jro_apps/redmine Commit - r10021:327660eb7f7e

Respond with 404 on ActionView::MissingTemplate (#11503)....

Jean-Philippe Lang -

r10021:327660eb7f7e

parent child

Context file:

r10021:327660eb7f7e

app/controllers/application_controller.rb +10 -5

                rescue_from ActionController::InvalidAuthenticityToken, :with => :invalid_authenticity_token
                rescue_from ::Unauthorized, :with => :deny_access
+               rescue_from ::ActionView::MissingTemplate, :with => :missing_template
                include Redmine::Search::Controller
                include Redmine::MenuManager::MenuController
                    format.html {
                      render :template => 'common/error', :layout => use_layout, :status => @status
                    }
-                   format.atom { head @status }
-                   format.xml { head @status }
-                   format.js { head @status }
-                   format.json { head @status }
+                   format.any { head @status }
                  end
                end
+               # Handler for ActionView::MissingTemplate exception
+               def missing_template
+                 logger.warn "Missing template, responding with 404"
+                 @project = nil
+                 render_404
+               end
                # Filter for actions that provide an API response
                # but have no HTML representation for non admin users
                def require_admin_or_api_request

test/integration/application_test.rb +5 0

                  assert_response 200
                  assert_nil session[:user_id]
                end
+               def test_missing_template_should_respond_with_404
+                 get '/login.png'
+                 assert_response 404
+               end
              end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages