jro_apps/redmine Commit - r11726:32464f491251

Perf: don't load all projects....

Jean-Philippe Lang -

r11726:32464f491251

parent child

Context file:

r11726:32464f491251

Collapse all files

app/models/issue.rb +6 -7

                   if issue.new_record?
                     issue.copy?
                   elsif user.allowed_to?(:move_issues, issue.project)
-                    projects = Issue.allowed_target_projects_on_move(user)
+                    Issue.allowed_target_projects_on_move.count > 1
-                    projects.include?(issue.project) && projects.size > 1
                   end
                 }
                 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
-                  if allowed_target_projects(user).collect(&:id).include?(p.to_i)
+                  if allowed_target_projects(user).where(:id => p.to_i).exists?
                     self.project_id = p
                   end
                 end
               end
               # End ReportsController extraction
-              # Returns an array of projects that user can assign the issue to
+              # Returns a scope of projects that user can assign the issue to
               def allowed_target_projects(user=User.current)
                 if new_record?
-                  Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
+                  Project.where(Project.allowed_to_condition(user, :add_issues))
                 else
                   self.class.allowed_target_projects_on_move(user)
                 end
               end
-              # Returns an array of projects that user can move issues to
+              # Returns a scope of projects that user can move issues to
               def self.allowed_target_projects_on_move(user=User.current)
-                Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
+                Project.where(Project.allowed_to_condition(user, :move_issues))
               end
               private

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages