jro_apps/redmine Commit - r665:317b460d9652

Some deprecation fixes (end_form_tag and count API)....

Jean-Philippe Lang -

r665:317b460d9652

parent child

Context file:

r665:317b460d9652

app/helpers/projects_helper.rb +4 -4

               def new_issue_selector
                 trackers = Tracker.find(:all, :order => 'position')
-                form_tag({:controller => 'projects', :action => 'add_issue', :id => @project}, :method => :get) +
+                # can't use form tag inside helper
-                  select_tag('tracker_id', '<option></option' + options_from_collection_for_select(trackers, 'id', 'name'),
+                content_tag('form',
-                    :onchange => "if (this.value != '') {this.form.submit()}") +
+                  select_tag('tracker_id', '<option></option' + options_from_collection_for_select(trackers, 'id', 'name'), :onchange => "if (this.value != '') {this.form.submit()}"),
-                  end_form_tag
+                  :action => url_for(:controller => 'projects', :action => 'add_issue', :id => @project), :method => 'get')
               end
             end

app/views/account/show.rhtml +1 -1

             <h3><%=l(:label_activity)%></h3>
             <p>
-            <%=l(:label_reported_issues)%>: <%= Issue.count(["author_id=?", @user.id]) %>
+            <%=l(:label_reported_issues)%>: <%= Issue.count(:conditions => ["author_id=?", @user.id]) %>
             </p>

app/views/roles/report.rhtml +2 -2

             <h2><%=l(:label_permissions_report)%></h2>
-            <%= start_form_tag({:action => 'report'}, :id => 'permissions_form') %>
+            <% form_tag({:action => 'report'}, :id => 'permissions_form') do %>
             <%= hidden_field_tag 'permissions[0]', '' %>
             <table class="list">
             <thead>
             </table>
             <p><%= check_all_links 'permissions_form' %></p>
             <p><%= submit_tag l(:button_save) %></p>
-            <%= end_form_tag %>
+            <% end %>

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages