jro_apps/redmine Commit - r15791:309c6cec861b

Don't preload custom field filter values (#24787)....

Jean-Philippe Lang -

r15791:309c6cec861b

parent child

Context file:

r15791:309c6cec861b

Collapse all files

app/models/query.rb 0 -5

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class QueryColumn
                attr_accessor :name, :sortable, :groupable, :totalable, :default_order
                include Redmine::I18n
                def initialize(name, options={})
                  self.name = name
                  self.sortable = options[:sortable]
                  self.groupable = options[:groupable] || false
                  if groupable == true
                    self.groupable = name.to_s
                  end
                  self.totalable = options[:totalable] || false
                  self.default_order = options[:default_order]
                  @inline = options.key?(:inline) ? options[:inline] : true
                  @caption_key = options[:caption] || "field_#{name}".to_sym
                  @frozen = options[:frozen]
                end
                def caption
                  case @caption_key
                  when Symbol
                    l(@caption_key)
                  when Proc
                    @caption_key.call
                  else
                    @caption_key
                  end
                end
                # Returns true if the column is sortable, otherwise false
                def sortable?
                  !@sortable.nil?
                end
                def sortable
                  @sortable.is_a?(Proc) ? @sortable.call : @sortable
                end
                def inline?
                  @inline
                end
                def frozen?
                  @frozen
                end
                def value(object)
                  object.send name
                end
                def value_object(object)
                  object.send name
                end
                def css_classes
                  name
                end
              end
              class QueryAssociationColumn < QueryColumn
                def initialize(association, attribute, options={})
                  @association = association
                  @attribute = attribute
                  name_with_assoc = "#{association}.#{attribute}".to_sym
                  super(name_with_assoc, options)
                end
                def value_object(object)
                  if assoc = object.send(@association)
                    assoc.send @attribute
                  end
                end
                def css_classes
                  @css_classes ||= "#{@association}-#{@attribute}"
                end
              end
              class QueryCustomFieldColumn < QueryColumn
                def initialize(custom_field, options={})
                  self.name = "cf_#{custom_field.id}".to_sym
                  self.sortable = custom_field.order_statement || false
                  self.groupable = custom_field.group_statement || false
                  self.totalable = options.key?(:totalable) ? !!options[:totalable] : custom_field.totalable?
                  @inline = true
                  @cf = custom_field
                end
                def caption
                  @cf.name
                end
                def custom_field
                  @cf
                end
                def value_object(object)
                  if custom_field.visible_by?(object.project, User.current)
                    cv = object.custom_values.select {|v| v.custom_field_id == @cf.id}
                    cv.size > 1 ? cv.sort {|a,b| a.value.to_s <=> b.value.to_s} : cv.first
                  else
                    nil
                  end
                end
                def value(object)
                  raw = value_object(object)
                  if raw.is_a?(Array)
                    raw.map {|r| @cf.cast_value(r.value)}
                  elsif raw
                    @cf.cast_value(raw.value)
                  else
                    nil
                  end
                end
                def css_classes
                  @css_classes ||= "#{name} #{@cf.field_format}"
                end
              end
              class QueryAssociationCustomFieldColumn < QueryCustomFieldColumn
                def initialize(association, custom_field, options={})
                  super(custom_field, options)
                  self.name = "#{association}.cf_#{custom_field.id}".to_sym
                  # TODO: support sorting/grouping by association custom field
                  self.sortable = false
                  self.groupable = false
                  @association = association
                end
                def value_object(object)
                  if assoc = object.send(@association)
                    super(assoc)
                  end
                end
                def css_classes
                  @css_classes ||= "#{@association}_cf_#{@cf.id} #{@cf.field_format}"
                end
              end
              class QueryFilter
                include Redmine::I18n
                def initialize(field, options)
                  @field = field.to_s
                  @options = options
                  @options[:name] ||= l(options[:label] || "field_#{field}".gsub(/_id$/, ''))
                  # Consider filters with a Proc for values as remote by default
                  @remote = options.key?(:remote) ? options[:remote] : options[:values].is_a?(Proc)
                end
                def [](arg)
                  if arg == :values
                    values
                  else
                    @options[arg]
                  end
                end
                def values
                  @values ||= begin
                    values = @options[:values]
                    if values.is_a?(Proc)
                      values = values.call
                    end
                    values
                  end
                end
                def remote
                  @remote
                end
              end
              class Query < ActiveRecord::Base
                class StatementInvalid < ::ActiveRecord::StatementInvalid
                end
                include Redmine::SubclassFactory
                VISIBILITY_PRIVATE = 0
                VISIBILITY_ROLES   = 1
                VISIBILITY_PUBLIC  = 2
                belongs_to :project
                belongs_to :user
                has_and_belongs_to_many :roles, :join_table => "#{table_name_prefix}queries_roles#{table_name_suffix}", :foreign_key => "query_id"
                serialize :filters
                serialize :column_names
                serialize :sort_criteria, Array
                serialize :options, Hash
                attr_protected :project_id, :user_id
                validates_presence_of :name
                validates_length_of :name, :maximum => 255
                validates :visibility, :inclusion => { :in => [VISIBILITY_PUBLIC, VISIBILITY_ROLES, VISIBILITY_PRIVATE] }
                validate :validate_query_filters
                validate do |query|
                  errors.add(:base, l(:label_role_plural) + ' ' + l('activerecord.errors.messages.blank')) if query.visibility == VISIBILITY_ROLES && roles.blank?
                end
                after_save do |query|
                  if query.visibility_changed? && query.visibility != VISIBILITY_ROLES
                    query.roles.clear
                  end
                end
                class_attribute :operators
                self.operators = {
                  "="   => :label_equals,
                  "!"   => :label_not_equals,
                  "o"   => :label_open_issues,
                  "c"   => :label_closed_issues,
                  "!*"  => :label_none,
                  "*"   => :label_any,
                  ">="  => :label_greater_or_equal,
                  "<="  => :label_less_or_equal,
                  "><"  => :label_between,
                  "<t+" => :label_in_less_than,
                  ">t+" => :label_in_more_than,
                  "><t+"=> :label_in_the_next_days,
                  "t+"  => :label_in,
                  "t"   => :label_today,
                  "ld"  => :label_yesterday,
                  "w"   => :label_this_week,
                  "lw"  => :label_last_week,
                  "l2w" => [:label_last_n_weeks, {:count => 2}],
                  "m"   => :label_this_month,
                  "lm"  => :label_last_month,
                  "y"   => :label_this_year,
                  ">t-" => :label_less_than_ago,
                  "<t-" => :label_more_than_ago,
                  "><t-"=> :label_in_the_past_days,
                  "t-"  => :label_ago,
                  "~"   => :label_contains,
                  "!~"  => :label_not_contains,
                  "=p"  => :label_any_issues_in_project,
                  "=!p" => :label_any_issues_not_in_project,
                  "!p"  => :label_no_issues_in_project,
                  "*o"  => :label_any_open_issues,
                  "!o"  => :label_no_open_issues
                }
                class_attribute :operators_by_filter_type
                self.operators_by_filter_type = {
                  :list => [ "=", "!" ],
                  :list_status => [ "o", "=", "!", "c", "*" ],
                  :list_optional => [ "=", "!", "!*", "*" ],
                  :list_subprojects => [ "*", "!*", "=" ],
                  :date => [ "=", ">=", "<=", "><", "<t+", ">t+", "><t+", "t+", "t", "ld", "w", "lw", "l2w", "m", "lm", "y", ">t-", "<t-", "><t-", "t-", "!*", "*" ],
                  :date_past => [ "=", ">=", "<=", "><", ">t-", "<t-", "><t-", "t-", "t", "ld", "w", "lw", "l2w", "m", "lm", "y", "!*", "*" ],
                  :string => [ "=", "~", "!", "!~", "!*", "*" ],
                  :text => [  "~", "!~", "!*", "*" ],
                  :integer => [ "=", ">=", "<=", "><", "!*", "*" ],
                  :float => [ "=", ">=", "<=", "><", "!*", "*" ],
                  :relation => ["=", "=p", "=!p", "!p", "*o", "!o", "!*", "*"],
                  :tree => ["=", "~", "!*", "*"]
                }
                class_attribute :available_columns
                self.available_columns = []
                class_attribute :queried_class
                # Permission required to view the queries, set on subclasses.
                class_attribute :view_permission
                # Scope of queries that are global or on the given project
                scope :global_or_on_project, lambda {|project|
                  where(:project_id => (project.nil? ? nil : [nil, project.id]))
                }
                scope :sorted, lambda {order(:name, :id)}
                # Scope of visible queries, can be used from subclasses only.
                # Unlike other visible scopes, a class methods is used as it
                # let handle inheritance more nicely than scope DSL.
                def self.visible(*args)
                  if self == ::Query
                    # Visibility depends on permissions for each subclass,
                    # raise an error if the scope is called from Query (eg. Query.visible)
                    raise Exception.new("Cannot call .visible scope from the base Query class, but from subclasses only.")
                  end
                  user = args.shift || User.current
                  base = Project.allowed_to_condition(user, view_permission, *args)
                  scope = joins("LEFT OUTER JOIN #{Project.table_name} ON #{table_name}.project_id = #{Project.table_name}.id").
                    where("#{table_name}.project_id IS NULL OR (#{base})")
                  if user.admin?
                    scope.where("#{table_name}.visibility <> ? OR #{table_name}.user_id = ?", VISIBILITY_PRIVATE, user.id)
                  elsif user.memberships.any?
                    scope.where("#{table_name}.visibility = ?" +
                      " OR (#{table_name}.visibility = ? AND #{table_name}.id IN (" +
                        "SELECT DISTINCT q.id FROM #{table_name} q" +
                        " INNER JOIN #{table_name_prefix}queries_roles#{table_name_suffix} qr on qr.query_id = q.id" +
                        " INNER JOIN #{MemberRole.table_name} mr ON mr.role_id = qr.role_id" +
                        " INNER JOIN #{Member.table_name} m ON m.id = mr.member_id AND m.user_id = ?" +
                        " WHERE q.project_id IS NULL OR q.project_id = m.project_id))" +
                      " OR #{table_name}.user_id = ?",
                      VISIBILITY_PUBLIC, VISIBILITY_ROLES, user.id, user.id)
                  elsif user.logged?
                    scope.where("#{table_name}.visibility = ? OR #{table_name}.user_id = ?", VISIBILITY_PUBLIC, user.id)
                  else
                    scope.where("#{table_name}.visibility = ?", VISIBILITY_PUBLIC)
                  end
                end
                # Returns true if the query is visible to +user+ or the current user.
                def visible?(user=User.current)
                  return true if user.admin?
                  return false unless project.nil? || user.allowed_to?(self.class.view_permission, project)
                  case visibility
                  when VISIBILITY_PUBLIC
                    true
                  when VISIBILITY_ROLES
                    if project
                      (user.roles_for_project(project) & roles).any?
                    else
                      Member.where(:user_id => user.id).joins(:roles).where(:member_roles => {:role_id => roles.map(&:id)}).any?
                    end
                  else
                    user == self.user
                  end
                end
                def is_private?
                  visibility == VISIBILITY_PRIVATE
                end
                def is_public?
                  !is_private?
                end
                def queried_table_name
                  @queried_table_name ||= self.class.queried_class.table_name
                end
                def initialize(attributes=nil, *args)
                  super attributes
                  @is_for_all = project.nil?
                end
                # Builds the query from the given params
                def build_from_params(params)
                  if params[:fields] || params[:f]
                    self.filters = {}
                    add_filters(params[:fields] || params[:f], params[:operators] || params[:op], params[:values] || params[:v])
                  else
                    available_filters.keys.each do |field|
                      add_short_filter(field, params[field]) if params[field]
                    end
                  end
                  self.group_by = params[:group_by] || (params[:query] && params[:query][:group_by])
                  self.column_names = params[:c] || (params[:query] && params[:query][:column_names])
                  self.totalable_names = params[:t] || (params[:query] && params[:query][:totalable_names])
                  self
                end
                # Builds a new query from the given params and attributes
                def self.build_from_params(params, attributes={})
                  new(attributes).build_from_params(params)
                end
                def validate_query_filters
                  filters.each_key do |field|
                    if values_for(field)
                      case type_for(field)
                      when :integer
                        add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/\A[+-]?\d+(,[+-]?\d+)*\z/) }
                      when :float
                        add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/\A[+-]?\d+(\.\d*)?\z/) }
                      when :date, :date_past
                        case operator_for(field)
                        when "=", ">=", "<=", "><"
                          add_filter_error(field, :invalid) if values_for(field).detect {|v|
                            v.present? && (!v.match(/\A\d{4}-\d{2}-\d{2}(T\d{2}((:)?\d{2}){0,2}(Z|\d{2}:?\d{2})?)?\z/) || parse_date(v).nil?)
                          }
                        when ">t-", "<t-", "t-", ">t+", "<t+", "t+", "><t+", "><t-"
                          add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^\d+$/) }
                        end
                      end
                    end
                    add_filter_error(field, :blank) unless
                        # filter requires one or more values
                        (values_for(field) and !values_for(field).first.blank?) or
                        # filter doesn't require any value
                        ["o", "c", "!*", "*", "t", "ld", "w", "lw", "l2w", "m", "lm", "y", "*o", "!o"].include? operator_for(field)
                  end if filters
                end
                def add_filter_error(field, message)
                  m = label_for(field) + " " + l(message, :scope => 'activerecord.errors.messages')
                  errors.add(:base, m)
                end
                def editable_by?(user)
                  return false unless user
                  # Admin can edit them all and regular users can edit their private queries
                  return true if user.admin? || (is_private? && self.user_id == user.id)
                  # Members can not edit public queries that are for all project (only admin is allowed to)
                  is_public? && !@is_for_all && user.allowed_to?(:manage_public_queries, project)
                end
                def trackers
                  @trackers ||= (project.nil? ? Tracker.all : project.rolled_up_trackers).visible.sorted
                end
                # Returns a hash of localized labels for all filter operators
                def self.operators_labels
                  operators.inject({}) {|h, operator| h[operator.first] = l(*operator.last); h}
                end
                # Returns a representation of the available filters for JSON serialization
                def available_filters_as_json
                  json = {}
                  available_filters.each do |field, filter|
                    options = {:type => filter[:type], :name => filter[:name]}
                    options[:remote] = true if filter.remote
                    if has_filter?(field) || !filter.remote
                      options[:values] = filter.values
                      if options[:values] && values_for(field)
                        missing = Array(values_for(field)).select(&:present?) - options[:values].map(&:last)
                        if missing.any? && respond_to?(method = "find_#{field}_filter_values")
                          options[:values] += send(method, missing)
                        end
                      end
                    end
                    json[field] = options.stringify_keys
                  end
                  json
                end
                def all_projects
                  @all_projects ||= Project.visible.to_a
                end
                def all_projects_values
                  return @all_projects_values if @all_projects_values
                  values = []
                  Project.project_tree(all_projects) do |p, level|
                    prefix = (level > 0 ? ('--' * level + ' ') : '')
                    values << ["#{prefix}#{p.name}", p.id.to_s]
                  end
                  @all_projects_values = values
                end
                def project_values
                  project_values = []
                  if User.current.logged? && User.current.memberships.any?
                    project_values << ["<< #{l(:label_my_projects).downcase} >>", "mine"]
                  end
                  project_values += all_projects_values
                  project_values
                end
                def subproject_values
                  project.descendants.visible.collect{|s| [s.name, s.id.to_s] }
                end
                def principals
                  @principal ||= begin
                    principals = []
                    if project
                      principals += project.principals.visible
                      unless project.leaf?
                        principals += Principal.member_of(project.descendants.visible).visible
                      end
                    else
                      principals += Principal.member_of(all_projects).visible
                    end
                    principals.uniq!
                    principals.sort!
                    principals.reject! {|p| p.is_a?(GroupBuiltin)}
                    principals
                  end
                end
                def users
                  principals.select {|p| p.is_a?(User)}
                end
                def author_values
                  author_values = []
                  author_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
                  author_values += users.collect{|s| [s.name, s.id.to_s] }
                  author_values
                end
                def assigned_to_values
                  assigned_to_values = []
                  assigned_to_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
                  assigned_to_values += (Setting.issue_group_assignment? ? principals : users).collect{|s| [s.name, s.id.to_s] }
                  assigned_to_values
                end
                def fixed_version_values
                  versions = []
                  if project
                    versions = project.shared_versions.to_a
                  else
                    versions = Version.visible.where(:sharing => 'system').to_a
                  end
                  Version.sort_by_status(versions).collect{|s| ["#{s.project.name} - #{s.name}", s.id.to_s, l("version_status_#{s.status}")] }
                end
                # Adds available filters
                def initialize_available_filters
                  # implemented by sub-classes
                end
                protected :initialize_available_filters
                # Adds an available filter
                def add_available_filter(field, options)
                  @available_filters ||= ActiveSupport::OrderedHash.new
                  @available_filters[field] = QueryFilter.new(field, options)
                  @available_filters
                end
                # Removes an available filter
                def delete_available_filter(field)
                  if @available_filters
                    @available_filters.delete(field)
                  end
                end
                # Return a hash of available filters
                def available_filters
                  unless @available_filters
                    initialize_available_filters
                    @available_filters ||= {}
                  end
                  @available_filters
                end
                def add_filter(field, operator, values=nil)
                  # values must be an array
                  return unless values.nil? || values.is_a?(Array)
                  # check if field is defined as an available filter
                  if available_filters.has_key? field
                    filter_options = available_filters[field]
                    filters[field] = {:operator => operator, :values => (values || [''])}
                  end
                end
                def add_short_filter(field, expression)
                  return unless expression && available_filters.has_key?(field)
                  field_type = available_filters[field][:type]
                  operators_by_filter_type[field_type].sort.reverse.detect do |operator|
                    next unless expression =~ /^#{Regexp.escape(operator)}(.*)$/
                    values = $1
                    add_filter field, operator, values.present? ? values.split('|') : ['']
                  end || add_filter(field, '=', expression.to_s.split('|'))
                end
                # Add multiple filters using +add_filter+
                def add_filters(fields, operators, values)
                  if fields.is_a?(Array) && operators.is_a?(Hash) && (values.nil? || values.is_a?(Hash))
                    fields.each do |field|
                      add_filter(field, operators[field], values && values[field])
                    end
                  end
                end
                def has_filter?(field)
                  filters and filters[field]
                end
                def type_for(field)
                  available_filters[field][:type] if available_filters.has_key?(field)
                end
                def operator_for(field)
                  has_filter?(field) ? filters[field][:operator] : nil
                end
                def values_for(field)
                  has_filter?(field) ? filters[field][:values] : nil
                end
                def value_for(field, index=0)
                  (values_for(field) || [])[index]
                end
                def label_for(field)
                  label = available_filters[field][:name] if available_filters.has_key?(field)
                  label ||= queried_class.human_attribute_name(field, :default => field)
                end
                def self.add_available_column(column)
                  self.available_columns << (column) if column.is_a?(QueryColumn)
                end
                # Returns an array of columns that can be used to group the results
                def groupable_columns
                  available_columns.select {|c| c.groupable}
                end
                # Returns a Hash of columns and the key for sorting
                def sortable_columns
                  available_columns.inject({}) {|h, column|
                    h[column.name.to_s] = column.sortable
                    h
                  }
                end
                def columns
                  # preserve the column_names order
                  cols = (has_default_columns? ? default_columns_names : column_names).collect do |name|
                     available_columns.find { |col| col.name == name }
                  end.compact
                  available_columns.select(&:frozen?) | cols
                end
                def inline_columns
                  columns.select(&:inline?)
                end
                def block_columns
                  columns.reject(&:inline?)
                end
                def available_inline_columns
                  available_columns.select(&:inline?)
                end
                def available_block_columns
                  available_columns.reject(&:inline?)
                end
                def available_totalable_columns
                  available_columns.select(&:totalable)
                end
                def default_columns_names
                  []
                end
                def default_totalable_names
                  []
                end
                def column_names=(names)
                  if names
                    names = names.select {|n| n.is_a?(Symbol) || !n.blank? }
                    names = names.collect {|n| n.is_a?(Symbol) ? n : n.to_sym }
                    # Set column_names to nil if default columns
                    if names == default_columns_names
                      names = nil
                    end
                  end
                  write_attribute(:column_names, names)
                end
                def has_column?(column)
                  column_names && column_names.include?(column.is_a?(QueryColumn) ? column.name : column)
                end
                def has_custom_field_column?
                  columns.any? {|column| column.is_a? QueryCustomFieldColumn}
                end
                def has_default_columns?
                  column_names.nil? || column_names.empty?
                end
                def totalable_columns
                  names = totalable_names
                  available_totalable_columns.select {|column| names.include?(column.name)}
                end
                def totalable_names=(names)
                  if names
                    names = names.select(&:present?).map {|n| n.is_a?(Symbol) ? n : n.to_sym}
                  end
                  options[:totalable_names] = names
                end
                def totalable_names
                  options[:totalable_names] || default_totalable_names || []
                end
                def sort_criteria=(arg)
                  c = []
                  if arg.is_a?(Hash)
                    arg = arg.keys.sort.collect {|k| arg[k]}
                  end
                  if arg
                    c = arg.select {|k,o| !k.to_s.blank?}.slice(0,3).collect {|k,o| [k.to_s, (o == 'desc' || o == false) ? 'desc' : 'asc']}
                  end
                  write_attribute(:sort_criteria, c)
                end
                def sort_criteria
                  read_attribute(:sort_criteria) || []
                end
                def sort_criteria_key(arg)
                  sort_criteria && sort_criteria[arg] && sort_criteria[arg].first
                end
                def sort_criteria_order(arg)
                  sort_criteria && sort_criteria[arg] && sort_criteria[arg].last
                end
                def sort_criteria_order_for(key)
                  sort_criteria.detect {|k, order| key.to_s == k}.try(:last)
                end
                # Returns the SQL sort order that should be prepended for grouping
                def group_by_sort_order
                  if column = group_by_column
                    order = (sort_criteria_order_for(column.name) || column.default_order || 'asc').try(:upcase)
                    Array(column.sortable).map {|s| "#{s} #{order}"}
                  end
                end
                # Returns true if the query is a grouped query
                def grouped?
                  !group_by_column.nil?
                end
                def group_by_column
                  groupable_columns.detect {|c| c.groupable && c.name.to_s == group_by}
                end
                def group_by_statement
                  group_by_column.try(:groupable)
                end
                def project_statement
                  project_clauses = []
                  if project && !project.descendants.active.empty?
                    if has_filter?("subproject_id")
                      case operator_for("subproject_id")
                      when '='
                        # include the selected subprojects
                        ids = [project.id] + values_for("subproject_id").each(&:to_i)
                        project_clauses << "#{Project.table_name}.id IN (%s)" % ids.join(',')
                      when '!*'
                        # main project only
                        project_clauses << "#{Project.table_name}.id = %d" % project.id
                      else
                        # all subprojects
                        project_clauses << "#{Project.table_name}.lft >= #{project.lft} AND #{Project.table_name}.rgt <= #{project.rgt}"
                      end
                    elsif Setting.display_subprojects_issues?
                      project_clauses << "#{Project.table_name}.lft >= #{project.lft} AND #{Project.table_name}.rgt <= #{project.rgt}"
                    else
                      project_clauses << "#{Project.table_name}.id = %d" % project.id
                    end
                  elsif project
                    project_clauses << "#{Project.table_name}.id = %d" % project.id
                  end
                  project_clauses.any? ? project_clauses.join(' AND ') : nil
                end
                def statement
                  # filters clauses
                  filters_clauses = []
                  filters.each_key do |field|
                    next if field == "subproject_id"
                    v = values_for(field).clone
                    next unless v and !v.empty?
                    operator = operator_for(field)
                    # "me" value substitution
                    if %w(assigned_to_id author_id user_id watcher_id).include?(field)
                      if v.delete("me")
                        if User.current.logged?
                          v.push(User.current.id.to_s)
                          v += User.current.group_ids.map(&:to_s) if field == 'assigned_to_id'
                        else
                          v.push("0")
                        end
                      end
                    end
                    if field == 'project_id'
                      if v.delete('mine')
                        v += User.current.memberships.map(&:project_id).map(&:to_s)
                      end
                    end
                    if field =~ /cf_(\d+)$/
                      # custom field
                      filters_clauses << sql_for_custom_field(field, operator, v, $1)
                    elsif respond_to?(method = "sql_for_#{field.gsub('.','_')}_field")
                      # specific statement
                      filters_clauses << send(method, field, operator, v)
                    else
                      # regular field
                      filters_clauses << '(' + sql_for_field(field, operator, v, queried_table_name, field) + ')'
                    end
                  end if filters and valid?
                  if (c = group_by_column) && c.is_a?(QueryCustomFieldColumn)
                    # Excludes results for which the grouped custom field is not visible
                    filters_clauses << c.custom_field.visibility_by_project_condition
                  end
                  filters_clauses << project_statement
                  filters_clauses.reject!(&:blank?)
                  filters_clauses.any? ? filters_clauses.join(' AND ') : nil
                end
                # Returns the sum of values for the given column
                def total_for(column)
                  total_with_scope(column, base_scope)
                end
                # Returns a hash of the sum of the given column for each group,
                # or nil if the query is not grouped
                def total_by_group_for(column)
                  grouped_query do |scope|
                    total_with_scope(column, scope)
                  end
                end
                def totals
                  totals = totalable_columns.map {|column| [column, total_for(column)]}
                  yield totals if block_given?
                  totals
                end
                def totals_by_group
                  totals = totalable_columns.map {|column| [column, total_by_group_for(column)]}
                  yield totals if block_given?
                  totals
                end
                private
                def grouped_query(&block)
                  r = nil
                  if grouped?
                    begin
                      # Rails3 will raise an (unexpected) RecordNotFound if there's only a nil group value
                      r = yield base_group_scope
                    rescue ActiveRecord::RecordNotFound
                      r = {nil => yield(base_scope)}
                    end
                    c = group_by_column
                    if c.is_a?(QueryCustomFieldColumn)
                      r = r.keys.inject({}) {|h, k| h[c.custom_field.cast_value(k)] = r[k]; h}
                    end
                  end
                  r
                rescue ::ActiveRecord::StatementInvalid => e
                  raise StatementInvalid.new(e.message)
                end
                def total_with_scope(column, scope)
                  unless column.is_a?(QueryColumn)
                    column = column.to_sym
                    column = available_totalable_columns.detect {|c| c.name == column}
                  end
                  if column.is_a?(QueryCustomFieldColumn)
                    custom_field = column.custom_field
                    send "total_for_custom_field", custom_field, scope
                  else
                    send "total_for_#{column.name}", scope
                  end
                rescue ::ActiveRecord::StatementInvalid => e
                  raise StatementInvalid.new(e.message)
                end
                def base_scope
                  raise "unimplemented"
                end
                def base_group_scope
                  base_scope.
                    joins(joins_for_order_statement(group_by_statement)).
                    group(group_by_statement)
                end
                def total_for_custom_field(custom_field, scope, &block)
                  total = custom_field.format.total_for_scope(custom_field, scope)
                  total = map_total(total) {|t| custom_field.format.cast_total_value(custom_field, t)}
                  total
                end
                def map_total(total, &block)
                  if total.is_a?(Hash)
                    total.keys.each {|k| total[k] = yield total[k]}
                  else
                    total = yield total
                  end
                  total
                end
                def sql_for_custom_field(field, operator, value, custom_field_id)
                  db_table = CustomValue.table_name
                  db_field = 'value'
                  filter = @available_filters[field]
                  return nil unless filter
                  if filter[:field].format.target_class && filter[:field].format.target_class <= User
                    if value.delete('me')
                      value.push User.current.id.to_s
                    end
                  end
                  not_in = nil
                  if operator == '!'
                    # Makes ! operator work for custom fields with multiple values
                    operator = '='
                    not_in = 'NOT'
                  end
                  customized_key = "id"
                  customized_class = queried_class
                  if field =~ /^(.+)\.cf_/
                    assoc = $1
                    customized_key = "#{assoc}_id"
                    customized_class = queried_class.reflect_on_association(assoc.to_sym).klass.base_class rescue nil
                    raise "Unknown #{queried_class.name} association #{assoc}" unless customized_class
                  end
                  where = sql_for_field(field, operator, value, db_table, db_field, true)
                  if operator =~ /[<>]/
                    where = "(#{where}) AND #{db_table}.#{db_field} <> ''"
                  end
                  "#{queried_table_name}.#{customized_key} #{not_in} IN (" +
                    "SELECT #{customized_class.table_name}.id FROM #{customized_class.table_name}" +
                    " LEFT OUTER JOIN #{db_table} ON #{db_table}.customized_type='#{customized_class}' AND #{db_table}.customized_id=#{customized_class.table_name}.id AND #{db_table}.custom_field_id=#{custom_field_id}" +
                    " WHERE (#{where}) AND (#{filter[:field].visibility_by_project_condition}))"
                end
                # Helper method to generate the WHERE sql for a +field+, +operator+ and a +value+
                def sql_for_field(field, operator, value, db_table, db_field, is_custom_filter=false)
                  sql = ''
                  case operator
                  when "="
                    if value.any?
                      case type_for(field)
                      when :date, :date_past
                        sql = date_clause(db_table, db_field, parse_date(value.first), parse_date(value.first), is_custom_filter)
                      when :integer
                        int_values = value.first.to_s.scan(/[+-]?\d+/).map(&:to_i).join(",")
                        if int_values.present?
                          if is_custom_filter
                            sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) IN (#{int_values}))"
                          else
                            sql = "#{db_table}.#{db_field} IN (#{int_values})"
                          end
                        else
                          sql = "1=0"
                        end
                      when :float
                        if is_custom_filter
                          sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5})"
                        else
                          sql = "#{db_table}.#{db_field} BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5}"
                        end
                      else
                        sql = queried_class.send(:sanitize_sql_for_conditions, ["#{db_table}.#{db_field} IN (?)", value])
                      end
                    else
                      # IN an empty set
                      sql = "1=0"
                    end
                  when "!"
                    if value.any?
                      sql = queried_class.send(:sanitize_sql_for_conditions, ["(#{db_table}.#{db_field} IS NULL OR #{db_table}.#{db_field} NOT IN (?))", value])
                    else
                      # NOT IN an empty set
                      sql = "1=1"
                    end
                  when "!*"
                    sql = "#{db_table}.#{db_field} IS NULL"
                    sql << " OR #{db_table}.#{db_field} = ''" if is_custom_filter
                  when "*"
                    sql = "#{db_table}.#{db_field} IS NOT NULL"
                    sql << " AND #{db_table}.#{db_field} <> ''" if is_custom_filter
                  when ">="
                    if [:date, :date_past].include?(type_for(field))
                      sql = date_clause(db_table, db_field, parse_date(value.first), nil, is_custom_filter)
                    else
                      if is_custom_filter
                        sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) >= #{value.first.to_f})"
                      else
                        sql = "#{db_table}.#{db_field} >= #{value.first.to_f}"
                      end
                    end
                  when "<="
                    if [:date, :date_past].include?(type_for(field))
                      sql = date_clause(db_table, db_field, nil, parse_date(value.first), is_custom_filter)
                    else
                      if is_custom_filter
                        sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) <= #{value.first.to_f})"
                      else
                        sql = "#{db_table}.#{db_field} <= #{value.first.to_f}"
                      end
                    end
                  when "><"
                    if [:date, :date_past].include?(type_for(field))
                      sql = date_clause(db_table, db_field, parse_date(value[0]), parse_date(value[1]), is_custom_filter)
                    else
                      if is_custom_filter
                        sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value[0].to_f} AND #{value[1].to_f})"
                      else
                        sql = "#{db_table}.#{db_field} BETWEEN #{value[0].to_f} AND #{value[1].to_f}"
                      end
                    end
                  when "o"
                    sql = "#{queried_table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{self.class.connection.quoted_false})" if field == "status_id"
                  when "c"
                    sql = "#{queried_table_name}.status_id IN (SELECT id FROM #{IssueStatus.table_name} WHERE is_closed=#{self.class.connection.quoted_true})" if field == "status_id"
                  when "><t-"
                    # between today - n days and today
                    sql = relative_date_clause(db_table, db_field, - value.first.to_i, 0, is_custom_filter)
                  when ">t-"
                    # >= today - n days
                    sql = relative_date_clause(db_table, db_field, - value.first.to_i, nil, is_custom_filter)
                  when "<t-"
                    # <= today - n days
                    sql = relative_date_clause(db_table, db_field, nil, - value.first.to_i, is_custom_filter)
                  when "t-"
                    # = n days in past
                    sql = relative_date_clause(db_table, db_field, - value.first.to_i, - value.first.to_i, is_custom_filter)
                  when "><t+"
                    # between today and today + n days
                    sql = relative_date_clause(db_table, db_field, 0, value.first.to_i, is_custom_filter)
                  when ">t+"
                    # >= today + n days
                    sql = relative_date_clause(db_table, db_field, value.first.to_i, nil, is_custom_filter)
                  when "<t+"
                    # <= today + n days
                    sql = relative_date_clause(db_table, db_field, nil, value.first.to_i, is_custom_filter)
                  when "t+"
                    # = today + n days
                    sql = relative_date_clause(db_table, db_field, value.first.to_i, value.first.to_i, is_custom_filter)
                  when "t"
                    # = today
                    sql = relative_date_clause(db_table, db_field, 0, 0, is_custom_filter)
                  when "ld"
                    # = yesterday
                    sql = relative_date_clause(db_table, db_field, -1, -1, is_custom_filter)
                  when "w"
                    # = this week
                    first_day_of_week = l(:general_first_day_of_week).to_i
                    day_of_week = User.current.today.cwday
                    days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
                    sql = relative_date_clause(db_table, db_field, - days_ago, - days_ago + 6, is_custom_filter)
                  when "lw"
                    # = last week
                    first_day_of_week = l(:general_first_day_of_week).to_i
                    day_of_week = User.current.today.cwday
                    days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
                    sql = relative_date_clause(db_table, db_field, - days_ago - 7, - days_ago - 1, is_custom_filter)
                  when "l2w"
                    # = last 2 weeks
                    first_day_of_week = l(:general_first_day_of_week).to_i
                    day_of_week = User.current.today.cwday
                    days_ago = (day_of_week >= first_day_of_week ? day_of_week - first_day_of_week : day_of_week + 7 - first_day_of_week)
                    sql = relative_date_clause(db_table, db_field, - days_ago - 14, - days_ago - 1, is_custom_filter)
                  when "m"
                    # = this month
                    date = User.current.today
                    sql = date_clause(db_table, db_field, date.beginning_of_month, date.end_of_month, is_custom_filter)
                  when "lm"
                    # = last month
                    date = User.current.today.prev_month
                    sql = date_clause(db_table, db_field, date.beginning_of_month, date.end_of_month, is_custom_filter)
                  when "y"
                    # = this year
                    date = User.current.today
                    sql = date_clause(db_table, db_field, date.beginning_of_year, date.end_of_year, is_custom_filter)
                  when "~"
                    sql = sql_contains("#{db_table}.#{db_field}", value.first)
                  when "!~"
                    sql = sql_contains("#{db_table}.#{db_field}", value.first, false)
                  else
                    raise "Unknown query operator #{operator}"
                  end
                  return sql
                end
                # Returns a SQL LIKE statement with wildcards
                def sql_contains(db_field, value, match=true)
                  queried_class.send :sanitize_sql_for_conditions,
                    [Redmine::Database.like(db_field, '?', :match => match), "%#{value}%"]
                end
                # Adds a filter for the given custom field
                def add_custom_field_filter(field, assoc=nil)
                  options = field.query_filter_options(self)
-                 if field.format.target_class && field.format.target_class <= User
-                   if options[:values].is_a?(Array) && User.current.logged?
-                     options[:values].unshift ["<< #{l(:label_me)} >>", "me"]
-                   end
-                 end
                  filter_id = "cf_#{field.id}"
                  filter_name = field.name
                  if assoc.present?
                    filter_id = "#{assoc}.#{filter_id}"
                    filter_name = l("label_attribute_of_#{assoc}", :name => filter_name)
                  end
                  add_available_filter filter_id, options.merge({
                    :name => filter_name,
                    :field => field
                  })
                end
                # Adds filters for the given custom fields scope
                def add_custom_fields_filters(scope, assoc=nil)
                  scope.visible.where(:is_filter => true).sorted.each do |field|
                    add_custom_field_filter(field, assoc)
                  end
                end
                # Adds filters for the given associations custom fields
                def add_associations_custom_fields_filters(*associations)
                  fields_by_class = CustomField.visible.where(:is_filter => true).group_by(&:class)
                  associations.each do |assoc|
                    association_klass = queried_class.reflect_on_association(assoc).klass
                    fields_by_class.each do |field_class, fields|
                      if field_class.customized_class <= association_klass
                        fields.sort.each do |field|
                          add_custom_field_filter(field, assoc)
                        end
                      end
                    end
                  end
                end
                def quoted_time(time, is_custom_filter)
                  if is_custom_filter
                    # Custom field values are stored as strings in the DB
                    # using this format that does not depend on DB date representation
                    time.strftime("%Y-%m-%d %H:%M:%S")
                  else
                    self.class.connection.quoted_date(time)
                  end
                end
                def date_for_user_time_zone(y, m, d)
                  if tz = User.current.time_zone
                    tz.local y, m, d
                  else
                    Time.local y, m, d
                  end
                end
                # Returns a SQL clause for a date or datetime field.
                def date_clause(table, field, from, to, is_custom_filter)
                  s = []
                  if from
                    if from.is_a?(Date)
                      from = date_for_user_time_zone(from.year, from.month, from.day).yesterday.end_of_day
                    else
                      from = from - 1 # second
                    end
                    if self.class.default_timezone == :utc
                      from = from.utc
                    end
                    s << ("#{table}.#{field} > '%s'" % [quoted_time(from, is_custom_filter)])
                  end
                  if to
                    if to.is_a?(Date)
                      to = date_for_user_time_zone(to.year, to.month, to.day).end_of_day
                    end
                    if self.class.default_timezone == :utc
                      to = to.utc
                    end
                    s << ("#{table}.#{field} <= '%s'" % [quoted_time(to, is_custom_filter)])
                  end
                  s.join(' AND ')
                end
                # Returns a SQL clause for a date or datetime field using relative dates.
                def relative_date_clause(table, field, days_from, days_to, is_custom_filter)
                  date_clause(table, field, (days_from ? User.current.today + days_from : nil), (days_to ? User.current.today + days_to : nil), is_custom_filter)
                end
                # Returns a Date or Time from the given filter value
                def parse_date(arg)
                  if arg.to_s =~ /\A\d{4}-\d{2}-\d{2}T/
                    Time.parse(arg) rescue nil
                  else
                    Date.parse(arg) rescue nil
                  end
                end
                # Additional joins required for the given sort options
                def joins_for_order_statement(order_options)
                  joins = []
                  if order_options
                    if order_options.include?('authors')
                      joins << "LEFT OUTER JOIN #{User.table_name} authors ON authors.id = #{queried_table_name}.author_id"
                    end
                    order_options.scan(/cf_\d+/).uniq.each do |name|
                      column = available_columns.detect {|c| c.name.to_s == name}
                      join = column && column.custom_field.join_for_order_statement
                      if join
                        joins << join
                      end
                    end
                  end
                  joins.any? ? joins.join(' ') : nil
                end
              end

lib/redmine/field_format.rb +5 -1

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require 'uri'
              module Redmine
                module FieldFormat
                  def self.add(name, klass)
                    all[name.to_s] = klass.instance
                  end
                  def self.delete(name)
                    all.delete(name.to_s)
                  end
                  def self.all
                    @formats ||= Hash.new(Base.instance)
                  end
                  def self.available_formats
                    all.keys
                  end
                  def self.find(name)
                    all[name.to_s]
                  end
                  # Return an array of custom field formats which can be used in select_tag
                  def self.as_select(class_name=nil)
                    formats = all.values.select do |format|
                      format.class.customized_class_names.nil? || format.class.customized_class_names.include?(class_name)
                    end
                    formats.map {|format| [::I18n.t(format.label), format.name] }.sort_by(&:first)
                  end
                  # Returns an array of formats that can be used for a custom field class
                  def self.formats_for_custom_field_class(klass=nil)
                    all.values.select do |format|
                      format.class.customized_class_names.nil? || format.class.customized_class_names.include?(klass.name)
                    end
                  end
                  class Base
                    include Singleton
                    include Redmine::I18n
                    include Redmine::Helpers::URL
                    include ERB::Util
                    class_attribute :format_name
                    self.format_name = nil
                    # Set this to true if the format supports multiple values
                    class_attribute :multiple_supported
                    self.multiple_supported = false
                    # Set this to true if the format supports filtering on custom values
                    class_attribute :is_filter_supported
                    self.is_filter_supported = true
                    # Set this to true if the format supports textual search on custom values
                    class_attribute :searchable_supported
                    self.searchable_supported = false
                    # Set this to true if field values can be summed up
                    class_attribute :totalable_supported
                    self.totalable_supported = false
                    # Set this to false if field cannot be bulk edited
                    class_attribute :bulk_edit_supported
                    self.bulk_edit_supported = true
                    # Restricts the classes that the custom field can be added to
                    # Set to nil for no restrictions
                    class_attribute :customized_class_names
                    self.customized_class_names = nil
                    # Name of the partial for editing the custom field
                    class_attribute :form_partial
                    self.form_partial = nil
                    class_attribute :change_as_diff
                    self.change_as_diff = false
                    class_attribute :change_no_details
                    self.change_no_details = false
                    def self.add(name)
                      self.format_name = name
                      Redmine::FieldFormat.add(name, self)
                    end
                    private_class_method :add
                    def self.field_attributes(*args)
                      CustomField.store_accessor :format_store, *args
                    end
                    field_attributes :url_pattern
                    def name
                      self.class.format_name
                    end
                    def label
                      "label_#{name}"
                    end
                    def set_custom_field_value(custom_field, custom_field_value, value)
                      if value.is_a?(Array)
                        value = value.map(&:to_s).reject{|v| v==''}.uniq
                        if value.empty?
                          value << ''
                        end
                      else
                        value = value.to_s
                      end
                      value
                    end
                    def cast_custom_value(custom_value)
                      cast_value(custom_value.custom_field, custom_value.value, custom_value.customized)
                    end
                    def cast_value(custom_field, value, customized=nil)
                      if value.blank?
                        nil
                      elsif value.is_a?(Array)
                        casted = value.map do |v|
                          cast_single_value(custom_field, v, customized)
                        end
                        casted.compact.sort
                      else
                        cast_single_value(custom_field, value, customized)
                      end
                    end
                    def cast_single_value(custom_field, value, customized=nil)
                      value.to_s
                    end
                    def target_class
                      nil
                    end
                    def possible_custom_value_options(custom_value)
                      possible_values_options(custom_value.custom_field, custom_value.customized)
                    end
                    def possible_values_options(custom_field, object=nil)
                      []
                    end
                    def value_from_keyword(custom_field, keyword, object)
                      possible_values_options = possible_values_options(custom_field, object)
                      if possible_values_options.present?
                        keyword = keyword.to_s
                        if v = possible_values_options.detect {|text, id| keyword.casecmp(text)  == 0}
                          if v.is_a?(Array)
                            v.last
                          else
                            v
                          end
                        end
                      else
                        keyword
                      end
                    end
                    # Returns the validation errors for custom_field
                    # Should return an empty array if custom_field is valid
                    def validate_custom_field(custom_field)
                      errors = []
                      pattern = custom_field.url_pattern
                      if pattern.present? && !uri_with_safe_scheme?(url_pattern_without_tokens(pattern))
                        errors << [:url_pattern, :invalid]
                      end
                      errors
                    end
                    # Returns the validation error messages for custom_value
                    # Should return an empty array if custom_value is valid
                    # custom_value is a CustomFieldValue.
                    def validate_custom_value(custom_value)
                      values = Array.wrap(custom_value.value).reject {|value| value.to_s == ''}
                      errors = values.map do |value|
                        validate_single_value(custom_value.custom_field, value, custom_value.customized)
                      end
                      errors.flatten.uniq
                    end
                    def validate_single_value(custom_field, value, customized=nil)
                      []
                    end
                    # CustomValue after_save callback
                    def after_save_custom_value(custom_field, custom_value)
                    end
                    def formatted_custom_value(view, custom_value, html=false)
                      formatted_value(view, custom_value.custom_field, custom_value.value, custom_value.customized, html)
                    end
                    def formatted_value(view, custom_field, value, customized=nil, html=false)
                      casted = cast_value(custom_field, value, customized)
                      if html && custom_field.url_pattern.present?
                        texts_and_urls = Array.wrap(casted).map do |single_value|
                          text = view.format_object(single_value, false).to_s
                          url = url_from_pattern(custom_field, single_value, customized)
                          [text, url]
                        end
                        links = texts_and_urls.sort_by(&:first).map {|text, url| view.link_to_if uri_with_safe_scheme?(url), text, url}
                        links.join(', ').html_safe
                      else
                        casted
                      end
                    end
                    # Returns an URL generated with the custom field URL pattern
                    # and variables substitution:
                    # %value% => the custom field value
                    # %id% => id of the customized object
                    # %project_id% => id of the project of the customized object if defined
                    # %project_identifier% => identifier of the project of the customized object if defined
                    # %m1%, %m2%... => capture groups matches of the custom field regexp if defined
                    def url_from_pattern(custom_field, value, customized)
                      url = custom_field.url_pattern.to_s.dup
                      url.gsub!('%value%') {URI.encode value.to_s}
                      url.gsub!('%id%') {URI.encode customized.id.to_s}
                      url.gsub!('%project_id%') {URI.encode (customized.respond_to?(:project) ? customized.project.try(:id) : nil).to_s}
                      url.gsub!('%project_identifier%') {URI.encode (customized.respond_to?(:project) ? customized.project.try(:identifier) : nil).to_s}
                      if custom_field.regexp.present?
                        url.gsub!(%r{%m(\d+)%}) do
                          m = $1.to_i
                          if matches ||= value.to_s.match(Regexp.new(custom_field.regexp))
                            URI.encode matches[m].to_s
                          end
                        end
                      end
                      url
                    end
                    protected :url_from_pattern
                    # Returns the URL pattern with substitution tokens removed,
                    # for validation purpose
                    def url_pattern_without_tokens(url_pattern)
                      url_pattern.to_s.gsub(/%(value|id|project_id|project_identifier|m\d+)%/, '')
                    end
                    protected :url_pattern_without_tokens
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      view.text_field_tag(tag_name, custom_value.value, options.merge(:id => tag_id))
                    end
                    def bulk_edit_tag(view, tag_id, tag_name, custom_field, objects, value, options={})
                      view.text_field_tag(tag_name, value, options.merge(:id => tag_id)) +
                        bulk_clear_tag(view, tag_id, tag_name, custom_field, value)
                    end
                    def bulk_clear_tag(view, tag_id, tag_name, custom_field, value)
                      if custom_field.is_required?
                        ''.html_safe
                      else
                        view.content_tag('label',
                          view.check_box_tag(tag_name, '__none__', (value == '__none__'), :id => nil, :data => {:disables => "##{tag_id}"}) + l(:button_clear),
                          :class => 'inline'
                        )
                      end
                    end
                    protected :bulk_clear_tag
                    def query_filter_options(custom_field, query)
                      {:type => :string}
                    end
                    def before_custom_field_save(custom_field)
                    end
                    # Returns a ORDER BY clause that can used to sort customized
                    # objects by their value of the custom field.
                    # Returns nil if the custom field can not be used for sorting.
                    def order_statement(custom_field)
                      # COALESCE is here to make sure that blank and NULL values are sorted equally
                      "COALESCE(#{join_alias custom_field}.value, '')"
                    end
                    # Returns a GROUP BY clause that can used to group by custom value
                    # Returns nil if the custom field can not be used for grouping.
                    def group_statement(custom_field)
                      nil
                    end
                    # Returns a JOIN clause that is added to the query when sorting by custom values
                    def join_for_order_statement(custom_field)
                      alias_name = join_alias(custom_field)
                      "LEFT OUTER JOIN #{CustomValue.table_name} #{alias_name}" +
                        " ON #{alias_name}.customized_type = '#{custom_field.class.customized_class.base_class.name}'" +
                        " AND #{alias_name}.customized_id = #{custom_field.class.customized_class.table_name}.id" +
                        " AND #{alias_name}.custom_field_id = #{custom_field.id}" +
                        " AND (#{custom_field.visibility_by_project_condition})" +
                        " AND #{alias_name}.value <> ''" +
                        " AND #{alias_name}.id = (SELECT max(#{alias_name}_2.id) FROM #{CustomValue.table_name} #{alias_name}_2" +
                          " WHERE #{alias_name}_2.customized_type = #{alias_name}.customized_type" +
                          " AND #{alias_name}_2.customized_id = #{alias_name}.customized_id" +
                          " AND #{alias_name}_2.custom_field_id = #{alias_name}.custom_field_id)"
                    end
                    def join_alias(custom_field)
                      "cf_#{custom_field.id}"
                    end
                    protected :join_alias
                  end
                  class Unbounded < Base
                    def validate_single_value(custom_field, value, customized=nil)
                      errs = super
                      value = value.to_s
                      unless custom_field.regexp.blank? or value =~ Regexp.new(custom_field.regexp)
                        errs << ::I18n.t('activerecord.errors.messages.invalid')
                      end
                      if custom_field.min_length && value.length < custom_field.min_length
                        errs << ::I18n.t('activerecord.errors.messages.too_short', :count => custom_field.min_length)
                      end
                      if custom_field.max_length && custom_field.max_length > 0 && value.length > custom_field.max_length
                        errs << ::I18n.t('activerecord.errors.messages.too_long', :count => custom_field.max_length)
                      end
                      errs
                    end
                  end
                  class StringFormat < Unbounded
                    add 'string'
                    self.searchable_supported = true
                    self.form_partial = 'custom_fields/formats/string'
                    field_attributes :text_formatting
                    def formatted_value(view, custom_field, value, customized=nil, html=false)
                      if html
                        if custom_field.url_pattern.present?
                          super
                        elsif custom_field.text_formatting == 'full'
                          view.textilizable(value, :object => customized)
                        else
                          value.to_s
                        end
                      else
                        value.to_s
                      end
                    end
                  end
                  class TextFormat < Unbounded
                    add 'text'
                    self.searchable_supported = true
                    self.form_partial = 'custom_fields/formats/text'
                    self.change_as_diff = true
                    def formatted_value(view, custom_field, value, customized=nil, html=false)
                      if html
                        if value.present?
                          if custom_field.text_formatting == 'full'
                            view.textilizable(value, :object => customized)
                          else
                            view.simple_format(html_escape(value))
                          end
                        else
                          ''
                        end
                      else
                        value.to_s
                      end
                    end
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      view.text_area_tag(tag_name, custom_value.value, options.merge(:id => tag_id, :rows => 3))
                    end
                    def bulk_edit_tag(view, tag_id, tag_name, custom_field, objects, value, options={})
                      view.text_area_tag(tag_name, value, options.merge(:id => tag_id, :rows => 3)) +
                        '<br />'.html_safe +
                        bulk_clear_tag(view, tag_id, tag_name, custom_field, value)
                    end
                    def query_filter_options(custom_field, query)
                      {:type => :text}
                    end
                  end
                  class LinkFormat < StringFormat
                    add 'link'
                    self.searchable_supported = false
                    self.form_partial = 'custom_fields/formats/link'
                    def formatted_value(view, custom_field, value, customized=nil, html=false)
                      if html && value.present?
                        if custom_field.url_pattern.present?
                          url = url_from_pattern(custom_field, value, customized)
                        else
                          url = value.to_s
                          unless url =~ %r{\A[a-z]+://}i
                            # no protocol found, use http by default
                            url = "http://" + url
                          end
                        end
                        view.link_to value.to_s.truncate(40), url
                      else
                        value.to_s
                      end
                    end
                  end
                  class Numeric < Unbounded
                    self.form_partial = 'custom_fields/formats/numeric'
                    self.totalable_supported = true
                    def order_statement(custom_field)
                      # Make the database cast values into numeric
                      # Postgresql will raise an error if a value can not be casted!
                      # CustomValue validations should ensure that it doesn't occur
                      "CAST(CASE #{join_alias custom_field}.value WHEN '' THEN '0' ELSE #{join_alias custom_field}.value END AS decimal(30,3))"
                    end
                    # Returns totals for the given scope
                    def total_for_scope(custom_field, scope)
                      scope.joins(:custom_values).
                        where(:custom_values => {:custom_field_id => custom_field.id}).
                        where.not(:custom_values => {:value => ''}).
                        sum("CAST(#{CustomValue.table_name}.value AS decimal(30,3))")
                    end
                    def cast_total_value(custom_field, value)
                      cast_single_value(custom_field, value)
                    end
                  end
                  class IntFormat < Numeric
                    add 'int'
                    def label
                      "label_integer"
                    end
                    def cast_single_value(custom_field, value, customized=nil)
                      value.to_i
                    end
                    def validate_single_value(custom_field, value, customized=nil)
                      errs = super
                      errs << ::I18n.t('activerecord.errors.messages.not_a_number') unless value.to_s =~ /^[+-]?\d+$/
                      errs
                    end
                    def query_filter_options(custom_field, query)
                      {:type => :integer}
                    end
                    def group_statement(custom_field)
                      order_statement(custom_field)
                    end
                  end
                  class FloatFormat < Numeric
                    add 'float'
                    def cast_single_value(custom_field, value, customized=nil)
                      value.to_f
                    end
                    def cast_total_value(custom_field, value)
                      value.to_f.round(2)
                    end
                    def validate_single_value(custom_field, value, customized=nil)
                      errs = super
                      errs << ::I18n.t('activerecord.errors.messages.invalid') unless (Kernel.Float(value) rescue nil)
                      errs
                    end
                    def query_filter_options(custom_field, query)
                      {:type => :float}
                    end
                  end
                  class DateFormat < Unbounded
                    add 'date'
                    self.form_partial = 'custom_fields/formats/date'
                    def cast_single_value(custom_field, value, customized=nil)
                      value.to_date rescue nil
                    end
                    def validate_single_value(custom_field, value, customized=nil)
                      if value =~ /^\d{4}-\d{2}-\d{2}$/ && (value.to_date rescue false)
                        []
                      else
                        [::I18n.t('activerecord.errors.messages.not_a_date')]
                      end
                    end
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      view.date_field_tag(tag_name, custom_value.value, options.merge(:id => tag_id, :size => 10)) +
                        view.calendar_for(tag_id)
                    end
                    def bulk_edit_tag(view, tag_id, tag_name, custom_field, objects, value, options={})
                      view.date_field_tag(tag_name, value, options.merge(:id => tag_id, :size => 10)) +
                        view.calendar_for(tag_id) +
                        bulk_clear_tag(view, tag_id, tag_name, custom_field, value)
                    end
                    def query_filter_options(custom_field, query)
                      {:type => :date}
                    end
                    def group_statement(custom_field)
                      order_statement(custom_field)
                    end
                  end
                  class List < Base
                    self.multiple_supported = true
                    field_attributes :edit_tag_style
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      if custom_value.custom_field.edit_tag_style == 'check_box'
                        check_box_edit_tag(view, tag_id, tag_name, custom_value, options)
                      else
                        select_edit_tag(view, tag_id, tag_name, custom_value, options)
                      end
                    end
                    def bulk_edit_tag(view, tag_id, tag_name, custom_field, objects, value, options={})
                      opts = []
                      opts << [l(:label_no_change_option), ''] unless custom_field.multiple?
                      opts << [l(:label_none), '__none__'] unless custom_field.is_required?
                      opts += possible_values_options(custom_field, objects)
                      view.select_tag(tag_name, view.options_for_select(opts, value), options.merge(:multiple => custom_field.multiple?))
                    end
                    def query_filter_options(custom_field, query)
-                     {:type => :list_optional, :values => query_filter_values(custom_field, query)}
+                     {:type => :list_optional, :values => lambda { query_filter_values(custom_field, query) }}
                    end
                    protected
                    # Returns the values that are available in the field filter
                    def query_filter_values(custom_field, query)
                      possible_values_options(custom_field, query.project)
                    end
                    # Renders the edit tag as a select tag
                    def select_edit_tag(view, tag_id, tag_name, custom_value, options={})
                      blank_option = ''.html_safe
                      unless custom_value.custom_field.multiple?
                        if custom_value.custom_field.is_required?
                          unless custom_value.custom_field.default_value.present?
                            blank_option = view.content_tag('option', "--- #{l(:actionview_instancetag_blank_option)} ---", :value => '')
                          end
                        else
                          blank_option = view.content_tag('option', '&nbsp;'.html_safe, :value => '')
                        end
                      end
                      options_tags = blank_option + view.options_for_select(possible_custom_value_options(custom_value), custom_value.value)
                      s = view.select_tag(tag_name, options_tags, options.merge(:id => tag_id, :multiple => custom_value.custom_field.multiple?))
                      if custom_value.custom_field.multiple?
                        s << view.hidden_field_tag(tag_name, '')
                      end
                      s
                    end
                    # Renders the edit tag as check box or radio tags
                    def check_box_edit_tag(view, tag_id, tag_name, custom_value, options={})
                      opts = []
                      unless custom_value.custom_field.multiple? || custom_value.custom_field.is_required?
                        opts << ["(#{l(:label_none)})", '']
                      end
                      opts += possible_custom_value_options(custom_value)
                      s = ''.html_safe
                      tag_method = custom_value.custom_field.multiple? ? :check_box_tag : :radio_button_tag
                      opts.each do |label, value|
                        value ||= label
                        checked = (custom_value.value.is_a?(Array) && custom_value.value.include?(value)) || custom_value.value.to_s == value
                        tag = view.send(tag_method, tag_name, value, checked, :id => tag_id)
                        # set the id on the first tag only
                        tag_id = nil
                        s << view.content_tag('label', tag + ' ' + label)
                      end
                      if custom_value.custom_field.multiple?
                        s << view.hidden_field_tag(tag_name, '')
                      end
                      css = "#{options[:class]} check_box_group"
                      view.content_tag('span', s, options.merge(:class => css))
                    end
                  end
                  class ListFormat < List
                    add 'list'
                    self.searchable_supported = true
                    self.form_partial = 'custom_fields/formats/list'
                    def possible_custom_value_options(custom_value)
                      options = possible_values_options(custom_value.custom_field)
                      missing = [custom_value.value].flatten.reject(&:blank?) - options
                      if missing.any?
                        options += missing
                      end
                      options
                    end
                    def possible_values_options(custom_field, object=nil)
                      custom_field.possible_values
                    end
                    def validate_custom_field(custom_field)
                      errors = []
                      errors << [:possible_values, :blank] if custom_field.possible_values.blank?
                      errors << [:possible_values, :invalid] unless custom_field.possible_values.is_a? Array
                      errors
                    end
                    def validate_custom_value(custom_value)
                      values = Array.wrap(custom_value.value).reject {|value| value.to_s == ''}
                      invalid_values = values - Array.wrap(custom_value.value_was) - custom_value.custom_field.possible_values
                      if invalid_values.any?
                        [::I18n.t('activerecord.errors.messages.inclusion')]
                      else
                        []
                      end
                    end
                    def group_statement(custom_field)
                      order_statement(custom_field)
                    end
                  end
                  class BoolFormat < List
                    add 'bool'
                    self.multiple_supported = false
                    self.form_partial = 'custom_fields/formats/bool'
                    def label
                      "label_boolean"
                    end
                    def cast_single_value(custom_field, value, customized=nil)
                      value == '1' ? true : false
                    end
                    def possible_values_options(custom_field, object=nil)
                      [[::I18n.t(:general_text_Yes), '1'], [::I18n.t(:general_text_No), '0']]
                    end
                    def group_statement(custom_field)
                      order_statement(custom_field)
                    end
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      case custom_value.custom_field.edit_tag_style
                      when 'check_box'
                        single_check_box_edit_tag(view, tag_id, tag_name, custom_value, options)
                      when 'radio'
                        check_box_edit_tag(view, tag_id, tag_name, custom_value, options)
                      else
                        select_edit_tag(view, tag_id, tag_name, custom_value, options)
                      end
                    end
                    # Renders the edit tag as a simple check box
                    def single_check_box_edit_tag(view, tag_id, tag_name, custom_value, options={})
                      s = ''.html_safe
                      s << view.hidden_field_tag(tag_name, '0', :id => nil)
                      s << view.check_box_tag(tag_name, '1', custom_value.value.to_s == '1', :id => tag_id)
                      view.content_tag('span', s, options)
                    end
                  end
                  class RecordList < List
                    self.customized_class_names = %w(Issue TimeEntry Version Document Project)
                    def cast_single_value(custom_field, value, customized=nil)
                      target_class.find_by_id(value.to_i) if value.present?
                    end
                    def target_class
                      @target_class ||= self.class.name[/^(.*::)?(.+)Format$/, 2].constantize rescue nil
                    end
                    def reset_target_class
                      @target_class = nil
                    end
                    def possible_custom_value_options(custom_value)
                      options = possible_values_options(custom_value.custom_field, custom_value.customized)
                      missing = [custom_value.value_was].flatten.reject(&:blank?) - options.map(&:last)
                      if missing.any?
                        options += target_class.where(:id => missing.map(&:to_i)).map {|o| [o.to_s, o.id.to_s]}
                      end
                      options
                    end
                    def order_statement(custom_field)
                      if target_class.respond_to?(:fields_for_order_statement)
                        target_class.fields_for_order_statement(value_join_alias(custom_field))
                      end
                    end
                    def group_statement(custom_field)
                      "COALESCE(#{join_alias custom_field}.value, '')"
                    end
                    def join_for_order_statement(custom_field)
                      alias_name = join_alias(custom_field)
                      "LEFT OUTER JOIN #{CustomValue.table_name} #{alias_name}" +
                        " ON #{alias_name}.customized_type = '#{custom_field.class.customized_class.base_class.name}'" +
                        " AND #{alias_name}.customized_id = #{custom_field.class.customized_class.table_name}.id" +
                        " AND #{alias_name}.custom_field_id = #{custom_field.id}" +
                        " AND (#{custom_field.visibility_by_project_condition})" +
                        " AND #{alias_name}.value <> ''" +
                        " AND #{alias_name}.id = (SELECT max(#{alias_name}_2.id) FROM #{CustomValue.table_name} #{alias_name}_2" +
                          " WHERE #{alias_name}_2.customized_type = #{alias_name}.customized_type" +
                          " AND #{alias_name}_2.customized_id = #{alias_name}.customized_id" +
                          " AND #{alias_name}_2.custom_field_id = #{alias_name}.custom_field_id)" +
                        " LEFT OUTER JOIN #{target_class.table_name} #{value_join_alias custom_field}" +
                        " ON CAST(CASE #{alias_name}.value WHEN '' THEN '0' ELSE #{alias_name}.value END AS decimal(30,0)) = #{value_join_alias custom_field}.id"
                    end
                    def value_join_alias(custom_field)
                      join_alias(custom_field) + "_" + custom_field.field_format
                    end
                    protected :value_join_alias
                  end
                  class EnumerationFormat < RecordList
                    add 'enumeration'
                    self.form_partial = 'custom_fields/formats/enumeration'
                    def label
                      "label_field_format_enumeration"
                    end
                    def target_class
                      @target_class ||= CustomFieldEnumeration
                    end
                    def possible_values_options(custom_field, object=nil)
                      possible_values_records(custom_field, object).map {|u| [u.name, u.id.to_s]}
                    end
                    def possible_values_records(custom_field, object=nil)
                      custom_field.enumerations.active
                    end
                    def value_from_keyword(custom_field, keyword, object)
                      value = custom_field.enumerations.where("LOWER(name) LIKE LOWER(?)", keyword).first
                      value ? value.id : nil
                    end
                  end
                  class UserFormat < RecordList
                    add 'user'
                    self.form_partial = 'custom_fields/formats/user'
                    field_attributes :user_role
                    def possible_values_options(custom_field, object=nil)
                      possible_values_records(custom_field, object).map {|u| [u.name, u.id.to_s]}
                    end
                    def possible_values_records(custom_field, object=nil)
                      if object.is_a?(Array)
                        projects = object.map {|o| o.respond_to?(:project) ? o.project : nil}.compact.uniq
                        projects.map {|project| possible_values_records(custom_field, project)}.reduce(:&) || []
                      elsif object.respond_to?(:project) && object.project
                        scope = object.project.users
                        if custom_field.user_role.is_a?(Array)
                          role_ids = custom_field.user_role.map(&:to_s).reject(&:blank?).map(&:to_i)
                          if role_ids.any?
                            scope = scope.where("#{Member.table_name}.id IN (SELECT DISTINCT member_id FROM #{MemberRole.table_name} WHERE role_id IN (?))", role_ids)
                          end
                        end
                        scope.sorted
                      else
                        []
                      end
                    end
                    def value_from_keyword(custom_field, keyword, object)
                      users = possible_values_records(custom_field, object).to_a
                      user = Principal.detect_by_keyword(users, keyword)
                      user ? user.id : nil
                    end
                    def before_custom_field_save(custom_field)
                      super
                      if custom_field.user_role.is_a?(Array)
                        custom_field.user_role.map!(&:to_s).reject!(&:blank?)
                      end
                    end
+                   def query_filter_values(*args)
+                     [["<< #{l(:label_me)} >>", "me"]] + super
+                   end
                  end
                  class VersionFormat < RecordList
                    add 'version'
                    self.form_partial = 'custom_fields/formats/version'
                    field_attributes :version_status
                    def possible_values_options(custom_field, object=nil)
                      versions_options(custom_field, object)
                    end
                    def before_custom_field_save(custom_field)
                      super
                      if custom_field.version_status.is_a?(Array)
                        custom_field.version_status.map!(&:to_s).reject!(&:blank?)
                      end
                    end
                    protected
                    def query_filter_values(custom_field, query)
                      versions_options(custom_field, query.project, true)
                    end
                    def versions_options(custom_field, object, all_statuses=false)
                      if object.is_a?(Array)
                        projects = object.map {|o| o.respond_to?(:project) ? o.project : nil}.compact.uniq
                        projects.map {|project| possible_values_options(custom_field, project)}.reduce(:&) || []
                      elsif object.respond_to?(:project) && object.project
                        scope = object.project.shared_versions
                        filtered_versions_options(custom_field, scope, all_statuses)
                      elsif object.nil?
                        scope = ::Version.visible.where(:sharing => 'system')
                        filtered_versions_options(custom_field, scope, all_statuses)
                      else
                        []
                      end
                    end
                    def filtered_versions_options(custom_field, scope, all_statuses=false)
                      if !all_statuses && custom_field.version_status.is_a?(Array)
                        statuses = custom_field.version_status.map(&:to_s).reject(&:blank?)
                        if statuses.any?
                          scope = scope.where(:status => statuses.map(&:to_s))
                        end
                      end
                      scope.sort.collect{|u| [u.to_s, u.id.to_s] }
                    end
                  end
                  class AttachmentFormat < Base
                    add 'attachment'
                    self.form_partial = 'custom_fields/formats/attachment'
                    self.is_filter_supported = false
                    self.change_no_details = true
                    self.bulk_edit_supported = false
                    field_attributes :extensions_allowed
                    def set_custom_field_value(custom_field, custom_field_value, value)
                      attachment_present = false
                      if value.is_a?(Hash)
                        attachment_present = true
                        value = value.except(:blank)
                        if value.values.any? && value.values.all? {|v| v.is_a?(Hash)}
                          value = value.values.first
                        end
                        if value.key?(:id)
                          value = set_custom_field_value_by_id(custom_field, custom_field_value, value[:id])
                        elsif value[:token].present?
                          if attachment = Attachment.find_by_token(value[:token])
                            value = attachment.id.to_s
                          else
                            value = ''
                          end
                        elsif value.key?(:file)
                          attachment = Attachment.new(:file => value[:file], :author => User.current)
                          if attachment.save
                            value = attachment.id.to_s
                          else
                            value = ''
                          end
                        else
                          attachment_present = false
                          value = ''
                        end
                      elsif value.is_a?(String)
                        value = set_custom_field_value_by_id(custom_field, custom_field_value, value)
                      end
                      custom_field_value.instance_variable_set "@attachment_present", attachment_present
                      value
                    end
                    def set_custom_field_value_by_id(custom_field, custom_field_value, id)
                      attachment = Attachment.find_by_id(id)
                      if attachment && attachment.container.is_a?(CustomValue) && attachment.container.customized == custom_field_value.customized
                        id.to_s
                      else
                        ''
                      end
                    end
                    private :set_custom_field_value_by_id
                    def cast_single_value(custom_field, value, customized=nil)
                      Attachment.find_by_id(value.to_i) if value.present? && value.respond_to?(:to_i)
                    end
                    def validate_custom_value(custom_value)
                      errors = []
                      if custom_value.value.blank?
                        if custom_value.instance_variable_get("@attachment_present")
                          errors << ::I18n.t('activerecord.errors.messages.invalid')
                        end
                      else
                        if custom_value.value.present?
                          attachment = Attachment.where(:id => custom_value.value.to_s).first
                          extensions = custom_value.custom_field.extensions_allowed
                          if attachment && extensions.present? && !attachment.extension_in?(extensions)
                            errors << "#{::I18n.t('activerecord.errors.messages.invalid')} (#{l(:setting_attachment_extensions_allowed)}: #{extensions})"
                          end
                        end
                      end
                      errors.uniq
                    end
                    def after_save_custom_value(custom_field, custom_value)
                      if custom_value.value_changed?
                        if custom_value.value.present?
                          attachment = Attachment.where(:id => custom_value.value.to_s).first
                          if attachment
                            attachment.container = custom_value
                            attachment.save!
                          end
                        end
                        if custom_value.value_was.present?
                          attachment = Attachment.where(:id => custom_value.value_was.to_s).first
                          if attachment
                            attachment.destroy
                          end
                        end
                      end
                    end
                    def edit_tag(view, tag_id, tag_name, custom_value, options={})
                      attachment = nil
                      if custom_value.value.present?
                        attachment = Attachment.find_by_id(custom_value.value)
                      end
                      view.hidden_field_tag("#{tag_name}[blank]", "") +
                        view.render(:partial => 'attachments/form',
                          :locals => {
                            :attachment_param => tag_name,
                            :multiple => false,
                            :description => false,
                            :saved_attachments => [attachment].compact,
                            :filedrop => false
                          })
                    end
                  end
                end
              end

test/unit/lib/redmine/field_format/version_field_format_test.rb +1 -1

              # Redmine - project management software
              # Copyright (C) 2006-2016  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../../../../test_helper', __FILE__)
              require 'redmine/field_format'
              class Redmine::VersionFieldFormatTest < ActionView::TestCase
                fixtures :projects, :versions, :trackers,
                         :roles, :users, :members, :member_roles,
                         :issue_statuses, :issue_categories, :issue_relations, :workflows,
                         :enumerations
                def test_version_status_should_reject_blank_values
                  field = IssueCustomField.new(:name => 'Foo', :field_format => 'version', :version_status => ["open", ""])
                  field.save!
                  assert_equal ["open"], field.version_status
                end
                def test_existing_values_should_be_valid
                  field = IssueCustomField.create!(:name => 'Foo', :field_format => 'version', :is_for_all => true, :trackers => Tracker.all)
                  project = Project.generate!
                  version = Version.generate!(:project => project, :status => 'open')
                  issue = Issue.generate!(:project_id => project.id, :tracker_id => 1, :custom_field_values => {field.id => version.id})
                  field.version_status = ["open"]
                  field.save!
                  issue = Issue.order('id DESC').first
                  assert_include [version.name, version.id.to_s], field.possible_custom_value_options(issue.custom_value_for(field))
                  assert issue.valid?
                end
                def test_possible_values_options_should_return_project_versions
                  field = IssueCustomField.new(:field_format => 'version')
                  project = Project.find(1)
                  expected = project.shared_versions.sort.map(&:name)
                  assert_equal expected, field.possible_values_options(project).map(&:first)
                end
                def test_possible_values_options_should_return_system_shared_versions_without_project
                  field = IssueCustomField.new(:field_format => 'version')
                  version = Version.generate!(:project => Project.find(1), :status => 'open', :sharing => 'system')
                  expected = Version.visible.where(:sharing => 'system').sort.map(&:name)
                  assert_include version.name, expected
                  assert_equal expected, field.possible_values_options.map(&:first)
                end
                def test_possible_values_options_should_return_project_versions_with_selected_status
                  field = IssueCustomField.new(:field_format => 'version', :version_status => ["open"])
                  project = Project.find(1)
                  expected = project.shared_versions.sort.select {|v| v.status == "open"}.map(&:name)
                  assert_equal expected, field.possible_values_options(project).map(&:first)
                end
                def test_cast_value_should_not_raise_error_when_array_contains_value_casted_to_nil
                  field = IssueCustomField.new(:field_format => 'version')
                  assert_nothing_raised do
                    field.cast_value([1,2, 42])
                  end
                end
                def test_query_filter_options_should_include_versions_with_any_status
                  field = IssueCustomField.new(:field_format => 'version', :version_status => ["open"])
                  project = Project.find(1)
                  version = Version.generate!(:project => project, :status => 'locked')
                  query = Query.new(:project => project)
                  assert_not_include version.name, field.possible_values_options(project).map(&:first)
-                 assert_include version.name, field.query_filter_options(query)[:values].map(&:first)
+                 assert_include version.name, field.query_filter_options(query)[:values].call.map(&:first)
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages