jro_apps/redmine Commit - r4067:2f380a798592

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class IssuesController < ApplicationController

18

class IssuesController < ApplicationController

19

menu_item :new_issue, :only => [:new, :create]

19

menu_item :new_issue, :only => [:new, :create]

20

default_search_scope :issues

20

default_search_scope :issues

21

22

before_filter :find_issue, :only => [:show, :edit, :update]

22

before_filter :find_issue, :only => [:show, :edit, :update]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

23

before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]

24

before_filter :find_project, :only => [:new, :create]

24

before_filter :find_project, :only => [:new, :create]

25

before_filter :authorize, :except => [:index]

25

before_filter :authorize, :except => [:index]

26

before_filter :find_optional_project, :only => [:index]

26

before_filter :find_optional_project, :only => [:index]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

27

before_filter :check_for_default_issue_status, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

28

before_filter :build_new_issue_from_params, :only => [:new, :create]

29

accept_key_auth :index, :show

29

accept_key_auth :index, :show

30

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

31

rescue_from Query::StatementInvalid, :with => :query_statement_invalid

32

33

helper :journals

33

helper :journals

34

helper :projects

34

helper :projects

35

include ProjectsHelper

35

include ProjectsHelper

36

helper :custom_fields

36

helper :custom_fields

37

include CustomFieldsHelper

37

include CustomFieldsHelper

38

helper :issue_relations

38

helper :issue_relations

39

include IssueRelationsHelper

39

include IssueRelationsHelper

40

helper :watchers

40

helper :watchers

41

include WatchersHelper

41

include WatchersHelper

42

helper :attachments

42

helper :attachments

43

include AttachmentsHelper

43

include AttachmentsHelper

44

helper :queries

44

helper :queries

45

include QueriesHelper

45

include QueriesHelper

46

helper :sort

46

helper :sort

47

include SortHelper

47

include SortHelper

48

include IssuesHelper

48

include IssuesHelper

49

helper :timelog

49

helper :timelog

50

helper :gantt

50

helper :gantt

51

include Redmine::Export::PDF

51

include Redmine::Export::PDF

52

53

verify :method => [:post, :delete],

53

verify :method => [:post, :delete],

54

:only => :destroy,

54

:only => :destroy,

55

:render => { :nothing => true, :status => :method_not_allowed }

55

:render => { :nothing => true, :status => :method_not_allowed }

56

57

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

57

verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }

58

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

58

verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }

59

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

59

verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }

60

61

def index

61

def index

62

retrieve_query

62

retrieve_query

63

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

63

sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)

64

sort_update(@query.sortable_columns)

64

sort_update(@query.sortable_columns)

65

66

if @query.valid?

66

if @query.valid?

67

limit = case params[:format]

67

limit = case params[:format]

68

when 'csv', 'pdf'

68

when 'csv', 'pdf'

69

Setting.issues_export_limit.to_i

69

Setting.issues_export_limit.to_i

70

when 'atom'

70

when 'atom'

71

Setting.feeds_limit.to_i

71

Setting.feeds_limit.to_i

72

else

72

else

73

per_page_option

73

per_page_option

74

end

74

end

75

76

@issue_count = @query.issue_count

76

@issue_count = @query.issue_count

77

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

77

@issue_pages = Paginator.new self, @issue_count, limit, params['page']

78

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

78

@issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],

79

:order => sort_clause,

79

:order => sort_clause,

80

:offset => @issue_pages.current.offset,

80

:offset => @issue_pages.current.offset,

81

:limit => limit)

81

:limit => limit)

82

@issue_count_by_group = @query.issue_count_by_group

82

@issue_count_by_group = @query.issue_count_by_group

83

84

respond_to do |format|

84

respond_to do |format|

85

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

85

format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }

86

format.xml { render :layout => false }

86

format.xml { render :layout => false }

87

format.json { render :text => @issues.to_json, :layout => false }

87

format.json { render :text => @issues.to_json, :layout => false }

88

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

88

format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }

89

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

89

format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }

90

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

90

format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }

91

end

91

end

92

else

92

else

93

# Send html if the query is not valid

93

# Send html if the query is not valid

94

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

94

render(:template => 'issues/index.rhtml', :layout => !request.xhr?)

95

end

95

end

96

rescue ActiveRecord::RecordNotFound

96

rescue ActiveRecord::RecordNotFound

97

render_404

97

render_404

98

end

98

end

99

100

def show

100

def show

101

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

101

@journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")

102

@journals.each_with_index {|j,i| j.indice = i+1}

102

@journals.each_with_index {|j,i| j.indice = i+1}

103

@journals.reverse! if User.current.wants_comments_in_reverse_order?

103

@journals.reverse! if User.current.wants_comments_in_reverse_order?

104

@changesets = @issue.changesets.visible.all

104

@changesets = @issue.changesets.visible.all

105

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

105

@changesets.reverse! if User.current.wants_comments_in_reverse_order?

106

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

106

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

107

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

107

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

108

@priorities = IssuePriority.all

108

@priorities = IssuePriority.all

109

@time_entry = TimeEntry.new

109

@time_entry = TimeEntry.new

110

respond_to do |format|

110

respond_to do |format|

111

format.html { render :template => 'issues/show.rhtml' }

111

format.html { render :template => 'issues/show.rhtml' }

112

format.xml { render :layout => false }

112

format.xml { render :layout => false }

113

format.json { render :text => @issue.to_json, :layout => false }

113

format.json { render :text => @issue.to_json, :layout => false }

114

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

114

format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }

115

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

115

format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }

116

end

116

end

117

end

117

end

118

119

# Add a new issue

119

# Add a new issue

120

# The new issue will be created from an existing one if copy_from parameter is given

120

# The new issue will be created from an existing one if copy_from parameter is given

121

def new

121

def new

122

respond_to do |format|

122

respond_to do |format|

123

format.html { render :action => 'new', :layout => !request.xhr? }

123

format.html { render :action => 'new', :layout => !request.xhr? }

124

format.js { render :partial => 'attributes' }

124

format.js { render :partial => 'attributes' }

125

end

125

end

126

end

126

end

127

128

def create

128

def create

129

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

129

call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })

130

if @issue.save

130

if @issue.save

131

attachments = Attachment.attach_files(@issue, params[:attachments])

131

attachments = Attachment.attach_files(@issue, params[:attachments])

132

render_attachment_warning_if_needed(@issue)

132

render_attachment_warning_if_needed(@issue)

133

flash[:notice] = l(:notice_successful_create)

133

flash[:notice] = l(:notice_successful_create)

134

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

134

call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})

135

respond_to do |format|

135

respond_to do |format|

136

format.html {

136

format.html {

137

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

137

redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :

138

{ :action => 'show', :id => @issue })

138

{ :action => 'show', :id => @issue })

139

}

139

}

140

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

140

format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }

141

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

141

format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }

142

end

142

end

143

return

143

return

144

else

144

else

145

respond_to do |format|

145

respond_to do |format|

146

format.html { render :action => 'new' }

146

format.html { render :action => 'new' }

147

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

147

format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }

148

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

148

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

149

end

149

end

150

end

150

end

151

end

151

end

152

153

# Attributes that can be updated on workflow transition (without :edit permission)

153

# Attributes that can be updated on workflow transition (without :edit permission)

154

# TODO: make it configurable (at least per role)

154

# TODO: make it configurable (at least per role)

155

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

155

UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)

156

157

def edit

157

def edit

158

update_issue_from_params

158

update_issue_from_params

159

160

@journal = @issue.current_journal

160

@journal = @issue.current_journal

161

162

respond_to do |format|

162

respond_to do |format|

163

format.html { }

163

format.html { }

164

format.xml { }

164

format.xml { }

165

end

165

end

166

end

166

end

167

168

def update

168

def update

169

update_issue_from_params

169

update_issue_from_params

170

171

if @issue.save_issue_with_child_records(params, @time_entry)

171

if @issue.save_issue_with_child_records(params, @time_entry)

172

render_attachment_warning_if_needed(@issue)

172

render_attachment_warning_if_needed(@issue)

173

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

173

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

174

175

respond_to do |format|

175

respond_to do |format|

176

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

176

format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }

177

format.xml { head :ok }

177

format.xml { head :ok }

178

format.json { head :ok }

178

format.json { head :ok }

179

end

179

end

180

else

180

else

181

render_attachment_warning_if_needed(@issue)

181

render_attachment_warning_if_needed(@issue)

182

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

182

flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?

183

@journal = @issue.current_journal

183

@journal = @issue.current_journal

184

185

respond_to do |format|

185

respond_to do |format|

186

format.html { render :action => 'edit' }

186

format.html { render :action => 'edit' }

187

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

187

format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }

188

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

188

format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }

189

end

189

end

190

end

190

end

191

end

191

end

192

193

# Bulk edit a set of issues

193

# Bulk edit a set of issues

194

def bulk_edit

194

def bulk_edit

195

@issues.sort!

195

@issues.sort!

196

@available_statuses = Workflow.available_statuses(@project)

196

@available_statuses = Workflow.available_statuses(@project)

197

@custom_fields = @project.all_issue_custom_fields

197

@custom_fields = @project.all_issue_custom_fields

198

end

198

end

199

200

def bulk_update

200

def bulk_update

201

@issues.sort!

201

@issues.sort!

202

attributes = parse_params_for_bulk_issue_attributes(params)

202

attributes = parse_params_for_bulk_issue_attributes(params)

203

204

unsaved_issue_ids = []

204

unsaved_issue_ids = []

205

@issues.each do |issue|

205

@issues.each do |issue|

206

issue.reload

206

issue.reload

207

journal = issue.init_journal(User.current, params[:notes])

207

journal = issue.init_journal(User.current, params[:notes])

208

issue.safe_attributes = attributes

208

issue.safe_attributes = attributes

209

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

209

call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })

210

unless issue.save

210

unless issue.save

211

# Keep unsaved issue ids to display them in flash error

211

# Keep unsaved issue ids to display them in flash error

212

unsaved_issue_ids << issue.id

212

unsaved_issue_ids << issue.id

213

end

213

end

214

end

214

end

215

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

215

set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)

216

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

216

redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})

217

end

217

end

218

219

def destroy

219

def destroy

220

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

220

@hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f

221

if @hours > 0

221

if @hours > 0

222

case params[:todo]

222

case params[:todo]

223

when 'destroy'

223

when 'destroy'

224

# nothing to do

224

# nothing to do

225

when 'nullify'

225

when 'nullify'

226

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

226

TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])

227

when 'reassign'

227

when 'reassign'

228

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

228

reassign_to = @project.issues.find_by_id(params[:reassign_to_id])

229

if reassign_to.nil?

229

if reassign_to.nil?

230

flash.now[:error] = l(:error_issue_not_found_in_project)

230

flash.now[:error] = l(:error_issue_not_found_in_project)

231

return

231

return

232

else

232

else

233

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

233

TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])

234

end

234

end

235

else

235

else

236

unless params[:format] == 'xml' || params[:format] == 'json'

236

unless params[:format] == 'xml' || params[:format] == 'json'

237

# display the destroy form if it's a user request

237

# display the destroy form if it's a user request

238

return

238

return

239

end

239

end

240

end

240

end

241

end

241

end

242

@issues.each(&:destroy)

242

@issues.each(&:destroy)

243

respond_to do |format|

243

respond_to do |format|

244

format.html { redirect_to :action => 'index', :project_id => @project }

244

format.html { redirect_to :action => 'index', :project_id => @project }

245

format.xml { head :ok }

245

format.xml { head :ok }

246

format.json { head :ok }

246

format.json { head :ok }

247

end

247

end

248

end

248

end

249

250

private

250

private

251

def find_issue

251

def find_issue

252

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

252

@issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])

253

@project = @issue.project

253

@project = @issue.project

254

rescue ActiveRecord::RecordNotFound

254

rescue ActiveRecord::RecordNotFound

255

render_404

255

render_404

256

end

256

end

257

258

def find_project

258

def find_project

259

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

259

project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]

260

@project = Project.find(project_id)

260

@project = Project.find(project_id)

261

rescue ActiveRecord::RecordNotFound

261

rescue ActiveRecord::RecordNotFound

262

render_404

262

render_404

263

end

263

end

264

265

# Used by #edit and #update to set some common instance variables

265

# Used by #edit and #update to set some common instance variables

266

# from the params

266

# from the params

267

# TODO: Refactor, not everything in here is needed by #edit

267

# TODO: Refactor, not everything in here is needed by #edit

268

def update_issue_from_params

268

def update_issue_from_params

269

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

269

@allowed_statuses = @issue.new_statuses_allowed_to(User.current)

270

@priorities = IssuePriority.all

270

@priorities = IssuePriority.all

271

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

271

@edit_allowed = User.current.allowed_to?(:edit_issues, @project)

272

@time_entry = TimeEntry.new

272

@time_entry = TimeEntry.new

273

274

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

274

@notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)

275

@issue.init_journal(User.current, @notes)

275

@issue.init_journal(User.current, @notes)

276

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

276

# User can change issue attributes only if he has :edit permission or if a workflow transition is allowed

277

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

277

if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]

278

attrs = params[:issue].dup

278

attrs = params[:issue].dup

279

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

279

attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed

280

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

280

attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}

281

@issue.safe_attributes = attrs

281

@issue.safe_attributes = attrs

282

end

282

end

283

284

end

284

end

285

286

# TODO: Refactor, lots of extra code in here

286

# TODO: Refactor, lots of extra code in here

287

# TODO: Changing tracker on an existing issue should not trigger this

287

def build_new_issue_from_params

288

def build_new_issue_from_params

288

if params[:id].blank?

289

if params[:id].blank?

289

@issue = Issue.new

290

@issue = Issue.new

290

@issue.copy_from(params[:copy_from]) if params[:copy_from]

291

@issue.copy_from(params[:copy_from]) if params[:copy_from]

291

@issue.project = @project

292

@issue.project = @project

292

else

293

else

293

@issue = @project.issues.visible.find(params[:id])

294

@issue = @project.issues.visible.find(params[:id])

294

end

295

end

295

296

@issue.project = @project

297

@issue.project = @project

297

# Tracker must be set before custom field values

298

# Tracker must be set before custom field values

298

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

299

@issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)

299

if @issue.tracker.nil?

300

if @issue.tracker.nil?

300

render_error l(:error_no_tracker_in_project)

301

render_error l(:error_no_tracker_in_project)

301

return false

302

return false

302

end

303

end

303

if params[:issue].is_a?(Hash)

304

if params[:issue].is_a?(Hash)

304

@issue.safe_attributes = params[:issue]

305

@issue.safe_attributes = params[:issue]

305

~~@issue~~.~~watcher_user_ids~~ = ~~params~~[~~:issue~~][~~'watcher_user_ids'~~] if User.current.allowed_to?(:add_issue_watchers, @project)

306

if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?

307

@issue.watcher_user_ids = params[:issue]['watcher_user_ids']

308

end

306

end

309

end

307

@issue.author = User.current

310

@issue.author = User.current

308

@issue.start_date ||= Date.today

311

@issue.start_date ||= Date.today

309

@priorities = IssuePriority.all

312

@priorities = IssuePriority.all

310

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

313

@allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)

311

end

314

end

312

315

313

def check_for_default_issue_status

316

def check_for_default_issue_status

314

if IssueStatus.default.nil?

317

if IssueStatus.default.nil?

315

render_error l(:error_no_default_issue_status)

318

render_error l(:error_no_default_issue_status)

316

return false

319

return false

317

end

320

end

318

end

321

end

319

322

320

def parse_params_for_bulk_issue_attributes(params)

323

def parse_params_for_bulk_issue_attributes(params)

321

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

324

attributes = (params[:issue] || {}).reject {|k,v| v.blank?}

322

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

325

attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}

323

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

326

attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]

324

attributes

327

attributes

325

end

328

end

326

end

329

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssuesController < ApplicationController
               menu_item :new_issue, :only => [:new, :create]
               default_search_scope :issues
               before_filter :find_issue, :only => [:show, :edit, :update]
               before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
               before_filter :find_project, :only => [:new, :create]
               before_filter :authorize, :except => [:index]
               before_filter :find_optional_project, :only => [:index]
               before_filter :check_for_default_issue_status, :only => [:new, :create]
               before_filter :build_new_issue_from_params, :only => [:new, :create]
               accept_key_auth :index, :show
               rescue_from Query::StatementInvalid, :with => :query_statement_invalid
               helper :journals
               helper :projects
               include ProjectsHelper
               helper :custom_fields
               include CustomFieldsHelper
               helper :issue_relations
               include IssueRelationsHelper
               helper :watchers
               include WatchersHelper
               helper :attachments
               include AttachmentsHelper
               helper :queries
               include QueriesHelper
               helper :sort
               include SortHelper
               include IssuesHelper
               helper :timelog
               helper :gantt
               include Redmine::Export::PDF
               verify :method => [:post, :delete],
                      :only => :destroy,
                      :render => { :nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
               verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
               def index
                 retrieve_query
                 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                 sort_update(@query.sortable_columns)
                 if @query.valid?
                   limit = case params[:format]
                   when 'csv', 'pdf'
                     Setting.issues_export_limit.to_i
                   when 'atom'
                     Setting.feeds_limit.to_i
                   else
                     per_page_option
                   end
                   @issue_count = @query.issue_count
                   @issue_pages = Paginator.new self, @issue_count, limit, params['page']
                   @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                           :order => sort_clause,
                                           :offset => @issue_pages.current.offset,
                                           :limit => limit)
                   @issue_count_by_group = @query.issue_count_by_group
                   respond_to do |format|
                     format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
                     format.xml  { render :layout => false }
                     format.json { render :text => @issues.to_json, :layout => false }
                     format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                     format.csv  { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
                     format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
                   end
                 else
                   # Send html if the query is not valid
                   render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def show
                 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
                 @journals.each_with_index {|j,i| j.indice = i+1}
                 @journals.reverse! if User.current.wants_comments_in_reverse_order?
                 @changesets = @issue.changesets.visible.all
                 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @priorities = IssuePriority.all
                 @time_entry = TimeEntry.new
                 respond_to do |format|
                   format.html { render :template => 'issues/show.rhtml' }
                   format.xml  { render :layout => false }
                   format.json { render :text => @issue.to_json, :layout => false }
                   format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                   format.pdf  { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
                 end
               end
               # Add a new issue
               # The new issue will be created from an existing one if copy_from parameter is given
               def new
                 respond_to do |format|
                   format.html { render :action => 'new', :layout => !request.xhr? }
                   format.js { render :partial => 'attributes' }
                 end
               end
               def create
                 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                 if @issue.save
                   attachments = Attachment.attach_files(@issue, params[:attachments])
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_create)
                   call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                   respond_to do |format|
                     format.html {
                       redirect_to(params[:continue] ?  { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
                                   { :action => 'show', :id => @issue })
                     }
                     format.xml  { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
                     format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
                   end
                   return
                 else
                   respond_to do |format|
                     format.html { render :action => 'new' }
                     format.xml  { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Attributes that can be updated on workflow transition (without :edit permission)
               # TODO: make it configurable (at least per role)
               UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
               def edit
                 update_issue_from_params
                 @journal = @issue.current_journal
                 respond_to do |format|
                   format.html { }
                   format.xml  { }
                 end
               end
               def update
                 update_issue_from_params
                 if @issue.save_issue_with_child_records(params, @time_entry)
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   respond_to do |format|
                     format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
                     format.xml  { head :ok }
                     format.json  { head :ok }
                   end
                 else
                   render_attachment_warning_if_needed(@issue)
                   flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                   @journal = @issue.current_journal
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.xml  { render :xml => @issue.errors, :status => :unprocessable_entity }
                     format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
                   end
                 end
               end
               # Bulk edit a set of issues
               def bulk_edit
                 @issues.sort!
                 @available_statuses = Workflow.available_statuses(@project)
                 @custom_fields = @project.all_issue_custom_fields
               end
               def bulk_update
                 @issues.sort!
                 attributes = parse_params_for_bulk_issue_attributes(params)
                 unsaved_issue_ids = []
                 @issues.each do |issue|
                   issue.reload
                   journal = issue.init_journal(User.current, params[:notes])
                   issue.safe_attributes = attributes
                   call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                   unless issue.save
                     # Keep unsaved issue ids to display them in flash error
                     unsaved_issue_ids << issue.id
                   end
                 end
                 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
                 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
               end
               def destroy
                 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                 if @hours > 0
                   case params[:todo]
                   when 'destroy'
                     # nothing to do
                   when 'nullify'
                     TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                   when 'reassign'
                     reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                     if reassign_to.nil?
                       flash.now[:error] = l(:error_issue_not_found_in_project)
                       return
                     else
                       TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                     end
                   else
                     unless params[:format] == 'xml' || params[:format] == 'json'
                       # display the destroy form if it's a user request
                       return
                     end
                   end
                 end
                 @issues.each(&:destroy)
                 respond_to do |format|
                   format.html { redirect_to :action => 'index', :project_id => @project }
                   format.xml  { head :ok }
                   format.json  { head :ok }
                 end
               end
             private
               def find_issue
                 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
                 @project = @issue.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_project
                 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
                 @project = Project.find(project_id)
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Used by #edit and #update to set some common instance variables
               # from the params
               # TODO: Refactor, not everything in here is needed by #edit
               def update_issue_from_params
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                 @priorities = IssuePriority.all
                 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                 @time_entry = TimeEntry.new
                 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
                 @issue.init_journal(User.current, @notes)
                 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
                 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
                   attrs = params[:issue].dup
                   attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
                   attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
                   @issue.safe_attributes = attrs
                 end
               end
               # TODO: Refactor, lots of extra code in here
+              # TODO: Changing tracker on an existing issue should not trigger this
               def build_new_issue_from_params
                 if params[:id].blank?
                   @issue = Issue.new
                   @issue.copy_from(params[:copy_from]) if params[:copy_from]
                   @issue.project = @project
                 else
                   @issue = @project.issues.visible.find(params[:id])
                 end
                 @issue.project = @project
                 # Tracker must be set before custom field values
                 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                 if @issue.tracker.nil?
                   render_error l(:error_no_tracker_in_project)
                   return false
                 end
                 if params[:issue].is_a?(Hash)
                   @issue.safe_attributes = params[:issue]
-                  @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
+                  if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
+                    @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
+                  end
                 end
                 @issue.author = User.current
                 @issue.start_date ||= Date.today
                 @priorities = IssuePriority.all
                 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
               end
               def check_for_default_issue_status
                 if IssueStatus.default.nil?
                   render_error l(:error_no_default_issue_status)
                   return false
                 end
               end
               def parse_params_for_bulk_issue_attributes(params)
                 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
                 attributes
               end
             end