##// END OF EJS Templates
remove unneeded Relation#all from IssueStatus model...
Toshi MARUYAMA -
r12450:2bdf28262b52
parent child
Show More
@@ -1,105 +1,105
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class IssueStatus < ActiveRecord::Base
18 class IssueStatus < ActiveRecord::Base
19 before_destroy :check_integrity
19 before_destroy :check_integrity
20 has_many :workflows, :class_name => 'WorkflowTransition', :foreign_key => "old_status_id"
20 has_many :workflows, :class_name => 'WorkflowTransition', :foreign_key => "old_status_id"
21 acts_as_list
21 acts_as_list
22
22
23 before_destroy :delete_workflow_rules
23 before_destroy :delete_workflow_rules
24 after_save :update_default
24 after_save :update_default
25
25
26 validates_presence_of :name
26 validates_presence_of :name
27 validates_uniqueness_of :name
27 validates_uniqueness_of :name
28 validates_length_of :name, :maximum => 30
28 validates_length_of :name, :maximum => 30
29 validates_inclusion_of :default_done_ratio, :in => 0..100, :allow_nil => true
29 validates_inclusion_of :default_done_ratio, :in => 0..100, :allow_nil => true
30
30
31 scope :sorted, lambda { order("#{table_name}.position ASC") }
31 scope :sorted, lambda { order("#{table_name}.position ASC") }
32 scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
32 scope :named, lambda {|arg| where("LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip)}
33
33
34 def update_default
34 def update_default
35 IssueStatus.where(['id <> ?', id]).update_all({:is_default => false}) if self.is_default?
35 IssueStatus.where(['id <> ?', id]).update_all({:is_default => false}) if self.is_default?
36 end
36 end
37
37
38 # Returns the default status for new issues
38 # Returns the default status for new issues
39 def self.default
39 def self.default
40 where(:is_default => true).first
40 where(:is_default => true).first
41 end
41 end
42
42
43 # Update all the +Issues+ setting their done_ratio to the value of their +IssueStatus+
43 # Update all the +Issues+ setting their done_ratio to the value of their +IssueStatus+
44 def self.update_issue_done_ratios
44 def self.update_issue_done_ratios
45 if Issue.use_status_for_done_ratio?
45 if Issue.use_status_for_done_ratio?
46 IssueStatus.where("default_done_ratio >= 0").all.each do |status|
46 IssueStatus.where("default_done_ratio >= 0").each do |status|
47 Issue.where({:status_id => status.id}).update_all({:done_ratio => status.default_done_ratio})
47 Issue.where({:status_id => status.id}).update_all({:done_ratio => status.default_done_ratio})
48 end
48 end
49 end
49 end
50
50
51 return Issue.use_status_for_done_ratio?
51 return Issue.use_status_for_done_ratio?
52 end
52 end
53
53
54 # Returns an array of all statuses the given role can switch to
54 # Returns an array of all statuses the given role can switch to
55 # Uses association cache when called more than one time
55 # Uses association cache when called more than one time
56 def new_statuses_allowed_to(roles, tracker, author=false, assignee=false)
56 def new_statuses_allowed_to(roles, tracker, author=false, assignee=false)
57 if roles && tracker
57 if roles && tracker
58 role_ids = roles.collect(&:id)
58 role_ids = roles.collect(&:id)
59 transitions = workflows.select do |w|
59 transitions = workflows.select do |w|
60 role_ids.include?(w.role_id) &&
60 role_ids.include?(w.role_id) &&
61 w.tracker_id == tracker.id &&
61 w.tracker_id == tracker.id &&
62 ((!w.author && !w.assignee) || (author && w.author) || (assignee && w.assignee))
62 ((!w.author && !w.assignee) || (author && w.author) || (assignee && w.assignee))
63 end
63 end
64 transitions.map(&:new_status).compact.sort
64 transitions.map(&:new_status).compact.sort
65 else
65 else
66 []
66 []
67 end
67 end
68 end
68 end
69
69
70 # Same thing as above but uses a database query
70 # Same thing as above but uses a database query
71 # More efficient than the previous method if called just once
71 # More efficient than the previous method if called just once
72 def find_new_statuses_allowed_to(roles, tracker, author=false, assignee=false)
72 def find_new_statuses_allowed_to(roles, tracker, author=false, assignee=false)
73 if roles.present? && tracker
73 if roles.present? && tracker
74 conditions = "(author = :false AND assignee = :false)"
74 conditions = "(author = :false AND assignee = :false)"
75 conditions << " OR author = :true" if author
75 conditions << " OR author = :true" if author
76 conditions << " OR assignee = :true" if assignee
76 conditions << " OR assignee = :true" if assignee
77
77
78 workflows.
78 workflows.
79 includes(:new_status).
79 includes(:new_status).
80 where(["role_id IN (:role_ids) AND tracker_id = :tracker_id AND (#{conditions})",
80 where(["role_id IN (:role_ids) AND tracker_id = :tracker_id AND (#{conditions})",
81 {:role_ids => roles.collect(&:id), :tracker_id => tracker.id, :true => true, :false => false}
81 {:role_ids => roles.collect(&:id), :tracker_id => tracker.id, :true => true, :false => false}
82 ]).all.
82 ]).all.
83 map(&:new_status).compact.sort
83 map(&:new_status).compact.sort
84 else
84 else
85 []
85 []
86 end
86 end
87 end
87 end
88
88
89 def <=>(status)
89 def <=>(status)
90 position <=> status.position
90 position <=> status.position
91 end
91 end
92
92
93 def to_s; name end
93 def to_s; name end
94
94
95 private
95 private
96
96
97 def check_integrity
97 def check_integrity
98 raise "Can't delete status" if Issue.where(:status_id => id).any?
98 raise "Can't delete status" if Issue.where(:status_id => id).any?
99 end
99 end
100
100
101 # Deletes associated workflows
101 # Deletes associated workflows
102 def delete_workflow_rules
102 def delete_workflow_rules
103 WorkflowRule.delete_all(["old_status_id = :id OR new_status_id = :id", {:id => id}])
103 WorkflowRule.delete_all(["old_status_id = :id OR new_status_id = :id", {:id => id}])
104 end
104 end
105 end
105 end
General Comments 0
You need to be logged in to leave comments. Login now