##// END OF EJS Templates
jro_apps » redmine
RSS
Merged r4378 from trunk....
Jean-Philippe Lang -
r4284:2b9a5bf6e2d0
parent child
Show More
Side by Side Unified
Context file:
r4284:2b9a5bf6e2d0 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,328 +1,328
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
24 24 before_filter :find_project, :only => [:new, :create]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
29 29 accept_key_auth :index, :show
30 30
31 31 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
32 32
33 33 helper :journals
34 34 helper :projects
35 35 include ProjectsHelper
36 36 helper :custom_fields
37 37 include CustomFieldsHelper
38 38 helper :issue_relations
39 39 include IssueRelationsHelper
40 40 helper :watchers
41 41 include WatchersHelper
42 42 helper :attachments
43 43 include AttachmentsHelper
44 44 helper :queries
45 45 include QueriesHelper
46 46 helper :sort
47 47 include SortHelper
48 48 include IssuesHelper
49 49 helper :timelog
50 50 include Redmine::Export::PDF
51 51
52 52 verify :method => [:post, :delete],
53 53 :only => :destroy,
54 54 :render => { :nothing => true, :status => :method_not_allowed }
55 55
56 56 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
57 57 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
58 58 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
59 59
60 60 def index
61 61 retrieve_query
62 62 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
63 63 sort_update(@query.sortable_columns)
64 64
65 65 if @query.valid?
66 66 limit = case params[:format]
67 67 when 'csv', 'pdf'
68 68 Setting.issues_export_limit.to_i
69 69 when 'atom'
70 70 Setting.feeds_limit.to_i
71 71 else
72 72 per_page_option
73 73 end
74 74
75 75 @issue_count = @query.issue_count
76 76 @issue_pages = Paginator.new self, @issue_count, limit, params['page']
77 77 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
78 78 :order => sort_clause,
79 79 :offset => @issue_pages.current.offset,
80 80 :limit => limit)
81 81 @issue_count_by_group = @query.issue_count_by_group
82 82
83 83 respond_to do |format|
84 84 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
85 85 format.xml { render :layout => false }
86 86 format.json { render :text => @issues.to_json, :layout => false }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
90 90 end
91 91 else
92 92 # Send html if the query is not valid
93 93 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
94 94 end
95 95 rescue ActiveRecord::RecordNotFound
96 96 render_404
97 97 end
98 98
99 99 def show
100 100 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
101 101 @journals.each_with_index {|j,i| j.indice = i+1}
102 102 @journals.reverse! if User.current.wants_comments_in_reverse_order?
103 103 @changesets = @issue.changesets.visible.all
104 104 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
105 105 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
106 106 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
107 107 @priorities = IssuePriority.all
108 108 @time_entry = TimeEntry.new
109 109 respond_to do |format|
110 110 format.html { render :template => 'issues/show.rhtml' }
111 111 format.xml { render :layout => false }
112 112 format.json { render :text => @issue.to_json, :layout => false }
113 113 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
114 114 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
115 115 end
116 116 end
117 117
118 118 # Add a new issue
119 119 # The new issue will be created from an existing one if copy_from parameter is given
120 120 def new
121 121 respond_to do |format|
122 122 format.html { render :action => 'new', :layout => !request.xhr? }
123 123 format.js { render :partial => 'attributes' }
124 124 end
125 125 end
126 126
127 127 def create
128 128 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
129 129 if @issue.save
130 130 attachments = Attachment.attach_files(@issue, params[:attachments])
131 131 render_attachment_warning_if_needed(@issue)
132 132 flash[:notice] = l(:notice_successful_create)
133 133 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
134 134 respond_to do |format|
135 135 format.html {
136 136 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
137 137 { :action => 'show', :id => @issue })
138 138 }
139 139 format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
140 140 format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
141 141 end
142 142 return
143 143 else
144 144 respond_to do |format|
145 145 format.html { render :action => 'new' }
146 146 format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
147 147 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
148 148 end
149 149 end
150 150 end
151 151
152 152 # Attributes that can be updated on workflow transition (without :edit permission)
153 153 # TODO: make it configurable (at least per role)
154 154 UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
155 155
156 156 def edit
157 157 update_issue_from_params
158 158
159 159 @journal = @issue.current_journal
160 160
161 161 respond_to do |format|
162 162 format.html { }
163 163 format.xml { }
164 164 end
165 165 end
166 166
167 167 def update
168 168 update_issue_from_params
169 169
170 170 if @issue.save_issue_with_child_records(params, @time_entry)
171 171 render_attachment_warning_if_needed(@issue)
172 172 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
173 173
174 174 respond_to do |format|
175 175 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
176 176 format.xml { head :ok }
177 177 format.json { head :ok }
178 178 end
179 179 else
180 180 render_attachment_warning_if_needed(@issue)
181 181 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
182 182 @journal = @issue.current_journal
183 183
184 184 respond_to do |format|
185 185 format.html { render :action => 'edit' }
186 186 format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }
187 187 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
188 188 end
189 189 end
190 190 end
191 191
192 192 # Bulk edit a set of issues
193 193 def bulk_edit
194 194 @issues.sort!
195 195 @available_statuses = Workflow.available_statuses(@project)
196 196 @custom_fields = @project.all_issue_custom_fields
197 197 end
198 198
199 199 def bulk_update
200 200 @issues.sort!
201 201 attributes = parse_params_for_bulk_issue_attributes(params)
202 202
203 203 unsaved_issue_ids = []
204 204 @issues.each do |issue|
205 205 issue.reload
206 206 journal = issue.init_journal(User.current, params[:notes])
207 207 issue.safe_attributes = attributes
208 208 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
209 209 unless issue.save
210 210 # Keep unsaved issue ids to display them in flash error
211 211 unsaved_issue_ids << issue.id
212 212 end
213 213 end
214 214 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
215 215 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
216 216 end
217 217
218 218 def destroy
219 219 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
220 220 if @hours > 0
221 221 case params[:todo]
222 222 when 'destroy'
223 223 # nothing to do
224 224 when 'nullify'
225 225 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
226 226 when 'reassign'
227 227 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
228 228 if reassign_to.nil?
229 229 flash.now[:error] = l(:error_issue_not_found_in_project)
230 230 return
231 231 else
232 232 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
233 233 end
234 234 else
235 235 unless params[:format] == 'xml' || params[:format] == 'json'
236 236 # display the destroy form if it's a user request
237 237 return
238 238 end
239 239 end
240 240 end
241 241 @issues.each(&:destroy)
242 242 respond_to do |format|
243 243 format.html { redirect_to :action => 'index', :project_id => @project }
244 244 format.xml { head :ok }
245 245 format.json { head :ok }
246 246 end
247 247 end
248 248
249 249 private
250 250 def find_issue
251 251 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
252 252 @project = @issue.project
253 253 rescue ActiveRecord::RecordNotFound
254 254 render_404
255 255 end
256 256
257 257 def find_project
258 258 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
259 259 @project = Project.find(project_id)
260 260 rescue ActiveRecord::RecordNotFound
261 261 render_404
262 262 end
263 263
264 264 # Used by #edit and #update to set some common instance variables
265 265 # from the params
266 266 # TODO: Refactor, not everything in here is needed by #edit
267 267 def update_issue_from_params
268 268 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
269 269 @priorities = IssuePriority.all
270 270 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
271 271 @time_entry = TimeEntry.new
272 272
273 273 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
274 274 @issue.init_journal(User.current, @notes)
275 275 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
276 276 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
277 277 attrs = params[:issue].dup
278 278 attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
279 279 attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
280 280 @issue.safe_attributes = attrs
281 281 end
282 282
283 283 end
284 284
285 285 # TODO: Refactor, lots of extra code in here
286 286 # TODO: Changing tracker on an existing issue should not trigger this
287 287 def build_new_issue_from_params
288 288 if params[:id].blank?
289 289 @issue = Issue.new
290 290 @issue.copy_from(params[:copy_from]) if params[:copy_from]
291 291 @issue.project = @project
292 292 else
293 293 @issue = @project.issues.visible.find(params[:id])
294 294 end
295 295
296 296 @issue.project = @project
297 297 # Tracker must be set before custom field values
298 298 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
299 299 if @issue.tracker.nil?
300 300 render_error l(:error_no_tracker_in_project)
301 301 return false
302 302 end
303 @issue.start_date ||= Date.today
303 304 if params[:issue].is_a?(Hash)
304 305 @issue.safe_attributes = params[:issue]
305 306 if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
306 307 @issue.watcher_user_ids = params[:issue]['watcher_user_ids']
307 308 end
308 309 end
309 310 @issue.author = User.current
310 @issue.start_date ||= Date.today
311 311 @priorities = IssuePriority.all
312 312 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
313 313 end
314 314
315 315 def check_for_default_issue_status
316 316 if IssueStatus.default.nil?
317 317 render_error l(:error_no_default_issue_status)
318 318 return false
319 319 end
320 320 end
321 321
322 322 def parse_params_for_bulk_issue_attributes(params)
323 323 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
324 324 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
325 325 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
326 326 attributes
327 327 end
328 328 end
Show file before | Show file after | Hide comments
@@ -1,1070 +1,1092
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.dirname(__FILE__) + '/../test_helper'
19 19 require 'issues_controller'
20 20
21 21 # Re-raise errors caught by the controller.
22 22 class IssuesController; def rescue_action(e) raise e end; end
23 23
24 24 class IssuesControllerTest < ActionController::TestCase
25 25 fixtures :projects,
26 26 :users,
27 27 :roles,
28 28 :members,
29 29 :member_roles,
30 30 :issues,
31 31 :issue_statuses,
32 32 :versions,
33 33 :trackers,
34 34 :projects_trackers,
35 35 :issue_categories,
36 36 :enabled_modules,
37 37 :enumerations,
38 38 :attachments,
39 39 :workflows,
40 40 :custom_fields,
41 41 :custom_values,
42 42 :custom_fields_projects,
43 43 :custom_fields_trackers,
44 44 :time_entries,
45 45 :journals,
46 46 :journal_details,
47 47 :queries
48 48
49 49 def setup
50 50 @controller = IssuesController.new
51 51 @request = ActionController::TestRequest.new
52 52 @response = ActionController::TestResponse.new
53 53 User.current = nil
54 54 end
55 55
56 56 def test_index
57 57 Setting.default_language = 'en'
58 58
59 59 get :index
60 60 assert_response :success
61 61 assert_template 'index.rhtml'
62 62 assert_not_nil assigns(:issues)
63 63 assert_nil assigns(:project)
64 64 assert_tag :tag => 'a', :content => /Can't print recipes/
65 65 assert_tag :tag => 'a', :content => /Subproject issue/
66 66 # private projects hidden
67 67 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
68 68 assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 69 # project column
70 70 assert_tag :tag => 'th', :content => /Project/
71 71 end
72 72
73 73 def test_index_should_not_list_issues_when_module_disabled
74 74 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
75 75 get :index
76 76 assert_response :success
77 77 assert_template 'index.rhtml'
78 78 assert_not_nil assigns(:issues)
79 79 assert_nil assigns(:project)
80 80 assert_no_tag :tag => 'a', :content => /Can't print recipes/
81 81 assert_tag :tag => 'a', :content => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_not_list_issues_when_module_disabled
85 85 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
86 86 get :index
87 87 assert_response :success
88 88 assert_template 'index.rhtml'
89 89 assert_not_nil assigns(:issues)
90 90 assert_nil assigns(:project)
91 91 assert_no_tag :tag => 'a', :content => /Can't print recipes/
92 92 assert_tag :tag => 'a', :content => /Subproject issue/
93 93 end
94 94
95 95 def test_index_with_project
96 96 Setting.display_subprojects_issues = 0
97 97 get :index, :project_id => 1
98 98 assert_response :success
99 99 assert_template 'index.rhtml'
100 100 assert_not_nil assigns(:issues)
101 101 assert_tag :tag => 'a', :content => /Can't print recipes/
102 102 assert_no_tag :tag => 'a', :content => /Subproject issue/
103 103 end
104 104
105 105 def test_index_with_project_and_subprojects
106 106 Setting.display_subprojects_issues = 1
107 107 get :index, :project_id => 1
108 108 assert_response :success
109 109 assert_template 'index.rhtml'
110 110 assert_not_nil assigns(:issues)
111 111 assert_tag :tag => 'a', :content => /Can't print recipes/
112 112 assert_tag :tag => 'a', :content => /Subproject issue/
113 113 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
114 114 end
115 115
116 116 def test_index_with_project_and_subprojects_should_show_private_subprojects
117 117 @request.session[:user_id] = 2
118 118 Setting.display_subprojects_issues = 1
119 119 get :index, :project_id => 1
120 120 assert_response :success
121 121 assert_template 'index.rhtml'
122 122 assert_not_nil assigns(:issues)
123 123 assert_tag :tag => 'a', :content => /Can't print recipes/
124 124 assert_tag :tag => 'a', :content => /Subproject issue/
125 125 assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 126 end
127 127
128 128 def test_index_with_project_and_filter
129 129 get :index, :project_id => 1, :set_filter => 1
130 130 assert_response :success
131 131 assert_template 'index.rhtml'
132 132 assert_not_nil assigns(:issues)
133 133 end
134 134
135 135 def test_index_with_query
136 136 get :index, :project_id => 1, :query_id => 5
137 137 assert_response :success
138 138 assert_template 'index.rhtml'
139 139 assert_not_nil assigns(:issues)
140 140 assert_nil assigns(:issue_count_by_group)
141 141 end
142 142
143 143 def test_index_with_query_grouped_by_tracker
144 144 get :index, :project_id => 1, :query_id => 6
145 145 assert_response :success
146 146 assert_template 'index.rhtml'
147 147 assert_not_nil assigns(:issues)
148 148 assert_not_nil assigns(:issue_count_by_group)
149 149 end
150 150
151 151 def test_index_with_query_grouped_by_list_custom_field
152 152 get :index, :project_id => 1, :query_id => 9
153 153 assert_response :success
154 154 assert_template 'index.rhtml'
155 155 assert_not_nil assigns(:issues)
156 156 assert_not_nil assigns(:issue_count_by_group)
157 157 end
158 158
159 159 def test_index_sort_by_field_not_included_in_columns
160 160 Setting.issue_list_default_columns = %w(subject author)
161 161 get :index, :sort => 'tracker'
162 162 end
163 163
164 164 def test_index_csv_with_project
165 165 Setting.default_language = 'en'
166 166
167 167 get :index, :format => 'csv'
168 168 assert_response :success
169 169 assert_not_nil assigns(:issues)
170 170 assert_equal 'text/csv', @response.content_type
171 171 assert @response.body.starts_with?("#,")
172 172
173 173 get :index, :project_id => 1, :format => 'csv'
174 174 assert_response :success
175 175 assert_not_nil assigns(:issues)
176 176 assert_equal 'text/csv', @response.content_type
177 177 end
178 178
179 179 def test_index_pdf
180 180 get :index, :format => 'pdf'
181 181 assert_response :success
182 182 assert_not_nil assigns(:issues)
183 183 assert_equal 'application/pdf', @response.content_type
184 184
185 185 get :index, :project_id => 1, :format => 'pdf'
186 186 assert_response :success
187 187 assert_not_nil assigns(:issues)
188 188 assert_equal 'application/pdf', @response.content_type
189 189
190 190 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
191 191 assert_response :success
192 192 assert_not_nil assigns(:issues)
193 193 assert_equal 'application/pdf', @response.content_type
194 194 end
195 195
196 196 def test_index_pdf_with_query_grouped_by_list_custom_field
197 197 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
198 198 assert_response :success
199 199 assert_not_nil assigns(:issues)
200 200 assert_not_nil assigns(:issue_count_by_group)
201 201 assert_equal 'application/pdf', @response.content_type
202 202 end
203 203
204 204 def test_index_sort
205 205 get :index, :sort => 'tracker,id:desc'
206 206 assert_response :success
207 207
208 208 sort_params = @request.session['issues_index_sort']
209 209 assert sort_params.is_a?(String)
210 210 assert_equal 'tracker,id:desc', sort_params
211 211
212 212 issues = assigns(:issues)
213 213 assert_not_nil issues
214 214 assert !issues.empty?
215 215 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
216 216 end
217 217
218 218 def test_index_with_columns
219 219 columns = ['tracker', 'subject', 'assigned_to']
220 220 get :index, :set_filter => 1, :query => { 'column_names' => columns}
221 221 assert_response :success
222 222
223 223 # query should use specified columns
224 224 query = assigns(:query)
225 225 assert_kind_of Query, query
226 226 assert_equal columns, query.column_names.map(&:to_s)
227 227
228 228 # columns should be stored in session
229 229 assert_kind_of Hash, session[:query]
230 230 assert_kind_of Array, session[:query][:column_names]
231 231 assert_equal columns, session[:query][:column_names].map(&:to_s)
232 232 end
233 233
234 234 def test_show_by_anonymous
235 235 get :show, :id => 1
236 236 assert_response :success
237 237 assert_template 'show.rhtml'
238 238 assert_not_nil assigns(:issue)
239 239 assert_equal Issue.find(1), assigns(:issue)
240 240
241 241 # anonymous role is allowed to add a note
242 242 assert_tag :tag => 'form',
243 243 :descendant => { :tag => 'fieldset',
244 244 :child => { :tag => 'legend',
245 245 :content => /Notes/ } }
246 246 end
247 247
248 248 def test_show_by_manager
249 249 @request.session[:user_id] = 2
250 250 get :show, :id => 1
251 251 assert_response :success
252 252
253 253 assert_tag :tag => 'form',
254 254 :descendant => { :tag => 'fieldset',
255 255 :child => { :tag => 'legend',
256 256 :content => /Change properties/ } },
257 257 :descendant => { :tag => 'fieldset',
258 258 :child => { :tag => 'legend',
259 259 :content => /Log time/ } },
260 260 :descendant => { :tag => 'fieldset',
261 261 :child => { :tag => 'legend',
262 262 :content => /Notes/ } }
263 263 end
264 264
265 265 def test_show_should_deny_anonymous_access_without_permission
266 266 Role.anonymous.remove_permission!(:view_issues)
267 267 get :show, :id => 1
268 268 assert_response :redirect
269 269 end
270 270
271 271 def test_show_should_deny_non_member_access_without_permission
272 272 Role.non_member.remove_permission!(:view_issues)
273 273 @request.session[:user_id] = 9
274 274 get :show, :id => 1
275 275 assert_response 403
276 276 end
277 277
278 278 def test_show_should_deny_member_access_without_permission
279 279 Role.find(1).remove_permission!(:view_issues)
280 280 @request.session[:user_id] = 2
281 281 get :show, :id => 1
282 282 assert_response 403
283 283 end
284 284
285 285 def test_show_should_not_disclose_relations_to_invisible_issues
286 286 Setting.cross_project_issue_relations = '1'
287 287 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
288 288 # Relation to a private project issue
289 289 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
290 290
291 291 get :show, :id => 1
292 292 assert_response :success
293 293
294 294 assert_tag :div, :attributes => { :id => 'relations' },
295 295 :descendant => { :tag => 'a', :content => /#2$/ }
296 296 assert_no_tag :div, :attributes => { :id => 'relations' },
297 297 :descendant => { :tag => 'a', :content => /#4$/ }
298 298 end
299 299
300 300 def test_show_atom
301 301 get :show, :id => 2, :format => 'atom'
302 302 assert_response :success
303 303 assert_template 'journals/index.rxml'
304 304 # Inline image
305 305 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
306 306 end
307 307
308 308 def test_show_export_to_pdf
309 309 get :show, :id => 3, :format => 'pdf'
310 310 assert_response :success
311 311 assert_equal 'application/pdf', @response.content_type
312 312 assert @response.body.starts_with?('%PDF')
313 313 assert_not_nil assigns(:issue)
314 314 end
315 315
316 316 def test_get_new
317 317 @request.session[:user_id] = 2
318 318 get :new, :project_id => 1, :tracker_id => 1
319 319 assert_response :success
320 320 assert_template 'new'
321 321
322 322 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
323 323 :value => 'Default string' }
324 324 end
325 325
326 326 def test_get_new_without_tracker_id
327 327 @request.session[:user_id] = 2
328 328 get :new, :project_id => 1
329 329 assert_response :success
330 330 assert_template 'new'
331 331
332 332 issue = assigns(:issue)
333 333 assert_not_nil issue
334 334 assert_equal Project.find(1).trackers.first, issue.tracker
335 335 end
336 336
337 337 def test_get_new_with_no_default_status_should_display_an_error
338 338 @request.session[:user_id] = 2
339 339 IssueStatus.delete_all
340 340
341 341 get :new, :project_id => 1
342 342 assert_response 500
343 343 assert_not_nil flash[:error]
344 344 assert_tag :tag => 'div', :attributes => { :class => /error/ },
345 345 :content => /No default issue/
346 346 end
347 347
348 348 def test_get_new_with_no_tracker_should_display_an_error
349 349 @request.session[:user_id] = 2
350 350 Tracker.delete_all
351 351
352 352 get :new, :project_id => 1
353 353 assert_response 500
354 354 assert_not_nil flash[:error]
355 355 assert_tag :tag => 'div', :attributes => { :class => /error/ },
356 356 :content => /No tracker/
357 357 end
358 358
359 359 def test_update_new_form
360 360 @request.session[:user_id] = 2
361 361 xhr :post, :new, :project_id => 1,
362 362 :issue => {:tracker_id => 2,
363 363 :subject => 'This is the test_new issue',
364 364 :description => 'This is the description',
365 365 :priority_id => 5}
366 366 assert_response :success
367 367 assert_template 'attributes'
368 368
369 369 issue = assigns(:issue)
370 370 assert_kind_of Issue, issue
371 371 assert_equal 1, issue.project_id
372 372 assert_equal 2, issue.tracker_id
373 373 assert_equal 'This is the test_new issue', issue.subject
374 374 end
375 375
376 376 def test_post_create
377 377 @request.session[:user_id] = 2
378 378 assert_difference 'Issue.count' do
379 379 post :create, :project_id => 1,
380 380 :issue => {:tracker_id => 3,
381 381 :status_id => 2,
382 382 :subject => 'This is the test_new issue',
383 383 :description => 'This is the description',
384 384 :priority_id => 5,
385 :start_date => '2010-11-07',
385 386 :estimated_hours => '',
386 387 :custom_field_values => {'2' => 'Value for field 2'}}
387 388 end
388 389 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
389 390
390 391 issue = Issue.find_by_subject('This is the test_new issue')
391 392 assert_not_nil issue
392 393 assert_equal 2, issue.author_id
393 394 assert_equal 3, issue.tracker_id
394 395 assert_equal 2, issue.status_id
396 assert_equal Date.parse('2010-11-07'), issue.start_date
395 397 assert_nil issue.estimated_hours
396 398 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
397 399 assert_not_nil v
398 400 assert_equal 'Value for field 2', v.value
399 401 end
400 402
403 def test_post_create_without_start_date
404 @request.session[:user_id] = 2
405 assert_difference 'Issue.count' do
406 post :create, :project_id => 1,
407 :issue => {:tracker_id => 3,
408 :status_id => 2,
409 :subject => 'This is the test_new issue',
410 :description => 'This is the description',
411 :priority_id => 5,
412 :start_date => '',
413 :estimated_hours => '',
414 :custom_field_values => {'2' => 'Value for field 2'}}
415 end
416 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
417
418 issue = Issue.find_by_subject('This is the test_new issue')
419 assert_not_nil issue
420 assert_nil issue.start_date
421 end
422
401 423 def test_post_create_and_continue
402 424 @request.session[:user_id] = 2
403 425 post :create, :project_id => 1,
404 426 :issue => {:tracker_id => 3,
405 427 :subject => 'This is first issue',
406 428 :priority_id => 5},
407 429 :continue => ''
408 430 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook',
409 431 :issue => {:tracker_id => 3}
410 432 end
411 433
412 434 def test_post_create_without_custom_fields_param
413 435 @request.session[:user_id] = 2
414 436 assert_difference 'Issue.count' do
415 437 post :create, :project_id => 1,
416 438 :issue => {:tracker_id => 1,
417 439 :subject => 'This is the test_new issue',
418 440 :description => 'This is the description',
419 441 :priority_id => 5}
420 442 end
421 443 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
422 444 end
423 445
424 446 def test_post_create_with_required_custom_field_and_without_custom_fields_param
425 447 field = IssueCustomField.find_by_name('Database')
426 448 field.update_attribute(:is_required, true)
427 449
428 450 @request.session[:user_id] = 2
429 451 post :create, :project_id => 1,
430 452 :issue => {:tracker_id => 1,
431 453 :subject => 'This is the test_new issue',
432 454 :description => 'This is the description',
433 455 :priority_id => 5}
434 456 assert_response :success
435 457 assert_template 'new'
436 458 issue = assigns(:issue)
437 459 assert_not_nil issue
438 460 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
439 461 end
440 462
441 463 def test_post_create_with_watchers
442 464 @request.session[:user_id] = 2
443 465 ActionMailer::Base.deliveries.clear
444 466
445 467 assert_difference 'Watcher.count', 2 do
446 468 post :create, :project_id => 1,
447 469 :issue => {:tracker_id => 1,
448 470 :subject => 'This is a new issue with watchers',
449 471 :description => 'This is the description',
450 472 :priority_id => 5,
451 473 :watcher_user_ids => ['2', '3']}
452 474 end
453 475 issue = Issue.find_by_subject('This is a new issue with watchers')
454 476 assert_not_nil issue
455 477 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
456 478
457 479 # Watchers added
458 480 assert_equal [2, 3], issue.watcher_user_ids.sort
459 481 assert issue.watched_by?(User.find(3))
460 482 # Watchers notified
461 483 mail = ActionMailer::Base.deliveries.last
462 484 assert_kind_of TMail::Mail, mail
463 485 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
464 486 end
465 487
466 488 def test_post_create_subissue
467 489 @request.session[:user_id] = 2
468 490
469 491 assert_difference 'Issue.count' do
470 492 post :create, :project_id => 1,
471 493 :issue => {:tracker_id => 1,
472 494 :subject => 'This is a child issue',
473 495 :parent_issue_id => 2}
474 496 end
475 497 issue = Issue.find_by_subject('This is a child issue')
476 498 assert_not_nil issue
477 499 assert_equal Issue.find(2), issue.parent
478 500 end
479 501
480 502 def test_post_create_should_send_a_notification
481 503 ActionMailer::Base.deliveries.clear
482 504 @request.session[:user_id] = 2
483 505 assert_difference 'Issue.count' do
484 506 post :create, :project_id => 1,
485 507 :issue => {:tracker_id => 3,
486 508 :subject => 'This is the test_new issue',
487 509 :description => 'This is the description',
488 510 :priority_id => 5,
489 511 :estimated_hours => '',
490 512 :custom_field_values => {'2' => 'Value for field 2'}}
491 513 end
492 514 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
493 515
494 516 assert_equal 1, ActionMailer::Base.deliveries.size
495 517 end
496 518
497 519 def test_post_create_should_preserve_fields_values_on_validation_failure
498 520 @request.session[:user_id] = 2
499 521 post :create, :project_id => 1,
500 522 :issue => {:tracker_id => 1,
501 523 # empty subject
502 524 :subject => '',
503 525 :description => 'This is a description',
504 526 :priority_id => 6,
505 527 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
506 528 assert_response :success
507 529 assert_template 'new'
508 530
509 531 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
510 532 :content => 'This is a description'
511 533 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
512 534 :child => { :tag => 'option', :attributes => { :selected => 'selected',
513 535 :value => '6' },
514 536 :content => 'High' }
515 537 # Custom fields
516 538 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
517 539 :child => { :tag => 'option', :attributes => { :selected => 'selected',
518 540 :value => 'Oracle' },
519 541 :content => 'Oracle' }
520 542 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
521 543 :value => 'Value for field 2'}
522 544 end
523 545
524 546 def test_post_create_should_ignore_non_safe_attributes
525 547 @request.session[:user_id] = 2
526 548 assert_nothing_raised do
527 549 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
528 550 end
529 551 end
530 552
531 553 context "without workflow privilege" do
532 554 setup do
533 555 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
534 556 Role.anonymous.add_permission! :add_issues
535 557 end
536 558
537 559 context "#new" do
538 560 should "propose default status only" do
539 561 get :new, :project_id => 1
540 562 assert_response :success
541 563 assert_template 'new'
542 564 assert_tag :tag => 'select',
543 565 :attributes => {:name => 'issue[status_id]'},
544 566 :children => {:count => 1},
545 567 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
546 568 end
547 569
548 570 should "accept default status" do
549 571 assert_difference 'Issue.count' do
550 572 post :create, :project_id => 1,
551 573 :issue => {:tracker_id => 1,
552 574 :subject => 'This is an issue',
553 575 :status_id => 1}
554 576 end
555 577 issue = Issue.last(:order => 'id')
556 578 assert_equal IssueStatus.default, issue.status
557 579 end
558 580
559 581 should "ignore unauthorized status" do
560 582 assert_difference 'Issue.count' do
561 583 post :create, :project_id => 1,
562 584 :issue => {:tracker_id => 1,
563 585 :subject => 'This is an issue',
564 586 :status_id => 3}
565 587 end
566 588 issue = Issue.last(:order => 'id')
567 589 assert_equal IssueStatus.default, issue.status
568 590 end
569 591 end
570 592 end
571 593
572 594 def test_copy_issue
573 595 @request.session[:user_id] = 2
574 596 get :new, :project_id => 1, :copy_from => 1
575 597 assert_template 'new'
576 598 assert_not_nil assigns(:issue)
577 599 orig = Issue.find(1)
578 600 assert_equal orig.subject, assigns(:issue).subject
579 601 end
580 602
581 603 def test_get_edit
582 604 @request.session[:user_id] = 2
583 605 get :edit, :id => 1
584 606 assert_response :success
585 607 assert_template 'edit'
586 608 assert_not_nil assigns(:issue)
587 609 assert_equal Issue.find(1), assigns(:issue)
588 610 end
589 611
590 612 def test_get_edit_with_params
591 613 @request.session[:user_id] = 2
592 614 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
593 615 assert_response :success
594 616 assert_template 'edit'
595 617
596 618 issue = assigns(:issue)
597 619 assert_not_nil issue
598 620
599 621 assert_equal 5, issue.status_id
600 622 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
601 623 :child => { :tag => 'option',
602 624 :content => 'Closed',
603 625 :attributes => { :selected => 'selected' } }
604 626
605 627 assert_equal 7, issue.priority_id
606 628 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
607 629 :child => { :tag => 'option',
608 630 :content => 'Urgent',
609 631 :attributes => { :selected => 'selected' } }
610 632 end
611 633
612 634 def test_update_edit_form
613 635 @request.session[:user_id] = 2
614 636 xhr :post, :new, :project_id => 1,
615 637 :id => 1,
616 638 :issue => {:tracker_id => 2,
617 639 :subject => 'This is the test_new issue',
618 640 :description => 'This is the description',
619 641 :priority_id => 5}
620 642 assert_response :success
621 643 assert_template 'attributes'
622 644
623 645 issue = assigns(:issue)
624 646 assert_kind_of Issue, issue
625 647 assert_equal 1, issue.id
626 648 assert_equal 1, issue.project_id
627 649 assert_equal 2, issue.tracker_id
628 650 assert_equal 'This is the test_new issue', issue.subject
629 651 end
630 652
631 653 def test_update_using_invalid_http_verbs
632 654 @request.session[:user_id] = 2
633 655 subject = 'Updated by an invalid http verb'
634 656
635 657 get :update, :id => 1, :issue => {:subject => subject}
636 658 assert_not_equal subject, Issue.find(1).subject
637 659
638 660 post :update, :id => 1, :issue => {:subject => subject}
639 661 assert_not_equal subject, Issue.find(1).subject
640 662
641 663 delete :update, :id => 1, :issue => {:subject => subject}
642 664 assert_not_equal subject, Issue.find(1).subject
643 665 end
644 666
645 667 def test_put_update_without_custom_fields_param
646 668 @request.session[:user_id] = 2
647 669 ActionMailer::Base.deliveries.clear
648 670
649 671 issue = Issue.find(1)
650 672 assert_equal '125', issue.custom_value_for(2).value
651 673 old_subject = issue.subject
652 674 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
653 675
654 676 assert_difference('Journal.count') do
655 677 assert_difference('JournalDetail.count', 2) do
656 678 put :update, :id => 1, :issue => {:subject => new_subject,
657 679 :priority_id => '6',
658 680 :category_id => '1' # no change
659 681 }
660 682 end
661 683 end
662 684 assert_redirected_to :action => 'show', :id => '1'
663 685 issue.reload
664 686 assert_equal new_subject, issue.subject
665 687 # Make sure custom fields were not cleared
666 688 assert_equal '125', issue.custom_value_for(2).value
667 689
668 690 mail = ActionMailer::Base.deliveries.last
669 691 assert_kind_of TMail::Mail, mail
670 692 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
671 693 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
672 694 end
673 695
674 696 def test_put_update_with_custom_field_change
675 697 @request.session[:user_id] = 2
676 698 issue = Issue.find(1)
677 699 assert_equal '125', issue.custom_value_for(2).value
678 700
679 701 assert_difference('Journal.count') do
680 702 assert_difference('JournalDetail.count', 3) do
681 703 put :update, :id => 1, :issue => {:subject => 'Custom field change',
682 704 :priority_id => '6',
683 705 :category_id => '1', # no change
684 706 :custom_field_values => { '2' => 'New custom value' }
685 707 }
686 708 end
687 709 end
688 710 assert_redirected_to :action => 'show', :id => '1'
689 711 issue.reload
690 712 assert_equal 'New custom value', issue.custom_value_for(2).value
691 713
692 714 mail = ActionMailer::Base.deliveries.last
693 715 assert_kind_of TMail::Mail, mail
694 716 assert mail.body.include?("Searchable field changed from 125 to New custom value")
695 717 end
696 718
697 719 def test_put_update_with_status_and_assignee_change
698 720 issue = Issue.find(1)
699 721 assert_equal 1, issue.status_id
700 722 @request.session[:user_id] = 2
701 723 assert_difference('TimeEntry.count', 0) do
702 724 put :update,
703 725 :id => 1,
704 726 :issue => { :status_id => 2, :assigned_to_id => 3 },
705 727 :notes => 'Assigned to dlopper',
706 728 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
707 729 end
708 730 assert_redirected_to :action => 'show', :id => '1'
709 731 issue.reload
710 732 assert_equal 2, issue.status_id
711 733 j = Journal.find(:first, :order => 'id DESC')
712 734 assert_equal 'Assigned to dlopper', j.notes
713 735 assert_equal 2, j.details.size
714 736
715 737 mail = ActionMailer::Base.deliveries.last
716 738 assert mail.body.include?("Status changed from New to Assigned")
717 739 # subject should contain the new status
718 740 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
719 741 end
720 742
721 743 def test_put_update_with_note_only
722 744 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
723 745 # anonymous user
724 746 put :update,
725 747 :id => 1,
726 748 :notes => notes
727 749 assert_redirected_to :action => 'show', :id => '1'
728 750 j = Journal.find(:first, :order => 'id DESC')
729 751 assert_equal notes, j.notes
730 752 assert_equal 0, j.details.size
731 753 assert_equal User.anonymous, j.user
732 754
733 755 mail = ActionMailer::Base.deliveries.last
734 756 assert mail.body.include?(notes)
735 757 end
736 758
737 759 def test_put_update_with_note_and_spent_time
738 760 @request.session[:user_id] = 2
739 761 spent_hours_before = Issue.find(1).spent_hours
740 762 assert_difference('TimeEntry.count') do
741 763 put :update,
742 764 :id => 1,
743 765 :notes => '2.5 hours added',
744 766 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
745 767 end
746 768 assert_redirected_to :action => 'show', :id => '1'
747 769
748 770 issue = Issue.find(1)
749 771
750 772 j = Journal.find(:first, :order => 'id DESC')
751 773 assert_equal '2.5 hours added', j.notes
752 774 assert_equal 0, j.details.size
753 775
754 776 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
755 777 assert_not_nil t
756 778 assert_equal 2.5, t.hours
757 779 assert_equal spent_hours_before + 2.5, issue.spent_hours
758 780 end
759 781
760 782 def test_put_update_with_attachment_only
761 783 set_tmp_attachments_directory
762 784
763 785 # Delete all fixtured journals, a race condition can occur causing the wrong
764 786 # journal to get fetched in the next find.
765 787 Journal.delete_all
766 788
767 789 # anonymous user
768 790 put :update,
769 791 :id => 1,
770 792 :notes => '',
771 793 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
772 794 assert_redirected_to :action => 'show', :id => '1'
773 795 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
774 796 assert j.notes.blank?
775 797 assert_equal 1, j.details.size
776 798 assert_equal 'testfile.txt', j.details.first.value
777 799 assert_equal User.anonymous, j.user
778 800
779 801 mail = ActionMailer::Base.deliveries.last
780 802 assert mail.body.include?('testfile.txt')
781 803 end
782 804
783 805 def test_put_update_with_attachment_that_fails_to_save
784 806 set_tmp_attachments_directory
785 807
786 808 # Delete all fixtured journals, a race condition can occur causing the wrong
787 809 # journal to get fetched in the next find.
788 810 Journal.delete_all
789 811
790 812 # Mock out the unsaved attachment
791 813 Attachment.any_instance.stubs(:create).returns(Attachment.new)
792 814
793 815 # anonymous user
794 816 put :update,
795 817 :id => 1,
796 818 :notes => '',
797 819 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
798 820 assert_redirected_to :action => 'show', :id => '1'
799 821 assert_equal '1 file(s) could not be saved.', flash[:warning]
800 822
801 823 end if Object.const_defined?(:Mocha)
802 824
803 825 def test_put_update_with_no_change
804 826 issue = Issue.find(1)
805 827 issue.journals.clear
806 828 ActionMailer::Base.deliveries.clear
807 829
808 830 put :update,
809 831 :id => 1,
810 832 :notes => ''
811 833 assert_redirected_to :action => 'show', :id => '1'
812 834
813 835 issue.reload
814 836 assert issue.journals.empty?
815 837 # No email should be sent
816 838 assert ActionMailer::Base.deliveries.empty?
817 839 end
818 840
819 841 def test_put_update_should_send_a_notification
820 842 @request.session[:user_id] = 2
821 843 ActionMailer::Base.deliveries.clear
822 844 issue = Issue.find(1)
823 845 old_subject = issue.subject
824 846 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
825 847
826 848 put :update, :id => 1, :issue => {:subject => new_subject,
827 849 :priority_id => '6',
828 850 :category_id => '1' # no change
829 851 }
830 852 assert_equal 1, ActionMailer::Base.deliveries.size
831 853 end
832 854
833 855 def test_put_update_with_invalid_spent_time
834 856 @request.session[:user_id] = 2
835 857 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
836 858
837 859 assert_no_difference('Journal.count') do
838 860 put :update,
839 861 :id => 1,
840 862 :notes => notes,
841 863 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
842 864 end
843 865 assert_response :success
844 866 assert_template 'edit'
845 867
846 868 assert_tag :textarea, :attributes => { :name => 'notes' },
847 869 :content => notes
848 870 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
849 871 end
850 872
851 873 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
852 874 issue = Issue.find(2)
853 875 @request.session[:user_id] = 2
854 876
855 877 put :update,
856 878 :id => issue.id,
857 879 :issue => {
858 880 :fixed_version_id => 4
859 881 }
860 882
861 883 assert_response :redirect
862 884 issue.reload
863 885 assert_equal 4, issue.fixed_version_id
864 886 assert_not_equal issue.project_id, issue.fixed_version.project_id
865 887 end
866 888
867 889 def test_put_update_should_redirect_back_using_the_back_url_parameter
868 890 issue = Issue.find(2)
869 891 @request.session[:user_id] = 2
870 892
871 893 put :update,
872 894 :id => issue.id,
873 895 :issue => {
874 896 :fixed_version_id => 4
875 897 },
876 898 :back_url => '/issues'
877 899
878 900 assert_response :redirect
879 901 assert_redirected_to '/issues'
880 902 end
881 903
882 904 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
883 905 issue = Issue.find(2)
884 906 @request.session[:user_id] = 2
885 907
886 908 put :update,
887 909 :id => issue.id,
888 910 :issue => {
889 911 :fixed_version_id => 4
890 912 },
891 913 :back_url => 'http://google.com'
892 914
893 915 assert_response :redirect
894 916 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
895 917 end
896 918
897 919 def test_get_bulk_edit
898 920 @request.session[:user_id] = 2
899 921 get :bulk_edit, :ids => [1, 2]
900 922 assert_response :success
901 923 assert_template 'bulk_edit'
902 924
903 925 # Project specific custom field, date type
904 926 field = CustomField.find(9)
905 927 assert !field.is_for_all?
906 928 assert_equal 'date', field.field_format
907 929 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
908 930
909 931 # System wide custom field
910 932 assert CustomField.find(1).is_for_all?
911 933 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
912 934 end
913 935
914 936 def test_bulk_update
915 937 @request.session[:user_id] = 2
916 938 # update issues priority
917 939 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
918 940 :issue => {:priority_id => 7,
919 941 :assigned_to_id => '',
920 942 :custom_field_values => {'2' => ''}}
921 943
922 944 assert_response 302
923 945 # check that the issues were updated
924 946 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
925 947
926 948 issue = Issue.find(1)
927 949 journal = issue.journals.find(:first, :order => 'created_on DESC')
928 950 assert_equal '125', issue.custom_value_for(2).value
929 951 assert_equal 'Bulk editing', journal.notes
930 952 assert_equal 1, journal.details.size
931 953 end
932 954
933 955 def test_bullk_update_should_send_a_notification
934 956 @request.session[:user_id] = 2
935 957 ActionMailer::Base.deliveries.clear
936 958 post(:bulk_update,
937 959 {
938 960 :ids => [1, 2],
939 961 :notes => 'Bulk editing',
940 962 :issue => {
941 963 :priority_id => 7,
942 964 :assigned_to_id => '',
943 965 :custom_field_values => {'2' => ''}
944 966 }
945 967 })
946 968
947 969 assert_response 302
948 970 assert_equal 2, ActionMailer::Base.deliveries.size
949 971 end
950 972
951 973 def test_bulk_update_status
952 974 @request.session[:user_id] = 2
953 975 # update issues priority
954 976 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
955 977 :issue => {:priority_id => '',
956 978 :assigned_to_id => '',
957 979 :status_id => '5'}
958 980
959 981 assert_response 302
960 982 issue = Issue.find(1)
961 983 assert issue.closed?
962 984 end
963 985
964 986 def test_bulk_update_custom_field
965 987 @request.session[:user_id] = 2
966 988 # update issues priority
967 989 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
968 990 :issue => {:priority_id => '',
969 991 :assigned_to_id => '',
970 992 :custom_field_values => {'2' => '777'}}
971 993
972 994 assert_response 302
973 995
974 996 issue = Issue.find(1)
975 997 journal = issue.journals.find(:first, :order => 'created_on DESC')
976 998 assert_equal '777', issue.custom_value_for(2).value
977 999 assert_equal 1, journal.details.size
978 1000 assert_equal '125', journal.details.first.old_value
979 1001 assert_equal '777', journal.details.first.value
980 1002 end
981 1003
982 1004 def test_bulk_update_unassign
983 1005 assert_not_nil Issue.find(2).assigned_to
984 1006 @request.session[:user_id] = 2
985 1007 # unassign issues
986 1008 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
987 1009 assert_response 302
988 1010 # check that the issues were updated
989 1011 assert_nil Issue.find(2).assigned_to
990 1012 end
991 1013
992 1014 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
993 1015 @request.session[:user_id] = 2
994 1016
995 1017 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
996 1018
997 1019 assert_response :redirect
998 1020 issues = Issue.find([1,2])
999 1021 issues.each do |issue|
1000 1022 assert_equal 4, issue.fixed_version_id
1001 1023 assert_not_equal issue.project_id, issue.fixed_version.project_id
1002 1024 end
1003 1025 end
1004 1026
1005 1027 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1006 1028 @request.session[:user_id] = 2
1007 1029 post :bulk_update, :ids => [1,2], :back_url => '/issues'
1008 1030
1009 1031 assert_response :redirect
1010 1032 assert_redirected_to '/issues'
1011 1033 end
1012 1034
1013 1035 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1014 1036 @request.session[:user_id] = 2
1015 1037 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1016 1038
1017 1039 assert_response :redirect
1018 1040 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
1019 1041 end
1020 1042
1021 1043 def test_destroy_issue_with_no_time_entries
1022 1044 assert_nil TimeEntry.find_by_issue_id(2)
1023 1045 @request.session[:user_id] = 2
1024 1046 post :destroy, :id => 2
1025 1047 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1026 1048 assert_nil Issue.find_by_id(2)
1027 1049 end
1028 1050
1029 1051 def test_destroy_issues_with_time_entries
1030 1052 @request.session[:user_id] = 2
1031 1053 post :destroy, :ids => [1, 3]
1032 1054 assert_response :success
1033 1055 assert_template 'destroy'
1034 1056 assert_not_nil assigns(:hours)
1035 1057 assert Issue.find_by_id(1) && Issue.find_by_id(3)
1036 1058 end
1037 1059
1038 1060 def test_destroy_issues_and_destroy_time_entries
1039 1061 @request.session[:user_id] = 2
1040 1062 post :destroy, :ids => [1, 3], :todo => 'destroy'
1041 1063 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1042 1064 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1043 1065 assert_nil TimeEntry.find_by_id([1, 2])
1044 1066 end
1045 1067
1046 1068 def test_destroy_issues_and_assign_time_entries_to_project
1047 1069 @request.session[:user_id] = 2
1048 1070 post :destroy, :ids => [1, 3], :todo => 'nullify'
1049 1071 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1050 1072 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1051 1073 assert_nil TimeEntry.find(1).issue_id
1052 1074 assert_nil TimeEntry.find(2).issue_id
1053 1075 end
1054 1076
1055 1077 def test_destroy_issues_and_reassign_time_entries_to_another_issue
1056 1078 @request.session[:user_id] = 2
1057 1079 post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
1058 1080 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1059 1081 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1060 1082 assert_equal 2, TimeEntry.find(1).issue_id
1061 1083 assert_equal 2, TimeEntry.find(2).issue_id
1062 1084 end
1063 1085
1064 1086 def test_default_search_scope
1065 1087 get :index
1066 1088 assert_tag :div, :attributes => {:id => 'quick-search'},
1067 1089 :child => {:tag => 'form',
1068 1090 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
1069 1091 end
1070 1092 end
General Comments 0
You need to be logged in to leave comments. Login now