jro_apps/redmine Commit - r12369:2a8ae016c566

Rails4: replace deprecated find_all_by_* at TimelogControllerTest...

Toshi MARUYAMA -

r12369:2a8ae016c566

parent child

Context file:

r12369:2a8ae016c566

test/functional/timelog_controller_test.rb +5 -3

                  assert_response 302
                  # check that the issues were updated
-                 assert_equal [9, 9], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.activity_id}
+                 assert_equal [9, 9], TimeEntry.where(:id => [1, 2]).collect {|i| i.activity_id}
                end
                def test_bulk_update_with_failure
                  assert_response 302
                  # check that the issues were updated
-                 assert_equal [9, 9, 9], TimeEntry.find_all_by_id([1, 2, 4]).collect {|i| i.activity_id}
+                 assert_equal [9, 9, 9], TimeEntry.where(:id => [1, 2, 4])
+                                             .collect {|i| i.activity_id}
                end
                def test_bulk_update_on_different_projects_without_rights
                  post :bulk_update, :ids => [1, 2], :time_entry => { :custom_field_values => {'10' => '0'} }
                  assert_response 302
-                 assert_equal ["0", "0"], TimeEntry.find_all_by_id([1, 2]).collect {|i| i.custom_value_for(10).value}
+                 assert_equal ["0", "0"], TimeEntry.where(:id => [1, 2])
+                                              .collect {|i| i.custom_value_for(10).value}
                end
                def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages