jro_apps/redmine Commit - r4960:28feb58754ff

Speeds up WikiHelper#wiki_page_options_for_select....

Jean-Philippe Lang -

r4960:28feb58754ff

parent child

Context file:

r4960:28feb58754ff

app/helpers/wiki_helper.rb +10 -7

              module WikiHelper
                def wiki_page_options_for_select(pages, selected = nil, parent = nil, level = 0)
+                 pages = pages.group_by(&:parent) unless pages.is_a?(Hash)
                  s = ''
-                 pages.select {|p| p.parent == parent}.each do |page|
-                   attrs = "value='#{page.id}'"
-                   attrs << " selected='selected'" if selected == page
-                   indent = (level > 0) ? ('&nbsp;' * level * 2 + '&#187; ') : nil
-                   s << "<option #{attrs}>#{indent}#{h page.pretty_title}</option>\n" +
-                          wiki_page_options_for_select(pages, selected, page, level + 1)
+                 if pages.has_key?(parent)
+                   pages[parent].each do |page|
+                     attrs = "value='#{page.id}'"
+                     attrs << " selected='selected'" if selected == page
+                     indent = (level > 0) ? ('&nbsp;' * level * 2 + '&#187; ') : nil
+                     s << "<option #{attrs}>#{indent}#{h page.pretty_title}</option>\n" +
+                            wiki_page_options_for_select(pages, selected, page, level + 1)
+                   end
                  end
                  s
                end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages