jro_apps/redmine Commit - r9894:28cdc8adfc5d

Don't turn #nnn with leading zeros into link (#11494)....

Jean-Philippe Lang -

r9894:28cdc8adfc5d

parent child

Context file:

r9894:28cdc8adfc5d

app/helpers/application_helper.rb +1 -1

                        oid = identifier.to_i
                        case prefix
                        when nil
-                         if issue = Issue.visible.find_by_id(oid, :include => :status)
+                         if oid.to_s == identifier && issue = Issue.visible.find_by_id(oid, :include => :status)
                            anchor = comment_id ? "note-#{comment_id}" : nil
                            link = link_to("##{oid}", {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid, :anchor => anchor},
                                                      :class => issue.css_classes,

test/unit/helpers/application_helper_test.rb +2 0

                    # ticket notes
                    '#3-14'                       => note_link,
                    '#3#note-14'                  => note_link,
+                   # should not ignore leading zero
+                   '#03'                         => '#03',
                    # changesets
                    'r1'                          => changeset_link,
                    'r1.'                         => "#{changeset_link}.",

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages