jro_apps/redmine Commit - r15627:28b20270b4c2

use symbol instead of string for 'position' in db migrate (#24013)...

Toshi MARUYAMA -

r15627:28b20270b4c2

parent child

Context file:

r15627:28b20270b4c2

db/migrate/072_add_enumerations_position.rb +1 -1

             class AddEnumerationsPosition < ActiveRecord::Migration
               def self.up
                 add_column(:enumerations, :position, :integer, :default => 1) unless Enumeration.column_names.include?('position')
                 Enumeration.all.group_by(&:opt).each do |opt, enums|
                   enums.each_with_index do |enum, i|
                     # do not call model callbacks
-                    Enumeration.where({:id => enum.id}).update_all("position = #{i+1}")
+                    Enumeration.where({:id => enum.id}).update_all(:position => (i+1))
                   end
                 end
               end
               def self.down
                 remove_column :enumerations, :position
               end
             end

db/migrate/078_add_custom_fields_position.rb +1 -1

             class AddCustomFieldsPosition < ActiveRecord::Migration
               def self.up
                 add_column(:custom_fields, :position, :integer, :default => 1)
                 CustomField.all.group_by(&:type).each  do |t, fields|
                   fields.each_with_index do |field, i|
                     # do not call model callbacks
-                    CustomField.where({:id => field.id}).update_all("position = #{i+1}")
+                    CustomField.where({:id => field.id}).update_all(:position => (i+1))
                   end
                 end
               end
               def self.down
                 remove_column :custom_fields, :position
               end
             end

db/migrate/20141029181824_remove_issue_statuses_is_default.rb +1 -1

             class RemoveIssueStatusesIsDefault < ActiveRecord::Migration
               def up
                 remove_column :issue_statuses, :is_default
               end
               def down
                 add_column :issue_statuses, :is_default, :boolean, :null => false, :default => false
                 # Restores the first status as default
-                default_status_id = IssueStatus.order("position").pluck(:id).first
+                default_status_id = IssueStatus.order(:position).pluck(:id).first
                 IssueStatus.where(:id => default_status_id).update_all(:is_default => true)
               end
             end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages