##// END OF EJS Templates
Do not do assertions on mail class....
Jean-Philippe Lang -
r8871:28503d83cbf9
parent child
Show More
@@ -1,157 +1,157
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'admin_controller'
20 20
21 21 # Re-raise errors caught by the controller.
22 22 class AdminController; def rescue_action(e) raise e end; end
23 23
24 24 class AdminControllerTest < ActionController::TestCase
25 25 fixtures :projects, :users, :roles
26 26
27 27 def setup
28 28 @controller = AdminController.new
29 29 @request = ActionController::TestRequest.new
30 30 @response = ActionController::TestResponse.new
31 31 User.current = nil
32 32 @request.session[:user_id] = 1 # admin
33 33 end
34 34
35 35 def test_index
36 36 get :index
37 37 assert_no_tag :tag => 'div',
38 38 :attributes => { :class => /nodata/ }
39 39 end
40 40
41 41 def test_index_with_no_configuration_data
42 42 delete_configuration_data
43 43 get :index
44 44 assert_tag :tag => 'div',
45 45 :attributes => { :class => /nodata/ }
46 46 end
47 47
48 48 def test_projects
49 49 get :projects
50 50 assert_response :success
51 51 assert_template 'projects'
52 52 assert_not_nil assigns(:projects)
53 53 # active projects only
54 54 assert_nil assigns(:projects).detect {|u| !u.active?}
55 55 end
56 56
57 57 def test_projects_with_status_filter
58 58 get :projects, :status => 1
59 59 assert_response :success
60 60 assert_template 'projects'
61 61 assert_not_nil assigns(:projects)
62 62 # active projects only
63 63 assert_nil assigns(:projects).detect {|u| !u.active?}
64 64 end
65 65
66 66 def test_projects_with_name_filter
67 67 get :projects, :name => 'store', :status => ''
68 68 assert_response :success
69 69 assert_template 'projects'
70 70 projects = assigns(:projects)
71 71 assert_not_nil projects
72 72 assert_equal 1, projects.size
73 73 assert_equal 'OnlineStore', projects.first.name
74 74 end
75 75
76 76 def test_load_default_configuration_data
77 77 delete_configuration_data
78 78 post :default_configuration, :lang => 'fr'
79 79 assert_response :redirect
80 80 assert_nil flash[:error]
81 81 assert IssueStatus.find_by_name('Nouveau')
82 82 end
83 83
84 84 def test_test_email
85 85 get :test_email
86 86 assert_redirected_to '/settings/edit?tab=notifications'
87 87 mail = ActionMailer::Base.deliveries.last
88 assert_kind_of TMail::Mail, mail
88 assert_not_nil mail
89 89 user = User.find(1)
90 90 assert_equal [user.mail], mail.bcc
91 91 end
92 92
93 93 def test_test_email_failure_should_display_the_error
94 94 Mailer.stubs(:deliver_test).raises(Exception, 'Some error message')
95 95 get :test_email
96 96 assert_redirected_to '/settings/edit?tab=notifications'
97 97 assert_match /Some error message/, flash[:error]
98 98 end
99 99
100 100 def test_no_plugins
101 101 Redmine::Plugin.clear
102 102
103 103 get :plugins
104 104 assert_response :success
105 105 assert_template 'plugins'
106 106 end
107 107
108 108 def test_plugins
109 109 # Register a few plugins
110 110 Redmine::Plugin.register :foo do
111 111 name 'Foo plugin'
112 112 author 'John Smith'
113 113 description 'This is a test plugin'
114 114 version '0.0.1'
115 115 settings :default => {'sample_setting' => 'value', 'foo'=>'bar'}, :partial => 'foo/settings'
116 116 end
117 117 Redmine::Plugin.register :bar do
118 118 end
119 119
120 120 get :plugins
121 121 assert_response :success
122 122 assert_template 'plugins'
123 123
124 124 assert_tag :td, :child => { :tag => 'span', :content => 'Foo plugin' }
125 125 assert_tag :td, :child => { :tag => 'span', :content => 'Bar' }
126 126 end
127 127
128 128 def test_info
129 129 get :info
130 130 assert_response :success
131 131 assert_template 'info'
132 132 end
133 133
134 134 def test_admin_menu_plugin_extension
135 135 Redmine::MenuManager.map :admin_menu do |menu|
136 136 menu.push :test_admin_menu_plugin_extension, '/foo/bar', :caption => 'Test'
137 137 end
138 138
139 139 get :index
140 140 assert_response :success
141 141 assert_tag :a, :attributes => { :href => '/foo/bar' },
142 142 :content => 'Test'
143 143
144 144 Redmine::MenuManager.map :admin_menu do |menu|
145 145 menu.delete :test_admin_menu_plugin_extension
146 146 end
147 147 end
148 148
149 149 private
150 150
151 151 def delete_configuration_data
152 152 Role.delete_all('builtin = 0')
153 153 Tracker.delete_all
154 154 IssueStatus.delete_all
155 155 Enumeration.delete_all
156 156 end
157 157 end
@@ -1,96 +1,96
1 1 require File.expand_path('../../test_helper', __FILE__)
2 2
3 3 class FilesControllerTest < ActionController::TestCase
4 4 fixtures :projects, :trackers, :issue_statuses, :issues,
5 5 :enumerations, :users, :issue_categories,
6 6 :projects_trackers,
7 7 :roles,
8 8 :member_roles,
9 9 :members,
10 10 :enabled_modules,
11 11 :workflows,
12 12 :journals, :journal_details,
13 13 :attachments,
14 14 :versions
15 15
16 16 def setup
17 17 @controller = FilesController.new
18 18 @request = ActionController::TestRequest.new
19 19 @response = ActionController::TestResponse.new
20 20 @request.session[:user_id] = nil
21 21 Setting.default_language = 'en'
22 22 end
23 23
24 24 def test_index
25 25 get :index, :project_id => 1
26 26 assert_response :success
27 27 assert_template 'index'
28 28 assert_not_nil assigns(:containers)
29 29
30 30 # file attached to the project
31 31 assert_tag :a, :content => 'project_file.zip',
32 32 :attributes => { :href => '/attachments/download/8/project_file.zip' }
33 33
34 34 # file attached to a project's version
35 35 assert_tag :a, :content => 'version_file.zip',
36 36 :attributes => { :href => '/attachments/download/9/version_file.zip' }
37 37 end
38 38
39 39 def test_new
40 40 @request.session[:user_id] = 2
41 41 get :new, :project_id => 1
42 42 assert_response :success
43 43 assert_template 'new'
44 44
45 45 assert_tag 'select', :attributes => {:name => 'version_id'}
46 46 end
47 47
48 48 def test_new_without_versions
49 49 Version.delete_all
50 50 @request.session[:user_id] = 2
51 51 get :new, :project_id => 1
52 52 assert_response :success
53 53 assert_template 'new'
54 54
55 55 assert_no_tag 'select', :attributes => {:name => 'version_id'}
56 56 end
57 57
58 58 def test_create_file
59 59 set_tmp_attachments_directory
60 60 @request.session[:user_id] = 2
61 61 Setting.notified_events = ['file_added']
62 62 ActionMailer::Base.deliveries.clear
63 63
64 64 assert_difference 'Attachment.count' do
65 65 post :create, :project_id => 1, :version_id => '',
66 66 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
67 67 assert_response :redirect
68 68 end
69 69 assert_redirected_to '/projects/ecookbook/files'
70 70 a = Attachment.find(:first, :order => 'created_on DESC')
71 71 assert_equal 'testfile.txt', a.filename
72 72 assert_equal Project.find(1), a.container
73 73
74 74 mail = ActionMailer::Base.deliveries.last
75 assert_kind_of TMail::Mail, mail
75 assert_not_nil mail
76 76 assert_equal "[eCookbook] New file", mail.subject
77 77 assert mail.body.include?('testfile.txt')
78 78 end
79 79
80 80 def test_create_version_file
81 81 set_tmp_attachments_directory
82 82 @request.session[:user_id] = 2
83 83 Setting.notified_events = ['file_added']
84 84
85 85 assert_difference 'Attachment.count' do
86 86 post :create, :project_id => 1, :version_id => '2',
87 87 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
88 88 assert_response :redirect
89 89 end
90 90 assert_redirected_to '/projects/ecookbook/files'
91 91 a = Attachment.find(:first, :order => 'created_on DESC')
92 92 assert_equal 'testfile.txt', a.filename
93 93 assert_equal Version.find(2), a.container
94 94 end
95 95
96 96 end
@@ -1,3087 +1,3087
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'issues_controller'
20 20
21 21 class IssuesControllerTest < ActionController::TestCase
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issues,
28 28 :issue_statuses,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries,
45 45 :repositories,
46 46 :changesets
47 47
48 48 include Redmine::I18n
49 49
50 50 def setup
51 51 @controller = IssuesController.new
52 52 @request = ActionController::TestRequest.new
53 53 @response = ActionController::TestResponse.new
54 54 User.current = nil
55 55 end
56 56
57 57 def test_index
58 58 with_settings :default_language => "en" do
59 59 get :index
60 60 assert_response :success
61 61 assert_template 'index'
62 62 assert_not_nil assigns(:issues)
63 63 assert_nil assigns(:project)
64 64 assert_tag :tag => 'a', :content => /Can't print recipes/
65 65 assert_tag :tag => 'a', :content => /Subproject issue/
66 66 # private projects hidden
67 67 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
68 68 assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 69 # project column
70 70 assert_tag :tag => 'th', :content => /Project/
71 71 end
72 72 end
73 73
74 74 def test_index_should_not_list_issues_when_module_disabled
75 75 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
76 76 get :index
77 77 assert_response :success
78 78 assert_template 'index'
79 79 assert_not_nil assigns(:issues)
80 80 assert_nil assigns(:project)
81 81 assert_no_tag :tag => 'a', :content => /Can't print recipes/
82 82 assert_tag :tag => 'a', :content => /Subproject issue/
83 83 end
84 84
85 85 def test_index_should_list_visible_issues_only
86 86 get :index, :per_page => 100
87 87 assert_response :success
88 88 assert_not_nil assigns(:issues)
89 89 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
90 90 end
91 91
92 92 def test_index_with_project
93 93 Setting.display_subprojects_issues = 0
94 94 get :index, :project_id => 1
95 95 assert_response :success
96 96 assert_template 'index'
97 97 assert_not_nil assigns(:issues)
98 98 assert_tag :tag => 'a', :content => /Can't print recipes/
99 99 assert_no_tag :tag => 'a', :content => /Subproject issue/
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108 assert_tag :tag => 'a', :content => /Can't print recipes/
109 109 assert_tag :tag => 'a', :content => /Subproject issue/
110 110 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
111 111 end
112 112
113 113 def test_index_with_project_and_subprojects_should_show_private_subprojects
114 114 @request.session[:user_id] = 2
115 115 Setting.display_subprojects_issues = 1
116 116 get :index, :project_id => 1
117 117 assert_response :success
118 118 assert_template 'index'
119 119 assert_not_nil assigns(:issues)
120 120 assert_tag :tag => 'a', :content => /Can't print recipes/
121 121 assert_tag :tag => 'a', :content => /Subproject issue/
122 122 assert_tag :tag => 'a', :content => /Issue of a private subproject/
123 123 end
124 124
125 125 def test_index_with_project_and_default_filter
126 126 get :index, :project_id => 1, :set_filter => 1
127 127 assert_response :success
128 128 assert_template 'index'
129 129 assert_not_nil assigns(:issues)
130 130
131 131 query = assigns(:query)
132 132 assert_not_nil query
133 133 # default filter
134 134 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
135 135 end
136 136
137 137 def test_index_with_project_and_filter
138 138 get :index, :project_id => 1, :set_filter => 1,
139 139 :f => ['tracker_id'],
140 140 :op => {'tracker_id' => '='},
141 141 :v => {'tracker_id' => ['1']}
142 142 assert_response :success
143 143 assert_template 'index'
144 144 assert_not_nil assigns(:issues)
145 145
146 146 query = assigns(:query)
147 147 assert_not_nil query
148 148 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
149 149 end
150 150
151 151 def test_index_with_short_filters
152 152
153 153 to_test = {
154 154 'status_id' => {
155 155 'o' => { :op => 'o', :values => [''] },
156 156 'c' => { :op => 'c', :values => [''] },
157 157 '7' => { :op => '=', :values => ['7'] },
158 158 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
159 159 '=7' => { :op => '=', :values => ['7'] },
160 160 '!3' => { :op => '!', :values => ['3'] },
161 161 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
162 162 'subject' => {
163 163 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
164 164 'o' => { :op => '=', :values => ['o'] },
165 165 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
166 166 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
167 167 'tracker_id' => {
168 168 '3' => { :op => '=', :values => ['3'] },
169 169 '=3' => { :op => '=', :values => ['3'] }},
170 170 'start_date' => {
171 171 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
172 172 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
174 174 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
175 175 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
176 176 '<t+2' => { :op => '<t+', :values => ['2'] },
177 177 '>t+2' => { :op => '>t+', :values => ['2'] },
178 178 't+2' => { :op => 't+', :values => ['2'] },
179 179 't' => { :op => 't', :values => [''] },
180 180 'w' => { :op => 'w', :values => [''] },
181 181 '>t-2' => { :op => '>t-', :values => ['2'] },
182 182 '<t-2' => { :op => '<t-', :values => ['2'] },
183 183 't-2' => { :op => 't-', :values => ['2'] }},
184 184 'created_on' => {
185 185 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
186 186 '<t+2' => { :op => '=', :values => ['<t+2'] },
187 187 '>t+2' => { :op => '=', :values => ['>t+2'] },
188 188 't+2' => { :op => 't', :values => ['+2'] }},
189 189 'cf_1' => {
190 190 'c' => { :op => '=', :values => ['c'] },
191 191 '!c' => { :op => '!', :values => ['c'] },
192 192 '!*' => { :op => '!*', :values => [''] },
193 193 '*' => { :op => '*', :values => [''] }},
194 194 'estimated_hours' => {
195 195 '=13.4' => { :op => '=', :values => ['13.4'] },
196 196 '>=45' => { :op => '>=', :values => ['45'] },
197 197 '<=125' => { :op => '<=', :values => ['125'] },
198 198 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
199 199 '!*' => { :op => '!*', :values => [''] },
200 200 '*' => { :op => '*', :values => [''] }}
201 201 }
202 202
203 203 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
204 204
205 205 to_test.each do |field, expression_and_expected|
206 206 expression_and_expected.each do |filter_expression, expected|
207 207
208 208 get :index, :set_filter => 1, field => filter_expression
209 209
210 210 assert_response :success
211 211 assert_template 'index'
212 212 assert_not_nil assigns(:issues)
213 213
214 214 query = assigns(:query)
215 215 assert_not_nil query
216 216 assert query.has_filter?(field)
217 217 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
218 218 end
219 219 end
220 220
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_query
236 236 get :index, :project_id => 1, :query_id => 5
237 237 assert_response :success
238 238 assert_template 'index'
239 239 assert_not_nil assigns(:issues)
240 240 assert_nil assigns(:issue_count_by_group)
241 241 end
242 242
243 243 def test_index_with_query_grouped_by_tracker
244 244 get :index, :project_id => 1, :query_id => 6
245 245 assert_response :success
246 246 assert_template 'index'
247 247 assert_not_nil assigns(:issues)
248 248 assert_not_nil assigns(:issue_count_by_group)
249 249 end
250 250
251 251 def test_index_with_query_grouped_by_list_custom_field
252 252 get :index, :project_id => 1, :query_id => 9
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_not_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_id_and_project_id_should_set_session_query
260 260 get :index, :project_id => 1, :query_id => 4
261 261 assert_response :success
262 262 assert_kind_of Hash, session[:query]
263 263 assert_equal 4, session[:query][:id]
264 264 assert_equal 1, session[:query][:project_id]
265 265 end
266 266
267 267 def test_index_with_cross_project_query_in_session_should_show_project_issues
268 268 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
269 269 @request.session[:query] = {:id => q.id, :project_id => 1}
270 270
271 271 with_settings :display_subprojects_issues => '0' do
272 272 get :index, :project_id => 1
273 273 end
274 274 assert_response :success
275 275 assert_not_nil assigns(:query)
276 276 assert_equal q.id, assigns(:query).id
277 277 assert_equal 1, assigns(:query).project_id
278 278 assert_equal [1], assigns(:issues).map(&:project_id).uniq
279 279 end
280 280
281 281 def test_private_query_should_not_be_available_to_other_users
282 282 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
283 283 @request.session[:user_id] = 3
284 284
285 285 get :index, :query_id => q.id
286 286 assert_response 403
287 287 end
288 288
289 289 def test_private_query_should_be_available_to_its_user
290 290 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
291 291 @request.session[:user_id] = 2
292 292
293 293 get :index, :query_id => q.id
294 294 assert_response :success
295 295 end
296 296
297 297 def test_public_query_should_be_available_to_other_users
298 298 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
299 299 @request.session[:user_id] = 3
300 300
301 301 get :index, :query_id => q.id
302 302 assert_response :success
303 303 end
304 304
305 305 def test_index_csv
306 306 get :index, :format => 'csv'
307 307 assert_response :success
308 308 assert_not_nil assigns(:issues)
309 309 assert_equal 'text/csv', @response.content_type
310 310 assert @response.body.starts_with?("#,")
311 311 lines = @response.body.chomp.split("\n")
312 312 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
313 313 end
314 314
315 315 def test_index_csv_with_project
316 316 get :index, :project_id => 1, :format => 'csv'
317 317 assert_response :success
318 318 assert_not_nil assigns(:issues)
319 319 assert_equal 'text/csv', @response.content_type
320 320 end
321 321
322 322 def test_index_csv_with_description
323 323 get :index, :format => 'csv', :description => '1'
324 324 assert_response :success
325 325 assert_not_nil assigns(:issues)
326 326 assert_equal 'text/csv', @response.content_type
327 327 assert @response.body.starts_with?("#,")
328 328 lines = @response.body.chomp.split("\n")
329 329 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
330 330 end
331 331
332 332 def test_index_csv_with_spent_time_column
333 333 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column')
334 334 TimeEntry.generate!(:project_id => issue.project_id, :issue_id => issue.id, :hours => 7.33)
335 335
336 336 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
337 337 assert_response :success
338 338 assert_equal 'text/csv', @response.content_type
339 339 lines = @response.body.chomp.split("\n")
340 340 assert_include "#{issue.id},#{issue.subject},7.33", lines
341 341 end
342 342
343 343 def test_index_csv_with_all_columns
344 344 get :index, :format => 'csv', :columns => 'all'
345 345 assert_response :success
346 346 assert_not_nil assigns(:issues)
347 347 assert_equal 'text/csv', @response.content_type
348 348 assert @response.body.starts_with?("#,")
349 349 lines = @response.body.chomp.split("\n")
350 350 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
351 351 end
352 352
353 353 def test_index_csv_with_multi_column_field
354 354 CustomField.find(1).update_attribute :multiple, true
355 355 issue = Issue.find(1)
356 356 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
357 357 issue.save!
358 358
359 359 get :index, :format => 'csv', :columns => 'all'
360 360 assert_response :success
361 361 lines = @response.body.chomp.split("\n")
362 362 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
363 363 end
364 364
365 365 def test_index_csv_big_5
366 366 with_settings :default_language => "zh-TW" do
367 367 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
368 368 str_big5 = "\xa4@\xa4\xeb"
369 369 if str_utf8.respond_to?(:force_encoding)
370 370 str_utf8.force_encoding('UTF-8')
371 371 str_big5.force_encoding('Big5')
372 372 end
373 373 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
374 374 :status_id => 1, :priority => IssuePriority.all.first,
375 375 :subject => str_utf8)
376 376 assert issue.save
377 377
378 378 get :index, :project_id => 1,
379 379 :f => ['subject'],
380 380 :op => '=', :values => [str_utf8],
381 381 :format => 'csv'
382 382 assert_equal 'text/csv', @response.content_type
383 383 lines = @response.body.chomp.split("\n")
384 384 s1 = "\xaa\xac\xbaA"
385 385 if str_utf8.respond_to?(:force_encoding)
386 386 s1.force_encoding('Big5')
387 387 end
388 388 assert lines[0].include?(s1)
389 389 assert lines[1].include?(str_big5)
390 390 end
391 391 end
392 392
393 393 def test_index_csv_cannot_convert_should_be_replaced_big_5
394 394 with_settings :default_language => "zh-TW" do
395 395 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
396 396 if str_utf8.respond_to?(:force_encoding)
397 397 str_utf8.force_encoding('UTF-8')
398 398 end
399 399 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
400 400 :status_id => 1, :priority => IssuePriority.all.first,
401 401 :subject => str_utf8)
402 402 assert issue.save
403 403
404 404 get :index, :project_id => 1,
405 405 :f => ['subject'],
406 406 :op => '=', :values => [str_utf8],
407 407 :c => ['status', 'subject'],
408 408 :format => 'csv',
409 409 :set_filter => 1
410 410 assert_equal 'text/csv', @response.content_type
411 411 lines = @response.body.chomp.split("\n")
412 412 s1 = "\xaa\xac\xbaA" # status
413 413 if str_utf8.respond_to?(:force_encoding)
414 414 s1.force_encoding('Big5')
415 415 end
416 416 assert lines[0].include?(s1)
417 417 s2 = lines[1].split(",")[2]
418 418 if s1.respond_to?(:force_encoding)
419 419 s3 = "\xa5H?" # subject
420 420 s3.force_encoding('Big5')
421 421 assert_equal s3, s2
422 422 elsif RUBY_PLATFORM == 'java'
423 423 assert_equal "??", s2
424 424 else
425 425 assert_equal "\xa5H???", s2
426 426 end
427 427 end
428 428 end
429 429
430 430 def test_index_csv_tw
431 431 with_settings :default_language => "zh-TW" do
432 432 str1 = "test_index_csv_tw"
433 433 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
434 434 :status_id => 1, :priority => IssuePriority.all.first,
435 435 :subject => str1, :estimated_hours => '1234.5')
436 436 assert issue.save
437 437 assert_equal 1234.5, issue.estimated_hours
438 438
439 439 get :index, :project_id => 1,
440 440 :f => ['subject'],
441 441 :op => '=', :values => [str1],
442 442 :c => ['estimated_hours', 'subject'],
443 443 :format => 'csv',
444 444 :set_filter => 1
445 445 assert_equal 'text/csv', @response.content_type
446 446 lines = @response.body.chomp.split("\n")
447 447 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
448 448
449 449 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
450 450 if str_tw.respond_to?(:force_encoding)
451 451 str_tw.force_encoding('UTF-8')
452 452 end
453 453 assert_equal str_tw, l(:general_lang_name)
454 454 assert_equal ',', l(:general_csv_separator)
455 455 assert_equal '.', l(:general_csv_decimal_separator)
456 456 end
457 457 end
458 458
459 459 def test_index_csv_fr
460 460 with_settings :default_language => "fr" do
461 461 str1 = "test_index_csv_fr"
462 462 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
463 463 :status_id => 1, :priority => IssuePriority.all.first,
464 464 :subject => str1, :estimated_hours => '1234.5')
465 465 assert issue.save
466 466 assert_equal 1234.5, issue.estimated_hours
467 467
468 468 get :index, :project_id => 1,
469 469 :f => ['subject'],
470 470 :op => '=', :values => [str1],
471 471 :c => ['estimated_hours', 'subject'],
472 472 :format => 'csv',
473 473 :set_filter => 1
474 474 assert_equal 'text/csv', @response.content_type
475 475 lines = @response.body.chomp.split("\n")
476 476 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
477 477
478 478 str_fr = "Fran\xc3\xa7ais"
479 479 if str_fr.respond_to?(:force_encoding)
480 480 str_fr.force_encoding('UTF-8')
481 481 end
482 482 assert_equal str_fr, l(:general_lang_name)
483 483 assert_equal ';', l(:general_csv_separator)
484 484 assert_equal ',', l(:general_csv_decimal_separator)
485 485 end
486 486 end
487 487
488 488 def test_index_pdf
489 489 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
490 490 with_settings :default_language => lang do
491 491
492 492 get :index
493 493 assert_response :success
494 494 assert_template 'index'
495 495
496 496 if lang == "ja"
497 497 if RUBY_PLATFORM != 'java'
498 498 assert_equal "CP932", l(:general_pdf_encoding)
499 499 end
500 500 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
501 501 next
502 502 end
503 503 end
504 504
505 505 get :index, :format => 'pdf'
506 506 assert_response :success
507 507 assert_not_nil assigns(:issues)
508 508 assert_equal 'application/pdf', @response.content_type
509 509
510 510 get :index, :project_id => 1, :format => 'pdf'
511 511 assert_response :success
512 512 assert_not_nil assigns(:issues)
513 513 assert_equal 'application/pdf', @response.content_type
514 514
515 515 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
516 516 assert_response :success
517 517 assert_not_nil assigns(:issues)
518 518 assert_equal 'application/pdf', @response.content_type
519 519 end
520 520 end
521 521 end
522 522
523 523 def test_index_pdf_with_query_grouped_by_list_custom_field
524 524 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
525 525 assert_response :success
526 526 assert_not_nil assigns(:issues)
527 527 assert_not_nil assigns(:issue_count_by_group)
528 528 assert_equal 'application/pdf', @response.content_type
529 529 end
530 530
531 531 def test_index_sort
532 532 get :index, :sort => 'tracker,id:desc'
533 533 assert_response :success
534 534
535 535 sort_params = @request.session['issues_index_sort']
536 536 assert sort_params.is_a?(String)
537 537 assert_equal 'tracker,id:desc', sort_params
538 538
539 539 issues = assigns(:issues)
540 540 assert_not_nil issues
541 541 assert !issues.empty?
542 542 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
543 543 end
544 544
545 545 def test_index_sort_by_field_not_included_in_columns
546 546 Setting.issue_list_default_columns = %w(subject author)
547 547 get :index, :sort => 'tracker'
548 548 end
549 549
550 550 def test_index_sort_by_assigned_to
551 551 get :index, :sort => 'assigned_to'
552 552 assert_response :success
553 553 assignees = assigns(:issues).collect(&:assigned_to).compact
554 554 assert_equal assignees.sort, assignees
555 555 end
556 556
557 557 def test_index_sort_by_assigned_to_desc
558 558 get :index, :sort => 'assigned_to:desc'
559 559 assert_response :success
560 560 assignees = assigns(:issues).collect(&:assigned_to).compact
561 561 assert_equal assignees.sort.reverse, assignees
562 562 end
563 563
564 564 def test_index_group_by_assigned_to
565 565 get :index, :group_by => 'assigned_to', :sort => 'priority'
566 566 assert_response :success
567 567 end
568 568
569 569 def test_index_sort_by_author
570 570 get :index, :sort => 'author'
571 571 assert_response :success
572 572 authors = assigns(:issues).collect(&:author)
573 573 assert_equal authors.sort, authors
574 574 end
575 575
576 576 def test_index_sort_by_author_desc
577 577 get :index, :sort => 'author:desc'
578 578 assert_response :success
579 579 authors = assigns(:issues).collect(&:author)
580 580 assert_equal authors.sort.reverse, authors
581 581 end
582 582
583 583 def test_index_group_by_author
584 584 get :index, :group_by => 'author', :sort => 'priority'
585 585 assert_response :success
586 586 end
587 587
588 588 def test_index_sort_by_spent_hours
589 589 get :index, :sort => 'spent_hours:desc'
590 590 assert_response :success
591 591 hours = assigns(:issues).collect(&:spent_hours)
592 592 assert_equal hours.sort.reverse, hours
593 593 end
594 594
595 595 def test_index_with_columns
596 596 columns = ['tracker', 'subject', 'assigned_to']
597 597 get :index, :set_filter => 1, :c => columns
598 598 assert_response :success
599 599
600 600 # query should use specified columns
601 601 query = assigns(:query)
602 602 assert_kind_of Query, query
603 603 assert_equal columns, query.column_names.map(&:to_s)
604 604
605 605 # columns should be stored in session
606 606 assert_kind_of Hash, session[:query]
607 607 assert_kind_of Array, session[:query][:column_names]
608 608 assert_equal columns, session[:query][:column_names].map(&:to_s)
609 609
610 610 # ensure only these columns are kept in the selected columns list
611 611 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
612 612 :children => { :count => 3 }
613 613 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
614 614 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
615 615 end
616 616
617 617 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
618 618 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
619 619 get :index, :set_filter => 1
620 620
621 621 # query should use specified columns
622 622 query = assigns(:query)
623 623 assert_kind_of Query, query
624 624 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
625 625 end
626 626
627 627 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
628 628 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
629 629 columns = ['tracker', 'subject', 'assigned_to']
630 630 get :index, :set_filter => 1, :c => columns
631 631
632 632 # query should use specified columns
633 633 query = assigns(:query)
634 634 assert_kind_of Query, query
635 635 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
636 636 end
637 637
638 638 def test_index_with_custom_field_column
639 639 columns = %w(tracker subject cf_2)
640 640 get :index, :set_filter => 1, :c => columns
641 641 assert_response :success
642 642
643 643 # query should use specified columns
644 644 query = assigns(:query)
645 645 assert_kind_of Query, query
646 646 assert_equal columns, query.column_names.map(&:to_s)
647 647
648 648 assert_tag :td,
649 649 :attributes => {:class => 'cf_2 string'},
650 650 :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
651 651 end
652 652
653 653 def test_index_with_multi_custom_field_column
654 654 field = CustomField.find(1)
655 655 field.update_attribute :multiple, true
656 656 issue = Issue.find(1)
657 657 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
658 658 issue.save!
659 659
660 660 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
661 661 assert_response :success
662 662
663 663 assert_tag :td,
664 664 :attributes => {:class => /cf_1/},
665 665 :content => 'MySQL, Oracle'
666 666 end
667 667
668 668 def test_index_with_multi_user_custom_field_column
669 669 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
670 670 :tracker_ids => [1], :is_for_all => true)
671 671 issue = Issue.find(1)
672 672 issue.custom_field_values = {field.id => ['2', '3']}
673 673 issue.save!
674 674
675 675 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
676 676 assert_response :success
677 677
678 678 assert_tag :td,
679 679 :attributes => {:class => /cf_#{field.id}/},
680 680 :child => {:tag => 'a', :content => 'John Smith'}
681 681 end
682 682
683 683 def test_index_with_date_column
684 684 Issue.find(1).update_attribute :start_date, '1987-08-24'
685 685
686 686 with_settings :date_format => '%d/%m/%Y' do
687 687 get :index, :set_filter => 1, :c => %w(start_date)
688 688 assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
689 689 end
690 690 end
691 691
692 692 def test_index_with_done_ratio
693 693 Issue.find(1).update_attribute :done_ratio, 40
694 694
695 695 get :index, :set_filter => 1, :c => %w(done_ratio)
696 696 assert_tag 'td', :attributes => {:class => /done_ratio/},
697 697 :child => {:tag => 'table', :attributes => {:class => 'progress'},
698 698 :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
699 699 }
700 700 end
701 701
702 702 def test_index_with_spent_hours_column
703 703 get :index, :set_filter => 1, :c => %w(subject spent_hours)
704 704
705 705 assert_tag 'tr', :attributes => {:id => 'issue-3'},
706 706 :child => {
707 707 :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
708 708 }
709 709 end
710 710
711 711 def test_index_should_not_show_spent_hours_column_without_permission
712 712 Role.anonymous.remove_permission! :view_time_entries
713 713 get :index, :set_filter => 1, :c => %w(subject spent_hours)
714 714
715 715 assert_no_tag 'td', :attributes => {:class => /spent_hours/}
716 716 end
717 717
718 718 def test_index_with_fixed_version
719 719 get :index, :set_filter => 1, :c => %w(fixed_version)
720 720 assert_tag 'td', :attributes => {:class => /fixed_version/},
721 721 :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
722 722 end
723 723
724 724 def test_index_send_html_if_query_is_invalid
725 725 get :index, :f => ['start_date'], :op => {:start_date => '='}
726 726 assert_equal 'text/html', @response.content_type
727 727 assert_template 'index'
728 728 end
729 729
730 730 def test_index_send_nothing_if_query_is_invalid
731 731 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
732 732 assert_equal 'text/csv', @response.content_type
733 733 assert @response.body.blank?
734 734 end
735 735
736 736 def test_show_by_anonymous
737 737 get :show, :id => 1
738 738 assert_response :success
739 739 assert_template 'show'
740 740 assert_not_nil assigns(:issue)
741 741 assert_equal Issue.find(1), assigns(:issue)
742 742
743 743 # anonymous role is allowed to add a note
744 744 assert_tag :tag => 'form',
745 745 :descendant => { :tag => 'fieldset',
746 746 :child => { :tag => 'legend',
747 747 :content => /Notes/ } }
748 748 assert_tag :tag => 'title',
749 749 :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
750 750 end
751 751
752 752 def test_show_by_manager
753 753 @request.session[:user_id] = 2
754 754 get :show, :id => 1
755 755 assert_response :success
756 756
757 757 assert_tag :tag => 'a',
758 758 :content => /Quote/
759 759
760 760 assert_tag :tag => 'form',
761 761 :descendant => { :tag => 'fieldset',
762 762 :child => { :tag => 'legend',
763 763 :content => /Change properties/ } },
764 764 :descendant => { :tag => 'fieldset',
765 765 :child => { :tag => 'legend',
766 766 :content => /Log time/ } },
767 767 :descendant => { :tag => 'fieldset',
768 768 :child => { :tag => 'legend',
769 769 :content => /Notes/ } }
770 770 end
771 771
772 772 def test_show_should_display_update_form
773 773 @request.session[:user_id] = 2
774 774 get :show, :id => 1
775 775 assert_response :success
776 776
777 777 assert_tag 'form', :attributes => {:id => 'issue-form'}
778 778 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
779 779 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
780 780 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
781 781 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
782 782 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
783 783 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
784 784 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
785 785 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
786 786 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
787 787 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
788 788 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
789 789 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
790 790 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
791 791 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
792 792 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
793 793 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
794 794 assert_tag 'textarea', :attributes => {:name => 'notes'}
795 795 end
796 796
797 797 def test_show_should_display_update_form_with_minimal_permissions
798 798 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
799 799 Workflow.delete_all :role_id => 1
800 800
801 801 @request.session[:user_id] = 2
802 802 get :show, :id => 1
803 803 assert_response :success
804 804
805 805 assert_tag 'form', :attributes => {:id => 'issue-form'}
806 806 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
807 807 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
808 808 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
809 809 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
810 810 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
811 811 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
812 812 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
813 813 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
814 814 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
815 815 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
816 816 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
817 817 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
818 818 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
819 819 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
820 820 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
821 821 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
822 822 assert_tag 'textarea', :attributes => {:name => 'notes'}
823 823 end
824 824
825 825 def test_show_should_display_update_form_with_workflow_permissions
826 826 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
827 827
828 828 @request.session[:user_id] = 2
829 829 get :show, :id => 1
830 830 assert_response :success
831 831
832 832 assert_tag 'form', :attributes => {:id => 'issue-form'}
833 833 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
834 834 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
835 835 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
836 836 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
837 837 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
838 838 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
839 839 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
840 840 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
841 841 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
842 842 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
843 843 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
844 844 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
845 845 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
846 846 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
847 847 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
848 848 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
849 849 assert_tag 'textarea', :attributes => {:name => 'notes'}
850 850 end
851 851
852 852 def test_show_should_not_display_update_form_without_permissions
853 853 Role.find(1).update_attribute :permissions, [:view_issues]
854 854
855 855 @request.session[:user_id] = 2
856 856 get :show, :id => 1
857 857 assert_response :success
858 858
859 859 assert_no_tag 'form', :attributes => {:id => 'issue-form'}
860 860 end
861 861
862 862 def test_update_form_should_not_display_inactive_enumerations
863 863 @request.session[:user_id] = 2
864 864 get :show, :id => 1
865 865 assert_response :success
866 866
867 867 assert ! IssuePriority.find(15).active?
868 868 assert_no_tag :option, :attributes => {:value => '15'},
869 869 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
870 870 end
871 871
872 872 def test_update_form_should_allow_attachment_upload
873 873 @request.session[:user_id] = 2
874 874 get :show, :id => 1
875 875
876 876 assert_tag :tag => 'form',
877 877 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
878 878 :descendant => {
879 879 :tag => 'input',
880 880 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
881 881 }
882 882 end
883 883
884 884 def test_show_should_deny_anonymous_access_without_permission
885 885 Role.anonymous.remove_permission!(:view_issues)
886 886 get :show, :id => 1
887 887 assert_response :redirect
888 888 end
889 889
890 890 def test_show_should_deny_anonymous_access_to_private_issue
891 891 Issue.update_all(["is_private = ?", true], "id = 1")
892 892 get :show, :id => 1
893 893 assert_response :redirect
894 894 end
895 895
896 896 def test_show_should_deny_non_member_access_without_permission
897 897 Role.non_member.remove_permission!(:view_issues)
898 898 @request.session[:user_id] = 9
899 899 get :show, :id => 1
900 900 assert_response 403
901 901 end
902 902
903 903 def test_show_should_deny_non_member_access_to_private_issue
904 904 Issue.update_all(["is_private = ?", true], "id = 1")
905 905 @request.session[:user_id] = 9
906 906 get :show, :id => 1
907 907 assert_response 403
908 908 end
909 909
910 910 def test_show_should_deny_member_access_without_permission
911 911 Role.find(1).remove_permission!(:view_issues)
912 912 @request.session[:user_id] = 2
913 913 get :show, :id => 1
914 914 assert_response 403
915 915 end
916 916
917 917 def test_show_should_deny_member_access_to_private_issue_without_permission
918 918 Issue.update_all(["is_private = ?", true], "id = 1")
919 919 @request.session[:user_id] = 3
920 920 get :show, :id => 1
921 921 assert_response 403
922 922 end
923 923
924 924 def test_show_should_allow_author_access_to_private_issue
925 925 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
926 926 @request.session[:user_id] = 3
927 927 get :show, :id => 1
928 928 assert_response :success
929 929 end
930 930
931 931 def test_show_should_allow_assignee_access_to_private_issue
932 932 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
933 933 @request.session[:user_id] = 3
934 934 get :show, :id => 1
935 935 assert_response :success
936 936 end
937 937
938 938 def test_show_should_allow_member_access_to_private_issue_with_permission
939 939 Issue.update_all(["is_private = ?", true], "id = 1")
940 940 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
941 941 @request.session[:user_id] = 3
942 942 get :show, :id => 1
943 943 assert_response :success
944 944 end
945 945
946 946 def test_show_should_not_disclose_relations_to_invisible_issues
947 947 Setting.cross_project_issue_relations = '1'
948 948 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
949 949 # Relation to a private project issue
950 950 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
951 951
952 952 get :show, :id => 1
953 953 assert_response :success
954 954
955 955 assert_tag :div, :attributes => { :id => 'relations' },
956 956 :descendant => { :tag => 'a', :content => /#2$/ }
957 957 assert_no_tag :div, :attributes => { :id => 'relations' },
958 958 :descendant => { :tag => 'a', :content => /#4$/ }
959 959 end
960 960
961 961 def test_show_should_list_subtasks
962 962 Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
963 963
964 964 get :show, :id => 1
965 965 assert_response :success
966 966 assert_tag 'div', :attributes => {:id => 'issue_tree'},
967 967 :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
968 968 end
969 969
970 970 def test_show_should_list_parents
971 971 issue = Issue.generate!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
972 972
973 973 get :show, :id => issue.id
974 974 assert_response :success
975 975 assert_tag 'div', :attributes => {:class => 'subject'},
976 976 :descendant => {:tag => 'h3', :content => 'Child Issue'}
977 977 assert_tag 'div', :attributes => {:class => 'subject'},
978 978 :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
979 979 end
980 980
981 981 def test_show_should_not_display_prev_next_links_without_query_in_session
982 982 get :show, :id => 1
983 983 assert_response :success
984 984 assert_nil assigns(:prev_issue_id)
985 985 assert_nil assigns(:next_issue_id)
986 986
987 987 assert_no_tag 'div', :attributes => {:class => /next-prev-links/}
988 988 end
989 989
990 990 def test_show_should_display_prev_next_links_with_query_in_session
991 991 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
992 992 @request.session['issues_index_sort'] = 'id'
993 993
994 994 with_settings :display_subprojects_issues => '0' do
995 995 get :show, :id => 3
996 996 end
997 997
998 998 assert_response :success
999 999 # Previous and next issues for all projects
1000 1000 assert_equal 2, assigns(:prev_issue_id)
1001 1001 assert_equal 5, assigns(:next_issue_id)
1002 1002
1003 1003 assert_tag 'div', :attributes => {:class => /next-prev-links/}
1004 1004 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
1005 1005 assert_tag 'a', :attributes => {:href => '/issues/5'}, :content => /Next/
1006 1006
1007 1007 count = Issue.open.visible.count
1008 1008 assert_tag 'span', :attributes => {:class => 'position'}, :content => "3 of #{count}"
1009 1009 end
1010 1010
1011 1011 def test_show_should_display_prev_next_links_with_saved_query_in_session
1012 1012 query = Query.create!(:name => 'test', :is_public => true, :user_id => 1,
1013 1013 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1014 1014 :sort_criteria => [['id', 'asc']])
1015 1015 @request.session[:query] = {:id => query.id, :project_id => nil}
1016 1016
1017 1017 get :show, :id => 11
1018 1018
1019 1019 assert_response :success
1020 1020 assert_equal query, assigns(:query)
1021 1021 # Previous and next issues for all projects
1022 1022 assert_equal 8, assigns(:prev_issue_id)
1023 1023 assert_equal 12, assigns(:next_issue_id)
1024 1024
1025 1025 assert_tag 'a', :attributes => {:href => '/issues/8'}, :content => /Previous/
1026 1026 assert_tag 'a', :attributes => {:href => '/issues/12'}, :content => /Next/
1027 1027 end
1028 1028
1029 1029 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1030 1030 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1031 1031
1032 1032 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1033 1033 @request.session['issues_index_sort'] = assoc_sort
1034 1034
1035 1035 get :show, :id => 3
1036 1036 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1037 1037
1038 1038 assert_tag 'div', :attributes => {:class => /next-prev-links/}, :content => /Previous/
1039 1039 assert_tag 'div', :attributes => {:class => /next-prev-links/}, :content => /Next/
1040 1040 end
1041 1041 end
1042 1042
1043 1043 def test_show_should_display_prev_next_links_with_project_query_in_session
1044 1044 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1045 1045 @request.session['issues_index_sort'] = 'id'
1046 1046
1047 1047 with_settings :display_subprojects_issues => '0' do
1048 1048 get :show, :id => 3
1049 1049 end
1050 1050
1051 1051 assert_response :success
1052 1052 # Previous and next issues inside project
1053 1053 assert_equal 2, assigns(:prev_issue_id)
1054 1054 assert_equal 7, assigns(:next_issue_id)
1055 1055
1056 1056 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
1057 1057 assert_tag 'a', :attributes => {:href => '/issues/7'}, :content => /Next/
1058 1058 end
1059 1059
1060 1060 def test_show_should_not_display_prev_link_for_first_issue
1061 1061 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1062 1062 @request.session['issues_index_sort'] = 'id'
1063 1063
1064 1064 with_settings :display_subprojects_issues => '0' do
1065 1065 get :show, :id => 1
1066 1066 end
1067 1067
1068 1068 assert_response :success
1069 1069 assert_nil assigns(:prev_issue_id)
1070 1070 assert_equal 2, assigns(:next_issue_id)
1071 1071
1072 1072 assert_no_tag 'a', :content => /Previous/
1073 1073 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Next/
1074 1074 end
1075 1075
1076 1076 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1077 1077 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1078 1078 @request.session['issues_index_sort'] = 'id'
1079 1079
1080 1080 get :show, :id => 1
1081 1081
1082 1082 assert_response :success
1083 1083 assert_nil assigns(:prev_issue_id)
1084 1084 assert_nil assigns(:next_issue_id)
1085 1085
1086 1086 assert_no_tag 'a', :content => /Previous/
1087 1087 assert_no_tag 'a', :content => /Next/
1088 1088 end
1089 1089
1090 1090 def test_show_should_display_visible_changesets_from_other_projects
1091 1091 project = Project.find(2)
1092 1092 issue = project.issues.first
1093 1093 issue.changeset_ids = [102]
1094 1094 issue.save!
1095 1095 project.disable_module! :repository
1096 1096
1097 1097 @request.session[:user_id] = 2
1098 1098 get :show, :id => issue.id
1099 1099 assert_tag 'a', :attributes => {:href => "/projects/ecookbook/repository/revisions/3"}
1100 1100 end
1101 1101
1102 1102 def test_show_with_multi_custom_field
1103 1103 field = CustomField.find(1)
1104 1104 field.update_attribute :multiple, true
1105 1105 issue = Issue.find(1)
1106 1106 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1107 1107 issue.save!
1108 1108
1109 1109 get :show, :id => 1
1110 1110 assert_response :success
1111 1111
1112 1112 assert_tag :td, :content => 'MySQL, Oracle'
1113 1113 end
1114 1114
1115 1115 def test_show_with_multi_user_custom_field
1116 1116 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1117 1117 :tracker_ids => [1], :is_for_all => true)
1118 1118 issue = Issue.find(1)
1119 1119 issue.custom_field_values = {field.id => ['2', '3']}
1120 1120 issue.save!
1121 1121
1122 1122 get :show, :id => 1
1123 1123 assert_response :success
1124 1124
1125 1125 # TODO: should display links
1126 1126 assert_tag :td, :content => 'Dave Lopper, John Smith'
1127 1127 end
1128 1128
1129 1129 def test_show_atom
1130 1130 get :show, :id => 2, :format => 'atom'
1131 1131 assert_response :success
1132 1132 assert_template 'journals/index'
1133 1133 # Inline image
1134 1134 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1135 1135 end
1136 1136
1137 1137 def test_show_export_to_pdf
1138 1138 get :show, :id => 3, :format => 'pdf'
1139 1139 assert_response :success
1140 1140 assert_equal 'application/pdf', @response.content_type
1141 1141 assert @response.body.starts_with?('%PDF')
1142 1142 assert_not_nil assigns(:issue)
1143 1143 end
1144 1144
1145 1145 def test_get_new
1146 1146 @request.session[:user_id] = 2
1147 1147 get :new, :project_id => 1, :tracker_id => 1
1148 1148 assert_response :success
1149 1149 assert_template 'new'
1150 1150
1151 1151 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
1152 1152 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1153 1153 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1154 1154 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1155 1155 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1156 1156 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1157 1157 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1158 1158 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1159 1159 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1160 1160 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1161 1161 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1162 1162 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1163 1163 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1164 1164 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1165 1165 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1166 1166 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1167 1167
1168 1168 # Be sure we don't display inactive IssuePriorities
1169 1169 assert ! IssuePriority.find(15).active?
1170 1170 assert_no_tag :option, :attributes => {:value => '15'},
1171 1171 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1172 1172 end
1173 1173
1174 1174 def test_get_new_with_minimal_permissions
1175 1175 Role.find(1).update_attribute :permissions, [:add_issues]
1176 1176 Workflow.delete_all :role_id => 1
1177 1177
1178 1178 @request.session[:user_id] = 2
1179 1179 get :new, :project_id => 1, :tracker_id => 1
1180 1180 assert_response :success
1181 1181 assert_template 'new'
1182 1182
1183 1183 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
1184 1184 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1185 1185 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1186 1186 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1187 1187 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1188 1188 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1189 1189 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1190 1190 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1191 1191 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1192 1192 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1193 1193 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1194 1194 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1195 1195 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1196 1196 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1197 1197 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1198 1198 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1199 1199 end
1200 1200
1201 1201 def test_get_new_with_multi_custom_field
1202 1202 field = IssueCustomField.find(1)
1203 1203 field.update_attribute :multiple, true
1204 1204
1205 1205 @request.session[:user_id] = 2
1206 1206 get :new, :project_id => 1, :tracker_id => 1
1207 1207 assert_response :success
1208 1208 assert_template 'new'
1209 1209
1210 1210 assert_tag 'select',
1211 1211 :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'},
1212 1212 :children => {:count => 3},
1213 1213 :child => {:tag => 'option', :attributes => {:value => 'MySQL'}, :content => 'MySQL'}
1214 1214 assert_tag 'input',
1215 1215 :attributes => {:name => 'issue[custom_field_values][1][]', :value => ''}
1216 1216 end
1217 1217
1218 1218 def test_get_new_with_multi_user_custom_field
1219 1219 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1220 1220 :tracker_ids => [1], :is_for_all => true)
1221 1221
1222 1222 @request.session[:user_id] = 2
1223 1223 get :new, :project_id => 1, :tracker_id => 1
1224 1224 assert_response :success
1225 1225 assert_template 'new'
1226 1226
1227 1227 assert_tag 'select',
1228 1228 :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :multiple => 'multiple'},
1229 1229 :children => {:count => Project.find(1).users.count},
1230 1230 :child => {:tag => 'option', :attributes => {:value => '2'}, :content => 'John Smith'}
1231 1231 assert_tag 'input',
1232 1232 :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :value => ''}
1233 1233 end
1234 1234
1235 1235 def test_get_new_without_default_start_date_is_creation_date
1236 1236 Setting.default_issue_start_date_to_creation_date = 0
1237 1237
1238 1238 @request.session[:user_id] = 2
1239 1239 get :new, :project_id => 1, :tracker_id => 1
1240 1240 assert_response :success
1241 1241 assert_template 'new'
1242 1242
1243 1243 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1244 1244 :value => nil }
1245 1245 end
1246 1246
1247 1247 def test_get_new_with_default_start_date_is_creation_date
1248 1248 Setting.default_issue_start_date_to_creation_date = 1
1249 1249
1250 1250 @request.session[:user_id] = 2
1251 1251 get :new, :project_id => 1, :tracker_id => 1
1252 1252 assert_response :success
1253 1253 assert_template 'new'
1254 1254
1255 1255 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1256 1256 :value => Date.today.to_s }
1257 1257 end
1258 1258
1259 1259 def test_get_new_form_should_allow_attachment_upload
1260 1260 @request.session[:user_id] = 2
1261 1261 get :new, :project_id => 1, :tracker_id => 1
1262 1262
1263 1263 assert_tag :tag => 'form',
1264 1264 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
1265 1265 :descendant => {
1266 1266 :tag => 'input',
1267 1267 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
1268 1268 }
1269 1269 end
1270 1270
1271 1271 def test_get_new_without_tracker_id
1272 1272 @request.session[:user_id] = 2
1273 1273 get :new, :project_id => 1
1274 1274 assert_response :success
1275 1275 assert_template 'new'
1276 1276
1277 1277 issue = assigns(:issue)
1278 1278 assert_not_nil issue
1279 1279 assert_equal Project.find(1).trackers.first, issue.tracker
1280 1280 end
1281 1281
1282 1282 def test_get_new_with_no_default_status_should_display_an_error
1283 1283 @request.session[:user_id] = 2
1284 1284 IssueStatus.delete_all
1285 1285
1286 1286 get :new, :project_id => 1
1287 1287 assert_response 500
1288 1288 assert_error_tag :content => /No default issue/
1289 1289 end
1290 1290
1291 1291 def test_get_new_with_no_tracker_should_display_an_error
1292 1292 @request.session[:user_id] = 2
1293 1293 Tracker.delete_all
1294 1294
1295 1295 get :new, :project_id => 1
1296 1296 assert_response 500
1297 1297 assert_error_tag :content => /No tracker/
1298 1298 end
1299 1299
1300 1300 def test_update_new_form
1301 1301 @request.session[:user_id] = 2
1302 1302 xhr :post, :new, :project_id => 1,
1303 1303 :issue => {:tracker_id => 2,
1304 1304 :subject => 'This is the test_new issue',
1305 1305 :description => 'This is the description',
1306 1306 :priority_id => 5}
1307 1307 assert_response :success
1308 1308 assert_template 'attributes'
1309 1309
1310 1310 issue = assigns(:issue)
1311 1311 assert_kind_of Issue, issue
1312 1312 assert_equal 1, issue.project_id
1313 1313 assert_equal 2, issue.tracker_id
1314 1314 assert_equal 'This is the test_new issue', issue.subject
1315 1315 end
1316 1316
1317 1317 def test_post_create
1318 1318 @request.session[:user_id] = 2
1319 1319 assert_difference 'Issue.count' do
1320 1320 post :create, :project_id => 1,
1321 1321 :issue => {:tracker_id => 3,
1322 1322 :status_id => 2,
1323 1323 :subject => 'This is the test_new issue',
1324 1324 :description => 'This is the description',
1325 1325 :priority_id => 5,
1326 1326 :start_date => '2010-11-07',
1327 1327 :estimated_hours => '',
1328 1328 :custom_field_values => {'2' => 'Value for field 2'}}
1329 1329 end
1330 1330 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1331 1331
1332 1332 issue = Issue.find_by_subject('This is the test_new issue')
1333 1333 assert_not_nil issue
1334 1334 assert_equal 2, issue.author_id
1335 1335 assert_equal 3, issue.tracker_id
1336 1336 assert_equal 2, issue.status_id
1337 1337 assert_equal Date.parse('2010-11-07'), issue.start_date
1338 1338 assert_nil issue.estimated_hours
1339 1339 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
1340 1340 assert_not_nil v
1341 1341 assert_equal 'Value for field 2', v.value
1342 1342 end
1343 1343
1344 1344 def test_post_new_with_group_assignment
1345 1345 group = Group.find(11)
1346 1346 project = Project.find(1)
1347 1347 project.members << Member.new(:principal => group, :roles => [Role.first])
1348 1348
1349 1349 with_settings :issue_group_assignment => '1' do
1350 1350 @request.session[:user_id] = 2
1351 1351 assert_difference 'Issue.count' do
1352 1352 post :create, :project_id => project.id,
1353 1353 :issue => {:tracker_id => 3,
1354 1354 :status_id => 1,
1355 1355 :subject => 'This is the test_new_with_group_assignment issue',
1356 1356 :assigned_to_id => group.id}
1357 1357 end
1358 1358 end
1359 1359 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1360 1360
1361 1361 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1362 1362 assert_not_nil issue
1363 1363 assert_equal group, issue.assigned_to
1364 1364 end
1365 1365
1366 1366 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1367 1367 Setting.default_issue_start_date_to_creation_date = 0
1368 1368
1369 1369 @request.session[:user_id] = 2
1370 1370 assert_difference 'Issue.count' do
1371 1371 post :create, :project_id => 1,
1372 1372 :issue => {:tracker_id => 3,
1373 1373 :status_id => 2,
1374 1374 :subject => 'This is the test_new issue',
1375 1375 :description => 'This is the description',
1376 1376 :priority_id => 5,
1377 1377 :estimated_hours => '',
1378 1378 :custom_field_values => {'2' => 'Value for field 2'}}
1379 1379 end
1380 1380 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1381 1381
1382 1382 issue = Issue.find_by_subject('This is the test_new issue')
1383 1383 assert_not_nil issue
1384 1384 assert_nil issue.start_date
1385 1385 end
1386 1386
1387 1387 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1388 1388 Setting.default_issue_start_date_to_creation_date = 1
1389 1389
1390 1390 @request.session[:user_id] = 2
1391 1391 assert_difference 'Issue.count' do
1392 1392 post :create, :project_id => 1,
1393 1393 :issue => {:tracker_id => 3,
1394 1394 :status_id => 2,
1395 1395 :subject => 'This is the test_new issue',
1396 1396 :description => 'This is the description',
1397 1397 :priority_id => 5,
1398 1398 :estimated_hours => '',
1399 1399 :custom_field_values => {'2' => 'Value for field 2'}}
1400 1400 end
1401 1401 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1402 1402
1403 1403 issue = Issue.find_by_subject('This is the test_new issue')
1404 1404 assert_not_nil issue
1405 1405 assert_equal Date.today, issue.start_date
1406 1406 end
1407 1407
1408 1408 def test_post_create_and_continue
1409 1409 @request.session[:user_id] = 2
1410 1410 assert_difference 'Issue.count' do
1411 1411 post :create, :project_id => 1,
1412 1412 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1413 1413 :continue => ''
1414 1414 end
1415 1415
1416 1416 issue = Issue.first(:order => 'id DESC')
1417 1417 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1418 1418 assert_not_nil flash[:notice], "flash was not set"
1419 1419 assert flash[:notice].include?("<a href='/issues/#{issue.id}'>##{issue.id}</a>"), "issue link not found in flash: #{flash[:notice]}"
1420 1420 end
1421 1421
1422 1422 def test_post_create_without_custom_fields_param
1423 1423 @request.session[:user_id] = 2
1424 1424 assert_difference 'Issue.count' do
1425 1425 post :create, :project_id => 1,
1426 1426 :issue => {:tracker_id => 1,
1427 1427 :subject => 'This is the test_new issue',
1428 1428 :description => 'This is the description',
1429 1429 :priority_id => 5}
1430 1430 end
1431 1431 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1432 1432 end
1433 1433
1434 1434 def test_post_create_with_multi_custom_field
1435 1435 field = IssueCustomField.find_by_name('Database')
1436 1436 field.update_attribute(:multiple, true)
1437 1437
1438 1438 @request.session[:user_id] = 2
1439 1439 assert_difference 'Issue.count' do
1440 1440 post :create, :project_id => 1,
1441 1441 :issue => {:tracker_id => 1,
1442 1442 :subject => 'This is the test_new issue',
1443 1443 :description => 'This is the description',
1444 1444 :priority_id => 5,
1445 1445 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1446 1446 end
1447 1447 assert_response 302
1448 1448 issue = Issue.first(:order => 'id DESC')
1449 1449 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1450 1450 end
1451 1451
1452 1452 def test_post_create_with_empty_multi_custom_field
1453 1453 field = IssueCustomField.find_by_name('Database')
1454 1454 field.update_attribute(:multiple, true)
1455 1455
1456 1456 @request.session[:user_id] = 2
1457 1457 assert_difference 'Issue.count' do
1458 1458 post :create, :project_id => 1,
1459 1459 :issue => {:tracker_id => 1,
1460 1460 :subject => 'This is the test_new issue',
1461 1461 :description => 'This is the description',
1462 1462 :priority_id => 5,
1463 1463 :custom_field_values => {'1' => ['']}}
1464 1464 end
1465 1465 assert_response 302
1466 1466 issue = Issue.first(:order => 'id DESC')
1467 1467 assert_equal [''], issue.custom_field_value(1).sort
1468 1468 end
1469 1469
1470 1470 def test_post_create_with_multi_user_custom_field
1471 1471 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1472 1472 :tracker_ids => [1], :is_for_all => true)
1473 1473
1474 1474 @request.session[:user_id] = 2
1475 1475 assert_difference 'Issue.count' do
1476 1476 post :create, :project_id => 1,
1477 1477 :issue => {:tracker_id => 1,
1478 1478 :subject => 'This is the test_new issue',
1479 1479 :description => 'This is the description',
1480 1480 :priority_id => 5,
1481 1481 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1482 1482 end
1483 1483 assert_response 302
1484 1484 issue = Issue.first(:order => 'id DESC')
1485 1485 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1486 1486 end
1487 1487
1488 1488 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1489 1489 field = IssueCustomField.find_by_name('Database')
1490 1490 field.update_attribute(:is_required, true)
1491 1491
1492 1492 @request.session[:user_id] = 2
1493 1493 assert_no_difference 'Issue.count' do
1494 1494 post :create, :project_id => 1,
1495 1495 :issue => {:tracker_id => 1,
1496 1496 :subject => 'This is the test_new issue',
1497 1497 :description => 'This is the description',
1498 1498 :priority_id => 5}
1499 1499 end
1500 1500 assert_response :success
1501 1501 assert_template 'new'
1502 1502 issue = assigns(:issue)
1503 1503 assert_not_nil issue
1504 1504 assert_error_tag :content => /Database can't be blank/
1505 1505 end
1506 1506
1507 1507 def test_post_create_with_watchers
1508 1508 @request.session[:user_id] = 2
1509 1509 ActionMailer::Base.deliveries.clear
1510 1510
1511 1511 assert_difference 'Watcher.count', 2 do
1512 1512 post :create, :project_id => 1,
1513 1513 :issue => {:tracker_id => 1,
1514 1514 :subject => 'This is a new issue with watchers',
1515 1515 :description => 'This is the description',
1516 1516 :priority_id => 5,
1517 1517 :watcher_user_ids => ['2', '3']}
1518 1518 end
1519 1519 issue = Issue.find_by_subject('This is a new issue with watchers')
1520 1520 assert_not_nil issue
1521 1521 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1522 1522
1523 1523 # Watchers added
1524 1524 assert_equal [2, 3], issue.watcher_user_ids.sort
1525 1525 assert issue.watched_by?(User.find(3))
1526 1526 # Watchers notified
1527 1527 mail = ActionMailer::Base.deliveries.last
1528 assert_kind_of TMail::Mail, mail
1528 assert_not_nil mail
1529 1529 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1530 1530 end
1531 1531
1532 1532 def test_post_create_subissue
1533 1533 @request.session[:user_id] = 2
1534 1534
1535 1535 assert_difference 'Issue.count' do
1536 1536 post :create, :project_id => 1,
1537 1537 :issue => {:tracker_id => 1,
1538 1538 :subject => 'This is a child issue',
1539 1539 :parent_issue_id => 2}
1540 1540 end
1541 1541 issue = Issue.find_by_subject('This is a child issue')
1542 1542 assert_not_nil issue
1543 1543 assert_equal Issue.find(2), issue.parent
1544 1544 end
1545 1545
1546 1546 def test_post_create_subissue_with_non_numeric_parent_id
1547 1547 @request.session[:user_id] = 2
1548 1548
1549 1549 assert_difference 'Issue.count' do
1550 1550 post :create, :project_id => 1,
1551 1551 :issue => {:tracker_id => 1,
1552 1552 :subject => 'This is a child issue',
1553 1553 :parent_issue_id => 'ABC'}
1554 1554 end
1555 1555 issue = Issue.find_by_subject('This is a child issue')
1556 1556 assert_not_nil issue
1557 1557 assert_nil issue.parent
1558 1558 end
1559 1559
1560 1560 def test_post_create_private
1561 1561 @request.session[:user_id] = 2
1562 1562
1563 1563 assert_difference 'Issue.count' do
1564 1564 post :create, :project_id => 1,
1565 1565 :issue => {:tracker_id => 1,
1566 1566 :subject => 'This is a private issue',
1567 1567 :is_private => '1'}
1568 1568 end
1569 1569 issue = Issue.first(:order => 'id DESC')
1570 1570 assert issue.is_private?
1571 1571 end
1572 1572
1573 1573 def test_post_create_private_with_set_own_issues_private_permission
1574 1574 role = Role.find(1)
1575 1575 role.remove_permission! :set_issues_private
1576 1576 role.add_permission! :set_own_issues_private
1577 1577
1578 1578 @request.session[:user_id] = 2
1579 1579
1580 1580 assert_difference 'Issue.count' do
1581 1581 post :create, :project_id => 1,
1582 1582 :issue => {:tracker_id => 1,
1583 1583 :subject => 'This is a private issue',
1584 1584 :is_private => '1'}
1585 1585 end
1586 1586 issue = Issue.first(:order => 'id DESC')
1587 1587 assert issue.is_private?
1588 1588 end
1589 1589
1590 1590 def test_post_create_should_send_a_notification
1591 1591 ActionMailer::Base.deliveries.clear
1592 1592 @request.session[:user_id] = 2
1593 1593 assert_difference 'Issue.count' do
1594 1594 post :create, :project_id => 1,
1595 1595 :issue => {:tracker_id => 3,
1596 1596 :subject => 'This is the test_new issue',
1597 1597 :description => 'This is the description',
1598 1598 :priority_id => 5,
1599 1599 :estimated_hours => '',
1600 1600 :custom_field_values => {'2' => 'Value for field 2'}}
1601 1601 end
1602 1602 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1603 1603
1604 1604 assert_equal 1, ActionMailer::Base.deliveries.size
1605 1605 end
1606 1606
1607 1607 def test_post_create_should_preserve_fields_values_on_validation_failure
1608 1608 @request.session[:user_id] = 2
1609 1609 post :create, :project_id => 1,
1610 1610 :issue => {:tracker_id => 1,
1611 1611 # empty subject
1612 1612 :subject => '',
1613 1613 :description => 'This is a description',
1614 1614 :priority_id => 6,
1615 1615 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
1616 1616 assert_response :success
1617 1617 assert_template 'new'
1618 1618
1619 1619 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
1620 1620 :content => 'This is a description'
1621 1621 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1622 1622 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1623 1623 :value => '6' },
1624 1624 :content => 'High' }
1625 1625 # Custom fields
1626 1626 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
1627 1627 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1628 1628 :value => 'Oracle' },
1629 1629 :content => 'Oracle' }
1630 1630 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
1631 1631 :value => 'Value for field 2'}
1632 1632 end
1633 1633
1634 1634 def test_post_create_should_ignore_non_safe_attributes
1635 1635 @request.session[:user_id] = 2
1636 1636 assert_nothing_raised do
1637 1637 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
1638 1638 end
1639 1639 end
1640 1640
1641 1641 def test_post_create_with_attachment
1642 1642 set_tmp_attachments_directory
1643 1643 @request.session[:user_id] = 2
1644 1644
1645 1645 assert_difference 'Issue.count' do
1646 1646 assert_difference 'Attachment.count' do
1647 1647 post :create, :project_id => 1,
1648 1648 :issue => { :tracker_id => '1', :subject => 'With attachment' },
1649 1649 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1650 1650 end
1651 1651 end
1652 1652
1653 1653 issue = Issue.first(:order => 'id DESC')
1654 1654 attachment = Attachment.first(:order => 'id DESC')
1655 1655
1656 1656 assert_equal issue, attachment.container
1657 1657 assert_equal 2, attachment.author_id
1658 1658 assert_equal 'testfile.txt', attachment.filename
1659 1659 assert_equal 'text/plain', attachment.content_type
1660 1660 assert_equal 'test file', attachment.description
1661 1661 assert_equal 59, attachment.filesize
1662 1662 assert File.exists?(attachment.diskfile)
1663 1663 assert_equal 59, File.size(attachment.diskfile)
1664 1664 end
1665 1665
1666 1666 def test_post_create_with_failure_should_save_attachments
1667 1667 set_tmp_attachments_directory
1668 1668 @request.session[:user_id] = 2
1669 1669
1670 1670 assert_no_difference 'Issue.count' do
1671 1671 assert_difference 'Attachment.count' do
1672 1672 post :create, :project_id => 1,
1673 1673 :issue => { :tracker_id => '1', :subject => '' },
1674 1674 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1675 1675 assert_response :success
1676 1676 assert_template 'new'
1677 1677 end
1678 1678 end
1679 1679
1680 1680 attachment = Attachment.first(:order => 'id DESC')
1681 1681 assert_equal 'testfile.txt', attachment.filename
1682 1682 assert File.exists?(attachment.diskfile)
1683 1683 assert_nil attachment.container
1684 1684
1685 1685 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
1686 1686 assert_tag 'span', :content => /testfile.txt/
1687 1687 end
1688 1688
1689 1689 def test_post_create_with_failure_should_keep_saved_attachments
1690 1690 set_tmp_attachments_directory
1691 1691 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
1692 1692 @request.session[:user_id] = 2
1693 1693
1694 1694 assert_no_difference 'Issue.count' do
1695 1695 assert_no_difference 'Attachment.count' do
1696 1696 post :create, :project_id => 1,
1697 1697 :issue => { :tracker_id => '1', :subject => '' },
1698 1698 :attachments => {'p0' => {'token' => attachment.token}}
1699 1699 assert_response :success
1700 1700 assert_template 'new'
1701 1701 end
1702 1702 end
1703 1703
1704 1704 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
1705 1705 assert_tag 'span', :content => /testfile.txt/
1706 1706 end
1707 1707
1708 1708 def test_post_create_should_attach_saved_attachments
1709 1709 set_tmp_attachments_directory
1710 1710 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
1711 1711 @request.session[:user_id] = 2
1712 1712
1713 1713 assert_difference 'Issue.count' do
1714 1714 assert_no_difference 'Attachment.count' do
1715 1715 post :create, :project_id => 1,
1716 1716 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
1717 1717 :attachments => {'p0' => {'token' => attachment.token}}
1718 1718 assert_response 302
1719 1719 end
1720 1720 end
1721 1721
1722 1722 issue = Issue.first(:order => 'id DESC')
1723 1723 assert_equal 1, issue.attachments.count
1724 1724
1725 1725 attachment.reload
1726 1726 assert_equal issue, attachment.container
1727 1727 end
1728 1728
1729 1729 context "without workflow privilege" do
1730 1730 setup do
1731 1731 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1732 1732 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1733 1733 end
1734 1734
1735 1735 context "#new" do
1736 1736 should "propose default status only" do
1737 1737 get :new, :project_id => 1
1738 1738 assert_response :success
1739 1739 assert_template 'new'
1740 1740 assert_tag :tag => 'select',
1741 1741 :attributes => {:name => 'issue[status_id]'},
1742 1742 :children => {:count => 1},
1743 1743 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
1744 1744 end
1745 1745
1746 1746 should "accept default status" do
1747 1747 assert_difference 'Issue.count' do
1748 1748 post :create, :project_id => 1,
1749 1749 :issue => {:tracker_id => 1,
1750 1750 :subject => 'This is an issue',
1751 1751 :status_id => 1}
1752 1752 end
1753 1753 issue = Issue.last(:order => 'id')
1754 1754 assert_equal IssueStatus.default, issue.status
1755 1755 end
1756 1756
1757 1757 should "ignore unauthorized status" do
1758 1758 assert_difference 'Issue.count' do
1759 1759 post :create, :project_id => 1,
1760 1760 :issue => {:tracker_id => 1,
1761 1761 :subject => 'This is an issue',
1762 1762 :status_id => 3}
1763 1763 end
1764 1764 issue = Issue.last(:order => 'id')
1765 1765 assert_equal IssueStatus.default, issue.status
1766 1766 end
1767 1767 end
1768 1768
1769 1769 context "#update" do
1770 1770 should "ignore status change" do
1771 1771 assert_difference 'Journal.count' do
1772 1772 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1773 1773 end
1774 1774 assert_equal 1, Issue.find(1).status_id
1775 1775 end
1776 1776
1777 1777 should "ignore attributes changes" do
1778 1778 assert_difference 'Journal.count' do
1779 1779 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1780 1780 end
1781 1781 issue = Issue.find(1)
1782 1782 assert_equal "Can't print recipes", issue.subject
1783 1783 assert_nil issue.assigned_to
1784 1784 end
1785 1785 end
1786 1786 end
1787 1787
1788 1788 context "with workflow privilege" do
1789 1789 setup do
1790 1790 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
1791 1791 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
1792 1792 Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
1793 1793 Role.anonymous.add_permission! :add_issues, :add_issue_notes
1794 1794 end
1795 1795
1796 1796 context "#update" do
1797 1797 should "accept authorized status" do
1798 1798 assert_difference 'Journal.count' do
1799 1799 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1800 1800 end
1801 1801 assert_equal 3, Issue.find(1).status_id
1802 1802 end
1803 1803
1804 1804 should "ignore unauthorized status" do
1805 1805 assert_difference 'Journal.count' do
1806 1806 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1807 1807 end
1808 1808 assert_equal 1, Issue.find(1).status_id
1809 1809 end
1810 1810
1811 1811 should "accept authorized attributes changes" do
1812 1812 assert_difference 'Journal.count' do
1813 1813 put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
1814 1814 end
1815 1815 issue = Issue.find(1)
1816 1816 assert_equal 2, issue.assigned_to_id
1817 1817 end
1818 1818
1819 1819 should "ignore unauthorized attributes changes" do
1820 1820 assert_difference 'Journal.count' do
1821 1821 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
1822 1822 end
1823 1823 issue = Issue.find(1)
1824 1824 assert_equal "Can't print recipes", issue.subject
1825 1825 end
1826 1826 end
1827 1827
1828 1828 context "and :edit_issues permission" do
1829 1829 setup do
1830 1830 Role.anonymous.add_permission! :add_issues, :edit_issues
1831 1831 end
1832 1832
1833 1833 should "accept authorized status" do
1834 1834 assert_difference 'Journal.count' do
1835 1835 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
1836 1836 end
1837 1837 assert_equal 3, Issue.find(1).status_id
1838 1838 end
1839 1839
1840 1840 should "ignore unauthorized status" do
1841 1841 assert_difference 'Journal.count' do
1842 1842 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
1843 1843 end
1844 1844 assert_equal 1, Issue.find(1).status_id
1845 1845 end
1846 1846
1847 1847 should "accept authorized attributes changes" do
1848 1848 assert_difference 'Journal.count' do
1849 1849 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
1850 1850 end
1851 1851 issue = Issue.find(1)
1852 1852 assert_equal "changed", issue.subject
1853 1853 assert_equal 2, issue.assigned_to_id
1854 1854 end
1855 1855 end
1856 1856 end
1857 1857
1858 1858 def test_new_as_copy
1859 1859 @request.session[:user_id] = 2
1860 1860 get :new, :project_id => 1, :copy_from => 1
1861 1861
1862 1862 assert_response :success
1863 1863 assert_template 'new'
1864 1864
1865 1865 assert_not_nil assigns(:issue)
1866 1866 orig = Issue.find(1)
1867 1867 assert_equal 1, assigns(:issue).project_id
1868 1868 assert_equal orig.subject, assigns(:issue).subject
1869 1869 assert assigns(:issue).copy?
1870 1870
1871 1871 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
1872 1872 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
1873 1873 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
1874 1874 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}, :content => 'eCookbook'}
1875 1875 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
1876 1876 :child => {:tag => 'option', :attributes => {:value => '2', :selected => nil}, :content => 'OnlineStore'}
1877 1877 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
1878 1878 end
1879 1879
1880 1880 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
1881 1881 @request.session[:user_id] = 2
1882 1882 issue = Issue.find(3)
1883 1883 assert issue.attachments.count > 0
1884 1884 get :new, :project_id => 1, :copy_from => 3
1885 1885
1886 1886 assert_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
1887 1887 end
1888 1888
1889 1889 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
1890 1890 @request.session[:user_id] = 2
1891 1891 issue = Issue.find(3)
1892 1892 issue.attachments.delete_all
1893 1893 get :new, :project_id => 1, :copy_from => 3
1894 1894
1895 1895 assert_no_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
1896 1896 end
1897 1897
1898 1898 def test_new_as_copy_with_invalid_issue_should_respond_with_404
1899 1899 @request.session[:user_id] = 2
1900 1900 get :new, :project_id => 1, :copy_from => 99999
1901 1901 assert_response 404
1902 1902 end
1903 1903
1904 1904 def test_create_as_copy_on_different_project
1905 1905 @request.session[:user_id] = 2
1906 1906 assert_difference 'Issue.count' do
1907 1907 post :create, :project_id => 1, :copy_from => 1,
1908 1908 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
1909 1909
1910 1910 assert_not_nil assigns(:issue)
1911 1911 assert assigns(:issue).copy?
1912 1912 end
1913 1913 issue = Issue.first(:order => 'id DESC')
1914 1914 assert_redirected_to "/issues/#{issue.id}"
1915 1915
1916 1916 assert_equal 2, issue.project_id
1917 1917 assert_equal 3, issue.tracker_id
1918 1918 assert_equal 'Copy', issue.subject
1919 1919 end
1920 1920
1921 1921 def test_create_as_copy_should_copy_attachments
1922 1922 @request.session[:user_id] = 2
1923 1923 issue = Issue.find(3)
1924 1924 count = issue.attachments.count
1925 1925 assert count > 0
1926 1926
1927 1927 assert_difference 'Issue.count' do
1928 1928 assert_difference 'Attachment.count', count do
1929 1929 assert_no_difference 'Journal.count' do
1930 1930 post :create, :project_id => 1, :copy_from => 3,
1931 1931 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
1932 1932 :copy_attachments => '1'
1933 1933 end
1934 1934 end
1935 1935 end
1936 1936 copy = Issue.first(:order => 'id DESC')
1937 1937 assert_equal count, copy.attachments.count
1938 1938 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
1939 1939 end
1940 1940
1941 1941 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
1942 1942 @request.session[:user_id] = 2
1943 1943 issue = Issue.find(3)
1944 1944 count = issue.attachments.count
1945 1945 assert count > 0
1946 1946
1947 1947 assert_difference 'Issue.count' do
1948 1948 assert_no_difference 'Attachment.count' do
1949 1949 assert_no_difference 'Journal.count' do
1950 1950 post :create, :project_id => 1, :copy_from => 3,
1951 1951 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
1952 1952 end
1953 1953 end
1954 1954 end
1955 1955 copy = Issue.first(:order => 'id DESC')
1956 1956 assert_equal 0, copy.attachments.count
1957 1957 end
1958 1958
1959 1959 def test_create_as_copy_with_attachments_should_add_new_files
1960 1960 @request.session[:user_id] = 2
1961 1961 issue = Issue.find(3)
1962 1962 count = issue.attachments.count
1963 1963 assert count > 0
1964 1964
1965 1965 assert_difference 'Issue.count' do
1966 1966 assert_difference 'Attachment.count', count + 1 do
1967 1967 assert_no_difference 'Journal.count' do
1968 1968 post :create, :project_id => 1, :copy_from => 3,
1969 1969 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
1970 1970 :copy_attachments => '1',
1971 1971 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
1972 1972 end
1973 1973 end
1974 1974 end
1975 1975 copy = Issue.first(:order => 'id DESC')
1976 1976 assert_equal count + 1, copy.attachments.count
1977 1977 end
1978 1978
1979 1979 def test_create_as_copy_with_failure
1980 1980 @request.session[:user_id] = 2
1981 1981 post :create, :project_id => 1, :copy_from => 1,
1982 1982 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
1983 1983
1984 1984 assert_response :success
1985 1985 assert_template 'new'
1986 1986
1987 1987 assert_not_nil assigns(:issue)
1988 1988 assert assigns(:issue).copy?
1989 1989
1990 1990 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
1991 1991 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
1992 1992 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
1993 1993 :child => {:tag => 'option', :attributes => {:value => '1', :selected => nil}, :content => 'eCookbook'}
1994 1994 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
1995 1995 :child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}, :content => 'OnlineStore'}
1996 1996 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
1997 1997 end
1998 1998
1999 1999 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2000 2000 @request.session[:user_id] = 2
2001 2001 assert !User.find(2).member_of?(Project.find(4))
2002 2002
2003 2003 assert_difference 'Issue.count' do
2004 2004 post :create, :project_id => 1, :copy_from => 1,
2005 2005 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2006 2006 end
2007 2007 issue = Issue.first(:order => 'id DESC')
2008 2008 assert_equal 1, issue.project_id
2009 2009 end
2010 2010
2011 2011 def test_get_edit
2012 2012 @request.session[:user_id] = 2
2013 2013 get :edit, :id => 1
2014 2014 assert_response :success
2015 2015 assert_template 'edit'
2016 2016 assert_not_nil assigns(:issue)
2017 2017 assert_equal Issue.find(1), assigns(:issue)
2018 2018
2019 2019 # Be sure we don't display inactive IssuePriorities
2020 2020 assert ! IssuePriority.find(15).active?
2021 2021 assert_no_tag :option, :attributes => {:value => '15'},
2022 2022 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2023 2023 end
2024 2024
2025 2025 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2026 2026 @request.session[:user_id] = 2
2027 2027 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2028 2028
2029 2029 get :edit, :id => 1
2030 2030 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2031 2031 end
2032 2032
2033 2033 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2034 2034 @request.session[:user_id] = 2
2035 2035 Role.find_by_name('Manager').remove_permission! :log_time
2036 2036
2037 2037 get :edit, :id => 1
2038 2038 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2039 2039 end
2040 2040
2041 2041 def test_get_edit_with_params
2042 2042 @request.session[:user_id] = 2
2043 2043 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2044 2044 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
2045 2045 assert_response :success
2046 2046 assert_template 'edit'
2047 2047
2048 2048 issue = assigns(:issue)
2049 2049 assert_not_nil issue
2050 2050
2051 2051 assert_equal 5, issue.status_id
2052 2052 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
2053 2053 :child => { :tag => 'option',
2054 2054 :content => 'Closed',
2055 2055 :attributes => { :selected => 'selected' } }
2056 2056
2057 2057 assert_equal 7, issue.priority_id
2058 2058 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
2059 2059 :child => { :tag => 'option',
2060 2060 :content => 'Urgent',
2061 2061 :attributes => { :selected => 'selected' } }
2062 2062
2063 2063 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
2064 2064 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
2065 2065 :child => { :tag => 'option',
2066 2066 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
2067 2067 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
2068 2068 end
2069 2069
2070 2070 def test_get_edit_with_multi_custom_field
2071 2071 field = CustomField.find(1)
2072 2072 field.update_attribute :multiple, true
2073 2073 issue = Issue.find(1)
2074 2074 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2075 2075 issue.save!
2076 2076
2077 2077 @request.session[:user_id] = 2
2078 2078 get :edit, :id => 1
2079 2079 assert_response :success
2080 2080 assert_template 'edit'
2081 2081
2082 2082 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'}
2083 2083 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2084 2084 :child => {:tag => 'option', :attributes => {:value => 'MySQL', :selected => 'selected'}}
2085 2085 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2086 2086 :child => {:tag => 'option', :attributes => {:value => 'PostgreSQL', :selected => nil}}
2087 2087 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2088 2088 :child => {:tag => 'option', :attributes => {:value => 'Oracle', :selected => 'selected'}}
2089 2089 end
2090 2090
2091 2091 def test_update_edit_form
2092 2092 @request.session[:user_id] = 2
2093 2093 xhr :put, :new, :project_id => 1,
2094 2094 :id => 1,
2095 2095 :issue => {:tracker_id => 2,
2096 2096 :subject => 'This is the test_new issue',
2097 2097 :description => 'This is the description',
2098 2098 :priority_id => 5}
2099 2099 assert_response :success
2100 2100 assert_template 'attributes'
2101 2101
2102 2102 issue = assigns(:issue)
2103 2103 assert_kind_of Issue, issue
2104 2104 assert_equal 1, issue.id
2105 2105 assert_equal 1, issue.project_id
2106 2106 assert_equal 2, issue.tracker_id
2107 2107 assert_equal 'This is the test_new issue', issue.subject
2108 2108 end
2109 2109
2110 2110 def test_update_edit_form_with_project_change
2111 2111 @request.session[:user_id] = 2
2112 2112 xhr :put, :new, :project_id => 1,
2113 2113 :id => 1,
2114 2114 :project_change => '1',
2115 2115 :issue => {:project_id => 2,
2116 2116 :tracker_id => 2,
2117 2117 :subject => 'This is the test_new issue',
2118 2118 :description => 'This is the description',
2119 2119 :priority_id => 5}
2120 2120 assert_response :success
2121 2121 assert_template 'form'
2122 2122
2123 2123 issue = assigns(:issue)
2124 2124 assert_kind_of Issue, issue
2125 2125 assert_equal 1, issue.id
2126 2126 assert_equal 2, issue.project_id
2127 2127 assert_equal 2, issue.tracker_id
2128 2128 assert_equal 'This is the test_new issue', issue.subject
2129 2129 end
2130 2130
2131 2131 def test_update_using_invalid_http_verbs
2132 2132 @request.session[:user_id] = 2
2133 2133 subject = 'Updated by an invalid http verb'
2134 2134
2135 2135 get :update, :id => 1, :issue => {:subject => subject}
2136 2136 assert_not_equal subject, Issue.find(1).subject
2137 2137
2138 2138 post :update, :id => 1, :issue => {:subject => subject}
2139 2139 assert_not_equal subject, Issue.find(1).subject
2140 2140
2141 2141 delete :update, :id => 1, :issue => {:subject => subject}
2142 2142 assert_not_equal subject, Issue.find(1).subject
2143 2143 end
2144 2144
2145 2145 def test_put_update_without_custom_fields_param
2146 2146 @request.session[:user_id] = 2
2147 2147 ActionMailer::Base.deliveries.clear
2148 2148
2149 2149 issue = Issue.find(1)
2150 2150 assert_equal '125', issue.custom_value_for(2).value
2151 2151 old_subject = issue.subject
2152 2152 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2153 2153
2154 2154 assert_difference('Journal.count') do
2155 2155 assert_difference('JournalDetail.count', 2) do
2156 2156 put :update, :id => 1, :issue => {:subject => new_subject,
2157 2157 :priority_id => '6',
2158 2158 :category_id => '1' # no change
2159 2159 }
2160 2160 end
2161 2161 end
2162 2162 assert_redirected_to :action => 'show', :id => '1'
2163 2163 issue.reload
2164 2164 assert_equal new_subject, issue.subject
2165 2165 # Make sure custom fields were not cleared
2166 2166 assert_equal '125', issue.custom_value_for(2).value
2167 2167
2168 2168 mail = ActionMailer::Base.deliveries.last
2169 assert_kind_of TMail::Mail, mail
2169 assert_not_nil mail
2170 2170 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2171 2171 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
2172 2172 end
2173 2173
2174 2174 def test_put_update_with_project_change
2175 2175 @request.session[:user_id] = 2
2176 2176 ActionMailer::Base.deliveries.clear
2177 2177
2178 2178 assert_difference('Journal.count') do
2179 2179 assert_difference('JournalDetail.count', 3) do
2180 2180 put :update, :id => 1, :issue => {:project_id => '2',
2181 2181 :tracker_id => '1', # no change
2182 2182 :priority_id => '6',
2183 2183 :category_id => '3'
2184 2184 }
2185 2185 end
2186 2186 end
2187 2187 assert_redirected_to :action => 'show', :id => '1'
2188 2188 issue = Issue.find(1)
2189 2189 assert_equal 2, issue.project_id
2190 2190 assert_equal 1, issue.tracker_id
2191 2191 assert_equal 6, issue.priority_id
2192 2192 assert_equal 3, issue.category_id
2193 2193
2194 2194 mail = ActionMailer::Base.deliveries.last
2195 2195 assert_not_nil mail
2196 2196 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2197 2197 assert mail.body.include?("Project changed from eCookbook to OnlineStore")
2198 2198 end
2199 2199
2200 2200 def test_put_update_with_tracker_change
2201 2201 @request.session[:user_id] = 2
2202 2202 ActionMailer::Base.deliveries.clear
2203 2203
2204 2204 assert_difference('Journal.count') do
2205 2205 assert_difference('JournalDetail.count', 2) do
2206 2206 put :update, :id => 1, :issue => {:project_id => '1',
2207 2207 :tracker_id => '2',
2208 2208 :priority_id => '6'
2209 2209 }
2210 2210 end
2211 2211 end
2212 2212 assert_redirected_to :action => 'show', :id => '1'
2213 2213 issue = Issue.find(1)
2214 2214 assert_equal 1, issue.project_id
2215 2215 assert_equal 2, issue.tracker_id
2216 2216 assert_equal 6, issue.priority_id
2217 2217 assert_equal 1, issue.category_id
2218 2218
2219 2219 mail = ActionMailer::Base.deliveries.last
2220 2220 assert_not_nil mail
2221 2221 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2222 2222 assert mail.body.include?("Tracker changed from Bug to Feature request")
2223 2223 end
2224 2224
2225 2225 def test_put_update_with_custom_field_change
2226 2226 @request.session[:user_id] = 2
2227 2227 issue = Issue.find(1)
2228 2228 assert_equal '125', issue.custom_value_for(2).value
2229 2229
2230 2230 assert_difference('Journal.count') do
2231 2231 assert_difference('JournalDetail.count', 3) do
2232 2232 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2233 2233 :priority_id => '6',
2234 2234 :category_id => '1', # no change
2235 2235 :custom_field_values => { '2' => 'New custom value' }
2236 2236 }
2237 2237 end
2238 2238 end
2239 2239 assert_redirected_to :action => 'show', :id => '1'
2240 2240 issue.reload
2241 2241 assert_equal 'New custom value', issue.custom_value_for(2).value
2242 2242
2243 2243 mail = ActionMailer::Base.deliveries.last
2244 assert_kind_of TMail::Mail, mail
2244 assert_not_nil mail
2245 2245 assert mail.body.include?("Searchable field changed from 125 to New custom value")
2246 2246 end
2247 2247
2248 2248 def test_put_update_with_multi_custom_field_change
2249 2249 field = CustomField.find(1)
2250 2250 field.update_attribute :multiple, true
2251 2251 issue = Issue.find(1)
2252 2252 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2253 2253 issue.save!
2254 2254
2255 2255 @request.session[:user_id] = 2
2256 2256 assert_difference('Journal.count') do
2257 2257 assert_difference('JournalDetail.count', 3) do
2258 2258 put :update, :id => 1,
2259 2259 :issue => {
2260 2260 :subject => 'Custom field change',
2261 2261 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2262 2262 }
2263 2263 end
2264 2264 end
2265 2265 assert_redirected_to :action => 'show', :id => '1'
2266 2266 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2267 2267 end
2268 2268
2269 2269 def test_put_update_with_status_and_assignee_change
2270 2270 issue = Issue.find(1)
2271 2271 assert_equal 1, issue.status_id
2272 2272 @request.session[:user_id] = 2
2273 2273 assert_difference('TimeEntry.count', 0) do
2274 2274 put :update,
2275 2275 :id => 1,
2276 2276 :issue => { :status_id => 2, :assigned_to_id => 3 },
2277 2277 :notes => 'Assigned to dlopper',
2278 2278 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2279 2279 end
2280 2280 assert_redirected_to :action => 'show', :id => '1'
2281 2281 issue.reload
2282 2282 assert_equal 2, issue.status_id
2283 2283 j = Journal.find(:first, :order => 'id DESC')
2284 2284 assert_equal 'Assigned to dlopper', j.notes
2285 2285 assert_equal 2, j.details.size
2286 2286
2287 2287 mail = ActionMailer::Base.deliveries.last
2288 2288 assert mail.body.include?("Status changed from New to Assigned")
2289 2289 # subject should contain the new status
2290 2290 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2291 2291 end
2292 2292
2293 2293 def test_put_update_with_note_only
2294 2294 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2295 2295 # anonymous user
2296 2296 put :update,
2297 2297 :id => 1,
2298 2298 :notes => notes
2299 2299 assert_redirected_to :action => 'show', :id => '1'
2300 2300 j = Journal.find(:first, :order => 'id DESC')
2301 2301 assert_equal notes, j.notes
2302 2302 assert_equal 0, j.details.size
2303 2303 assert_equal User.anonymous, j.user
2304 2304
2305 2305 mail = ActionMailer::Base.deliveries.last
2306 2306 assert mail.body.include?(notes)
2307 2307 end
2308 2308
2309 2309 def test_put_update_with_note_and_spent_time
2310 2310 @request.session[:user_id] = 2
2311 2311 spent_hours_before = Issue.find(1).spent_hours
2312 2312 assert_difference('TimeEntry.count') do
2313 2313 put :update,
2314 2314 :id => 1,
2315 2315 :notes => '2.5 hours added',
2316 2316 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2317 2317 end
2318 2318 assert_redirected_to :action => 'show', :id => '1'
2319 2319
2320 2320 issue = Issue.find(1)
2321 2321
2322 2322 j = Journal.find(:first, :order => 'id DESC')
2323 2323 assert_equal '2.5 hours added', j.notes
2324 2324 assert_equal 0, j.details.size
2325 2325
2326 2326 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2327 2327 assert_not_nil t
2328 2328 assert_equal 2.5, t.hours
2329 2329 assert_equal spent_hours_before + 2.5, issue.spent_hours
2330 2330 end
2331 2331
2332 2332 def test_put_update_with_attachment_only
2333 2333 set_tmp_attachments_directory
2334 2334
2335 2335 # Delete all fixtured journals, a race condition can occur causing the wrong
2336 2336 # journal to get fetched in the next find.
2337 2337 Journal.delete_all
2338 2338
2339 2339 # anonymous user
2340 2340 assert_difference 'Attachment.count' do
2341 2341 put :update, :id => 1,
2342 2342 :notes => '',
2343 2343 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2344 2344 end
2345 2345
2346 2346 assert_redirected_to :action => 'show', :id => '1'
2347 2347 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
2348 2348 assert j.notes.blank?
2349 2349 assert_equal 1, j.details.size
2350 2350 assert_equal 'testfile.txt', j.details.first.value
2351 2351 assert_equal User.anonymous, j.user
2352 2352
2353 2353 attachment = Attachment.first(:order => 'id DESC')
2354 2354 assert_equal Issue.find(1), attachment.container
2355 2355 assert_equal User.anonymous, attachment.author
2356 2356 assert_equal 'testfile.txt', attachment.filename
2357 2357 assert_equal 'text/plain', attachment.content_type
2358 2358 assert_equal 'test file', attachment.description
2359 2359 assert_equal 59, attachment.filesize
2360 2360 assert File.exists?(attachment.diskfile)
2361 2361 assert_equal 59, File.size(attachment.diskfile)
2362 2362
2363 2363 mail = ActionMailer::Base.deliveries.last
2364 2364 assert mail.body.include?('testfile.txt')
2365 2365 end
2366 2366
2367 2367 def test_put_update_with_failure_should_save_attachments
2368 2368 set_tmp_attachments_directory
2369 2369 @request.session[:user_id] = 2
2370 2370
2371 2371 assert_no_difference 'Journal.count' do
2372 2372 assert_difference 'Attachment.count' do
2373 2373 put :update, :id => 1,
2374 2374 :issue => { :subject => '' },
2375 2375 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2376 2376 assert_response :success
2377 2377 assert_template 'edit'
2378 2378 end
2379 2379 end
2380 2380
2381 2381 attachment = Attachment.first(:order => 'id DESC')
2382 2382 assert_equal 'testfile.txt', attachment.filename
2383 2383 assert File.exists?(attachment.diskfile)
2384 2384 assert_nil attachment.container
2385 2385
2386 2386 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2387 2387 assert_tag 'span', :content => /testfile.txt/
2388 2388 end
2389 2389
2390 2390 def test_put_update_with_failure_should_keep_saved_attachments
2391 2391 set_tmp_attachments_directory
2392 2392 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2393 2393 @request.session[:user_id] = 2
2394 2394
2395 2395 assert_no_difference 'Journal.count' do
2396 2396 assert_no_difference 'Attachment.count' do
2397 2397 put :update, :id => 1,
2398 2398 :issue => { :subject => '' },
2399 2399 :attachments => {'p0' => {'token' => attachment.token}}
2400 2400 assert_response :success
2401 2401 assert_template 'edit'
2402 2402 end
2403 2403 end
2404 2404
2405 2405 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2406 2406 assert_tag 'span', :content => /testfile.txt/
2407 2407 end
2408 2408
2409 2409 def test_put_update_should_attach_saved_attachments
2410 2410 set_tmp_attachments_directory
2411 2411 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2412 2412 @request.session[:user_id] = 2
2413 2413
2414 2414 assert_difference 'Journal.count' do
2415 2415 assert_difference 'JournalDetail.count' do
2416 2416 assert_no_difference 'Attachment.count' do
2417 2417 put :update, :id => 1,
2418 2418 :notes => 'Attachment added',
2419 2419 :attachments => {'p0' => {'token' => attachment.token}}
2420 2420 assert_redirected_to '/issues/1'
2421 2421 end
2422 2422 end
2423 2423 end
2424 2424
2425 2425 attachment.reload
2426 2426 assert_equal Issue.find(1), attachment.container
2427 2427
2428 2428 journal = Journal.first(:order => 'id DESC')
2429 2429 assert_equal 1, journal.details.size
2430 2430 assert_equal 'testfile.txt', journal.details.first.value
2431 2431 end
2432 2432
2433 2433 def test_put_update_with_attachment_that_fails_to_save
2434 2434 set_tmp_attachments_directory
2435 2435
2436 2436 # Delete all fixtured journals, a race condition can occur causing the wrong
2437 2437 # journal to get fetched in the next find.
2438 2438 Journal.delete_all
2439 2439
2440 2440 # Mock out the unsaved attachment
2441 2441 Attachment.any_instance.stubs(:create).returns(Attachment.new)
2442 2442
2443 2443 # anonymous user
2444 2444 put :update,
2445 2445 :id => 1,
2446 2446 :notes => '',
2447 2447 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
2448 2448 assert_redirected_to :action => 'show', :id => '1'
2449 2449 assert_equal '1 file(s) could not be saved.', flash[:warning]
2450 2450 end
2451 2451
2452 2452 def test_put_update_with_no_change
2453 2453 issue = Issue.find(1)
2454 2454 issue.journals.clear
2455 2455 ActionMailer::Base.deliveries.clear
2456 2456
2457 2457 put :update,
2458 2458 :id => 1,
2459 2459 :notes => ''
2460 2460 assert_redirected_to :action => 'show', :id => '1'
2461 2461
2462 2462 issue.reload
2463 2463 assert issue.journals.empty?
2464 2464 # No email should be sent
2465 2465 assert ActionMailer::Base.deliveries.empty?
2466 2466 end
2467 2467
2468 2468 def test_put_update_should_send_a_notification
2469 2469 @request.session[:user_id] = 2
2470 2470 ActionMailer::Base.deliveries.clear
2471 2471 issue = Issue.find(1)
2472 2472 old_subject = issue.subject
2473 2473 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2474 2474
2475 2475 put :update, :id => 1, :issue => {:subject => new_subject,
2476 2476 :priority_id => '6',
2477 2477 :category_id => '1' # no change
2478 2478 }
2479 2479 assert_equal 1, ActionMailer::Base.deliveries.size
2480 2480 end
2481 2481
2482 2482 def test_put_update_with_invalid_spent_time_hours_only
2483 2483 @request.session[:user_id] = 2
2484 2484 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
2485 2485
2486 2486 assert_no_difference('Journal.count') do
2487 2487 put :update,
2488 2488 :id => 1,
2489 2489 :notes => notes,
2490 2490 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
2491 2491 end
2492 2492 assert_response :success
2493 2493 assert_template 'edit'
2494 2494
2495 2495 assert_error_tag :descendant => {:content => /Activity can't be blank/}
2496 2496 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
2497 2497 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
2498 2498 end
2499 2499
2500 2500 def test_put_update_with_invalid_spent_time_comments_only
2501 2501 @request.session[:user_id] = 2
2502 2502 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
2503 2503
2504 2504 assert_no_difference('Journal.count') do
2505 2505 put :update,
2506 2506 :id => 1,
2507 2507 :notes => notes,
2508 2508 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
2509 2509 end
2510 2510 assert_response :success
2511 2511 assert_template 'edit'
2512 2512
2513 2513 assert_error_tag :descendant => {:content => /Activity can't be blank/}
2514 2514 assert_error_tag :descendant => {:content => /Hours can't be blank/}
2515 2515 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes
2516 2516 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
2517 2517 end
2518 2518
2519 2519 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
2520 2520 issue = Issue.find(2)
2521 2521 @request.session[:user_id] = 2
2522 2522
2523 2523 put :update,
2524 2524 :id => issue.id,
2525 2525 :issue => {
2526 2526 :fixed_version_id => 4
2527 2527 }
2528 2528
2529 2529 assert_response :redirect
2530 2530 issue.reload
2531 2531 assert_equal 4, issue.fixed_version_id
2532 2532 assert_not_equal issue.project_id, issue.fixed_version.project_id
2533 2533 end
2534 2534
2535 2535 def test_put_update_should_redirect_back_using_the_back_url_parameter
2536 2536 issue = Issue.find(2)
2537 2537 @request.session[:user_id] = 2
2538 2538
2539 2539 put :update,
2540 2540 :id => issue.id,
2541 2541 :issue => {
2542 2542 :fixed_version_id => 4
2543 2543 },
2544 2544 :back_url => '/issues'
2545 2545
2546 2546 assert_response :redirect
2547 2547 assert_redirected_to '/issues'
2548 2548 end
2549 2549
2550 2550 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
2551 2551 issue = Issue.find(2)
2552 2552 @request.session[:user_id] = 2
2553 2553
2554 2554 put :update,
2555 2555 :id => issue.id,
2556 2556 :issue => {
2557 2557 :fixed_version_id => 4
2558 2558 },
2559 2559 :back_url => 'http://google.com'
2560 2560
2561 2561 assert_response :redirect
2562 2562 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
2563 2563 end
2564 2564
2565 2565 def test_get_bulk_edit
2566 2566 @request.session[:user_id] = 2
2567 2567 get :bulk_edit, :ids => [1, 2]
2568 2568 assert_response :success
2569 2569 assert_template 'bulk_edit'
2570 2570
2571 2571 assert_tag :select, :attributes => {:name => 'issue[project_id]'}
2572 2572 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2573 2573
2574 2574 # Project specific custom field, date type
2575 2575 field = CustomField.find(9)
2576 2576 assert !field.is_for_all?
2577 2577 assert_equal 'date', field.field_format
2578 2578 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2579 2579
2580 2580 # System wide custom field
2581 2581 assert CustomField.find(1).is_for_all?
2582 2582 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
2583 2583
2584 2584 # Be sure we don't display inactive IssuePriorities
2585 2585 assert ! IssuePriority.find(15).active?
2586 2586 assert_no_tag :option, :attributes => {:value => '15'},
2587 2587 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2588 2588 end
2589 2589
2590 2590 def test_get_bulk_edit_on_different_projects
2591 2591 @request.session[:user_id] = 2
2592 2592 get :bulk_edit, :ids => [1, 2, 6]
2593 2593 assert_response :success
2594 2594 assert_template 'bulk_edit'
2595 2595
2596 2596 # Can not set issues from different projects as children of an issue
2597 2597 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2598 2598
2599 2599 # Project specific custom field, date type
2600 2600 field = CustomField.find(9)
2601 2601 assert !field.is_for_all?
2602 2602 assert !field.project_ids.include?(Issue.find(6).project_id)
2603 2603 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2604 2604 end
2605 2605
2606 2606 def test_get_bulk_edit_with_user_custom_field
2607 2607 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
2608 2608
2609 2609 @request.session[:user_id] = 2
2610 2610 get :bulk_edit, :ids => [1, 2]
2611 2611 assert_response :success
2612 2612 assert_template 'bulk_edit'
2613 2613
2614 2614 assert_tag :select,
2615 2615 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
2616 2616 :children => {
2617 2617 :only => {:tag => 'option'},
2618 2618 :count => Project.find(1).users.count + 1
2619 2619 }
2620 2620 end
2621 2621
2622 2622 def test_get_bulk_edit_with_version_custom_field
2623 2623 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
2624 2624
2625 2625 @request.session[:user_id] = 2
2626 2626 get :bulk_edit, :ids => [1, 2]
2627 2627 assert_response :success
2628 2628 assert_template 'bulk_edit'
2629 2629
2630 2630 assert_tag :select,
2631 2631 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
2632 2632 :children => {
2633 2633 :only => {:tag => 'option'},
2634 2634 :count => Project.find(1).shared_versions.count + 1
2635 2635 }
2636 2636 end
2637 2637
2638 2638 def test_get_bulk_edit_with_multi_custom_field
2639 2639 field = CustomField.find(1)
2640 2640 field.update_attribute :multiple, true
2641 2641
2642 2642 @request.session[:user_id] = 2
2643 2643 get :bulk_edit, :ids => [1, 2]
2644 2644 assert_response :success
2645 2645 assert_template 'bulk_edit'
2646 2646
2647 2647 assert_tag :select,
2648 2648 :attributes => {:name => "issue[custom_field_values][1][]"},
2649 2649 :children => {
2650 2650 :only => {:tag => 'option'},
2651 2651 :count => 3
2652 2652 }
2653 2653 end
2654 2654
2655 2655 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
2656 2656 Workflow.delete_all
2657 2657 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
2658 2658 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2659 2659 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2660 2660 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2661 2661 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
2662 2662 Workflow.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2663 2663 @request.session[:user_id] = 2
2664 2664 get :bulk_edit, :ids => [1, 2]
2665 2665
2666 2666 assert_response :success
2667 2667 statuses = assigns(:available_statuses)
2668 2668 assert_not_nil statuses
2669 2669 assert_equal [1, 3], statuses.map(&:id).sort
2670 2670
2671 2671 assert_tag 'select', :attributes => {:name => 'issue[status_id]'},
2672 2672 :children => {:count => 3} # 2 statuses + "no change" option
2673 2673 end
2674 2674
2675 2675 def test_bulk_update
2676 2676 @request.session[:user_id] = 2
2677 2677 # update issues priority
2678 2678 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
2679 2679 :issue => {:priority_id => 7,
2680 2680 :assigned_to_id => '',
2681 2681 :custom_field_values => {'2' => ''}}
2682 2682
2683 2683 assert_response 302
2684 2684 # check that the issues were updated
2685 2685 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
2686 2686
2687 2687 issue = Issue.find(1)
2688 2688 journal = issue.journals.find(:first, :order => 'created_on DESC')
2689 2689 assert_equal '125', issue.custom_value_for(2).value
2690 2690 assert_equal 'Bulk editing', journal.notes
2691 2691 assert_equal 1, journal.details.size
2692 2692 end
2693 2693
2694 2694 def test_bulk_update_with_group_assignee
2695 2695 group = Group.find(11)
2696 2696 project = Project.find(1)
2697 2697 project.members << Member.new(:principal => group, :roles => [Role.first])
2698 2698
2699 2699 @request.session[:user_id] = 2
2700 2700 # update issues assignee
2701 2701 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
2702 2702 :issue => {:priority_id => '',
2703 2703 :assigned_to_id => group.id,
2704 2704 :custom_field_values => {'2' => ''}}
2705 2705
2706 2706 assert_response 302
2707 2707 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
2708 2708 end
2709 2709
2710 2710 def test_bulk_update_on_different_projects
2711 2711 @request.session[:user_id] = 2
2712 2712 # update issues priority
2713 2713 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
2714 2714 :issue => {:priority_id => 7,
2715 2715 :assigned_to_id => '',
2716 2716 :custom_field_values => {'2' => ''}}
2717 2717
2718 2718 assert_response 302
2719 2719 # check that the issues were updated
2720 2720 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
2721 2721
2722 2722 issue = Issue.find(1)
2723 2723 journal = issue.journals.find(:first, :order => 'created_on DESC')
2724 2724 assert_equal '125', issue.custom_value_for(2).value
2725 2725 assert_equal 'Bulk editing', journal.notes
2726 2726 assert_equal 1, journal.details.size
2727 2727 end
2728 2728
2729 2729 def test_bulk_update_on_different_projects_without_rights
2730 2730 @request.session[:user_id] = 3
2731 2731 user = User.find(3)
2732 2732 action = { :controller => "issues", :action => "bulk_update" }
2733 2733 assert user.allowed_to?(action, Issue.find(1).project)
2734 2734 assert ! user.allowed_to?(action, Issue.find(6).project)
2735 2735 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
2736 2736 :issue => {:priority_id => 7,
2737 2737 :assigned_to_id => '',
2738 2738 :custom_field_values => {'2' => ''}}
2739 2739 assert_response 403
2740 2740 assert_not_equal "Bulk should fail", Journal.last.notes
2741 2741 end
2742 2742
2743 2743 def test_bullk_update_should_send_a_notification
2744 2744 @request.session[:user_id] = 2
2745 2745 ActionMailer::Base.deliveries.clear
2746 2746 post(:bulk_update,
2747 2747 {
2748 2748 :ids => [1, 2],
2749 2749 :notes => 'Bulk editing',
2750 2750 :issue => {
2751 2751 :priority_id => 7,
2752 2752 :assigned_to_id => '',
2753 2753 :custom_field_values => {'2' => ''}
2754 2754 }
2755 2755 })
2756 2756
2757 2757 assert_response 302
2758 2758 assert_equal 2, ActionMailer::Base.deliveries.size
2759 2759 end
2760 2760
2761 2761 def test_bulk_update_project
2762 2762 @request.session[:user_id] = 2
2763 2763 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
2764 2764 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2765 2765 # Issues moved to project 2
2766 2766 assert_equal 2, Issue.find(1).project_id
2767 2767 assert_equal 2, Issue.find(2).project_id
2768 2768 # No tracker change
2769 2769 assert_equal 1, Issue.find(1).tracker_id
2770 2770 assert_equal 2, Issue.find(2).tracker_id
2771 2771 end
2772 2772
2773 2773 def test_bulk_update_project_on_single_issue_should_follow_when_needed
2774 2774 @request.session[:user_id] = 2
2775 2775 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
2776 2776 assert_redirected_to '/issues/1'
2777 2777 end
2778 2778
2779 2779 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
2780 2780 @request.session[:user_id] = 2
2781 2781 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
2782 2782 assert_redirected_to '/projects/onlinestore/issues'
2783 2783 end
2784 2784
2785 2785 def test_bulk_update_tracker
2786 2786 @request.session[:user_id] = 2
2787 2787 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
2788 2788 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2789 2789 assert_equal 2, Issue.find(1).tracker_id
2790 2790 assert_equal 2, Issue.find(2).tracker_id
2791 2791 end
2792 2792
2793 2793 def test_bulk_update_status
2794 2794 @request.session[:user_id] = 2
2795 2795 # update issues priority
2796 2796 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
2797 2797 :issue => {:priority_id => '',
2798 2798 :assigned_to_id => '',
2799 2799 :status_id => '5'}
2800 2800
2801 2801 assert_response 302
2802 2802 issue = Issue.find(1)
2803 2803 assert issue.closed?
2804 2804 end
2805 2805
2806 2806 def test_bulk_update_priority
2807 2807 @request.session[:user_id] = 2
2808 2808 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
2809 2809
2810 2810 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2811 2811 assert_equal 6, Issue.find(1).priority_id
2812 2812 assert_equal 6, Issue.find(2).priority_id
2813 2813 end
2814 2814
2815 2815 def test_bulk_update_with_notes
2816 2816 @request.session[:user_id] = 2
2817 2817 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
2818 2818
2819 2819 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
2820 2820 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
2821 2821 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
2822 2822 end
2823 2823
2824 2824 def test_bulk_update_parent_id
2825 2825 @request.session[:user_id] = 2
2826 2826 post :bulk_update, :ids => [1, 3],
2827 2827 :notes => 'Bulk editing parent',
2828 2828 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
2829 2829
2830 2830 assert_response 302
2831 2831 parent = Issue.find(2)
2832 2832 assert_equal parent.id, Issue.find(1).parent_id
2833 2833 assert_equal parent.id, Issue.find(3).parent_id
2834 2834 assert_equal [1, 3], parent.children.collect(&:id).sort
2835 2835 end
2836 2836
2837 2837 def test_bulk_update_custom_field
2838 2838 @request.session[:user_id] = 2
2839 2839 # update issues priority
2840 2840 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
2841 2841 :issue => {:priority_id => '',
2842 2842 :assigned_to_id => '',
2843 2843 :custom_field_values => {'2' => '777'}}
2844 2844
2845 2845 assert_response 302
2846 2846
2847 2847 issue = Issue.find(1)
2848 2848 journal = issue.journals.find(:first, :order => 'created_on DESC')
2849 2849 assert_equal '777', issue.custom_value_for(2).value
2850 2850 assert_equal 1, journal.details.size
2851 2851 assert_equal '125', journal.details.first.old_value
2852 2852 assert_equal '777', journal.details.first.value
2853 2853 end
2854 2854
2855 2855 def test_bulk_update_multi_custom_field
2856 2856 field = CustomField.find(1)
2857 2857 field.update_attribute :multiple, true
2858 2858
2859 2859 @request.session[:user_id] = 2
2860 2860 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
2861 2861 :issue => {:priority_id => '',
2862 2862 :assigned_to_id => '',
2863 2863 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
2864 2864
2865 2865 assert_response 302
2866 2866
2867 2867 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
2868 2868 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
2869 2869 # the custom field is not associated with the issue tracker
2870 2870 assert_nil Issue.find(2).custom_field_value(1)
2871 2871 end
2872 2872
2873 2873 def test_bulk_update_unassign
2874 2874 assert_not_nil Issue.find(2).assigned_to
2875 2875 @request.session[:user_id] = 2
2876 2876 # unassign issues
2877 2877 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
2878 2878 assert_response 302
2879 2879 # check that the issues were updated
2880 2880 assert_nil Issue.find(2).assigned_to
2881 2881 end
2882 2882
2883 2883 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
2884 2884 @request.session[:user_id] = 2
2885 2885
2886 2886 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
2887 2887
2888 2888 assert_response :redirect
2889 2889 issues = Issue.find([1,2])
2890 2890 issues.each do |issue|
2891 2891 assert_equal 4, issue.fixed_version_id
2892 2892 assert_not_equal issue.project_id, issue.fixed_version.project_id
2893 2893 end
2894 2894 end
2895 2895
2896 2896 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
2897 2897 @request.session[:user_id] = 2
2898 2898 post :bulk_update, :ids => [1,2], :back_url => '/issues'
2899 2899
2900 2900 assert_response :redirect
2901 2901 assert_redirected_to '/issues'
2902 2902 end
2903 2903
2904 2904 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
2905 2905 @request.session[:user_id] = 2
2906 2906 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
2907 2907
2908 2908 assert_response :redirect
2909 2909 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
2910 2910 end
2911 2911
2912 2912 def test_bulk_copy_to_another_project
2913 2913 @request.session[:user_id] = 2
2914 2914 assert_difference 'Issue.count', 2 do
2915 2915 assert_no_difference 'Project.find(1).issues.count' do
2916 2916 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
2917 2917 end
2918 2918 end
2919 2919 assert_redirected_to '/projects/ecookbook/issues'
2920 2920 end
2921 2921
2922 2922 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
2923 2923 @request.session[:user_id] = 2
2924 2924 issue_before_move = Issue.find(1)
2925 2925 assert_difference 'Issue.count', 1 do
2926 2926 assert_no_difference 'Project.find(1).issues.count' do
2927 2927 post :bulk_update, :ids => [1], :copy => '1',
2928 2928 :issue => {
2929 2929 :project_id => '2', :tracker_id => '', :assigned_to_id => '',
2930 2930 :status_id => '', :start_date => '', :due_date => ''
2931 2931 }
2932 2932 end
2933 2933 end
2934 2934 issue_after_move = Issue.first(:order => 'id desc', :conditions => {:project_id => 2})
2935 2935 assert_equal issue_before_move.tracker_id, issue_after_move.tracker_id
2936 2936 assert_equal issue_before_move.status_id, issue_after_move.status_id
2937 2937 assert_equal issue_before_move.assigned_to_id, issue_after_move.assigned_to_id
2938 2938 end
2939 2939
2940 2940 def test_bulk_copy_should_allow_changing_the_issue_attributes
2941 2941 # Fixes random test failure with Mysql
2942 2942 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
2943 2943 # doesn't return the expected results
2944 2944 Issue.delete_all("project_id=2")
2945 2945
2946 2946 @request.session[:user_id] = 2
2947 2947 assert_difference 'Issue.count', 2 do
2948 2948 assert_no_difference 'Project.find(1).issues.count' do
2949 2949 post :bulk_update, :ids => [1, 2], :copy => '1',
2950 2950 :issue => {
2951 2951 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
2952 2952 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
2953 2953 }
2954 2954 end
2955 2955 end
2956 2956
2957 2957 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
2958 2958 assert_equal 2, copied_issues.size
2959 2959 copied_issues.each do |issue|
2960 2960 assert_equal 2, issue.project_id, "Project is incorrect"
2961 2961 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
2962 2962 assert_equal 3, issue.status_id, "Status is incorrect"
2963 2963 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
2964 2964 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
2965 2965 end
2966 2966 end
2967 2967
2968 2968 def test_bulk_copy_should_allow_adding_a_note
2969 2969 @request.session[:user_id] = 2
2970 2970 assert_difference 'Issue.count', 1 do
2971 2971 post :bulk_update, :ids => [1], :copy => '1',
2972 2972 :notes => 'Copying one issue',
2973 2973 :issue => {
2974 2974 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
2975 2975 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
2976 2976 }
2977 2977 end
2978 2978
2979 2979 issue = Issue.first(:order => 'id DESC')
2980 2980 assert_equal 1, issue.journals.size
2981 2981 journal = issue.journals.first
2982 2982 assert_equal 0, journal.details.size
2983 2983 assert_equal 'Copying one issue', journal.notes
2984 2984 end
2985 2985
2986 2986 def test_bulk_copy_to_another_project_should_follow_when_needed
2987 2987 @request.session[:user_id] = 2
2988 2988 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
2989 2989 issue = Issue.first(:order => 'id DESC')
2990 2990 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
2991 2991 end
2992 2992
2993 2993 def test_destroy_issue_with_no_time_entries
2994 2994 assert_nil TimeEntry.find_by_issue_id(2)
2995 2995 @request.session[:user_id] = 2
2996 2996
2997 2997 assert_difference 'Issue.count', -1 do
2998 2998 delete :destroy, :id => 2
2999 2999 end
3000 3000 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3001 3001 assert_nil Issue.find_by_id(2)
3002 3002 end
3003 3003
3004 3004 def test_destroy_issues_with_time_entries
3005 3005 @request.session[:user_id] = 2
3006 3006
3007 3007 assert_no_difference 'Issue.count' do
3008 3008 delete :destroy, :ids => [1, 3]
3009 3009 end
3010 3010 assert_response :success
3011 3011 assert_template 'destroy'
3012 3012 assert_not_nil assigns(:hours)
3013 3013 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3014 3014 assert_tag 'form',
3015 3015 :descendant => {:tag => 'input', :attributes => {:name => '_method', :value => 'delete'}}
3016 3016 end
3017 3017
3018 3018 def test_destroy_issues_and_destroy_time_entries
3019 3019 @request.session[:user_id] = 2
3020 3020
3021 3021 assert_difference 'Issue.count', -2 do
3022 3022 assert_difference 'TimeEntry.count', -3 do
3023 3023 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3024 3024 end
3025 3025 end
3026 3026 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3027 3027 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3028 3028 assert_nil TimeEntry.find_by_id([1, 2])
3029 3029 end
3030 3030
3031 3031 def test_destroy_issues_and_assign_time_entries_to_project
3032 3032 @request.session[:user_id] = 2
3033 3033
3034 3034 assert_difference 'Issue.count', -2 do
3035 3035 assert_no_difference 'TimeEntry.count' do
3036 3036 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3037 3037 end
3038 3038 end
3039 3039 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3040 3040 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3041 3041 assert_nil TimeEntry.find(1).issue_id
3042 3042 assert_nil TimeEntry.find(2).issue_id
3043 3043 end
3044 3044
3045 3045 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3046 3046 @request.session[:user_id] = 2
3047 3047
3048 3048 assert_difference 'Issue.count', -2 do
3049 3049 assert_no_difference 'TimeEntry.count' do
3050 3050 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3051 3051 end
3052 3052 end
3053 3053 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3054 3054 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3055 3055 assert_equal 2, TimeEntry.find(1).issue_id
3056 3056 assert_equal 2, TimeEntry.find(2).issue_id
3057 3057 end
3058 3058
3059 3059 def test_destroy_issues_from_different_projects
3060 3060 @request.session[:user_id] = 2
3061 3061
3062 3062 assert_difference 'Issue.count', -3 do
3063 3063 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3064 3064 end
3065 3065 assert_redirected_to :controller => 'issues', :action => 'index'
3066 3066 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3067 3067 end
3068 3068
3069 3069 def test_destroy_parent_and_child_issues
3070 3070 parent = Issue.generate!(:project_id => 1, :tracker_id => 1)
3071 3071 child = Issue.generate!(:project_id => 1, :tracker_id => 1, :parent_issue_id => parent.id)
3072 3072 assert child.is_descendant_of?(parent.reload)
3073 3073
3074 3074 @request.session[:user_id] = 2
3075 3075 assert_difference 'Issue.count', -2 do
3076 3076 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3077 3077 end
3078 3078 assert_response 302
3079 3079 end
3080 3080
3081 3081 def test_default_search_scope
3082 3082 get :index
3083 3083 assert_tag :div, :attributes => {:id => 'quick-search'},
3084 3084 :child => {:tag => 'form',
3085 3085 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
3086 3086 end
3087 3087 end
@@ -1,155 +1,155
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'messages_controller'
20 20
21 21 # Re-raise errors caught by the controller.
22 22 class MessagesController; def rescue_action(e) raise e end; end
23 23
24 24 class MessagesControllerTest < ActionController::TestCase
25 25 fixtures :projects, :users, :members, :member_roles, :roles, :boards, :messages, :enabled_modules
26 26
27 27 def setup
28 28 @controller = MessagesController.new
29 29 @request = ActionController::TestRequest.new
30 30 @response = ActionController::TestResponse.new
31 31 User.current = nil
32 32 end
33 33
34 34 def test_show
35 35 get :show, :board_id => 1, :id => 1
36 36 assert_response :success
37 37 assert_template 'show'
38 38 assert_not_nil assigns(:board)
39 39 assert_not_nil assigns(:project)
40 40 assert_not_nil assigns(:topic)
41 41 end
42 42
43 43 def test_show_should_contain_reply_field_tags_for_quoting
44 44 @request.session[:user_id] = 2
45 45 get :show, :board_id => 1, :id => 1
46 46 assert_response :success
47 47
48 48 # tags required by MessagesController#quote
49 49 assert_tag 'input', :attributes => {:id => 'message_subject'}
50 50 assert_tag 'textarea', :attributes => {:id => 'message_content'}
51 51 assert_tag 'div', :attributes => {:id => 'reply'}
52 52 end
53 53
54 54 def test_show_with_pagination
55 55 message = Message.find(1)
56 56 assert_difference 'Message.count', 30 do
57 57 30.times do
58 58 message.children << Message.new(:subject => 'Reply', :content => 'Reply body', :author_id => 2, :board_id => 1)
59 59 end
60 60 end
61 61 get :show, :board_id => 1, :id => 1, :r => message.children.last(:order => 'id').id
62 62 assert_response :success
63 63 assert_template 'show'
64 64 replies = assigns(:replies)
65 65 assert_not_nil replies
66 66 assert !replies.include?(message.children.first(:order => 'id'))
67 67 assert replies.include?(message.children.last(:order => 'id'))
68 68 end
69 69
70 70 def test_show_with_reply_permission
71 71 @request.session[:user_id] = 2
72 72 get :show, :board_id => 1, :id => 1
73 73 assert_response :success
74 74 assert_template 'show'
75 75 assert_tag :div, :attributes => { :id => 'reply' },
76 76 :descendant => { :tag => 'textarea', :attributes => { :id => 'message_content' } }
77 77 end
78 78
79 79 def test_show_message_not_found
80 80 get :show, :board_id => 1, :id => 99999
81 81 assert_response 404
82 82 end
83 83
84 84 def test_get_new
85 85 @request.session[:user_id] = 2
86 86 get :new, :board_id => 1
87 87 assert_response :success
88 88 assert_template 'new'
89 89 end
90 90
91 91 def test_post_new
92 92 @request.session[:user_id] = 2
93 93 ActionMailer::Base.deliveries.clear
94 94 Setting.notified_events = ['message_posted']
95 95
96 96 post :new, :board_id => 1,
97 97 :message => { :subject => 'Test created message',
98 98 :content => 'Message body'}
99 99 message = Message.find_by_subject('Test created message')
100 100 assert_not_nil message
101 101 assert_redirected_to "/boards/1/topics/#{message.to_param}"
102 102 assert_equal 'Message body', message.content
103 103 assert_equal 2, message.author_id
104 104 assert_equal 1, message.board_id
105 105
106 106 mail = ActionMailer::Base.deliveries.last
107 assert_kind_of TMail::Mail, mail
107 assert_not_nil mail
108 108 assert_equal "[#{message.board.project.name} - #{message.board.name} - msg#{message.root.id}] Test created message", mail.subject
109 109 assert mail.body.include?('Message body')
110 110 # author
111 111 assert mail.bcc.include?('jsmith@somenet.foo')
112 112 # project member
113 113 assert mail.bcc.include?('dlopper@somenet.foo')
114 114 end
115 115
116 116 def test_get_edit
117 117 @request.session[:user_id] = 2
118 118 get :edit, :board_id => 1, :id => 1
119 119 assert_response :success
120 120 assert_template 'edit'
121 121 end
122 122
123 123 def test_post_edit
124 124 @request.session[:user_id] = 2
125 125 post :edit, :board_id => 1, :id => 1,
126 126 :message => { :subject => 'New subject',
127 127 :content => 'New body'}
128 128 assert_redirected_to '/boards/1/topics/1'
129 129 message = Message.find(1)
130 130 assert_equal 'New subject', message.subject
131 131 assert_equal 'New body', message.content
132 132 end
133 133
134 134 def test_reply
135 135 @request.session[:user_id] = 2
136 136 post :reply, :board_id => 1, :id => 1, :reply => { :content => 'This is a test reply', :subject => 'Test reply' }
137 137 reply = Message.find(:first, :order => 'id DESC')
138 138 assert_redirected_to "/boards/1/topics/1?r=#{reply.id}"
139 139 assert Message.find_by_subject('Test reply')
140 140 end
141 141
142 142 def test_destroy_topic
143 143 @request.session[:user_id] = 2
144 144 post :destroy, :board_id => 1, :id => 1
145 145 assert_redirected_to '/projects/ecookbook/boards/1'
146 146 assert_nil Message.find_by_id(1)
147 147 end
148 148
149 149 def test_quote
150 150 @request.session[:user_id] = 2
151 151 xhr :get, :quote, :board_id => 1, :id => 3
152 152 assert_response :success
153 153 assert_select_rjs :show, 'reply'
154 154 end
155 155 end
@@ -1,526 +1,526
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class MailerTest < ActiveSupport::TestCase
21 21 include Redmine::I18n
22 22 include ActionController::Assertions::SelectorAssertions
23 23 fixtures :projects, :enabled_modules, :issues, :users, :members,
24 24 :member_roles, :roles, :documents, :attachments, :news,
25 25 :tokens, :journals, :journal_details, :changesets, :trackers,
26 26 :issue_statuses, :enumerations, :messages, :boards, :repositories,
27 27 :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions,
28 28 :versions,
29 29 :comments
30 30
31 31 def setup
32 32 ActionMailer::Base.deliveries.clear
33 33 Setting.host_name = 'mydomain.foo'
34 34 Setting.protocol = 'http'
35 35 Setting.plain_text_mail = '0'
36 36 end
37 37
38 38 def test_generated_links_in_emails
39 39 Setting.host_name = 'mydomain.foo'
40 40 Setting.protocol = 'https'
41 41
42 42 journal = Journal.find(2)
43 43 assert Mailer.deliver_issue_edit(journal)
44 44
45 45 mail = ActionMailer::Base.deliveries.last
46 assert_kind_of TMail::Mail, mail
46 assert_not_nil mail
47 47
48 48 assert_select_email do
49 49 # link to the main ticket
50 50 assert_select "a[href=?]",
51 51 "https://mydomain.foo/issues/1#change-2",
52 52 :text => "Bug #1: Can't print recipes"
53 53 # link to a referenced ticket
54 54 assert_select "a[href=?][title=?]",
55 55 "https://mydomain.foo/issues/2",
56 56 "Add ingredients categories (Assigned)",
57 57 :text => "#2"
58 58 # link to a changeset
59 59 assert_select "a[href=?][title=?]",
60 60 "https://mydomain.foo/projects/ecookbook/repository/revisions/2",
61 61 "This commit fixes #1, #2 and references #1 &amp; #3",
62 62 :text => "r2"
63 63 end
64 64 end
65 65
66 66 def test_generated_links_with_prefix
67 67 relative_url_root = Redmine::Utils.relative_url_root
68 68 Setting.host_name = 'mydomain.foo/rdm'
69 69 Setting.protocol = 'http'
70 70 Redmine::Utils.relative_url_root = '/rdm'
71 71
72 72 journal = Journal.find(2)
73 73 assert Mailer.deliver_issue_edit(journal)
74 74
75 75 mail = ActionMailer::Base.deliveries.last
76 assert_kind_of TMail::Mail, mail
76 assert_not_nil mail
77 77
78 78 assert_select_email do
79 79 # link to the main ticket
80 80 assert_select "a[href=?]",
81 81 "http://mydomain.foo/rdm/issues/1#change-2",
82 82 :text => "Bug #1: Can't print recipes"
83 83 # link to a referenced ticket
84 84 assert_select "a[href=?][title=?]",
85 85 "http://mydomain.foo/rdm/issues/2",
86 86 "Add ingredients categories (Assigned)",
87 87 :text => "#2"
88 88 # link to a changeset
89 89 assert_select "a[href=?][title=?]",
90 90 "http://mydomain.foo/rdm/projects/ecookbook/repository/revisions/2",
91 91 "This commit fixes #1, #2 and references #1 &amp; #3",
92 92 :text => "r2"
93 93 end
94 94 ensure
95 95 # restore it
96 96 Redmine::Utils.relative_url_root = relative_url_root
97 97 end
98 98
99 99 def test_generated_links_with_prefix_and_no_relative_url_root
100 100 relative_url_root = Redmine::Utils.relative_url_root
101 101 Setting.host_name = 'mydomain.foo/rdm'
102 102 Setting.protocol = 'http'
103 103 Redmine::Utils.relative_url_root = nil
104 104
105 105 journal = Journal.find(2)
106 106 assert Mailer.deliver_issue_edit(journal)
107 107
108 108 mail = ActionMailer::Base.deliveries.last
109 assert_kind_of TMail::Mail, mail
109 assert_not_nil mail
110 110
111 111 assert_select_email do
112 112 # link to the main ticket
113 113 assert_select "a[href=?]",
114 114 "http://mydomain.foo/rdm/issues/1#change-2",
115 115 :text => "Bug #1: Can't print recipes"
116 116 # link to a referenced ticket
117 117 assert_select "a[href=?][title=?]",
118 118 "http://mydomain.foo/rdm/issues/2",
119 119 "Add ingredients categories (Assigned)",
120 120 :text => "#2"
121 121 # link to a changeset
122 122 assert_select "a[href=?][title=?]",
123 123 "http://mydomain.foo/rdm/projects/ecookbook/repository/revisions/2",
124 124 "This commit fixes #1, #2 and references #1 &amp; #3",
125 125 :text => "r2"
126 126 end
127 127 ensure
128 128 # restore it
129 129 Redmine::Utils.relative_url_root = relative_url_root
130 130 end
131 131
132 132 def test_email_headers
133 133 issue = Issue.find(1)
134 134 Mailer.deliver_issue_add(issue)
135 135 mail = ActionMailer::Base.deliveries.last
136 136 assert_not_nil mail
137 137 assert_equal 'OOF', mail.header_string('X-Auto-Response-Suppress')
138 138 assert_equal 'auto-generated', mail.header_string('Auto-Submitted')
139 139 end
140 140
141 141 def test_email_headers_should_include_sender
142 142 issue = Issue.find(1)
143 143 Mailer.deliver_issue_add(issue)
144 144 mail = ActionMailer::Base.deliveries.last
145 145 assert_not_nil mail
146 146 assert_equal issue.author.login, mail.header_string('X-Redmine-Sender')
147 147 end
148 148
149 149 def test_plain_text_mail
150 150 Setting.plain_text_mail = 1
151 151 journal = Journal.find(2)
152 152 Mailer.deliver_issue_edit(journal)
153 153 mail = ActionMailer::Base.deliveries.last
154 154 assert_equal "text/plain", mail.content_type
155 155 assert_equal 0, mail.parts.size
156 156 assert !mail.encoded.include?('href')
157 157 end
158 158
159 159 def test_html_mail
160 160 Setting.plain_text_mail = 0
161 161 journal = Journal.find(2)
162 162 Mailer.deliver_issue_edit(journal)
163 163 mail = ActionMailer::Base.deliveries.last
164 164 assert_equal 2, mail.parts.size
165 165 assert mail.encoded.include?('href')
166 166 end
167 167
168 168 def test_from_header
169 169 with_settings :mail_from => 'redmine@example.net' do
170 170 Mailer.deliver_test(User.find(1))
171 171 end
172 172 mail = ActionMailer::Base.deliveries.last
173 173 assert_not_nil mail
174 174 assert_equal 'redmine@example.net', mail.from_addrs.first.address
175 175 end
176 176
177 177 def test_from_header_with_phrase
178 178 with_settings :mail_from => 'Redmine app <redmine@example.net>' do
179 179 Mailer.deliver_test(User.find(1))
180 180 end
181 181 mail = ActionMailer::Base.deliveries.last
182 182 assert_not_nil mail
183 183 assert_equal 'redmine@example.net', mail.from_addrs.first.address
184 184 assert_equal 'Redmine app', mail.from_addrs.first.name
185 185 end
186 186
187 187 def test_should_not_send_email_without_recipient
188 188 news = News.find(:first)
189 189 user = news.author
190 190 # Remove members except news author
191 191 news.project.memberships.each {|m| m.destroy unless m.user == user}
192 192
193 193 user.pref[:no_self_notified] = false
194 194 user.pref.save
195 195 User.current = user
196 196 Mailer.deliver_news_added(news.reload)
197 197 assert_equal 1, last_email.bcc.size
198 198
199 199 # nobody to notify
200 200 user.pref[:no_self_notified] = true
201 201 user.pref.save
202 202 User.current = user
203 203 ActionMailer::Base.deliveries.clear
204 204 Mailer.deliver_news_added(news.reload)
205 205 assert ActionMailer::Base.deliveries.empty?
206 206 end
207 207
208 208 def test_issue_add_message_id
209 209 issue = Issue.find(1)
210 210 Mailer.deliver_issue_add(issue)
211 211 mail = ActionMailer::Base.deliveries.last
212 212 assert_not_nil mail
213 213 assert_equal Mailer.message_id_for(issue), mail.message_id
214 214 assert_nil mail.references
215 215 end
216 216
217 217 def test_issue_edit_message_id
218 218 journal = Journal.find(1)
219 219 Mailer.deliver_issue_edit(journal)
220 220 mail = ActionMailer::Base.deliveries.last
221 221 assert_not_nil mail
222 222 assert_equal Mailer.message_id_for(journal), mail.message_id
223 223 assert_equal Mailer.message_id_for(journal.issue), mail.references.first.to_s
224 224 assert_select_email do
225 225 # link to the update
226 226 assert_select "a[href=?]",
227 227 "http://mydomain.foo/issues/#{journal.journalized_id}#change-#{journal.id}"
228 228 end
229 229 end
230 230
231 231 def test_message_posted_message_id
232 232 message = Message.find(1)
233 233 Mailer.deliver_message_posted(message)
234 234 mail = ActionMailer::Base.deliveries.last
235 235 assert_not_nil mail
236 236 assert_equal Mailer.message_id_for(message), mail.message_id
237 237 assert_nil mail.references
238 238 assert_select_email do
239 239 # link to the message
240 240 assert_select "a[href=?]",
241 241 "http://mydomain.foo/boards/#{message.board.id}/topics/#{message.id}",
242 242 :text => message.subject
243 243 end
244 244 end
245 245
246 246 def test_reply_posted_message_id
247 247 message = Message.find(3)
248 248 Mailer.deliver_message_posted(message)
249 249 mail = ActionMailer::Base.deliveries.last
250 250 assert_not_nil mail
251 251 assert_equal Mailer.message_id_for(message), mail.message_id
252 252 assert_equal Mailer.message_id_for(message.parent), mail.references.first.to_s
253 253 assert_select_email do
254 254 # link to the reply
255 255 assert_select "a[href=?]",
256 256 "http://mydomain.foo/boards/#{message.board.id}/topics/#{message.root.id}?r=#{message.id}#message-#{message.id}",
257 257 :text => message.subject
258 258 end
259 259 end
260 260
261 261 context("#issue_add") do
262 262 setup do
263 263 ActionMailer::Base.deliveries.clear
264 264 Setting.bcc_recipients = '1'
265 265 @issue = Issue.find(1)
266 266 end
267 267
268 268 should "notify project members" do
269 269 assert Mailer.deliver_issue_add(@issue)
270 270 assert last_email.bcc.include?('dlopper@somenet.foo')
271 271 end
272 272
273 273 should "not notify project members that are not allow to view the issue" do
274 274 Role.find(2).remove_permission!(:view_issues)
275 275 assert Mailer.deliver_issue_add(@issue)
276 276 assert !last_email.bcc.include?('dlopper@somenet.foo')
277 277 end
278 278
279 279 should "notify issue watchers" do
280 280 user = User.find(9)
281 281 # minimal email notification options
282 282 user.pref[:no_self_notified] = '1'
283 283 user.pref.save
284 284 user.mail_notification = false
285 285 user.save
286 286
287 287 Watcher.create!(:watchable => @issue, :user => user)
288 288 assert Mailer.deliver_issue_add(@issue)
289 289 assert last_email.bcc.include?(user.mail)
290 290 end
291 291
292 292 should "not notify watchers not allowed to view the issue" do
293 293 user = User.find(9)
294 294 Watcher.create!(:watchable => @issue, :user => user)
295 295 Role.non_member.remove_permission!(:view_issues)
296 296 assert Mailer.deliver_issue_add(@issue)
297 297 assert !last_email.bcc.include?(user.mail)
298 298 end
299 299 end
300 300
301 301 # test mailer methods for each language
302 302 def test_issue_add
303 303 issue = Issue.find(1)
304 304 valid_languages.each do |lang|
305 305 Setting.default_language = lang.to_s
306 306 assert Mailer.deliver_issue_add(issue)
307 307 end
308 308 end
309 309
310 310 def test_issue_edit
311 311 journal = Journal.find(1)
312 312 valid_languages.each do |lang|
313 313 Setting.default_language = lang.to_s
314 314 assert Mailer.deliver_issue_edit(journal)
315 315 end
316 316 end
317 317
318 318 def test_document_added
319 319 document = Document.find(1)
320 320 valid_languages.each do |lang|
321 321 Setting.default_language = lang.to_s
322 322 assert Mailer.deliver_document_added(document)
323 323 end
324 324 end
325 325
326 326 def test_attachments_added
327 327 attachements = [ Attachment.find_by_container_type('Document') ]
328 328 valid_languages.each do |lang|
329 329 Setting.default_language = lang.to_s
330 330 assert Mailer.deliver_attachments_added(attachements)
331 331 end
332 332 end
333 333
334 334 def test_version_file_added
335 335 attachements = [ Attachment.find_by_container_type('Version') ]
336 336 assert Mailer.deliver_attachments_added(attachements)
337 337 assert_not_nil last_email.bcc
338 338 assert last_email.bcc.any?
339 339 assert_select_email do
340 340 assert_select "a[href=?]", "http://mydomain.foo/projects/ecookbook/files"
341 341 end
342 342 end
343 343
344 344 def test_project_file_added
345 345 attachements = [ Attachment.find_by_container_type('Project') ]
346 346 assert Mailer.deliver_attachments_added(attachements)
347 347 assert_not_nil last_email.bcc
348 348 assert last_email.bcc.any?
349 349 assert_select_email do
350 350 assert_select "a[href=?]", "http://mydomain.foo/projects/ecookbook/files"
351 351 end
352 352 end
353 353
354 354 def test_news_added
355 355 news = News.find(:first)
356 356 valid_languages.each do |lang|
357 357 Setting.default_language = lang.to_s
358 358 assert Mailer.deliver_news_added(news)
359 359 end
360 360 end
361 361
362 362 def test_news_comment_added
363 363 comment = Comment.find(2)
364 364 valid_languages.each do |lang|
365 365 Setting.default_language = lang.to_s
366 366 assert Mailer.deliver_news_comment_added(comment)
367 367 end
368 368 end
369 369
370 370 def test_message_posted
371 371 message = Message.find(:first)
372 372 recipients = ([message.root] + message.root.children).collect {|m| m.author.mail if m.author}
373 373 recipients = recipients.compact.uniq
374 374 valid_languages.each do |lang|
375 375 Setting.default_language = lang.to_s
376 376 assert Mailer.deliver_message_posted(message)
377 377 end
378 378 end
379 379
380 380 def test_wiki_content_added
381 381 content = WikiContent.find(:first)
382 382 valid_languages.each do |lang|
383 383 Setting.default_language = lang.to_s
384 384 assert_difference 'ActionMailer::Base.deliveries.size' do
385 385 assert Mailer.deliver_wiki_content_added(content)
386 386 end
387 387 end
388 388 end
389 389
390 390 def test_wiki_content_updated
391 391 content = WikiContent.find(:first)
392 392 valid_languages.each do |lang|
393 393 Setting.default_language = lang.to_s
394 394 assert_difference 'ActionMailer::Base.deliveries.size' do
395 395 assert Mailer.deliver_wiki_content_updated(content)
396 396 end
397 397 end
398 398 end
399 399
400 400 def test_account_information
401 401 user = User.find(2)
402 402 valid_languages.each do |lang|
403 403 user.update_attribute :language, lang.to_s
404 404 user.reload
405 405 assert Mailer.deliver_account_information(user, 'pAsswORd')
406 406 end
407 407 end
408 408
409 409 def test_lost_password
410 410 token = Token.find(2)
411 411 valid_languages.each do |lang|
412 412 token.user.update_attribute :language, lang.to_s
413 413 token.reload
414 414 assert Mailer.deliver_lost_password(token)
415 415 end
416 416 end
417 417
418 418 def test_register
419 419 token = Token.find(1)
420 420 Setting.host_name = 'redmine.foo'
421 421 Setting.protocol = 'https'
422 422
423 423 valid_languages.each do |lang|
424 424 token.user.update_attribute :language, lang.to_s
425 425 token.reload
426 426 ActionMailer::Base.deliveries.clear
427 427 assert Mailer.deliver_register(token)
428 428 mail = ActionMailer::Base.deliveries.last
429 429 assert_select_email do
430 430 assert_select "a[href=?]",
431 431 "https://redmine.foo/account/activate?token=#{token.value}",
432 432 :text => "https://redmine.foo/account/activate?token=#{token.value}"
433 433 end
434 434 end
435 435 end
436 436
437 437 def test_test
438 438 user = User.find(1)
439 439 valid_languages.each do |lang|
440 440 user.update_attribute :language, lang.to_s
441 441 assert Mailer.deliver_test(user)
442 442 end
443 443 end
444 444
445 445 def test_reminders
446 446 Mailer.reminders(:days => 42)
447 447 assert_equal 1, ActionMailer::Base.deliveries.size
448 448 mail = ActionMailer::Base.deliveries.last
449 449 assert mail.bcc.include?('dlopper@somenet.foo')
450 450 assert mail.body.include?('Bug #3: Error 281 when updating a recipe')
451 451 assert_equal '1 issue(s) due in the next 42 days', mail.subject
452 452 end
453 453
454 454 def test_reminders_should_not_include_closed_issues
455 455 with_settings :default_language => 'en' do
456 456 Issue.generate!(:project_id => 1, :tracker_id => 1, :status_id => 5,
457 457 :subject => 'Closed issue', :assigned_to_id => 3,
458 458 :due_date => 5.days.from_now)
459 459 ActionMailer::Base.deliveries.clear
460 460
461 461 Mailer.reminders(:days => 42)
462 462 assert_equal 1, ActionMailer::Base.deliveries.size
463 463 mail = ActionMailer::Base.deliveries.last
464 464 assert mail.bcc.include?('dlopper@somenet.foo')
465 465 assert !mail.body.include?('Closed issue')
466 466 end
467 467 end
468 468
469 469 def test_reminders_for_users
470 470 Mailer.reminders(:days => 42, :users => ['5'])
471 471 assert_equal 0, ActionMailer::Base.deliveries.size # No mail for dlopper
472 472 Mailer.reminders(:days => 42, :users => ['3'])
473 473 assert_equal 1, ActionMailer::Base.deliveries.size # No mail for dlopper
474 474 mail = ActionMailer::Base.deliveries.last
475 475 assert mail.bcc.include?('dlopper@somenet.foo')
476 476 assert mail.body.include?('Bug #3: Error 281 when updating a recipe')
477 477 end
478 478
479 479 def last_email
480 480 mail = ActionMailer::Base.deliveries.last
481 481 assert_not_nil mail
482 482 mail
483 483 end
484 484
485 485 def test_mailer_should_not_change_locale
486 486 Setting.default_language = 'en'
487 487 # Set current language to italian
488 488 set_language_if_valid 'it'
489 489 # Send an email to a french user
490 490 user = User.find(1)
491 491 user.language = 'fr'
492 492 Mailer.deliver_account_activated(user)
493 493 mail = ActionMailer::Base.deliveries.last
494 494 assert mail.body.include?('Votre compte')
495 495
496 496 assert_equal :it, current_language
497 497 end
498 498
499 499 def test_with_deliveries_off
500 500 Mailer.with_deliveries false do
501 501 Mailer.deliver_test(User.find(1))
502 502 end
503 503 assert ActionMailer::Base.deliveries.empty?
504 504 # should restore perform_deliveries
505 505 assert ActionMailer::Base.perform_deliveries
506 506 end
507 507
508 508 def test_tmail_to_header_field_should_not_include_blank_lines
509 509 mail = TMail::Mail.new
510 510 mail.to = ["a.user@example.com", "v.user2@example.com", "e.smith@example.com", "info@example.com", "v.pupkin@example.com",
511 511 "b.user@example.com", "w.user2@example.com", "f.smith@example.com", "info2@example.com", "w.pupkin@example.com"]
512 512
513 513 assert !mail.encoded.strip.split("\r\n").detect(&:blank?), "#{mail.encoded} malformed"
514 514 end
515 515
516 516 def test_layout_should_include_the_emails_header
517 517 with_settings :emails_header => "*Header content*" do
518 518 assert Mailer.deliver_test(User.find(1))
519 519 assert_select_email do
520 520 assert_select ".header" do
521 521 assert_select "strong", :text => "Header content"
522 522 end
523 523 end
524 524 end
525 525 end
526 526 end
@@ -1,321 +1,321
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class RepositoryTest < ActiveSupport::TestCase
21 21 fixtures :projects,
22 22 :trackers,
23 23 :projects_trackers,
24 24 :enabled_modules,
25 25 :repositories,
26 26 :issues,
27 27 :issue_statuses,
28 28 :issue_categories,
29 29 :changesets,
30 30 :changes,
31 31 :users,
32 32 :members,
33 33 :member_roles,
34 34 :roles,
35 35 :enumerations
36 36
37 37 include Redmine::I18n
38 38
39 39 def setup
40 40 @repository = Project.find(1).repository
41 41 end
42 42
43 43 def test_blank_log_encoding_error_message
44 44 set_language_if_valid 'en'
45 45 repo = Repository::Bazaar.new(
46 46 :project => Project.find(3),
47 47 :url => "/test",
48 48 :log_encoding => ''
49 49 )
50 50 assert !repo.save
51 51 assert_include "Commit messages encoding can't be blank",
52 52 repo.errors.full_messages
53 53 end
54 54
55 55 def test_blank_log_encoding_error_message_fr
56 56 set_language_if_valid 'fr'
57 57 str = "Encodage des messages de commit doit \xc3\xaatre renseign\xc3\xa9(e)"
58 58 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
59 59 repo = Repository::Bazaar.new(
60 60 :project => Project.find(3),
61 61 :url => "/test"
62 62 )
63 63 assert !repo.save
64 64 assert_include str, repo.errors.full_messages
65 65 end
66 66
67 67 def test_create
68 68 repository = Repository::Subversion.new(:project => Project.find(3))
69 69 assert !repository.save
70 70
71 71 repository.url = "svn://localhost"
72 72 assert repository.save
73 73 repository.reload
74 74
75 75 project = Project.find(3)
76 76 assert_equal repository, project.repository
77 77 end
78 78
79 79 def test_first_repository_should_be_set_as_default
80 80 repository1 = Repository::Subversion.new(
81 81 :project => Project.find(3),
82 82 :identifier => 'svn1',
83 83 :url => 'file:///svn1'
84 84 )
85 85 assert repository1.save
86 86 assert repository1.is_default?
87 87
88 88 repository2 = Repository::Subversion.new(
89 89 :project => Project.find(3),
90 90 :identifier => 'svn2',
91 91 :url => 'file:///svn2'
92 92 )
93 93 assert repository2.save
94 94 assert !repository2.is_default?
95 95
96 96 assert_equal repository1, Project.find(3).repository
97 97 assert_equal [repository1, repository2], Project.find(3).repositories.sort
98 98 end
99 99
100 100 def test_destroy
101 101 changesets = Changeset.count(:all, :conditions => "repository_id = 10")
102 102 changes = Change.count(:all, :conditions => "repository_id = 10",
103 103 :include => :changeset)
104 104 assert_difference 'Changeset.count', -changesets do
105 105 assert_difference 'Change.count', -changes do
106 106 Repository.find(10).destroy
107 107 end
108 108 end
109 109 end
110 110
111 111 def test_destroy_should_delete_parents_associations
112 112 changeset = Changeset.find(102)
113 113 changeset.parents = Changeset.find_all_by_id([100, 101])
114 114
115 115 assert_difference 'Changeset.connection.select_all("select * from changeset_parents").size', -2 do
116 116 Repository.find(10).destroy
117 117 end
118 118 end
119 119
120 120 def test_destroy_should_delete_issues_associations
121 121 changeset = Changeset.find(102)
122 122 changeset.issues = Issue.find_all_by_id([1, 2])
123 123
124 124 assert_difference 'Changeset.connection.select_all("select * from changesets_issues").size', -2 do
125 125 Repository.find(10).destroy
126 126 end
127 127 end
128 128
129 129 def test_should_not_create_with_disabled_scm
130 130 # disable Subversion
131 131 with_settings :enabled_scm => ['Darcs', 'Git'] do
132 132 repository = Repository::Subversion.new(
133 133 :project => Project.find(3), :url => "svn://localhost")
134 134 assert !repository.save
135 135 assert_equal I18n.translate('activerecord.errors.messages.invalid'),
136 136 repository.errors[:type].to_s
137 137 end
138 138 end
139 139
140 140 def test_scan_changesets_for_issue_ids
141 141 Setting.default_language = 'en'
142 142 Setting.notified_events = ['issue_added','issue_updated']
143 143
144 144 # choosing a status to apply to fix issues
145 145 Setting.commit_fix_status_id = IssueStatus.find(
146 146 :first,
147 147 :conditions => ["is_closed = ?", true]).id
148 148 Setting.commit_fix_done_ratio = "90"
149 149 Setting.commit_ref_keywords = 'refs , references, IssueID'
150 150 Setting.commit_fix_keywords = 'fixes , closes'
151 151 Setting.default_language = 'en'
152 152 ActionMailer::Base.deliveries.clear
153 153
154 154 # make sure issue 1 is not already closed
155 155 fixed_issue = Issue.find(1)
156 156 assert !fixed_issue.status.is_closed?
157 157 old_status = fixed_issue.status
158 158
159 159 Repository.scan_changesets_for_issue_ids
160 160 assert_equal [101, 102], Issue.find(3).changeset_ids
161 161
162 162 # fixed issues
163 163 fixed_issue.reload
164 164 assert fixed_issue.status.is_closed?
165 165 assert_equal 90, fixed_issue.done_ratio
166 166 assert_equal [101], fixed_issue.changeset_ids
167 167
168 168 # issue change
169 169 journal = fixed_issue.journals.find(:first, :order => 'created_on desc')
170 170 assert_equal User.find_by_login('dlopper'), journal.user
171 171 assert_equal 'Applied in changeset r2.', journal.notes
172 172
173 173 # 2 email notifications
174 174 assert_equal 2, ActionMailer::Base.deliveries.size
175 175 mail = ActionMailer::Base.deliveries.first
176 assert_kind_of TMail::Mail, mail
176 assert_not_nil mail
177 177 assert mail.subject.starts_with?(
178 178 "[#{fixed_issue.project.name} - #{fixed_issue.tracker.name} ##{fixed_issue.id}]")
179 179 assert mail.body.include?(
180 180 "Status changed from #{old_status} to #{fixed_issue.status}")
181 181
182 182 # ignoring commits referencing an issue of another project
183 183 assert_equal [], Issue.find(4).changesets
184 184 end
185 185
186 186 def test_for_changeset_comments_strip
187 187 repository = Repository::Mercurial.create(
188 188 :project => Project.find( 4 ),
189 189 :url => '/foo/bar/baz' )
190 190 comment = <<-COMMENT
191 191 This is a loooooooooooooooooooooooooooong comment
192 192
193 193
194 194 COMMENT
195 195 changeset = Changeset.new(
196 196 :comments => comment, :commit_date => Time.now,
197 197 :revision => 0, :scmid => 'f39b7922fb3c',
198 198 :committer => 'foo <foo@example.com>',
199 199 :committed_on => Time.now, :repository => repository )
200 200 assert( changeset.save )
201 201 assert_not_equal( comment, changeset.comments )
202 202 assert_equal( 'This is a loooooooooooooooooooooooooooong comment',
203 203 changeset.comments )
204 204 end
205 205
206 206 def test_for_urls_strip_cvs
207 207 repository = Repository::Cvs.create(
208 208 :project => Project.find(4),
209 209 :url => ' :pserver:login:password@host:/path/to/the/repository',
210 210 :root_url => 'foo ',
211 211 :log_encoding => 'UTF-8')
212 212 assert repository.save
213 213 repository.reload
214 214 assert_equal ':pserver:login:password@host:/path/to/the/repository',
215 215 repository.url
216 216 assert_equal 'foo', repository.root_url
217 217 end
218 218
219 219 def test_for_urls_strip_subversion
220 220 repository = Repository::Subversion.create(
221 221 :project => Project.find(4),
222 222 :url => ' file:///dummy ')
223 223 assert repository.save
224 224 repository.reload
225 225 assert_equal 'file:///dummy', repository.url
226 226 end
227 227
228 228 def test_for_urls_strip_git
229 229 repository = Repository::Git.create(
230 230 :project => Project.find(4),
231 231 :url => ' c:\dummy ')
232 232 assert repository.save
233 233 repository.reload
234 234 assert_equal 'c:\dummy', repository.url
235 235 end
236 236
237 237 def test_manual_user_mapping
238 238 assert_no_difference "Changeset.count(:conditions => 'user_id <> 2')" do
239 239 c = Changeset.create!(
240 240 :repository => @repository,
241 241 :committer => 'foo',
242 242 :committed_on => Time.now,
243 243 :revision => 100,
244 244 :comments => 'Committed by foo.'
245 245 )
246 246 assert_nil c.user
247 247 @repository.committer_ids = {'foo' => '2'}
248 248 assert_equal User.find(2), c.reload.user
249 249 # committer is now mapped
250 250 c = Changeset.create!(
251 251 :repository => @repository,
252 252 :committer => 'foo',
253 253 :committed_on => Time.now,
254 254 :revision => 101,
255 255 :comments => 'Another commit by foo.'
256 256 )
257 257 assert_equal User.find(2), c.user
258 258 end
259 259 end
260 260
261 261 def test_auto_user_mapping_by_username
262 262 c = Changeset.create!(
263 263 :repository => @repository,
264 264 :committer => 'jsmith',
265 265 :committed_on => Time.now,
266 266 :revision => 100,
267 267 :comments => 'Committed by john.'
268 268 )
269 269 assert_equal User.find(2), c.user
270 270 end
271 271
272 272 def test_auto_user_mapping_by_email
273 273 c = Changeset.create!(
274 274 :repository => @repository,
275 275 :committer => 'john <jsmith@somenet.foo>',
276 276 :committed_on => Time.now,
277 277 :revision => 100,
278 278 :comments => 'Committed by john.'
279 279 )
280 280 assert_equal User.find(2), c.user
281 281 end
282 282
283 283 def test_filesystem_avaialbe
284 284 klass = Repository::Filesystem
285 285 assert klass.scm_adapter_class
286 286 assert_equal true, klass.scm_available
287 287 end
288 288
289 289 def test_merge_extra_info
290 290 repo = Repository::Subversion.new(:project => Project.find(3))
291 291 assert !repo.save
292 292 repo.url = "svn://localhost"
293 293 assert repo.save
294 294 repo.reload
295 295 project = Project.find(3)
296 296 assert_equal repo, project.repository
297 297 assert_nil repo.extra_info
298 298 h1 = {"test_1" => {"test_11" => "test_value_11"}}
299 299 repo.merge_extra_info(h1)
300 300 assert_equal h1, repo.extra_info
301 301 h2 = {"test_2" => {
302 302 "test_21" => "test_value_21",
303 303 "test_22" => "test_value_22",
304 304 }}
305 305 repo.merge_extra_info(h2)
306 306 assert_equal (h = {"test_11" => "test_value_11"}),
307 307 repo.extra_info["test_1"]
308 308 assert_equal "test_value_21",
309 309 repo.extra_info["test_2"]["test_21"]
310 310 h3 = {"test_2" => {
311 311 "test_23" => "test_value_23",
312 312 "test_24" => "test_value_24",
313 313 }}
314 314 repo.merge_extra_info(h3)
315 315 assert_equal (h = {"test_11" => "test_value_11"}),
316 316 repo.extra_info["test_1"]
317 317 assert_nil repo.extra_info["test_2"]["test_21"]
318 318 assert_equal "test_value_23",
319 319 repo.extra_info["test_2"]["test_23"]
320 320 end
321 321 end
General Comments 0
You need to be logged in to leave comments. Login now