jro_apps/redmine Commit - r15402:26f0e0dfb1e5

Don't show "status" field when creating a new version (#23377)....

Jean-Philippe Lang -

r15402:26f0e0dfb1e5

parent child

Context file:

r15402:26f0e0dfb1e5

app/views/versions/_form.html.erb +3 -1

             <div class="box tabular">
             <p><%= f.text_field :name, :size => 60, :required => true %></p>
             <p><%= f.text_field :description, :size => 60 %></p>
-            <p><%= f.select :status, Version::VERSION_STATUSES.collect {|s| [l("version_status_#{s}"), s]} %></p>
+            <% unless @version.new_record? %>
+              <p><%= f.select :status, Version::VERSION_STATUSES.collect {|s| [l("version_status_#{s}"), s]} %></p>
+            <% end %>
             <p><%= f.text_field :wiki_page_title, :label => :label_wiki_page, :size => 60, :disabled => @project.wiki.nil? %></p>
             <p><%= f.date_field :effective_date, :size => 10 %><%= calendar_for('version_effective_date') %></p>
             <p><%= f.select :sharing, @version.allowed_sharings.collect {|v| [format_version_sharing(v), v]} %></p>

test/functional/versions_controller_test.rb +8 -2

                 get :new, :params => {:project_id => '1'}
                 assert_response :success
                 assert_select 'input[name=?]', 'version[name]'
+                assert_select 'select[name=?]', 'version[status]', false
               end
               def test_new_from_issue_form
                 @request.session[:user_id] = 2
                 get :edit, :params => {:id => 2}
                 assert_response :success
-                assert_select 'input[name=?][value=?]', 'version[name]', Version.find(2).name
+                version = Version.find(2)
+                assert_select 'select[name=?]', 'version[status]' do
+                  assert_select 'option[value=?][selected="selected"]', version.status
+                end
+                assert_select 'input[name=?][value=?]', 'version[name]', version.name
               end
               def test_close_completed
               def test_post_update
                 @request.session[:user_id] = 2
                 put :update, :params => {
                   :id => 2,
                   :version => {
                     :name => 'New version name',
                     :effective_date => Date.today.strftime("%Y-%m-%d")

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages