##// END OF EJS Templates
jro_apps » redmine
RSS
Code cleanup....
Jean-Philippe Lang -
r11412:24e99f8b2233
parent child
Show More
Side by Side Unified
Context file:
r11412:24e99f8b2233 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1445 +1,1433
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21
22 22 belongs_to :project
23 23 belongs_to :tracker
24 24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30 30
31 31 has_many :journals, :as => :journalized, :dependent => :destroy
32 32 has_many :visible_journals,
33 33 :class_name => 'Journal',
34 34 :as => :journalized,
35 35 :conditions => Proc.new {
36 36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 37 },
38 38 :readonly => true
39 39
40 40 has_many :time_entries, :dependent => :delete_all
41 41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 48 acts_as_customizable
49 49 acts_as_watchable
50 50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 51 :include => [:project, :visible_journals],
52 52 # sort by id so that limited eager loading doesn't break with postgresql
53 53 :order_column => "#{table_name}.id"
54 54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57 57
58 58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 59 :author_key => :author_id
60 60
61 61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62 62
63 63 attr_reader :current_journal
64 64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65 65
66 66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67 67
68 68 validates_length_of :subject, :maximum => 255
69 69 validates_inclusion_of :done_ratio, :in => 0..100
70 70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 71 validates :start_date, :date => true
72 72 validates :due_date, :date => true
73 73 validate :validate_issue, :validate_required_fields
74 74
75 75 scope :visible, lambda {|*args|
76 76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 77 }
78 78
79 79 scope :open, lambda {|*args|
80 80 is_closed = args.size > 0 ? !args.first : false
81 81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 82 }
83 83
84 84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 85 scope :on_active_project, lambda {
86 86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 87 }
88 88 scope :fixed_version, lambda {|versions|
89 89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 91 }
92 92
93 93 before_create :default_assign
94 94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 97 # Should be after_create but would be called before previous after_save callbacks
98 98 after_save :after_create_from_copy
99 99 after_destroy :update_parent_attributes
100 100
101 101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 102 def self.visible_condition(user, options={})
103 103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 104 if user.logged?
105 105 case role.issues_visibility
106 106 when 'all'
107 107 nil
108 108 when 'default'
109 109 user_ids = [user.id] + user.groups.map(&:id)
110 110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 111 when 'own'
112 112 user_ids = [user.id] + user.groups.map(&:id)
113 113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 114 else
115 115 '1=0'
116 116 end
117 117 else
118 118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 119 end
120 120 end
121 121 end
122 122
123 123 # Returns true if usr or current user is allowed to view the issue
124 124 def visible?(usr=nil)
125 125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 126 if user.logged?
127 127 case role.issues_visibility
128 128 when 'all'
129 129 true
130 130 when 'default'
131 131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 132 when 'own'
133 133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 134 else
135 135 false
136 136 end
137 137 else
138 138 !self.is_private?
139 139 end
140 140 end
141 141 end
142 142
143 143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 144 def editable?(user=User.current)
145 145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 146 end
147 147
148 148 def initialize(attributes=nil, *args)
149 149 super
150 150 if new_record?
151 151 # set default values for new records only
152 152 self.status ||= IssueStatus.default
153 153 self.priority ||= IssuePriority.default
154 154 self.watcher_user_ids = []
155 155 end
156 156 end
157 157
158 158 def create_or_update
159 159 super
160 160 ensure
161 161 @status_was = nil
162 162 end
163 163 private :create_or_update
164 164
165 165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 166 # if the issue was already deleted or updated (non matching lock_version).
167 167 # This is a problem when bulk deleting issues or deleting a project
168 168 # (because an issue may already be deleted if its parent was deleted
169 169 # first).
170 170 # The issue is reloaded by the nested_set before being deleted so
171 171 # the lock_version condition should not be an issue but we handle it.
172 172 def destroy
173 173 super
174 174 rescue ActiveRecord::RecordNotFound
175 175 # Stale or already deleted
176 176 begin
177 177 reload
178 178 rescue ActiveRecord::RecordNotFound
179 179 # The issue was actually already deleted
180 180 @destroyed = true
181 181 return freeze
182 182 end
183 183 # The issue was stale, retry to destroy
184 184 super
185 185 end
186 186
187 187 alias :base_reload :reload
188 188 def reload(*args)
189 189 @workflow_rule_by_attribute = nil
190 190 @assignable_versions = nil
191 191 @relations = nil
192 192 base_reload(*args)
193 193 end
194 194
195 195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
196 196 def available_custom_fields
197 197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
198 198 end
199 199
200 200 # Copies attributes from another issue, arg can be an id or an Issue
201 201 def copy_from(arg, options={})
202 202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
203 203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
204 204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
205 205 self.status = issue.status
206 206 self.author = User.current
207 207 unless options[:attachments] == false
208 208 self.attachments = issue.attachments.map do |attachement|
209 209 attachement.copy(:container => self)
210 210 end
211 211 end
212 212 @copied_from = issue
213 213 @copy_options = options
214 214 self
215 215 end
216 216
217 217 # Returns an unsaved copy of the issue
218 218 def copy(attributes=nil, copy_options={})
219 219 copy = self.class.new.copy_from(self, copy_options)
220 220 copy.attributes = attributes if attributes
221 221 copy
222 222 end
223 223
224 224 # Returns true if the issue is a copy
225 225 def copy?
226 226 @copied_from.present?
227 227 end
228 228
229 229 # Moves/copies an issue to a new project and tracker
230 230 # Returns the moved/copied issue on success, false on failure
231 231 def move_to_project(new_project, new_tracker=nil, options={})
232 232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
233 233
234 234 if options[:copy]
235 235 issue = self.copy
236 236 else
237 237 issue = self
238 238 end
239 239
240 240 issue.init_journal(User.current, options[:notes])
241 241
242 242 # Preserve previous behaviour
243 243 # #move_to_project doesn't change tracker automatically
244 244 issue.send :project=, new_project, true
245 245 if new_tracker
246 246 issue.tracker = new_tracker
247 247 end
248 248 # Allow bulk setting of attributes on the issue
249 249 if options[:attributes]
250 250 issue.attributes = options[:attributes]
251 251 end
252 252
253 253 issue.save ? issue : false
254 254 end
255 255
256 256 def status_id=(sid)
257 257 self.status = nil
258 258 result = write_attribute(:status_id, sid)
259 259 @workflow_rule_by_attribute = nil
260 260 result
261 261 end
262 262
263 263 def priority_id=(pid)
264 264 self.priority = nil
265 265 write_attribute(:priority_id, pid)
266 266 end
267 267
268 268 def category_id=(cid)
269 269 self.category = nil
270 270 write_attribute(:category_id, cid)
271 271 end
272 272
273 273 def fixed_version_id=(vid)
274 274 self.fixed_version = nil
275 275 write_attribute(:fixed_version_id, vid)
276 276 end
277 277
278 278 def tracker_id=(tid)
279 279 self.tracker = nil
280 280 result = write_attribute(:tracker_id, tid)
281 281 @custom_field_values = nil
282 282 @workflow_rule_by_attribute = nil
283 283 result
284 284 end
285 285
286 286 def project_id=(project_id)
287 287 if project_id.to_s != self.project_id.to_s
288 288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
289 289 end
290 290 end
291 291
292 292 def project=(project, keep_tracker=false)
293 293 project_was = self.project
294 294 write_attribute(:project_id, project ? project.id : nil)
295 295 association_instance_set('project', project)
296 296 if project_was && project && project_was != project
297 297 @assignable_versions = nil
298 298
299 299 unless keep_tracker || project.trackers.include?(tracker)
300 300 self.tracker = project.trackers.first
301 301 end
302 302 # Reassign to the category with same name if any
303 303 if category
304 304 self.category = project.issue_categories.find_by_name(category.name)
305 305 end
306 306 # Keep the fixed_version if it's still valid in the new_project
307 307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
308 308 self.fixed_version = nil
309 309 end
310 310 # Clear the parent task if it's no longer valid
311 311 unless valid_parent_project?
312 312 self.parent_issue_id = nil
313 313 end
314 314 @custom_field_values = nil
315 315 end
316 316 end
317 317
318 318 def description=(arg)
319 319 if arg.is_a?(String)
320 320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
321 321 end
322 322 write_attribute(:description, arg)
323 323 end
324 324
325 325 # Overrides assign_attributes so that project and tracker get assigned first
326 326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
327 327 return if new_attributes.nil?
328 328 attrs = new_attributes.dup
329 329 attrs.stringify_keys!
330 330
331 331 %w(project project_id tracker tracker_id).each do |attr|
332 332 if attrs.has_key?(attr)
333 333 send "#{attr}=", attrs.delete(attr)
334 334 end
335 335 end
336 336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
337 337 end
338 338 # Do not redefine alias chain on reload (see #4838)
339 339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
340 340
341 341 def estimated_hours=(h)
342 342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
343 343 end
344 344
345 345 safe_attributes 'project_id',
346 346 :if => lambda {|issue, user|
347 347 if issue.new_record?
348 348 issue.copy?
349 349 elsif user.allowed_to?(:move_issues, issue.project)
350 350 projects = Issue.allowed_target_projects_on_move(user)
351 351 projects.include?(issue.project) && projects.size > 1
352 352 end
353 353 }
354 354
355 355 safe_attributes 'tracker_id',
356 356 'status_id',
357 357 'category_id',
358 358 'assigned_to_id',
359 359 'priority_id',
360 360 'fixed_version_id',
361 361 'subject',
362 362 'description',
363 363 'start_date',
364 364 'due_date',
365 365 'done_ratio',
366 366 'estimated_hours',
367 367 'custom_field_values',
368 368 'custom_fields',
369 369 'lock_version',
370 370 'notes',
371 371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
372 372
373 373 safe_attributes 'status_id',
374 374 'assigned_to_id',
375 375 'fixed_version_id',
376 376 'done_ratio',
377 377 'lock_version',
378 378 'notes',
379 379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
380 380
381 381 safe_attributes 'notes',
382 382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
383 383
384 384 safe_attributes 'private_notes',
385 385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
386 386
387 387 safe_attributes 'watcher_user_ids',
388 388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
389 389
390 390 safe_attributes 'is_private',
391 391 :if => lambda {|issue, user|
392 392 user.allowed_to?(:set_issues_private, issue.project) ||
393 393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
394 394 }
395 395
396 396 safe_attributes 'parent_issue_id',
397 397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
398 398 user.allowed_to?(:manage_subtasks, issue.project)}
399 399
400 400 def safe_attribute_names(user=nil)
401 401 names = super
402 402 names -= disabled_core_fields
403 403 names -= read_only_attribute_names(user)
404 404 names
405 405 end
406 406
407 407 # Safely sets attributes
408 408 # Should be called from controllers instead of #attributes=
409 409 # attr_accessible is too rough because we still want things like
410 410 # Issue.new(:project => foo) to work
411 411 def safe_attributes=(attrs, user=User.current)
412 412 return unless attrs.is_a?(Hash)
413 413
414 414 attrs = attrs.dup
415 415
416 416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
417 417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
418 418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
419 419 self.project_id = p
420 420 end
421 421 end
422 422
423 423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
424 424 self.tracker_id = t
425 425 end
426 426
427 427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
428 428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
429 429 self.status_id = s
430 430 end
431 431 end
432 432
433 433 attrs = delete_unsafe_attributes(attrs, user)
434 434 return if attrs.empty?
435 435
436 436 unless leaf?
437 437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
438 438 end
439 439
440 440 if attrs['parent_issue_id'].present?
441 441 s = attrs['parent_issue_id'].to_s
442 442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
443 443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
444 444 end
445 445 end
446 446
447 447 if attrs['custom_field_values'].present?
448 448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
449 449 end
450 450
451 451 if attrs['custom_fields'].present?
452 452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
453 453 end
454 454
455 455 # mass-assignment security bypass
456 456 assign_attributes attrs, :without_protection => true
457 457 end
458 458
459 459 def disabled_core_fields
460 460 tracker ? tracker.disabled_core_fields : []
461 461 end
462 462
463 463 # Returns the custom_field_values that can be edited by the given user
464 464 def editable_custom_field_values(user=nil)
465 465 custom_field_values.reject do |value|
466 466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
467 467 end
468 468 end
469 469
470 470 # Returns the names of attributes that are read-only for user or the current user
471 471 # For users with multiple roles, the read-only fields are the intersection of
472 472 # read-only fields of each role
473 473 # The result is an array of strings where sustom fields are represented with their ids
474 474 #
475 475 # Examples:
476 476 # issue.read_only_attribute_names # => ['due_date', '2']
477 477 # issue.read_only_attribute_names(user) # => []
478 478 def read_only_attribute_names(user=nil)
479 479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
480 480 end
481 481
482 482 # Returns the names of required attributes for user or the current user
483 483 # For users with multiple roles, the required fields are the intersection of
484 484 # required fields of each role
485 485 # The result is an array of strings where sustom fields are represented with their ids
486 486 #
487 487 # Examples:
488 488 # issue.required_attribute_names # => ['due_date', '2']
489 489 # issue.required_attribute_names(user) # => []
490 490 def required_attribute_names(user=nil)
491 491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
492 492 end
493 493
494 494 # Returns true if the attribute is required for user
495 495 def required_attribute?(name, user=nil)
496 496 required_attribute_names(user).include?(name.to_s)
497 497 end
498 498
499 499 # Returns a hash of the workflow rule by attribute for the given user
500 500 #
501 501 # Examples:
502 502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
503 503 def workflow_rule_by_attribute(user=nil)
504 504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
505 505
506 506 user_real = user || User.current
507 507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
508 508 return {} if roles.empty?
509 509
510 510 result = {}
511 511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
512 512 if workflow_permissions.any?
513 513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
514 514 h[wp.field_name] ||= []
515 515 h[wp.field_name] << wp.rule
516 516 h
517 517 end
518 518 workflow_rules.each do |attr, rules|
519 519 next if rules.size < roles.size
520 520 uniq_rules = rules.uniq
521 521 if uniq_rules.size == 1
522 522 result[attr] = uniq_rules.first
523 523 else
524 524 result[attr] = 'required'
525 525 end
526 526 end
527 527 end
528 528 @workflow_rule_by_attribute = result if user.nil?
529 529 result
530 530 end
531 531 private :workflow_rule_by_attribute
532 532
533 533 def done_ratio
534 534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
535 535 status.default_done_ratio
536 536 else
537 537 read_attribute(:done_ratio)
538 538 end
539 539 end
540 540
541 541 def self.use_status_for_done_ratio?
542 542 Setting.issue_done_ratio == 'issue_status'
543 543 end
544 544
545 545 def self.use_field_for_done_ratio?
546 546 Setting.issue_done_ratio == 'issue_field'
547 547 end
548 548
549 549 def validate_issue
550 550 if due_date && start_date && due_date < start_date
551 551 errors.add :due_date, :greater_than_start_date
552 552 end
553 553
554 554 if start_date && soonest_start && start_date < soonest_start
555 555 errors.add :start_date, :invalid
556 556 end
557 557
558 558 if fixed_version
559 559 if !assignable_versions.include?(fixed_version)
560 560 errors.add :fixed_version_id, :inclusion
561 561 elsif reopened? && fixed_version.closed?
562 562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
563 563 end
564 564 end
565 565
566 566 # Checks that the issue can not be added/moved to a disabled tracker
567 567 if project && (tracker_id_changed? || project_id_changed?)
568 568 unless project.trackers.include?(tracker)
569 569 errors.add :tracker_id, :inclusion
570 570 end
571 571 end
572 572
573 573 # Checks parent issue assignment
574 574 if @invalid_parent_issue_id.present?
575 575 errors.add :parent_issue_id, :invalid
576 576 elsif @parent_issue
577 577 if !valid_parent_project?(@parent_issue)
578 578 errors.add :parent_issue_id, :invalid
579 579 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
580 580 errors.add :parent_issue_id, :invalid
581 581 elsif !new_record?
582 582 # moving an existing issue
583 583 if @parent_issue.root_id != root_id
584 584 # we can always move to another tree
585 585 elsif move_possible?(@parent_issue)
586 586 # move accepted inside tree
587 587 else
588 588 errors.add :parent_issue_id, :invalid
589 589 end
590 590 end
591 591 end
592 592 end
593 593
594 594 # Validates the issue against additional workflow requirements
595 595 def validate_required_fields
596 596 user = new_record? ? author : current_journal.try(:user)
597 597
598 598 required_attribute_names(user).each do |attribute|
599 599 if attribute =~ /^\d+$/
600 600 attribute = attribute.to_i
601 601 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
602 602 if v && v.value.blank?
603 603 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
604 604 end
605 605 else
606 606 if respond_to?(attribute) && send(attribute).blank?
607 607 errors.add attribute, :blank
608 608 end
609 609 end
610 610 end
611 611 end
612 612
613 613 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
614 614 # even if the user turns off the setting later
615 615 def update_done_ratio_from_issue_status
616 616 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
617 617 self.done_ratio = status.default_done_ratio
618 618 end
619 619 end
620 620
621 621 def init_journal(user, notes = "")
622 622 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
623 623 if new_record?
624 624 @current_journal.notify = false
625 625 else
626 626 @attributes_before_change = attributes.dup
627 627 @custom_values_before_change = {}
628 628 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
629 629 end
630 630 @current_journal
631 631 end
632 632
633 633 # Returns the id of the last journal or nil
634 634 def last_journal_id
635 635 if new_record?
636 636 nil
637 637 else
638 638 journals.maximum(:id)
639 639 end
640 640 end
641 641
642 642 # Returns a scope for journals that have an id greater than journal_id
643 643 def journals_after(journal_id)
644 644 scope = journals.reorder("#{Journal.table_name}.id ASC")
645 645 if journal_id.present?
646 646 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
647 647 end
648 648 scope
649 649 end
650 650
651 651 # Returns the initial status of the issue
652 652 # Returns nil for a new issue
653 653 def status_was
654 654 if status_id_was && status_id_was.to_i > 0
655 655 @status_was ||= IssueStatus.find_by_id(status_id_was)
656 656 end
657 657 end
658 658
659 659 # Return true if the issue is closed, otherwise false
660 660 def closed?
661 661 self.status.is_closed?
662 662 end
663 663
664 664 # Return true if the issue is being reopened
665 665 def reopened?
666 666 if !new_record? && status_id_changed?
667 667 status_was = IssueStatus.find_by_id(status_id_was)
668 668 status_new = IssueStatus.find_by_id(status_id)
669 669 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
670 670 return true
671 671 end
672 672 end
673 673 false
674 674 end
675 675
676 676 # Return true if the issue is being closed
677 677 def closing?
678 678 if !new_record? && status_id_changed?
679 679 if status_was && status && !status_was.is_closed? && status.is_closed?
680 680 return true
681 681 end
682 682 end
683 683 false
684 684 end
685 685
686 686 # Returns true if the issue is overdue
687 687 def overdue?
688 688 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
689 689 end
690 690
691 691 # Is the amount of work done less than it should for the due date
692 692 def behind_schedule?
693 693 return false if start_date.nil? || due_date.nil?
694 694 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
695 695 return done_date <= Date.today
696 696 end
697 697
698 698 # Does this issue have children?
699 699 def children?
700 700 !leaf?
701 701 end
702 702
703 703 # Users the issue can be assigned to
704 704 def assignable_users
705 705 users = project.assignable_users
706 706 users << author if author
707 707 users << assigned_to if assigned_to
708 708 users.uniq.sort
709 709 end
710 710
711 711 # Versions that the issue can be assigned to
712 712 def assignable_versions
713 713 return @assignable_versions if @assignable_versions
714 714
715 715 versions = project.shared_versions.open.all
716 716 if fixed_version
717 717 if fixed_version_id_changed?
718 718 # nothing to do
719 719 elsif project_id_changed?
720 720 if project.shared_versions.include?(fixed_version)
721 721 versions << fixed_version
722 722 end
723 723 else
724 724 versions << fixed_version
725 725 end
726 726 end
727 727 @assignable_versions = versions.uniq.sort
728 728 end
729 729
730 730 # Returns true if this issue is blocked by another issue that is still open
731 731 def blocked?
732 732 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
733 733 end
734 734
735 735 # Returns an array of statuses that user is able to apply
736 736 def new_statuses_allowed_to(user=User.current, include_default=false)
737 737 if new_record? && @copied_from
738 738 [IssueStatus.default, @copied_from.status].compact.uniq.sort
739 739 else
740 740 initial_status = nil
741 741 if new_record?
742 742 initial_status = IssueStatus.default
743 743 elsif status_id_was
744 744 initial_status = IssueStatus.find_by_id(status_id_was)
745 745 end
746 746 initial_status ||= status
747 747
748 748 statuses = initial_status.find_new_statuses_allowed_to(
749 749 user.admin ? Role.all : user.roles_for_project(project),
750 750 tracker,
751 751 author == user,
752 752 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
753 753 )
754 754 statuses << initial_status unless statuses.empty?
755 755 statuses << IssueStatus.default if include_default
756 756 statuses = statuses.compact.uniq.sort
757 757 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
758 758 end
759 759 end
760 760
761 761 def assigned_to_was
762 762 if assigned_to_id_changed? && assigned_to_id_was.present?
763 763 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
764 764 end
765 765 end
766 766
767 767 # Returns the users that should be notified
768 768 def notified_users
769 769 notified = []
770 770 # Author and assignee are always notified unless they have been
771 771 # locked or don't want to be notified
772 772 notified << author if author
773 773 if assigned_to
774 774 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
775 775 end
776 776 if assigned_to_was
777 777 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
778 778 end
779 779 notified = notified.select {|u| u.active? && u.notify_about?(self)}
780 780
781 781 notified += project.notified_users
782 782 notified.uniq!
783 783 # Remove users that can not view the issue
784 784 notified.reject! {|user| !visible?(user)}
785 785 notified
786 786 end
787 787
788 788 # Returns the email addresses that should be notified
789 789 def recipients
790 790 notified_users.collect(&:mail)
791 791 end
792 792
793 793 # Returns the number of hours spent on this issue
794 794 def spent_hours
795 795 @spent_hours ||= time_entries.sum(:hours) || 0
796 796 end
797 797
798 798 # Returns the total number of hours spent on this issue and its descendants
799 799 #
800 800 # Example:
801 801 # spent_hours => 0.0
802 802 # spent_hours => 50.2
803 803 def total_spent_hours
804 804 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
805 805 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
806 806 end
807 807
808 808 def relations
809 809 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
810 810 end
811 811
812 812 # Preloads relations for a collection of issues
813 813 def self.load_relations(issues)
814 814 if issues.any?
815 815 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
816 816 issues.each do |issue|
817 817 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
818 818 end
819 819 end
820 820 end
821 821
822 822 # Preloads visible spent time for a collection of issues
823 823 def self.load_visible_spent_hours(issues, user=User.current)
824 824 if issues.any?
825 825 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
826 826 issues.each do |issue|
827 827 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
828 828 end
829 829 end
830 830 end
831 831
832 832 # Preloads visible relations for a collection of issues
833 833 def self.load_visible_relations(issues, user=User.current)
834 834 if issues.any?
835 835 issue_ids = issues.map(&:id)
836 836 # Relations with issue_from in given issues and visible issue_to
837 837 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
838 838 # Relations with issue_to in given issues and visible issue_from
839 839 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
840 840
841 841 issues.each do |issue|
842 842 relations =
843 843 relations_from.select {|relation| relation.issue_from_id == issue.id} +
844 844 relations_to.select {|relation| relation.issue_to_id == issue.id}
845 845
846 846 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
847 847 end
848 848 end
849 849 end
850 850
851 851 # Finds an issue relation given its id.
852 852 def find_relation(relation_id)
853 853 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
854 854 end
855 855
856 # Returns all the other issues that depend on the issue
856 857 def all_dependent_issues(except=[])
857 858 except << self
858 859 dependencies = []
859 relations_from.each do |relation|
860 if relation.issue_to && !except.include?(relation.issue_to)
861 dependencies << relation.issue_to
862 dependencies += relation.issue_to.all_dependent_issues(except)
863 end
864 end
865 unless leaf?
866 children.each do |child|
867 if !except.include?(child)
868 dependencies << child
869 dependencies += child.all_dependent_issues(except)
870 end
871 end
872 end
873 if parent && !except.include?(parent)
874 dependencies << parent
875 dependencies += parent.all_dependent_issues(except)
876 end
877 dependencies
860 dependencies += relations_from.map(&:issue_to)
861 dependencies += children unless leaf?
862 dependencies << parent
863 dependencies.compact!
864 dependencies -= except
865 dependencies + dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
878 866 end
879 867
880 868 # Returns an array of issues that duplicate this one
881 869 def duplicates
882 870 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
883 871 end
884 872
885 873 # Returns the due date or the target due date if any
886 874 # Used on gantt chart
887 875 def due_before
888 876 due_date || (fixed_version ? fixed_version.effective_date : nil)
889 877 end
890 878
891 879 # Returns the time scheduled for this issue.
892 880 #
893 881 # Example:
894 882 # Start Date: 2/26/09, End Date: 3/04/09
895 883 # duration => 6
896 884 def duration
897 885 (start_date && due_date) ? due_date - start_date : 0
898 886 end
899 887
900 888 # Returns the duration in working days
901 889 def working_duration
902 890 (start_date && due_date) ? working_days(start_date, due_date) : 0
903 891 end
904 892
905 893 def soonest_start(reload=false)
906 894 @soonest_start = nil if reload
907 895 @soonest_start ||= (
908 896 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
909 897 [(@parent_issue || parent).try(:soonest_start)]
910 898 ).compact.max
911 899 end
912 900
913 901 # Sets start_date on the given date or the next working day
914 902 # and changes due_date to keep the same working duration.
915 903 def reschedule_on(date)
916 904 wd = working_duration
917 905 date = next_working_date(date)
918 906 self.start_date = date
919 907 self.due_date = add_working_days(date, wd)
920 908 end
921 909
922 910 # Reschedules the issue on the given date or the next working day and saves the record.
923 911 # If the issue is a parent task, this is done by rescheduling its subtasks.
924 912 def reschedule_on!(date)
925 913 return if date.nil?
926 914 if leaf?
927 915 if start_date.nil? || start_date != date
928 916 if start_date && start_date > date
929 917 # Issue can not be moved earlier than its soonest start date
930 918 date = [soonest_start(true), date].compact.max
931 919 end
932 920 reschedule_on(date)
933 921 begin
934 922 save
935 923 rescue ActiveRecord::StaleObjectError
936 924 reload
937 925 reschedule_on(date)
938 926 save
939 927 end
940 928 end
941 929 else
942 930 leaves.each do |leaf|
943 931 if leaf.start_date
944 932 # Only move subtask if it starts at the same date as the parent
945 933 # or if it starts before the given date
946 934 if start_date == leaf.start_date || date > leaf.start_date
947 935 leaf.reschedule_on!(date)
948 936 end
949 937 else
950 938 leaf.reschedule_on!(date)
951 939 end
952 940 end
953 941 end
954 942 end
955 943
956 944 def <=>(issue)
957 945 if issue.nil?
958 946 -1
959 947 elsif root_id != issue.root_id
960 948 (root_id || 0) <=> (issue.root_id || 0)
961 949 else
962 950 (lft || 0) <=> (issue.lft || 0)
963 951 end
964 952 end
965 953
966 954 def to_s
967 955 "#{tracker} ##{id}: #{subject}"
968 956 end
969 957
970 958 # Returns a string of css classes that apply to the issue
971 959 def css_classes
972 960 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
973 961 s << ' closed' if closed?
974 962 s << ' overdue' if overdue?
975 963 s << ' child' if child?
976 964 s << ' parent' unless leaf?
977 965 s << ' private' if is_private?
978 966 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
979 967 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
980 968 s
981 969 end
982 970
983 971 # Saves an issue and a time_entry from the parameters
984 972 def save_issue_with_child_records(params, existing_time_entry=nil)
985 973 Issue.transaction do
986 974 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
987 975 @time_entry = existing_time_entry || TimeEntry.new
988 976 @time_entry.project = project
989 977 @time_entry.issue = self
990 978 @time_entry.user = User.current
991 979 @time_entry.spent_on = User.current.today
992 980 @time_entry.attributes = params[:time_entry]
993 981 self.time_entries << @time_entry
994 982 end
995 983
996 984 # TODO: Rename hook
997 985 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
998 986 if save
999 987 # TODO: Rename hook
1000 988 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
1001 989 else
1002 990 raise ActiveRecord::Rollback
1003 991 end
1004 992 end
1005 993 end
1006 994
1007 995 # Unassigns issues from +version+ if it's no longer shared with issue's project
1008 996 def self.update_versions_from_sharing_change(version)
1009 997 # Update issues assigned to the version
1010 998 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1011 999 end
1012 1000
1013 1001 # Unassigns issues from versions that are no longer shared
1014 1002 # after +project+ was moved
1015 1003 def self.update_versions_from_hierarchy_change(project)
1016 1004 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1017 1005 # Update issues of the moved projects and issues assigned to a version of a moved project
1018 1006 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1019 1007 end
1020 1008
1021 1009 def parent_issue_id=(arg)
1022 1010 s = arg.to_s.strip.presence
1023 1011 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1024 1012 @parent_issue.id
1025 1013 else
1026 1014 @parent_issue = nil
1027 1015 @invalid_parent_issue_id = arg
1028 1016 end
1029 1017 end
1030 1018
1031 1019 def parent_issue_id
1032 1020 if @invalid_parent_issue_id
1033 1021 @invalid_parent_issue_id
1034 1022 elsif instance_variable_defined? :@parent_issue
1035 1023 @parent_issue.nil? ? nil : @parent_issue.id
1036 1024 else
1037 1025 parent_id
1038 1026 end
1039 1027 end
1040 1028
1041 1029 # Returns true if issue's project is a valid
1042 1030 # parent issue project
1043 1031 def valid_parent_project?(issue=parent)
1044 1032 return true if issue.nil? || issue.project_id == project_id
1045 1033
1046 1034 case Setting.cross_project_subtasks
1047 1035 when 'system'
1048 1036 true
1049 1037 when 'tree'
1050 1038 issue.project.root == project.root
1051 1039 when 'hierarchy'
1052 1040 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1053 1041 when 'descendants'
1054 1042 issue.project.is_or_is_ancestor_of?(project)
1055 1043 else
1056 1044 false
1057 1045 end
1058 1046 end
1059 1047
1060 1048 # Extracted from the ReportsController.
1061 1049 def self.by_tracker(project)
1062 1050 count_and_group_by(:project => project,
1063 1051 :field => 'tracker_id',
1064 1052 :joins => Tracker.table_name)
1065 1053 end
1066 1054
1067 1055 def self.by_version(project)
1068 1056 count_and_group_by(:project => project,
1069 1057 :field => 'fixed_version_id',
1070 1058 :joins => Version.table_name)
1071 1059 end
1072 1060
1073 1061 def self.by_priority(project)
1074 1062 count_and_group_by(:project => project,
1075 1063 :field => 'priority_id',
1076 1064 :joins => IssuePriority.table_name)
1077 1065 end
1078 1066
1079 1067 def self.by_category(project)
1080 1068 count_and_group_by(:project => project,
1081 1069 :field => 'category_id',
1082 1070 :joins => IssueCategory.table_name)
1083 1071 end
1084 1072
1085 1073 def self.by_assigned_to(project)
1086 1074 count_and_group_by(:project => project,
1087 1075 :field => 'assigned_to_id',
1088 1076 :joins => User.table_name)
1089 1077 end
1090 1078
1091 1079 def self.by_author(project)
1092 1080 count_and_group_by(:project => project,
1093 1081 :field => 'author_id',
1094 1082 :joins => User.table_name)
1095 1083 end
1096 1084
1097 1085 def self.by_subproject(project)
1098 1086 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1099 1087 s.is_closed as closed,
1100 1088 #{Issue.table_name}.project_id as project_id,
1101 1089 count(#{Issue.table_name}.id) as total
1102 1090 from
1103 1091 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1104 1092 where
1105 1093 #{Issue.table_name}.status_id=s.id
1106 1094 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1107 1095 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1108 1096 and #{Issue.table_name}.project_id <> #{project.id}
1109 1097 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1110 1098 end
1111 1099 # End ReportsController extraction
1112 1100
1113 1101 # Returns an array of projects that user can assign the issue to
1114 1102 def allowed_target_projects(user=User.current)
1115 1103 if new_record?
1116 1104 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1117 1105 else
1118 1106 self.class.allowed_target_projects_on_move(user)
1119 1107 end
1120 1108 end
1121 1109
1122 1110 # Returns an array of projects that user can move issues to
1123 1111 def self.allowed_target_projects_on_move(user=User.current)
1124 1112 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1125 1113 end
1126 1114
1127 1115 private
1128 1116
1129 1117 def after_project_change
1130 1118 # Update project_id on related time entries
1131 1119 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1132 1120
1133 1121 # Delete issue relations
1134 1122 unless Setting.cross_project_issue_relations?
1135 1123 relations_from.clear
1136 1124 relations_to.clear
1137 1125 end
1138 1126
1139 1127 # Move subtasks that were in the same project
1140 1128 children.each do |child|
1141 1129 next unless child.project_id == project_id_was
1142 1130 # Change project and keep project
1143 1131 child.send :project=, project, true
1144 1132 unless child.save
1145 1133 raise ActiveRecord::Rollback
1146 1134 end
1147 1135 end
1148 1136 end
1149 1137
1150 1138 # Callback for after the creation of an issue by copy
1151 1139 # * adds a "copied to" relation with the copied issue
1152 1140 # * copies subtasks from the copied issue
1153 1141 def after_create_from_copy
1154 1142 return unless copy? && !@after_create_from_copy_handled
1155 1143
1156 1144 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1157 1145 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1158 1146 unless relation.save
1159 1147 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1160 1148 end
1161 1149 end
1162 1150
1163 1151 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1164 1152 copy_options = (@copy_options || {}).merge(:subtasks => false)
1165 1153 copied_issue_ids = {@copied_from.id => self.id}
1166 1154 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1167 1155 # Do not copy self when copying an issue as a descendant of the copied issue
1168 1156 next if child == self
1169 1157 # Do not copy subtasks of issues that were not copied
1170 1158 next unless copied_issue_ids[child.parent_id]
1171 1159 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1172 1160 unless child.visible?
1173 1161 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1174 1162 next
1175 1163 end
1176 1164 copy = Issue.new.copy_from(child, copy_options)
1177 1165 copy.author = author
1178 1166 copy.project = project
1179 1167 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1180 1168 unless copy.save
1181 1169 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1182 1170 next
1183 1171 end
1184 1172 copied_issue_ids[child.id] = copy.id
1185 1173 end
1186 1174 end
1187 1175 @after_create_from_copy_handled = true
1188 1176 end
1189 1177
1190 1178 def update_nested_set_attributes
1191 1179 if root_id.nil?
1192 1180 # issue was just created
1193 1181 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1194 1182 set_default_left_and_right
1195 1183 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1196 1184 if @parent_issue
1197 1185 move_to_child_of(@parent_issue)
1198 1186 end
1199 1187 elsif parent_issue_id != parent_id
1200 1188 former_parent_id = parent_id
1201 1189 # moving an existing issue
1202 1190 if @parent_issue && @parent_issue.root_id == root_id
1203 1191 # inside the same tree
1204 1192 move_to_child_of(@parent_issue)
1205 1193 else
1206 1194 # to another tree
1207 1195 unless root?
1208 1196 move_to_right_of(root)
1209 1197 end
1210 1198 old_root_id = root_id
1211 1199 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1212 1200 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1213 1201 offset = target_maxright + 1 - lft
1214 1202 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1215 1203 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1216 1204 self[left_column_name] = lft + offset
1217 1205 self[right_column_name] = rgt + offset
1218 1206 if @parent_issue
1219 1207 move_to_child_of(@parent_issue)
1220 1208 end
1221 1209 end
1222 1210 # delete invalid relations of all descendants
1223 1211 self_and_descendants.each do |issue|
1224 1212 issue.relations.each do |relation|
1225 1213 relation.destroy unless relation.valid?
1226 1214 end
1227 1215 end
1228 1216 # update former parent
1229 1217 recalculate_attributes_for(former_parent_id) if former_parent_id
1230 1218 end
1231 1219 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1232 1220 end
1233 1221
1234 1222 def update_parent_attributes
1235 1223 recalculate_attributes_for(parent_id) if parent_id
1236 1224 end
1237 1225
1238 1226 def recalculate_attributes_for(issue_id)
1239 1227 if issue_id && p = Issue.find_by_id(issue_id)
1240 1228 # priority = highest priority of children
1241 1229 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1242 1230 p.priority = IssuePriority.find_by_position(priority_position)
1243 1231 end
1244 1232
1245 1233 # start/due dates = lowest/highest dates of children
1246 1234 p.start_date = p.children.minimum(:start_date)
1247 1235 p.due_date = p.children.maximum(:due_date)
1248 1236 if p.start_date && p.due_date && p.due_date < p.start_date
1249 1237 p.start_date, p.due_date = p.due_date, p.start_date
1250 1238 end
1251 1239
1252 1240 # done ratio = weighted average ratio of leaves
1253 1241 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1254 1242 leaves_count = p.leaves.count
1255 1243 if leaves_count > 0
1256 1244 average = p.leaves.average(:estimated_hours).to_f
1257 1245 if average == 0
1258 1246 average = 1
1259 1247 end
1260 1248 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1261 1249 progress = done / (average * leaves_count)
1262 1250 p.done_ratio = progress.round
1263 1251 end
1264 1252 end
1265 1253
1266 1254 # estimate = sum of leaves estimates
1267 1255 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1268 1256 p.estimated_hours = nil if p.estimated_hours == 0.0
1269 1257
1270 1258 # ancestors will be recursively updated
1271 1259 p.save(:validate => false)
1272 1260 end
1273 1261 end
1274 1262
1275 1263 # Update issues so their versions are not pointing to a
1276 1264 # fixed_version that is not shared with the issue's project
1277 1265 def self.update_versions(conditions=nil)
1278 1266 # Only need to update issues with a fixed_version from
1279 1267 # a different project and that is not systemwide shared
1280 1268 Issue.scoped(:conditions => conditions).all(
1281 1269 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1282 1270 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1283 1271 " AND #{Version.table_name}.sharing <> 'system'",
1284 1272 :include => [:project, :fixed_version]
1285 1273 ).each do |issue|
1286 1274 next if issue.project.nil? || issue.fixed_version.nil?
1287 1275 unless issue.project.shared_versions.include?(issue.fixed_version)
1288 1276 issue.init_journal(User.current)
1289 1277 issue.fixed_version = nil
1290 1278 issue.save
1291 1279 end
1292 1280 end
1293 1281 end
1294 1282
1295 1283 # Callback on file attachment
1296 1284 def attachment_added(obj)
1297 1285 if @current_journal && !obj.new_record?
1298 1286 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1299 1287 end
1300 1288 end
1301 1289
1302 1290 # Callback on attachment deletion
1303 1291 def attachment_removed(obj)
1304 1292 if @current_journal && !obj.new_record?
1305 1293 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1306 1294 @current_journal.save
1307 1295 end
1308 1296 end
1309 1297
1310 1298 # Default assignment based on category
1311 1299 def default_assign
1312 1300 if assigned_to.nil? && category && category.assigned_to
1313 1301 self.assigned_to = category.assigned_to
1314 1302 end
1315 1303 end
1316 1304
1317 1305 # Updates start/due dates of following issues
1318 1306 def reschedule_following_issues
1319 1307 if start_date_changed? || due_date_changed?
1320 1308 relations_from.each do |relation|
1321 1309 relation.set_issue_to_dates
1322 1310 end
1323 1311 end
1324 1312 end
1325 1313
1326 1314 # Closes duplicates if the issue is being closed
1327 1315 def close_duplicates
1328 1316 if closing?
1329 1317 duplicates.each do |duplicate|
1330 1318 # Reload is need in case the duplicate was updated by a previous duplicate
1331 1319 duplicate.reload
1332 1320 # Don't re-close it if it's already closed
1333 1321 next if duplicate.closed?
1334 1322 # Same user and notes
1335 1323 if @current_journal
1336 1324 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1337 1325 end
1338 1326 duplicate.update_attribute :status, self.status
1339 1327 end
1340 1328 end
1341 1329 end
1342 1330
1343 1331 # Make sure updated_on is updated when adding a note and set updated_on now
1344 1332 # so we can set closed_on with the same value on closing
1345 1333 def force_updated_on_change
1346 1334 if @current_journal || changed?
1347 1335 self.updated_on = current_time_from_proper_timezone
1348 1336 if new_record?
1349 1337 self.created_on = updated_on
1350 1338 end
1351 1339 end
1352 1340 end
1353 1341
1354 1342 # Callback for setting closed_on when the issue is closed.
1355 1343 # The closed_on attribute stores the time of the last closing
1356 1344 # and is preserved when the issue is reopened.
1357 1345 def update_closed_on
1358 1346 if closing? || (new_record? && closed?)
1359 1347 self.closed_on = updated_on
1360 1348 end
1361 1349 end
1362 1350
1363 1351 # Saves the changes in a Journal
1364 1352 # Called after_save
1365 1353 def create_journal
1366 1354 if @current_journal
1367 1355 # attributes changes
1368 1356 if @attributes_before_change
1369 1357 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1370 1358 before = @attributes_before_change[c]
1371 1359 after = send(c)
1372 1360 next if before == after || (before.blank? && after.blank?)
1373 1361 @current_journal.details << JournalDetail.new(:property => 'attr',
1374 1362 :prop_key => c,
1375 1363 :old_value => before,
1376 1364 :value => after)
1377 1365 }
1378 1366 end
1379 1367 if @custom_values_before_change
1380 1368 # custom fields changes
1381 1369 custom_field_values.each {|c|
1382 1370 before = @custom_values_before_change[c.custom_field_id]
1383 1371 after = c.value
1384 1372 next if before == after || (before.blank? && after.blank?)
1385 1373
1386 1374 if before.is_a?(Array) || after.is_a?(Array)
1387 1375 before = [before] unless before.is_a?(Array)
1388 1376 after = [after] unless after.is_a?(Array)
1389 1377
1390 1378 # values removed
1391 1379 (before - after).reject(&:blank?).each do |value|
1392 1380 @current_journal.details << JournalDetail.new(:property => 'cf',
1393 1381 :prop_key => c.custom_field_id,
1394 1382 :old_value => value,
1395 1383 :value => nil)
1396 1384 end
1397 1385 # values added
1398 1386 (after - before).reject(&:blank?).each do |value|
1399 1387 @current_journal.details << JournalDetail.new(:property => 'cf',
1400 1388 :prop_key => c.custom_field_id,
1401 1389 :old_value => nil,
1402 1390 :value => value)
1403 1391 end
1404 1392 else
1405 1393 @current_journal.details << JournalDetail.new(:property => 'cf',
1406 1394 :prop_key => c.custom_field_id,
1407 1395 :old_value => before,
1408 1396 :value => after)
1409 1397 end
1410 1398 }
1411 1399 end
1412 1400 @current_journal.save
1413 1401 # reset current journal
1414 1402 init_journal @current_journal.user, @current_journal.notes
1415 1403 end
1416 1404 end
1417 1405
1418 1406 # Query generator for selecting groups of issue counts for a project
1419 1407 # based on specific criteria
1420 1408 #
1421 1409 # Options
1422 1410 # * project - Project to search in.
1423 1411 # * field - String. Issue field to key off of in the grouping.
1424 1412 # * joins - String. The table name to join against.
1425 1413 def self.count_and_group_by(options)
1426 1414 project = options.delete(:project)
1427 1415 select_field = options.delete(:field)
1428 1416 joins = options.delete(:joins)
1429 1417
1430 1418 where = "#{Issue.table_name}.#{select_field}=j.id"
1431 1419
1432 1420 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1433 1421 s.is_closed as closed,
1434 1422 j.id as #{select_field},
1435 1423 count(#{Issue.table_name}.id) as total
1436 1424 from
1437 1425 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1438 1426 where
1439 1427 #{Issue.table_name}.status_id=s.id
1440 1428 and #{where}
1441 1429 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1442 1430 and #{visible_condition(User.current, :project => project)}
1443 1431 group by s.id, s.is_closed, j.id")
1444 1432 end
1445 1433 end
General Comments 0
You need to be logged in to leave comments. Login now