##// END OF EJS Templates
Code cleanup....
Jean-Philippe Lang -
r11412:24e99f8b2233
parent child
Show More
@@ -1,1445 +1,1433
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Issue < ActiveRecord::Base
18 class Issue < ActiveRecord::Base
19 include Redmine::SafeAttributes
19 include Redmine::SafeAttributes
20 include Redmine::Utils::DateCalculation
20 include Redmine::Utils::DateCalculation
21
21
22 belongs_to :project
22 belongs_to :project
23 belongs_to :tracker
23 belongs_to :tracker
24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
30
30
31 has_many :journals, :as => :journalized, :dependent => :destroy
31 has_many :journals, :as => :journalized, :dependent => :destroy
32 has_many :visible_journals,
32 has_many :visible_journals,
33 :class_name => 'Journal',
33 :class_name => 'Journal',
34 :as => :journalized,
34 :as => :journalized,
35 :conditions => Proc.new {
35 :conditions => Proc.new {
36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
36 ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
37 },
37 },
38 :readonly => true
38 :readonly => true
39
39
40 has_many :time_entries, :dependent => :delete_all
40 has_many :time_entries, :dependent => :delete_all
41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
41 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
42
42
43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45
45
46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
46 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
47 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
48 acts_as_customizable
48 acts_as_customizable
49 acts_as_watchable
49 acts_as_watchable
50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
50 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
51 :include => [:project, :visible_journals],
51 :include => [:project, :visible_journals],
52 # sort by id so that limited eager loading doesn't break with postgresql
52 # sort by id so that limited eager loading doesn't break with postgresql
53 :order_column => "#{table_name}.id"
53 :order_column => "#{table_name}.id"
54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
54 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
55 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
56 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
57
57
58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
58 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
59 :author_key => :author_id
59 :author_key => :author_id
60
60
61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
61 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
62
62
63 attr_reader :current_journal
63 attr_reader :current_journal
64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
64 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
65
65
66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
66 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
67
67
68 validates_length_of :subject, :maximum => 255
68 validates_length_of :subject, :maximum => 255
69 validates_inclusion_of :done_ratio, :in => 0..100
69 validates_inclusion_of :done_ratio, :in => 0..100
70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
70 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
71 validates :start_date, :date => true
71 validates :start_date, :date => true
72 validates :due_date, :date => true
72 validates :due_date, :date => true
73 validate :validate_issue, :validate_required_fields
73 validate :validate_issue, :validate_required_fields
74
74
75 scope :visible, lambda {|*args|
75 scope :visible, lambda {|*args|
76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
76 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
77 }
77 }
78
78
79 scope :open, lambda {|*args|
79 scope :open, lambda {|*args|
80 is_closed = args.size > 0 ? !args.first : false
80 is_closed = args.size > 0 ? !args.first : false
81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
81 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
82 }
82 }
83
83
84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
84 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
85 scope :on_active_project, lambda {
85 scope :on_active_project, lambda {
86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
86 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
87 }
87 }
88 scope :fixed_version, lambda {|versions|
88 scope :fixed_version, lambda {|versions|
89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
89 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
90 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
91 }
91 }
92
92
93 before_create :default_assign
93 before_create :default_assign
94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
94 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
95 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
96 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
97 # Should be after_create but would be called before previous after_save callbacks
97 # Should be after_create but would be called before previous after_save callbacks
98 after_save :after_create_from_copy
98 after_save :after_create_from_copy
99 after_destroy :update_parent_attributes
99 after_destroy :update_parent_attributes
100
100
101 # Returns a SQL conditions string used to find all issues visible by the specified user
101 # Returns a SQL conditions string used to find all issues visible by the specified user
102 def self.visible_condition(user, options={})
102 def self.visible_condition(user, options={})
103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
103 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
104 if user.logged?
104 if user.logged?
105 case role.issues_visibility
105 case role.issues_visibility
106 when 'all'
106 when 'all'
107 nil
107 nil
108 when 'default'
108 when 'default'
109 user_ids = [user.id] + user.groups.map(&:id)
109 user_ids = [user.id] + user.groups.map(&:id)
110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
110 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
111 when 'own'
111 when 'own'
112 user_ids = [user.id] + user.groups.map(&:id)
112 user_ids = [user.id] + user.groups.map(&:id)
113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
113 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
114 else
114 else
115 '1=0'
115 '1=0'
116 end
116 end
117 else
117 else
118 "(#{table_name}.is_private = #{connection.quoted_false})"
118 "(#{table_name}.is_private = #{connection.quoted_false})"
119 end
119 end
120 end
120 end
121 end
121 end
122
122
123 # Returns true if usr or current user is allowed to view the issue
123 # Returns true if usr or current user is allowed to view the issue
124 def visible?(usr=nil)
124 def visible?(usr=nil)
125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
125 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
126 if user.logged?
126 if user.logged?
127 case role.issues_visibility
127 case role.issues_visibility
128 when 'all'
128 when 'all'
129 true
129 true
130 when 'default'
130 when 'default'
131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
131 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
132 when 'own'
132 when 'own'
133 self.author == user || user.is_or_belongs_to?(assigned_to)
133 self.author == user || user.is_or_belongs_to?(assigned_to)
134 else
134 else
135 false
135 false
136 end
136 end
137 else
137 else
138 !self.is_private?
138 !self.is_private?
139 end
139 end
140 end
140 end
141 end
141 end
142
142
143 # Returns true if user or current user is allowed to edit or add a note to the issue
143 # Returns true if user or current user is allowed to edit or add a note to the issue
144 def editable?(user=User.current)
144 def editable?(user=User.current)
145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
145 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
146 end
146 end
147
147
148 def initialize(attributes=nil, *args)
148 def initialize(attributes=nil, *args)
149 super
149 super
150 if new_record?
150 if new_record?
151 # set default values for new records only
151 # set default values for new records only
152 self.status ||= IssueStatus.default
152 self.status ||= IssueStatus.default
153 self.priority ||= IssuePriority.default
153 self.priority ||= IssuePriority.default
154 self.watcher_user_ids = []
154 self.watcher_user_ids = []
155 end
155 end
156 end
156 end
157
157
158 def create_or_update
158 def create_or_update
159 super
159 super
160 ensure
160 ensure
161 @status_was = nil
161 @status_was = nil
162 end
162 end
163 private :create_or_update
163 private :create_or_update
164
164
165 # AR#Persistence#destroy would raise and RecordNotFound exception
165 # AR#Persistence#destroy would raise and RecordNotFound exception
166 # if the issue was already deleted or updated (non matching lock_version).
166 # if the issue was already deleted or updated (non matching lock_version).
167 # This is a problem when bulk deleting issues or deleting a project
167 # This is a problem when bulk deleting issues or deleting a project
168 # (because an issue may already be deleted if its parent was deleted
168 # (because an issue may already be deleted if its parent was deleted
169 # first).
169 # first).
170 # The issue is reloaded by the nested_set before being deleted so
170 # The issue is reloaded by the nested_set before being deleted so
171 # the lock_version condition should not be an issue but we handle it.
171 # the lock_version condition should not be an issue but we handle it.
172 def destroy
172 def destroy
173 super
173 super
174 rescue ActiveRecord::RecordNotFound
174 rescue ActiveRecord::RecordNotFound
175 # Stale or already deleted
175 # Stale or already deleted
176 begin
176 begin
177 reload
177 reload
178 rescue ActiveRecord::RecordNotFound
178 rescue ActiveRecord::RecordNotFound
179 # The issue was actually already deleted
179 # The issue was actually already deleted
180 @destroyed = true
180 @destroyed = true
181 return freeze
181 return freeze
182 end
182 end
183 # The issue was stale, retry to destroy
183 # The issue was stale, retry to destroy
184 super
184 super
185 end
185 end
186
186
187 alias :base_reload :reload
187 alias :base_reload :reload
188 def reload(*args)
188 def reload(*args)
189 @workflow_rule_by_attribute = nil
189 @workflow_rule_by_attribute = nil
190 @assignable_versions = nil
190 @assignable_versions = nil
191 @relations = nil
191 @relations = nil
192 base_reload(*args)
192 base_reload(*args)
193 end
193 end
194
194
195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
195 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
196 def available_custom_fields
196 def available_custom_fields
197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
197 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
198 end
198 end
199
199
200 # Copies attributes from another issue, arg can be an id or an Issue
200 # Copies attributes from another issue, arg can be an id or an Issue
201 def copy_from(arg, options={})
201 def copy_from(arg, options={})
202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
202 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
203 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
204 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
205 self.status = issue.status
205 self.status = issue.status
206 self.author = User.current
206 self.author = User.current
207 unless options[:attachments] == false
207 unless options[:attachments] == false
208 self.attachments = issue.attachments.map do |attachement|
208 self.attachments = issue.attachments.map do |attachement|
209 attachement.copy(:container => self)
209 attachement.copy(:container => self)
210 end
210 end
211 end
211 end
212 @copied_from = issue
212 @copied_from = issue
213 @copy_options = options
213 @copy_options = options
214 self
214 self
215 end
215 end
216
216
217 # Returns an unsaved copy of the issue
217 # Returns an unsaved copy of the issue
218 def copy(attributes=nil, copy_options={})
218 def copy(attributes=nil, copy_options={})
219 copy = self.class.new.copy_from(self, copy_options)
219 copy = self.class.new.copy_from(self, copy_options)
220 copy.attributes = attributes if attributes
220 copy.attributes = attributes if attributes
221 copy
221 copy
222 end
222 end
223
223
224 # Returns true if the issue is a copy
224 # Returns true if the issue is a copy
225 def copy?
225 def copy?
226 @copied_from.present?
226 @copied_from.present?
227 end
227 end
228
228
229 # Moves/copies an issue to a new project and tracker
229 # Moves/copies an issue to a new project and tracker
230 # Returns the moved/copied issue on success, false on failure
230 # Returns the moved/copied issue on success, false on failure
231 def move_to_project(new_project, new_tracker=nil, options={})
231 def move_to_project(new_project, new_tracker=nil, options={})
232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
232 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
233
233
234 if options[:copy]
234 if options[:copy]
235 issue = self.copy
235 issue = self.copy
236 else
236 else
237 issue = self
237 issue = self
238 end
238 end
239
239
240 issue.init_journal(User.current, options[:notes])
240 issue.init_journal(User.current, options[:notes])
241
241
242 # Preserve previous behaviour
242 # Preserve previous behaviour
243 # #move_to_project doesn't change tracker automatically
243 # #move_to_project doesn't change tracker automatically
244 issue.send :project=, new_project, true
244 issue.send :project=, new_project, true
245 if new_tracker
245 if new_tracker
246 issue.tracker = new_tracker
246 issue.tracker = new_tracker
247 end
247 end
248 # Allow bulk setting of attributes on the issue
248 # Allow bulk setting of attributes on the issue
249 if options[:attributes]
249 if options[:attributes]
250 issue.attributes = options[:attributes]
250 issue.attributes = options[:attributes]
251 end
251 end
252
252
253 issue.save ? issue : false
253 issue.save ? issue : false
254 end
254 end
255
255
256 def status_id=(sid)
256 def status_id=(sid)
257 self.status = nil
257 self.status = nil
258 result = write_attribute(:status_id, sid)
258 result = write_attribute(:status_id, sid)
259 @workflow_rule_by_attribute = nil
259 @workflow_rule_by_attribute = nil
260 result
260 result
261 end
261 end
262
262
263 def priority_id=(pid)
263 def priority_id=(pid)
264 self.priority = nil
264 self.priority = nil
265 write_attribute(:priority_id, pid)
265 write_attribute(:priority_id, pid)
266 end
266 end
267
267
268 def category_id=(cid)
268 def category_id=(cid)
269 self.category = nil
269 self.category = nil
270 write_attribute(:category_id, cid)
270 write_attribute(:category_id, cid)
271 end
271 end
272
272
273 def fixed_version_id=(vid)
273 def fixed_version_id=(vid)
274 self.fixed_version = nil
274 self.fixed_version = nil
275 write_attribute(:fixed_version_id, vid)
275 write_attribute(:fixed_version_id, vid)
276 end
276 end
277
277
278 def tracker_id=(tid)
278 def tracker_id=(tid)
279 self.tracker = nil
279 self.tracker = nil
280 result = write_attribute(:tracker_id, tid)
280 result = write_attribute(:tracker_id, tid)
281 @custom_field_values = nil
281 @custom_field_values = nil
282 @workflow_rule_by_attribute = nil
282 @workflow_rule_by_attribute = nil
283 result
283 result
284 end
284 end
285
285
286 def project_id=(project_id)
286 def project_id=(project_id)
287 if project_id.to_s != self.project_id.to_s
287 if project_id.to_s != self.project_id.to_s
288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
288 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
289 end
289 end
290 end
290 end
291
291
292 def project=(project, keep_tracker=false)
292 def project=(project, keep_tracker=false)
293 project_was = self.project
293 project_was = self.project
294 write_attribute(:project_id, project ? project.id : nil)
294 write_attribute(:project_id, project ? project.id : nil)
295 association_instance_set('project', project)
295 association_instance_set('project', project)
296 if project_was && project && project_was != project
296 if project_was && project && project_was != project
297 @assignable_versions = nil
297 @assignable_versions = nil
298
298
299 unless keep_tracker || project.trackers.include?(tracker)
299 unless keep_tracker || project.trackers.include?(tracker)
300 self.tracker = project.trackers.first
300 self.tracker = project.trackers.first
301 end
301 end
302 # Reassign to the category with same name if any
302 # Reassign to the category with same name if any
303 if category
303 if category
304 self.category = project.issue_categories.find_by_name(category.name)
304 self.category = project.issue_categories.find_by_name(category.name)
305 end
305 end
306 # Keep the fixed_version if it's still valid in the new_project
306 # Keep the fixed_version if it's still valid in the new_project
307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
307 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
308 self.fixed_version = nil
308 self.fixed_version = nil
309 end
309 end
310 # Clear the parent task if it's no longer valid
310 # Clear the parent task if it's no longer valid
311 unless valid_parent_project?
311 unless valid_parent_project?
312 self.parent_issue_id = nil
312 self.parent_issue_id = nil
313 end
313 end
314 @custom_field_values = nil
314 @custom_field_values = nil
315 end
315 end
316 end
316 end
317
317
318 def description=(arg)
318 def description=(arg)
319 if arg.is_a?(String)
319 if arg.is_a?(String)
320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
320 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
321 end
321 end
322 write_attribute(:description, arg)
322 write_attribute(:description, arg)
323 end
323 end
324
324
325 # Overrides assign_attributes so that project and tracker get assigned first
325 # Overrides assign_attributes so that project and tracker get assigned first
326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
326 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
327 return if new_attributes.nil?
327 return if new_attributes.nil?
328 attrs = new_attributes.dup
328 attrs = new_attributes.dup
329 attrs.stringify_keys!
329 attrs.stringify_keys!
330
330
331 %w(project project_id tracker tracker_id).each do |attr|
331 %w(project project_id tracker tracker_id).each do |attr|
332 if attrs.has_key?(attr)
332 if attrs.has_key?(attr)
333 send "#{attr}=", attrs.delete(attr)
333 send "#{attr}=", attrs.delete(attr)
334 end
334 end
335 end
335 end
336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
336 send :assign_attributes_without_project_and_tracker_first, attrs, *args
337 end
337 end
338 # Do not redefine alias chain on reload (see #4838)
338 # Do not redefine alias chain on reload (see #4838)
339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
339 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
340
340
341 def estimated_hours=(h)
341 def estimated_hours=(h)
342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
342 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
343 end
343 end
344
344
345 safe_attributes 'project_id',
345 safe_attributes 'project_id',
346 :if => lambda {|issue, user|
346 :if => lambda {|issue, user|
347 if issue.new_record?
347 if issue.new_record?
348 issue.copy?
348 issue.copy?
349 elsif user.allowed_to?(:move_issues, issue.project)
349 elsif user.allowed_to?(:move_issues, issue.project)
350 projects = Issue.allowed_target_projects_on_move(user)
350 projects = Issue.allowed_target_projects_on_move(user)
351 projects.include?(issue.project) && projects.size > 1
351 projects.include?(issue.project) && projects.size > 1
352 end
352 end
353 }
353 }
354
354
355 safe_attributes 'tracker_id',
355 safe_attributes 'tracker_id',
356 'status_id',
356 'status_id',
357 'category_id',
357 'category_id',
358 'assigned_to_id',
358 'assigned_to_id',
359 'priority_id',
359 'priority_id',
360 'fixed_version_id',
360 'fixed_version_id',
361 'subject',
361 'subject',
362 'description',
362 'description',
363 'start_date',
363 'start_date',
364 'due_date',
364 'due_date',
365 'done_ratio',
365 'done_ratio',
366 'estimated_hours',
366 'estimated_hours',
367 'custom_field_values',
367 'custom_field_values',
368 'custom_fields',
368 'custom_fields',
369 'lock_version',
369 'lock_version',
370 'notes',
370 'notes',
371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
371 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
372
372
373 safe_attributes 'status_id',
373 safe_attributes 'status_id',
374 'assigned_to_id',
374 'assigned_to_id',
375 'fixed_version_id',
375 'fixed_version_id',
376 'done_ratio',
376 'done_ratio',
377 'lock_version',
377 'lock_version',
378 'notes',
378 'notes',
379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
379 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
380
380
381 safe_attributes 'notes',
381 safe_attributes 'notes',
382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
382 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
383
383
384 safe_attributes 'private_notes',
384 safe_attributes 'private_notes',
385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
385 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
386
386
387 safe_attributes 'watcher_user_ids',
387 safe_attributes 'watcher_user_ids',
388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
388 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
389
389
390 safe_attributes 'is_private',
390 safe_attributes 'is_private',
391 :if => lambda {|issue, user|
391 :if => lambda {|issue, user|
392 user.allowed_to?(:set_issues_private, issue.project) ||
392 user.allowed_to?(:set_issues_private, issue.project) ||
393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
393 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
394 }
394 }
395
395
396 safe_attributes 'parent_issue_id',
396 safe_attributes 'parent_issue_id',
397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
397 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
398 user.allowed_to?(:manage_subtasks, issue.project)}
398 user.allowed_to?(:manage_subtasks, issue.project)}
399
399
400 def safe_attribute_names(user=nil)
400 def safe_attribute_names(user=nil)
401 names = super
401 names = super
402 names -= disabled_core_fields
402 names -= disabled_core_fields
403 names -= read_only_attribute_names(user)
403 names -= read_only_attribute_names(user)
404 names
404 names
405 end
405 end
406
406
407 # Safely sets attributes
407 # Safely sets attributes
408 # Should be called from controllers instead of #attributes=
408 # Should be called from controllers instead of #attributes=
409 # attr_accessible is too rough because we still want things like
409 # attr_accessible is too rough because we still want things like
410 # Issue.new(:project => foo) to work
410 # Issue.new(:project => foo) to work
411 def safe_attributes=(attrs, user=User.current)
411 def safe_attributes=(attrs, user=User.current)
412 return unless attrs.is_a?(Hash)
412 return unless attrs.is_a?(Hash)
413
413
414 attrs = attrs.dup
414 attrs = attrs.dup
415
415
416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
416 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
417 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
418 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
419 self.project_id = p
419 self.project_id = p
420 end
420 end
421 end
421 end
422
422
423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
423 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
424 self.tracker_id = t
424 self.tracker_id = t
425 end
425 end
426
426
427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
427 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
428 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
429 self.status_id = s
429 self.status_id = s
430 end
430 end
431 end
431 end
432
432
433 attrs = delete_unsafe_attributes(attrs, user)
433 attrs = delete_unsafe_attributes(attrs, user)
434 return if attrs.empty?
434 return if attrs.empty?
435
435
436 unless leaf?
436 unless leaf?
437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
437 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
438 end
438 end
439
439
440 if attrs['parent_issue_id'].present?
440 if attrs['parent_issue_id'].present?
441 s = attrs['parent_issue_id'].to_s
441 s = attrs['parent_issue_id'].to_s
442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
442 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
443 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
444 end
444 end
445 end
445 end
446
446
447 if attrs['custom_field_values'].present?
447 if attrs['custom_field_values'].present?
448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
448 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
449 end
449 end
450
450
451 if attrs['custom_fields'].present?
451 if attrs['custom_fields'].present?
452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
452 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
453 end
453 end
454
454
455 # mass-assignment security bypass
455 # mass-assignment security bypass
456 assign_attributes attrs, :without_protection => true
456 assign_attributes attrs, :without_protection => true
457 end
457 end
458
458
459 def disabled_core_fields
459 def disabled_core_fields
460 tracker ? tracker.disabled_core_fields : []
460 tracker ? tracker.disabled_core_fields : []
461 end
461 end
462
462
463 # Returns the custom_field_values that can be edited by the given user
463 # Returns the custom_field_values that can be edited by the given user
464 def editable_custom_field_values(user=nil)
464 def editable_custom_field_values(user=nil)
465 custom_field_values.reject do |value|
465 custom_field_values.reject do |value|
466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
466 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
467 end
467 end
468 end
468 end
469
469
470 # Returns the names of attributes that are read-only for user or the current user
470 # Returns the names of attributes that are read-only for user or the current user
471 # For users with multiple roles, the read-only fields are the intersection of
471 # For users with multiple roles, the read-only fields are the intersection of
472 # read-only fields of each role
472 # read-only fields of each role
473 # The result is an array of strings where sustom fields are represented with their ids
473 # The result is an array of strings where sustom fields are represented with their ids
474 #
474 #
475 # Examples:
475 # Examples:
476 # issue.read_only_attribute_names # => ['due_date', '2']
476 # issue.read_only_attribute_names # => ['due_date', '2']
477 # issue.read_only_attribute_names(user) # => []
477 # issue.read_only_attribute_names(user) # => []
478 def read_only_attribute_names(user=nil)
478 def read_only_attribute_names(user=nil)
479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
479 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
480 end
480 end
481
481
482 # Returns the names of required attributes for user or the current user
482 # Returns the names of required attributes for user or the current user
483 # For users with multiple roles, the required fields are the intersection of
483 # For users with multiple roles, the required fields are the intersection of
484 # required fields of each role
484 # required fields of each role
485 # The result is an array of strings where sustom fields are represented with their ids
485 # The result is an array of strings where sustom fields are represented with their ids
486 #
486 #
487 # Examples:
487 # Examples:
488 # issue.required_attribute_names # => ['due_date', '2']
488 # issue.required_attribute_names # => ['due_date', '2']
489 # issue.required_attribute_names(user) # => []
489 # issue.required_attribute_names(user) # => []
490 def required_attribute_names(user=nil)
490 def required_attribute_names(user=nil)
491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
491 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
492 end
492 end
493
493
494 # Returns true if the attribute is required for user
494 # Returns true if the attribute is required for user
495 def required_attribute?(name, user=nil)
495 def required_attribute?(name, user=nil)
496 required_attribute_names(user).include?(name.to_s)
496 required_attribute_names(user).include?(name.to_s)
497 end
497 end
498
498
499 # Returns a hash of the workflow rule by attribute for the given user
499 # Returns a hash of the workflow rule by attribute for the given user
500 #
500 #
501 # Examples:
501 # Examples:
502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
502 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
503 def workflow_rule_by_attribute(user=nil)
503 def workflow_rule_by_attribute(user=nil)
504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
504 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
505
505
506 user_real = user || User.current
506 user_real = user || User.current
507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
507 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
508 return {} if roles.empty?
508 return {} if roles.empty?
509
509
510 result = {}
510 result = {}
511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
511 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
512 if workflow_permissions.any?
512 if workflow_permissions.any?
513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
513 workflow_rules = workflow_permissions.inject({}) do |h, wp|
514 h[wp.field_name] ||= []
514 h[wp.field_name] ||= []
515 h[wp.field_name] << wp.rule
515 h[wp.field_name] << wp.rule
516 h
516 h
517 end
517 end
518 workflow_rules.each do |attr, rules|
518 workflow_rules.each do |attr, rules|
519 next if rules.size < roles.size
519 next if rules.size < roles.size
520 uniq_rules = rules.uniq
520 uniq_rules = rules.uniq
521 if uniq_rules.size == 1
521 if uniq_rules.size == 1
522 result[attr] = uniq_rules.first
522 result[attr] = uniq_rules.first
523 else
523 else
524 result[attr] = 'required'
524 result[attr] = 'required'
525 end
525 end
526 end
526 end
527 end
527 end
528 @workflow_rule_by_attribute = result if user.nil?
528 @workflow_rule_by_attribute = result if user.nil?
529 result
529 result
530 end
530 end
531 private :workflow_rule_by_attribute
531 private :workflow_rule_by_attribute
532
532
533 def done_ratio
533 def done_ratio
534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
534 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
535 status.default_done_ratio
535 status.default_done_ratio
536 else
536 else
537 read_attribute(:done_ratio)
537 read_attribute(:done_ratio)
538 end
538 end
539 end
539 end
540
540
541 def self.use_status_for_done_ratio?
541 def self.use_status_for_done_ratio?
542 Setting.issue_done_ratio == 'issue_status'
542 Setting.issue_done_ratio == 'issue_status'
543 end
543 end
544
544
545 def self.use_field_for_done_ratio?
545 def self.use_field_for_done_ratio?
546 Setting.issue_done_ratio == 'issue_field'
546 Setting.issue_done_ratio == 'issue_field'
547 end
547 end
548
548
549 def validate_issue
549 def validate_issue
550 if due_date && start_date && due_date < start_date
550 if due_date && start_date && due_date < start_date
551 errors.add :due_date, :greater_than_start_date
551 errors.add :due_date, :greater_than_start_date
552 end
552 end
553
553
554 if start_date && soonest_start && start_date < soonest_start
554 if start_date && soonest_start && start_date < soonest_start
555 errors.add :start_date, :invalid
555 errors.add :start_date, :invalid
556 end
556 end
557
557
558 if fixed_version
558 if fixed_version
559 if !assignable_versions.include?(fixed_version)
559 if !assignable_versions.include?(fixed_version)
560 errors.add :fixed_version_id, :inclusion
560 errors.add :fixed_version_id, :inclusion
561 elsif reopened? && fixed_version.closed?
561 elsif reopened? && fixed_version.closed?
562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
562 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
563 end
563 end
564 end
564 end
565
565
566 # Checks that the issue can not be added/moved to a disabled tracker
566 # Checks that the issue can not be added/moved to a disabled tracker
567 if project && (tracker_id_changed? || project_id_changed?)
567 if project && (tracker_id_changed? || project_id_changed?)
568 unless project.trackers.include?(tracker)
568 unless project.trackers.include?(tracker)
569 errors.add :tracker_id, :inclusion
569 errors.add :tracker_id, :inclusion
570 end
570 end
571 end
571 end
572
572
573 # Checks parent issue assignment
573 # Checks parent issue assignment
574 if @invalid_parent_issue_id.present?
574 if @invalid_parent_issue_id.present?
575 errors.add :parent_issue_id, :invalid
575 errors.add :parent_issue_id, :invalid
576 elsif @parent_issue
576 elsif @parent_issue
577 if !valid_parent_project?(@parent_issue)
577 if !valid_parent_project?(@parent_issue)
578 errors.add :parent_issue_id, :invalid
578 errors.add :parent_issue_id, :invalid
579 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
579 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
580 errors.add :parent_issue_id, :invalid
580 errors.add :parent_issue_id, :invalid
581 elsif !new_record?
581 elsif !new_record?
582 # moving an existing issue
582 # moving an existing issue
583 if @parent_issue.root_id != root_id
583 if @parent_issue.root_id != root_id
584 # we can always move to another tree
584 # we can always move to another tree
585 elsif move_possible?(@parent_issue)
585 elsif move_possible?(@parent_issue)
586 # move accepted inside tree
586 # move accepted inside tree
587 else
587 else
588 errors.add :parent_issue_id, :invalid
588 errors.add :parent_issue_id, :invalid
589 end
589 end
590 end
590 end
591 end
591 end
592 end
592 end
593
593
594 # Validates the issue against additional workflow requirements
594 # Validates the issue against additional workflow requirements
595 def validate_required_fields
595 def validate_required_fields
596 user = new_record? ? author : current_journal.try(:user)
596 user = new_record? ? author : current_journal.try(:user)
597
597
598 required_attribute_names(user).each do |attribute|
598 required_attribute_names(user).each do |attribute|
599 if attribute =~ /^\d+$/
599 if attribute =~ /^\d+$/
600 attribute = attribute.to_i
600 attribute = attribute.to_i
601 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
601 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
602 if v && v.value.blank?
602 if v && v.value.blank?
603 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
603 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
604 end
604 end
605 else
605 else
606 if respond_to?(attribute) && send(attribute).blank?
606 if respond_to?(attribute) && send(attribute).blank?
607 errors.add attribute, :blank
607 errors.add attribute, :blank
608 end
608 end
609 end
609 end
610 end
610 end
611 end
611 end
612
612
613 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
613 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
614 # even if the user turns off the setting later
614 # even if the user turns off the setting later
615 def update_done_ratio_from_issue_status
615 def update_done_ratio_from_issue_status
616 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
616 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
617 self.done_ratio = status.default_done_ratio
617 self.done_ratio = status.default_done_ratio
618 end
618 end
619 end
619 end
620
620
621 def init_journal(user, notes = "")
621 def init_journal(user, notes = "")
622 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
622 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
623 if new_record?
623 if new_record?
624 @current_journal.notify = false
624 @current_journal.notify = false
625 else
625 else
626 @attributes_before_change = attributes.dup
626 @attributes_before_change = attributes.dup
627 @custom_values_before_change = {}
627 @custom_values_before_change = {}
628 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
628 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
629 end
629 end
630 @current_journal
630 @current_journal
631 end
631 end
632
632
633 # Returns the id of the last journal or nil
633 # Returns the id of the last journal or nil
634 def last_journal_id
634 def last_journal_id
635 if new_record?
635 if new_record?
636 nil
636 nil
637 else
637 else
638 journals.maximum(:id)
638 journals.maximum(:id)
639 end
639 end
640 end
640 end
641
641
642 # Returns a scope for journals that have an id greater than journal_id
642 # Returns a scope for journals that have an id greater than journal_id
643 def journals_after(journal_id)
643 def journals_after(journal_id)
644 scope = journals.reorder("#{Journal.table_name}.id ASC")
644 scope = journals.reorder("#{Journal.table_name}.id ASC")
645 if journal_id.present?
645 if journal_id.present?
646 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
646 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
647 end
647 end
648 scope
648 scope
649 end
649 end
650
650
651 # Returns the initial status of the issue
651 # Returns the initial status of the issue
652 # Returns nil for a new issue
652 # Returns nil for a new issue
653 def status_was
653 def status_was
654 if status_id_was && status_id_was.to_i > 0
654 if status_id_was && status_id_was.to_i > 0
655 @status_was ||= IssueStatus.find_by_id(status_id_was)
655 @status_was ||= IssueStatus.find_by_id(status_id_was)
656 end
656 end
657 end
657 end
658
658
659 # Return true if the issue is closed, otherwise false
659 # Return true if the issue is closed, otherwise false
660 def closed?
660 def closed?
661 self.status.is_closed?
661 self.status.is_closed?
662 end
662 end
663
663
664 # Return true if the issue is being reopened
664 # Return true if the issue is being reopened
665 def reopened?
665 def reopened?
666 if !new_record? && status_id_changed?
666 if !new_record? && status_id_changed?
667 status_was = IssueStatus.find_by_id(status_id_was)
667 status_was = IssueStatus.find_by_id(status_id_was)
668 status_new = IssueStatus.find_by_id(status_id)
668 status_new = IssueStatus.find_by_id(status_id)
669 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
669 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
670 return true
670 return true
671 end
671 end
672 end
672 end
673 false
673 false
674 end
674 end
675
675
676 # Return true if the issue is being closed
676 # Return true if the issue is being closed
677 def closing?
677 def closing?
678 if !new_record? && status_id_changed?
678 if !new_record? && status_id_changed?
679 if status_was && status && !status_was.is_closed? && status.is_closed?
679 if status_was && status && !status_was.is_closed? && status.is_closed?
680 return true
680 return true
681 end
681 end
682 end
682 end
683 false
683 false
684 end
684 end
685
685
686 # Returns true if the issue is overdue
686 # Returns true if the issue is overdue
687 def overdue?
687 def overdue?
688 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
688 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
689 end
689 end
690
690
691 # Is the amount of work done less than it should for the due date
691 # Is the amount of work done less than it should for the due date
692 def behind_schedule?
692 def behind_schedule?
693 return false if start_date.nil? || due_date.nil?
693 return false if start_date.nil? || due_date.nil?
694 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
694 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
695 return done_date <= Date.today
695 return done_date <= Date.today
696 end
696 end
697
697
698 # Does this issue have children?
698 # Does this issue have children?
699 def children?
699 def children?
700 !leaf?
700 !leaf?
701 end
701 end
702
702
703 # Users the issue can be assigned to
703 # Users the issue can be assigned to
704 def assignable_users
704 def assignable_users
705 users = project.assignable_users
705 users = project.assignable_users
706 users << author if author
706 users << author if author
707 users << assigned_to if assigned_to
707 users << assigned_to if assigned_to
708 users.uniq.sort
708 users.uniq.sort
709 end
709 end
710
710
711 # Versions that the issue can be assigned to
711 # Versions that the issue can be assigned to
712 def assignable_versions
712 def assignable_versions
713 return @assignable_versions if @assignable_versions
713 return @assignable_versions if @assignable_versions
714
714
715 versions = project.shared_versions.open.all
715 versions = project.shared_versions.open.all
716 if fixed_version
716 if fixed_version
717 if fixed_version_id_changed?
717 if fixed_version_id_changed?
718 # nothing to do
718 # nothing to do
719 elsif project_id_changed?
719 elsif project_id_changed?
720 if project.shared_versions.include?(fixed_version)
720 if project.shared_versions.include?(fixed_version)
721 versions << fixed_version
721 versions << fixed_version
722 end
722 end
723 else
723 else
724 versions << fixed_version
724 versions << fixed_version
725 end
725 end
726 end
726 end
727 @assignable_versions = versions.uniq.sort
727 @assignable_versions = versions.uniq.sort
728 end
728 end
729
729
730 # Returns true if this issue is blocked by another issue that is still open
730 # Returns true if this issue is blocked by another issue that is still open
731 def blocked?
731 def blocked?
732 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
732 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
733 end
733 end
734
734
735 # Returns an array of statuses that user is able to apply
735 # Returns an array of statuses that user is able to apply
736 def new_statuses_allowed_to(user=User.current, include_default=false)
736 def new_statuses_allowed_to(user=User.current, include_default=false)
737 if new_record? && @copied_from
737 if new_record? && @copied_from
738 [IssueStatus.default, @copied_from.status].compact.uniq.sort
738 [IssueStatus.default, @copied_from.status].compact.uniq.sort
739 else
739 else
740 initial_status = nil
740 initial_status = nil
741 if new_record?
741 if new_record?
742 initial_status = IssueStatus.default
742 initial_status = IssueStatus.default
743 elsif status_id_was
743 elsif status_id_was
744 initial_status = IssueStatus.find_by_id(status_id_was)
744 initial_status = IssueStatus.find_by_id(status_id_was)
745 end
745 end
746 initial_status ||= status
746 initial_status ||= status
747
747
748 statuses = initial_status.find_new_statuses_allowed_to(
748 statuses = initial_status.find_new_statuses_allowed_to(
749 user.admin ? Role.all : user.roles_for_project(project),
749 user.admin ? Role.all : user.roles_for_project(project),
750 tracker,
750 tracker,
751 author == user,
751 author == user,
752 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
752 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
753 )
753 )
754 statuses << initial_status unless statuses.empty?
754 statuses << initial_status unless statuses.empty?
755 statuses << IssueStatus.default if include_default
755 statuses << IssueStatus.default if include_default
756 statuses = statuses.compact.uniq.sort
756 statuses = statuses.compact.uniq.sort
757 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
757 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
758 end
758 end
759 end
759 end
760
760
761 def assigned_to_was
761 def assigned_to_was
762 if assigned_to_id_changed? && assigned_to_id_was.present?
762 if assigned_to_id_changed? && assigned_to_id_was.present?
763 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
763 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
764 end
764 end
765 end
765 end
766
766
767 # Returns the users that should be notified
767 # Returns the users that should be notified
768 def notified_users
768 def notified_users
769 notified = []
769 notified = []
770 # Author and assignee are always notified unless they have been
770 # Author and assignee are always notified unless they have been
771 # locked or don't want to be notified
771 # locked or don't want to be notified
772 notified << author if author
772 notified << author if author
773 if assigned_to
773 if assigned_to
774 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
774 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
775 end
775 end
776 if assigned_to_was
776 if assigned_to_was
777 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
777 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
778 end
778 end
779 notified = notified.select {|u| u.active? && u.notify_about?(self)}
779 notified = notified.select {|u| u.active? && u.notify_about?(self)}
780
780
781 notified += project.notified_users
781 notified += project.notified_users
782 notified.uniq!
782 notified.uniq!
783 # Remove users that can not view the issue
783 # Remove users that can not view the issue
784 notified.reject! {|user| !visible?(user)}
784 notified.reject! {|user| !visible?(user)}
785 notified
785 notified
786 end
786 end
787
787
788 # Returns the email addresses that should be notified
788 # Returns the email addresses that should be notified
789 def recipients
789 def recipients
790 notified_users.collect(&:mail)
790 notified_users.collect(&:mail)
791 end
791 end
792
792
793 # Returns the number of hours spent on this issue
793 # Returns the number of hours spent on this issue
794 def spent_hours
794 def spent_hours
795 @spent_hours ||= time_entries.sum(:hours) || 0
795 @spent_hours ||= time_entries.sum(:hours) || 0
796 end
796 end
797
797
798 # Returns the total number of hours spent on this issue and its descendants
798 # Returns the total number of hours spent on this issue and its descendants
799 #
799 #
800 # Example:
800 # Example:
801 # spent_hours => 0.0
801 # spent_hours => 0.0
802 # spent_hours => 50.2
802 # spent_hours => 50.2
803 def total_spent_hours
803 def total_spent_hours
804 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
804 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
805 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
805 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
806 end
806 end
807
807
808 def relations
808 def relations
809 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
809 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
810 end
810 end
811
811
812 # Preloads relations for a collection of issues
812 # Preloads relations for a collection of issues
813 def self.load_relations(issues)
813 def self.load_relations(issues)
814 if issues.any?
814 if issues.any?
815 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
815 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
816 issues.each do |issue|
816 issues.each do |issue|
817 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
817 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
818 end
818 end
819 end
819 end
820 end
820 end
821
821
822 # Preloads visible spent time for a collection of issues
822 # Preloads visible spent time for a collection of issues
823 def self.load_visible_spent_hours(issues, user=User.current)
823 def self.load_visible_spent_hours(issues, user=User.current)
824 if issues.any?
824 if issues.any?
825 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
825 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
826 issues.each do |issue|
826 issues.each do |issue|
827 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
827 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
828 end
828 end
829 end
829 end
830 end
830 end
831
831
832 # Preloads visible relations for a collection of issues
832 # Preloads visible relations for a collection of issues
833 def self.load_visible_relations(issues, user=User.current)
833 def self.load_visible_relations(issues, user=User.current)
834 if issues.any?
834 if issues.any?
835 issue_ids = issues.map(&:id)
835 issue_ids = issues.map(&:id)
836 # Relations with issue_from in given issues and visible issue_to
836 # Relations with issue_from in given issues and visible issue_to
837 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
837 relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
838 # Relations with issue_to in given issues and visible issue_from
838 # Relations with issue_to in given issues and visible issue_from
839 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
839 relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
840
840
841 issues.each do |issue|
841 issues.each do |issue|
842 relations =
842 relations =
843 relations_from.select {|relation| relation.issue_from_id == issue.id} +
843 relations_from.select {|relation| relation.issue_from_id == issue.id} +
844 relations_to.select {|relation| relation.issue_to_id == issue.id}
844 relations_to.select {|relation| relation.issue_to_id == issue.id}
845
845
846 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
846 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
847 end
847 end
848 end
848 end
849 end
849 end
850
850
851 # Finds an issue relation given its id.
851 # Finds an issue relation given its id.
852 def find_relation(relation_id)
852 def find_relation(relation_id)
853 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
853 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
854 end
854 end
855
855
856 # Returns all the other issues that depend on the issue
856 def all_dependent_issues(except=[])
857 def all_dependent_issues(except=[])
857 except << self
858 except << self
858 dependencies = []
859 dependencies = []
859 relations_from.each do |relation|
860 dependencies += relations_from.map(&:issue_to)
860 if relation.issue_to && !except.include?(relation.issue_to)
861 dependencies += children unless leaf?
861 dependencies << relation.issue_to
862 dependencies << parent
862 dependencies += relation.issue_to.all_dependent_issues(except)
863 dependencies.compact!
863 end
864 dependencies -= except
864 end
865 dependencies + dependencies.map {|issue| issue.all_dependent_issues(except)}.flatten
865 unless leaf?
866 children.each do |child|
867 if !except.include?(child)
868 dependencies << child
869 dependencies += child.all_dependent_issues(except)
870 end
871 end
872 end
873 if parent && !except.include?(parent)
874 dependencies << parent
875 dependencies += parent.all_dependent_issues(except)
876 end
877 dependencies
878 end
866 end
879
867
880 # Returns an array of issues that duplicate this one
868 # Returns an array of issues that duplicate this one
881 def duplicates
869 def duplicates
882 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
870 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
883 end
871 end
884
872
885 # Returns the due date or the target due date if any
873 # Returns the due date or the target due date if any
886 # Used on gantt chart
874 # Used on gantt chart
887 def due_before
875 def due_before
888 due_date || (fixed_version ? fixed_version.effective_date : nil)
876 due_date || (fixed_version ? fixed_version.effective_date : nil)
889 end
877 end
890
878
891 # Returns the time scheduled for this issue.
879 # Returns the time scheduled for this issue.
892 #
880 #
893 # Example:
881 # Example:
894 # Start Date: 2/26/09, End Date: 3/04/09
882 # Start Date: 2/26/09, End Date: 3/04/09
895 # duration => 6
883 # duration => 6
896 def duration
884 def duration
897 (start_date && due_date) ? due_date - start_date : 0
885 (start_date && due_date) ? due_date - start_date : 0
898 end
886 end
899
887
900 # Returns the duration in working days
888 # Returns the duration in working days
901 def working_duration
889 def working_duration
902 (start_date && due_date) ? working_days(start_date, due_date) : 0
890 (start_date && due_date) ? working_days(start_date, due_date) : 0
903 end
891 end
904
892
905 def soonest_start(reload=false)
893 def soonest_start(reload=false)
906 @soonest_start = nil if reload
894 @soonest_start = nil if reload
907 @soonest_start ||= (
895 @soonest_start ||= (
908 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
896 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
909 [(@parent_issue || parent).try(:soonest_start)]
897 [(@parent_issue || parent).try(:soonest_start)]
910 ).compact.max
898 ).compact.max
911 end
899 end
912
900
913 # Sets start_date on the given date or the next working day
901 # Sets start_date on the given date or the next working day
914 # and changes due_date to keep the same working duration.
902 # and changes due_date to keep the same working duration.
915 def reschedule_on(date)
903 def reschedule_on(date)
916 wd = working_duration
904 wd = working_duration
917 date = next_working_date(date)
905 date = next_working_date(date)
918 self.start_date = date
906 self.start_date = date
919 self.due_date = add_working_days(date, wd)
907 self.due_date = add_working_days(date, wd)
920 end
908 end
921
909
922 # Reschedules the issue on the given date or the next working day and saves the record.
910 # Reschedules the issue on the given date or the next working day and saves the record.
923 # If the issue is a parent task, this is done by rescheduling its subtasks.
911 # If the issue is a parent task, this is done by rescheduling its subtasks.
924 def reschedule_on!(date)
912 def reschedule_on!(date)
925 return if date.nil?
913 return if date.nil?
926 if leaf?
914 if leaf?
927 if start_date.nil? || start_date != date
915 if start_date.nil? || start_date != date
928 if start_date && start_date > date
916 if start_date && start_date > date
929 # Issue can not be moved earlier than its soonest start date
917 # Issue can not be moved earlier than its soonest start date
930 date = [soonest_start(true), date].compact.max
918 date = [soonest_start(true), date].compact.max
931 end
919 end
932 reschedule_on(date)
920 reschedule_on(date)
933 begin
921 begin
934 save
922 save
935 rescue ActiveRecord::StaleObjectError
923 rescue ActiveRecord::StaleObjectError
936 reload
924 reload
937 reschedule_on(date)
925 reschedule_on(date)
938 save
926 save
939 end
927 end
940 end
928 end
941 else
929 else
942 leaves.each do |leaf|
930 leaves.each do |leaf|
943 if leaf.start_date
931 if leaf.start_date
944 # Only move subtask if it starts at the same date as the parent
932 # Only move subtask if it starts at the same date as the parent
945 # or if it starts before the given date
933 # or if it starts before the given date
946 if start_date == leaf.start_date || date > leaf.start_date
934 if start_date == leaf.start_date || date > leaf.start_date
947 leaf.reschedule_on!(date)
935 leaf.reschedule_on!(date)
948 end
936 end
949 else
937 else
950 leaf.reschedule_on!(date)
938 leaf.reschedule_on!(date)
951 end
939 end
952 end
940 end
953 end
941 end
954 end
942 end
955
943
956 def <=>(issue)
944 def <=>(issue)
957 if issue.nil?
945 if issue.nil?
958 -1
946 -1
959 elsif root_id != issue.root_id
947 elsif root_id != issue.root_id
960 (root_id || 0) <=> (issue.root_id || 0)
948 (root_id || 0) <=> (issue.root_id || 0)
961 else
949 else
962 (lft || 0) <=> (issue.lft || 0)
950 (lft || 0) <=> (issue.lft || 0)
963 end
951 end
964 end
952 end
965
953
966 def to_s
954 def to_s
967 "#{tracker} ##{id}: #{subject}"
955 "#{tracker} ##{id}: #{subject}"
968 end
956 end
969
957
970 # Returns a string of css classes that apply to the issue
958 # Returns a string of css classes that apply to the issue
971 def css_classes
959 def css_classes
972 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
960 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
973 s << ' closed' if closed?
961 s << ' closed' if closed?
974 s << ' overdue' if overdue?
962 s << ' overdue' if overdue?
975 s << ' child' if child?
963 s << ' child' if child?
976 s << ' parent' unless leaf?
964 s << ' parent' unless leaf?
977 s << ' private' if is_private?
965 s << ' private' if is_private?
978 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
966 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
979 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
967 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
980 s
968 s
981 end
969 end
982
970
983 # Saves an issue and a time_entry from the parameters
971 # Saves an issue and a time_entry from the parameters
984 def save_issue_with_child_records(params, existing_time_entry=nil)
972 def save_issue_with_child_records(params, existing_time_entry=nil)
985 Issue.transaction do
973 Issue.transaction do
986 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
974 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
987 @time_entry = existing_time_entry || TimeEntry.new
975 @time_entry = existing_time_entry || TimeEntry.new
988 @time_entry.project = project
976 @time_entry.project = project
989 @time_entry.issue = self
977 @time_entry.issue = self
990 @time_entry.user = User.current
978 @time_entry.user = User.current
991 @time_entry.spent_on = User.current.today
979 @time_entry.spent_on = User.current.today
992 @time_entry.attributes = params[:time_entry]
980 @time_entry.attributes = params[:time_entry]
993 self.time_entries << @time_entry
981 self.time_entries << @time_entry
994 end
982 end
995
983
996 # TODO: Rename hook
984 # TODO: Rename hook
997 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
985 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
998 if save
986 if save
999 # TODO: Rename hook
987 # TODO: Rename hook
1000 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
988 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
1001 else
989 else
1002 raise ActiveRecord::Rollback
990 raise ActiveRecord::Rollback
1003 end
991 end
1004 end
992 end
1005 end
993 end
1006
994
1007 # Unassigns issues from +version+ if it's no longer shared with issue's project
995 # Unassigns issues from +version+ if it's no longer shared with issue's project
1008 def self.update_versions_from_sharing_change(version)
996 def self.update_versions_from_sharing_change(version)
1009 # Update issues assigned to the version
997 # Update issues assigned to the version
1010 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
998 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1011 end
999 end
1012
1000
1013 # Unassigns issues from versions that are no longer shared
1001 # Unassigns issues from versions that are no longer shared
1014 # after +project+ was moved
1002 # after +project+ was moved
1015 def self.update_versions_from_hierarchy_change(project)
1003 def self.update_versions_from_hierarchy_change(project)
1016 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1004 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1017 # Update issues of the moved projects and issues assigned to a version of a moved project
1005 # Update issues of the moved projects and issues assigned to a version of a moved project
1018 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1006 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
1019 end
1007 end
1020
1008
1021 def parent_issue_id=(arg)
1009 def parent_issue_id=(arg)
1022 s = arg.to_s.strip.presence
1010 s = arg.to_s.strip.presence
1023 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1011 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1024 @parent_issue.id
1012 @parent_issue.id
1025 else
1013 else
1026 @parent_issue = nil
1014 @parent_issue = nil
1027 @invalid_parent_issue_id = arg
1015 @invalid_parent_issue_id = arg
1028 end
1016 end
1029 end
1017 end
1030
1018
1031 def parent_issue_id
1019 def parent_issue_id
1032 if @invalid_parent_issue_id
1020 if @invalid_parent_issue_id
1033 @invalid_parent_issue_id
1021 @invalid_parent_issue_id
1034 elsif instance_variable_defined? :@parent_issue
1022 elsif instance_variable_defined? :@parent_issue
1035 @parent_issue.nil? ? nil : @parent_issue.id
1023 @parent_issue.nil? ? nil : @parent_issue.id
1036 else
1024 else
1037 parent_id
1025 parent_id
1038 end
1026 end
1039 end
1027 end
1040
1028
1041 # Returns true if issue's project is a valid
1029 # Returns true if issue's project is a valid
1042 # parent issue project
1030 # parent issue project
1043 def valid_parent_project?(issue=parent)
1031 def valid_parent_project?(issue=parent)
1044 return true if issue.nil? || issue.project_id == project_id
1032 return true if issue.nil? || issue.project_id == project_id
1045
1033
1046 case Setting.cross_project_subtasks
1034 case Setting.cross_project_subtasks
1047 when 'system'
1035 when 'system'
1048 true
1036 true
1049 when 'tree'
1037 when 'tree'
1050 issue.project.root == project.root
1038 issue.project.root == project.root
1051 when 'hierarchy'
1039 when 'hierarchy'
1052 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1040 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1053 when 'descendants'
1041 when 'descendants'
1054 issue.project.is_or_is_ancestor_of?(project)
1042 issue.project.is_or_is_ancestor_of?(project)
1055 else
1043 else
1056 false
1044 false
1057 end
1045 end
1058 end
1046 end
1059
1047
1060 # Extracted from the ReportsController.
1048 # Extracted from the ReportsController.
1061 def self.by_tracker(project)
1049 def self.by_tracker(project)
1062 count_and_group_by(:project => project,
1050 count_and_group_by(:project => project,
1063 :field => 'tracker_id',
1051 :field => 'tracker_id',
1064 :joins => Tracker.table_name)
1052 :joins => Tracker.table_name)
1065 end
1053 end
1066
1054
1067 def self.by_version(project)
1055 def self.by_version(project)
1068 count_and_group_by(:project => project,
1056 count_and_group_by(:project => project,
1069 :field => 'fixed_version_id',
1057 :field => 'fixed_version_id',
1070 :joins => Version.table_name)
1058 :joins => Version.table_name)
1071 end
1059 end
1072
1060
1073 def self.by_priority(project)
1061 def self.by_priority(project)
1074 count_and_group_by(:project => project,
1062 count_and_group_by(:project => project,
1075 :field => 'priority_id',
1063 :field => 'priority_id',
1076 :joins => IssuePriority.table_name)
1064 :joins => IssuePriority.table_name)
1077 end
1065 end
1078
1066
1079 def self.by_category(project)
1067 def self.by_category(project)
1080 count_and_group_by(:project => project,
1068 count_and_group_by(:project => project,
1081 :field => 'category_id',
1069 :field => 'category_id',
1082 :joins => IssueCategory.table_name)
1070 :joins => IssueCategory.table_name)
1083 end
1071 end
1084
1072
1085 def self.by_assigned_to(project)
1073 def self.by_assigned_to(project)
1086 count_and_group_by(:project => project,
1074 count_and_group_by(:project => project,
1087 :field => 'assigned_to_id',
1075 :field => 'assigned_to_id',
1088 :joins => User.table_name)
1076 :joins => User.table_name)
1089 end
1077 end
1090
1078
1091 def self.by_author(project)
1079 def self.by_author(project)
1092 count_and_group_by(:project => project,
1080 count_and_group_by(:project => project,
1093 :field => 'author_id',
1081 :field => 'author_id',
1094 :joins => User.table_name)
1082 :joins => User.table_name)
1095 end
1083 end
1096
1084
1097 def self.by_subproject(project)
1085 def self.by_subproject(project)
1098 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1086 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1099 s.is_closed as closed,
1087 s.is_closed as closed,
1100 #{Issue.table_name}.project_id as project_id,
1088 #{Issue.table_name}.project_id as project_id,
1101 count(#{Issue.table_name}.id) as total
1089 count(#{Issue.table_name}.id) as total
1102 from
1090 from
1103 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1091 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
1104 where
1092 where
1105 #{Issue.table_name}.status_id=s.id
1093 #{Issue.table_name}.status_id=s.id
1106 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1094 and #{Issue.table_name}.project_id = #{Project.table_name}.id
1107 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1095 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
1108 and #{Issue.table_name}.project_id <> #{project.id}
1096 and #{Issue.table_name}.project_id <> #{project.id}
1109 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1097 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
1110 end
1098 end
1111 # End ReportsController extraction
1099 # End ReportsController extraction
1112
1100
1113 # Returns an array of projects that user can assign the issue to
1101 # Returns an array of projects that user can assign the issue to
1114 def allowed_target_projects(user=User.current)
1102 def allowed_target_projects(user=User.current)
1115 if new_record?
1103 if new_record?
1116 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1104 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
1117 else
1105 else
1118 self.class.allowed_target_projects_on_move(user)
1106 self.class.allowed_target_projects_on_move(user)
1119 end
1107 end
1120 end
1108 end
1121
1109
1122 # Returns an array of projects that user can move issues to
1110 # Returns an array of projects that user can move issues to
1123 def self.allowed_target_projects_on_move(user=User.current)
1111 def self.allowed_target_projects_on_move(user=User.current)
1124 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1112 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
1125 end
1113 end
1126
1114
1127 private
1115 private
1128
1116
1129 def after_project_change
1117 def after_project_change
1130 # Update project_id on related time entries
1118 # Update project_id on related time entries
1131 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1119 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
1132
1120
1133 # Delete issue relations
1121 # Delete issue relations
1134 unless Setting.cross_project_issue_relations?
1122 unless Setting.cross_project_issue_relations?
1135 relations_from.clear
1123 relations_from.clear
1136 relations_to.clear
1124 relations_to.clear
1137 end
1125 end
1138
1126
1139 # Move subtasks that were in the same project
1127 # Move subtasks that were in the same project
1140 children.each do |child|
1128 children.each do |child|
1141 next unless child.project_id == project_id_was
1129 next unless child.project_id == project_id_was
1142 # Change project and keep project
1130 # Change project and keep project
1143 child.send :project=, project, true
1131 child.send :project=, project, true
1144 unless child.save
1132 unless child.save
1145 raise ActiveRecord::Rollback
1133 raise ActiveRecord::Rollback
1146 end
1134 end
1147 end
1135 end
1148 end
1136 end
1149
1137
1150 # Callback for after the creation of an issue by copy
1138 # Callback for after the creation of an issue by copy
1151 # * adds a "copied to" relation with the copied issue
1139 # * adds a "copied to" relation with the copied issue
1152 # * copies subtasks from the copied issue
1140 # * copies subtasks from the copied issue
1153 def after_create_from_copy
1141 def after_create_from_copy
1154 return unless copy? && !@after_create_from_copy_handled
1142 return unless copy? && !@after_create_from_copy_handled
1155
1143
1156 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1144 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1157 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1145 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1158 unless relation.save
1146 unless relation.save
1159 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1147 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1160 end
1148 end
1161 end
1149 end
1162
1150
1163 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1151 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1164 copy_options = (@copy_options || {}).merge(:subtasks => false)
1152 copy_options = (@copy_options || {}).merge(:subtasks => false)
1165 copied_issue_ids = {@copied_from.id => self.id}
1153 copied_issue_ids = {@copied_from.id => self.id}
1166 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1154 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1167 # Do not copy self when copying an issue as a descendant of the copied issue
1155 # Do not copy self when copying an issue as a descendant of the copied issue
1168 next if child == self
1156 next if child == self
1169 # Do not copy subtasks of issues that were not copied
1157 # Do not copy subtasks of issues that were not copied
1170 next unless copied_issue_ids[child.parent_id]
1158 next unless copied_issue_ids[child.parent_id]
1171 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1159 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1172 unless child.visible?
1160 unless child.visible?
1173 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1161 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1174 next
1162 next
1175 end
1163 end
1176 copy = Issue.new.copy_from(child, copy_options)
1164 copy = Issue.new.copy_from(child, copy_options)
1177 copy.author = author
1165 copy.author = author
1178 copy.project = project
1166 copy.project = project
1179 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1167 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1180 unless copy.save
1168 unless copy.save
1181 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1169 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1182 next
1170 next
1183 end
1171 end
1184 copied_issue_ids[child.id] = copy.id
1172 copied_issue_ids[child.id] = copy.id
1185 end
1173 end
1186 end
1174 end
1187 @after_create_from_copy_handled = true
1175 @after_create_from_copy_handled = true
1188 end
1176 end
1189
1177
1190 def update_nested_set_attributes
1178 def update_nested_set_attributes
1191 if root_id.nil?
1179 if root_id.nil?
1192 # issue was just created
1180 # issue was just created
1193 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1181 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
1194 set_default_left_and_right
1182 set_default_left_and_right
1195 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1183 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
1196 if @parent_issue
1184 if @parent_issue
1197 move_to_child_of(@parent_issue)
1185 move_to_child_of(@parent_issue)
1198 end
1186 end
1199 elsif parent_issue_id != parent_id
1187 elsif parent_issue_id != parent_id
1200 former_parent_id = parent_id
1188 former_parent_id = parent_id
1201 # moving an existing issue
1189 # moving an existing issue
1202 if @parent_issue && @parent_issue.root_id == root_id
1190 if @parent_issue && @parent_issue.root_id == root_id
1203 # inside the same tree
1191 # inside the same tree
1204 move_to_child_of(@parent_issue)
1192 move_to_child_of(@parent_issue)
1205 else
1193 else
1206 # to another tree
1194 # to another tree
1207 unless root?
1195 unless root?
1208 move_to_right_of(root)
1196 move_to_right_of(root)
1209 end
1197 end
1210 old_root_id = root_id
1198 old_root_id = root_id
1211 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1199 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1212 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1200 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1213 offset = target_maxright + 1 - lft
1201 offset = target_maxright + 1 - lft
1214 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1202 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
1215 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1203 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1216 self[left_column_name] = lft + offset
1204 self[left_column_name] = lft + offset
1217 self[right_column_name] = rgt + offset
1205 self[right_column_name] = rgt + offset
1218 if @parent_issue
1206 if @parent_issue
1219 move_to_child_of(@parent_issue)
1207 move_to_child_of(@parent_issue)
1220 end
1208 end
1221 end
1209 end
1222 # delete invalid relations of all descendants
1210 # delete invalid relations of all descendants
1223 self_and_descendants.each do |issue|
1211 self_and_descendants.each do |issue|
1224 issue.relations.each do |relation|
1212 issue.relations.each do |relation|
1225 relation.destroy unless relation.valid?
1213 relation.destroy unless relation.valid?
1226 end
1214 end
1227 end
1215 end
1228 # update former parent
1216 # update former parent
1229 recalculate_attributes_for(former_parent_id) if former_parent_id
1217 recalculate_attributes_for(former_parent_id) if former_parent_id
1230 end
1218 end
1231 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1219 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1232 end
1220 end
1233
1221
1234 def update_parent_attributes
1222 def update_parent_attributes
1235 recalculate_attributes_for(parent_id) if parent_id
1223 recalculate_attributes_for(parent_id) if parent_id
1236 end
1224 end
1237
1225
1238 def recalculate_attributes_for(issue_id)
1226 def recalculate_attributes_for(issue_id)
1239 if issue_id && p = Issue.find_by_id(issue_id)
1227 if issue_id && p = Issue.find_by_id(issue_id)
1240 # priority = highest priority of children
1228 # priority = highest priority of children
1241 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1229 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1242 p.priority = IssuePriority.find_by_position(priority_position)
1230 p.priority = IssuePriority.find_by_position(priority_position)
1243 end
1231 end
1244
1232
1245 # start/due dates = lowest/highest dates of children
1233 # start/due dates = lowest/highest dates of children
1246 p.start_date = p.children.minimum(:start_date)
1234 p.start_date = p.children.minimum(:start_date)
1247 p.due_date = p.children.maximum(:due_date)
1235 p.due_date = p.children.maximum(:due_date)
1248 if p.start_date && p.due_date && p.due_date < p.start_date
1236 if p.start_date && p.due_date && p.due_date < p.start_date
1249 p.start_date, p.due_date = p.due_date, p.start_date
1237 p.start_date, p.due_date = p.due_date, p.start_date
1250 end
1238 end
1251
1239
1252 # done ratio = weighted average ratio of leaves
1240 # done ratio = weighted average ratio of leaves
1253 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1241 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1254 leaves_count = p.leaves.count
1242 leaves_count = p.leaves.count
1255 if leaves_count > 0
1243 if leaves_count > 0
1256 average = p.leaves.average(:estimated_hours).to_f
1244 average = p.leaves.average(:estimated_hours).to_f
1257 if average == 0
1245 if average == 0
1258 average = 1
1246 average = 1
1259 end
1247 end
1260 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1248 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1261 progress = done / (average * leaves_count)
1249 progress = done / (average * leaves_count)
1262 p.done_ratio = progress.round
1250 p.done_ratio = progress.round
1263 end
1251 end
1264 end
1252 end
1265
1253
1266 # estimate = sum of leaves estimates
1254 # estimate = sum of leaves estimates
1267 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1255 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1268 p.estimated_hours = nil if p.estimated_hours == 0.0
1256 p.estimated_hours = nil if p.estimated_hours == 0.0
1269
1257
1270 # ancestors will be recursively updated
1258 # ancestors will be recursively updated
1271 p.save(:validate => false)
1259 p.save(:validate => false)
1272 end
1260 end
1273 end
1261 end
1274
1262
1275 # Update issues so their versions are not pointing to a
1263 # Update issues so their versions are not pointing to a
1276 # fixed_version that is not shared with the issue's project
1264 # fixed_version that is not shared with the issue's project
1277 def self.update_versions(conditions=nil)
1265 def self.update_versions(conditions=nil)
1278 # Only need to update issues with a fixed_version from
1266 # Only need to update issues with a fixed_version from
1279 # a different project and that is not systemwide shared
1267 # a different project and that is not systemwide shared
1280 Issue.scoped(:conditions => conditions).all(
1268 Issue.scoped(:conditions => conditions).all(
1281 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1269 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1282 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1270 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1283 " AND #{Version.table_name}.sharing <> 'system'",
1271 " AND #{Version.table_name}.sharing <> 'system'",
1284 :include => [:project, :fixed_version]
1272 :include => [:project, :fixed_version]
1285 ).each do |issue|
1273 ).each do |issue|
1286 next if issue.project.nil? || issue.fixed_version.nil?
1274 next if issue.project.nil? || issue.fixed_version.nil?
1287 unless issue.project.shared_versions.include?(issue.fixed_version)
1275 unless issue.project.shared_versions.include?(issue.fixed_version)
1288 issue.init_journal(User.current)
1276 issue.init_journal(User.current)
1289 issue.fixed_version = nil
1277 issue.fixed_version = nil
1290 issue.save
1278 issue.save
1291 end
1279 end
1292 end
1280 end
1293 end
1281 end
1294
1282
1295 # Callback on file attachment
1283 # Callback on file attachment
1296 def attachment_added(obj)
1284 def attachment_added(obj)
1297 if @current_journal && !obj.new_record?
1285 if @current_journal && !obj.new_record?
1298 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1286 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1299 end
1287 end
1300 end
1288 end
1301
1289
1302 # Callback on attachment deletion
1290 # Callback on attachment deletion
1303 def attachment_removed(obj)
1291 def attachment_removed(obj)
1304 if @current_journal && !obj.new_record?
1292 if @current_journal && !obj.new_record?
1305 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1293 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1306 @current_journal.save
1294 @current_journal.save
1307 end
1295 end
1308 end
1296 end
1309
1297
1310 # Default assignment based on category
1298 # Default assignment based on category
1311 def default_assign
1299 def default_assign
1312 if assigned_to.nil? && category && category.assigned_to
1300 if assigned_to.nil? && category && category.assigned_to
1313 self.assigned_to = category.assigned_to
1301 self.assigned_to = category.assigned_to
1314 end
1302 end
1315 end
1303 end
1316
1304
1317 # Updates start/due dates of following issues
1305 # Updates start/due dates of following issues
1318 def reschedule_following_issues
1306 def reschedule_following_issues
1319 if start_date_changed? || due_date_changed?
1307 if start_date_changed? || due_date_changed?
1320 relations_from.each do |relation|
1308 relations_from.each do |relation|
1321 relation.set_issue_to_dates
1309 relation.set_issue_to_dates
1322 end
1310 end
1323 end
1311 end
1324 end
1312 end
1325
1313
1326 # Closes duplicates if the issue is being closed
1314 # Closes duplicates if the issue is being closed
1327 def close_duplicates
1315 def close_duplicates
1328 if closing?
1316 if closing?
1329 duplicates.each do |duplicate|
1317 duplicates.each do |duplicate|
1330 # Reload is need in case the duplicate was updated by a previous duplicate
1318 # Reload is need in case the duplicate was updated by a previous duplicate
1331 duplicate.reload
1319 duplicate.reload
1332 # Don't re-close it if it's already closed
1320 # Don't re-close it if it's already closed
1333 next if duplicate.closed?
1321 next if duplicate.closed?
1334 # Same user and notes
1322 # Same user and notes
1335 if @current_journal
1323 if @current_journal
1336 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1324 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1337 end
1325 end
1338 duplicate.update_attribute :status, self.status
1326 duplicate.update_attribute :status, self.status
1339 end
1327 end
1340 end
1328 end
1341 end
1329 end
1342
1330
1343 # Make sure updated_on is updated when adding a note and set updated_on now
1331 # Make sure updated_on is updated when adding a note and set updated_on now
1344 # so we can set closed_on with the same value on closing
1332 # so we can set closed_on with the same value on closing
1345 def force_updated_on_change
1333 def force_updated_on_change
1346 if @current_journal || changed?
1334 if @current_journal || changed?
1347 self.updated_on = current_time_from_proper_timezone
1335 self.updated_on = current_time_from_proper_timezone
1348 if new_record?
1336 if new_record?
1349 self.created_on = updated_on
1337 self.created_on = updated_on
1350 end
1338 end
1351 end
1339 end
1352 end
1340 end
1353
1341
1354 # Callback for setting closed_on when the issue is closed.
1342 # Callback for setting closed_on when the issue is closed.
1355 # The closed_on attribute stores the time of the last closing
1343 # The closed_on attribute stores the time of the last closing
1356 # and is preserved when the issue is reopened.
1344 # and is preserved when the issue is reopened.
1357 def update_closed_on
1345 def update_closed_on
1358 if closing? || (new_record? && closed?)
1346 if closing? || (new_record? && closed?)
1359 self.closed_on = updated_on
1347 self.closed_on = updated_on
1360 end
1348 end
1361 end
1349 end
1362
1350
1363 # Saves the changes in a Journal
1351 # Saves the changes in a Journal
1364 # Called after_save
1352 # Called after_save
1365 def create_journal
1353 def create_journal
1366 if @current_journal
1354 if @current_journal
1367 # attributes changes
1355 # attributes changes
1368 if @attributes_before_change
1356 if @attributes_before_change
1369 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1357 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
1370 before = @attributes_before_change[c]
1358 before = @attributes_before_change[c]
1371 after = send(c)
1359 after = send(c)
1372 next if before == after || (before.blank? && after.blank?)
1360 next if before == after || (before.blank? && after.blank?)
1373 @current_journal.details << JournalDetail.new(:property => 'attr',
1361 @current_journal.details << JournalDetail.new(:property => 'attr',
1374 :prop_key => c,
1362 :prop_key => c,
1375 :old_value => before,
1363 :old_value => before,
1376 :value => after)
1364 :value => after)
1377 }
1365 }
1378 end
1366 end
1379 if @custom_values_before_change
1367 if @custom_values_before_change
1380 # custom fields changes
1368 # custom fields changes
1381 custom_field_values.each {|c|
1369 custom_field_values.each {|c|
1382 before = @custom_values_before_change[c.custom_field_id]
1370 before = @custom_values_before_change[c.custom_field_id]
1383 after = c.value
1371 after = c.value
1384 next if before == after || (before.blank? && after.blank?)
1372 next if before == after || (before.blank? && after.blank?)
1385
1373
1386 if before.is_a?(Array) || after.is_a?(Array)
1374 if before.is_a?(Array) || after.is_a?(Array)
1387 before = [before] unless before.is_a?(Array)
1375 before = [before] unless before.is_a?(Array)
1388 after = [after] unless after.is_a?(Array)
1376 after = [after] unless after.is_a?(Array)
1389
1377
1390 # values removed
1378 # values removed
1391 (before - after).reject(&:blank?).each do |value|
1379 (before - after).reject(&:blank?).each do |value|
1392 @current_journal.details << JournalDetail.new(:property => 'cf',
1380 @current_journal.details << JournalDetail.new(:property => 'cf',
1393 :prop_key => c.custom_field_id,
1381 :prop_key => c.custom_field_id,
1394 :old_value => value,
1382 :old_value => value,
1395 :value => nil)
1383 :value => nil)
1396 end
1384 end
1397 # values added
1385 # values added
1398 (after - before).reject(&:blank?).each do |value|
1386 (after - before).reject(&:blank?).each do |value|
1399 @current_journal.details << JournalDetail.new(:property => 'cf',
1387 @current_journal.details << JournalDetail.new(:property => 'cf',
1400 :prop_key => c.custom_field_id,
1388 :prop_key => c.custom_field_id,
1401 :old_value => nil,
1389 :old_value => nil,
1402 :value => value)
1390 :value => value)
1403 end
1391 end
1404 else
1392 else
1405 @current_journal.details << JournalDetail.new(:property => 'cf',
1393 @current_journal.details << JournalDetail.new(:property => 'cf',
1406 :prop_key => c.custom_field_id,
1394 :prop_key => c.custom_field_id,
1407 :old_value => before,
1395 :old_value => before,
1408 :value => after)
1396 :value => after)
1409 end
1397 end
1410 }
1398 }
1411 end
1399 end
1412 @current_journal.save
1400 @current_journal.save
1413 # reset current journal
1401 # reset current journal
1414 init_journal @current_journal.user, @current_journal.notes
1402 init_journal @current_journal.user, @current_journal.notes
1415 end
1403 end
1416 end
1404 end
1417
1405
1418 # Query generator for selecting groups of issue counts for a project
1406 # Query generator for selecting groups of issue counts for a project
1419 # based on specific criteria
1407 # based on specific criteria
1420 #
1408 #
1421 # Options
1409 # Options
1422 # * project - Project to search in.
1410 # * project - Project to search in.
1423 # * field - String. Issue field to key off of in the grouping.
1411 # * field - String. Issue field to key off of in the grouping.
1424 # * joins - String. The table name to join against.
1412 # * joins - String. The table name to join against.
1425 def self.count_and_group_by(options)
1413 def self.count_and_group_by(options)
1426 project = options.delete(:project)
1414 project = options.delete(:project)
1427 select_field = options.delete(:field)
1415 select_field = options.delete(:field)
1428 joins = options.delete(:joins)
1416 joins = options.delete(:joins)
1429
1417
1430 where = "#{Issue.table_name}.#{select_field}=j.id"
1418 where = "#{Issue.table_name}.#{select_field}=j.id"
1431
1419
1432 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1420 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1433 s.is_closed as closed,
1421 s.is_closed as closed,
1434 j.id as #{select_field},
1422 j.id as #{select_field},
1435 count(#{Issue.table_name}.id) as total
1423 count(#{Issue.table_name}.id) as total
1436 from
1424 from
1437 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1425 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1438 where
1426 where
1439 #{Issue.table_name}.status_id=s.id
1427 #{Issue.table_name}.status_id=s.id
1440 and #{where}
1428 and #{where}
1441 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1429 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1442 and #{visible_condition(User.current, :project => project)}
1430 and #{visible_condition(User.current, :project => project)}
1443 group by s.id, s.is_closed, j.id")
1431 group by s.id, s.is_closed, j.id")
1444 end
1432 end
1445 end
1433 end
General Comments 0
You need to be logged in to leave comments. Login now