jro_apps/redmine Commit - r10758:24be0551ccd7

Code cleanup....

Jean-Philippe Lang -

r10758:24be0551ccd7

parent child

Context file:

r10758:24be0551ccd7

app/controllers/queries_controller.rb 0 -1

                 @queries = IssueQuery.visible.all(:limit => @limit, :offset => @offset, :order => "#{Query.table_name}.name")
                 respond_to do |format|
-                  format.html { render :nothing => true }
                   format.api
                 end
               end

app/controllers/workflows_controller.rb +1 -1

                 if request.post?
                   if params[:source_tracker_id].blank? || params[:source_role_id].blank? || (@source_tracker.nil? && @source_role.nil?)
                     flash.now[:error] = l(:error_workflow_copy_source)
-                  elsif @target_trackers.nil? || @target_roles.nil?
+                  elsif @target_trackers.blank? || @target_roles.blank?
                     flash.now[:error] = l(:error_workflow_copy_target)
                   else
                     WorkflowRule.copy(@source_tracker, @source_role, @target_trackers, @target_roles)

test/functional/messages_controller_test.rb +6 0

                 assert_template 'new'
               end
+              def test_get_new_with_invalid_board
+                @request.session[:user_id] = 2
+                get :new, :board_id => 99
+                assert_response 404
+              end
               def test_post_new
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear

test/functional/queries_controller_test.rb +6 0

                 User.current = nil
               end
+              def test_index
+                get :index
+                # HTML response not implemented
+                assert_response 406
+              end
               def test_new_project_query
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1

test/functional/workflows_controller_test.rb +20 0

@@ -297,6 +297,26 class WorkflowsControllerTest < ActionController::TestCase
297	assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 3)	297	assert_equal source_t3, status_transitions(:tracker_id => 3, :role_id => 3)
298	end	298	end
299		299
		300	def test_post_copy_with_incomplete_source_specification_should_fail
		301	assert_no_difference 'WorkflowRule.count' do
		302	post :copy,
		303	:source_tracker_id => '', :source_role_id => '2',
		304	:target_tracker_ids => ['2', '3'], :target_role_ids => ['1', '3']
		305	assert_response 200
		306	assert_select 'div.flash.error', :text => 'Please select a source tracker or role'
		307	end
		308	end
		309
		310	def test_post_copy_with_incomplete_target_specification_should_fail
		311	assert_no_difference 'WorkflowRule.count' do
		312	post :copy,
		313	:source_tracker_id => '1', :source_role_id => '2',
		314	:target_tracker_ids => ['2', '3']
		315	assert_response 200
		316	assert_select 'div.flash.error', :text => 'Please select target tracker(s) and role(s)'
		317	end
		318	end
		319
300	# Returns an array of status transitions that can be compared	320	# Returns an array of status transitions that can be compared
301	def status_transitions(conditions)	321	def status_transitions(conditions)
302	WorkflowTransition.	322	WorkflowTransition.

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages