##// END OF EJS Templates
Fixed assertion (#19368)....
Jean-Philippe Lang -
r13705:242eb5db5d70
parent child
Show More
@@ -1,699 +1,699
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2015 Jean-Philippe Lang
2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../../../test_helper', __FILE__)
18 require File.expand_path('../../../test_helper', __FILE__)
19
19
20 class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
20 class Redmine::ApiTest::IssuesTest < Redmine::ApiTest::Base
21 fixtures :projects,
21 fixtures :projects,
22 :users,
22 :users,
23 :roles,
23 :roles,
24 :members,
24 :members,
25 :member_roles,
25 :member_roles,
26 :issues,
26 :issues,
27 :issue_statuses,
27 :issue_statuses,
28 :issue_relations,
28 :issue_relations,
29 :versions,
29 :versions,
30 :trackers,
30 :trackers,
31 :projects_trackers,
31 :projects_trackers,
32 :issue_categories,
32 :issue_categories,
33 :enabled_modules,
33 :enabled_modules,
34 :enumerations,
34 :enumerations,
35 :attachments,
35 :attachments,
36 :workflows,
36 :workflows,
37 :custom_fields,
37 :custom_fields,
38 :custom_values,
38 :custom_values,
39 :custom_fields_projects,
39 :custom_fields_projects,
40 :custom_fields_trackers,
40 :custom_fields_trackers,
41 :time_entries,
41 :time_entries,
42 :journals,
42 :journals,
43 :journal_details,
43 :journal_details,
44 :queries,
44 :queries,
45 :attachments
45 :attachments
46
46
47 test "GET /issues.xml should contain metadata" do
47 test "GET /issues.xml should contain metadata" do
48 get '/issues.xml'
48 get '/issues.xml'
49 assert_select 'issues[type=array][total_count=?][limit="25"][offset="0"]',
49 assert_select 'issues[type=array][total_count=?][limit="25"][offset="0"]',
50 assigns(:issue_count).to_s
50 assigns(:issue_count).to_s
51 end
51 end
52
52
53 test "GET /issues.xml with nometa param should not contain metadata" do
53 test "GET /issues.xml with nometa param should not contain metadata" do
54 get '/issues.xml?nometa=1'
54 get '/issues.xml?nometa=1'
55 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
55 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
56 end
56 end
57
57
58 test "GET /issues.xml with nometa header should not contain metadata" do
58 test "GET /issues.xml with nometa header should not contain metadata" do
59 get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
59 get '/issues.xml', {}, {'X-Redmine-Nometa' => '1'}
60 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
60 assert_select 'issues[type=array]:not([total_count]):not([limit]):not([offset])'
61 end
61 end
62
62
63 test "GET /issues.xml with offset and limit" do
63 test "GET /issues.xml with offset and limit" do
64 get '/issues.xml?offset=2&limit=3'
64 get '/issues.xml?offset=2&limit=3'
65
65
66 assert_equal 3, assigns(:limit)
66 assert_equal 3, assigns(:limit)
67 assert_equal 2, assigns(:offset)
67 assert_equal 2, assigns(:offset)
68 assert_select 'issues issue', 3
68 assert_select 'issues issue', 3
69 end
69 end
70
70
71 test "GET /issues.xml with relations" do
71 test "GET /issues.xml with relations" do
72 get '/issues.xml?include=relations'
72 get '/issues.xml?include=relations'
73
73
74 assert_response :success
74 assert_response :success
75 assert_equal 'application/xml', @response.content_type
75 assert_equal 'application/xml', @response.content_type
76
76
77 assert_select 'issue id', :text => '3' do
77 assert_select 'issue id', :text => '3' do
78 assert_select '~ relations relation', 1
78 assert_select '~ relations relation', 1
79 assert_select '~ relations relation[id="2"][issue_id="2"][issue_to_id="3"][relation_type=relates]'
79 assert_select '~ relations relation[id="2"][issue_id="2"][issue_to_id="3"][relation_type=relates]'
80 end
80 end
81
81
82 assert_select 'issue id', :text => '1' do
82 assert_select 'issue id', :text => '1' do
83 assert_select '~ relations'
83 assert_select '~ relations'
84 assert_select '~ relations relation', 0
84 assert_select '~ relations relation', 0
85 end
85 end
86 end
86 end
87
87
88 test "GET /issues.xml with invalid query params" do
88 test "GET /issues.xml with invalid query params" do
89 get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
89 get '/issues.xml', {:f => ['start_date'], :op => {:start_date => '='}}
90
90
91 assert_response :unprocessable_entity
91 assert_response :unprocessable_entity
92 assert_equal 'application/xml', @response.content_type
92 assert_equal 'application/xml', @response.content_type
93 assert_select 'errors error', :text => "Start date cannot be blank"
93 assert_select 'errors error', :text => "Start date cannot be blank"
94 end
94 end
95
95
96 test "GET /issues.xml with custom field filter" do
96 test "GET /issues.xml with custom field filter" do
97 get '/issues.xml',
97 get '/issues.xml',
98 {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='}, :v => {:cf_1 => ['MySQL']}}
98 {:set_filter => 1, :f => ['cf_1'], :op => {:cf_1 => '='}, :v => {:cf_1 => ['MySQL']}}
99
99
100 expected_ids = Issue.visible.
100 expected_ids = Issue.visible.
101 joins(:custom_values).
101 joins(:custom_values).
102 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
102 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
103 assert expected_ids.any?
103 assert expected_ids.any?
104
104
105 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
105 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
106 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
106 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
107 end
107 end
108 end
108 end
109
109
110 test "GET /issues.xml with custom field filter (shorthand method)" do
110 test "GET /issues.xml with custom field filter (shorthand method)" do
111 get '/issues.xml', {:cf_1 => 'MySQL'}
111 get '/issues.xml', {:cf_1 => 'MySQL'}
112
112
113 expected_ids = Issue.visible.
113 expected_ids = Issue.visible.
114 joins(:custom_values).
114 joins(:custom_values).
115 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
115 where(:custom_values => {:custom_field_id => 1, :value => 'MySQL'}).map(&:id)
116 assert expected_ids.any?
116 assert expected_ids.any?
117
117
118 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
118 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
119 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
119 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
120 end
120 end
121 end
121 end
122
122
123 def test_index_should_include_issue_attributes
123 def test_index_should_include_issue_attributes
124 get '/issues.xml'
124 get '/issues.xml'
125 assert_select 'issues>issue>is_private', :text => 'false'
125 assert_select 'issues>issue>is_private', :text => 'false'
126 end
126 end
127
127
128 def test_index_should_allow_timestamp_filtering
128 def test_index_should_allow_timestamp_filtering
129 Issue.delete_all
129 Issue.delete_all
130 Issue.generate!(:subject => '1').update_column(:updated_on, Time.parse("2014-01-02T10:25:00Z"))
130 Issue.generate!(:subject => '1').update_column(:updated_on, Time.parse("2014-01-02T10:25:00Z"))
131 Issue.generate!(:subject => '2').update_column(:updated_on, Time.parse("2014-01-02T12:13:00Z"))
131 Issue.generate!(:subject => '2').update_column(:updated_on, Time.parse("2014-01-02T12:13:00Z"))
132
132
133 get '/issues.xml',
133 get '/issues.xml',
134 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '<='},
134 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '<='},
135 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
135 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
136 assert_select 'issues>issue', :count => 1
136 assert_select 'issues>issue', :count => 1
137 assert_select 'issues>issue>subject', :text => '1'
137 assert_select 'issues>issue>subject', :text => '1'
138
138
139 get '/issues.xml',
139 get '/issues.xml',
140 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
140 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
141 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
141 :v => {:updated_on => ['2014-01-02T12:00:00Z']}}
142 assert_select 'issues>issue', :count => 1
142 assert_select 'issues>issue', :count => 1
143 assert_select 'issues>issue>subject', :text => '2'
143 assert_select 'issues>issue>subject', :text => '2'
144
144
145 get '/issues.xml',
145 get '/issues.xml',
146 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
146 {:set_filter => 1, :f => ['updated_on'], :op => {:updated_on => '>='},
147 :v => {:updated_on => ['2014-01-02T08:00:00Z']}}
147 :v => {:updated_on => ['2014-01-02T08:00:00Z']}}
148 assert_select 'issues>issue', :count => 2
148 assert_select 'issues>issue', :count => 2
149 end
149 end
150
150
151 test "GET /issues.xml with filter" do
151 test "GET /issues.xml with filter" do
152 get '/issues.xml?status_id=5'
152 get '/issues.xml?status_id=5'
153
153
154 expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
154 expected_ids = Issue.visible.where(:status_id => 5).map(&:id)
155 assert expected_ids.any?
155 assert expected_ids.any?
156
156
157 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
157 assert_select 'issues > issue > id', :count => expected_ids.count do |ids|
158 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
158 ids.each { |id| assert expected_ids.delete(id.children.first.content.to_i) }
159 end
159 end
160 end
160 end
161
161
162 test "GET /issues.json with filter" do
162 test "GET /issues.json with filter" do
163 get '/issues.json?status_id=5'
163 get '/issues.json?status_id=5'
164
164
165 json = ActiveSupport::JSON.decode(response.body)
165 json = ActiveSupport::JSON.decode(response.body)
166 status_ids_used = json['issues'].collect {|j| j['status']['id'] }
166 status_ids_used = json['issues'].collect {|j| j['status']['id'] }
167 assert_equal 3, status_ids_used.length
167 assert_equal 3, status_ids_used.length
168 assert status_ids_used.all? {|id| id == 5 }
168 assert status_ids_used.all? {|id| id == 5 }
169 end
169 end
170
170
171 test "GET /issues/:id.xml with journals" do
171 test "GET /issues/:id.xml with journals" do
172 get '/issues/1.xml?include=journals'
172 get '/issues/1.xml?include=journals'
173
173
174 assert_select 'issue journals[type=array]' do
174 assert_select 'issue journals[type=array]' do
175 assert_select 'journal[id="1"]' do
175 assert_select 'journal[id="1"]' do
176 assert_select 'details[type=array]' do
176 assert_select 'details[type=array]' do
177 assert_select 'detail[name=status_id]' do
177 assert_select 'detail[name=status_id]' do
178 assert_select 'old_value', :text => '1'
178 assert_select 'old_value', :text => '1'
179 assert_select 'new_value', :text => '2'
179 assert_select 'new_value', :text => '2'
180 end
180 end
181 end
181 end
182 end
182 end
183 end
183 end
184 end
184 end
185
185
186 test "GET /issues/:id.xml with journals should format timestamps in ISO 8601" do
186 test "GET /issues/:id.xml with journals should format timestamps in ISO 8601" do
187 get '/issues/1.xml?include=journals'
187 get '/issues/1.xml?include=journals'
188
188
189 iso_date = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/
189 iso_date = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z$/
190 assert_select 'issue>created_on', :text => iso_date
190 assert_select 'issue>created_on', :text => iso_date
191 assert_select 'issue>updated_on', :text => iso_date
191 assert_select 'issue>updated_on', :text => iso_date
192 assert_select 'issue journal>created_on', :text => iso_date
192 assert_select 'issue journal>created_on', :text => iso_date
193 end
193 end
194
194
195 test "GET /issues/:id.xml with custom fields" do
195 test "GET /issues/:id.xml with custom fields" do
196 get '/issues/3.xml'
196 get '/issues/3.xml'
197
197
198 assert_select 'issue custom_fields[type=array]' do
198 assert_select 'issue custom_fields[type=array]' do
199 assert_select 'custom_field[id="1"]' do
199 assert_select 'custom_field[id="1"]' do
200 assert_select 'value', :text => 'MySQL'
200 assert_select 'value', :text => 'MySQL'
201 end
201 end
202 end
202 end
203 assert_nothing_raised do
203 assert_nothing_raised do
204 Hash.from_xml(response.body).to_xml
204 Hash.from_xml(response.body).to_xml
205 end
205 end
206 end
206 end
207
207
208 test "GET /issues/:id.xml with multi custom fields" do
208 test "GET /issues/:id.xml with multi custom fields" do
209 field = CustomField.find(1)
209 field = CustomField.find(1)
210 field.update_attribute :multiple, true
210 field.update_attribute :multiple, true
211 issue = Issue.find(3)
211 issue = Issue.find(3)
212 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
212 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
213 issue.save!
213 issue.save!
214
214
215 get '/issues/3.xml'
215 get '/issues/3.xml'
216 assert_response :success
216 assert_response :success
217
217
218 assert_select 'issue custom_fields[type=array]' do
218 assert_select 'issue custom_fields[type=array]' do
219 assert_select 'custom_field[id="1"]' do
219 assert_select 'custom_field[id="1"]' do
220 assert_select 'value[type=array] value', 2
220 assert_select 'value[type=array] value', 2
221 end
221 end
222 end
222 end
223 xml = Hash.from_xml(response.body)
223 xml = Hash.from_xml(response.body)
224 custom_fields = xml['issue']['custom_fields']
224 custom_fields = xml['issue']['custom_fields']
225 assert_kind_of Array, custom_fields
225 assert_kind_of Array, custom_fields
226 field = custom_fields.detect {|f| f['id'] == '1'}
226 field = custom_fields.detect {|f| f['id'] == '1'}
227 assert_kind_of Hash, field
227 assert_kind_of Hash, field
228 assert_equal ['MySQL', 'Oracle'], field['value'].sort
228 assert_equal ['MySQL', 'Oracle'], field['value'].sort
229 end
229 end
230
230
231 test "GET /issues/:id.json with multi custom fields" do
231 test "GET /issues/:id.json with multi custom fields" do
232 field = CustomField.find(1)
232 field = CustomField.find(1)
233 field.update_attribute :multiple, true
233 field.update_attribute :multiple, true
234 issue = Issue.find(3)
234 issue = Issue.find(3)
235 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
235 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
236 issue.save!
236 issue.save!
237
237
238 get '/issues/3.json'
238 get '/issues/3.json'
239 assert_response :success
239 assert_response :success
240
240
241 json = ActiveSupport::JSON.decode(response.body)
241 json = ActiveSupport::JSON.decode(response.body)
242 custom_fields = json['issue']['custom_fields']
242 custom_fields = json['issue']['custom_fields']
243 assert_kind_of Array, custom_fields
243 assert_kind_of Array, custom_fields
244 field = custom_fields.detect {|f| f['id'] == 1}
244 field = custom_fields.detect {|f| f['id'] == 1}
245 assert_kind_of Hash, field
245 assert_kind_of Hash, field
246 assert_equal ['MySQL', 'Oracle'], field['value'].sort
246 assert_equal ['MySQL', 'Oracle'], field['value'].sort
247 end
247 end
248
248
249 test "GET /issues/:id.xml with empty value for multi custom field" do
249 test "GET /issues/:id.xml with empty value for multi custom field" do
250 field = CustomField.find(1)
250 field = CustomField.find(1)
251 field.update_attribute :multiple, true
251 field.update_attribute :multiple, true
252 issue = Issue.find(3)
252 issue = Issue.find(3)
253 issue.custom_field_values = {1 => ['']}
253 issue.custom_field_values = {1 => ['']}
254 issue.save!
254 issue.save!
255
255
256 get '/issues/3.xml'
256 get '/issues/3.xml'
257
257
258 assert_select 'issue custom_fields[type=array]' do
258 assert_select 'issue custom_fields[type=array]' do
259 assert_select 'custom_field[id="1"]' do
259 assert_select 'custom_field[id="1"]' do
260 assert_select 'value[type=array]:empty'
260 assert_select 'value[type=array]:empty'
261 end
261 end
262 end
262 end
263 xml = Hash.from_xml(response.body)
263 xml = Hash.from_xml(response.body)
264 custom_fields = xml['issue']['custom_fields']
264 custom_fields = xml['issue']['custom_fields']
265 assert_kind_of Array, custom_fields
265 assert_kind_of Array, custom_fields
266 field = custom_fields.detect {|f| f['id'] == '1'}
266 field = custom_fields.detect {|f| f['id'] == '1'}
267 assert_kind_of Hash, field
267 assert_kind_of Hash, field
268 assert_equal [], field['value']
268 assert_equal [], field['value']
269 end
269 end
270
270
271 test "GET /issues/:id.json with empty value for multi custom field" do
271 test "GET /issues/:id.json with empty value for multi custom field" do
272 field = CustomField.find(1)
272 field = CustomField.find(1)
273 field.update_attribute :multiple, true
273 field.update_attribute :multiple, true
274 issue = Issue.find(3)
274 issue = Issue.find(3)
275 issue.custom_field_values = {1 => ['']}
275 issue.custom_field_values = {1 => ['']}
276 issue.save!
276 issue.save!
277
277
278 get '/issues/3.json'
278 get '/issues/3.json'
279 assert_response :success
279 assert_response :success
280 json = ActiveSupport::JSON.decode(response.body)
280 json = ActiveSupport::JSON.decode(response.body)
281 custom_fields = json['issue']['custom_fields']
281 custom_fields = json['issue']['custom_fields']
282 assert_kind_of Array, custom_fields
282 assert_kind_of Array, custom_fields
283 field = custom_fields.detect {|f| f['id'] == 1}
283 field = custom_fields.detect {|f| f['id'] == 1}
284 assert_kind_of Hash, field
284 assert_kind_of Hash, field
285 assert_equal [], field['value'].sort
285 assert_equal [], field['value'].sort
286 end
286 end
287
287
288 test "GET /issues/:id.xml with attachments" do
288 test "GET /issues/:id.xml with attachments" do
289 get '/issues/3.xml?include=attachments'
289 get '/issues/3.xml?include=attachments'
290
290
291 assert_select 'issue attachments[type=array]' do
291 assert_select 'issue attachments[type=array]' do
292 assert_select 'attachment', 4
292 assert_select 'attachment', 4
293 assert_select 'attachment id', :text => '1' do
293 assert_select 'attachment id', :text => '1' do
294 assert_select '~ filename', :text => 'error281.txt'
294 assert_select '~ filename', :text => 'error281.txt'
295 assert_select '~ content_url', :text => 'http://www.example.com/attachments/download/1/error281.txt'
295 assert_select '~ content_url', :text => 'http://www.example.com/attachments/download/1/error281.txt'
296 end
296 end
297 end
297 end
298 end
298 end
299
299
300 test "GET /issues/:id.xml with subtasks" do
300 test "GET /issues/:id.xml with subtasks" do
301 issue = Issue.generate_with_descendants!(:project_id => 1)
301 issue = Issue.generate_with_descendants!(:project_id => 1)
302 get "/issues/#{issue.id}.xml?include=children"
302 get "/issues/#{issue.id}.xml?include=children"
303
303
304 assert_select 'issue id', :text => issue.id.to_s do
304 assert_select 'issue id', :text => issue.id.to_s do
305 assert_select '~ children[type=array] > issue', 2
305 assert_select '~ children[type=array] > issue', 2
306 assert_select '~ children[type=array] > issue > children', 1
306 assert_select '~ children[type=array] > issue > children', 1
307 end
307 end
308 end
308 end
309
309
310 test "GET /issues/:id.json with subtasks" do
310 test "GET /issues/:id.json with subtasks" do
311 issue = Issue.generate_with_descendants!(:project_id => 1)
311 issue = Issue.generate_with_descendants!(:project_id => 1)
312 get "/issues/#{issue.id}.json?include=children"
312 get "/issues/#{issue.id}.json?include=children"
313
313
314 json = ActiveSupport::JSON.decode(response.body)
314 json = ActiveSupport::JSON.decode(response.body)
315 assert_equal 2, json['issue']['children'].size
315 assert_equal 2, json['issue']['children'].size
316 assert_equal 1, json['issue']['children'].select {|child| child.key?('children')}.size
316 assert_equal 1, json['issue']['children'].select {|child| child.key?('children')}.size
317 end
317 end
318
318
319 def test_show_should_include_issue_attributes
319 def test_show_should_include_issue_attributes
320 get '/issues/1.xml'
320 get '/issues/1.xml'
321 assert_select 'issue>is_private', :text => 'false'
321 assert_select 'issue>is_private', :text => 'false'
322 end
322 end
323
323
324 test "GET /issues/:id.xml?include=watchers should include watchers" do
324 test "GET /issues/:id.xml?include=watchers should include watchers" do
325 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
325 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
326
326
327 get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
327 get '/issues/1.xml?include=watchers', {}, credentials('jsmith')
328
328
329 assert_response :ok
329 assert_response :ok
330 assert_equal 'application/xml', response.content_type
330 assert_equal 'application/xml', response.content_type
331 assert_select 'issue' do
331 assert_select 'issue' do
332 assert_select 'watchers', Issue.find(1).watchers.count
332 assert_select 'watchers', Issue.find(1).watchers.count
333 assert_select 'watchers' do
333 assert_select 'watchers' do
334 assert_select 'user[id="3"]'
334 assert_select 'user[id="3"]'
335 end
335 end
336 end
336 end
337 end
337 end
338
338
339 test "POST /issues.xml should create an issue with the attributes" do
339 test "POST /issues.xml should create an issue with the attributes" do
340
340
341 payload = <<-XML
341 payload = <<-XML
342 <?xml version="1.0" encoding="UTF-8" ?>
342 <?xml version="1.0" encoding="UTF-8" ?>
343 <issue>
343 <issue>
344 <project_id>1</project_id>
344 <project_id>1</project_id>
345 <tracker_id>2</tracker_id>
345 <tracker_id>2</tracker_id>
346 <status_id>3</status_id>
346 <status_id>3</status_id>
347 <subject>API test</subject>
347 <subject>API test</subject>
348 </issue>
348 </issue>
349 XML
349 XML
350
350
351 assert_difference('Issue.count') do
351 assert_difference('Issue.count') do
352 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
352 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
353 end
353 end
354 issue = Issue.order('id DESC').first
354 issue = Issue.order('id DESC').first
355 assert_equal 1, issue.project_id
355 assert_equal 1, issue.project_id
356 assert_equal 2, issue.tracker_id
356 assert_equal 2, issue.tracker_id
357 assert_equal 3, issue.status_id
357 assert_equal 3, issue.status_id
358 assert_equal 'API test', issue.subject
358 assert_equal 'API test', issue.subject
359
359
360 assert_response :created
360 assert_response :created
361 assert_equal 'application/xml', @response.content_type
361 assert_equal 'application/xml', @response.content_type
362 assert_select 'issue > id', :text => issue.id.to_s
362 assert_select 'issue > id', :text => issue.id.to_s
363 end
363 end
364
364
365 test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
365 test "POST /issues.xml with watcher_user_ids should create issue with watchers" do
366 assert_difference('Issue.count') do
366 assert_difference('Issue.count') do
367 post '/issues.xml',
367 post '/issues.xml',
368 {:issue => {:project_id => 1, :subject => 'Watchers',
368 {:issue => {:project_id => 1, :subject => 'Watchers',
369 :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
369 :tracker_id => 2, :status_id => 3, :watcher_user_ids => [3, 1]}}, credentials('jsmith')
370 assert_response :created
370 assert_response :created
371 end
371 end
372 issue = Issue.order('id desc').first
372 issue = Issue.order('id desc').first
373 assert_equal 2, issue.watchers.size
373 assert_equal 2, issue.watchers.size
374 assert_equal [1, 3], issue.watcher_user_ids.sort
374 assert_equal [1, 3], issue.watcher_user_ids.sort
375 end
375 end
376
376
377 test "POST /issues.xml with failure should return errors" do
377 test "POST /issues.xml with failure should return errors" do
378 assert_no_difference('Issue.count') do
378 assert_no_difference('Issue.count') do
379 post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
379 post '/issues.xml', {:issue => {:project_id => 1}}, credentials('jsmith')
380 end
380 end
381
381
382 assert_select 'errors error', :text => "Subject cannot be blank"
382 assert_select 'errors error', :text => "Subject cannot be blank"
383 end
383 end
384
384
385 test "POST /issues.json should create an issue with the attributes" do
385 test "POST /issues.json should create an issue with the attributes" do
386
386
387 payload = <<-JSON
387 payload = <<-JSON
388 {
388 {
389 "issue": {
389 "issue": {
390 "project_id": "1",
390 "project_id": "1",
391 "tracker_id": "2",
391 "tracker_id": "2",
392 "status_id": "3",
392 "status_id": "3",
393 "subject": "API test"
393 "subject": "API test"
394 }
394 }
395 }
395 }
396 JSON
396 JSON
397
397
398 assert_difference('Issue.count') do
398 assert_difference('Issue.count') do
399 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
399 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
400 end
400 end
401
401
402 issue = Issue.order('id DESC').first
402 issue = Issue.order('id DESC').first
403 assert_equal 1, issue.project_id
403 assert_equal 1, issue.project_id
404 assert_equal 2, issue.tracker_id
404 assert_equal 2, issue.tracker_id
405 assert_equal 3, issue.status_id
405 assert_equal 3, issue.status_id
406 assert_equal 'API test', issue.subject
406 assert_equal 'API test', issue.subject
407 end
407 end
408
408
409 test "POST /issues.json without tracker_id should accept custom fields" do
409 test "POST /issues.json without tracker_id should accept custom fields" do
410 field = IssueCustomField.generate!(
410 field = IssueCustomField.generate!(
411 :field_format => 'list',
411 :field_format => 'list',
412 :multiple => true,
412 :multiple => true,
413 :possible_values => ["V1", "V2", "V3"],
413 :possible_values => ["V1", "V2", "V3"],
414 :default_value => "V2",
414 :default_value => "V2",
415 :is_for_all => true,
415 :is_for_all => true,
416 :trackers => Tracker.all.to_a
416 :trackers => Tracker.all.to_a
417 )
417 )
418
418
419 payload = <<-JSON
419 payload = <<-JSON
420 {
420 {
421 "issue": {
421 "issue": {
422 "project_id": "1",
422 "project_id": "1",
423 "subject": "Multivalued custom field",
423 "subject": "Multivalued custom field",
424 "custom_field_values":{"#{field.id}":["V1","V3"]}
424 "custom_field_values":{"#{field.id}":["V1","V3"]}
425 }
425 }
426 }
426 }
427 JSON
427 JSON
428
428
429 assert_difference('Issue.count') do
429 assert_difference('Issue.count') do
430 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
430 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
431 end
431 end
432
432
433 assert_response :created
433 assert_response :created
434 issue = Issue.order('id DESC').first
434 issue = Issue.order('id DESC').first
435 assert_equal ["V1", "V3"], issue.custom_field_value(field)
435 assert_equal ["V1", "V3"], issue.custom_field_value(field).sort
436 end
436 end
437
437
438 test "POST /issues.json with failure should return errors" do
438 test "POST /issues.json with failure should return errors" do
439 assert_no_difference('Issue.count') do
439 assert_no_difference('Issue.count') do
440 post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
440 post '/issues.json', {:issue => {:project_id => 1}}, credentials('jsmith')
441 end
441 end
442
442
443 json = ActiveSupport::JSON.decode(response.body)
443 json = ActiveSupport::JSON.decode(response.body)
444 assert json['errors'].include?("Subject cannot be blank")
444 assert json['errors'].include?("Subject cannot be blank")
445 end
445 end
446
446
447 test "PUT /issues/:id.xml" do
447 test "PUT /issues/:id.xml" do
448 assert_difference('Journal.count') do
448 assert_difference('Journal.count') do
449 put '/issues/6.xml',
449 put '/issues/6.xml',
450 {:issue => {:subject => 'API update', :notes => 'A new note'}},
450 {:issue => {:subject => 'API update', :notes => 'A new note'}},
451 credentials('jsmith')
451 credentials('jsmith')
452 end
452 end
453
453
454 issue = Issue.find(6)
454 issue = Issue.find(6)
455 assert_equal "API update", issue.subject
455 assert_equal "API update", issue.subject
456 journal = Journal.last
456 journal = Journal.last
457 assert_equal "A new note", journal.notes
457 assert_equal "A new note", journal.notes
458 end
458 end
459
459
460 test "PUT /issues/:id.xml with custom fields" do
460 test "PUT /issues/:id.xml with custom fields" do
461 put '/issues/3.xml',
461 put '/issues/3.xml',
462 {:issue => {:custom_fields => [
462 {:issue => {:custom_fields => [
463 {'id' => '1', 'value' => 'PostgreSQL' },
463 {'id' => '1', 'value' => 'PostgreSQL' },
464 {'id' => '2', 'value' => '150'}
464 {'id' => '2', 'value' => '150'}
465 ]}},
465 ]}},
466 credentials('jsmith')
466 credentials('jsmith')
467
467
468 issue = Issue.find(3)
468 issue = Issue.find(3)
469 assert_equal '150', issue.custom_value_for(2).value
469 assert_equal '150', issue.custom_value_for(2).value
470 assert_equal 'PostgreSQL', issue.custom_value_for(1).value
470 assert_equal 'PostgreSQL', issue.custom_value_for(1).value
471 end
471 end
472
472
473 test "PUT /issues/:id.xml with multi custom fields" do
473 test "PUT /issues/:id.xml with multi custom fields" do
474 field = CustomField.find(1)
474 field = CustomField.find(1)
475 field.update_attribute :multiple, true
475 field.update_attribute :multiple, true
476
476
477 put '/issues/3.xml',
477 put '/issues/3.xml',
478 {:issue => {:custom_fields => [
478 {:issue => {:custom_fields => [
479 {'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
479 {'id' => '1', 'value' => ['MySQL', 'PostgreSQL'] },
480 {'id' => '2', 'value' => '150'}
480 {'id' => '2', 'value' => '150'}
481 ]}},
481 ]}},
482 credentials('jsmith')
482 credentials('jsmith')
483
483
484 issue = Issue.find(3)
484 issue = Issue.find(3)
485 assert_equal '150', issue.custom_value_for(2).value
485 assert_equal '150', issue.custom_value_for(2).value
486 assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
486 assert_equal ['MySQL', 'PostgreSQL'], issue.custom_field_value(1).sort
487 end
487 end
488
488
489 test "PUT /issues/:id.xml with project change" do
489 test "PUT /issues/:id.xml with project change" do
490 put '/issues/3.xml',
490 put '/issues/3.xml',
491 {:issue => {:project_id => 2, :subject => 'Project changed'}},
491 {:issue => {:project_id => 2, :subject => 'Project changed'}},
492 credentials('jsmith')
492 credentials('jsmith')
493
493
494 issue = Issue.find(3)
494 issue = Issue.find(3)
495 assert_equal 2, issue.project_id
495 assert_equal 2, issue.project_id
496 assert_equal 'Project changed', issue.subject
496 assert_equal 'Project changed', issue.subject
497 end
497 end
498
498
499 test "PUT /issues/:id.xml with notes only" do
499 test "PUT /issues/:id.xml with notes only" do
500 assert_difference('Journal.count') do
500 assert_difference('Journal.count') do
501 put '/issues/6.xml',
501 put '/issues/6.xml',
502 {:issue => {:notes => 'Notes only'}},
502 {:issue => {:notes => 'Notes only'}},
503 credentials('jsmith')
503 credentials('jsmith')
504 end
504 end
505
505
506 journal = Journal.last
506 journal = Journal.last
507 assert_equal "Notes only", journal.notes
507 assert_equal "Notes only", journal.notes
508 end
508 end
509
509
510 test "PUT /issues/:id.xml with failed update" do
510 test "PUT /issues/:id.xml with failed update" do
511 put '/issues/6.xml', {:issue => {:subject => ''}}, credentials('jsmith')
511 put '/issues/6.xml', {:issue => {:subject => ''}}, credentials('jsmith')
512
512
513 assert_response :unprocessable_entity
513 assert_response :unprocessable_entity
514 assert_select 'errors error', :text => "Subject cannot be blank"
514 assert_select 'errors error', :text => "Subject cannot be blank"
515 end
515 end
516
516
517 test "PUT /issues/:id.json" do
517 test "PUT /issues/:id.json" do
518 assert_difference('Journal.count') do
518 assert_difference('Journal.count') do
519 put '/issues/6.json',
519 put '/issues/6.json',
520 {:issue => {:subject => 'API update', :notes => 'A new note'}},
520 {:issue => {:subject => 'API update', :notes => 'A new note'}},
521 credentials('jsmith')
521 credentials('jsmith')
522
522
523 assert_response :ok
523 assert_response :ok
524 assert_equal '', response.body
524 assert_equal '', response.body
525 end
525 end
526
526
527 issue = Issue.find(6)
527 issue = Issue.find(6)
528 assert_equal "API update", issue.subject
528 assert_equal "API update", issue.subject
529 journal = Journal.last
529 journal = Journal.last
530 assert_equal "A new note", journal.notes
530 assert_equal "A new note", journal.notes
531 end
531 end
532
532
533 test "PUT /issues/:id.json with failed update" do
533 test "PUT /issues/:id.json with failed update" do
534 put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
534 put '/issues/6.json', {:issue => {:subject => ''}}, credentials('jsmith')
535
535
536 assert_response :unprocessable_entity
536 assert_response :unprocessable_entity
537 json = ActiveSupport::JSON.decode(response.body)
537 json = ActiveSupport::JSON.decode(response.body)
538 assert json['errors'].include?("Subject cannot be blank")
538 assert json['errors'].include?("Subject cannot be blank")
539 end
539 end
540
540
541 test "DELETE /issues/:id.xml" do
541 test "DELETE /issues/:id.xml" do
542 assert_difference('Issue.count', -1) do
542 assert_difference('Issue.count', -1) do
543 delete '/issues/6.xml', {}, credentials('jsmith')
543 delete '/issues/6.xml', {}, credentials('jsmith')
544
544
545 assert_response :ok
545 assert_response :ok
546 assert_equal '', response.body
546 assert_equal '', response.body
547 end
547 end
548 assert_nil Issue.find_by_id(6)
548 assert_nil Issue.find_by_id(6)
549 end
549 end
550
550
551 test "DELETE /issues/:id.json" do
551 test "DELETE /issues/:id.json" do
552 assert_difference('Issue.count', -1) do
552 assert_difference('Issue.count', -1) do
553 delete '/issues/6.json', {}, credentials('jsmith')
553 delete '/issues/6.json', {}, credentials('jsmith')
554
554
555 assert_response :ok
555 assert_response :ok
556 assert_equal '', response.body
556 assert_equal '', response.body
557 end
557 end
558 assert_nil Issue.find_by_id(6)
558 assert_nil Issue.find_by_id(6)
559 end
559 end
560
560
561 test "POST /issues/:id/watchers.xml should add watcher" do
561 test "POST /issues/:id/watchers.xml should add watcher" do
562 assert_difference 'Watcher.count' do
562 assert_difference 'Watcher.count' do
563 post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
563 post '/issues/1/watchers.xml', {:user_id => 3}, credentials('jsmith')
564
564
565 assert_response :ok
565 assert_response :ok
566 assert_equal '', response.body
566 assert_equal '', response.body
567 end
567 end
568 watcher = Watcher.order('id desc').first
568 watcher = Watcher.order('id desc').first
569 assert_equal Issue.find(1), watcher.watchable
569 assert_equal Issue.find(1), watcher.watchable
570 assert_equal User.find(3), watcher.user
570 assert_equal User.find(3), watcher.user
571 end
571 end
572
572
573 test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
573 test "DELETE /issues/:id/watchers/:user_id.xml should remove watcher" do
574 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
574 Watcher.create!(:user_id => 3, :watchable => Issue.find(1))
575
575
576 assert_difference 'Watcher.count', -1 do
576 assert_difference 'Watcher.count', -1 do
577 delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
577 delete '/issues/1/watchers/3.xml', {}, credentials('jsmith')
578
578
579 assert_response :ok
579 assert_response :ok
580 assert_equal '', response.body
580 assert_equal '', response.body
581 end
581 end
582 assert_equal false, Issue.find(1).watched_by?(User.find(3))
582 assert_equal false, Issue.find(1).watched_by?(User.find(3))
583 end
583 end
584
584
585 def test_create_issue_with_uploaded_file
585 def test_create_issue_with_uploaded_file
586 token = xml_upload('test_create_with_upload', credentials('jsmith'))
586 token = xml_upload('test_create_with_upload', credentials('jsmith'))
587 attachment = Attachment.find_by_token(token)
587 attachment = Attachment.find_by_token(token)
588
588
589 # create the issue with the upload's token
589 # create the issue with the upload's token
590 assert_difference 'Issue.count' do
590 assert_difference 'Issue.count' do
591 post '/issues.xml',
591 post '/issues.xml',
592 {:issue => {:project_id => 1, :subject => 'Uploaded file',
592 {:issue => {:project_id => 1, :subject => 'Uploaded file',
593 :uploads => [{:token => token, :filename => 'test.txt',
593 :uploads => [{:token => token, :filename => 'test.txt',
594 :content_type => 'text/plain'}]}},
594 :content_type => 'text/plain'}]}},
595 credentials('jsmith')
595 credentials('jsmith')
596 assert_response :created
596 assert_response :created
597 end
597 end
598 issue = Issue.order('id DESC').first
598 issue = Issue.order('id DESC').first
599 assert_equal 1, issue.attachments.count
599 assert_equal 1, issue.attachments.count
600 assert_equal attachment, issue.attachments.first
600 assert_equal attachment, issue.attachments.first
601
601
602 attachment.reload
602 attachment.reload
603 assert_equal 'test.txt', attachment.filename
603 assert_equal 'test.txt', attachment.filename
604 assert_equal 'text/plain', attachment.content_type
604 assert_equal 'text/plain', attachment.content_type
605 assert_equal 'test_create_with_upload'.size, attachment.filesize
605 assert_equal 'test_create_with_upload'.size, attachment.filesize
606 assert_equal 2, attachment.author_id
606 assert_equal 2, attachment.author_id
607
607
608 # get the issue with its attachments
608 # get the issue with its attachments
609 get "/issues/#{issue.id}.xml", :include => 'attachments'
609 get "/issues/#{issue.id}.xml", :include => 'attachments'
610 assert_response :success
610 assert_response :success
611 xml = Hash.from_xml(response.body)
611 xml = Hash.from_xml(response.body)
612 attachments = xml['issue']['attachments']
612 attachments = xml['issue']['attachments']
613 assert_kind_of Array, attachments
613 assert_kind_of Array, attachments
614 assert_equal 1, attachments.size
614 assert_equal 1, attachments.size
615 url = attachments.first['content_url']
615 url = attachments.first['content_url']
616 assert_not_nil url
616 assert_not_nil url
617
617
618 # download the attachment
618 # download the attachment
619 get url
619 get url
620 assert_response :success
620 assert_response :success
621 assert_equal 'test_create_with_upload', response.body
621 assert_equal 'test_create_with_upload', response.body
622 end
622 end
623
623
624 def test_create_issue_with_multiple_uploaded_files_as_xml
624 def test_create_issue_with_multiple_uploaded_files_as_xml
625 token1 = xml_upload('File content 1', credentials('jsmith'))
625 token1 = xml_upload('File content 1', credentials('jsmith'))
626 token2 = xml_upload('File content 2', credentials('jsmith'))
626 token2 = xml_upload('File content 2', credentials('jsmith'))
627
627
628 payload = <<-XML
628 payload = <<-XML
629 <?xml version="1.0" encoding="UTF-8" ?>
629 <?xml version="1.0" encoding="UTF-8" ?>
630 <issue>
630 <issue>
631 <project_id>1</project_id>
631 <project_id>1</project_id>
632 <tracker_id>1</tracker_id>
632 <tracker_id>1</tracker_id>
633 <subject>Issue with multiple attachments</subject>
633 <subject>Issue with multiple attachments</subject>
634 <uploads type="array">
634 <uploads type="array">
635 <upload>
635 <upload>
636 <token>#{token1}</token>
636 <token>#{token1}</token>
637 <filename>test1.txt</filename>
637 <filename>test1.txt</filename>
638 </upload>
638 </upload>
639 <upload>
639 <upload>
640 <token>#{token2}</token>
640 <token>#{token2}</token>
641 <filename>test1.txt</filename>
641 <filename>test1.txt</filename>
642 </upload>
642 </upload>
643 </uploads>
643 </uploads>
644 </issue>
644 </issue>
645 XML
645 XML
646
646
647 assert_difference 'Issue.count' do
647 assert_difference 'Issue.count' do
648 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
648 post '/issues.xml', payload, {"CONTENT_TYPE" => 'application/xml'}.merge(credentials('jsmith'))
649 assert_response :created
649 assert_response :created
650 end
650 end
651 issue = Issue.order('id DESC').first
651 issue = Issue.order('id DESC').first
652 assert_equal 2, issue.attachments.count
652 assert_equal 2, issue.attachments.count
653 end
653 end
654
654
655 def test_create_issue_with_multiple_uploaded_files_as_json
655 def test_create_issue_with_multiple_uploaded_files_as_json
656 token1 = json_upload('File content 1', credentials('jsmith'))
656 token1 = json_upload('File content 1', credentials('jsmith'))
657 token2 = json_upload('File content 2', credentials('jsmith'))
657 token2 = json_upload('File content 2', credentials('jsmith'))
658
658
659 payload = <<-JSON
659 payload = <<-JSON
660 {
660 {
661 "issue": {
661 "issue": {
662 "project_id": "1",
662 "project_id": "1",
663 "tracker_id": "1",
663 "tracker_id": "1",
664 "subject": "Issue with multiple attachments",
664 "subject": "Issue with multiple attachments",
665 "uploads": [
665 "uploads": [
666 {"token": "#{token1}", "filename": "test1.txt"},
666 {"token": "#{token1}", "filename": "test1.txt"},
667 {"token": "#{token2}", "filename": "test2.txt"}
667 {"token": "#{token2}", "filename": "test2.txt"}
668 ]
668 ]
669 }
669 }
670 }
670 }
671 JSON
671 JSON
672
672
673 assert_difference 'Issue.count' do
673 assert_difference 'Issue.count' do
674 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
674 post '/issues.json', payload, {"CONTENT_TYPE" => 'application/json'}.merge(credentials('jsmith'))
675 assert_response :created
675 assert_response :created
676 end
676 end
677 issue = Issue.order('id DESC').first
677 issue = Issue.order('id DESC').first
678 assert_equal 2, issue.attachments.count
678 assert_equal 2, issue.attachments.count
679 end
679 end
680
680
681 def test_update_issue_with_uploaded_file
681 def test_update_issue_with_uploaded_file
682 token = xml_upload('test_upload_with_upload', credentials('jsmith'))
682 token = xml_upload('test_upload_with_upload', credentials('jsmith'))
683 attachment = Attachment.find_by_token(token)
683 attachment = Attachment.find_by_token(token)
684
684
685 # update the issue with the upload's token
685 # update the issue with the upload's token
686 assert_difference 'Journal.count' do
686 assert_difference 'Journal.count' do
687 put '/issues/1.xml',
687 put '/issues/1.xml',
688 {:issue => {:notes => 'Attachment added',
688 {:issue => {:notes => 'Attachment added',
689 :uploads => [{:token => token, :filename => 'test.txt',
689 :uploads => [{:token => token, :filename => 'test.txt',
690 :content_type => 'text/plain'}]}},
690 :content_type => 'text/plain'}]}},
691 credentials('jsmith')
691 credentials('jsmith')
692 assert_response :ok
692 assert_response :ok
693 assert_equal '', @response.body
693 assert_equal '', @response.body
694 end
694 end
695
695
696 issue = Issue.find(1)
696 issue = Issue.find(1)
697 assert_include attachment, issue.attachments
697 assert_include attachment, issue.attachments
698 end
698 end
699 end
699 end
General Comments 0
You need to be logged in to leave comments. Login now