##// END OF EJS Templates
jro_apps » redmine
RSS
Fixed MissingFeatureException: let user choose to copy attachments or not when bulk copying issues....
Jean-Philippe Lang -
r9271:231282ddcb73
parent child
Show More
Side by Side Unified
Context file:
r9271:231282ddcb73 Loading diff...:

The requested changes are too big and content was truncated. Show full diff

Show file before | Show file after | Hide comments
@@ -1,439 +1,442
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 24 before_filter :find_project, :only => [:new, :create]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
29 29 accept_rss_auth :index, :show
30 30 accept_api_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 47 helper :repositories
48 48 include RepositoriesHelper
49 49 helper :sort
50 50 include SortHelper
51 51 include IssuesHelper
52 52 helper :timelog
53 53 helper :gantt
54 54 include Redmine::Export::PDF
55 55
56 56 def index
57 57 retrieve_query
58 58 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
59 59 sort_update(@query.sortable_columns)
60 60
61 61 if @query.valid?
62 62 case params[:format]
63 63 when 'csv', 'pdf'
64 64 @limit = Setting.issues_export_limit.to_i
65 65 when 'atom'
66 66 @limit = Setting.feeds_limit.to_i
67 67 when 'xml', 'json'
68 68 @offset, @limit = api_offset_and_limit
69 69 else
70 70 @limit = per_page_option
71 71 end
72 72
73 73 @issue_count = @query.issue_count
74 74 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
75 75 @offset ||= @issue_pages.current.offset
76 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
77 77 :order => sort_clause,
78 78 :offset => @offset,
79 79 :limit => @limit)
80 80 @issue_count_by_group = @query.issue_count_by_group
81 81
82 82 respond_to do |format|
83 83 format.html { render :template => 'issues/index', :layout => !request.xhr? }
84 84 format.api {
85 85 Issue.load_relations(@issues) if include_in_api_response?('relations')
86 86 }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
90 90 end
91 91 else
92 92 respond_to do |format|
93 93 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
94 94 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
95 95 format.api { render_validation_errors(@query) }
96 96 end
97 97 end
98 98 rescue ActiveRecord::RecordNotFound
99 99 render_404
100 100 end
101 101
102 102 def show
103 103 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
104 104 @journals.each_with_index {|j,i| j.indice = i+1}
105 105 @journals.reverse! if User.current.wants_comments_in_reverse_order?
106 106
107 107 @changesets = @issue.changesets.visible.all
108 108 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
109 109
110 110 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
111 111 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
112 112 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
113 113 @priorities = IssuePriority.active
114 114 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
115 115 respond_to do |format|
116 116 format.html {
117 117 retrieve_previous_and_next_issue_ids
118 118 render :template => 'issues/show'
119 119 }
120 120 format.api
121 121 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
122 122 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
123 123 end
124 124 end
125 125
126 126 # Add a new issue
127 127 # The new issue will be created from an existing one if copy_from parameter is given
128 128 def new
129 129 respond_to do |format|
130 130 format.html { render :action => 'new', :layout => !request.xhr? }
131 131 format.js {
132 132 render(:update) { |page|
133 133 if params[:project_change]
134 134 page.replace_html 'all_attributes', :partial => 'form'
135 135 else
136 136 page.replace_html 'attributes', :partial => 'attributes'
137 137 end
138 138 m = User.current.allowed_to?(:log_time, @issue.project) ? 'show' : 'hide'
139 139 page << "if ($('log_time')) {Element.#{m}('log_time');}"
140 140 }
141 141 }
142 142 end
143 143 end
144 144
145 145 def create
146 146 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
147 147 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
148 148 if @issue.save
149 149 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
150 150 respond_to do |format|
151 151 format.html {
152 152 render_attachment_warning_if_needed(@issue)
153 153 flash[:notice] = l(:notice_issue_successful_create, :id => "<a href='#{issue_path(@issue)}'>##{@issue.id}</a>")
154 154 redirect_to(params[:continue] ? { :action => 'new', :project_id => @issue.project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
155 155 { :action => 'show', :id => @issue })
156 156 }
157 157 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
158 158 end
159 159 return
160 160 else
161 161 respond_to do |format|
162 162 format.html { render :action => 'new' }
163 163 format.api { render_validation_errors(@issue) }
164 164 end
165 165 end
166 166 end
167 167
168 168 def edit
169 169 return unless update_issue_from_params
170 170
171 171 respond_to do |format|
172 172 format.html { }
173 173 format.xml { }
174 174 end
175 175 end
176 176
177 177 def update
178 178 return unless update_issue_from_params
179 179 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
180 180 saved = false
181 181 begin
182 182 saved = @issue.save_issue_with_child_records(params, @time_entry)
183 183 rescue ActiveRecord::StaleObjectError
184 184 @conflict = true
185 185 if params[:last_journal_id]
186 186 if params[:last_journal_id].present?
187 187 last_journal_id = params[:last_journal_id].to_i
188 188 @conflict_journals = @issue.journals.all(:conditions => ["#{Journal.table_name}.id > ?", last_journal_id])
189 189 else
190 190 @conflict_journals = @issue.journals.all
191 191 end
192 192 end
193 193 end
194 194
195 195 if saved
196 196 render_attachment_warning_if_needed(@issue)
197 197 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
198 198
199 199 respond_to do |format|
200 200 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
201 201 format.api { head :ok }
202 202 end
203 203 else
204 204 respond_to do |format|
205 205 format.html { render :action => 'edit' }
206 206 format.api { render_validation_errors(@issue) }
207 207 end
208 208 end
209 209 end
210 210
211 211 # Bulk edit/copy a set of issues
212 212 def bulk_edit
213 213 @issues.sort!
214 214 @copy = params[:copy].present?
215 215 @notes = params[:notes]
216 216
217 217 if User.current.allowed_to?(:move_issues, @projects)
218 218 @allowed_projects = Issue.allowed_target_projects_on_move
219 219 if params[:issue]
220 220 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
221 221 if @target_project
222 222 target_projects = [@target_project]
223 223 end
224 224 end
225 225 end
226 226 target_projects ||= @projects
227 227
228 228 if @copy
229 229 @available_statuses = [IssueStatus.default]
230 230 else
231 231 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
232 232 end
233 233 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
234 234 @assignables = target_projects.map(&:assignable_users).reduce(:&)
235 235 @trackers = target_projects.map(&:trackers).reduce(:&)
236 236 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
237 237 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
238 if @copy
239 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
240 end
238 241
239 242 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
240 243 render :layout => false if request.xhr?
241 244 end
242 245
243 246 def bulk_update
244 247 @issues.sort!
245 248 @copy = params[:copy].present?
246 249 attributes = parse_params_for_bulk_issue_attributes(params)
247 250
248 251 unsaved_issue_ids = []
249 252 moved_issues = []
250 253 @issues.each do |issue|
251 254 issue.reload
252 255 if @copy
253 issue = issue.copy
256 issue = issue.copy({}, :attachments => params[:copy_attachments].present?)
254 257 end
255 258 journal = issue.init_journal(User.current, params[:notes])
256 259 issue.safe_attributes = attributes
257 260 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
258 261 if issue.save
259 262 moved_issues << issue
260 263 else
261 264 # Keep unsaved issue ids to display them in flash error
262 265 unsaved_issue_ids << issue.id
263 266 end
264 267 end
265 268 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
266 269
267 270 if params[:follow]
268 271 if @issues.size == 1 && moved_issues.size == 1
269 272 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
270 273 elsif moved_issues.map(&:project).uniq.size == 1
271 274 redirect_to :controller => 'issues', :action => 'index', :project_id => moved_issues.map(&:project).first
272 275 end
273 276 else
274 277 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
275 278 end
276 279 end
277 280
278 281 def destroy
279 282 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
280 283 if @hours > 0
281 284 case params[:todo]
282 285 when 'destroy'
283 286 # nothing to do
284 287 when 'nullify'
285 288 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
286 289 when 'reassign'
287 290 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
288 291 if reassign_to.nil?
289 292 flash.now[:error] = l(:error_issue_not_found_in_project)
290 293 return
291 294 else
292 295 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
293 296 end
294 297 else
295 298 # display the destroy form if it's a user request
296 299 return unless api_request?
297 300 end
298 301 end
299 302 @issues.each do |issue|
300 303 begin
301 304 issue.reload.destroy
302 305 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
303 306 # nothing to do, issue was already deleted (eg. by a parent)
304 307 end
305 308 end
306 309 respond_to do |format|
307 310 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
308 311 format.api { head :ok }
309 312 end
310 313 end
311 314
312 315 private
313 316 def find_issue
314 317 # Issue.visible.find(...) can not be used to redirect user to the login form
315 318 # if the issue actually exists but requires authentication
316 319 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
317 320 unless @issue.visible?
318 321 deny_access
319 322 return
320 323 end
321 324 @project = @issue.project
322 325 rescue ActiveRecord::RecordNotFound
323 326 render_404
324 327 end
325 328
326 329 def find_project
327 330 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
328 331 @project = Project.find(project_id)
329 332 rescue ActiveRecord::RecordNotFound
330 333 render_404
331 334 end
332 335
333 336 def retrieve_previous_and_next_issue_ids
334 337 retrieve_query_from_session
335 338 if @query
336 339 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
337 340 sort_update(@query.sortable_columns, 'issues_index_sort')
338 341 limit = 500
339 342 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
340 343 if (idx = issue_ids.index(@issue.id)) && idx < limit
341 344 if issue_ids.size < 500
342 345 @issue_position = idx + 1
343 346 @issue_count = issue_ids.size
344 347 end
345 348 @prev_issue_id = issue_ids[idx - 1] if idx > 0
346 349 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
347 350 end
348 351 end
349 352 end
350 353
351 354 # Used by #edit and #update to set some common instance variables
352 355 # from the params
353 356 # TODO: Refactor, not everything in here is needed by #edit
354 357 def update_issue_from_params
355 358 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
356 359 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
357 360 @time_entry.attributes = params[:time_entry]
358 361
359 362 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
360 363 @issue.init_journal(User.current, @notes)
361 364
362 365 issue_attributes = params[:issue]
363 366 if issue_attributes && params[:conflict_resolution]
364 367 case params[:conflict_resolution]
365 368 when 'overwrite'
366 369 issue_attributes = issue_attributes.dup
367 370 issue_attributes.delete(:lock_version)
368 371 when 'add_notes'
369 372 issue_attributes = {}
370 373 when 'cancel'
371 374 redirect_to issue_path(@issue)
372 375 return false
373 376 end
374 377 end
375 378 @issue.safe_attributes = issue_attributes
376 379 @priorities = IssuePriority.active
377 380 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
378 381 true
379 382 end
380 383
381 384 # TODO: Refactor, lots of extra code in here
382 385 # TODO: Changing tracker on an existing issue should not trigger this
383 386 def build_new_issue_from_params
384 387 if params[:id].blank?
385 388 @issue = Issue.new
386 389 if params[:copy_from]
387 390 begin
388 391 @copy_from = Issue.visible.find(params[:copy_from])
389 392 @copy_attachments = params[:copy_attachments].present? || request.get?
390 393 @issue.copy_from(@copy_from, :attachments => @copy_attachments)
391 394 rescue ActiveRecord::RecordNotFound
392 395 render_404
393 396 return
394 397 end
395 398 end
396 399 @issue.project = @project
397 400 else
398 401 @issue = @project.issues.visible.find(params[:id])
399 402 end
400 403
401 404 @issue.project = @project
402 405 @issue.author = User.current
403 406 # Tracker must be set before custom field values
404 407 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
405 408 if @issue.tracker.nil?
406 409 render_error l(:error_no_tracker_in_project)
407 410 return false
408 411 end
409 412 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
410 413 @issue.safe_attributes = params[:issue]
411 414
412 415 @priorities = IssuePriority.active
413 416 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
414 417 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
415 418 end
416 419
417 420 def check_for_default_issue_status
418 421 if IssueStatus.default.nil?
419 422 render_error l(:error_no_default_issue_status)
420 423 return false
421 424 end
422 425 end
423 426
424 427 def parse_params_for_bulk_issue_attributes(params)
425 428 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
426 429 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
427 430 if custom = attributes[:custom_field_values]
428 431 custom.reject! {|k,v| v.blank?}
429 432 custom.keys.each do |k|
430 433 if custom[k].is_a?(Array)
431 434 custom[k] << '' if custom[k].delete('__none__')
432 435 else
433 436 custom[k] = '' if custom[k] == '__none__'
434 437 end
435 438 end
436 439 end
437 440 attributes
438 441 end
439 442 end
Show file before | Show file after | Hide comments
@@ -1,1078 +1,1078
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20
21 21 belongs_to :project
22 22 belongs_to :tracker
23 23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 25 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29 29
30 30 has_many :journals, :as => :journalized, :dependent => :destroy
31 31 has_many :time_entries, :dependent => :delete_all
32 32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
33 33
34 34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
35 35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
36 36
37 37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
38 38 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
39 39 acts_as_customizable
40 40 acts_as_watchable
41 41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
42 42 :include => [:project, :journals],
43 43 # sort by id so that limited eager loading doesn't break with postgresql
44 44 :order_column => "#{table_name}.id"
45 45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
46 46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
47 47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
48 48
49 49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
50 50 :author_key => :author_id
51 51
52 52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
53 53
54 54 attr_reader :current_journal
55 55
56 56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
57 57
58 58 validates_length_of :subject, :maximum => 255
59 59 validates_inclusion_of :done_ratio, :in => 0..100
60 60 validates_numericality_of :estimated_hours, :allow_nil => true
61 61 validate :validate_issue
62 62
63 63 named_scope :visible, lambda {|*args| { :include => :project,
64 64 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
65 65
66 66 named_scope :open, lambda {|*args|
67 67 is_closed = args.size > 0 ? !args.first : false
68 68 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
69 69 }
70 70
71 71 named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
72 72 named_scope :with_limit, lambda { |limit| { :limit => limit} }
73 73 named_scope :on_active_project, :include => [:status, :project, :tracker],
74 74 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
75 75
76 76 before_create :default_assign
77 77 before_save :close_duplicates, :update_done_ratio_from_issue_status
78 78 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
79 79 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
80 80 after_destroy :update_parent_attributes
81 81
82 82 # Returns a SQL conditions string used to find all issues visible by the specified user
83 83 def self.visible_condition(user, options={})
84 84 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
85 85 case role.issues_visibility
86 86 when 'all'
87 87 nil
88 88 when 'default'
89 89 user_ids = [user.id] + user.groups.map(&:id)
90 90 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
91 91 when 'own'
92 92 user_ids = [user.id] + user.groups.map(&:id)
93 93 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
94 94 else
95 95 '1=0'
96 96 end
97 97 end
98 98 end
99 99
100 100 # Returns true if usr or current user is allowed to view the issue
101 101 def visible?(usr=nil)
102 102 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
103 103 case role.issues_visibility
104 104 when 'all'
105 105 true
106 106 when 'default'
107 107 !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
108 108 when 'own'
109 109 self.author == user || user.is_or_belongs_to?(assigned_to)
110 110 else
111 111 false
112 112 end
113 113 end
114 114 end
115 115
116 116 def initialize(attributes=nil, *args)
117 117 super
118 118 if new_record?
119 119 # set default values for new records only
120 120 self.status ||= IssueStatus.default
121 121 self.priority ||= IssuePriority.default
122 122 self.watcher_user_ids = []
123 123 end
124 124 end
125 125
126 126 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
127 127 def available_custom_fields
128 128 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
129 129 end
130 130
131 131 # Copies attributes from another issue, arg can be an id or an Issue
132 132 def copy_from(arg, options={})
133 133 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
134 134 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
135 135 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
136 136 self.status = issue.status
137 137 self.author = User.current
138 138 unless options[:attachments] == false
139 139 self.attachments = issue.attachments.map do |attachement|
140 140 attachement.copy(:container => self)
141 141 end
142 142 end
143 143 @copied_from = issue
144 144 self
145 145 end
146 146
147 147 # Returns an unsaved copy of the issue
148 def copy(attributes=nil)
149 copy = self.class.new.copy_from(self)
148 def copy(attributes=nil, copy_options={})
149 copy = self.class.new.copy_from(self, copy_options)
150 150 copy.attributes = attributes if attributes
151 151 copy
152 152 end
153 153
154 154 # Returns true if the issue is a copy
155 155 def copy?
156 156 @copied_from.present?
157 157 end
158 158
159 159 # Moves/copies an issue to a new project and tracker
160 160 # Returns the moved/copied issue on success, false on failure
161 161 def move_to_project(new_project, new_tracker=nil, options={})
162 162 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
163 163
164 164 if options[:copy]
165 165 issue = self.copy
166 166 else
167 167 issue = self
168 168 end
169 169
170 170 issue.init_journal(User.current, options[:notes])
171 171
172 172 # Preserve previous behaviour
173 173 # #move_to_project doesn't change tracker automatically
174 174 issue.send :project=, new_project, true
175 175 if new_tracker
176 176 issue.tracker = new_tracker
177 177 end
178 178 # Allow bulk setting of attributes on the issue
179 179 if options[:attributes]
180 180 issue.attributes = options[:attributes]
181 181 end
182 182
183 183 issue.save ? issue : false
184 184 end
185 185
186 186 def status_id=(sid)
187 187 self.status = nil
188 188 write_attribute(:status_id, sid)
189 189 end
190 190
191 191 def priority_id=(pid)
192 192 self.priority = nil
193 193 write_attribute(:priority_id, pid)
194 194 end
195 195
196 196 def category_id=(cid)
197 197 self.category = nil
198 198 write_attribute(:category_id, cid)
199 199 end
200 200
201 201 def fixed_version_id=(vid)
202 202 self.fixed_version = nil
203 203 write_attribute(:fixed_version_id, vid)
204 204 end
205 205
206 206 def tracker_id=(tid)
207 207 self.tracker = nil
208 208 result = write_attribute(:tracker_id, tid)
209 209 @custom_field_values = nil
210 210 result
211 211 end
212 212
213 213 def project_id=(project_id)
214 214 if project_id.to_s != self.project_id.to_s
215 215 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
216 216 end
217 217 end
218 218
219 219 def project=(project, keep_tracker=false)
220 220 project_was = self.project
221 221 write_attribute(:project_id, project ? project.id : nil)
222 222 association_instance_set('project', project)
223 223 if project_was && project && project_was != project
224 224 unless keep_tracker || project.trackers.include?(tracker)
225 225 self.tracker = project.trackers.first
226 226 end
227 227 # Reassign to the category with same name if any
228 228 if category
229 229 self.category = project.issue_categories.find_by_name(category.name)
230 230 end
231 231 # Keep the fixed_version if it's still valid in the new_project
232 232 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
233 233 self.fixed_version = nil
234 234 end
235 235 if parent && parent.project_id != project_id
236 236 self.parent_issue_id = nil
237 237 end
238 238 @custom_field_values = nil
239 239 end
240 240 end
241 241
242 242 def description=(arg)
243 243 if arg.is_a?(String)
244 244 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
245 245 end
246 246 write_attribute(:description, arg)
247 247 end
248 248
249 249 # Overrides attributes= so that project and tracker get assigned first
250 250 def attributes_with_project_and_tracker_first=(new_attributes, *args)
251 251 return if new_attributes.nil?
252 252 attrs = new_attributes.dup
253 253 attrs.stringify_keys!
254 254
255 255 %w(project project_id tracker tracker_id).each do |attr|
256 256 if attrs.has_key?(attr)
257 257 send "#{attr}=", attrs.delete(attr)
258 258 end
259 259 end
260 260 send :attributes_without_project_and_tracker_first=, attrs, *args
261 261 end
262 262 # Do not redefine alias chain on reload (see #4838)
263 263 alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
264 264
265 265 def estimated_hours=(h)
266 266 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
267 267 end
268 268
269 269 safe_attributes 'project_id',
270 270 :if => lambda {|issue, user|
271 271 if issue.new_record?
272 272 issue.copy?
273 273 elsif user.allowed_to?(:move_issues, issue.project)
274 274 projects = Issue.allowed_target_projects_on_move(user)
275 275 projects.include?(issue.project) && projects.size > 1
276 276 end
277 277 }
278 278
279 279 safe_attributes 'tracker_id',
280 280 'status_id',
281 281 'category_id',
282 282 'assigned_to_id',
283 283 'priority_id',
284 284 'fixed_version_id',
285 285 'subject',
286 286 'description',
287 287 'start_date',
288 288 'due_date',
289 289 'done_ratio',
290 290 'estimated_hours',
291 291 'custom_field_values',
292 292 'custom_fields',
293 293 'lock_version',
294 294 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
295 295
296 296 safe_attributes 'status_id',
297 297 'assigned_to_id',
298 298 'fixed_version_id',
299 299 'done_ratio',
300 300 'lock_version',
301 301 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
302 302
303 303 safe_attributes 'watcher_user_ids',
304 304 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
305 305
306 306 safe_attributes 'is_private',
307 307 :if => lambda {|issue, user|
308 308 user.allowed_to?(:set_issues_private, issue.project) ||
309 309 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
310 310 }
311 311
312 312 safe_attributes 'parent_issue_id',
313 313 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
314 314 user.allowed_to?(:manage_subtasks, issue.project)}
315 315
316 316 # Safely sets attributes
317 317 # Should be called from controllers instead of #attributes=
318 318 # attr_accessible is too rough because we still want things like
319 319 # Issue.new(:project => foo) to work
320 320 def safe_attributes=(attrs, user=User.current)
321 321 return unless attrs.is_a?(Hash)
322 322
323 323 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
324 324 attrs = delete_unsafe_attributes(attrs, user)
325 325 return if attrs.empty?
326 326
327 327 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
328 328 if p = attrs.delete('project_id')
329 329 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
330 330 self.project_id = p
331 331 end
332 332 end
333 333
334 334 if t = attrs.delete('tracker_id')
335 335 self.tracker_id = t
336 336 end
337 337
338 338 if attrs['status_id']
339 339 unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
340 340 attrs.delete('status_id')
341 341 end
342 342 end
343 343
344 344 unless leaf?
345 345 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
346 346 end
347 347
348 348 if attrs['parent_issue_id'].present?
349 349 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
350 350 end
351 351
352 352 # mass-assignment security bypass
353 353 self.send :attributes=, attrs, false
354 354 end
355 355
356 356 def done_ratio
357 357 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
358 358 status.default_done_ratio
359 359 else
360 360 read_attribute(:done_ratio)
361 361 end
362 362 end
363 363
364 364 def self.use_status_for_done_ratio?
365 365 Setting.issue_done_ratio == 'issue_status'
366 366 end
367 367
368 368 def self.use_field_for_done_ratio?
369 369 Setting.issue_done_ratio == 'issue_field'
370 370 end
371 371
372 372 def validate_issue
373 373 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
374 374 errors.add :due_date, :not_a_date
375 375 end
376 376
377 377 if self.due_date and self.start_date and self.due_date < self.start_date
378 378 errors.add :due_date, :greater_than_start_date
379 379 end
380 380
381 381 if start_date && soonest_start && start_date < soonest_start
382 382 errors.add :start_date, :invalid
383 383 end
384 384
385 385 if fixed_version
386 386 if !assignable_versions.include?(fixed_version)
387 387 errors.add :fixed_version_id, :inclusion
388 388 elsif reopened? && fixed_version.closed?
389 389 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
390 390 end
391 391 end
392 392
393 393 # Checks that the issue can not be added/moved to a disabled tracker
394 394 if project && (tracker_id_changed? || project_id_changed?)
395 395 unless project.trackers.include?(tracker)
396 396 errors.add :tracker_id, :inclusion
397 397 end
398 398 end
399 399
400 400 # Checks parent issue assignment
401 401 if @parent_issue
402 402 if @parent_issue.project_id != project_id
403 403 errors.add :parent_issue_id, :not_same_project
404 404 elsif !new_record?
405 405 # moving an existing issue
406 406 if @parent_issue.root_id != root_id
407 407 # we can always move to another tree
408 408 elsif move_possible?(@parent_issue)
409 409 # move accepted inside tree
410 410 else
411 411 errors.add :parent_issue_id, :not_a_valid_parent
412 412 end
413 413 end
414 414 end
415 415 end
416 416
417 417 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
418 418 # even if the user turns off the setting later
419 419 def update_done_ratio_from_issue_status
420 420 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
421 421 self.done_ratio = status.default_done_ratio
422 422 end
423 423 end
424 424
425 425 def init_journal(user, notes = "")
426 426 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
427 427 if new_record?
428 428 @current_journal.notify = false
429 429 else
430 430 @attributes_before_change = attributes.dup
431 431 @custom_values_before_change = {}
432 432 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
433 433 end
434 434 # Make sure updated_on is updated when adding a note.
435 435 updated_on_will_change!
436 436 @current_journal
437 437 end
438 438
439 439 # Returns the id of the last journal or nil
440 440 def last_journal_id
441 441 if new_record?
442 442 nil
443 443 else
444 444 journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
445 445 end
446 446 end
447 447
448 448 # Return true if the issue is closed, otherwise false
449 449 def closed?
450 450 self.status.is_closed?
451 451 end
452 452
453 453 # Return true if the issue is being reopened
454 454 def reopened?
455 455 if !new_record? && status_id_changed?
456 456 status_was = IssueStatus.find_by_id(status_id_was)
457 457 status_new = IssueStatus.find_by_id(status_id)
458 458 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
459 459 return true
460 460 end
461 461 end
462 462 false
463 463 end
464 464
465 465 # Return true if the issue is being closed
466 466 def closing?
467 467 if !new_record? && status_id_changed?
468 468 status_was = IssueStatus.find_by_id(status_id_was)
469 469 status_new = IssueStatus.find_by_id(status_id)
470 470 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
471 471 return true
472 472 end
473 473 end
474 474 false
475 475 end
476 476
477 477 # Returns true if the issue is overdue
478 478 def overdue?
479 479 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
480 480 end
481 481
482 482 # Is the amount of work done less than it should for the due date
483 483 def behind_schedule?
484 484 return false if start_date.nil? || due_date.nil?
485 485 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
486 486 return done_date <= Date.today
487 487 end
488 488
489 489 # Does this issue have children?
490 490 def children?
491 491 !leaf?
492 492 end
493 493
494 494 # Users the issue can be assigned to
495 495 def assignable_users
496 496 users = project.assignable_users
497 497 users << author if author
498 498 users << assigned_to if assigned_to
499 499 users.uniq.sort
500 500 end
501 501
502 502 # Versions that the issue can be assigned to
503 503 def assignable_versions
504 504 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
505 505 end
506 506
507 507 # Returns true if this issue is blocked by another issue that is still open
508 508 def blocked?
509 509 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
510 510 end
511 511
512 512 # Returns an array of statuses that user is able to apply
513 513 def new_statuses_allowed_to(user=User.current, include_default=false)
514 514 if new_record? && @copied_from
515 515 [IssueStatus.default, @copied_from.status].compact.uniq.sort
516 516 else
517 517 initial_status = nil
518 518 if new_record?
519 519 initial_status = IssueStatus.default
520 520 elsif status_id_was
521 521 initial_status = IssueStatus.find_by_id(status_id_was)
522 522 end
523 523 initial_status ||= status
524 524
525 525 statuses = initial_status.find_new_statuses_allowed_to(
526 526 user.admin ? Role.all : user.roles_for_project(project),
527 527 tracker,
528 528 author == user,
529 529 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
530 530 )
531 531 statuses << initial_status unless statuses.empty?
532 532 statuses << IssueStatus.default if include_default
533 533 statuses = statuses.compact.uniq.sort
534 534 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
535 535 end
536 536 end
537 537
538 538 def assigned_to_was
539 539 if assigned_to_id_changed? && assigned_to_id_was.present?
540 540 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
541 541 end
542 542 end
543 543
544 544 # Returns the mail adresses of users that should be notified
545 545 def recipients
546 546 notified = []
547 547 # Author and assignee are always notified unless they have been
548 548 # locked or don't want to be notified
549 549 notified << author if author
550 550 if assigned_to
551 551 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
552 552 end
553 553 if assigned_to_was
554 554 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
555 555 end
556 556 notified = notified.select {|u| u.active? && u.notify_about?(self)}
557 557
558 558 notified += project.notified_users
559 559 notified.uniq!
560 560 # Remove users that can not view the issue
561 561 notified.reject! {|user| !visible?(user)}
562 562 notified.collect(&:mail)
563 563 end
564 564
565 565 # Returns the number of hours spent on this issue
566 566 def spent_hours
567 567 @spent_hours ||= time_entries.sum(:hours) || 0
568 568 end
569 569
570 570 # Returns the total number of hours spent on this issue and its descendants
571 571 #
572 572 # Example:
573 573 # spent_hours => 0.0
574 574 # spent_hours => 50.2
575 575 def total_spent_hours
576 576 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
577 577 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
578 578 end
579 579
580 580 def relations
581 581 @relations ||= (relations_from + relations_to).sort
582 582 end
583 583
584 584 # Preloads relations for a collection of issues
585 585 def self.load_relations(issues)
586 586 if issues.any?
587 587 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
588 588 issues.each do |issue|
589 589 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
590 590 end
591 591 end
592 592 end
593 593
594 594 # Preloads visible spent time for a collection of issues
595 595 def self.load_visible_spent_hours(issues, user=User.current)
596 596 if issues.any?
597 597 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
598 598 issues.each do |issue|
599 599 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
600 600 end
601 601 end
602 602 end
603 603
604 604 # Finds an issue relation given its id.
605 605 def find_relation(relation_id)
606 606 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
607 607 end
608 608
609 609 def all_dependent_issues(except=[])
610 610 except << self
611 611 dependencies = []
612 612 relations_from.each do |relation|
613 613 if relation.issue_to && !except.include?(relation.issue_to)
614 614 dependencies << relation.issue_to
615 615 dependencies += relation.issue_to.all_dependent_issues(except)
616 616 end
617 617 end
618 618 dependencies
619 619 end
620 620
621 621 # Returns an array of issues that duplicate this one
622 622 def duplicates
623 623 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
624 624 end
625 625
626 626 # Returns the due date or the target due date if any
627 627 # Used on gantt chart
628 628 def due_before
629 629 due_date || (fixed_version ? fixed_version.effective_date : nil)
630 630 end
631 631
632 632 # Returns the time scheduled for this issue.
633 633 #
634 634 # Example:
635 635 # Start Date: 2/26/09, End Date: 3/04/09
636 636 # duration => 6
637 637 def duration
638 638 (start_date && due_date) ? due_date - start_date : 0
639 639 end
640 640
641 641 def soonest_start
642 642 @soonest_start ||= (
643 643 relations_to.collect{|relation| relation.successor_soonest_start} +
644 644 ancestors.collect(&:soonest_start)
645 645 ).compact.max
646 646 end
647 647
648 648 def reschedule_after(date)
649 649 return if date.nil?
650 650 if leaf?
651 651 if start_date.nil? || start_date < date
652 652 self.start_date, self.due_date = date, date + duration
653 653 begin
654 654 save
655 655 rescue ActiveRecord::StaleObjectError
656 656 reload
657 657 self.start_date, self.due_date = date, date + duration
658 658 save
659 659 end
660 660 end
661 661 else
662 662 leaves.each do |leaf|
663 663 leaf.reschedule_after(date)
664 664 end
665 665 end
666 666 end
667 667
668 668 def <=>(issue)
669 669 if issue.nil?
670 670 -1
671 671 elsif root_id != issue.root_id
672 672 (root_id || 0) <=> (issue.root_id || 0)
673 673 else
674 674 (lft || 0) <=> (issue.lft || 0)
675 675 end
676 676 end
677 677
678 678 def to_s
679 679 "#{tracker} ##{id}: #{subject}"
680 680 end
681 681
682 682 # Returns a string of css classes that apply to the issue
683 683 def css_classes
684 684 s = "issue status-#{status.position} priority-#{priority.position}"
685 685 s << ' closed' if closed?
686 686 s << ' overdue' if overdue?
687 687 s << ' child' if child?
688 688 s << ' parent' unless leaf?
689 689 s << ' private' if is_private?
690 690 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
691 691 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
692 692 s
693 693 end
694 694
695 695 # Saves an issue and a time_entry from the parameters
696 696 def save_issue_with_child_records(params, existing_time_entry=nil)
697 697 Issue.transaction do
698 698 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
699 699 @time_entry = existing_time_entry || TimeEntry.new
700 700 @time_entry.project = project
701 701 @time_entry.issue = self
702 702 @time_entry.user = User.current
703 703 @time_entry.spent_on = User.current.today
704 704 @time_entry.attributes = params[:time_entry]
705 705 self.time_entries << @time_entry
706 706 end
707 707
708 708 # TODO: Rename hook
709 709 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
710 710 if save
711 711 # TODO: Rename hook
712 712 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
713 713 else
714 714 raise ActiveRecord::Rollback
715 715 end
716 716 end
717 717 end
718 718
719 719 # Unassigns issues from +version+ if it's no longer shared with issue's project
720 720 def self.update_versions_from_sharing_change(version)
721 721 # Update issues assigned to the version
722 722 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
723 723 end
724 724
725 725 # Unassigns issues from versions that are no longer shared
726 726 # after +project+ was moved
727 727 def self.update_versions_from_hierarchy_change(project)
728 728 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
729 729 # Update issues of the moved projects and issues assigned to a version of a moved project
730 730 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
731 731 end
732 732
733 733 def parent_issue_id=(arg)
734 734 parent_issue_id = arg.blank? ? nil : arg.to_i
735 735 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
736 736 @parent_issue.id
737 737 else
738 738 @parent_issue = nil
739 739 nil
740 740 end
741 741 end
742 742
743 743 def parent_issue_id
744 744 if instance_variable_defined? :@parent_issue
745 745 @parent_issue.nil? ? nil : @parent_issue.id
746 746 else
747 747 parent_id
748 748 end
749 749 end
750 750
751 751 # Extracted from the ReportsController.
752 752 def self.by_tracker(project)
753 753 count_and_group_by(:project => project,
754 754 :field => 'tracker_id',
755 755 :joins => Tracker.table_name)
756 756 end
757 757
758 758 def self.by_version(project)
759 759 count_and_group_by(:project => project,
760 760 :field => 'fixed_version_id',
761 761 :joins => Version.table_name)
762 762 end
763 763
764 764 def self.by_priority(project)
765 765 count_and_group_by(:project => project,
766 766 :field => 'priority_id',
767 767 :joins => IssuePriority.table_name)
768 768 end
769 769
770 770 def self.by_category(project)
771 771 count_and_group_by(:project => project,
772 772 :field => 'category_id',
773 773 :joins => IssueCategory.table_name)
774 774 end
775 775
776 776 def self.by_assigned_to(project)
777 777 count_and_group_by(:project => project,
778 778 :field => 'assigned_to_id',
779 779 :joins => User.table_name)
780 780 end
781 781
782 782 def self.by_author(project)
783 783 count_and_group_by(:project => project,
784 784 :field => 'author_id',
785 785 :joins => User.table_name)
786 786 end
787 787
788 788 def self.by_subproject(project)
789 789 ActiveRecord::Base.connection.select_all("select s.id as status_id,
790 790 s.is_closed as closed,
791 791 #{Issue.table_name}.project_id as project_id,
792 792 count(#{Issue.table_name}.id) as total
793 793 from
794 794 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
795 795 where
796 796 #{Issue.table_name}.status_id=s.id
797 797 and #{Issue.table_name}.project_id = #{Project.table_name}.id
798 798 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
799 799 and #{Issue.table_name}.project_id <> #{project.id}
800 800 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
801 801 end
802 802 # End ReportsController extraction
803 803
804 804 # Returns an array of projects that user can assign the issue to
805 805 def allowed_target_projects(user=User.current)
806 806 if new_record?
807 807 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
808 808 else
809 809 self.class.allowed_target_projects_on_move(user)
810 810 end
811 811 end
812 812
813 813 # Returns an array of projects that user can move issues to
814 814 def self.allowed_target_projects_on_move(user=User.current)
815 815 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
816 816 end
817 817
818 818 private
819 819
820 820 def after_project_change
821 821 # Update project_id on related time entries
822 822 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
823 823
824 824 # Delete issue relations
825 825 unless Setting.cross_project_issue_relations?
826 826 relations_from.clear
827 827 relations_to.clear
828 828 end
829 829
830 830 # Move subtasks
831 831 children.each do |child|
832 832 # Change project and keep project
833 833 child.send :project=, project, true
834 834 unless child.save
835 835 raise ActiveRecord::Rollback
836 836 end
837 837 end
838 838 end
839 839
840 840 def update_nested_set_attributes
841 841 if root_id.nil?
842 842 # issue was just created
843 843 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
844 844 set_default_left_and_right
845 845 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
846 846 if @parent_issue
847 847 move_to_child_of(@parent_issue)
848 848 end
849 849 reload
850 850 elsif parent_issue_id != parent_id
851 851 former_parent_id = parent_id
852 852 # moving an existing issue
853 853 if @parent_issue && @parent_issue.root_id == root_id
854 854 # inside the same tree
855 855 move_to_child_of(@parent_issue)
856 856 else
857 857 # to another tree
858 858 unless root?
859 859 move_to_right_of(root)
860 860 reload
861 861 end
862 862 old_root_id = root_id
863 863 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
864 864 target_maxright = nested_set_scope.maximum(right_column_name) || 0
865 865 offset = target_maxright + 1 - lft
866 866 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
867 867 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
868 868 self[left_column_name] = lft + offset
869 869 self[right_column_name] = rgt + offset
870 870 if @parent_issue
871 871 move_to_child_of(@parent_issue)
872 872 end
873 873 end
874 874 reload
875 875 # delete invalid relations of all descendants
876 876 self_and_descendants.each do |issue|
877 877 issue.relations.each do |relation|
878 878 relation.destroy unless relation.valid?
879 879 end
880 880 end
881 881 # update former parent
882 882 recalculate_attributes_for(former_parent_id) if former_parent_id
883 883 end
884 884 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
885 885 end
886 886
887 887 def update_parent_attributes
888 888 recalculate_attributes_for(parent_id) if parent_id
889 889 end
890 890
891 891 def recalculate_attributes_for(issue_id)
892 892 if issue_id && p = Issue.find_by_id(issue_id)
893 893 # priority = highest priority of children
894 894 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
895 895 p.priority = IssuePriority.find_by_position(priority_position)
896 896 end
897 897
898 898 # start/due dates = lowest/highest dates of children
899 899 p.start_date = p.children.minimum(:start_date)
900 900 p.due_date = p.children.maximum(:due_date)
901 901 if p.start_date && p.due_date && p.due_date < p.start_date
902 902 p.start_date, p.due_date = p.due_date, p.start_date
903 903 end
904 904
905 905 # done ratio = weighted average ratio of leaves
906 906 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
907 907 leaves_count = p.leaves.count
908 908 if leaves_count > 0
909 909 average = p.leaves.average(:estimated_hours).to_f
910 910 if average == 0
911 911 average = 1
912 912 end
913 913 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
914 914 progress = done / (average * leaves_count)
915 915 p.done_ratio = progress.round
916 916 end
917 917 end
918 918
919 919 # estimate = sum of leaves estimates
920 920 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
921 921 p.estimated_hours = nil if p.estimated_hours == 0.0
922 922
923 923 # ancestors will be recursively updated
924 924 p.save(false)
925 925 end
926 926 end
927 927
928 928 # Update issues so their versions are not pointing to a
929 929 # fixed_version that is not shared with the issue's project
930 930 def self.update_versions(conditions=nil)
931 931 # Only need to update issues with a fixed_version from
932 932 # a different project and that is not systemwide shared
933 933 Issue.scoped(:conditions => conditions).all(
934 934 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
935 935 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
936 936 " AND #{Version.table_name}.sharing <> 'system'",
937 937 :include => [:project, :fixed_version]
938 938 ).each do |issue|
939 939 next if issue.project.nil? || issue.fixed_version.nil?
940 940 unless issue.project.shared_versions.include?(issue.fixed_version)
941 941 issue.init_journal(User.current)
942 942 issue.fixed_version = nil
943 943 issue.save
944 944 end
945 945 end
946 946 end
947 947
948 948 # Callback on attachment deletion
949 949 def attachment_added(obj)
950 950 if @current_journal && !obj.new_record?
951 951 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
952 952 end
953 953 end
954 954
955 955 # Callback on attachment deletion
956 956 def attachment_removed(obj)
957 957 if @current_journal && !obj.new_record?
958 958 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
959 959 @current_journal.save
960 960 end
961 961 end
962 962
963 963 # Default assignment based on category
964 964 def default_assign
965 965 if assigned_to.nil? && category && category.assigned_to
966 966 self.assigned_to = category.assigned_to
967 967 end
968 968 end
969 969
970 970 # Updates start/due dates of following issues
971 971 def reschedule_following_issues
972 972 if start_date_changed? || due_date_changed?
973 973 relations_from.each do |relation|
974 974 relation.set_issue_to_dates
975 975 end
976 976 end
977 977 end
978 978
979 979 # Closes duplicates if the issue is being closed
980 980 def close_duplicates
981 981 if closing?
982 982 duplicates.each do |duplicate|
983 983 # Reload is need in case the duplicate was updated by a previous duplicate
984 984 duplicate.reload
985 985 # Don't re-close it if it's already closed
986 986 next if duplicate.closed?
987 987 # Same user and notes
988 988 if @current_journal
989 989 duplicate.init_journal(@current_journal.user, @current_journal.notes)
990 990 end
991 991 duplicate.update_attribute :status, self.status
992 992 end
993 993 end
994 994 end
995 995
996 996 # Saves the changes in a Journal
997 997 # Called after_save
998 998 def create_journal
999 999 if @current_journal
1000 1000 # attributes changes
1001 1001 if @attributes_before_change
1002 1002 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
1003 1003 before = @attributes_before_change[c]
1004 1004 after = send(c)
1005 1005 next if before == after || (before.blank? && after.blank?)
1006 1006 @current_journal.details << JournalDetail.new(:property => 'attr',
1007 1007 :prop_key => c,
1008 1008 :old_value => before,
1009 1009 :value => after)
1010 1010 }
1011 1011 end
1012 1012 if @custom_values_before_change
1013 1013 # custom fields changes
1014 1014 custom_field_values.each {|c|
1015 1015 before = @custom_values_before_change[c.custom_field_id]
1016 1016 after = c.value
1017 1017 next if before == after || (before.blank? && after.blank?)
1018 1018
1019 1019 if before.is_a?(Array) || after.is_a?(Array)
1020 1020 before = [before] unless before.is_a?(Array)
1021 1021 after = [after] unless after.is_a?(Array)
1022 1022
1023 1023 # values removed
1024 1024 (before - after).reject(&:blank?).each do |value|
1025 1025 @current_journal.details << JournalDetail.new(:property => 'cf',
1026 1026 :prop_key => c.custom_field_id,
1027 1027 :old_value => value,
1028 1028 :value => nil)
1029 1029 end
1030 1030 # values added
1031 1031 (after - before).reject(&:blank?).each do |value|
1032 1032 @current_journal.details << JournalDetail.new(:property => 'cf',
1033 1033 :prop_key => c.custom_field_id,
1034 1034 :old_value => nil,
1035 1035 :value => value)
1036 1036 end
1037 1037 else
1038 1038 @current_journal.details << JournalDetail.new(:property => 'cf',
1039 1039 :prop_key => c.custom_field_id,
1040 1040 :old_value => before,
1041 1041 :value => after)
1042 1042 end
1043 1043 }
1044 1044 end
1045 1045 @current_journal.save
1046 1046 # reset current journal
1047 1047 init_journal @current_journal.user, @current_journal.notes
1048 1048 end
1049 1049 end
1050 1050
1051 1051 # Query generator for selecting groups of issue counts for a project
1052 1052 # based on specific criteria
1053 1053 #
1054 1054 # Options
1055 1055 # * project - Project to search in.
1056 1056 # * field - String. Issue field to key off of in the grouping.
1057 1057 # * joins - String. The table name to join against.
1058 1058 def self.count_and_group_by(options)
1059 1059 project = options.delete(:project)
1060 1060 select_field = options.delete(:field)
1061 1061 joins = options.delete(:joins)
1062 1062
1063 1063 where = "#{Issue.table_name}.#{select_field}=j.id"
1064 1064
1065 1065 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1066 1066 s.is_closed as closed,
1067 1067 j.id as #{select_field},
1068 1068 count(#{Issue.table_name}.id) as total
1069 1069 from
1070 1070 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1071 1071 where
1072 1072 #{Issue.table_name}.status_id=s.id
1073 1073 and #{where}
1074 1074 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1075 1075 and #{visible_condition(User.current, :project => project)}
1076 1076 group by s.id, s.is_closed, j.id")
1077 1077 end
1078 1078 end
Show file before | Show file after | Hide comments
@@ -1,120 +1,127
1 1 <h2><%= @copy ? l(:button_copy) : l(:label_bulk_edit_selected_issues) %></h2>
2 2
3 3 <ul><%= @issues.collect {|i|
4 4 content_tag('li',
5 5 link_to(h("#{i.tracker} ##{i.id}"),
6 6 { :action => 'show', :id => i }
7 7 ) + h(": #{i.subject}"))
8 8 }.join("\n").html_safe %></ul>
9 9
10 10 <% form_tag({:action => 'bulk_update'}, :id => 'bulk_edit_form') do %>
11 11 <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join("\n").html_safe %>
12 12 <div class="box tabular">
13 13 <fieldset class="attributes">
14 14 <legend><%= l(:label_change_properties) %></legend>
15 15
16 16 <div class="splitcontentleft">
17 17 <% if @allowed_projects.present? %>
18 18 <p>
19 19 <label for="issue_project_id"><%= l(:field_project) %></label>
20 20 <%= select_tag('issue[project_id]', content_tag('option', l(:label_no_change_option), :value => '') + project_tree_options_for_select(@allowed_projects, :selected => @target_project)) %>
21 21 </p>
22 22 <%= observe_field :issue_project_id, :url => {:action => 'bulk_edit'},
23 23 :update => 'content',
24 24 :with => "Form.serialize('bulk_edit_form')" %>
25 25 <% end %>
26 26 <p>
27 27 <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
28 28 <%= select_tag('issue[tracker_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@trackers, :id, :name)) %>
29 29 </p>
30 30 <% if @available_statuses.any? %>
31 31 <p>
32 32 <label for='issue_status_id'><%= l(:field_status) %></label>
33 33 <%= select_tag('issue[status_id]',content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@available_statuses, :id, :name)) %>
34 34 </p>
35 35 <% end %>
36 36 <p>
37 37 <label for='issue_priority_id'><%= l(:field_priority) %></label>
38 38 <%= select_tag('issue[priority_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
39 39 </p>
40 40 <p>
41 41 <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
42 42 <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
43 43 content_tag('option', l(:label_nobody), :value => 'none') +
44 44 principals_options_for_select(@assignables)) %>
45 45 </p>
46 46 <p>
47 47 <label for='issue_category_id'><%= l(:field_category) %></label>
48 48 <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
49 49 content_tag('option', l(:label_none), :value => 'none') +
50 50 options_from_collection_for_select(@categories, :id, :name)) %>
51 51 </p>
52 52 <p>
53 53 <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
54 54 <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
55 55 content_tag('option', l(:label_none), :value => 'none') +
56 56 version_options_for_select(@versions.sort)) %>
57 57 </p>
58 58
59 59 <% @custom_fields.each do |custom_field| %>
60 60 <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
61 61 <% end %>
62 62
63 <% if @copy && @attachments_present %>
64 <p>
65 <label for='copy_attachments'><%= l(:label_copy_attachments) %></label>
66 <%= check_box_tag 'copy_attachments', '1', true %>
67 </p>
68 <% end %>
69
63 70 <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
64 71 </div>
65 72
66 73 <div class="splitcontentright">
67 74 <% if @safe_attributes.include?('is_private') %>
68 75 <p>
69 76 <label for='issue_is_private'><%= l(:field_is_private) %></label>
70 77 <%= select_tag('issue[is_private]', content_tag('option', l(:label_no_change_option), :value => '') +
71 78 content_tag('option', l(:general_text_Yes), :value => '1') +
72 79 content_tag('option', l(:general_text_No), :value => '0')) %>
73 80 </p>
74 81 <% end %>
75 82 <% if @project && User.current.allowed_to?(:manage_subtasks, @project) %>
76 83 <p>
77 84 <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
78 85 <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
79 86 </p>
80 87 <div id="parent_issue_candidates" class="autocomplete"></div>
81 88 <%= javascript_tag "observeParentIssueField('#{auto_complete_issues_path(:project_id => @project) }')" %>
82 89 <% end %>
83 90 <p>
84 91 <label for='issue_start_date'><%= l(:field_start_date) %></label>
85 92 <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
86 93 </p>
87 94 <p>
88 95 <label for='issue_due_date'><%= l(:field_due_date) %></label>
89 96 <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
90 97 </p>
91 98 <% if Issue.use_field_for_done_ratio? %>
92 99 <p>
93 100 <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
94 101 <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
95 102 </p>
96 103 <% end %>
97 104 </div>
98 105
99 106 </fieldset>
100 107
101 108 <fieldset><legend><%= l(:field_notes) %></legend>
102 109 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
103 110 <%= wikitoolbar_for 'notes' %>
104 111 </fieldset>
105 112 </div>
106 113
107 114 <p>
108 115 <% if @copy %>
109 116 <%= hidden_field_tag 'copy', '1' %>
110 117 <%= submit_tag l(:button_copy) %>
111 118 <%= submit_tag l(:button_copy_and_follow), :name => 'follow' %>
112 119 <% elsif @target_project %>
113 120 <%= submit_tag l(:button_move) %>
114 121 <%= submit_tag l(:button_move_and_follow), :name => 'follow' %>
115 122 <% else %>
116 123 <%= submit_tag l(:button_submit) %>
117 124 <% end %>
118 125 </p>
119 126
120 127 <% end %>
Show file before | Show file after | Hide comments
1 NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff
General Comments 0
You need to be logged in to leave comments. Login now