jro_apps/redmine Commit - r9969:2275f4613875

Makes Version#<=> consistent with SQL sort....

Jean-Philippe Lang -

r9969:2275f4613875

parent child

Context file:

r9969:2275f4613875

app/models/version.rb +2 -2

                 if self.effective_date
                   if version.effective_date
                     if self.effective_date == version.effective_date
-                      "#{self.project.name} - #{self.name}" <=> "#{version.project.name} - #{version.name}"
+                      name == version.name ? id <=> version.id : name <=> version.name
                     else
                       self.effective_date <=> version.effective_date
                     end
                   if version.effective_date
                   else
-                    "#{self.project.name} - #{self.name}" <=> "#{version.project.name} - #{version.name}"
+                    name == version.name ? id <=> version.id : name <=> version.name
                   end
                 end
               end

test/unit/version_test.rb +1 0

                 v1 = Version.create!(:project_id => 1, :name => 'v3', :effective_date => '2012-08-02')
                 v5 = Version.create!(:project_id => 1, :name => 'v5', :effective_date => '2012-07-02')
+                assert_equal [v5, v3, v1, v2, v4], [v1, v2, v3, v4, v5].sort
                 assert_equal [v5, v3, v1, v2, v4], Version.sorted.all
               end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages