jro_apps/redmine Commit - r13274:1fcbeb6f816a

Use named routes or helpers....

Jean-Philippe Lang -

r13274:1fcbeb6f816a

parent child

Context file:

r13274:1fcbeb6f816a

app/helpers/attachments_helper.rb +1 -1

                   api.filesize attachment.filesize
                   api.content_type attachment.content_type
                   api.description attachment.description
-                  api.content_url url_for(:controller => 'attachments', :action => 'download', :id => attachment, :filename => attachment.filename, :only_path => false)
+                  api.content_url download_named_attachment_url(attachment, attachment.filename)
                   api.author(:id => attachment.author.id, :name => attachment.author.name) if attachment.author
                   api.created_on attachment.created_on
                 end

app/views/common/feed.atom.builder +1 -1

               xml.title   truncate_single_line_raw(@title, 100)
               xml.link    "rel" => "self", "href" => url_for(params.merge(:only_path => false))
               xml.link    "rel" => "alternate", "href" => url_for(params.merge(:only_path => false, :format => nil, :key => nil))
-              xml.id      url_for(:controller => 'welcome', :only_path => false)
+              xml.id      home_url
               xml.icon    favicon_url
               xml.updated((@items.first ? @items.first.event_datetime : Time.now).xmlschema)
               xml.author  { xml.name "#{Setting.app_title}" }

app/views/journals/index.builder +4 -4

             xml.feed "xmlns" => "http://www.w3.org/2005/Atom" do
               xml.title   @title
               xml.link    "rel" => "self", "href" => url_for(:format => 'atom', :key => User.current.rss_key, :only_path => false)
-              xml.link    "rel" => "alternate", "href" => home_url(:only_path => false)
+              xml.link    "rel" => "alternate", "href" => home_url
-              xml.id      url_for(:controller => 'welcome', :only_path => false)
+              xml.id      home_url
               xml.icon    favicon_url
               xml.updated((@journals.first ? @journals.first.event_datetime : Time.now).xmlschema)
               xml.author  { xml.name "#{Setting.app_title}" }
                 issue = change.issue
                 xml.entry do
                   xml.title   "#{issue.project.name} - #{issue.tracker.name} ##{issue.id}: #{issue.subject}"
-                  xml.link    "rel" => "alternate", "href" => url_for(:controller => 'issues' , :action => 'show', :id => issue, :only_path => false)
+                  xml.link    "rel" => "alternate", "href" => issue_url(issue)
-                  xml.id      url_for(:controller => 'issues' , :action => 'show', :id => issue, :journal_id => change, :only_path => false)
+                  xml.id      issue_url(issue, :journal_id => change)
                   xml.updated change.created_on.xmlschema
                   xml.author do
                     xml.name change.user.name

app/views/mailer/reminder.html.erb +1 -1

             <ul>
             <% @issues.each do |issue| -%>
-              <li><%=h issue.project %> - <%=link_to(h("#{issue.tracker} ##{issue.id}"), :controller => 'issues', :action => 'show', :id => issue, :only_path => false)%>: <%=h issue.subject %></li>
+              <li><%= link_to_issue(issue, :project => true, :only_path => false) %></li>
             <% end -%>
             </ul>

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages