jro_apps/redmine Commit - r14161:1dbb2562934f

Merged r14473 (#20278)....

Jean-Philippe Lang -

r14161:1dbb2562934f

parent child

Context file:

r14161:1dbb2562934f

app/models/attachment.rb +1 -1

               def self.latest_attach(attachments, filename)
                 attachments.sort_by(&:created_on).reverse.detect do |att|
-                  att.filename.downcase == filename.downcase
+                  filename.casecmp(att.filename) == 0
                 end
               end

test/unit/attachment_test.rb +7 0

                 set_tmp_attachments_directory
               end
+              def test_latest_attach_should_not_error_with_string_with_invalid_encoding
+                string = "width:50\xFE-Image.jpg".force_encoding('UTF-8')
+                assert_equal false, string.valid_encoding?
+                Attachment.latest_attach(Attachment.limit(2).to_a, string)
+              end
               def test_thumbnailable_should_be_true_for_images
                 assert_equal true, Attachment.new(:filename => 'test.jpg').thumbnailable?
               end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages