jro_apps/redmine Commit - r4264:1c047dfeb80c

Fixed: start date being filled with current date even when blank value is submitted (#6575)....

Jean-Philippe Lang -

r4264:1c047dfeb80c

parent child

Context file:

r4264:1c047dfeb80c

Collapse all files

app/controllers/issues_controller.rb +1 -1

                    render_error l(:error_no_tracker_in_project)
                    return false
                  end
+                 @issue.start_date ||= Date.today
                  if params[:issue].is_a?(Hash)
                    @issue.safe_attributes = params[:issue]
                    if User.current.allowed_to?(:add_issue_watchers, @project) && @issue.new_record?
                    end
                  end
                  @issue.author = User.current
-                 @issue.start_date ||= Date.today
                  @priorities = IssuePriority.all
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
                end

test/functional/issues_controller_test.rb +22 0

                                          :subject => 'This is the test_new issue',
                                          :description => 'This is the description',
                                          :priority_id => 5,
+                                         :start_date => '2010-11-07',
                                          :estimated_hours => '',
                                          :custom_field_values => {'2' => 'Value for field 2'}}
                  end
                  assert_equal 2, issue.author_id
                  assert_equal 3, issue.tracker_id
                  assert_equal 2, issue.status_id
+                 assert_equal Date.parse('2010-11-07'), issue.start_date
                  assert_nil issue.estimated_hours
                  v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
                  assert_not_nil v
                  assert_equal 'Value for field 2', v.value
                end
+               def test_post_create_without_start_date
+                 @request.session[:user_id] = 2
+                 assert_difference 'Issue.count' do
+                   post :create, :project_id => 1,
+                              :issue => {:tracker_id => 3,
+                                         :status_id => 2,
+                                         :subject => 'This is the test_new issue',
+                                         :description => 'This is the description',
+                                         :priority_id => 5,
+                                         :start_date => '',
+                                         :estimated_hours => '',
+                                         :custom_field_values => {'2' => 'Value for field 2'}}
+                 end
+                 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
+                 issue = Issue.find_by_subject('This is the test_new issue')
+                 assert_not_nil issue
+                 assert_nil issue.start_date
+               end
                def test_post_create_and_continue
                  @request.session[:user_id] = 2
                  post :create, :project_id => 1,

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages