##// END OF EJS Templates
Fixes Redmine.pm error "closing dbh with active statement handles at /usr/lib/perl5/Apache/Redmine.pm" (#4205)....
Jean-Philippe Lang -
r3186:1b65a44cfc1e
parent child
Show More
@@ -1,350 +1,355
1 1 package Apache::Authn::Redmine;
2 2
3 3 =head1 Apache::Authn::Redmine
4 4
5 5 Redmine - a mod_perl module to authenticate webdav subversion users
6 6 against redmine database
7 7
8 8 =head1 SYNOPSIS
9 9
10 10 This module allow anonymous users to browse public project and
11 11 registred users to browse and commit their project. Authentication is
12 12 done against the redmine database or the LDAP configured in redmine.
13 13
14 14 This method is far simpler than the one with pam_* and works with all
15 15 database without an hassle but you need to have apache/mod_perl on the
16 16 svn server.
17 17
18 18 =head1 INSTALLATION
19 19
20 20 For this to automagically work, you need to have a recent reposman.rb
21 21 (after r860) and if you already use reposman, read the last section to
22 22 migrate.
23 23
24 24 Sorry ruby users but you need some perl modules, at least mod_perl2,
25 25 DBI and DBD::mysql (or the DBD driver for you database as it should
26 26 work on allmost all databases).
27 27
28 28 On debian/ubuntu you must do :
29 29
30 30 aptitude install libapache-dbi-perl libapache2-mod-perl2 libdbd-mysql-perl
31 31
32 32 If your Redmine users use LDAP authentication, you will also need
33 33 Authen::Simple::LDAP (and IO::Socket::SSL if LDAPS is used):
34 34
35 35 aptitude install libauthen-simple-ldap-perl libio-socket-ssl-perl
36 36
37 37 =head1 CONFIGURATION
38 38
39 39 ## This module has to be in your perl path
40 40 ## eg: /usr/lib/perl5/Apache/Authn/Redmine.pm
41 41 PerlLoadModule Apache::Authn::Redmine
42 42 <Location /svn>
43 43 DAV svn
44 44 SVNParentPath "/var/svn"
45 45
46 46 AuthType Basic
47 47 AuthName redmine
48 48 Require valid-user
49 49
50 50 PerlAccessHandler Apache::Authn::Redmine::access_handler
51 51 PerlAuthenHandler Apache::Authn::Redmine::authen_handler
52 52
53 53 ## for mysql
54 54 RedmineDSN "DBI:mysql:database=databasename;host=my.db.server"
55 55 ## for postgres
56 56 # RedmineDSN "DBI:Pg:dbname=databasename;host=my.db.server"
57 57
58 58 RedmineDbUser "redmine"
59 59 RedmineDbPass "password"
60 60 ## Optional where clause (fulltext search would be slow and
61 61 ## database dependant).
62 62 # RedmineDbWhereClause "and members.role_id IN (1,2)"
63 63 ## Optional credentials cache size
64 64 # RedmineCacheCredsMax 50
65 65 </Location>
66 66
67 67 To be able to browse repository inside redmine, you must add something
68 68 like that :
69 69
70 70 <Location /svn-private>
71 71 DAV svn
72 72 SVNParentPath "/var/svn"
73 73 Order deny,allow
74 74 Deny from all
75 75 # only allow reading orders
76 76 <Limit GET PROPFIND OPTIONS REPORT>
77 77 Allow from redmine.server.ip
78 78 </Limit>
79 79 </Location>
80 80
81 81 and you will have to use this reposman.rb command line to create repository :
82 82
83 83 reposman.rb --redmine my.redmine.server --svn-dir /var/svn --owner www-data -u http://svn.server/svn-private/
84 84
85 85 =head1 MIGRATION FROM OLDER RELEASES
86 86
87 87 If you use an older reposman.rb (r860 or before), you need to change
88 88 rights on repositories to allow the apache user to read and write
89 89 S<them :>
90 90
91 91 sudo chown -R www-data /var/svn/*
92 92 sudo chmod -R u+w /var/svn/*
93 93
94 94 And you need to upgrade at least reposman.rb (after r860).
95 95
96 96 =cut
97 97
98 98 use strict;
99 99 use warnings FATAL => 'all', NONFATAL => 'redefine';
100 100
101 101 use DBI;
102 102 use Digest::SHA1;
103 103 # optional module for LDAP authentication
104 104 my $CanUseLDAPAuth = eval("use Authen::Simple::LDAP; 1");
105 105
106 106 use Apache2::Module;
107 107 use Apache2::Access;
108 108 use Apache2::ServerRec qw();
109 109 use Apache2::RequestRec qw();
110 110 use Apache2::RequestUtil qw();
111 111 use Apache2::Const qw(:common :override :cmd_how);
112 112 use APR::Pool ();
113 113 use APR::Table ();
114 114
115 115 # use Apache2::Directive qw();
116 116
117 117 my @directives = (
118 118 {
119 119 name => 'RedmineDSN',
120 120 req_override => OR_AUTHCFG,
121 121 args_how => TAKE1,
122 122 errmsg => 'Dsn in format used by Perl DBI. eg: "DBI:Pg:dbname=databasename;host=my.db.server"',
123 123 },
124 124 {
125 125 name => 'RedmineDbUser',
126 126 req_override => OR_AUTHCFG,
127 127 args_how => TAKE1,
128 128 },
129 129 {
130 130 name => 'RedmineDbPass',
131 131 req_override => OR_AUTHCFG,
132 132 args_how => TAKE1,
133 133 },
134 134 {
135 135 name => 'RedmineDbWhereClause',
136 136 req_override => OR_AUTHCFG,
137 137 args_how => TAKE1,
138 138 },
139 139 {
140 140 name => 'RedmineCacheCredsMax',
141 141 req_override => OR_AUTHCFG,
142 142 args_how => TAKE1,
143 143 errmsg => 'RedmineCacheCredsMax must be decimal number',
144 144 },
145 145 );
146 146
147 147 sub RedmineDSN {
148 148 my ($self, $parms, $arg) = @_;
149 149 $self->{RedmineDSN} = $arg;
150 150 my $query = "SELECT
151 151 hashed_password, auth_source_id, permissions
152 152 FROM members, projects, users, roles, member_roles
153 153 WHERE
154 154 projects.id=members.project_id
155 155 AND member_roles.member_id=members.id
156 156 AND users.id=members.user_id
157 157 AND roles.id=member_roles.role_id
158 158 AND users.status=1
159 159 AND login=?
160 160 AND identifier=? ";
161 161 $self->{RedmineQuery} = trim($query);
162 162 }
163 163
164 164 sub RedmineDbUser { set_val('RedmineDbUser', @_); }
165 165 sub RedmineDbPass { set_val('RedmineDbPass', @_); }
166 166 sub RedmineDbWhereClause {
167 167 my ($self, $parms, $arg) = @_;
168 168 $self->{RedmineQuery} = trim($self->{RedmineQuery}.($arg ? $arg : "")." ");
169 169 }
170 170
171 171 sub RedmineCacheCredsMax {
172 172 my ($self, $parms, $arg) = @_;
173 173 if ($arg) {
174 174 $self->{RedmineCachePool} = APR::Pool->new;
175 175 $self->{RedmineCacheCreds} = APR::Table::make($self->{RedmineCachePool}, $arg);
176 176 $self->{RedmineCacheCredsCount} = 0;
177 177 $self->{RedmineCacheCredsMax} = $arg;
178 178 }
179 179 }
180 180
181 181 sub trim {
182 182 my $string = shift;
183 183 $string =~ s/\s{2,}/ /g;
184 184 return $string;
185 185 }
186 186
187 187 sub set_val {
188 188 my ($key, $self, $parms, $arg) = @_;
189 189 $self->{$key} = $arg;
190 190 }
191 191
192 192 Apache2::Module::add(__PACKAGE__, \@directives);
193 193
194 194
195 195 my %read_only_methods = map { $_ => 1 } qw/GET PROPFIND REPORT OPTIONS/;
196 196
197 197 sub access_handler {
198 198 my $r = shift;
199 199
200 200 unless ($r->some_auth_required) {
201 201 $r->log_reason("No authentication has been configured");
202 202 return FORBIDDEN;
203 203 }
204 204
205 205 my $method = $r->method;
206 206 return OK unless defined $read_only_methods{$method};
207 207
208 208 my $project_id = get_project_identifier($r);
209 209
210 210 $r->set_handlers(PerlAuthenHandler => [\&OK])
211 211 if is_public_project($project_id, $r);
212 212
213 213 return OK
214 214 }
215 215
216 216 sub authen_handler {
217 217 my $r = shift;
218 218
219 219 my ($res, $redmine_pass) = $r->get_basic_auth_pw();
220 220 return $res unless $res == OK;
221 221
222 222 if (is_member($r->user, $redmine_pass, $r)) {
223 223 return OK;
224 224 } else {
225 225 $r->note_auth_failure();
226 226 return AUTH_REQUIRED;
227 227 }
228 228 }
229 229
230 230 sub is_public_project {
231 231 my $project_id = shift;
232 232 my $r = shift;
233 233
234 234 my $dbh = connect_database($r);
235 235 my $sth = $dbh->prepare(
236 236 "SELECT is_public FROM projects WHERE projects.identifier = ?;"
237 237 );
238 238
239 239 $sth->execute($project_id);
240 240 my $ret = 0;
241 241 if (my @row = $sth->fetchrow_array) {
242 242 if ($row[0] eq "1" || $row[0] eq "t") {
243 243 $ret = 1;
244 244 }
245 245 }
246 246 $sth->finish();
247 undef $sth;
247 248 $dbh->disconnect();
249 undef $dbh;
248 250
249 251 $ret;
250 252 }
251 253
252 254 # perhaps we should use repository right (other read right) to check public access.
253 255 # it could be faster BUT it doesn't work for the moment.
254 256 # sub is_public_project_by_file {
255 257 # my $project_id = shift;
256 258 # my $r = shift;
257 259
258 260 # my $tree = Apache2::Directive::conftree();
259 261 # my $node = $tree->lookup('Location', $r->location);
260 262 # my $hash = $node->as_hash;
261 263
262 264 # my $svnparentpath = $hash->{SVNParentPath};
263 265 # my $repos_path = $svnparentpath . "/" . $project_id;
264 266 # return 1 if (stat($repos_path))[2] & 00007;
265 267 # }
266 268
267 269 sub is_member {
268 270 my $redmine_user = shift;
269 271 my $redmine_pass = shift;
270 272 my $r = shift;
271 273
272 274 my $dbh = connect_database($r);
273 275 my $project_id = get_project_identifier($r);
274 276
275 277 my $pass_digest = Digest::SHA1::sha1_hex($redmine_pass);
276 278
277 279 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
278 280 my $usrprojpass;
279 281 if ($cfg->{RedmineCacheCredsMax}) {
280 282 $usrprojpass = $cfg->{RedmineCacheCreds}->get($redmine_user.":".$project_id);
281 283 return 1 if (defined $usrprojpass and ($usrprojpass eq $pass_digest));
282 284 }
283 285 my $query = $cfg->{RedmineQuery};
284 286 my $sth = $dbh->prepare($query);
285 287 $sth->execute($redmine_user, $project_id);
286 288
287 289 my $ret;
288 290 while (my ($hashed_password, $auth_source_id, $permissions) = $sth->fetchrow_array) {
289 291
290 292 unless ($auth_source_id) {
291 293 my $method = $r->method;
292 294 if ($hashed_password eq $pass_digest && ((defined $read_only_methods{$method} && $permissions =~ /:browse_repository/) || $permissions =~ /:commit_access/) ) {
293 295 $ret = 1;
294 296 last;
295 297 }
296 298 } elsif ($CanUseLDAPAuth) {
297 299 my $sthldap = $dbh->prepare(
298 300 "SELECT host,port,tls,account,account_password,base_dn,attr_login from auth_sources WHERE id = ?;"
299 301 );
300 302 $sthldap->execute($auth_source_id);
301 303 while (my @rowldap = $sthldap->fetchrow_array) {
302 304 my $ldap = Authen::Simple::LDAP->new(
303 305 host => ($rowldap[2] eq "1" || $rowldap[2] eq "t") ? "ldaps://$rowldap[0]" : $rowldap[0],
304 306 port => $rowldap[1],
305 307 basedn => $rowldap[5],
306 308 binddn => $rowldap[3] ? $rowldap[3] : "",
307 309 bindpw => $rowldap[4] ? $rowldap[4] : "",
308 310 filter => "(".$rowldap[6]."=%s)"
309 311 );
310 312 $ret = 1 if ($ldap->authenticate($redmine_user, $redmine_pass));
311 313 }
312 314 $sthldap->finish();
315 undef $sthldap;
313 316 }
314 317 }
315 318 $sth->finish();
319 undef $sth;
316 320 $dbh->disconnect();
321 undef $dbh;
317 322
318 323 if ($cfg->{RedmineCacheCredsMax} and $ret) {
319 324 if (defined $usrprojpass) {
320 325 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id, $pass_digest);
321 326 } else {
322 327 if ($cfg->{RedmineCacheCredsCount} < $cfg->{RedmineCacheCredsMax}) {
323 328 $cfg->{RedmineCacheCreds}->set($redmine_user.":".$project_id, $pass_digest);
324 329 $cfg->{RedmineCacheCredsCount}++;
325 330 } else {
326 331 $cfg->{RedmineCacheCreds}->clear();
327 332 $cfg->{RedmineCacheCredsCount} = 0;
328 333 }
329 334 }
330 335 }
331 336
332 337 $ret;
333 338 }
334 339
335 340 sub get_project_identifier {
336 341 my $r = shift;
337 342
338 343 my $location = $r->location;
339 344 my ($identifier) = $r->uri =~ m{$location/*([^/]+)};
340 345 $identifier;
341 346 }
342 347
343 348 sub connect_database {
344 349 my $r = shift;
345 350
346 351 my $cfg = Apache2::Module::get_config(__PACKAGE__, $r->server, $r->per_dir_config);
347 352 return DBI->connect($cfg->{RedmineDSN}, $cfg->{RedmineDbUser}, $cfg->{RedmineDbPass});
348 353 }
349 354
350 355 1;
General Comments 0
You need to be logged in to leave comments. Login now