jro_apps/redmine Commit - r2311:1ad255155949

Adds ability to bulk copy issues (#1847)....

Jean-Philippe Lang -

r2311:1ad255155949

parent child

Context file:

r2311:1ad255155949

Collapse all files

app/controllers/issues_controller.rb +1 -1

                   unsaved_issue_ids = []
                   @issues.each do |issue|
                     issue.init_journal(User.current)
-                    unsaved_issue_ids << issue.id unless issue.move_to(@target_project, new_tracker)
+                    unsaved_issue_ids << issue.id unless issue.move_to(@target_project, new_tracker, params[:copy_options])
                   end
                   if unsaved_issue_ids.empty?
                     flash[:notice] = l(:notice_successful_update) unless @issues.empty?

app/models/issue.rb +24 -15

                 self
               end
-              # Move an issue to a new project and tracker
+              # Moves/copies an issue to a new project and tracker
-              def move_to(new_project, new_tracker = nil)
+              # Returns the moved/copied issue on success, false on failure
+              def move_to(new_project, new_tracker = nil, options = {})
+                options ||= {}
+                issue = options[:copy] ? self.clone : self
                 transaction do
-                  if new_project && project_id != new_project.id
+                  if new_project && issue.project_id != new_project.id
                     # delete issue relations
                     unless Setting.cross_project_issue_relations?
-                      self.relations_from.clear
+                      issue.relations_from.clear
-                      self.relations_to.clear
+                      issue.relations_to.clear
                     end
                     # issue is moved to another project
                     # reassign to the category with same name if any
-                    new_category = category.nil? ? nil : new_project.issue_categories.find_by_name(category.name)
+                    new_category = issue.category.nil? ? nil : new_project.issue_categories.find_by_name(issue.category.name)
-                    self.category = new_category
+                    issue.category = new_category
-                    self.fixed_version = nil
+                    issue.fixed_version = nil
-                    self.project = new_project
+                    issue.project = new_project
                   end
                   if new_tracker
-                    self.tracker = new_tracker
+                    issue.tracker = new_tracker
                   end
-                  if save
+                  if options[:copy]
-                    # Manually update project_id on related time entries
+                    issue.custom_field_values = self.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
-                    TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
+                    issue.status = self.status
+                  end
+                  if issue.save
+                    unless options[:copy]
+                      # Manually update project_id on related time entries
+                      TimeEntry.update_all("project_id = #{new_project.id}", {:issue_id => id})
+                    end
                   else
-                    rollback_db_transaction
+                    Issue.connection.rollback_db_transaction
                     return false
                   end
                 end
-                return true
+                return issue
               end
               def priority_id=(pid)

app/views/issues/move.rhtml +3 0

             <p><label for="new_tracker_id"><%=l(:field_tracker)%> :</label>
             <%= select_tag "new_tracker_id", "<option value=\"\">#{l(:label_no_change_option)}</option>" + options_from_collection_for_select(@trackers, "id", "name") %></p>
+            <p><label for="copy_options_copy"><%= l(:button_copy)%></label>
+            <%= check_box_tag "copy_options[copy]", "1" %></p>
             </div>
             <%= submit_tag l(:button_move) %>

test/functional/issues_controller_test.rb +10 0

@@ -672,6 +672,16 class IssuesControllerTest < Test::Unit::TestCase
672	assert_equal 2, Issue.find(1).tracker_id	672	assert_equal 2, Issue.find(1).tracker_id
673	assert_equal 2, Issue.find(2).tracker_id	673	assert_equal 2, Issue.find(2).tracker_id
674	end	674	end
		675
		676	def test_bulk_copy_to_another_project
		677	@request.session[:user_id] = 1
		678	assert_difference 'Issue.count', 2 do
		679	assert_no_difference 'Project.find(1).issues.count' do
		680	post :move, :ids => [1, 2], :new_project_id => 2, :copy_options => {:copy => '1'}
		681	end
		682	end
		683	assert_redirected_to 'projects/ecookbook/issues'
		684	end
675		685
676	def test_context_menu_one_issue	686	def test_context_menu_one_issue
677	@request.session[:user_id] = 2	687	@request.session[:user_id] = 2

test/unit/issue_test.rb +24 0

@@ -191,6 +191,30 class IssueTest < Test::Unit::TestCase
191	assert_nil issue.category_id	191	assert_nil issue.category_id
192	end	192	end
193		193
		194	def test_copy_to_the_same_project
		195	issue = Issue.find(1)
		196	copy = nil
		197	assert_difference 'Issue.count' do
		198	copy = issue.move_to(issue.project, nil, :copy => true)
		199	end
		200	assert_kind_of Issue, copy
		201	assert_equal issue.project, copy.project
		202	assert_equal "125", copy.custom_value_for(2).value
		203	end
		204
		205	def test_copy_to_another_project_and_tracker
		206	issue = Issue.find(1)
		207	copy = nil
		208	assert_difference 'Issue.count' do
		209	copy = issue.move_to(Project.find(3), Tracker.find(2), :copy => true)
		210	end
		211	assert_kind_of Issue, copy
		212	assert_equal Project.find(3), copy.project
		213	assert_equal Tracker.find(2), copy.tracker
		214	# Custom field #2 is not associated with target tracker
		215	assert_nil copy.custom_value_for(2)
		216	end
		217
194	def test_issue_destroy	218	def test_issue_destroy
195	Issue.find(1).destroy	219	Issue.find(1).destroy
196	assert_nil Issue.find_by_id(1)	220	assert_nil Issue.find_by_id(1)

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages