jro_apps/redmine Commit - r15901:19d2529faa25

Check permission of wiki pages before generating a link to it (#23793)....

Jean-Philippe Lang -

r15901:19d2529faa25

parent child

Context file:

r15901:19d2529faa25

app/helpers/application_helper.rb +1 -1

                       title ||= identifier if page.blank?
                     end
-                    if link_project && link_project.wiki
+                    if link_project && link_project.wiki && User.current.allowed_to?(:view_wiki_pages, link_project)
                       # extract anchor
                       anchor = nil
                       if page =~ /^(.+?)\#(.+)$/

test/fixtures/wikis.yml +5 0

test/unit/helpers/application_helper_test.rb +4 0

               end
               def test_wiki_links
+                User.current = User.find_by_login('jsmith')
                 russian_eacape = CGI.escape(@russian_test)
                 to_test = {
                   '[[CookBook documentation]]' =>
                   # project does not exist
                   '[[unknowproject:Start]]' => '[[unknowproject:Start]]',
                   '[[unknowproject:Start|Page title]]' => '[[unknowproject:Start|Page title]]',
+                  # missing permission to view wiki in project
+                  '[[private-child:]]' => '[[private-child:]]',
+                  '[[private-child:Wiki]]' => '[[private-child:Wiki]]',
                 }
                 @project = Project.find(1)
                 to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text) }

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages