jro_apps/redmine Commit - r12363:190bb9af3048

Rails4: replace deprecated Relation#first with finder options at IssuesControllerTransactionTest...

Toshi MARUYAMA -

r12363:190bb9af3048

parent child

Context file:

r12363:190bb9af3048

test/functional/issues_controller_transaction_test.rb +3 -3

                 assert_response :success
                 assert_template 'edit'
-                attachment = Attachment.first(:order => 'id DESC')
+                attachment = Attachment.order('id DESC').first
                 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
                 assert_tag 'input', :attributes => {:name => 'attachments[p0][filename]', :value => 'testfile.txt'}
               end
                 assert_response 302
                 issue = Issue.find(1)
                 assert_equal 4, issue.fixed_version_id
-                journal = Journal.first(:order => 'id DESC')
+                journal = Journal.order('id DESC').first
                 assert_equal 'overwrite_conflict_resolution', journal.notes
                 assert journal.details.any?
               end
                 assert_response 302
                 issue = Issue.find(1)
                 assert_nil issue.fixed_version_id
-                journal = Journal.first(:order => 'id DESC')
+                journal = Journal.order('id DESC').first
                 assert_equal 'add_notes_conflict_resolution', journal.notes
                 assert journal.details.empty?
               end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages