jro_apps/redmine Commit - r14253:16cc9ec06a57

Activate sudo mode after password based login (#20589)....

Jean-Philippe Lang -

r14253:16cc9ec06a57

parent child

Context file:

r14253:16cc9ec06a57

Collapse all files

app/controllers/account_controller.rb +1 0

                   # Valid user
                   if user.active?
                     successful_authentication(user)
+                    update_sudo_timestamp! # activate Sudo Mode
                   else
                     handle_inactive_user(user)
                   end

test/integration/sudo_mode_test.rb +27 0

                 Redmine::SudoMode.stubs(:enabled?).returns(true)
               end
+              def test_sudo_mode_should_be_active_after_login
+                log_user("admin", "admin")
+                get "/users/new"
+                assert_response :success
+                post "/users",
+                     :user => { :login => "psmith", :firstname => "Paul",
+                                :lastname => "Smith", :mail => "psmith@somenet.foo",
+                                :language => "en", :password => "psmith09",
+                                :password_confirmation => "psmith09" }
+                assert_response 302
+                user = User.find_by_login("psmith")
+                assert_kind_of User, user
+              end
               def test_add_user
                 log_user("admin", "admin")
+                expire_sudo_mode!
                 get "/users/new"
                 assert_response :success
                 post "/users",
               def test_create_member_xhr
                 log_user 'admin', 'admin'
+                expire_sudo_mode!
                 get '/projects/ecookbook/settings/members'
                 assert_response :success
               def test_create_member
                 log_user 'admin', 'admin'
+                expire_sudo_mode!
                 get '/projects/ecookbook/settings/members'
                 assert_response :success
               def test_create_role
                 log_user 'admin', 'admin'
+                expire_sudo_mode!
                 get '/roles'
                 assert_response :success
               def test_update_email_address
                 log_user 'jsmith', 'jsmith'
+                expire_sudo_mode!
                 get '/my/account'
                 assert_response :success
                 post '/my/account', user: { mail: 'newmail@test.com' }
                   end
                 end
               end
+              private
+              # sudo mode is active after sign, let it expire by advancing the time
+              def expire_sudo_mode!
+                travel_to 20.minutes.from_now
+              end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages