jro_apps/redmine Commit - r2056:131b15fc7a0d

Fix access to Repository Parent Path (FORBIDEN instead of AUTH_REQUIRED)....

Liwiusz Ociepa -

r2056:131b15fc7a0d swistak

parent child

Context file:

r2056:131b15fc7a0d

extra/svn/Redmine.pm +7 -3

               my ($res, $redmine_pass) =  $r->get_basic_auth_pw();
               return $res unless $res == OK;
-              if (is_member($r->user, $redmine_pass, $r)) {
+              my $project_id  = get_project_identifier($r);
+              if (!$project_id) {
+                return FORBIDDEN;
+              }
+              if (is_member($r->user, $redmine_pass, $r, $project_id)) {
                   return OK;
               } else {
                   $r->note_auth_failure();
               my $redmine_user = shift;
               my $redmine_pass = shift;
               my $r = shift;
+              my $project_id = shift;
               my $dbh         = connect_database($r);
-              my $project_id  = get_project_identifier($r);
               my $pass_digest = Digest::SHA1::sha1_hex($redmine_pass);
                 my $location = $r->location;
                 my ($identifier) = $r->uri =~ m{$location/*([^/]+)};
-                $identifier ? $identifier : " ";
+                $identifier;
             }
             sub connect_database {

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages