jro_apps/redmine Commit - r676:1281d99f3057

Added the ability to move issues (to another project) without changing their trackers....

Jean-Philippe Lang -

r676:1281d99f3057

parent child

Context file:

r676:1281d99f3057

Collapse all files

app/controllers/projects_controller.rb +10 -9

                 # issue can be moved to any tracker
                 @trackers = Tracker.find(:all)
                 if request.post? and params[:new_project_id] and params[:new_tracker_id]
-                  new_project = Project.find(params[:new_project_id])
+                  new_project = Project.find_by_id(params[:new_project_id])
-                  new_tracker = Tracker.find(params[:new_tracker_id])
+                  new_tracker = Tracker.find_by_id(params[:new_tracker_id])
-                  @issues.each { |i|
+                  @issues.each do |i|
-                    # project dependent properties
+                    if new_project && i.project_id != new_project.id
-                    unless i.project_id == new_project.id
+                      # issue is moved to another project
                       i.category = nil
                       i.fixed_version = nil
                       # delete issue relations
                       i.relations_from.clear
                       i.relations_to.clear
+                      i.project = new_project
+                    end
+                    if new_tracker
+                      i.tracker = new_tracker
                     end
-                    # move the issue
-                    i.project = new_project
-                    i.tracker = new_tracker
                     i.save
+                  end
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to :action => 'list_issues', :id => @project
                 end

app/models/project.rb +1 0

               validates_length_of :name, :maximum => 30
               validates_format_of :name, :with => /^[\w\s\'\-]*$/i
               validates_length_of :description, :maximum => 255
+              validates_length_of :homepage, :maximum => 30
               validates_length_of :identifier, :in => 3..12
               validates_format_of :identifier, :with => /^[a-z0-9\-]*$/

app/views/projects/move_issues.rhtml +4 -4

             <% form_tag({:action => 'move_issues', :id => @project}, :class => "tabular") do %>
             <div class="box">
-            <p><label><%= l(:label_issue_plural) %>:</label>
+            <p><label><%= l(:label_issue_plural) %> :</label>
             <% for issue in @issues %>
                 <%= link_to_issue issue %>: <%=h issue.subject %>
                 <%= hidden_field_tag "issue_ids[]", issue.id %><br />
             &nbsp;
             <!--[form:issue]-->
-            <p><label for="new_project_id"><%=l(:field_project)%></label>
+            <p><label for="new_project_id"><%=l(:field_project)%> :</label>
             <%= select_tag "new_project_id", options_from_collection_for_select(@projects, "id", "name", @project.id) %></p>
-            <p><label for="new_tracker_id"><%=l(:field_tracker)%></label>
+            <p><label for="new_tracker_id"><%=l(:field_tracker)%> :</label>
-            <%= select_tag "new_tracker_id", options_from_collection_for_select(@trackers, "id", "name") %></p>
+            <%= select_tag "new_tracker_id", '<option></option>' + options_from_collection_for_select(@trackers, "id", "name") %></p>
             </div>
             <%= submit_tag l(:button_move) %>
             <% end %>

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages