jro_apps/redmine Commit - r11556:1269e6c7d3f5

Display the bulk edit form with error messages when some issues can not be saved (#13943)....

Jean-Philippe Lang -

r11556:1269e6c7d3f5

parent child

Context file:

r11556:1269e6c7d3f5

Collapse all files

The requested changes are too big and content was truncated. Show full diff

app/controllers/application_controller.rb 0 -15

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require 'uri'
              require 'cgi'
              class Unauthorized < Exception; end
              class ApplicationController < ActionController::Base
                include Redmine::I18n
                include Redmine::Pagination
                include RoutesHelper
                helper :routes
                class_attribute :accept_api_auth_actions
                class_attribute :accept_rss_auth_actions
                class_attribute :model_object
                layout 'base'
                protect_from_forgery
                def handle_unverified_request
                  super
                  cookies.delete(autologin_cookie_name)
                end
                before_filter :session_expiration, :user_setup, :check_if_login_required, :set_localization
                rescue_from ActionController::InvalidAuthenticityToken, :with => :invalid_authenticity_token
                rescue_from ::Unauthorized, :with => :deny_access
                rescue_from ::ActionView::MissingTemplate, :with => :missing_template
                include Redmine::Search::Controller
                include Redmine::MenuManager::MenuController
                helper Redmine::MenuManager::MenuHelper
                def session_expiration
                  if session[:user_id]
                    if session_expired? && !try_to_autologin
                      reset_session
                      flash[:error] = l(:error_session_expired)
                      redirect_to signin_url
                    else
                      session[:atime] = Time.now.utc.to_i
                    end
                  end
                end
                def session_expired?
                  if Setting.session_lifetime?
                    unless session[:ctime] && (Time.now.utc.to_i - session[:ctime].to_i <= Setting.session_lifetime.to_i * 60)
                      return true
                    end
                  end
                  if Setting.session_timeout?
                    unless session[:atime] && (Time.now.utc.to_i - session[:atime].to_i <= Setting.session_timeout.to_i * 60)
                      return true
                    end
                  end
                  false
                end
                def start_user_session(user)
                  session[:user_id] = user.id
                  session[:ctime] = Time.now.utc.to_i
                  session[:atime] = Time.now.utc.to_i
                end
                def user_setup
                  # Check the settings cache for each request
                  Setting.check_cache
                  # Find the current user
                  User.current = find_current_user
                  logger.info("  Current user: " + (User.current.logged? ? "#{User.current.login} (id=#{User.current.id})" : "anonymous")) if logger
                end
                # Returns the current user or nil if no user is logged in
                # and starts a session if needed
                def find_current_user
                  user = nil
                  unless api_request?
                    if session[:user_id]
                      # existing session
                      user = (User.active.find(session[:user_id]) rescue nil)
                    elsif autologin_user = try_to_autologin
                      user = autologin_user
                    elsif params[:format] == 'atom' && params[:key] && request.get? && accept_rss_auth?
                      # RSS key authentication does not start a session
                      user = User.find_by_rss_key(params[:key])
                    end
                  end
                  if user.nil? && Setting.rest_api_enabled? && accept_api_auth?
                    if (key = api_key_from_request)
                      # Use API key
                      user = User.find_by_api_key(key)
                    else
                      # HTTP Basic, either username/password or API key/random
                      authenticate_with_http_basic do |username, password|
                        user = User.try_to_login(username, password) || User.find_by_api_key(username)
                      end
                    end
                    # Switch user if requested by an admin user
                    if user && user.admin? && (username = api_switch_user_from_request)
                      su = User.find_by_login(username)
                      if su && su.active?
                        logger.info("  User switched by: #{user.login} (id=#{user.id})") if logger
                        user = su
                      else
                        render_error :message => 'Invalid X-Redmine-Switch-User header', :status => 412
                      end
                    end
                  end
                  user
                end
                def autologin_cookie_name
                  Redmine::Configuration['autologin_cookie_name'].presence || 'autologin'
                end
                def try_to_autologin
                  if cookies[autologin_cookie_name] && Setting.autologin?
                    # auto-login feature starts a new session
                    user = User.try_to_autologin(cookies[autologin_cookie_name])
                    if user
                      reset_session
                      start_user_session(user)
                    end
                    user
                  end
                end
                # Sets the logged in user
                def logged_user=(user)
                  reset_session
                  if user && user.is_a?(User)
                    User.current = user
                    start_user_session(user)
                  else
                    User.current = User.anonymous
                  end
                end
                # Logs out current user
                def logout_user
                  if User.current.logged?
                    cookies.delete(autologin_cookie_name)
                    Token.delete_all(["user_id = ? AND action = ?", User.current.id, 'autologin'])
                    self.logged_user = nil
                  end
                end
                # check if login is globally required to access the application
                def check_if_login_required
                  # no check needed if user is already logged in
                  return true if User.current.logged?
                  require_login if Setting.login_required?
                end
                def set_localization
                  lang = nil
                  if User.current.logged?
                    lang = find_language(User.current.language)
                  end
                  if lang.nil? && request.env['HTTP_ACCEPT_LANGUAGE']
                    accept_lang = parse_qvalues(request.env['HTTP_ACCEPT_LANGUAGE']).first
                    if !accept_lang.blank?
                      accept_lang = accept_lang.downcase
                      lang = find_language(accept_lang) || find_language(accept_lang.split('-').first)
                    end
                  end
                  lang ||= Setting.default_language
                  set_language_if_valid(lang)
                end
                def require_login
                  if !User.current.logged?
                    # Extract only the basic url parameters on non-GET requests
                    if request.get?
                      url = url_for(params)
                    else
                      url = url_for(:controller => params[:controller], :action => params[:action], :id => params[:id], :project_id => params[:project_id])
                    end
                    respond_to do |format|
                      format.html { redirect_to :controller => "account", :action => "login", :back_url => url }
                      format.atom { redirect_to :controller => "account", :action => "login", :back_url => url }
                      format.xml  { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                      format.js   { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                      format.json { head :unauthorized, 'WWW-Authenticate' => 'Basic realm="Redmine API"' }
                    end
                    return false
                  end
                  true
                end
                def require_admin
                  return unless require_login
                  if !User.current.admin?
                    render_403
                    return false
                  end
                  true
                end
                def deny_access
                  User.current.logged? ? render_403 : require_login
                end
                # Authorize the user for the requested action
                def authorize(ctrl = params[:controller], action = params[:action], global = false)
                  allowed = User.current.allowed_to?({:controller => ctrl, :action => action}, @project || @projects, :global => global)
                  if allowed
                    true
                  else
                    if @project && @project.archived?
                      render_403 :message => :notice_not_authorized_archived_project
                    else
                      deny_access
                    end
                  end
                end
                # Authorize the user for the requested action outside a project
                def authorize_global(ctrl = params[:controller], action = params[:action], global = true)
                  authorize(ctrl, action, global)
                end
                # Find project of id params[:id]
                def find_project
                  @project = Project.find(params[:id])
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find project of id params[:project_id]
                def find_project_by_project_id
                  @project = Project.find(params[:project_id])
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find a project based on params[:project_id]
                # TODO: some subclasses override this, see about merging their logic
                def find_optional_project
                  @project = Project.find(params[:project_id]) unless params[:project_id].blank?
                  allowed = User.current.allowed_to?({:controller => params[:controller], :action => params[:action]}, @project, :global => true)
                  allowed ? true : deny_access
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Finds and sets @project based on @object.project
                def find_project_from_association
                  render_404 unless @object.present?
                  @project = @object.project
                end
                def find_model_object
                  model = self.class.model_object
                  if model
                    @object = model.find(params[:id])
                    self.instance_variable_set('@' + controller_name.singularize, @object) if @object
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def self.model_object(model)
                  self.model_object = model
                end
                # Find the issue whose id is the :id parameter
                # Raises a Unauthorized exception if the issue is not visible
                def find_issue
                  # Issue.visible.find(...) can not be used to redirect user to the login form
                  # if the issue actually exists but requires authentication
                  @issue = Issue.find(params[:id])
                  raise Unauthorized unless @issue.visible?
                  @project = @issue.project
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                # Find issues with a single :id param or :ids array param
                # Raises a Unauthorized exception if one of the issues is not visible
                def find_issues
                  @issues = Issue.find_all_by_id(params[:id] || params[:ids])
                  raise ActiveRecord::RecordNotFound if @issues.empty?
                  raise Unauthorized unless @issues.all?(&:visible?)
                  @projects = @issues.collect(&:project).compact.uniq
                  @project = @projects.first if @projects.size == 1
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def find_attachments
                  if (attachments = params[:attachments]).present?
                    att = attachments.values.collect do |attachment|
                      Attachment.find_by_token( attachment[:token] ) if attachment[:token].present?
                    end
                    att.compact!
                  end
                  @attachments = att || []
                end
                # make sure that the user is a member of the project (or admin) if project is private
                # used as a before_filter for actions that do not require any particular permission on the project
                def check_project_privacy
                  if @project && !@project.archived?
                    if @project.visible?
                      true
                    else
                      deny_access
                    end
                  else
                    @project = nil
                    render_404
                    false
                  end
                end
                def back_url
                  url = params[:back_url]
                  if url.nil? && referer = request.env['HTTP_REFERER']
                    url = CGI.unescape(referer.to_s)
                  end
                  url
                end
                def redirect_back_or_default(default)
                  back_url = params[:back_url].to_s
                  if back_url.present?
                    begin
                      uri = URI.parse(back_url)
                      # do not redirect user to another host or to the login or register page
                      if (uri.relative? || (uri.host == request.host)) && !uri.path.match(%r{/(login|account/register)})
                        redirect_to(back_url)
                        return
                      end
                    rescue URI::InvalidURIError
                      logger.warn("Could not redirect to invalid URL #{back_url}")
                      # redirect to default
                    end
                  end
                  redirect_to default
                  false
                end
                # Redirects to the request referer if present, redirects to args or call block otherwise.
                def redirect_to_referer_or(*args, &block)
                  redirect_to :back
                rescue ::ActionController::RedirectBackError
                  if args.any?
                    redirect_to *args
                  elsif block_given?
                    block.call
                  else
                    raise "#redirect_to_referer_or takes arguments or a block"
                  end
                end
                def render_403(options={})
                  @project = nil
                  render_error({:message => :notice_not_authorized, :status => 403}.merge(options))
                  return false
                end
                def render_404(options={})
                  render_error({:message => :notice_file_not_found, :status => 404}.merge(options))
                  return false
                end
                # Renders an error response
                def render_error(arg)
                  arg = {:message => arg} unless arg.is_a?(Hash)
                  @message = arg[:message]
                  @message = l(@message) if @message.is_a?(Symbol)
                  @status = arg[:status] || 500
                  respond_to do |format|
                    format.html {
                      render :template => 'common/error', :layout => use_layout, :status => @status
                    }
                    format.any { head @status }
                  end
                end
                # Handler for ActionView::MissingTemplate exception
                def missing_template
                  logger.warn "Missing template, responding with 404"
                  @project = nil
                  render_404
                end
                # Filter for actions that provide an API response
                # but have no HTML representation for non admin users
                def require_admin_or_api_request
                  return true if api_request?
                  if User.current.admin?
                    true
                  elsif User.current.logged?
                    render_error(:status => 406)
                  else
                    deny_access
                  end
                end
                # Picks which layout to use based on the request
                #
                # @return [boolean, string] name of the layout to use or false for no layout
                def use_layout
                  request.xhr? ? false : 'base'
                end
                def invalid_authenticity_token
                  if api_request?
                    logger.error "Form authenticity token is missing or is invalid. API calls must include a proper Content-type header (text/xml or text/json)."
                  end
                  render_error "Invalid form authenticity token."
                end
                def render_feed(items, options={})
                  @items = items || []
                  @items.sort! {|x,y| y.event_datetime <=> x.event_datetime }
                  @items = @items.slice(0, Setting.feeds_limit.to_i)
                  @title = options[:title] || Setting.app_title
                  render :template => "common/feed", :formats => [:atom], :layout => false,
                         :content_type => 'application/atom+xml'
                end
                def self.accept_rss_auth(*actions)
                  if actions.any?
                    self.accept_rss_auth_actions = actions
                  else
                    self.accept_rss_auth_actions || []
                  end
                end
                def accept_rss_auth?(action=action_name)
                  self.class.accept_rss_auth.include?(action.to_sym)
                end
                def self.accept_api_auth(*actions)
                  if actions.any?
                    self.accept_api_auth_actions = actions
                  else
                    self.accept_api_auth_actions || []
                  end
                end
                def accept_api_auth?(action=action_name)
                  self.class.accept_api_auth.include?(action.to_sym)
                end
                # Returns the number of objects that should be displayed
                # on the paginated list
                def per_page_option
                  per_page = nil
                  if params[:per_page] && Setting.per_page_options_array.include?(params[:per_page].to_s.to_i)
                    per_page = params[:per_page].to_s.to_i
                    session[:per_page] = per_page
                  elsif session[:per_page]
                    per_page = session[:per_page]
                  else
                    per_page = Setting.per_page_options_array.first || 25
                  end
                  per_page
                end
                # Returns offset and limit used to retrieve objects
                # for an API response based on offset, limit and page parameters
                def api_offset_and_limit(options=params)
                  if options[:offset].present?
                    offset = options[:offset].to_i
                    if offset < 0
                      offset = 0
                    end
                  end
                  limit = options[:limit].to_i
                  if limit < 1
                    limit = 25
                  elsif limit > 100
                    limit = 100
                  end
                  if offset.nil? && options[:page].present?
                    offset = (options[:page].to_i - 1) * limit
                    offset = 0 if offset < 0
                  end
                  offset ||= 0
                  [offset, limit]
                end
                # qvalues http header parser
                # code taken from webrick
                def parse_qvalues(value)
                  tmp = []
                  if value
                    parts = value.split(/,\s*/)
                    parts.each {|part|
                      if m = %r{^([^\s,]+?)(?:;\s*q=(\d+(?:\.\d+)?))?$}.match(part)
                        val = m[1]
                        q = (m[2] or 1).to_f
                        tmp.push([val, q])
                      end
                    }
                    tmp = tmp.sort_by{|val, q| -q}
                    tmp.collect!{|val, q| val}
                  end
                  return tmp
                rescue
                  nil
                end
                # Returns a string that can be used as filename value in Content-Disposition header
                def filename_for_content_disposition(name)
                  request.env['HTTP_USER_AGENT'] =~ %r{MSIE} ? ERB::Util.url_encode(name) : name
                end
                def api_request?
                  %w(xml json).include? params[:format]
                end
                # Returns the API key present in the request
                def api_key_from_request
                  if params[:key].present?
                    params[:key].to_s
                  elsif request.headers["X-Redmine-API-Key"].present?
                    request.headers["X-Redmine-API-Key"].to_s
                  end
                end
                # Returns the API 'switch user' value if present
                def api_switch_user_from_request
                  request.headers["X-Redmine-Switch-User"].to_s.presence
                end
                # Renders a warning flash if obj has unsaved attachments
                def render_attachment_warning_if_needed(obj)
                  flash[:warning] = l(:warning_attachments_not_saved, obj.unsaved_attachments.size) if obj.unsaved_attachments.present?
                end
-               # Sets the `flash` notice or error based the number of issues that did not save
+               #
-               # @param [Array, Issue] issues all of the saved and unsaved Issues
-               # @param [Array, Integer] unsaved_issue_ids the issue ids that were not saved
-               def set_flash_from_bulk_issue_save(issues, unsaved_issue_ids)
-                 if unsaved_issue_ids.empty?
-                   flash[:notice] = l(:notice_successful_update) unless issues.empty?
-                 else
-                   flash[:error] = l(:notice_failed_to_save_issues,
-                                     :count => unsaved_issue_ids.size,
-                                     :total => issues.size,
-                                     :ids => '#' + unsaved_issue_ids.join(', #'))
-                 end
-               end
                # Rescues an invalid query statement. Just in case...
                def query_statement_invalid(exception)
                  logger.error "Query::StatementInvalid: #{exception.message}" if logger
                  session.delete(:query)
                  sort_clear if respond_to?(:sort_clear)
                  render_error "An error occurred while executing the query and has been logged. Please report this error to your Redmine administrator."
                end
                # Renders a 200 response for successfull updates or deletions via the API
                def render_api_ok
                  render_api_head :ok
                end
                # Renders a head API response
                def render_api_head(status)
                  # #head would return a response body with one space
                  render :text => '', :status => status, :layout => nil
                end
                # Renders API response on validation failure
                def render_validation_errors(objects)
                  if objects.is_a?(Array)
                    @error_messages = objects.map {|object| object.errors.full_messages}.flatten
                  else
                    @error_messages = objects.errors.full_messages
                  end
                  render :template => 'common/error_messages.api', :status => :unprocessable_entity, :layout => nil
                end
                # Overrides #_include_layout? so that #render with no arguments
                # doesn't use the layout for api requests
                def _include_layout?(*args)
                  api_request? ? false : super
                end
              end

app/controllers/issues_controller.rb +17 -12

              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class IssuesController < ApplicationController
                menu_item :new_issue, :only => [:new, :create]
                default_search_scope :issues
                before_filter :find_issue, :only => [:show, :edit, :update]
                before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
                before_filter :find_project, :only => [:new, :create, :update_form]
                before_filter :authorize, :except => [:index]
                before_filter :find_optional_project, :only => [:index]
                before_filter :check_for_default_issue_status, :only => [:new, :create]
                before_filter :build_new_issue_from_params, :only => [:new, :create, :update_form]
                accept_rss_auth :index, :show
                accept_api_auth :index, :show, :create, :update, :destroy
                rescue_from Query::StatementInvalid, :with => :query_statement_invalid
                helper :journals
                helper :projects
                include ProjectsHelper
                helper :custom_fields
                include CustomFieldsHelper
                helper :issue_relations
                include IssueRelationsHelper
                helper :watchers
                include WatchersHelper
                helper :attachments
                include AttachmentsHelper
                helper :queries
                include QueriesHelper
                helper :repositories
                include RepositoriesHelper
                helper :sort
                include SortHelper
                include IssuesHelper
                helper :timelog
                include Redmine::Export::PDF
                def index
                  retrieve_query
                  sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                  sort_update(@query.sortable_columns)
                  @query.sort_criteria = sort_criteria.to_a
                  if @query.valid?
                    case params[:format]
                    when 'csv', 'pdf'
                      @limit = Setting.issues_export_limit.to_i
                    when 'atom'
                      @limit = Setting.feeds_limit.to_i
                    when 'xml', 'json'
                      @offset, @limit = api_offset_and_limit
                    else
                      @limit = per_page_option
                    end
                    @issue_count = @query.issue_count
                    @issue_pages = Paginator.new @issue_count, @limit, params['page']
                    @offset ||= @issue_pages.offset
                    @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
                                            :order => sort_clause,
                                            :offset => @offset,
                                            :limit => @limit)
                    @issue_count_by_group = @query.issue_count_by_group
                    respond_to do |format|
                      format.html { render :template => 'issues/index', :layout => !request.xhr? }
                      format.api  {
                        Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
                      }
                      format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
                      format.csv  { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') }
                      format.pdf  { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'issues.pdf') }
                    end
                  else
                    respond_to do |format|
                      format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
                      format.any(:atom, :csv, :pdf) { render(:nothing => true) }
                      format.api { render_validation_errors(@query) }
                    end
                  end
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def show
                  @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
                  @journals.each_with_index {|j,i| j.indice = i+1}
                  @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                  @journals.reverse! if User.current.wants_comments_in_reverse_order?
                  @changesets = @issue.changesets.visible.all
                  @changesets.reverse! if User.current.wants_comments_in_reverse_order?
                  @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                  @priorities = IssuePriority.active
                  @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                  @relation = IssueRelation.new
                  respond_to do |format|
                    format.html {
                      retrieve_previous_and_next_issue_ids
                      render :template => 'issues/show'
                    }
                    format.api
                    format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
                    format.pdf  {
                      pdf = issue_to_pdf(@issue, :journals => @journals)
                      send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
                    }
                  end
                end
                # Add a new issue
                # The new issue will be created from an existing one if copy_from parameter is given
                def new
                  respond_to do |format|
                    format.html { render :action => 'new', :layout => !request.xhr? }
                  end
                end
                def create
                  call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
                  @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                  if @issue.save
                    call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
                    respond_to do |format|
                      format.html {
                        render_attachment_warning_if_needed(@issue)
                        flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
                        if params[:continue]
                          attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
                          redirect_to new_project_issue_path(@issue.project, :issue => attrs)
                        else
                          redirect_to issue_path(@issue)
                        end
                      }
                      format.api  { render :action => 'show', :status => :created, :location => issue_url(@issue) }
                    end
                    return
                  else
                    respond_to do |format|
                      format.html { render :action => 'new' }
                      format.api  { render_validation_errors(@issue) }
                    end
                  end
                end
                def edit
                  return unless update_issue_from_params
                  respond_to do |format|
                    format.html { }
                    format.xml  { }
                  end
                end
                def update
                  return unless update_issue_from_params
                  @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
                  saved = false
                  begin
                    saved = @issue.save_issue_with_child_records(params, @time_entry)
                  rescue ActiveRecord::StaleObjectError
                    @conflict = true
                    if params[:last_journal_id]
                      @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
                      @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
                    end
                  end
                  if saved
                    render_attachment_warning_if_needed(@issue)
                    flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
                    respond_to do |format|
                      format.html { redirect_back_or_default issue_path(@issue) }
                      format.api  { render_api_ok }
                    end
                  else
                    respond_to do |format|
                      format.html { render :action => 'edit' }
                      format.api  { render_validation_errors(@issue) }
                    end
                  end
                end
                # Updates the issue form when changing the project, status or tracker
                # on issue creation/update
                def update_form
                end
                # Bulk edit/copy a set of issues
                def bulk_edit
                  @issues.sort!
                  @copy = params[:copy].present?
                  @notes = params[:notes]
                  if User.current.allowed_to?(:move_issues, @projects)
                    @allowed_projects = Issue.allowed_target_projects_on_move
                    if params[:issue]
                      @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
                      if @target_project
                        target_projects = [@target_project]
                      end
                    end
                  end
                  target_projects ||= @projects
                  if @copy
                    @available_statuses = [IssueStatus.default]
                  else
                    @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
                  end
                  @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
                  @assignables = target_projects.map(&:assignable_users).reduce(:&)
                  @trackers = target_projects.map(&:trackers).reduce(:&)
                  @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
                  @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
                  if @copy
                    @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
                    @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
                  end
                  @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
-                 render :layout => false if request.xhr?
                end
                def bulk_update
                  @issues.sort!
                  @copy = params[:copy].present?
                  attributes = parse_params_for_bulk_issue_attributes(params)
-                 unsaved_issue_ids = []
-                 moved_issues = []
+                 unsaved_issues = []
+                 saved_issues = []
                  if @copy && params[:copy_subtasks].present?
                    # Descendant issues will be copied with the parent task
                    # Don't copy them twice
                    @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
                  end
                  @issues.each do |issue|
                    issue.reload
                    if @copy
                      issue = issue.copy({},
                        :attachments => params[:copy_attachments].present?,
                        :subtasks => params[:copy_subtasks].present?
                      )
                    end
                    journal = issue.init_journal(User.current, params[:notes])
                    issue.safe_attributes = attributes
                    call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
                    if issue.save
-                     moved_issues << issue
+                     saved_issues << issue
                    else
-                     logger.info "issue could not be updated or copied: #{issue.errors.full_messages}" if logger && logger.info
-                     # Keep unsaved issue ids to display them in flash error
-                     unsaved_issue_ids << issue.id
+                     unsaved_issues << issue
                    end
                  end
-                 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
+                 if unsaved_issues.empty?
+                   flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
                  if params[:follow]
-                   if @issues.size == 1 && moved_issues.size == 1
-                     redirect_to issue_path(moved_issues.first)
-                   elsif moved_issues.map(&:project).uniq.size == 1
-                     redirect_to project_issues_path(moved_issues.map(&:project).first)
+                     if @issues.size == 1 && saved_issues.size == 1
+                       redirect_to issue_path(saved_issues.first)
+                     elsif saved_issues.map(&:project).uniq.size == 1
+                       redirect_to project_issues_path(saved_issues.map(&:project).first)
                    end
                  else
                    redirect_back_or_default _project_issues_path(@project)
                  end
+                 else
+                   @saved_issues = @issues
+                   @unsaved_issues = unsaved_issues
+                   @issues = Issue.visible.find_all_by_id(@unsaved_issues.map(&:id))
+                   bulk_edit
+                   render :action => 'bulk_edit'
+                 end
                end
                def destroy
                  @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
                  if @hours > 0
                    case params[:todo]
                    when 'destroy'
                      # nothing to do
                    when 'nullify'
                      TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
                    when 'reassign'
                      reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
                      if reassign_to.nil?
                        flash.now[:error] = l(:error_issue_not_found_in_project)
                        return
                      else
                        TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
                      end
                    else
                      # display the destroy form if it's a user request
                      return unless api_request?
                    end
                  end
                  @issues.each do |issue|
                    begin
                      issue.reload.destroy
                    rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
                      # nothing to do, issue was already deleted (eg. by a parent)
                    end
                  end
                  respond_to do |format|
                    format.html { redirect_back_or_default _project_issues_path(@project) }
                    format.api  { render_api_ok }
                  end
                end
                private
                def find_project
                  project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
                  @project = Project.find(project_id)
                rescue ActiveRecord::RecordNotFound
                  render_404
                end
                def retrieve_previous_and_next_issue_ids
                  retrieve_query_from_session
                  if @query
                    sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
                    sort_update(@query.sortable_columns, 'issues_index_sort')
                    limit = 500
                    issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
                    if (idx = issue_ids.index(@issue.id)) && idx < limit
                      if issue_ids.size < 500
                        @issue_position = idx + 1
                        @issue_count = issue_ids.size
                      end
                      @prev_issue_id = issue_ids[idx - 1] if idx > 0
                      @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
                    end
                  end
                end
                # Used by #edit and #update to set some common instance variables
                # from the params
                # TODO: Refactor, not everything in here is needed by #edit
                def update_issue_from_params
                  @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
                  @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
                  @time_entry.attributes = params[:time_entry]
                  @issue.init_journal(User.current)
                  issue_attributes = params[:issue]
                  if issue_attributes && params[:conflict_resolution]
                    case params[:conflict_resolution]
                    when 'overwrite'
                      issue_attributes = issue_attributes.dup
                      issue_attributes.delete(:lock_version)
                    when 'add_notes'
                      issue_attributes = issue_attributes.slice(:notes)
                    when 'cancel'
                      redirect_to issue_path(@issue)
                      return false
                    end
                  end
                  @issue.safe_attributes = issue_attributes
                  @priorities = IssuePriority.active
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
                  true
                end
                # TODO: Refactor, lots of extra code in here
                # TODO: Changing tracker on an existing issue should not trigger this
                def build_new_issue_from_params
                  if params[:id].blank?
                    @issue = Issue.new
                    if params[:copy_from]
                      begin
                        @copy_from = Issue.visible.find(params[:copy_from])
                        @copy_attachments = params[:copy_attachments].present? || request.get?
                        @copy_subtasks = params[:copy_subtasks].present? || request.get?
                        @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
                      rescue ActiveRecord::RecordNotFound
                        render_404
                        return
                      end
                    end
                    @issue.project = @project
                  else
                    @issue = @project.issues.visible.find(params[:id])
                  end
                  @issue.project = @project
                  @issue.author ||= User.current
                  # Tracker must be set before custom field values
                  @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
                  if @issue.tracker.nil?
                    render_error l(:error_no_tracker_in_project)
                    return false
                  end
                  @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
                  @issue.safe_attributes = params[:issue]
                  @priorities = IssuePriority.active
                  @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
                  @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
                end
                def check_for_default_issue_status
                  if IssueStatus.default.nil?
                    render_error l(:error_no_default_issue_status)
                    return false
                  end
                end
                def parse_params_for_bulk_issue_attributes(params)
                  attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
                  attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
                  if custom = attributes[:custom_field_values]
                    custom.reject! {|k,v| v.blank?}
                    custom.keys.each do |k|
                      if custom[k].is_a?(Array)
                        custom[k] << '' if custom[k].delete('__none__')
                      else
                        custom[k] = '' if custom[k] == '__none__'
                      end
                    end
                  end
                  attributes
                end
              end

app/helpers/issues_helper.rb +14 0

              # encoding: utf-8
              #
              # Redmine - project management software
              # Copyright (C) 2006-2013  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              module IssuesHelper
                include ApplicationHelper
                def issue_list(issues, &block)
                  ancestors = []
                  issues.each do |issue|
                    while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
                      ancestors.pop
                    end
                    yield issue, ancestors.size
                    ancestors << issue unless issue.leaf?
                  end
                end
                # Renders a HTML/CSS tooltip
                #
                # To use, a trigger div is needed.  This is a div with the class of "tooltip"
                # that contains this method wrapped in a span with the class of "tip"
                #
                #    <div class="tooltip"><%= link_to_issue(issue) %>
                #      <span class="tip"><%= render_issue_tooltip(issue) %></span>
                #    </div>
                #
                def render_issue_tooltip(issue)
                  @cached_label_status ||= l(:field_status)
                  @cached_label_start_date ||= l(:field_start_date)
                  @cached_label_due_date ||= l(:field_due_date)
                  @cached_label_assigned_to ||= l(:field_assigned_to)
                  @cached_label_priority ||= l(:field_priority)
                  @cached_label_project ||= l(:field_project)
                  link_to_issue(issue) + "<br /><br />".html_safe +
                    "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
                    "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
                    "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
                    "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
                    "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
                    "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
                end
                def issue_heading(issue)
                  h("#{issue.tracker} ##{issue.id}")
                end
                def render_issue_subject_with_tree(issue)
                  s = ''
                  ancestors = issue.root? ? [] : issue.ancestors.visible.all
                  ancestors.each do |ancestor|
                    s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
                  end
                  s << '<div>'
                  subject = h(issue.subject)
                  if issue.is_private?
                    subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
                  end
                  s << content_tag('h3', subject)
                  s << '</div>' * (ancestors.size + 1)
                  s.html_safe
                end
                def render_descendants_tree(issue)
                  s = '<form><table class="list issues">'
                  issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
                    css = "issue issue-#{child.id} hascontextmenu"
                    css << " idnt idnt-#{level}" if level > 0
                    s << content_tag('tr',
                           content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
                           content_tag('td', link_to_issue(child, :truncate => 60, :project => (issue.project_id != child.project_id)), :class => 'subject') +
                           content_tag('td', h(child.status)) +
                           content_tag('td', link_to_user(child.assigned_to)) +
                           content_tag('td', progress_bar(child.done_ratio, :width => '80px')),
                           :class => css)
                  end
                  s << '</table></form>'
                  s.html_safe
                end
+               # Returns an array of error messages for bulk edited issues
+               def bulk_edit_error_messages(issues)
+                 messages = {}
+                 issues.each do |issue|
+                   issue.errors.full_messages.each do |message|
+                     messages[message] ||= []
+                     messages[message] << issue
+                   end
+                 end
+                 messages.map { |message, issues|
+                   "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
+                 }
+              end
                # Returns a link for adding a new subtask to the given issue
                def link_to_new_subtask(issue)
                  attrs = {
                    :tracker_id => issue.tracker,
                    :parent_issue_id => issue
                  }
                  link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
                end
                class IssueFieldsRows
                  include ActionView::Helpers::TagHelper
                  def initialize
                    @left = []
                    @right = []
                  end
                  def left(*args)
                    args.any? ? @left << cells(*args) : @left
                  end
                  def right(*args)
                    args.any? ? @right << cells(*args) : @right
                  end
                  def size
                    @left.size > @right.size ? @left.size : @right.size
                  end
                  def to_html
                    html = ''.html_safe
                    blank = content_tag('th', '') + content_tag('td', '')
                    size.times do |i|
                      left = @left[i] || blank
                      right = @right[i] || blank
                      html << content_tag('tr', left + right)
                    end
                    html
                  end
                  def cells(label, text, options={})
                    content_tag('th', "#{label}:", options) + content_tag('td', text, options)
                  end
                end
                def issue_fields_rows
                  r = IssueFieldsRows.new
                  yield r
                  r.to_html
                end
                def render_custom_fields_rows(issue)
                  return if issue.custom_field_values.empty?
                  ordered_values = []
                  half = (issue.custom_field_values.size / 2.0).ceil
                  half.times do |i|
                    ordered_values << issue.custom_field_values[i]
                    ordered_values << issue.custom_field_values[i + half]
                  end
                  s = "<tr>\n"
                  n = 0
                  ordered_values.compact.each do |value|
                    s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
                    s << "\t<th>#{ h(value.custom_field.name) }:</th><td>#{ simple_format_without_paragraph(h(show_value(value))) }</td>\n"
                    n += 1
                  end
                  s << "</tr>\n"
                  s.html_safe
                end
                def issues_destroy_confirmation_message(issues)
                  issues = [issues] unless issues.is_a?(Array)
                  message = l(:text_issues_destroy_confirmation)
                  descendant_count = issues.inject(0) {|memo, i| memo += (i.right - i.left - 1)/2}
                  if descendant_count > 0
                    issues.each do |issue|
                      next if issue.root?
                      issues.each do |other_issue|
                        descendant_count -= 1 if issue.is_descendant_of?(other_issue)
                      end
                    end
                    if descendant_count > 0
                      message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
                    end
                  end
                  message
                end
                def sidebar_queries
                  unless @sidebar_queries
                    @sidebar_queries = IssueQuery.visible.
                      order("#{Query.table_name}.name ASC").
                      # Project specific queries and global queries
                      where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).
                      all
                  end
                  @sidebar_queries
                end
                def query_links(title, queries)
                  return '' if queries.empty?
                  # links to #index on issues/show
                  url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
                  content_tag('h3', title) + "\n" +
                    content_tag('ul',
                      queries.collect {|query|
                          css = 'query'
                          css << ' selected' if query == @query
                          content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))
                        }.join("\n").html_safe,
                      :class => 'queries'
                    ) + "\n"
                end
                def render_sidebar_queries
                  out = ''.html_safe
                  out << query_links(l(:label_my_queries), sidebar_queries.reject(&:is_public?))
                  out << query_links(l(:label_query_plural), sidebar_queries.select(&:is_public?))
                  out
                end
                # Returns the textual representation of a journal details
                # as an array of strings
                def details_to_strings(details, no_html=false, options={})
                  options[:only_path] = (options[:only_path] == false ? false : true)
                  strings = []
                  values_by_field = {}
                  details.each do |detail|
                    if detail.property == 'cf'
                      field_id = detail.prop_key
                      field = CustomField.find_by_id(field_id)
                      if field && field.multiple?
                        values_by_field[field_id] ||= {:added => [], :deleted => []}
                        if detail.old_value
                          values_by_field[field_id][:deleted] << detail.old_value
                        end
                        if detail.value
                          values_by_field[field_id][:added] << detail.value
                        end
                        next
                      end
                    end
                    strings << show_detail(detail, no_html, options)
                  end
                  values_by_field.each do |field_id, changes|
                    detail = JournalDetail.new(:property => 'cf', :prop_key => field_id)
                    if changes[:added].any?
                      detail.value = changes[:added]
                      strings << show_detail(detail, no_html, options)
                    elsif changes[:deleted].any?
                      detail.old_value = changes[:deleted]
                      strings << show_detail(detail, no_html, options)
                    end
                  end
                  strings
                end
                # Returns the textual representation of a single journal detail
                def show_detail(detail, no_html=false, options={})
                  multiple = false
                  case detail.property
                  when 'attr'
                    field = detail.prop_key.to_s.gsub(/\_id$/, "")
                    label = l(("field_" + field).to_sym)
                    case detail.prop_key
                    when 'due_date', 'start_date'
                      value = format_date(detail.value.to_date) if detail.value
                      old_value = format_date(detail.old_value.to_date) if detail.old_value
                    when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
                          'priority_id', 'category_id', 'fixed_version_id'
                      value = find_name_by_reflection(field, detail.value)
                      old_value = find_name_by_reflection(field, detail.old_value)
                    when 'estimated_hours'
                      value = "%0.02f" % detail.value.to_f unless detail.value.blank?
                      old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
                    when 'parent_id'
                      label = l(:field_parent_issue)
                      value = "##{detail.value}" unless detail.value.blank?
                      old_value = "##{detail.old_value}" unless detail.old_value.blank?
                    when 'is_private'
                      value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
                      old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
                    end
                  when 'cf'
                    custom_field = CustomField.find_by_id(detail.prop_key)
                    if custom_field
                      multiple = custom_field.multiple?
                      label = custom_field.name
                      value = format_value(detail.value, custom_field.field_format) if detail.value
                      old_value = format_value(detail.old_value, custom_field.field_format) if detail.old_value
                    end
                  when 'attachment'
                    label = l(:label_attachment)
                  end
                  call_hook(:helper_issues_show_detail_after_setting,
                            {:detail => detail, :label => label, :value => value, :old_value => old_value })
                  label ||= detail.prop_key
                  value ||= detail.value
                  old_value ||= detail.old_value
                  unless no_html
                    label = content_tag('strong', label)
                    old_value = content_tag("i", h(old_value)) if detail.old_value
                    old_value = content_tag("del", old_value) if detail.old_value and detail.value.blank?
                    if detail.property == 'attachment' && !value.blank? && atta = Attachment.find_by_id(detail.prop_key)
                      # Link to the attachment if it has not been removed
                      value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
                      if options[:only_path] != false && atta.is_text?
                        value += link_to(
                                     image_tag('magnifier.png'),
                                     :controller => 'attachments', :action => 'show',
                                     :id => atta, :filename => atta.filename
                                   )
                      end
                    else
                      value = content_tag("i", h(value)) if value
                    end
                  end
                  if detail.property == 'attr' && detail.prop_key == 'description'
                    s = l(:text_journal_changed_no_detail, :label => label)
                    unless no_html
                      diff_link = link_to 'diff',
                        {:controller => 'journals', :action => 'diff', :id => detail.journal_id,
                         :detail_id => detail.id, :only_path => options[:only_path]},
                        :title => l(:label_view_diff)
                      s << " (#{ diff_link })"
                    end
                    s.html_safe
                  elsif detail.value.present?
                    case detail.property
                    when 'attr', 'cf'
                      if detail.old_value.present?
                        l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
                      elsif multiple
                        l(:text_journal_added, :label => label, :value => value).html_safe
                      else
                        l(:text_journal_set_to, :label => label, :value => value).html_safe
                      end
                    when 'attachment'
                      l(:text_journal_added, :label => label, :value => value).html_safe
                    end
                  else
                    l(:text_journal_deleted, :label => label, :old => old_value).html_safe
                  end
                end
                # Find the name of an associated record stored in the field attribute
                def find_name_by_reflection(field, id)
                  unless id.present?
                    return nil
                  end
                  association = Issue.reflect_on_association(field.to_sym)
                  if association
                    record = association.class_name.constantize.find_by_id(id)
                    if record
                      record.name.force_encoding('UTF-8') if record.name.respond_to?(:force_encoding)
                      return record.name
                    end
                  end
                end
                # Renders issue children recursively
                def render_api_issue_children(issue, api)
                  return if issue.leaf?
                  api.array :children do
                    issue.children.each do |child|
                      api.issue(:id => child.id) do
                        api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
                        api.subject child.subject
                        render_api_issue_children(child, api)
                      end
                    end
                  end
                end
              end

app/views/issues/bulk_edit.html.erb +16 0

              <h2><%= @copy ? l(:button_copy) : l(:label_bulk_edit_selected_issues) %></h2>
+             <% if @saved_issues && @unsaved_issues.present? %>
+             <div id="errorExplanation">
+               <span>
+                 <%= l(:notice_failed_to_save_issues,
+                     :count => @unsaved_issues.size,
+                     :total => @saved_issues.size,
+                     :ids => @unsaved_issues.map {|i| "##{i.id}"}.join(', ')) %>
+               </span>
+               <ul>
+               <% bulk_edit_error_messages(@unsaved_issues).each do |message| %>
+                 <li><%= message %></li>
+               <% end %>
+               </ul>
+             </div>
+             <% end %>
              <ul id="bulk-selection">
              <% @issues.each do |issue| %>
                <%= content_tag 'li', link_to_issue(issue) %>
              <% end %>
              </ul>
              <%= form_tag(bulk_update_issues_path, :id => 'bulk_edit_form') do %>
              <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join("\n").html_safe %>
              <div class="box tabular">
              <fieldset class="attributes">
              <legend><%= l(:label_change_properties) %></legend>
              <div class="splitcontentleft">
              <% if @allowed_projects.present? %>
              <p>
                <label for="issue_project_id"><%= l(:field_project) %></label>
                <%= select_tag('issue[project_id]', content_tag('option', l(:label_no_change_option), :value => '') + project_tree_options_for_select(@allowed_projects, :selected => @target_project),
                               :onchange => "updateBulkEditFrom('#{escape_javascript url_for(:action => 'bulk_edit', :format => 'js')}')") %>
              </p>
              <% end %>
              <p>
                <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
                <%= select_tag('issue[tracker_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@trackers, :id, :name)) %>
              </p>
              <% if @available_statuses.any? %>
              <p>
                <label for='issue_status_id'><%= l(:field_status) %></label>
                <%= select_tag('issue[status_id]',content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@available_statuses, :id, :name)) %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('priority_id') -%>
              <p>
                <label for='issue_priority_id'><%= l(:field_priority) %></label>
                <%= select_tag('issue[priority_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('assigned_to_id') -%>
              <p>
                <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
                <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                               content_tag('option', l(:label_nobody), :value => 'none') +
                                               principals_options_for_select(@assignables)) %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('category_id') -%>
              <p>
                <label for='issue_category_id'><%= l(:field_category) %></label>
                <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                              content_tag('option', l(:label_none), :value => 'none') +
                                              options_from_collection_for_select(@categories, :id, :name)) %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('fixed_version_id') -%>
              <p>
                <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
                <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
                                                 content_tag('option', l(:label_none), :value => 'none') +
                                                 version_options_for_select(@versions.sort)) %>
              </p>
              <% end %>
              <% @custom_fields.each do |custom_field| %>
                <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
              <% end %>
              <% if @copy && @attachments_present %>
              <p>
                <label for='copy_attachments'><%= l(:label_copy_attachments) %></label>
                <%= check_box_tag 'copy_attachments', '1', true %>
              </p>
              <% end %>
              <% if @copy && @subtasks_present %>
              <p>
                <label for='copy_subtasks'><%= l(:label_copy_subtasks) %></label>
                <%= check_box_tag 'copy_subtasks', '1', true %>
              </p>
              <% end %>
              <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
              </div>
              <div class="splitcontentright">
              <% if @safe_attributes.include?('is_private') %>
              <p>
                <label for='issue_is_private'><%= l(:field_is_private) %></label>
                <%= select_tag('issue[is_private]', content_tag('option', l(:label_no_change_option), :value => '') +
                                              content_tag('option', l(:general_text_Yes), :value => '1') +
                                              content_tag('option', l(:general_text_No), :value => '0')) %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('parent_issue_id') && @project %>
              <p>
                <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
                <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
              </p>
              <%= javascript_tag "observeAutocompleteField('issue_parent_issue_id', '#{escape_javascript auto_complete_issues_path(:project_id => @project)}')" %>
              <% end %>
              <% if @safe_attributes.include?('start_date') %>
              <p>
                <label for='issue_start_date'><%= l(:field_start_date) %></label>
                <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('due_date') %>
              <p>
                <label for='issue_due_date'><%= l(:field_due_date) %></label>
                <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
              </p>
              <% end %>
              <% if @safe_attributes.include?('done_ratio') && Issue.use_field_for_done_ratio? %>
              <p>
                <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
                <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
              </p>
              <% end %>
              </div>
              </fieldset>
              <fieldset>
              <legend><%= l(:field_notes) %></legend>
              <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
              <%= wikitoolbar_for 'notes' %>
              </fieldset>
              </div>
              <p>
                <% if @copy %>
                  <%= hidden_field_tag 'copy', '1' %>
                  <%= submit_tag l(:button_copy) %>
                  <%= submit_tag l(:button_copy_and_follow), :name => 'follow' %>
                <% elsif @target_project %>
                  <%= submit_tag l(:button_move) %>
                  <%= submit_tag l(:button_move_and_follow), :name => 'follow' %>
                <% else %>
                  <%= submit_tag l(:button_submit) %>
                <% end %>
              </p>
              <% end %>

test/functional/issues_controller_test.rb 0 0

	1		NO CONTENT: modified file
The requested commit or file is too big and content was truncated. Show full diff

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages