jro_apps/redmine Commit - r3355:103698b371ee

Wraps changeset creation inside a single transation....

Jean-Philippe Lang -

r3355:103698b371ee

parent child

Context file:

r3355:103698b371ee

lib/redmine/scm/adapters/abstract_adapter.rb +11 -9

                     end
                     def save(repo)
-                      if repo.changesets.find_by_scmid(scmid.to_s).nil?
+                      Changeset.transaction do
-                        changeset = Changeset.create!(
+                        changeset = Changeset.new(
                           :repository => repo,
                           :revision => identifier,
                           :scmid => scmid,
                           :committer => author,
                           :committed_on => time,
                           :comments => message)
-                        paths.each do |file|
+                        if changeset.save
-                          Change.create!(
+                          paths.each do |file|
-                            :changeset => changeset,
+                            Change.create(
-                            :action => file[:action],
+                              :changeset => changeset,
-                            :path => file[:path])
+                              :action => file[:action],
-                        end
+                              :path => file[:path])
+                          end
+                        end
                       end
                     end
                   end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages