jro_apps/redmine Commit - r4366:0e19aa4362a0

Fixed: error when serializing back objects with custom fields using ActiveResource (#6403)....

Jean-Philippe Lang -

r4366:0e19aa4362a0

parent child

Context file:

r4366:0e19aa4362a0

Collapse all files

app/helpers/custom_fields_helper.rb +11 0

             # redMine - project management software
             # Copyright (C) 2006  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             module CustomFieldsHelper
               def custom_fields_tabs
                 tabs = [{:name => 'IssueCustomField', :partial => 'custom_fields/index', :label => :label_issue_plural},
                         {:name => 'TimeEntryCustomField', :partial => 'custom_fields/index', :label => :label_spent_time},
                         {:name => 'ProjectCustomField', :partial => 'custom_fields/index', :label => :label_project_plural},
                         {:name => 'VersionCustomField', :partial => 'custom_fields/index', :label => :label_version_plural},
                         {:name => 'UserCustomField', :partial => 'custom_fields/index', :label => :label_user_plural},
                         {:name => 'GroupCustomField', :partial => 'custom_fields/index', :label => :label_group_plural},
                         {:name => 'TimeEntryActivityCustomField', :partial => 'custom_fields/index', :label => TimeEntryActivity::OptionName},
                         {:name => 'IssuePriorityCustomField', :partial => 'custom_fields/index', :label => IssuePriority::OptionName},
                         {:name => 'DocumentCategoryCustomField', :partial => 'custom_fields/index', :label => DocumentCategory::OptionName}
                         ]
               end
               # Return custom field html tag corresponding to its format
               def custom_field_tag(name, custom_value)
                 custom_field = custom_value.custom_field
                 field_name = "#{name}[custom_field_values][#{custom_field.id}]"
                 field_id = "#{name}_custom_field_values_#{custom_field.id}"
                 field_format = Redmine::CustomFieldFormat.find_by_name(custom_field.field_format)
                 case field_format.edit_as
                 when "date"
                   text_field_tag(field_name, custom_value.value, :id => field_id, :size => 10) +
                   calendar_for(field_id)
                 when "text"
                   text_area_tag(field_name, custom_value.value, :id => field_id, :rows => 3, :style => 'width:90%')
                 when "bool"
                   hidden_field_tag(field_name, '0') + check_box_tag(field_name, '1', custom_value.true?, :id => field_id)
                 when "list"
                   blank_option = custom_field.is_required? ?
                                    (custom_field.default_value.blank? ? "<option value=\"\">--- #{l(:actionview_instancetag_blank_option)} ---</option>" : '') :
                                    '<option></option>'
                   select_tag(field_name, blank_option + options_for_select(custom_field.possible_values, custom_value.value), :id => field_id)
                 else
                   text_field_tag(field_name, custom_value.value, :id => field_id)
                 end
               end
               # Return custom field label tag
               def custom_field_label_tag(name, custom_value)
                 content_tag "label", custom_value.custom_field.name +
             	(custom_value.custom_field.is_required? ? " <span class=\"required\">*</span>" : ""),
             	:for => "#{name}_custom_field_values_#{custom_value.custom_field.id}",
             	:class => (custom_value.errors.empty? ? nil : "error" )
               end
               # Return custom field tag with its label tag
               def custom_field_tag_with_label(name, custom_value)
                 custom_field_label_tag(name, custom_value) + custom_field_tag(name, custom_value)
               end
               def custom_field_tag_for_bulk_edit(name, custom_field)
                 field_name = "#{name}[custom_field_values][#{custom_field.id}]"
                 field_id = "#{name}_custom_field_values_#{custom_field.id}"
                 field_format = Redmine::CustomFieldFormat.find_by_name(custom_field.field_format)
                 case field_format.edit_as
                   when "date"
                     text_field_tag(field_name, '', :id => field_id, :size => 10) +
                     calendar_for(field_id)
                   when "text"
                     text_area_tag(field_name, '', :id => field_id, :rows => 3, :style => 'width:90%')
                   when "bool"
                     select_tag(field_name, options_for_select([[l(:label_no_change_option), ''],
                                                                [l(:general_text_yes), '1'],
                                                                [l(:general_text_no), '0']]), :id => field_id)
                   when "list"
                     select_tag(field_name, options_for_select([[l(:label_no_change_option), '']] + custom_field.possible_values), :id => field_id)
                   else
                     text_field_tag(field_name, '', :id => field_id)
                 end
               end
               # Return a string used to display a custom value
               def show_value(custom_value)
                 return "" unless custom_value
                 format_value(custom_value.value, custom_value.custom_field.field_format)
               end
               # Return a string used to display a custom value
               def format_value(value, field_format)
                 Redmine::CustomFieldFormat.format_value(value, field_format) # Proxy
               end
               # Return an array of custom field formats which can be used in select_tag
               def custom_field_formats_for_select
                 Redmine::CustomFieldFormat.as_select
               end
+              # Renders the custom_values in api views
+              def render_api_custom_values(custom_values, api)
+                api.array :custom_fields do
+                  custom_values.each do |custom_value|
+                    api.custom_field :id => custom_value.custom_field_id, :name => custom_value.custom_field.name do
+                      api.value custom_value.value
+                    end
+                  end
+                end unless custom_values.empty?
+              end
             end

app/views/issues/index.api.rsb +1 -5

             api.array :issues do
               @issues.each do |issue|
             	  api.issue do
             	    api.id					issue.id
             			api.project(:id => issue.project_id, :name => issue.project.name) unless issue.project.nil?
             			api.tracker(:id => issue.tracker_id, :name => issue.tracker.name) unless issue.tracker.nil?
             			api.status(:id => issue.status_id, :name => issue.status.name) unless issue.status.nil?
             			api.priority(:id => issue.priority_id, :name => issue.priority.name) unless issue.priority.nil?
             		 	api.author(:id => issue.author_id, :name => issue.author.name) unless issue.author.nil?
             		 	api.assigned_to(:id => issue.assigned_to_id, :name => issue.assigned_to.name) unless issue.assigned_to.nil?
             		  api.category(:id => issue.category_id, :name => issue.category.name) unless issue.category.nil?
             		  api.fixed_version(:id => issue.fixed_version_id, :name => issue.fixed_version.name) unless issue.fixed_version.nil?
                   api.parent(:id => issue.parent_id) unless issue.parent.nil?
                   api.subject 		issue.subject
                   api.description issue.description
                   api.start_date 	issue.start_date
                   api.due_date 		issue.due_date
                   api.done_ratio 	issue.done_ratio
                   api.estimated_hours issue.estimated_hours
-                  api.array :custom_fields do
+                  render_api_custom_values issue.custom_field_values, api
-                  	issue.custom_field_values.each do |custom_value|
-                  		api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-                  	end
-                  end
                   api.created_on issue.created_on
                   api.updated_on issue.updated_on
                 end
               end
             end

app/views/issues/show.api.rsb +1 -5

             api.issue do
               api.id					@issue.id
             	api.project(:id => @issue.project_id, :name => @issue.project.name) unless @issue.project.nil?
             	api.tracker(:id => @issue.tracker_id, :name => @issue.tracker.name) unless @issue.tracker.nil?
             	api.status(:id => @issue.status_id, :name => @issue.status.name) unless @issue.status.nil?
             	api.priority(:id => @issue.priority_id, :name => @issue.priority.name) unless @issue.priority.nil?
              	api.author(:id => @issue.author_id, :name => @issue.author.name) unless @issue.author.nil?
              	api.assigned_to(:id => @issue.assigned_to_id, :name => @issue.assigned_to.name) unless @issue.assigned_to.nil?
               api.category(:id => @issue.category_id, :name => @issue.category.name) unless @issue.category.nil?
               api.fixed_version(:id => @issue.fixed_version_id, :name => @issue.fixed_version.name) unless @issue.fixed_version.nil?
               api.parent(:id => @issue.parent_id) unless @issue.parent.nil?
               api.subject 		@issue.subject
               api.description @issue.description
               api.start_date 	@issue.start_date
               api.due_date 		@issue.due_date
               api.done_ratio 	@issue.done_ratio
               api.estimated_hours @issue.estimated_hours
               if User.current.allowed_to?(:view_time_entries, @project)
               	api.spent_hours		@issue.spent_hours
              	end
-              api.array :custom_fields do
+              render_api_custom_values @issue.custom_field_values, api
-              	@issue.custom_field_values.each do |custom_value|
-              		api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-              	end
-              end unless @issue.custom_field_values.empty?
               api.created_on @issue.created_on
               api.updated_on @issue.updated_on
               render_api_issue_children(@issue, api)
               api.array :relations do
               	@issue.relations.select {|r| r.other_issue(@issue).visible? }.each do |relation|
               		api.relation(:id => relation.id, :issue_id => relation.other_issue(@issue).id, :relation_type => relation.relation_type_for(@issue), :delay => relation.delay)
               	end
               end
               api.array :changesets do
               	@issue.changesets.each do |changeset|
               		api.changeset :revision => changeset.revision do
               			api.user(:id => changeset.user_id, :name => changeset.user.name) unless changeset.user.nil?
               			api.comments changeset.comments
               			api.committed_on changeset.committed_on
               		end
               	end
               end if User.current.allowed_to?(:view_changesets, @project) && @issue.changesets.any?
               api.array :journals do
               	@issue.journals.each do |journal|
               		api.journal :id => journal.id do
             			 	api.user(:id => journal.user_id, :name => journal.user.name) unless journal.user.nil?
               			api.notes journal.notes
               			api.array :details do
               				journal.details.each do |detail|
               					api.detail :property => detail.property, :name => detail.prop_key, :old => detail.old_value, :new => detail.value
               				end
               			end
               		end
               	end
               end unless @issue.journals.empty?
             end

app/views/projects/index.api.rsb +3 -5

             api.array :projects do
               @projects.each do |project|
                 api.project do
                   api.id          project.id
                   api.name        project.name
                   api.identifier  project.identifier
                   api.description project.description
                   api.parent(:id => project.parent_id, :name => project.parent.name) unless project.parent.nil?
-                  api.array :custom_fields do
-                    project.visible_custom_field_values.each do |custom_value|
+                  render_api_custom_values project.visible_custom_field_values, api
-                      api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-                    end
-                  end unless project.custom_field_values.empty?
                   api.created_on  project.created_on
                   api.updated_on  project.updated_on
                 end
               end
             end

app/views/projects/show.api.rsb +1 -5

             api.project do
               api.id          @project.id
               api.name        @project.name
               api.identifier  @project.identifier
               api.description @project.description
               api.homepage    @project.homepage
-              api.array :custom_fields do
+              render_api_custom_values @project.visible_custom_field_values, api
-                @project.visible_custom_field_values.each do |custom_value|
-                  api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-                end
-              end unless @project.custom_field_values.empty?
               api.created_on @project.created_on
               api.updated_on @project.updated_on
               api.array :trackers do
                 @project.trackers.each do |tracker|
                   api.tracker(:id => tracker.id, :name => tracker.name)
                 end
               end
             end

app/views/users/index.api.rsb +1 -5

             api.array :users do
               @users.each do |user|
                 api.user do
                   api.id         user.id
                   api.login      user.login
                   api.firstname  user.firstname
                   api.lastname   user.lastname
                   api.mail       user.mail
                   api.created_on user.created_on
                   api.last_login_on user.last_login_on
-                  api.array :custom_fields do
+                  render_api_custom_values user.visible_custom_field_values, api
-                    user.visible_custom_field_values.each do |custom_value|
-                      api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-                    end
-                  end unless user.visible_custom_field_values.empty?
                 end
               end
             end

app/views/users/show.api.rsb +1 -5

             api.user do
               api.id         @user.id
               api.login      @user.login if User.current.admin?
               api.firstname  @user.firstname
               api.lastname   @user.lastname
               api.mail       @user.mail if User.current.admin? || !@user.pref.hide_mail
               api.created_on @user.created_on
               api.last_login_on @user.last_login_on
-              api.array :custom_fields do
+              render_api_custom_values @user.visible_custom_field_values, api
-                @user.visible_custom_field_values.each do |custom_value|
-                  api.custom_field custom_value.value, :id => custom_value.custom_field_id, :name => custom_value.custom_field.name
-                end
-              end unless @user.visible_custom_field_values.empty?
               api.array :memberships do
                 @memberships.each do |membership|
                   api.membership do
                     api.project :id => membership.project.id, :name => membership.project.name
                     api.array :roles do
                       membership.roles.each do |role|
                         api.role :id => role.id, :name => role.name
                       end
                     end
                   end if membership.project
                 end
               end if @memberships.present?
             end

test/integration/api_test/issues_test.rb +26 0

             # Redmine - project management software
             # Copyright (C) 2006-2010  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require "#{File.dirname(__FILE__)}/../../test_helper"
             class ApiTest::IssuesTest < ActionController::IntegrationTest
               fixtures :projects,
                 :users,
                 :roles,
                 :members,
                 :member_roles,
                 :issues,
                 :issue_statuses,
                 :versions,
                 :trackers,
                 :projects_trackers,
                 :issue_categories,
                 :enabled_modules,
                 :enumerations,
                 :attachments,
                 :workflows,
                 :custom_fields,
                 :custom_values,
                 :custom_fields_projects,
                 :custom_fields_trackers,
                 :time_entries,
                 :journals,
                 :journal_details,
                 :queries
               def setup
                 Setting.rest_api_enabled = '1'
               end
               # Use a private project to make sure auth is really working and not just
               # only showing public issues.
               context "/index.xml" do
                 should_allow_api_authentication(:get, "/projects/private-child/issues.xml")
               end
               context "/index.json" do
                 should_allow_api_authentication(:get, "/projects/private-child/issues.json")
               end
               context "/index.xml with filter" do
                 should_allow_api_authentication(:get, "/projects/private-child/issues.xml?status_id=5")
                 should "show only issues with the status_id" do
                   get '/issues.xml?status_id=5'
                   assert_tag :tag => 'issues',
                              :children => { :count => Issue.visible.count(:conditions => {:status_id => 5}),
                                             :only => { :tag => 'issue' } }
                 end
               end
               context "/index.json with filter" do
                 should_allow_api_authentication(:get, "/projects/private-child/issues.json?status_id=5")
                 should "show only issues with the status_id" do
                   get '/issues.json?status_id=5'
                   json = ActiveSupport::JSON.decode(response.body)
                   status_ids_used = json['issues'].collect {|j| j['status']['id'] }
                   assert_equal 3, status_ids_used.length
                   assert status_ids_used.all? {|id| id == 5 }
                 end
               end
               # Issue 6 is on a private project
               context "/issues/6.xml" do
                 should_allow_api_authentication(:get, "/issues/6.xml")
               end
               context "/issues/6.json" do
                 should_allow_api_authentication(:get, "/issues/6.json")
               end
               context "GET /issues/:id" do
+                context "with custom fields" do
+                  context ".xml" do
+                    should "display custom fields" do
+                      get '/issues/3.xml'
+                      assert_tag :tag => 'issue',
+                        :child => {
+                          :tag => 'custom_fields',
+                          :attributes => { :type => 'array' },
+                          :child => {
+                            :tag => 'custom_field',
+                            :attributes => { :id => '1'},
+                            :child => {
+                              :tag => 'value',
+                              :content => 'MySQL'
+                            }
+                          }
+                        }
+                      assert_nothing_raised do
+                        Hash.from_xml(response.body).to_xml
+                      end
+                    end
+                  end
+                end
                 context "with subtasks" do
                   setup do
                     @c1 = Issue.generate!(:status_id => 1, :subject => "child c1", :tracker_id => 1, :project_id => 1, :parent_issue_id => 1)
                     @c2 = Issue.generate!(:status_id => 1, :subject => "child c2", :tracker_id => 1, :project_id => 1, :parent_issue_id => 1)
                     @c3 = Issue.generate!(:status_id => 1, :subject => "child c3", :tracker_id => 1, :project_id => 1, :parent_issue_id => @c1.id)
                   end
                   context ".xml" do
                     should "display children" do
                       get '/issues/1.xml'
                       assert_tag :tag => 'issue',
                         :child => {
                           :tag => 'children',
                           :children => {:count => 2},
                           :child => {
                             :tag => 'issue',
                             :attributes => {:id => @c1.id.to_s},
                             :child => {
                               :tag => 'subject',
                               :content => 'child c1',
                               :sibling => {
                                 :tag => 'children',
                                 :children => {:count => 1},
                                 :child => {
                                   :tag => 'issue',
                                   :attributes => {:id => @c3.id.to_s}
                                 }
                               }
                             }
                           }
                         }
                     end
                     context ".json" do
                       should "display children" do
                         get '/issues/1.json'
                         json = ActiveSupport::JSON.decode(response.body)
                         assert_equal([
                           {
                             'id' => @c1.id, 'subject' => 'child c1', 'tracker' => {'id' => 1, 'name' => 'Bug'},
                             'children' => [{ 'id' => @c3.id, 'subject' => 'child c3', 'tracker' => {'id' => 1, 'name' => 'Bug'} }]
                           },
                           { 'id' => @c2.id, 'subject' => 'child c2', 'tracker' => {'id' => 1, 'name' => 'Bug'} }
                           ],
                           json['issue']['children'])
                       end
                     end
                   end
                 end
               end
               context "POST /issues.xml" do
                 should_allow_api_authentication(:post,
                                                 '/issues.xml',
                                                 {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}},
                                                 {:success_code => :created})
                 should "create an issue with the attributes" do
                   assert_difference('Issue.count') do
                     post '/issues.xml', {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, :authorization => credentials('jsmith')
                   end
                   issue = Issue.first(:order => 'id DESC')
                   assert_equal 1, issue.project_id
                   assert_equal 2, issue.tracker_id
                   assert_equal 3, issue.status_id
                   assert_equal 'API test', issue.subject
                   assert_response :created
                   assert_equal 'application/xml', @response.content_type
                   assert_tag 'issue', :child => {:tag => 'id', :content => issue.id.to_s}
                 end
               end
               context "POST /issues.xml with failure" do
                 should_allow_api_authentication(:post,
                                                 '/issues.xml',
                                                 {:issue => {:project_id => 1}},
                                                 {:success_code => :unprocessable_entity})
                 should "have an errors tag" do
                   assert_no_difference('Issue.count') do
                     post '/issues.xml', {:issue => {:project_id => 1}}, :authorization => credentials('jsmith')
                   end
                   assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
                 end
               end
               context "POST /issues.json" do
                 should_allow_api_authentication(:post,
                                                 '/issues.json',
                                                 {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}},
                                                 {:success_code => :created})
                 should "create an issue with the attributes" do
                   assert_difference('Issue.count') do
                     post '/issues.json', {:issue => {:project_id => 1, :subject => 'API test', :tracker_id => 2, :status_id => 3}}, :authorization => credentials('jsmith')
                   end
                   issue = Issue.first(:order => 'id DESC')
                   assert_equal 1, issue.project_id
                   assert_equal 2, issue.tracker_id
                   assert_equal 3, issue.status_id
                   assert_equal 'API test', issue.subject
                 end
               end
               context "POST /issues.json with failure" do
                 should_allow_api_authentication(:post,
                                                 '/issues.json',
                                                 {:issue => {:project_id => 1}},
                                                 {:success_code => :unprocessable_entity})
                 should "have an errors element" do
                   assert_no_difference('Issue.count') do
                     post '/issues.json', {:issue => {:project_id => 1}}, :authorization => credentials('jsmith')
                   end
                   json = ActiveSupport::JSON.decode(response.body)
                   assert json['errors'].include?(['subject', "can't be blank"])
                 end
               end
               # Issue 6 is on a private project
               context "PUT /issues/6.xml" do
                 setup do
                   @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
                   @headers = { :authorization => credentials('jsmith') }
                 end
                 should_allow_api_authentication(:put,
                                                 '/issues/6.xml',
                                                 {:issue => {:subject => 'API update', :notes => 'A new note'}},
                                                 {:success_code => :ok})
                 should "not create a new issue" do
                   assert_no_difference('Issue.count') do
                     put '/issues/6.xml', @parameters, @headers
                   end
                 end
                 should "create a new journal" do
                   assert_difference('Journal.count') do
                     put '/issues/6.xml', @parameters, @headers
                   end
                 end
                 should "add the note to the journal" do
                   put '/issues/6.xml', @parameters, @headers
                   journal = Journal.last
                   assert_equal "A new note", journal.notes
                 end
                 should "update the issue" do
                   put '/issues/6.xml', @parameters, @headers
                   issue = Issue.find(6)
                   assert_equal "API update", issue.subject
                 end
               end
               context "PUT /issues/6.xml with failed update" do
                 setup do
                   @parameters = {:issue => {:subject => ''}}
                   @headers = { :authorization => credentials('jsmith') }
                 end
                 should_allow_api_authentication(:put,
                                                 '/issues/6.xml',
                                                 {:issue => {:subject => ''}}, # Missing subject should fail
                                                 {:success_code => :unprocessable_entity})
                 should "not create a new issue" do
                   assert_no_difference('Issue.count') do
                     put '/issues/6.xml', @parameters, @headers
                   end
                 end
                 should "not create a new journal" do
                   assert_no_difference('Journal.count') do
                     put '/issues/6.xml', @parameters, @headers
                   end
                 end
                 should "have an errors tag" do
                   put '/issues/6.xml', @parameters, @headers
                   assert_tag :errors, :child => {:tag => 'error', :content => "Subject can't be blank"}
                 end
               end
               context "PUT /issues/6.json" do
                 setup do
                   @parameters = {:issue => {:subject => 'API update', :notes => 'A new note'}}
                   @headers = { :authorization => credentials('jsmith') }
                 end
                 should_allow_api_authentication(:put,
                                                 '/issues/6.json',
                                                 {:issue => {:subject => 'API update', :notes => 'A new note'}},
                                                 {:success_code => :ok})
                 should "not create a new issue" do
                   assert_no_difference('Issue.count') do
                     put '/issues/6.json', @parameters, @headers
                   end
                 end
                 should "create a new journal" do
                   assert_difference('Journal.count') do
                     put '/issues/6.json', @parameters, @headers
                   end
                 end
                 should "add the note to the journal" do
                   put '/issues/6.json', @parameters, @headers
                   journal = Journal.last
                   assert_equal "A new note", journal.notes
                 end
                 should "update the issue" do
                   put '/issues/6.json', @parameters, @headers
                   issue = Issue.find(6)
                   assert_equal "API update", issue.subject
                 end
               end
               context "PUT /issues/6.json with failed update" do
                 setup do
                   @parameters = {:issue => {:subject => ''}}
                   @headers = { :authorization => credentials('jsmith') }
                 end
                 should_allow_api_authentication(:put,
                                                 '/issues/6.json',
                                                 {:issue => {:subject => ''}}, # Missing subject should fail
                                                 {:success_code => :unprocessable_entity})
                 should "not create a new issue" do
                   assert_no_difference('Issue.count') do
                     put '/issues/6.json', @parameters, @headers
                   end
                 end
                 should "not create a new journal" do
                   assert_no_difference('Journal.count') do
                     put '/issues/6.json', @parameters, @headers
                   end
                 end
                 should "have an errors attribute" do
                   put '/issues/6.json', @parameters, @headers
                   json = ActiveSupport::JSON.decode(response.body)
                   assert json['errors'].include?(['subject', "can't be blank"])
                 end
               end
               context "DELETE /issues/1.xml" do
                 should_allow_api_authentication(:delete,
                                                 '/issues/6.xml',
                                                 {},
                                                 {:success_code => :ok})
                 should "delete the issue" do
                   assert_difference('Issue.count',-1) do
                     delete '/issues/6.xml', {}, :authorization => credentials('jsmith')
                   end
                   assert_nil Issue.find_by_id(6)
                 end
               end
               context "DELETE /issues/1.json" do
                 should_allow_api_authentication(:delete,
                                                 '/issues/6.json',
                                                 {},
                                                 {:success_code => :ok})
                 should "delete the issue" do
                   assert_difference('Issue.count',-1) do
                     delete '/issues/6.json', {}, :authorization => credentials('jsmith')
                   end
                   assert_nil Issue.find_by_id(6)
                 end
               end
               def credentials(user, password=nil)
                 ActionController::HttpAuthentication::Basic.encode_credentials(user, password || user)
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages