##// END OF EJS Templates
Fixed test failure introduced by r14366....
Jean-Philippe Lang -
r13986:0dd95cdbc53e
parent child
Show More
@@ -1,198 +1,198
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2015 Jean-Philippe Lang
2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Member < ActiveRecord::Base
18 class Member < ActiveRecord::Base
19 belongs_to :user
19 belongs_to :user
20 belongs_to :principal, :foreign_key => 'user_id'
20 belongs_to :principal, :foreign_key => 'user_id'
21 has_many :member_roles, :dependent => :destroy
21 has_many :member_roles, :dependent => :destroy
22 has_many :roles, lambda {uniq}, :through => :member_roles
22 has_many :roles, lambda {uniq}, :through => :member_roles
23 belongs_to :project
23 belongs_to :project
24
24
25 validates_presence_of :principal, :project
25 validates_presence_of :principal, :project
26 validates_uniqueness_of :user_id, :scope => :project_id
26 validates_uniqueness_of :user_id, :scope => :project_id
27 validate :validate_role
27 validate :validate_role
28 attr_protected :id
28 attr_protected :id
29
29
30 before_destroy :set_issue_category_nil
30 before_destroy :set_issue_category_nil
31
31
32 scope :active, lambda { joins(:principal).where(:users => {:status => Principal::STATUS_ACTIVE})}
32 scope :active, lambda { joins(:principal).where(:users => {:status => Principal::STATUS_ACTIVE})}
33
33
34 alias :base_reload :reload
34 alias :base_reload :reload
35 def reload(*args)
35 def reload(*args)
36 @managed_roles = nil
36 @managed_roles = nil
37 base_reload(*args)
37 base_reload(*args)
38 end
38 end
39
39
40 def role
40 def role
41 end
41 end
42
42
43 def role=
43 def role=
44 end
44 end
45
45
46 def name
46 def name
47 self.user.name
47 self.user.name
48 end
48 end
49
49
50 alias :base_role_ids= :role_ids=
50 alias :base_role_ids= :role_ids=
51 def role_ids=(arg)
51 def role_ids=(arg)
52 ids = (arg || []).collect(&:to_i) - [0]
52 ids = (arg || []).collect(&:to_i) - [0]
53 # Keep inherited roles
53 # Keep inherited roles
54 ids += member_roles.select {|mr| !mr.inherited_from.nil?}.collect(&:role_id)
54 ids += member_roles.select {|mr| !mr.inherited_from.nil?}.collect(&:role_id)
55
55
56 new_role_ids = ids - role_ids
56 new_role_ids = ids - role_ids
57 # Add new roles
57 # Add new roles
58 new_role_ids.each {|id| member_roles << MemberRole.new(:role_id => id, :member => self) }
58 new_role_ids.each {|id| member_roles << MemberRole.new(:role_id => id, :member => self) }
59 # Remove roles (Rails' #role_ids= will not trigger MemberRole#on_destroy)
59 # Remove roles (Rails' #role_ids= will not trigger MemberRole#on_destroy)
60 member_roles_to_destroy = member_roles.select {|mr| !ids.include?(mr.role_id)}
60 member_roles_to_destroy = member_roles.select {|mr| !ids.include?(mr.role_id)}
61 if member_roles_to_destroy.any?
61 if member_roles_to_destroy.any?
62 member_roles_to_destroy.each(&:destroy)
62 member_roles_to_destroy.each(&:destroy)
63 end
63 end
64 end
64 end
65
65
66 def <=>(member)
66 def <=>(member)
67 a, b = roles.sort, member.roles.sort
67 a, b = roles.sort, member.roles.sort
68 if a == b
68 if a == b
69 if principal
69 if principal
70 principal <=> member.principal
70 principal <=> member.principal
71 else
71 else
72 1
72 1
73 end
73 end
74 elsif a
74 elsif a.any?
75 a <=> b
75 b.any? ? a <=> b : -1
76 else
76 else
77 1
77 1
78 end
78 end
79 end
79 end
80
80
81 # Set member role ids ignoring any change to roles that
81 # Set member role ids ignoring any change to roles that
82 # user is not allowed to manage
82 # user is not allowed to manage
83 def set_editable_role_ids(ids, user=User.current)
83 def set_editable_role_ids(ids, user=User.current)
84 ids = (ids || []).collect(&:to_i) - [0]
84 ids = (ids || []).collect(&:to_i) - [0]
85 editable_role_ids = user.managed_roles(project).map(&:id)
85 editable_role_ids = user.managed_roles(project).map(&:id)
86 untouched_role_ids = self.role_ids - editable_role_ids
86 untouched_role_ids = self.role_ids - editable_role_ids
87 touched_role_ids = ids & editable_role_ids
87 touched_role_ids = ids & editable_role_ids
88 self.role_ids = untouched_role_ids + touched_role_ids
88 self.role_ids = untouched_role_ids + touched_role_ids
89 end
89 end
90
90
91 # Returns true if one of the member roles is inherited
91 # Returns true if one of the member roles is inherited
92 def any_inherited_role?
92 def any_inherited_role?
93 member_roles.any? {|mr| mr.inherited_from}
93 member_roles.any? {|mr| mr.inherited_from}
94 end
94 end
95
95
96 # Returns true if the member has the role and if it's inherited
96 # Returns true if the member has the role and if it's inherited
97 def has_inherited_role?(role)
97 def has_inherited_role?(role)
98 member_roles.any? {|mr| mr.role_id == role.id && mr.inherited_from.present?}
98 member_roles.any? {|mr| mr.role_id == role.id && mr.inherited_from.present?}
99 end
99 end
100
100
101 # Returns true if the member's role is editable by user
101 # Returns true if the member's role is editable by user
102 def role_editable?(role, user=User.current)
102 def role_editable?(role, user=User.current)
103 if has_inherited_role?(role)
103 if has_inherited_role?(role)
104 false
104 false
105 else
105 else
106 user.managed_roles(project).include?(role)
106 user.managed_roles(project).include?(role)
107 end
107 end
108 end
108 end
109
109
110 # Returns true if the member is deletable by user
110 # Returns true if the member is deletable by user
111 def deletable?(user=User.current)
111 def deletable?(user=User.current)
112 if any_inherited_role?
112 if any_inherited_role?
113 false
113 false
114 else
114 else
115 roles & user.managed_roles(project) == roles
115 roles & user.managed_roles(project) == roles
116 end
116 end
117 end
117 end
118
118
119 # Destroys the member
119 # Destroys the member
120 def destroy
120 def destroy
121 member_roles.reload.each(&:destroy_without_member_removal)
121 member_roles.reload.each(&:destroy_without_member_removal)
122 super
122 super
123 end
123 end
124
124
125 # Returns true if the member is user or is a group
125 # Returns true if the member is user or is a group
126 # that includes user
126 # that includes user
127 def include?(user)
127 def include?(user)
128 if principal.is_a?(Group)
128 if principal.is_a?(Group)
129 !user.nil? && user.groups.include?(principal)
129 !user.nil? && user.groups.include?(principal)
130 else
130 else
131 self.user == user
131 self.user == user
132 end
132 end
133 end
133 end
134
134
135 def set_issue_category_nil
135 def set_issue_category_nil
136 if user_id && project_id
136 if user_id && project_id
137 # remove category based auto assignments for this member
137 # remove category based auto assignments for this member
138 IssueCategory.where(["project_id = ? AND assigned_to_id = ?", project_id, user_id]).
138 IssueCategory.where(["project_id = ? AND assigned_to_id = ?", project_id, user_id]).
139 update_all("assigned_to_id = NULL")
139 update_all("assigned_to_id = NULL")
140 end
140 end
141 end
141 end
142
142
143 # Returns the roles that the member is allowed to manage
143 # Returns the roles that the member is allowed to manage
144 # in the project the member belongs to
144 # in the project the member belongs to
145 def managed_roles
145 def managed_roles
146 @managed_roles ||= begin
146 @managed_roles ||= begin
147 if principal.try(:admin?)
147 if principal.try(:admin?)
148 Role.givable.to_a
148 Role.givable.to_a
149 else
149 else
150 members_management_roles = roles.select do |role|
150 members_management_roles = roles.select do |role|
151 role.has_permission?(:manage_members)
151 role.has_permission?(:manage_members)
152 end
152 end
153 if members_management_roles.empty?
153 if members_management_roles.empty?
154 []
154 []
155 elsif members_management_roles.any?(&:all_roles_managed?)
155 elsif members_management_roles.any?(&:all_roles_managed?)
156 Role.givable.to_a
156 Role.givable.to_a
157 else
157 else
158 members_management_roles.map(&:managed_roles).reduce(&:|)
158 members_management_roles.map(&:managed_roles).reduce(&:|)
159 end
159 end
160 end
160 end
161 end
161 end
162 end
162 end
163
163
164 # Creates memberships for principal with the attributes
164 # Creates memberships for principal with the attributes
165 # * project_ids : one or more project ids
165 # * project_ids : one or more project ids
166 # * role_ids : ids of the roles to give to each membership
166 # * role_ids : ids of the roles to give to each membership
167 #
167 #
168 # Example:
168 # Example:
169 # Member.create_principal_memberships(user, :project_ids => [2, 5], :role_ids => [1, 3]
169 # Member.create_principal_memberships(user, :project_ids => [2, 5], :role_ids => [1, 3]
170 def self.create_principal_memberships(principal, attributes)
170 def self.create_principal_memberships(principal, attributes)
171 members = []
171 members = []
172 if attributes
172 if attributes
173 project_ids = Array.wrap(attributes[:project_ids] || attributes[:project_id])
173 project_ids = Array.wrap(attributes[:project_ids] || attributes[:project_id])
174 role_ids = attributes[:role_ids]
174 role_ids = attributes[:role_ids]
175 project_ids.each do |project_id|
175 project_ids.each do |project_id|
176 members << Member.new(:principal => principal, :role_ids => role_ids, :project_id => project_id)
176 members << Member.new(:principal => principal, :role_ids => role_ids, :project_id => project_id)
177 end
177 end
178 principal.members << members
178 principal.members << members
179 end
179 end
180 members
180 members
181 end
181 end
182
182
183 # Finds or initilizes a Member for the given project and principal
183 # Finds or initilizes a Member for the given project and principal
184 def self.find_or_new(project, principal)
184 def self.find_or_new(project, principal)
185 project_id = project.is_a?(Project) ? project.id : project
185 project_id = project.is_a?(Project) ? project.id : project
186 principal_id = principal.is_a?(Principal) ? principal.id : principal
186 principal_id = principal.is_a?(Principal) ? principal.id : principal
187
187
188 member = Member.find_by_project_id_and_user_id(project_id, principal_id)
188 member = Member.find_by_project_id_and_user_id(project_id, principal_id)
189 member ||= Member.new(:project_id => project_id, :user_id => principal_id)
189 member ||= Member.new(:project_id => project_id, :user_id => principal_id)
190 member
190 member
191 end
191 end
192
192
193 protected
193 protected
194
194
195 def validate_role
195 def validate_role
196 errors.add_on_empty :role if member_roles.empty? && roles.empty?
196 errors.add_on_empty :role if member_roles.empty? && roles.empty?
197 end
197 end
198 end
198 end
General Comments 0
You need to be logged in to leave comments. Login now