jro_apps/redmine Commit - r2286:0c4e40b89cfe

Use In-Reply-To and References headers to handle replies by email....

Jean-Philippe Lang -

r2286:0c4e40b89cfe

parent child

Context file:

r2286:0c4e40b89cfe

Collapse all files

app/models/mail_handler.rb +22 -3

               private
+              MESSAGE_ID_RE = %r{^<redmine\.([a-z0-9_]+)\-(\d+)\.\d+@}
               ISSUE_REPLY_SUBJECT_RE = %r{\[[^\]]+#(\d+)\]}
               def dispatch
-                if m = email.subject.match(ISSUE_REPLY_SUBJECT_RE)
+                headers = [email.in_reply_to, email.references].flatten.compact
-                  receive_issue_update(m[1].to_i)
+                if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
+                  klass, object_id = $1, $2.to_i
+                  method_name = "receive_#{klass}_reply"
+                  if self.class.private_instance_methods.include?(method_name)
+                    send method_name, object_id
+                  else
+                    # ignoring it
+                  end
+                elsif m = email.subject.match(ISSUE_REPLY_SUBJECT_RE)
+                  # for compatibility
+                  receive_issue_reply(m[1].to_i)
                 else
                   receive_issue
                 end
               end
               # Adds a note to an existing issue
-              def receive_issue_update(issue_id)
+              def receive_issue_reply(issue_id)
                 status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
                 issue = Issue.find_by_id(issue_id)
                 journal
               end
+              # Reply will be added to the issue
+              def receive_journal_reply(journal_id)
+                journal = Journal.find_by_id(journal_id)
+                if journal && journal.journalized_type == 'Issue'
+                  receive_issue_reply(journal.journalized_id)
+                end
+              end
               def add_attachments(obj)
                 if email.has_attachments?
                   email.attachments.each do |attachment|

test/fixtures/mail_handler/ticket_reply.eml +2 -1

             	by OSIRIS
             	with hMailServer ; Sat, 21 Jun 2008 18:41:39 +0200
             Message-ID: <006a01c8d3bd$ad9baec0$0a00a8c0@osiris>
+            In-Reply-To: <redmine.issue-2.20060719210421@osiris>
             From: "John Smith" <jsmith@somenet.foo>
             To: <redmine@somenet.foo>
             References: <485d0ad366c88_d7014663a025f@osiris.tmail>
-            Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories
+            Subject: Re: Add ingredients categories
             Date: Sat, 21 Jun 2008 18:41:39 +0200
             MIME-Version: 1.0
             Content-Type: multipart/alternative;

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages