jro_apps/redmine Commit - r14891:08c9a5e3ef1a

Remove pagination on trackers, roles and issue statuses (#12909)....

Jean-Philippe Lang -

r14891:08c9a5e3ef1a

parent child

Context file:

r14891:08c9a5e3ef1a

Collapse all files

app/controllers/issue_statuses_controller.rb +3 -7

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssueStatusesController < ApplicationController
               layout 'admin'
               before_filter :require_admin, :except => :index
               before_filter :require_admin_or_api_request, :only => :index
               accept_api_auth :index
               def index
+                @issue_statuses = IssueStatus.sorted.to_a
                 respond_to do |format|
-                  format.html {
+                  format.html { render :layout => false if request.xhr? }
-                    @issue_status_pages, @issue_statuses = paginate IssueStatus.sorted, :per_page => 25
+                  format.api
-                    render :action => "index", :layout => false if request.xhr?
-                  format.api {
-                    @issue_statuses = IssueStatus.order('position').to_a
                 end
               end
               def new
                 @issue_status = IssueStatus.new
               end
               def create
                 @issue_status = IssueStatus.new(params[:issue_status])
                 if @issue_status.save
                   flash[:notice] = l(:notice_successful_create)
                   redirect_to issue_statuses_path
                 else
                   render :action => 'new'
                 end
               end
               def edit
                 @issue_status = IssueStatus.find(params[:id])
               end
               def update
                 @issue_status = IssueStatus.find(params[:id])
                 if @issue_status.update_attributes(params[:issue_status])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to issue_statuses_path(:page => params[:page])
                 else
                   render :action => 'edit'
                 end
               end
               def destroy
                 IssueStatus.find(params[:id]).destroy
                 redirect_to issue_statuses_path
               rescue
                 flash[:error] = l(:error_unable_delete_issue_status)
                 redirect_to issue_statuses_path
               end
               def update_issue_done_ratio
                 if request.post? && IssueStatus.update_issue_done_ratios
                   flash[:notice] = l(:notice_issue_done_ratios_updated)
                 else
                   flash[:error] =  l(:error_issue_done_ratios_not_updated)
                 end
                 redirect_to issue_statuses_path
               end
             end

app/controllers/roles_controller.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class RolesController < ApplicationController
               layout 'admin'
               before_filter :require_admin, :except => [:index, :show]
               before_filter :require_admin_or_api_request, :only => [:index, :show]
               before_filter :find_role, :only => [:show, :edit, :update, :destroy]
               accept_api_auth :index, :show
               require_sudo_mode :create, :update, :destroy
               def index
                 respond_to do |format|
                   format.html {
-                    @role_pages, @roles = paginate Role.sorted, :per_page => 25
+                    @roles = Role.sorted.to_a
-                    render :action => "index", :layout => false if request.xhr?
+                    render :layout => false if request.xhr?
                   }
                   format.api {
                     @roles = Role.givable.to_a
                   }
                 end
               end
               def show
                 respond_to do |format|
                   format.api
                 end
               end
               def new
                 # Prefills the form with 'Non member' role permissions by default
                 @role = Role.new(params[:role] || {:permissions => Role.non_member.permissions})
                 if params[:copy].present? && @copy_from = Role.find_by_id(params[:copy])
                   @role.copy_from(@copy_from)
                 end
                 @roles = Role.sorted.to_a
               end
               def create
                 @role = Role.new(params[:role])
                 if request.post? && @role.save
                   # workflow copy
                   if !params[:copy_workflow_from].blank? && (copy_from = Role.find_by_id(params[:copy_workflow_from]))
                     @role.workflow_rules.copy(copy_from)
                   end
                   flash[:notice] = l(:notice_successful_create)
                   redirect_to roles_path
                 else
                   @roles = Role.sorted.to_a
                   render :action => 'new'
                 end
               end
               def edit
               end
               def update
                 if @role.update_attributes(params[:role])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to roles_path(:page => params[:page])
                 else
                   render :action => 'edit'
                 end
               end
               def destroy
                 @role.destroy
                 redirect_to roles_path
               rescue
                 flash[:error] =  l(:error_can_not_remove_role)
                 redirect_to roles_path
               end
               def permissions
                 @roles = Role.sorted.to_a
                 @permissions = Redmine::AccessControl.permissions.select { |p| !p.public? }
                 if request.post?
                   @roles.each do |role|
                     role.permissions = params[:permissions][role.id.to_s]
                     role.save
                   end
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to roles_path
                 end
               end
               private
               def find_role
                 @role = Role.find(params[:id])
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
             end

app/controllers/trackers_controller.rb +3 -7

             # Redmine - project management software
             # Copyright (C) 2006-2016  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class TrackersController < ApplicationController
               layout 'admin'
               before_filter :require_admin, :except => :index
               before_filter :require_admin_or_api_request, :only => :index
               accept_api_auth :index
               def index
+                @trackers = Tracker.sorted.to_a
                 respond_to do |format|
-                  format.html {
+                  format.html { render :layout => false if request.xhr? }
-                    @tracker_pages, @trackers = paginate Tracker.sorted, :per_page => 25
+                  format.api
-                    render :action => "index", :layout => false if request.xhr?
-                  format.api {
-                    @trackers = Tracker.sorted.to_a
                 end
               end
               def new
                 @tracker ||= Tracker.new(params[:tracker])
                 @trackers = Tracker.sorted.to_a
                 @projects = Project.all
               end
               def create
                 @tracker = Tracker.new(params[:tracker])
                 if @tracker.save
                   # workflow copy
                   if !params[:copy_workflow_from].blank? && (copy_from = Tracker.find_by_id(params[:copy_workflow_from]))
                     @tracker.workflow_rules.copy(copy_from)
                   end
                   flash[:notice] = l(:notice_successful_create)
                   redirect_to trackers_path
                   return
                 end
                 new
                 render :action => 'new'
               end
               def edit
                 @tracker ||= Tracker.find(params[:id])
                 @projects = Project.all
               end
               def update
                 @tracker = Tracker.find(params[:id])
                 if @tracker.update_attributes(params[:tracker])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to trackers_path(:page => params[:page])
                   return
                 end
                 edit
                 render :action => 'edit'
               end
               def destroy
                 @tracker = Tracker.find(params[:id])
                 unless @tracker.issues.empty?
                   flash[:error] = l(:error_can_not_delete_tracker)
                 else
                   @tracker.destroy
                 end
                 redirect_to trackers_path
               end
               def fields
                 if request.post? && params[:trackers]
                   params[:trackers].each do |tracker_id, tracker_params|
                     tracker = Tracker.find_by_id(tracker_id)
                     if tracker
                       tracker.core_fields = tracker_params[:core_fields]
                       tracker.custom_field_ids = tracker_params[:custom_field_ids]
                       tracker.save
                     end
                   end
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to fields_trackers_path
                   return
                 end
                 @trackers = Tracker.sorted.to_a
                 @custom_fields = IssueCustomField.all.sort
               end
             end

app/views/issue_statuses/index.html.erb 0 -2

             <div class="contextual">
             <%= link_to l(:label_issue_status_new), new_issue_status_path, :class => 'icon icon-add' %>
             <%= link_to(l(:label_update_issue_done_ratios), update_issue_done_ratio_issue_statuses_path, :class => 'icon icon-multiple', :method => 'post', :data => {:confirm => l(:text_are_you_sure)}) if Issue.use_status_for_done_ratio? %>
             </div>
             <h2><%=l(:label_issue_status_plural)%></h2>
             <table class="list">
               <thead><tr>
               <th><%=l(:field_status)%></th>
               <% if Issue.use_status_for_done_ratio? %>
               <th><%=l(:field_done_ratio)%></th>
               <% end %>
               <th><%=l(:field_is_closed)%></th>
               <th><%=l(:button_sort)%></th>
               <th></th>
               </tr></thead>
               <tbody>
             <% for status in @issue_statuses %>
               <tr class="<%= cycle("odd", "even") %>">
               <td class="name"><%= link_to status.name, edit_issue_status_path(status) %></td>
               <% if Issue.use_status_for_done_ratio? %>
               <td><%= status.default_done_ratio %></td>
               <% end %>
               <td><%= checked_image status.is_closed? %></td>
               <td class="reorder"><%= reorder_links('issue_status', {:action => 'update', :id => status, :page => params[:page]}, :put) %></td>
               <td class="buttons">
                 <%= delete_link issue_status_path(status) %>
               </td>
               </tr>
             <% end %>
               </tbody>
             </table>
-            <span class="pagination"><%= pagination_links_full @issue_status_pages %></span>
             <% html_title(l(:label_issue_status_plural)) -%>

app/views/roles/index.html.erb 0 -2

             <div class="contextual">
             <%= link_to l(:label_role_new), new_role_path, :class => 'icon icon-add' %>
             <%= link_to l(:label_permissions_report), permissions_roles_path, :class => 'icon icon-summary' %>
             </div>
             <h2><%=l(:label_role_plural)%></h2>
             <table class="list">
               <thead><tr>
                 <th><%=l(:label_role)%></th>
                 <th><%=l(:button_sort)%></th>
               <th></th>
               </tr></thead>
               <tbody>
             <% for role in @roles %>
               <tr class="<%= cycle("odd", "even") %>">
               <td class="name"><%= content_tag(role.builtin? ? 'em' : 'span', link_to(role.name, edit_role_path(role))) %></td>
               <td class="reorder">
               <% unless role.builtin? %>
                 <%= reorder_links('role', {:action => 'update', :id => role, :page => params[:page]}, :put) %>
               <% end %>
               </td>
               <td class="buttons">
                 <%= link_to l(:button_copy), new_role_path(:copy => role), :class => 'icon icon-copy' %>
                 <%= delete_link role_path(role) unless role.builtin? %>
               </td>
               </tr>
             <% end %>
               </tbody>
             </table>
-            <span class="pagination"><%= pagination_links_full @role_pages %></span>
             <% html_title(l(:label_role_plural)) -%>

app/views/trackers/index.html.erb 0 -2

             <div class="contextual">
             <%= link_to l(:label_tracker_new), new_tracker_path, :class => 'icon icon-add' %>
             <%= link_to l(:field_summary), fields_trackers_path, :class => 'icon icon-summary' %>
             </div>
             <h2><%=l(:label_tracker_plural)%></h2>
             <table class="list">
               <thead><tr>
               <th><%=l(:label_tracker)%></th>
               <th></th>
               <th><%=l(:button_sort)%></th>
               <th></th>
               </tr></thead>
               <tbody>
             <% for tracker in @trackers %>
               <tr class="<%= cycle("odd", "even") %>">
               <td class="name"><%= link_to tracker.name, edit_tracker_path(tracker) %></td>
               <td>
                 <% unless tracker.workflow_rules.count > 0 %>
                   <span class="icon icon-warning">
                     <%= l(:text_tracker_no_workflow) %> (<%= link_to l(:button_edit), workflows_edit_path(:tracker_id => tracker) %>)
                   </span>
                 <% end %>
               </td>
               <td class="reorder">
                 <%= reorder_links('tracker', {:action => 'update', :id => tracker, :page => params[:page]}, :put) %>
               </td>
               <td class="buttons">
                 <%= delete_link tracker_path(tracker) %>
               </td>
               </tr>
             <% end %>
               </tbody>
             </table>
-            <span class="pagination"><%= pagination_links_full @tracker_pages %></span>
             <% html_title(l(:label_tracker_plural)) -%>

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages