jro_apps/redmine Commit - r3649:080dc2212efd

Add 'Start date' and 'End date' keywords for incoming email. #5595...

Eric Davis -

r3649:080dc2212efd

parent child

Context file:

r3649:080dc2212efd

Collapse all files

app/models/mail_handler.rb +10 -3

                  category = (get_keyword(:category) && project.issue_categories.find_by_name(get_keyword(:category)))
                  priority = (get_keyword(:priority) && IssuePriority.find_by_name(get_keyword(:priority)))
                  status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
+                 due_date = get_keyword(:due_date, :override => true)
+                 start_date = get_keyword(:start_date, :override => true)
                  # check permission
                  unless @@handler_options[:no_permission_check]
                    raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
                  end
-                 issue = Issue.new(:author => user, :project => project, :tracker => tracker, :category => category, :priority => priority)
+                 issue = Issue.new(:author => user, :project => project, :tracker => tracker, :category => category, :priority => priority, :due_date => due_date, :start_date => start_date)
                  # check workflow
                  if status && issue.new_statuses_allowed_to(user).include?(status)
                    issue.status = status
                # Adds a note to an existing issue
                def receive_issue_reply(issue_id)
                  status =  (get_keyword(:status) && IssueStatus.find_by_name(get_keyword(:status)))
+                 due_date = get_keyword(:due_date, :override => true)
+                 start_date = get_keyword(:start_date, :override => true)
                  issue = Issue.find_by_id(issue_id)
                  return unless issue
                  if status && issue.new_statuses_allowed_to(user).include?(status)
                    issue.status = status
                  end
+                 issue.start_date = start_date if start_date
+                 issue.due_date = due_date if due_date
                  issue.save!
                  logger.info "MailHandler: issue ##{issue.id} updated by #{user}" if logger && logger.info
                  journal
                    @keywords[attr]
                  else
                    @keywords[attr] = begin
-                     if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) && plain_text_body.gsub!(/^#{attr}[ \t]*:[ \t]*(.+)\s*$/i, '')
+                     if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) && plain_text_body.gsub!(/^#{attr.to_s.humanize}[ \t]*:[ \t]*(.+)\s*$/i, '')
                        $1.strip
                      elsif !@@handler_options[:issue][attr].blank?
                        @@handler_options[:issue][attr]

test/fixtures/mail_handler/ticket_on_given_project.eml +2 -1

              Project: onlinestore
              Status: Resolved
+             due date: 2010-12-31
+             Start Date:2010-01-01

test/fixtures/mail_handler/ticket_reply_with_status.eml +3 0

              This is reply
              Status: Resolved
+             due date: 2010-12-31
+             Start Date:2010-01-01
              ------=_NextPart_000_0067_01C8D3CE.711F9CC0
              Content-Type: text/html;
              	charset="utf-8"

test/unit/mail_handler_test.rb +5 -1

                  assert_equal Project.find(2), issue.project
                  assert_equal IssueStatus.find_by_name('Resolved'), issue.status
                  assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
+                 assert_equal '2010-01-01', issue.start_date.to_s
+                 assert_equal '2010-12-31', issue.due_date.to_s
                  # keywords should be removed from the email body
                  assert !issue.description.match(/^Project:/i)
                  assert !issue.description.match(/^Status:/i)
                  assert_match /This is reply/, journal.notes
                end
-               def test_add_issue_note_with_status_change
+               def test_add_issue_note_with_attribute_changes
                  # This email contains: 'Status: Resolved'
                  journal = submit_email('ticket_reply_with_status.eml')
                  assert journal.is_a?(Journal)
                  assert_equal Issue.find(2), journal.journalized
                  assert_match /This is reply/, journal.notes
                  assert_equal IssueStatus.find_by_name("Resolved"), issue.status
+                 assert_equal '2010-01-01', issue.start_date.to_s
+                 assert_equal '2010-12-31', issue.due_date.to_s
                end
                def test_add_issue_note_should_send_email_notification

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages