##// END OF EJS Templates
jro_apps » redmine
RSS
remove unneeded Relation#all from WorkflowsController...
Toshi MARUYAMA -
r12446:077598fe4bb7
parent child
Show More
Side by Side Unified
Context file:
r12446:077598fe4bb7 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,129 +1,129
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class WorkflowsController < ApplicationController
19 19 layout 'admin'
20 20
21 21 before_filter :require_admin, :find_roles, :find_trackers
22 22
23 23 def index
24 24 @workflow_counts = WorkflowTransition.count_by_tracker_and_role
25 25 end
26 26
27 27 def edit
28 28 @role = Role.find_by_id(params[:role_id]) if params[:role_id]
29 29 @tracker = Tracker.find_by_id(params[:tracker_id]) if params[:tracker_id]
30 30
31 31 if request.post?
32 32 WorkflowTransition.destroy_all( ["role_id=? and tracker_id=?", @role.id, @tracker.id])
33 33 (params[:issue_status] || []).each { |status_id, transitions|
34 34 transitions.each { |new_status_id, options|
35 35 author = options.is_a?(Array) && options.include?('author') && !options.include?('always')
36 36 assignee = options.is_a?(Array) && options.include?('assignee') && !options.include?('always')
37 37 WorkflowTransition.create(:role_id => @role.id, :tracker_id => @tracker.id, :old_status_id => status_id, :new_status_id => new_status_id, :author => author, :assignee => assignee)
38 38 }
39 39 }
40 40 if @role.save
41 41 flash[:notice] = l(:notice_successful_update)
42 42 redirect_to workflows_edit_path(:role_id => @role, :tracker_id => @tracker, :used_statuses_only => params[:used_statuses_only])
43 43 return
44 44 end
45 45 end
46 46
47 47 @used_statuses_only = (params[:used_statuses_only] == '0' ? false : true)
48 48 if @tracker && @used_statuses_only && @tracker.issue_statuses.any?
49 49 @statuses = @tracker.issue_statuses
50 50 end
51 51 @statuses ||= IssueStatus.sorted.all
52 52
53 53 if @tracker && @role && @statuses.any?
54 54 workflows = WorkflowTransition.where(:role_id => @role.id, :tracker_id => @tracker.id).all
55 55 @workflows = {}
56 56 @workflows['always'] = workflows.select {|w| !w.author && !w.assignee}
57 57 @workflows['author'] = workflows.select {|w| w.author}
58 58 @workflows['assignee'] = workflows.select {|w| w.assignee}
59 59 end
60 60 end
61 61
62 62 def permissions
63 63 @role = Role.find_by_id(params[:role_id]) if params[:role_id]
64 64 @tracker = Tracker.find_by_id(params[:tracker_id]) if params[:tracker_id]
65 65
66 66 if request.post? && @role && @tracker
67 67 WorkflowPermission.replace_permissions(@tracker, @role, params[:permissions] || {})
68 68 flash[:notice] = l(:notice_successful_update)
69 69 redirect_to workflows_permissions_path(:role_id => @role, :tracker_id => @tracker, :used_statuses_only => params[:used_statuses_only])
70 70 return
71 71 end
72 72
73 73 @used_statuses_only = (params[:used_statuses_only] == '0' ? false : true)
74 74 if @tracker && @used_statuses_only && @tracker.issue_statuses.any?
75 75 @statuses = @tracker.issue_statuses
76 76 end
77 77 @statuses ||= IssueStatus.sorted.all
78 78
79 79 if @role && @tracker
80 80 @fields = (Tracker::CORE_FIELDS_ALL - @tracker.disabled_core_fields).map {|field| [field, l("field_"+field.sub(/_id$/, ''))]}
81 81 @custom_fields = @tracker.custom_fields
82
83 @permissions = WorkflowPermission.where(:tracker_id => @tracker.id, :role_id => @role.id).all.inject({}) do |h, w|
82 @permissions = WorkflowPermission.
83 where(:tracker_id => @tracker.id, :role_id => @role.id).inject({}) do |h, w|
84 84 h[w.old_status_id] ||= {}
85 85 h[w.old_status_id][w.field_name] = w.rule
86 86 h
87 87 end
88 88 @statuses.each {|status| @permissions[status.id] ||= {}}
89 89 end
90 90 end
91 91
92 92 def copy
93 93 if params[:source_tracker_id].blank? || params[:source_tracker_id] == 'any'
94 94 @source_tracker = nil
95 95 else
96 96 @source_tracker = Tracker.find_by_id(params[:source_tracker_id].to_i)
97 97 end
98 98 if params[:source_role_id].blank? || params[:source_role_id] == 'any'
99 99 @source_role = nil
100 100 else
101 101 @source_role = Role.find_by_id(params[:source_role_id].to_i)
102 102 end
103 103 @target_trackers = params[:target_tracker_ids].blank? ?
104 104 nil : Tracker.where(:id => params[:target_tracker_ids]).all
105 105 @target_roles = params[:target_role_ids].blank? ?
106 106 nil : Role.where(:id => params[:target_role_ids]).all
107 107 if request.post?
108 108 if params[:source_tracker_id].blank? || params[:source_role_id].blank? || (@source_tracker.nil? && @source_role.nil?)
109 109 flash.now[:error] = l(:error_workflow_copy_source)
110 110 elsif @target_trackers.blank? || @target_roles.blank?
111 111 flash.now[:error] = l(:error_workflow_copy_target)
112 112 else
113 113 WorkflowRule.copy(@source_tracker, @source_role, @target_trackers, @target_roles)
114 114 flash[:notice] = l(:notice_successful_update)
115 115 redirect_to workflows_copy_path(:source_tracker_id => @source_tracker, :source_role_id => @source_role)
116 116 end
117 117 end
118 118 end
119 119
120 120 private
121 121
122 122 def find_roles
123 123 @roles = Role.sorted.all
124 124 end
125 125
126 126 def find_trackers
127 127 @trackers = Tracker.sorted.all
128 128 end
129 129 end
General Comments 0
You need to be logged in to leave comments. Login now