##// END OF EJS Templates
jro_apps » redmine
RSS
Merged r4083 from trunk....
Eric Davis -
r4030:066f648949c6
parent child
Show More
Side by Side Unified
Context file:
r4030:066f648949c6 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,325 +1,325
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :move, :perform_move, :destroy]
24 24 before_filter :find_project, :only => [:new, :create]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
29 29 accept_key_auth :index, :show
30 30
31 31 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
32 32
33 33 helper :journals
34 34 helper :projects
35 35 include ProjectsHelper
36 36 helper :custom_fields
37 37 include CustomFieldsHelper
38 38 helper :issue_relations
39 39 include IssueRelationsHelper
40 40 helper :watchers
41 41 include WatchersHelper
42 42 helper :attachments
43 43 include AttachmentsHelper
44 44 helper :queries
45 45 include QueriesHelper
46 46 helper :sort
47 47 include SortHelper
48 48 include IssuesHelper
49 49 helper :timelog
50 50 include Redmine::Export::PDF
51 51
52 52 verify :method => [:post, :delete],
53 53 :only => :destroy,
54 54 :render => { :nothing => true, :status => :method_not_allowed }
55 55
56 56 verify :method => :post, :only => :create, :render => {:nothing => true, :status => :method_not_allowed }
57 57 verify :method => :post, :only => :bulk_update, :render => {:nothing => true, :status => :method_not_allowed }
58 58 verify :method => :put, :only => :update, :render => {:nothing => true, :status => :method_not_allowed }
59 59
60 60 def index
61 61 retrieve_query
62 62 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
63 63 sort_update(@query.sortable_columns)
64 64
65 65 if @query.valid?
66 66 limit = case params[:format]
67 67 when 'csv', 'pdf'
68 68 Setting.issues_export_limit.to_i
69 69 when 'atom'
70 70 Setting.feeds_limit.to_i
71 71 else
72 72 per_page_option
73 73 end
74 74
75 75 @issue_count = @query.issue_count
76 76 @issue_pages = Paginator.new self, @issue_count, limit, params['page']
77 77 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
78 78 :order => sort_clause,
79 79 :offset => @issue_pages.current.offset,
80 80 :limit => limit)
81 81 @issue_count_by_group = @query.issue_count_by_group
82 82
83 83 respond_to do |format|
84 84 format.html { render :template => 'issues/index.rhtml', :layout => !request.xhr? }
85 85 format.xml { render :layout => false }
86 86 format.json { render :text => @issues.to_json, :layout => false }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(issues_to_csv(@issues, @project), :type => 'text/csv; header=present', :filename => 'export.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
90 90 end
91 91 else
92 92 # Send html if the query is not valid
93 93 render(:template => 'issues/index.rhtml', :layout => !request.xhr?)
94 94 end
95 95 rescue ActiveRecord::RecordNotFound
96 96 render_404
97 97 end
98 98
99 99 def show
100 100 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
101 101 @journals.each_with_index {|j,i| j.indice = i+1}
102 102 @journals.reverse! if User.current.wants_comments_in_reverse_order?
103 103 @changesets = @issue.changesets.visible.all
104 104 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
105 105 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
106 106 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
107 107 @priorities = IssuePriority.all
108 108 @time_entry = TimeEntry.new
109 109 respond_to do |format|
110 110 format.html { render :template => 'issues/show.rhtml' }
111 111 format.xml { render :layout => false }
112 112 format.json { render :text => @issue.to_json, :layout => false }
113 113 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
114 114 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
115 115 end
116 116 end
117 117
118 118 # Add a new issue
119 119 # The new issue will be created from an existing one if copy_from parameter is given
120 120 def new
121 121 respond_to do |format|
122 122 format.html { render :action => 'new', :layout => !request.xhr? }
123 123 format.js { render :partial => 'attributes' }
124 124 end
125 125 end
126 126
127 127 def create
128 128 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
129 129 if @issue.save
130 130 attachments = Attachment.attach_files(@issue, params[:attachments])
131 131 render_attachment_warning_if_needed(@issue)
132 132 flash[:notice] = l(:notice_successful_create)
133 133 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
134 134 respond_to do |format|
135 135 format.html {
136 redirect_to(params[:continue] ? { :action => 'new', :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
136 redirect_to(params[:continue] ? { :action => 'new', :project_id => @project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
137 137 { :action => 'show', :id => @issue })
138 138 }
139 139 format.xml { render :action => 'show', :status => :created, :location => url_for(:controller => 'issues', :action => 'show', :id => @issue) }
140 140 format.json { render :text => @issue.to_json, :status => :created, :location => url_for(:controller => 'issues', :action => 'show'), :layout => false }
141 141 end
142 142 return
143 143 else
144 144 respond_to do |format|
145 145 format.html { render :action => 'new' }
146 146 format.xml { render(:xml => @issue.errors, :status => :unprocessable_entity); return }
147 147 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
148 148 end
149 149 end
150 150 end
151 151
152 152 # Attributes that can be updated on workflow transition (without :edit permission)
153 153 # TODO: make it configurable (at least per role)
154 154 UPDATABLE_ATTRS_ON_TRANSITION = %w(status_id assigned_to_id fixed_version_id done_ratio) unless const_defined?(:UPDATABLE_ATTRS_ON_TRANSITION)
155 155
156 156 def edit
157 157 update_issue_from_params
158 158
159 159 @journal = @issue.current_journal
160 160
161 161 respond_to do |format|
162 162 format.html { }
163 163 format.xml { }
164 164 end
165 165 end
166 166
167 167 def update
168 168 update_issue_from_params
169 169
170 170 if @issue.save_issue_with_child_records(params, @time_entry)
171 171 render_attachment_warning_if_needed(@issue)
172 172 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
173 173
174 174 respond_to do |format|
175 175 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
176 176 format.xml { head :ok }
177 177 format.json { head :ok }
178 178 end
179 179 else
180 180 render_attachment_warning_if_needed(@issue)
181 181 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
182 182 @journal = @issue.current_journal
183 183
184 184 respond_to do |format|
185 185 format.html { render :action => 'edit' }
186 186 format.xml { render :xml => @issue.errors, :status => :unprocessable_entity }
187 187 format.json { render :text => object_errors_to_json(@issue), :status => :unprocessable_entity, :layout => false }
188 188 end
189 189 end
190 190 end
191 191
192 192 # Bulk edit a set of issues
193 193 def bulk_edit
194 194 @issues.sort!
195 195 @available_statuses = Workflow.available_statuses(@project)
196 196 @custom_fields = @project.all_issue_custom_fields
197 197 end
198 198
199 199 def bulk_update
200 200 @issues.sort!
201 201 attributes = parse_params_for_bulk_issue_attributes(params)
202 202
203 203 unsaved_issue_ids = []
204 204 @issues.each do |issue|
205 205 issue.reload
206 206 journal = issue.init_journal(User.current, params[:notes])
207 207 issue.safe_attributes = attributes
208 208 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
209 209 unless issue.save
210 210 # Keep unsaved issue ids to display them in flash error
211 211 unsaved_issue_ids << issue.id
212 212 end
213 213 end
214 214 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
215 215 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
216 216 end
217 217
218 218 def destroy
219 219 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
220 220 if @hours > 0
221 221 case params[:todo]
222 222 when 'destroy'
223 223 # nothing to do
224 224 when 'nullify'
225 225 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
226 226 when 'reassign'
227 227 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
228 228 if reassign_to.nil?
229 229 flash.now[:error] = l(:error_issue_not_found_in_project)
230 230 return
231 231 else
232 232 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
233 233 end
234 234 else
235 235 unless params[:format] == 'xml' || params[:format] == 'json'
236 236 # display the destroy form if it's a user request
237 237 return
238 238 end
239 239 end
240 240 end
241 241 @issues.each(&:destroy)
242 242 respond_to do |format|
243 243 format.html { redirect_to :action => 'index', :project_id => @project }
244 244 format.xml { head :ok }
245 245 format.json { head :ok }
246 246 end
247 247 end
248 248
249 249 private
250 250 def find_issue
251 251 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
252 252 @project = @issue.project
253 253 rescue ActiveRecord::RecordNotFound
254 254 render_404
255 255 end
256 256
257 257 def find_project
258 258 project_id = (params[:issue] && params[:issue][:project_id]) || params[:project_id]
259 259 @project = Project.find(project_id)
260 260 rescue ActiveRecord::RecordNotFound
261 261 render_404
262 262 end
263 263
264 264 # Used by #edit and #update to set some common instance variables
265 265 # from the params
266 266 # TODO: Refactor, not everything in here is needed by #edit
267 267 def update_issue_from_params
268 268 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
269 269 @priorities = IssuePriority.all
270 270 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
271 271 @time_entry = TimeEntry.new
272 272
273 273 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
274 274 @issue.init_journal(User.current, @notes)
275 275 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
276 276 if (@edit_allowed || !@allowed_statuses.empty?) && params[:issue]
277 277 attrs = params[:issue].dup
278 278 attrs.delete_if {|k,v| !UPDATABLE_ATTRS_ON_TRANSITION.include?(k) } unless @edit_allowed
279 279 attrs.delete(:status_id) unless @allowed_statuses.detect {|s| s.id.to_s == attrs[:status_id].to_s}
280 280 @issue.safe_attributes = attrs
281 281 end
282 282
283 283 end
284 284
285 285 # TODO: Refactor, lots of extra code in here
286 286 def build_new_issue_from_params
287 287 if params[:id].blank?
288 288 @issue = Issue.new
289 289 @issue.copy_from(params[:copy_from]) if params[:copy_from]
290 290 @issue.project = @project
291 291 else
292 292 @issue = @project.issues.visible.find(params[:id])
293 293 end
294 294
295 295 @issue.project = @project
296 296 # Tracker must be set before custom field values
297 297 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
298 298 if @issue.tracker.nil?
299 299 render_error l(:error_no_tracker_in_project)
300 300 return false
301 301 end
302 302 if params[:issue].is_a?(Hash)
303 303 @issue.safe_attributes = params[:issue]
304 304 @issue.watcher_user_ids = params[:issue]['watcher_user_ids'] if User.current.allowed_to?(:add_issue_watchers, @project)
305 305 end
306 306 @issue.author = User.current
307 307 @issue.start_date ||= Date.today
308 308 @priorities = IssuePriority.all
309 309 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
310 310 end
311 311
312 312 def check_for_default_issue_status
313 313 if IssueStatus.default.nil?
314 314 render_error l(:error_no_default_issue_status)
315 315 return false
316 316 end
317 317 end
318 318
319 319 def parse_params_for_bulk_issue_attributes(params)
320 320 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
321 321 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
322 322 attributes[:custom_field_values].reject! {|k,v| v.blank?} if attributes[:custom_field_values]
323 323 attributes
324 324 end
325 325 end
Show file before | Show file after | Hide comments
@@ -1,1069 +1,1070
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2008 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.dirname(__FILE__) + '/../test_helper'
19 19 require 'issues_controller'
20 20
21 21 # Re-raise errors caught by the controller.
22 22 class IssuesController; def rescue_action(e) raise e end; end
23 23
24 24 class IssuesControllerTest < ActionController::TestCase
25 25 fixtures :projects,
26 26 :users,
27 27 :roles,
28 28 :members,
29 29 :member_roles,
30 30 :issues,
31 31 :issue_statuses,
32 32 :versions,
33 33 :trackers,
34 34 :projects_trackers,
35 35 :issue_categories,
36 36 :enabled_modules,
37 37 :enumerations,
38 38 :attachments,
39 39 :workflows,
40 40 :custom_fields,
41 41 :custom_values,
42 42 :custom_fields_projects,
43 43 :custom_fields_trackers,
44 44 :time_entries,
45 45 :journals,
46 46 :journal_details,
47 47 :queries
48 48
49 49 def setup
50 50 @controller = IssuesController.new
51 51 @request = ActionController::TestRequest.new
52 52 @response = ActionController::TestResponse.new
53 53 User.current = nil
54 54 end
55 55
56 56 def test_index
57 57 Setting.default_language = 'en'
58 58
59 59 get :index
60 60 assert_response :success
61 61 assert_template 'index.rhtml'
62 62 assert_not_nil assigns(:issues)
63 63 assert_nil assigns(:project)
64 64 assert_tag :tag => 'a', :content => /Can't print recipes/
65 65 assert_tag :tag => 'a', :content => /Subproject issue/
66 66 # private projects hidden
67 67 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
68 68 assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 69 # project column
70 70 assert_tag :tag => 'th', :content => /Project/
71 71 end
72 72
73 73 def test_index_should_not_list_issues_when_module_disabled
74 74 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
75 75 get :index
76 76 assert_response :success
77 77 assert_template 'index.rhtml'
78 78 assert_not_nil assigns(:issues)
79 79 assert_nil assigns(:project)
80 80 assert_no_tag :tag => 'a', :content => /Can't print recipes/
81 81 assert_tag :tag => 'a', :content => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_not_list_issues_when_module_disabled
85 85 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
86 86 get :index
87 87 assert_response :success
88 88 assert_template 'index.rhtml'
89 89 assert_not_nil assigns(:issues)
90 90 assert_nil assigns(:project)
91 91 assert_no_tag :tag => 'a', :content => /Can't print recipes/
92 92 assert_tag :tag => 'a', :content => /Subproject issue/
93 93 end
94 94
95 95 def test_index_with_project
96 96 Setting.display_subprojects_issues = 0
97 97 get :index, :project_id => 1
98 98 assert_response :success
99 99 assert_template 'index.rhtml'
100 100 assert_not_nil assigns(:issues)
101 101 assert_tag :tag => 'a', :content => /Can't print recipes/
102 102 assert_no_tag :tag => 'a', :content => /Subproject issue/
103 103 end
104 104
105 105 def test_index_with_project_and_subprojects
106 106 Setting.display_subprojects_issues = 1
107 107 get :index, :project_id => 1
108 108 assert_response :success
109 109 assert_template 'index.rhtml'
110 110 assert_not_nil assigns(:issues)
111 111 assert_tag :tag => 'a', :content => /Can't print recipes/
112 112 assert_tag :tag => 'a', :content => /Subproject issue/
113 113 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
114 114 end
115 115
116 116 def test_index_with_project_and_subprojects_should_show_private_subprojects
117 117 @request.session[:user_id] = 2
118 118 Setting.display_subprojects_issues = 1
119 119 get :index, :project_id => 1
120 120 assert_response :success
121 121 assert_template 'index.rhtml'
122 122 assert_not_nil assigns(:issues)
123 123 assert_tag :tag => 'a', :content => /Can't print recipes/
124 124 assert_tag :tag => 'a', :content => /Subproject issue/
125 125 assert_tag :tag => 'a', :content => /Issue of a private subproject/
126 126 end
127 127
128 128 def test_index_with_project_and_filter
129 129 get :index, :project_id => 1, :set_filter => 1
130 130 assert_response :success
131 131 assert_template 'index.rhtml'
132 132 assert_not_nil assigns(:issues)
133 133 end
134 134
135 135 def test_index_with_query
136 136 get :index, :project_id => 1, :query_id => 5
137 137 assert_response :success
138 138 assert_template 'index.rhtml'
139 139 assert_not_nil assigns(:issues)
140 140 assert_nil assigns(:issue_count_by_group)
141 141 end
142 142
143 143 def test_index_with_query_grouped_by_tracker
144 144 get :index, :project_id => 1, :query_id => 6
145 145 assert_response :success
146 146 assert_template 'index.rhtml'
147 147 assert_not_nil assigns(:issues)
148 148 assert_not_nil assigns(:issue_count_by_group)
149 149 end
150 150
151 151 def test_index_with_query_grouped_by_list_custom_field
152 152 get :index, :project_id => 1, :query_id => 9
153 153 assert_response :success
154 154 assert_template 'index.rhtml'
155 155 assert_not_nil assigns(:issues)
156 156 assert_not_nil assigns(:issue_count_by_group)
157 157 end
158 158
159 159 def test_index_sort_by_field_not_included_in_columns
160 160 Setting.issue_list_default_columns = %w(subject author)
161 161 get :index, :sort => 'tracker'
162 162 end
163 163
164 164 def test_index_csv_with_project
165 165 Setting.default_language = 'en'
166 166
167 167 get :index, :format => 'csv'
168 168 assert_response :success
169 169 assert_not_nil assigns(:issues)
170 170 assert_equal 'text/csv', @response.content_type
171 171 assert @response.body.starts_with?("#,")
172 172
173 173 get :index, :project_id => 1, :format => 'csv'
174 174 assert_response :success
175 175 assert_not_nil assigns(:issues)
176 176 assert_equal 'text/csv', @response.content_type
177 177 end
178 178
179 179 def test_index_pdf
180 180 get :index, :format => 'pdf'
181 181 assert_response :success
182 182 assert_not_nil assigns(:issues)
183 183 assert_equal 'application/pdf', @response.content_type
184 184
185 185 get :index, :project_id => 1, :format => 'pdf'
186 186 assert_response :success
187 187 assert_not_nil assigns(:issues)
188 188 assert_equal 'application/pdf', @response.content_type
189 189
190 190 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
191 191 assert_response :success
192 192 assert_not_nil assigns(:issues)
193 193 assert_equal 'application/pdf', @response.content_type
194 194 end
195 195
196 196 def test_index_pdf_with_query_grouped_by_list_custom_field
197 197 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
198 198 assert_response :success
199 199 assert_not_nil assigns(:issues)
200 200 assert_not_nil assigns(:issue_count_by_group)
201 201 assert_equal 'application/pdf', @response.content_type
202 202 end
203 203
204 204 def test_index_sort
205 205 get :index, :sort => 'tracker,id:desc'
206 206 assert_response :success
207 207
208 208 sort_params = @request.session['issues_index_sort']
209 209 assert sort_params.is_a?(String)
210 210 assert_equal 'tracker,id:desc', sort_params
211 211
212 212 issues = assigns(:issues)
213 213 assert_not_nil issues
214 214 assert !issues.empty?
215 215 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
216 216 end
217 217
218 218 def test_index_with_columns
219 219 columns = ['tracker', 'subject', 'assigned_to']
220 220 get :index, :set_filter => 1, :query => { 'column_names' => columns}
221 221 assert_response :success
222 222
223 223 # query should use specified columns
224 224 query = assigns(:query)
225 225 assert_kind_of Query, query
226 226 assert_equal columns, query.column_names.map(&:to_s)
227 227
228 228 # columns should be stored in session
229 229 assert_kind_of Hash, session[:query]
230 230 assert_kind_of Array, session[:query][:column_names]
231 231 assert_equal columns, session[:query][:column_names].map(&:to_s)
232 232 end
233 233
234 234 def test_show_by_anonymous
235 235 get :show, :id => 1
236 236 assert_response :success
237 237 assert_template 'show.rhtml'
238 238 assert_not_nil assigns(:issue)
239 239 assert_equal Issue.find(1), assigns(:issue)
240 240
241 241 # anonymous role is allowed to add a note
242 242 assert_tag :tag => 'form',
243 243 :descendant => { :tag => 'fieldset',
244 244 :child => { :tag => 'legend',
245 245 :content => /Notes/ } }
246 246 end
247 247
248 248 def test_show_by_manager
249 249 @request.session[:user_id] = 2
250 250 get :show, :id => 1
251 251 assert_response :success
252 252
253 253 assert_tag :tag => 'form',
254 254 :descendant => { :tag => 'fieldset',
255 255 :child => { :tag => 'legend',
256 256 :content => /Change properties/ } },
257 257 :descendant => { :tag => 'fieldset',
258 258 :child => { :tag => 'legend',
259 259 :content => /Log time/ } },
260 260 :descendant => { :tag => 'fieldset',
261 261 :child => { :tag => 'legend',
262 262 :content => /Notes/ } }
263 263 end
264 264
265 265 def test_show_should_deny_anonymous_access_without_permission
266 266 Role.anonymous.remove_permission!(:view_issues)
267 267 get :show, :id => 1
268 268 assert_response :redirect
269 269 end
270 270
271 271 def test_show_should_deny_non_member_access_without_permission
272 272 Role.non_member.remove_permission!(:view_issues)
273 273 @request.session[:user_id] = 9
274 274 get :show, :id => 1
275 275 assert_response 403
276 276 end
277 277
278 278 def test_show_should_deny_member_access_without_permission
279 279 Role.find(1).remove_permission!(:view_issues)
280 280 @request.session[:user_id] = 2
281 281 get :show, :id => 1
282 282 assert_response 403
283 283 end
284 284
285 285 def test_show_should_not_disclose_relations_to_invisible_issues
286 286 Setting.cross_project_issue_relations = '1'
287 287 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
288 288 # Relation to a private project issue
289 289 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
290 290
291 291 get :show, :id => 1
292 292 assert_response :success
293 293
294 294 assert_tag :div, :attributes => { :id => 'relations' },
295 295 :descendant => { :tag => 'a', :content => /#2$/ }
296 296 assert_no_tag :div, :attributes => { :id => 'relations' },
297 297 :descendant => { :tag => 'a', :content => /#4$/ }
298 298 end
299 299
300 300 def test_show_atom
301 301 get :show, :id => 2, :format => 'atom'
302 302 assert_response :success
303 303 assert_template 'journals/index.rxml'
304 304 # Inline image
305 305 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
306 306 end
307 307
308 308 def test_show_export_to_pdf
309 309 get :show, :id => 3, :format => 'pdf'
310 310 assert_response :success
311 311 assert_equal 'application/pdf', @response.content_type
312 312 assert @response.body.starts_with?('%PDF')
313 313 assert_not_nil assigns(:issue)
314 314 end
315 315
316 316 def test_get_new
317 317 @request.session[:user_id] = 2
318 318 get :new, :project_id => 1, :tracker_id => 1
319 319 assert_response :success
320 320 assert_template 'new'
321 321
322 322 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
323 323 :value => 'Default string' }
324 324 end
325 325
326 326 def test_get_new_without_tracker_id
327 327 @request.session[:user_id] = 2
328 328 get :new, :project_id => 1
329 329 assert_response :success
330 330 assert_template 'new'
331 331
332 332 issue = assigns(:issue)
333 333 assert_not_nil issue
334 334 assert_equal Project.find(1).trackers.first, issue.tracker
335 335 end
336 336
337 337 def test_get_new_with_no_default_status_should_display_an_error
338 338 @request.session[:user_id] = 2
339 339 IssueStatus.delete_all
340 340
341 341 get :new, :project_id => 1
342 342 assert_response 500
343 343 assert_not_nil flash[:error]
344 344 assert_tag :tag => 'div', :attributes => { :class => /error/ },
345 345 :content => /No default issue/
346 346 end
347 347
348 348 def test_get_new_with_no_tracker_should_display_an_error
349 349 @request.session[:user_id] = 2
350 350 Tracker.delete_all
351 351
352 352 get :new, :project_id => 1
353 353 assert_response 500
354 354 assert_not_nil flash[:error]
355 355 assert_tag :tag => 'div', :attributes => { :class => /error/ },
356 356 :content => /No tracker/
357 357 end
358 358
359 359 def test_update_new_form
360 360 @request.session[:user_id] = 2
361 361 xhr :post, :new, :project_id => 1,
362 362 :issue => {:tracker_id => 2,
363 363 :subject => 'This is the test_new issue',
364 364 :description => 'This is the description',
365 365 :priority_id => 5}
366 366 assert_response :success
367 367 assert_template 'attributes'
368 368
369 369 issue = assigns(:issue)
370 370 assert_kind_of Issue, issue
371 371 assert_equal 1, issue.project_id
372 372 assert_equal 2, issue.tracker_id
373 373 assert_equal 'This is the test_new issue', issue.subject
374 374 end
375 375
376 376 def test_post_create
377 377 @request.session[:user_id] = 2
378 378 assert_difference 'Issue.count' do
379 379 post :create, :project_id => 1,
380 380 :issue => {:tracker_id => 3,
381 381 :status_id => 2,
382 382 :subject => 'This is the test_new issue',
383 383 :description => 'This is the description',
384 384 :priority_id => 5,
385 385 :estimated_hours => '',
386 386 :custom_field_values => {'2' => 'Value for field 2'}}
387 387 end
388 388 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
389 389
390 390 issue = Issue.find_by_subject('This is the test_new issue')
391 391 assert_not_nil issue
392 392 assert_equal 2, issue.author_id
393 393 assert_equal 3, issue.tracker_id
394 394 assert_equal 2, issue.status_id
395 395 assert_nil issue.estimated_hours
396 396 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
397 397 assert_not_nil v
398 398 assert_equal 'Value for field 2', v.value
399 399 end
400 400
401 401 def test_post_create_and_continue
402 402 @request.session[:user_id] = 2
403 403 post :create, :project_id => 1,
404 404 :issue => {:tracker_id => 3,
405 405 :subject => 'This is first issue',
406 406 :priority_id => 5},
407 407 :continue => ''
408 assert_redirected_to :controller => 'issues', :action => 'new', :issue => {:tracker_id => 3}
408 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook',
409 :issue => {:tracker_id => 3}
409 410 end
410 411
411 412 def test_post_create_without_custom_fields_param
412 413 @request.session[:user_id] = 2
413 414 assert_difference 'Issue.count' do
414 415 post :create, :project_id => 1,
415 416 :issue => {:tracker_id => 1,
416 417 :subject => 'This is the test_new issue',
417 418 :description => 'This is the description',
418 419 :priority_id => 5}
419 420 end
420 421 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
421 422 end
422 423
423 424 def test_post_create_with_required_custom_field_and_without_custom_fields_param
424 425 field = IssueCustomField.find_by_name('Database')
425 426 field.update_attribute(:is_required, true)
426 427
427 428 @request.session[:user_id] = 2
428 429 post :create, :project_id => 1,
429 430 :issue => {:tracker_id => 1,
430 431 :subject => 'This is the test_new issue',
431 432 :description => 'This is the description',
432 433 :priority_id => 5}
433 434 assert_response :success
434 435 assert_template 'new'
435 436 issue = assigns(:issue)
436 437 assert_not_nil issue
437 438 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
438 439 end
439 440
440 441 def test_post_create_with_watchers
441 442 @request.session[:user_id] = 2
442 443 ActionMailer::Base.deliveries.clear
443 444
444 445 assert_difference 'Watcher.count', 2 do
445 446 post :create, :project_id => 1,
446 447 :issue => {:tracker_id => 1,
447 448 :subject => 'This is a new issue with watchers',
448 449 :description => 'This is the description',
449 450 :priority_id => 5,
450 451 :watcher_user_ids => ['2', '3']}
451 452 end
452 453 issue = Issue.find_by_subject('This is a new issue with watchers')
453 454 assert_not_nil issue
454 455 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
455 456
456 457 # Watchers added
457 458 assert_equal [2, 3], issue.watcher_user_ids.sort
458 459 assert issue.watched_by?(User.find(3))
459 460 # Watchers notified
460 461 mail = ActionMailer::Base.deliveries.last
461 462 assert_kind_of TMail::Mail, mail
462 463 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
463 464 end
464 465
465 466 def test_post_create_subissue
466 467 @request.session[:user_id] = 2
467 468
468 469 assert_difference 'Issue.count' do
469 470 post :create, :project_id => 1,
470 471 :issue => {:tracker_id => 1,
471 472 :subject => 'This is a child issue',
472 473 :parent_issue_id => 2}
473 474 end
474 475 issue = Issue.find_by_subject('This is a child issue')
475 476 assert_not_nil issue
476 477 assert_equal Issue.find(2), issue.parent
477 478 end
478 479
479 480 def test_post_create_should_send_a_notification
480 481 ActionMailer::Base.deliveries.clear
481 482 @request.session[:user_id] = 2
482 483 assert_difference 'Issue.count' do
483 484 post :create, :project_id => 1,
484 485 :issue => {:tracker_id => 3,
485 486 :subject => 'This is the test_new issue',
486 487 :description => 'This is the description',
487 488 :priority_id => 5,
488 489 :estimated_hours => '',
489 490 :custom_field_values => {'2' => 'Value for field 2'}}
490 491 end
491 492 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
492 493
493 494 assert_equal 1, ActionMailer::Base.deliveries.size
494 495 end
495 496
496 497 def test_post_create_should_preserve_fields_values_on_validation_failure
497 498 @request.session[:user_id] = 2
498 499 post :create, :project_id => 1,
499 500 :issue => {:tracker_id => 1,
500 501 # empty subject
501 502 :subject => '',
502 503 :description => 'This is a description',
503 504 :priority_id => 6,
504 505 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
505 506 assert_response :success
506 507 assert_template 'new'
507 508
508 509 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
509 510 :content => 'This is a description'
510 511 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
511 512 :child => { :tag => 'option', :attributes => { :selected => 'selected',
512 513 :value => '6' },
513 514 :content => 'High' }
514 515 # Custom fields
515 516 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
516 517 :child => { :tag => 'option', :attributes => { :selected => 'selected',
517 518 :value => 'Oracle' },
518 519 :content => 'Oracle' }
519 520 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
520 521 :value => 'Value for field 2'}
521 522 end
522 523
523 524 def test_post_create_should_ignore_non_safe_attributes
524 525 @request.session[:user_id] = 2
525 526 assert_nothing_raised do
526 527 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
527 528 end
528 529 end
529 530
530 531 context "without workflow privilege" do
531 532 setup do
532 533 Workflow.delete_all(["role_id = ?", Role.anonymous.id])
533 534 Role.anonymous.add_permission! :add_issues
534 535 end
535 536
536 537 context "#new" do
537 538 should "propose default status only" do
538 539 get :new, :project_id => 1
539 540 assert_response :success
540 541 assert_template 'new'
541 542 assert_tag :tag => 'select',
542 543 :attributes => {:name => 'issue[status_id]'},
543 544 :children => {:count => 1},
544 545 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
545 546 end
546 547
547 548 should "accept default status" do
548 549 assert_difference 'Issue.count' do
549 550 post :create, :project_id => 1,
550 551 :issue => {:tracker_id => 1,
551 552 :subject => 'This is an issue',
552 553 :status_id => 1}
553 554 end
554 555 issue = Issue.last(:order => 'id')
555 556 assert_equal IssueStatus.default, issue.status
556 557 end
557 558
558 559 should "ignore unauthorized status" do
559 560 assert_difference 'Issue.count' do
560 561 post :create, :project_id => 1,
561 562 :issue => {:tracker_id => 1,
562 563 :subject => 'This is an issue',
563 564 :status_id => 3}
564 565 end
565 566 issue = Issue.last(:order => 'id')
566 567 assert_equal IssueStatus.default, issue.status
567 568 end
568 569 end
569 570 end
570 571
571 572 def test_copy_issue
572 573 @request.session[:user_id] = 2
573 574 get :new, :project_id => 1, :copy_from => 1
574 575 assert_template 'new'
575 576 assert_not_nil assigns(:issue)
576 577 orig = Issue.find(1)
577 578 assert_equal orig.subject, assigns(:issue).subject
578 579 end
579 580
580 581 def test_get_edit
581 582 @request.session[:user_id] = 2
582 583 get :edit, :id => 1
583 584 assert_response :success
584 585 assert_template 'edit'
585 586 assert_not_nil assigns(:issue)
586 587 assert_equal Issue.find(1), assigns(:issue)
587 588 end
588 589
589 590 def test_get_edit_with_params
590 591 @request.session[:user_id] = 2
591 592 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
592 593 assert_response :success
593 594 assert_template 'edit'
594 595
595 596 issue = assigns(:issue)
596 597 assert_not_nil issue
597 598
598 599 assert_equal 5, issue.status_id
599 600 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
600 601 :child => { :tag => 'option',
601 602 :content => 'Closed',
602 603 :attributes => { :selected => 'selected' } }
603 604
604 605 assert_equal 7, issue.priority_id
605 606 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
606 607 :child => { :tag => 'option',
607 608 :content => 'Urgent',
608 609 :attributes => { :selected => 'selected' } }
609 610 end
610 611
611 612 def test_update_edit_form
612 613 @request.session[:user_id] = 2
613 614 xhr :post, :new, :project_id => 1,
614 615 :id => 1,
615 616 :issue => {:tracker_id => 2,
616 617 :subject => 'This is the test_new issue',
617 618 :description => 'This is the description',
618 619 :priority_id => 5}
619 620 assert_response :success
620 621 assert_template 'attributes'
621 622
622 623 issue = assigns(:issue)
623 624 assert_kind_of Issue, issue
624 625 assert_equal 1, issue.id
625 626 assert_equal 1, issue.project_id
626 627 assert_equal 2, issue.tracker_id
627 628 assert_equal 'This is the test_new issue', issue.subject
628 629 end
629 630
630 631 def test_update_using_invalid_http_verbs
631 632 @request.session[:user_id] = 2
632 633 subject = 'Updated by an invalid http verb'
633 634
634 635 get :update, :id => 1, :issue => {:subject => subject}
635 636 assert_not_equal subject, Issue.find(1).subject
636 637
637 638 post :update, :id => 1, :issue => {:subject => subject}
638 639 assert_not_equal subject, Issue.find(1).subject
639 640
640 641 delete :update, :id => 1, :issue => {:subject => subject}
641 642 assert_not_equal subject, Issue.find(1).subject
642 643 end
643 644
644 645 def test_put_update_without_custom_fields_param
645 646 @request.session[:user_id] = 2
646 647 ActionMailer::Base.deliveries.clear
647 648
648 649 issue = Issue.find(1)
649 650 assert_equal '125', issue.custom_value_for(2).value
650 651 old_subject = issue.subject
651 652 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
652 653
653 654 assert_difference('Journal.count') do
654 655 assert_difference('JournalDetail.count', 2) do
655 656 put :update, :id => 1, :issue => {:subject => new_subject,
656 657 :priority_id => '6',
657 658 :category_id => '1' # no change
658 659 }
659 660 end
660 661 end
661 662 assert_redirected_to :action => 'show', :id => '1'
662 663 issue.reload
663 664 assert_equal new_subject, issue.subject
664 665 # Make sure custom fields were not cleared
665 666 assert_equal '125', issue.custom_value_for(2).value
666 667
667 668 mail = ActionMailer::Base.deliveries.last
668 669 assert_kind_of TMail::Mail, mail
669 670 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
670 671 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
671 672 end
672 673
673 674 def test_put_update_with_custom_field_change
674 675 @request.session[:user_id] = 2
675 676 issue = Issue.find(1)
676 677 assert_equal '125', issue.custom_value_for(2).value
677 678
678 679 assert_difference('Journal.count') do
679 680 assert_difference('JournalDetail.count', 3) do
680 681 put :update, :id => 1, :issue => {:subject => 'Custom field change',
681 682 :priority_id => '6',
682 683 :category_id => '1', # no change
683 684 :custom_field_values => { '2' => 'New custom value' }
684 685 }
685 686 end
686 687 end
687 688 assert_redirected_to :action => 'show', :id => '1'
688 689 issue.reload
689 690 assert_equal 'New custom value', issue.custom_value_for(2).value
690 691
691 692 mail = ActionMailer::Base.deliveries.last
692 693 assert_kind_of TMail::Mail, mail
693 694 assert mail.body.include?("Searchable field changed from 125 to New custom value")
694 695 end
695 696
696 697 def test_put_update_with_status_and_assignee_change
697 698 issue = Issue.find(1)
698 699 assert_equal 1, issue.status_id
699 700 @request.session[:user_id] = 2
700 701 assert_difference('TimeEntry.count', 0) do
701 702 put :update,
702 703 :id => 1,
703 704 :issue => { :status_id => 2, :assigned_to_id => 3 },
704 705 :notes => 'Assigned to dlopper',
705 706 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
706 707 end
707 708 assert_redirected_to :action => 'show', :id => '1'
708 709 issue.reload
709 710 assert_equal 2, issue.status_id
710 711 j = Journal.find(:first, :order => 'id DESC')
711 712 assert_equal 'Assigned to dlopper', j.notes
712 713 assert_equal 2, j.details.size
713 714
714 715 mail = ActionMailer::Base.deliveries.last
715 716 assert mail.body.include?("Status changed from New to Assigned")
716 717 # subject should contain the new status
717 718 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
718 719 end
719 720
720 721 def test_put_update_with_note_only
721 722 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
722 723 # anonymous user
723 724 put :update,
724 725 :id => 1,
725 726 :notes => notes
726 727 assert_redirected_to :action => 'show', :id => '1'
727 728 j = Journal.find(:first, :order => 'id DESC')
728 729 assert_equal notes, j.notes
729 730 assert_equal 0, j.details.size
730 731 assert_equal User.anonymous, j.user
731 732
732 733 mail = ActionMailer::Base.deliveries.last
733 734 assert mail.body.include?(notes)
734 735 end
735 736
736 737 def test_put_update_with_note_and_spent_time
737 738 @request.session[:user_id] = 2
738 739 spent_hours_before = Issue.find(1).spent_hours
739 740 assert_difference('TimeEntry.count') do
740 741 put :update,
741 742 :id => 1,
742 743 :notes => '2.5 hours added',
743 744 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
744 745 end
745 746 assert_redirected_to :action => 'show', :id => '1'
746 747
747 748 issue = Issue.find(1)
748 749
749 750 j = Journal.find(:first, :order => 'id DESC')
750 751 assert_equal '2.5 hours added', j.notes
751 752 assert_equal 0, j.details.size
752 753
753 754 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
754 755 assert_not_nil t
755 756 assert_equal 2.5, t.hours
756 757 assert_equal spent_hours_before + 2.5, issue.spent_hours
757 758 end
758 759
759 760 def test_put_update_with_attachment_only
760 761 set_tmp_attachments_directory
761 762
762 763 # Delete all fixtured journals, a race condition can occur causing the wrong
763 764 # journal to get fetched in the next find.
764 765 Journal.delete_all
765 766
766 767 # anonymous user
767 768 put :update,
768 769 :id => 1,
769 770 :notes => '',
770 771 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
771 772 assert_redirected_to :action => 'show', :id => '1'
772 773 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
773 774 assert j.notes.blank?
774 775 assert_equal 1, j.details.size
775 776 assert_equal 'testfile.txt', j.details.first.value
776 777 assert_equal User.anonymous, j.user
777 778
778 779 mail = ActionMailer::Base.deliveries.last
779 780 assert mail.body.include?('testfile.txt')
780 781 end
781 782
782 783 def test_put_update_with_attachment_that_fails_to_save
783 784 set_tmp_attachments_directory
784 785
785 786 # Delete all fixtured journals, a race condition can occur causing the wrong
786 787 # journal to get fetched in the next find.
787 788 Journal.delete_all
788 789
789 790 # Mock out the unsaved attachment
790 791 Attachment.any_instance.stubs(:create).returns(Attachment.new)
791 792
792 793 # anonymous user
793 794 put :update,
794 795 :id => 1,
795 796 :notes => '',
796 797 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
797 798 assert_redirected_to :action => 'show', :id => '1'
798 799 assert_equal '1 file(s) could not be saved.', flash[:warning]
799 800
800 801 end if Object.const_defined?(:Mocha)
801 802
802 803 def test_put_update_with_no_change
803 804 issue = Issue.find(1)
804 805 issue.journals.clear
805 806 ActionMailer::Base.deliveries.clear
806 807
807 808 put :update,
808 809 :id => 1,
809 810 :notes => ''
810 811 assert_redirected_to :action => 'show', :id => '1'
811 812
812 813 issue.reload
813 814 assert issue.journals.empty?
814 815 # No email should be sent
815 816 assert ActionMailer::Base.deliveries.empty?
816 817 end
817 818
818 819 def test_put_update_should_send_a_notification
819 820 @request.session[:user_id] = 2
820 821 ActionMailer::Base.deliveries.clear
821 822 issue = Issue.find(1)
822 823 old_subject = issue.subject
823 824 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
824 825
825 826 put :update, :id => 1, :issue => {:subject => new_subject,
826 827 :priority_id => '6',
827 828 :category_id => '1' # no change
828 829 }
829 830 assert_equal 1, ActionMailer::Base.deliveries.size
830 831 end
831 832
832 833 def test_put_update_with_invalid_spent_time
833 834 @request.session[:user_id] = 2
834 835 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
835 836
836 837 assert_no_difference('Journal.count') do
837 838 put :update,
838 839 :id => 1,
839 840 :notes => notes,
840 841 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
841 842 end
842 843 assert_response :success
843 844 assert_template 'edit'
844 845
845 846 assert_tag :textarea, :attributes => { :name => 'notes' },
846 847 :content => notes
847 848 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
848 849 end
849 850
850 851 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
851 852 issue = Issue.find(2)
852 853 @request.session[:user_id] = 2
853 854
854 855 put :update,
855 856 :id => issue.id,
856 857 :issue => {
857 858 :fixed_version_id => 4
858 859 }
859 860
860 861 assert_response :redirect
861 862 issue.reload
862 863 assert_equal 4, issue.fixed_version_id
863 864 assert_not_equal issue.project_id, issue.fixed_version.project_id
864 865 end
865 866
866 867 def test_put_update_should_redirect_back_using_the_back_url_parameter
867 868 issue = Issue.find(2)
868 869 @request.session[:user_id] = 2
869 870
870 871 put :update,
871 872 :id => issue.id,
872 873 :issue => {
873 874 :fixed_version_id => 4
874 875 },
875 876 :back_url => '/issues'
876 877
877 878 assert_response :redirect
878 879 assert_redirected_to '/issues'
879 880 end
880 881
881 882 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
882 883 issue = Issue.find(2)
883 884 @request.session[:user_id] = 2
884 885
885 886 put :update,
886 887 :id => issue.id,
887 888 :issue => {
888 889 :fixed_version_id => 4
889 890 },
890 891 :back_url => 'http://google.com'
891 892
892 893 assert_response :redirect
893 894 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
894 895 end
895 896
896 897 def test_get_bulk_edit
897 898 @request.session[:user_id] = 2
898 899 get :bulk_edit, :ids => [1, 2]
899 900 assert_response :success
900 901 assert_template 'bulk_edit'
901 902
902 903 # Project specific custom field, date type
903 904 field = CustomField.find(9)
904 905 assert !field.is_for_all?
905 906 assert_equal 'date', field.field_format
906 907 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
907 908
908 909 # System wide custom field
909 910 assert CustomField.find(1).is_for_all?
910 911 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
911 912 end
912 913
913 914 def test_bulk_update
914 915 @request.session[:user_id] = 2
915 916 # update issues priority
916 917 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
917 918 :issue => {:priority_id => 7,
918 919 :assigned_to_id => '',
919 920 :custom_field_values => {'2' => ''}}
920 921
921 922 assert_response 302
922 923 # check that the issues were updated
923 924 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
924 925
925 926 issue = Issue.find(1)
926 927 journal = issue.journals.find(:first, :order => 'created_on DESC')
927 928 assert_equal '125', issue.custom_value_for(2).value
928 929 assert_equal 'Bulk editing', journal.notes
929 930 assert_equal 1, journal.details.size
930 931 end
931 932
932 933 def test_bullk_update_should_send_a_notification
933 934 @request.session[:user_id] = 2
934 935 ActionMailer::Base.deliveries.clear
935 936 post(:bulk_update,
936 937 {
937 938 :ids => [1, 2],
938 939 :notes => 'Bulk editing',
939 940 :issue => {
940 941 :priority_id => 7,
941 942 :assigned_to_id => '',
942 943 :custom_field_values => {'2' => ''}
943 944 }
944 945 })
945 946
946 947 assert_response 302
947 948 assert_equal 2, ActionMailer::Base.deliveries.size
948 949 end
949 950
950 951 def test_bulk_update_status
951 952 @request.session[:user_id] = 2
952 953 # update issues priority
953 954 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
954 955 :issue => {:priority_id => '',
955 956 :assigned_to_id => '',
956 957 :status_id => '5'}
957 958
958 959 assert_response 302
959 960 issue = Issue.find(1)
960 961 assert issue.closed?
961 962 end
962 963
963 964 def test_bulk_update_custom_field
964 965 @request.session[:user_id] = 2
965 966 # update issues priority
966 967 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
967 968 :issue => {:priority_id => '',
968 969 :assigned_to_id => '',
969 970 :custom_field_values => {'2' => '777'}}
970 971
971 972 assert_response 302
972 973
973 974 issue = Issue.find(1)
974 975 journal = issue.journals.find(:first, :order => 'created_on DESC')
975 976 assert_equal '777', issue.custom_value_for(2).value
976 977 assert_equal 1, journal.details.size
977 978 assert_equal '125', journal.details.first.old_value
978 979 assert_equal '777', journal.details.first.value
979 980 end
980 981
981 982 def test_bulk_update_unassign
982 983 assert_not_nil Issue.find(2).assigned_to
983 984 @request.session[:user_id] = 2
984 985 # unassign issues
985 986 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
986 987 assert_response 302
987 988 # check that the issues were updated
988 989 assert_nil Issue.find(2).assigned_to
989 990 end
990 991
991 992 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
992 993 @request.session[:user_id] = 2
993 994
994 995 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
995 996
996 997 assert_response :redirect
997 998 issues = Issue.find([1,2])
998 999 issues.each do |issue|
999 1000 assert_equal 4, issue.fixed_version_id
1000 1001 assert_not_equal issue.project_id, issue.fixed_version.project_id
1001 1002 end
1002 1003 end
1003 1004
1004 1005 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
1005 1006 @request.session[:user_id] = 2
1006 1007 post :bulk_update, :ids => [1,2], :back_url => '/issues'
1007 1008
1008 1009 assert_response :redirect
1009 1010 assert_redirected_to '/issues'
1010 1011 end
1011 1012
1012 1013 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
1013 1014 @request.session[:user_id] = 2
1014 1015 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
1015 1016
1016 1017 assert_response :redirect
1017 1018 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
1018 1019 end
1019 1020
1020 1021 def test_destroy_issue_with_no_time_entries
1021 1022 assert_nil TimeEntry.find_by_issue_id(2)
1022 1023 @request.session[:user_id] = 2
1023 1024 post :destroy, :id => 2
1024 1025 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1025 1026 assert_nil Issue.find_by_id(2)
1026 1027 end
1027 1028
1028 1029 def test_destroy_issues_with_time_entries
1029 1030 @request.session[:user_id] = 2
1030 1031 post :destroy, :ids => [1, 3]
1031 1032 assert_response :success
1032 1033 assert_template 'destroy'
1033 1034 assert_not_nil assigns(:hours)
1034 1035 assert Issue.find_by_id(1) && Issue.find_by_id(3)
1035 1036 end
1036 1037
1037 1038 def test_destroy_issues_and_destroy_time_entries
1038 1039 @request.session[:user_id] = 2
1039 1040 post :destroy, :ids => [1, 3], :todo => 'destroy'
1040 1041 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1041 1042 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1042 1043 assert_nil TimeEntry.find_by_id([1, 2])
1043 1044 end
1044 1045
1045 1046 def test_destroy_issues_and_assign_time_entries_to_project
1046 1047 @request.session[:user_id] = 2
1047 1048 post :destroy, :ids => [1, 3], :todo => 'nullify'
1048 1049 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1049 1050 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1050 1051 assert_nil TimeEntry.find(1).issue_id
1051 1052 assert_nil TimeEntry.find(2).issue_id
1052 1053 end
1053 1054
1054 1055 def test_destroy_issues_and_reassign_time_entries_to_another_issue
1055 1056 @request.session[:user_id] = 2
1056 1057 post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
1057 1058 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
1058 1059 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
1059 1060 assert_equal 2, TimeEntry.find(1).issue_id
1060 1061 assert_equal 2, TimeEntry.find(2).issue_id
1061 1062 end
1062 1063
1063 1064 def test_default_search_scope
1064 1065 get :index
1065 1066 assert_tag :div, :attributes => {:id => 'quick-search'},
1066 1067 :child => {:tag => 'form',
1067 1068 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
1068 1069 end
1069 1070 end
General Comments 0
You need to be logged in to leave comments. Login now