##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_create_should_send_email_notification at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7359:06452ae8cf0d
parent child
Show More
Side by Side Unified
Context file:
r7359:06452ae8cf0d Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1101 +1,1104
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
33 33 :status_id => 1, :priority => IssuePriority.all.first,
34 34 :subject => 'test_create',
35 35 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 36 assert issue.save
37 37 issue.reload
38 38 assert_equal 1.5, issue.estimated_hours
39 39 end
40 40
41 41 def test_create_minimal
42 42 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
43 43 :status_id => 1, :priority => IssuePriority.all.first,
44 44 :subject => 'test_create')
45 45 assert issue.save
46 46 assert issue.description.nil?
47 47 end
48 48
49 49 def test_create_with_required_custom_field
50 50 field = IssueCustomField.find_by_name('Database')
51 51 field.update_attribute(:is_required, true)
52 52
53 53 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
54 54 :status_id => 1, :subject => 'test_create',
55 55 :description => 'IssueTest#test_create_with_required_custom_field')
56 56 assert issue.available_custom_fields.include?(field)
57 57 # No value for the custom field
58 58 assert !issue.save
59 59 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 60 # Blank value
61 61 issue.custom_field_values = { field.id => '' }
62 62 assert !issue.save
63 63 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 64 # Invalid value
65 65 issue.custom_field_values = { field.id => 'SQLServer' }
66 66 assert !issue.save
67 67 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 68 # Valid value
69 69 issue.custom_field_values = { field.id => 'PostgreSQL' }
70 70 assert issue.save
71 71 issue.reload
72 72 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
73 73 end
74 74
75 75 def test_create_with_group_assignment
76 76 with_settings :issue_group_assignment => '1' do
77 77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
78 78 :subject => 'Group assignment',
79 79 :assigned_to_id => 11).save
80 80 issue = Issue.first(:order => 'id DESC')
81 81 assert_kind_of Group, issue.assigned_to
82 82 assert_equal Group.find(11), issue.assigned_to
83 83 end
84 84 end
85 85
86 86 def assert_visibility_match(user, issues)
87 87 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous
91 91 # Anonymous user should see issues of public projects only
92 92 issues = Issue.visible(User.anonymous).all
93 93 assert issues.any?
94 94 assert_nil issues.detect {|issue| !issue.project.is_public?}
95 95 assert_nil issues.detect {|issue| issue.is_private?}
96 96 assert_visibility_match User.anonymous, issues
97 97 end
98 98
99 99 def test_visible_scope_for_anonymous_with_own_issues_visibility
100 100 Role.anonymous.update_attribute :issues_visibility, 'own'
101 101 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
102 102
103 103 issues = Issue.visible(User.anonymous).all
104 104 assert issues.any?
105 105 assert_nil issues.detect {|issue| issue.author != User.anonymous}
106 106 assert_visibility_match User.anonymous, issues
107 107 end
108 108
109 109 def test_visible_scope_for_anonymous_without_view_issues_permissions
110 110 # Anonymous user should not see issues without permission
111 111 Role.anonymous.remove_permission!(:view_issues)
112 112 issues = Issue.visible(User.anonymous).all
113 113 assert issues.empty?
114 114 assert_visibility_match User.anonymous, issues
115 115 end
116 116
117 117 def test_visible_scope_for_non_member
118 118 user = User.find(9)
119 119 assert user.projects.empty?
120 120 # Non member user should see issues of public projects only
121 121 issues = Issue.visible(user).all
122 122 assert issues.any?
123 123 assert_nil issues.detect {|issue| !issue.project.is_public?}
124 124 assert_nil issues.detect {|issue| issue.is_private?}
125 125 assert_visibility_match user, issues
126 126 end
127 127
128 128 def test_visible_scope_for_non_member_with_own_issues_visibility
129 129 Role.non_member.update_attribute :issues_visibility, 'own'
130 130 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
131 131 user = User.find(9)
132 132
133 133 issues = Issue.visible(user).all
134 134 assert issues.any?
135 135 assert_nil issues.detect {|issue| issue.author != user}
136 136 assert_visibility_match user, issues
137 137 end
138 138
139 139 def test_visible_scope_for_non_member_without_view_issues_permissions
140 140 # Non member user should not see issues without permission
141 141 Role.non_member.remove_permission!(:view_issues)
142 142 user = User.find(9)
143 143 assert user.projects.empty?
144 144 issues = Issue.visible(user).all
145 145 assert issues.empty?
146 146 assert_visibility_match user, issues
147 147 end
148 148
149 149 def test_visible_scope_for_member
150 150 user = User.find(9)
151 151 # User should see issues of projects for which he has view_issues permissions only
152 152 Role.non_member.remove_permission!(:view_issues)
153 153 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
154 154 issues = Issue.visible(user).all
155 155 assert issues.any?
156 156 assert_nil issues.detect {|issue| issue.project_id != 3}
157 157 assert_nil issues.detect {|issue| issue.is_private?}
158 158 assert_visibility_match user, issues
159 159 end
160 160
161 161 def test_visible_scope_for_admin
162 162 user = User.find(1)
163 163 user.members.each(&:destroy)
164 164 assert user.projects.empty?
165 165 issues = Issue.visible(user).all
166 166 assert issues.any?
167 167 # Admin should see issues on private projects that he does not belong to
168 168 assert issues.detect {|issue| !issue.project.is_public?}
169 169 # Admin should see private issues of other users
170 170 assert issues.detect {|issue| issue.is_private? && issue.author != user}
171 171 assert_visibility_match user, issues
172 172 end
173 173
174 174 def test_visible_scope_with_project
175 175 project = Project.find(1)
176 176 issues = Issue.visible(User.find(2), :project => project).all
177 177 projects = issues.collect(&:project).uniq
178 178 assert_equal 1, projects.size
179 179 assert_equal project, projects.first
180 180 end
181 181
182 182 def test_visible_scope_with_project_and_subprojects
183 183 project = Project.find(1)
184 184 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
185 185 projects = issues.collect(&:project).uniq
186 186 assert projects.size > 1
187 187 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
188 188 end
189 189
190 190 def test_visible_and_nested_set_scopes
191 191 assert_equal 0, Issue.find(1).descendants.visible.all.size
192 192 end
193 193
194 194 def test_errors_full_messages_should_include_custom_fields_errors
195 195 field = IssueCustomField.find_by_name('Database')
196 196
197 197 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
198 198 :status_id => 1, :subject => 'test_create',
199 199 :description => 'IssueTest#test_create_with_required_custom_field')
200 200 assert issue.available_custom_fields.include?(field)
201 201 # Invalid value
202 202 issue.custom_field_values = { field.id => 'SQLServer' }
203 203
204 204 assert !issue.valid?
205 205 assert_equal 1, issue.errors.full_messages.size
206 206 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
207 207 end
208 208
209 209 def test_update_issue_with_required_custom_field
210 210 field = IssueCustomField.find_by_name('Database')
211 211 field.update_attribute(:is_required, true)
212 212
213 213 issue = Issue.find(1)
214 214 assert_nil issue.custom_value_for(field)
215 215 assert issue.available_custom_fields.include?(field)
216 216 # No change to custom values, issue can be saved
217 217 assert issue.save
218 218 # Blank value
219 219 issue.custom_field_values = { field.id => '' }
220 220 assert !issue.save
221 221 # Valid value
222 222 issue.custom_field_values = { field.id => 'PostgreSQL' }
223 223 assert issue.save
224 224 issue.reload
225 225 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
226 226 end
227 227
228 228 def test_should_not_update_attributes_if_custom_fields_validation_fails
229 229 issue = Issue.find(1)
230 230 field = IssueCustomField.find_by_name('Database')
231 231 assert issue.available_custom_fields.include?(field)
232 232
233 233 issue.custom_field_values = { field.id => 'Invalid' }
234 234 issue.subject = 'Should be not be saved'
235 235 assert !issue.save
236 236
237 237 issue.reload
238 238 assert_equal "Can't print recipes", issue.subject
239 239 end
240 240
241 241 def test_should_not_recreate_custom_values_objects_on_update
242 242 field = IssueCustomField.find_by_name('Database')
243 243
244 244 issue = Issue.find(1)
245 245 issue.custom_field_values = { field.id => 'PostgreSQL' }
246 246 assert issue.save
247 247 custom_value = issue.custom_value_for(field)
248 248 issue.reload
249 249 issue.custom_field_values = { field.id => 'MySQL' }
250 250 assert issue.save
251 251 issue.reload
252 252 assert_equal custom_value.id, issue.custom_value_for(field).id
253 253 end
254 254
255 255 def test_assigning_tracker_id_should_reload_custom_fields_values
256 256 issue = Issue.new(:project => Project.find(1))
257 257 assert issue.custom_field_values.empty?
258 258 issue.tracker_id = 1
259 259 assert issue.custom_field_values.any?
260 260 end
261 261
262 262 def test_assigning_attributes_should_assign_tracker_id_first
263 263 attributes = ActiveSupport::OrderedHash.new
264 264 attributes['custom_field_values'] = { '1' => 'MySQL' }
265 265 attributes['tracker_id'] = '1'
266 266 issue = Issue.new(:project => Project.find(1))
267 267 issue.attributes = attributes
268 268 assert_not_nil issue.custom_value_for(1)
269 269 assert_equal 'MySQL', issue.custom_value_for(1).value
270 270 end
271 271
272 272 def test_should_update_issue_with_disabled_tracker
273 273 p = Project.find(1)
274 274 issue = Issue.find(1)
275 275
276 276 p.trackers.delete(issue.tracker)
277 277 assert !p.trackers.include?(issue.tracker)
278 278
279 279 issue.reload
280 280 issue.subject = 'New subject'
281 281 assert issue.save
282 282 end
283 283
284 284 def test_should_not_set_a_disabled_tracker
285 285 p = Project.find(1)
286 286 p.trackers.delete(Tracker.find(2))
287 287
288 288 issue = Issue.find(1)
289 289 issue.tracker_id = 2
290 290 issue.subject = 'New subject'
291 291 assert !issue.save
292 292 assert_not_nil issue.errors.on(:tracker_id)
293 293 end
294 294
295 295 def test_category_based_assignment
296 296 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
297 297 :status_id => 1, :priority => IssuePriority.all.first,
298 298 :subject => 'Assignment test',
299 299 :description => 'Assignment test', :category_id => 1)
300 300 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
301 301 end
302 302
303 303 def test_new_statuses_allowed_to
304 304 Workflow.delete_all
305 305
306 306 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
307 307 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
308 308 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
309 309 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
310 310 status = IssueStatus.find(1)
311 311 role = Role.find(1)
312 312 tracker = Tracker.find(1)
313 313 user = User.find(2)
314 314
315 315 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
316 316 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
317 317
318 318 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
319 319 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
320 320
321 321 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
322 322 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
323 323
324 324 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
325 325 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
326 326 end
327 327
328 328 def test_copy
329 329 issue = Issue.new.copy_from(1)
330 330 assert issue.save
331 331 issue.reload
332 332 orig = Issue.find(1)
333 333 assert_equal orig.subject, issue.subject
334 334 assert_equal orig.tracker, issue.tracker
335 335 assert_equal "125", issue.custom_value_for(2).value
336 336 end
337 337
338 338 def test_copy_should_copy_status
339 339 orig = Issue.find(8)
340 340 assert orig.status != IssueStatus.default
341 341
342 342 issue = Issue.new.copy_from(orig)
343 343 assert issue.save
344 344 issue.reload
345 345 assert_equal orig.status, issue.status
346 346 end
347 347
348 348 def test_should_close_duplicates
349 349 # Create 3 issues
350 350 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
351 351 assert issue1.save
352 352 issue2 = issue1.clone
353 353 assert issue2.save
354 354 issue3 = issue1.clone
355 355 assert issue3.save
356 356
357 357 # 2 is a dupe of 1
358 358 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
359 359 # And 3 is a dupe of 2
360 360 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
361 361 # And 3 is a dupe of 1 (circular duplicates)
362 362 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
363 363
364 364 assert issue1.reload.duplicates.include?(issue2)
365 365
366 366 # Closing issue 1
367 367 issue1.init_journal(User.find(:first), "Closing issue1")
368 368 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
369 369 assert issue1.save
370 370 # 2 and 3 should be also closed
371 371 assert issue2.reload.closed?
372 372 assert issue3.reload.closed?
373 373 end
374 374
375 375 def test_should_not_close_duplicated_issue
376 376 # Create 3 issues
377 377 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
378 378 assert issue1.save
379 379 issue2 = issue1.clone
380 380 assert issue2.save
381 381
382 382 # 2 is a dupe of 1
383 383 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
384 384 # 2 is a dup of 1 but 1 is not a duplicate of 2
385 385 assert !issue2.reload.duplicates.include?(issue1)
386 386
387 387 # Closing issue 2
388 388 issue2.init_journal(User.find(:first), "Closing issue2")
389 389 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
390 390 assert issue2.save
391 391 # 1 should not be also closed
392 392 assert !issue1.reload.closed?
393 393 end
394 394
395 395 def test_assignable_versions
396 396 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
397 397 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
398 398 end
399 399
400 400 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
401 401 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
402 402 assert !issue.save
403 403 assert_not_nil issue.errors.on(:fixed_version_id)
404 404 end
405 405
406 406 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
407 407 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
408 408 assert !issue.save
409 409 assert_not_nil issue.errors.on(:fixed_version_id)
410 410 end
411 411
412 412 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
413 413 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
414 414 assert issue.save
415 415 end
416 416
417 417 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
418 418 issue = Issue.find(11)
419 419 assert_equal 'closed', issue.fixed_version.status
420 420 issue.subject = 'Subject changed'
421 421 assert issue.save
422 422 end
423 423
424 424 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
425 425 issue = Issue.find(11)
426 426 issue.status_id = 1
427 427 assert !issue.save
428 428 assert_not_nil issue.errors.on_base
429 429 end
430 430
431 431 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
432 432 issue = Issue.find(11)
433 433 issue.status_id = 1
434 434 issue.fixed_version_id = 3
435 435 assert issue.save
436 436 end
437 437
438 438 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
439 439 issue = Issue.find(12)
440 440 assert_equal 'locked', issue.fixed_version.status
441 441 issue.status_id = 1
442 442 assert issue.save
443 443 end
444 444
445 445 def test_move_to_another_project_with_same_category
446 446 issue = Issue.find(1)
447 447 assert issue.move_to_project(Project.find(2))
448 448 issue.reload
449 449 assert_equal 2, issue.project_id
450 450 # Category changes
451 451 assert_equal 4, issue.category_id
452 452 # Make sure time entries were move to the target project
453 453 assert_equal 2, issue.time_entries.first.project_id
454 454 end
455 455
456 456 def test_move_to_another_project_without_same_category
457 457 issue = Issue.find(2)
458 458 assert issue.move_to_project(Project.find(2))
459 459 issue.reload
460 460 assert_equal 2, issue.project_id
461 461 # Category cleared
462 462 assert_nil issue.category_id
463 463 end
464 464
465 465 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
466 466 issue = Issue.find(1)
467 467 issue.update_attribute(:fixed_version_id, 1)
468 468 assert issue.move_to_project(Project.find(2))
469 469 issue.reload
470 470 assert_equal 2, issue.project_id
471 471 # Cleared fixed_version
472 472 assert_equal nil, issue.fixed_version
473 473 end
474 474
475 475 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
476 476 issue = Issue.find(1)
477 477 issue.update_attribute(:fixed_version_id, 4)
478 478 assert issue.move_to_project(Project.find(5))
479 479 issue.reload
480 480 assert_equal 5, issue.project_id
481 481 # Keep fixed_version
482 482 assert_equal 4, issue.fixed_version_id
483 483 end
484 484
485 485 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
486 486 issue = Issue.find(1)
487 487 issue.update_attribute(:fixed_version_id, 1)
488 488 assert issue.move_to_project(Project.find(5))
489 489 issue.reload
490 490 assert_equal 5, issue.project_id
491 491 # Cleared fixed_version
492 492 assert_equal nil, issue.fixed_version
493 493 end
494 494
495 495 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
496 496 issue = Issue.find(1)
497 497 issue.update_attribute(:fixed_version_id, 7)
498 498 assert issue.move_to_project(Project.find(2))
499 499 issue.reload
500 500 assert_equal 2, issue.project_id
501 501 # Keep fixed_version
502 502 assert_equal 7, issue.fixed_version_id
503 503 end
504 504
505 505 def test_move_to_another_project_with_disabled_tracker
506 506 issue = Issue.find(1)
507 507 target = Project.find(2)
508 508 target.tracker_ids = [3]
509 509 target.save
510 510 assert_equal false, issue.move_to_project(target)
511 511 issue.reload
512 512 assert_equal 1, issue.project_id
513 513 end
514 514
515 515 def test_copy_to_the_same_project
516 516 issue = Issue.find(1)
517 517 copy = nil
518 518 assert_difference 'Issue.count' do
519 519 copy = issue.move_to_project(issue.project, nil, :copy => true)
520 520 end
521 521 assert_kind_of Issue, copy
522 522 assert_equal issue.project, copy.project
523 523 assert_equal "125", copy.custom_value_for(2).value
524 524 end
525 525
526 526 def test_copy_to_another_project_and_tracker
527 527 issue = Issue.find(1)
528 528 copy = nil
529 529 assert_difference 'Issue.count' do
530 530 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
531 531 end
532 532 copy.reload
533 533 assert_kind_of Issue, copy
534 534 assert_equal Project.find(3), copy.project
535 535 assert_equal Tracker.find(2), copy.tracker
536 536 # Custom field #2 is not associated with target tracker
537 537 assert_nil copy.custom_value_for(2)
538 538 end
539 539
540 540 context "#move_to_project" do
541 541 context "as a copy" do
542 542 setup do
543 543 @issue = Issue.find(1)
544 544 @copy = nil
545 545 end
546 546
547 547 should "not create a journal" do
548 548 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
549 549 assert_equal 0, @copy.reload.journals.size
550 550 end
551 551
552 552 should "allow assigned_to changes" do
553 553 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
554 554 assert_equal 3, @copy.assigned_to_id
555 555 end
556 556
557 557 should "allow status changes" do
558 558 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
559 559 assert_equal 2, @copy.status_id
560 560 end
561 561
562 562 should "allow start date changes" do
563 563 date = Date.today
564 564 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
565 565 assert_equal date, @copy.start_date
566 566 end
567 567
568 568 should "allow due date changes" do
569 569 date = Date.today
570 570 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
571 571
572 572 assert_equal date, @copy.due_date
573 573 end
574 574
575 575 should "set current user as author" do
576 576 User.current = User.find(9)
577 577 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
578 578
579 579 assert_equal User.current, @copy.author
580 580 end
581 581
582 582 should "keep journal notes" do
583 583 date = Date.today
584 584 notes = "Notes added when copying"
585 585 User.current = User.find(9)
586 586 @issue.init_journal(User.current, notes)
587 587 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
588 588
589 589 assert_equal 1, @copy.journals.size
590 590 journal = @copy.journals.first
591 591 assert_equal 0, journal.details.size
592 592 assert_equal notes, journal.notes
593 593 end
594 594 end
595 595 end
596 596
597 597 def test_recipients_should_not_include_users_that_cannot_view_the_issue
598 598 issue = Issue.find(12)
599 599 assert issue.recipients.include?(issue.author.mail)
600 600 # move the issue to a private project
601 601 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
602 602 # author is not a member of project anymore
603 603 assert !copy.recipients.include?(copy.author.mail)
604 604 end
605 605
606 606 def test_recipients_should_include_the_assigned_group_members
607 607 group_member = User.generate_with_protected!
608 608 group = Group.generate!
609 609 group.users << group_member
610 610
611 611 issue = Issue.find(12)
612 612 issue.assigned_to = group
613 613 assert issue.recipients.include?(group_member.mail)
614 614 end
615 615
616 616 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
617 617 user = User.find(3)
618 618 issue = Issue.find(9)
619 619 Watcher.create!(:user => user, :watchable => issue)
620 620 assert issue.watched_by?(user)
621 621 assert !issue.watcher_recipients.include?(user.mail)
622 622 end
623 623
624 624 def test_issue_destroy
625 625 Issue.find(1).destroy
626 626 assert_nil Issue.find_by_id(1)
627 627 assert_nil TimeEntry.find_by_issue_id(1)
628 628 end
629 629
630 630 def test_blocked
631 631 blocked_issue = Issue.find(9)
632 632 blocking_issue = Issue.find(10)
633 633
634 634 assert blocked_issue.blocked?
635 635 assert !blocking_issue.blocked?
636 636 end
637 637
638 638 def test_blocked_issues_dont_allow_closed_statuses
639 639 blocked_issue = Issue.find(9)
640 640
641 641 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
642 642 assert !allowed_statuses.empty?
643 643 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
644 644 assert closed_statuses.empty?
645 645 end
646 646
647 647 def test_unblocked_issues_allow_closed_statuses
648 648 blocking_issue = Issue.find(10)
649 649
650 650 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
651 651 assert !allowed_statuses.empty?
652 652 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
653 653 assert !closed_statuses.empty?
654 654 end
655 655
656 656 def test_rescheduling_an_issue_should_reschedule_following_issue
657 657 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
658 658 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
659 659 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
660 660 assert_equal issue1.due_date + 1, issue2.reload.start_date
661 661
662 662 issue1.due_date = Date.today + 5
663 663 issue1.save!
664 664 assert_equal issue1.due_date + 1, issue2.reload.start_date
665 665 end
666 666
667 667 def test_overdue
668 668 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
669 669 assert !Issue.new(:due_date => Date.today).overdue?
670 670 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
671 671 assert !Issue.new(:due_date => nil).overdue?
672 672 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
673 673 end
674 674
675 675 context "#behind_schedule?" do
676 676 should "be false if the issue has no start_date" do
677 677 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
678 678 end
679 679
680 680 should "be false if the issue has no end_date" do
681 681 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
682 682 end
683 683
684 684 should "be false if the issue has more done than it's calendar time" do
685 685 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
686 686 end
687 687
688 688 should "be true if the issue hasn't been started at all" do
689 689 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
690 690 end
691 691
692 692 should "be true if the issue has used more calendar time than it's done ratio" do
693 693 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
694 694 end
695 695 end
696 696
697 697 context "#assignable_users" do
698 698 should "be Users" do
699 699 assert_kind_of User, Issue.find(1).assignable_users.first
700 700 end
701 701
702 702 should "include the issue author" do
703 703 project = Project.find(1)
704 704 non_project_member = User.generate!
705 705 issue = Issue.generate_for_project!(project, :author => non_project_member)
706 706
707 707 assert issue.assignable_users.include?(non_project_member)
708 708 end
709 709
710 710 should "include the current assignee" do
711 711 project = Project.find(1)
712 712 user = User.generate!
713 713 issue = Issue.generate_for_project!(project, :assigned_to => user)
714 714 user.lock!
715 715
716 716 assert Issue.find(issue.id).assignable_users.include?(user)
717 717 end
718 718
719 719 should "not show the issue author twice" do
720 720 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
721 721 assert_equal 2, assignable_user_ids.length
722 722
723 723 assignable_user_ids.each do |user_id|
724 724 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
725 725 end
726 726 end
727 727
728 728 context "with issue_group_assignment" do
729 729 should "include groups" do
730 730 issue = Issue.new(:project => Project.find(2))
731 731
732 732 with_settings :issue_group_assignment => '1' do
733 733 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
734 734 assert issue.assignable_users.include?(Group.find(11))
735 735 end
736 736 end
737 737 end
738 738
739 739 context "without issue_group_assignment" do
740 740 should "not include groups" do
741 741 issue = Issue.new(:project => Project.find(2))
742 742
743 743 with_settings :issue_group_assignment => '0' do
744 744 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
745 745 assert !issue.assignable_users.include?(Group.find(11))
746 746 end
747 747 end
748 748 end
749 749 end
750 750
751 751 def test_create_should_send_email_notification
752 752 ActionMailer::Base.deliveries.clear
753 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
753 issue = Issue.new(:project_id => 1, :tracker_id => 1,
754 :author_id => 3, :status_id => 1,
755 :priority => IssuePriority.all.first,
756 :subject => 'test_create', :estimated_hours => '1:30')
754 757
755 758 assert issue.save
756 759 assert_equal 1, ActionMailer::Base.deliveries.size
757 760 end
758 761
759 762 def test_stale_issue_should_not_send_email_notification
760 763 ActionMailer::Base.deliveries.clear
761 764 issue = Issue.find(1)
762 765 stale = Issue.find(1)
763 766
764 767 issue.init_journal(User.find(1))
765 768 issue.subject = 'Subjet update'
766 769 assert issue.save
767 770 assert_equal 1, ActionMailer::Base.deliveries.size
768 771 ActionMailer::Base.deliveries.clear
769 772
770 773 stale.init_journal(User.find(1))
771 774 stale.subject = 'Another subjet update'
772 775 assert_raise ActiveRecord::StaleObjectError do
773 776 stale.save
774 777 end
775 778 assert ActionMailer::Base.deliveries.empty?
776 779 end
777 780
778 781 def test_journalized_description
779 782 IssueCustomField.delete_all
780 783
781 784 i = Issue.first
782 785 old_description = i.description
783 786 new_description = "This is the new description"
784 787
785 788 i.init_journal(User.find(2))
786 789 i.description = new_description
787 790 assert_difference 'Journal.count', 1 do
788 791 assert_difference 'JournalDetail.count', 1 do
789 792 i.save!
790 793 end
791 794 end
792 795
793 796 detail = JournalDetail.first(:order => 'id DESC')
794 797 assert_equal i, detail.journal.journalized
795 798 assert_equal 'attr', detail.property
796 799 assert_equal 'description', detail.prop_key
797 800 assert_equal old_description, detail.old_value
798 801 assert_equal new_description, detail.value
799 802 end
800 803
801 804 def test_blank_descriptions_should_not_be_journalized
802 805 IssueCustomField.delete_all
803 806 Issue.update_all("description = NULL", "id=1")
804 807
805 808 i = Issue.find(1)
806 809 i.init_journal(User.find(2))
807 810 i.subject = "blank description"
808 811 i.description = "\r\n"
809 812
810 813 assert_difference 'Journal.count', 1 do
811 814 assert_difference 'JournalDetail.count', 1 do
812 815 i.save!
813 816 end
814 817 end
815 818 end
816 819
817 820 def test_description_eol_should_be_normalized
818 821 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
819 822 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
820 823 end
821 824
822 825 def test_saving_twice_should_not_duplicate_journal_details
823 826 i = Issue.find(:first)
824 827 i.init_journal(User.find(2), 'Some notes')
825 828 # initial changes
826 829 i.subject = 'New subject'
827 830 i.done_ratio = i.done_ratio + 10
828 831 assert_difference 'Journal.count' do
829 832 assert i.save
830 833 end
831 834 # 1 more change
832 835 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
833 836 assert_no_difference 'Journal.count' do
834 837 assert_difference 'JournalDetail.count', 1 do
835 838 i.save
836 839 end
837 840 end
838 841 # no more change
839 842 assert_no_difference 'Journal.count' do
840 843 assert_no_difference 'JournalDetail.count' do
841 844 i.save
842 845 end
843 846 end
844 847 end
845 848
846 849 def test_all_dependent_issues
847 850 IssueRelation.delete_all
848 851 assert IssueRelation.create!(:issue_from => Issue.find(1),
849 852 :issue_to => Issue.find(2),
850 853 :relation_type => IssueRelation::TYPE_PRECEDES)
851 854 assert IssueRelation.create!(:issue_from => Issue.find(2),
852 855 :issue_to => Issue.find(3),
853 856 :relation_type => IssueRelation::TYPE_PRECEDES)
854 857 assert IssueRelation.create!(:issue_from => Issue.find(3),
855 858 :issue_to => Issue.find(8),
856 859 :relation_type => IssueRelation::TYPE_PRECEDES)
857 860
858 861 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
859 862 end
860 863
861 864 def test_all_dependent_issues_with_persistent_circular_dependency
862 865 IssueRelation.delete_all
863 866 assert IssueRelation.create!(:issue_from => Issue.find(1),
864 867 :issue_to => Issue.find(2),
865 868 :relation_type => IssueRelation::TYPE_PRECEDES)
866 869 assert IssueRelation.create!(:issue_from => Issue.find(2),
867 870 :issue_to => Issue.find(3),
868 871 :relation_type => IssueRelation::TYPE_PRECEDES)
869 872 # Validation skipping
870 873 assert IssueRelation.new(:issue_from => Issue.find(3),
871 874 :issue_to => Issue.find(1),
872 875 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
873 876
874 877 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
875 878 end
876 879
877 880 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
878 881 IssueRelation.delete_all
879 882 assert IssueRelation.create!(:issue_from => Issue.find(1),
880 883 :issue_to => Issue.find(2),
881 884 :relation_type => IssueRelation::TYPE_RELATES)
882 885 assert IssueRelation.create!(:issue_from => Issue.find(2),
883 886 :issue_to => Issue.find(3),
884 887 :relation_type => IssueRelation::TYPE_RELATES)
885 888 assert IssueRelation.create!(:issue_from => Issue.find(3),
886 889 :issue_to => Issue.find(8),
887 890 :relation_type => IssueRelation::TYPE_RELATES)
888 891 # Validation skipping
889 892 assert IssueRelation.new(:issue_from => Issue.find(8),
890 893 :issue_to => Issue.find(2),
891 894 :relation_type => IssueRelation::TYPE_RELATES).save(false)
892 895 assert IssueRelation.new(:issue_from => Issue.find(3),
893 896 :issue_to => Issue.find(1),
894 897 :relation_type => IssueRelation::TYPE_RELATES).save(false)
895 898
896 899 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
897 900 end
898 901
899 902 context "#done_ratio" do
900 903 setup do
901 904 @issue = Issue.find(1)
902 905 @issue_status = IssueStatus.find(1)
903 906 @issue_status.update_attribute(:default_done_ratio, 50)
904 907 @issue2 = Issue.find(2)
905 908 @issue_status2 = IssueStatus.find(2)
906 909 @issue_status2.update_attribute(:default_done_ratio, 0)
907 910 end
908 911
909 912 context "with Setting.issue_done_ratio using the issue_field" do
910 913 setup do
911 914 Setting.issue_done_ratio = 'issue_field'
912 915 end
913 916
914 917 should "read the issue's field" do
915 918 assert_equal 0, @issue.done_ratio
916 919 assert_equal 30, @issue2.done_ratio
917 920 end
918 921 end
919 922
920 923 context "with Setting.issue_done_ratio using the issue_status" do
921 924 setup do
922 925 Setting.issue_done_ratio = 'issue_status'
923 926 end
924 927
925 928 should "read the Issue Status's default done ratio" do
926 929 assert_equal 50, @issue.done_ratio
927 930 assert_equal 0, @issue2.done_ratio
928 931 end
929 932 end
930 933 end
931 934
932 935 context "#update_done_ratio_from_issue_status" do
933 936 setup do
934 937 @issue = Issue.find(1)
935 938 @issue_status = IssueStatus.find(1)
936 939 @issue_status.update_attribute(:default_done_ratio, 50)
937 940 @issue2 = Issue.find(2)
938 941 @issue_status2 = IssueStatus.find(2)
939 942 @issue_status2.update_attribute(:default_done_ratio, 0)
940 943 end
941 944
942 945 context "with Setting.issue_done_ratio using the issue_field" do
943 946 setup do
944 947 Setting.issue_done_ratio = 'issue_field'
945 948 end
946 949
947 950 should "not change the issue" do
948 951 @issue.update_done_ratio_from_issue_status
949 952 @issue2.update_done_ratio_from_issue_status
950 953
951 954 assert_equal 0, @issue.read_attribute(:done_ratio)
952 955 assert_equal 30, @issue2.read_attribute(:done_ratio)
953 956 end
954 957 end
955 958
956 959 context "with Setting.issue_done_ratio using the issue_status" do
957 960 setup do
958 961 Setting.issue_done_ratio = 'issue_status'
959 962 end
960 963
961 964 should "change the issue's done ratio" do
962 965 @issue.update_done_ratio_from_issue_status
963 966 @issue2.update_done_ratio_from_issue_status
964 967
965 968 assert_equal 50, @issue.read_attribute(:done_ratio)
966 969 assert_equal 0, @issue2.read_attribute(:done_ratio)
967 970 end
968 971 end
969 972 end
970 973
971 974 test "#by_tracker" do
972 975 User.current = User.anonymous
973 976 groups = Issue.by_tracker(Project.find(1))
974 977 assert_equal 3, groups.size
975 978 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
976 979 end
977 980
978 981 test "#by_version" do
979 982 User.current = User.anonymous
980 983 groups = Issue.by_version(Project.find(1))
981 984 assert_equal 3, groups.size
982 985 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
983 986 end
984 987
985 988 test "#by_priority" do
986 989 User.current = User.anonymous
987 990 groups = Issue.by_priority(Project.find(1))
988 991 assert_equal 4, groups.size
989 992 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
990 993 end
991 994
992 995 test "#by_category" do
993 996 User.current = User.anonymous
994 997 groups = Issue.by_category(Project.find(1))
995 998 assert_equal 2, groups.size
996 999 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
997 1000 end
998 1001
999 1002 test "#by_assigned_to" do
1000 1003 User.current = User.anonymous
1001 1004 groups = Issue.by_assigned_to(Project.find(1))
1002 1005 assert_equal 2, groups.size
1003 1006 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1004 1007 end
1005 1008
1006 1009 test "#by_author" do
1007 1010 User.current = User.anonymous
1008 1011 groups = Issue.by_author(Project.find(1))
1009 1012 assert_equal 4, groups.size
1010 1013 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1011 1014 end
1012 1015
1013 1016 test "#by_subproject" do
1014 1017 User.current = User.anonymous
1015 1018 groups = Issue.by_subproject(Project.find(1))
1016 1019 # Private descendant not visible
1017 1020 assert_equal 1, groups.size
1018 1021 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1019 1022 end
1020 1023
1021 1024 context ".allowed_target_projects_on_move" do
1022 1025 should "return all active projects for admin users" do
1023 1026 User.current = User.find(1)
1024 1027 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1025 1028 end
1026 1029
1027 1030 should "return allowed projects for non admin users" do
1028 1031 User.current = User.find(2)
1029 1032 Role.non_member.remove_permission! :move_issues
1030 1033 assert_equal 3, Issue.allowed_target_projects_on_move.size
1031 1034
1032 1035 Role.non_member.add_permission! :move_issues
1033 1036 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1034 1037 end
1035 1038 end
1036 1039
1037 1040 def test_recently_updated_with_limit_scopes
1038 1041 #should return the last updated issue
1039 1042 assert_equal 1, Issue.recently_updated.with_limit(1).length
1040 1043 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1041 1044 end
1042 1045
1043 1046 def test_on_active_projects_scope
1044 1047 assert Project.find(2).archive
1045 1048
1046 1049 before = Issue.on_active_project.length
1047 1050 # test inclusion to results
1048 1051 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1049 1052 assert_equal before + 1, Issue.on_active_project.length
1050 1053
1051 1054 # Move to an archived project
1052 1055 issue.project = Project.find(2)
1053 1056 assert issue.save
1054 1057 assert_equal before, Issue.on_active_project.length
1055 1058 end
1056 1059
1057 1060 context "Issue#recipients" do
1058 1061 setup do
1059 1062 @project = Project.find(1)
1060 1063 @author = User.generate_with_protected!
1061 1064 @assignee = User.generate_with_protected!
1062 1065 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1063 1066 end
1064 1067
1065 1068 should "include project recipients" do
1066 1069 assert @project.recipients.present?
1067 1070 @project.recipients.each do |project_recipient|
1068 1071 assert @issue.recipients.include?(project_recipient)
1069 1072 end
1070 1073 end
1071 1074
1072 1075 should "include the author if the author is active" do
1073 1076 assert @issue.author, "No author set for Issue"
1074 1077 assert @issue.recipients.include?(@issue.author.mail)
1075 1078 end
1076 1079
1077 1080 should "include the assigned to user if the assigned to user is active" do
1078 1081 assert @issue.assigned_to, "No assigned_to set for Issue"
1079 1082 assert @issue.recipients.include?(@issue.assigned_to.mail)
1080 1083 end
1081 1084
1082 1085 should "not include users who opt out of all email" do
1083 1086 @author.update_attribute(:mail_notification, :none)
1084 1087
1085 1088 assert !@issue.recipients.include?(@issue.author.mail)
1086 1089 end
1087 1090
1088 1091 should "not include the issue author if they are only notified of assigned issues" do
1089 1092 @author.update_attribute(:mail_notification, :only_assigned)
1090 1093
1091 1094 assert !@issue.recipients.include?(@issue.author.mail)
1092 1095 end
1093 1096
1094 1097 should "not include the assigned user if they are only notified of owned issues" do
1095 1098 @assignee.update_attribute(:mail_notification, :only_owner)
1096 1099
1097 1100 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1098 1101 end
1099 1102
1100 1103 end
1101 1104 end
General Comments 0
You need to be logged in to leave comments. Login now