##// END OF EJS Templates
code layout clean up test_should_not_call_after_project_change_on_creation of unit issue test...
Toshi MARUYAMA -
r10439:04ac60d891f8
parent child
Show More
@@ -1,1788 +1,1789
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../../test_helper', __FILE__)
18 require File.expand_path('../../test_helper', __FILE__)
19
19
20 class IssueTest < ActiveSupport::TestCase
20 class IssueTest < ActiveSupport::TestCase
21 fixtures :projects, :users, :members, :member_roles, :roles,
21 fixtures :projects, :users, :members, :member_roles, :roles,
22 :groups_users,
22 :groups_users,
23 :trackers, :projects_trackers,
23 :trackers, :projects_trackers,
24 :enabled_modules,
24 :enabled_modules,
25 :versions,
25 :versions,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 :enumerations,
27 :enumerations,
28 :issues, :journals, :journal_details,
28 :issues, :journals, :journal_details,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 :time_entries
30 :time_entries
31
31
32 include Redmine::I18n
32 include Redmine::I18n
33
33
34 def teardown
34 def teardown
35 User.current = nil
35 User.current = nil
36 end
36 end
37
37
38 def test_create
38 def test_create
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
40 :status_id => 1, :priority => IssuePriority.all.first,
40 :status_id => 1, :priority => IssuePriority.all.first,
41 :subject => 'test_create',
41 :subject => 'test_create',
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
43 assert issue.save
43 assert issue.save
44 issue.reload
44 issue.reload
45 assert_equal 1.5, issue.estimated_hours
45 assert_equal 1.5, issue.estimated_hours
46 end
46 end
47
47
48 def test_create_minimal
48 def test_create_minimal
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
50 :status_id => 1, :priority => IssuePriority.all.first,
50 :status_id => 1, :priority => IssuePriority.all.first,
51 :subject => 'test_create')
51 :subject => 'test_create')
52 assert issue.save
52 assert issue.save
53 assert issue.description.nil?
53 assert issue.description.nil?
54 assert_nil issue.estimated_hours
54 assert_nil issue.estimated_hours
55 end
55 end
56
56
57 def test_create_with_required_custom_field
57 def test_create_with_required_custom_field
58 set_language_if_valid 'en'
58 set_language_if_valid 'en'
59 field = IssueCustomField.find_by_name('Database')
59 field = IssueCustomField.find_by_name('Database')
60 field.update_attribute(:is_required, true)
60 field.update_attribute(:is_required, true)
61
61
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
63 :status_id => 1, :subject => 'test_create',
63 :status_id => 1, :subject => 'test_create',
64 :description => 'IssueTest#test_create_with_required_custom_field')
64 :description => 'IssueTest#test_create_with_required_custom_field')
65 assert issue.available_custom_fields.include?(field)
65 assert issue.available_custom_fields.include?(field)
66 # No value for the custom field
66 # No value for the custom field
67 assert !issue.save
67 assert !issue.save
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
69 # Blank value
69 # Blank value
70 issue.custom_field_values = { field.id => '' }
70 issue.custom_field_values = { field.id => '' }
71 assert !issue.save
71 assert !issue.save
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
73 # Invalid value
73 # Invalid value
74 issue.custom_field_values = { field.id => 'SQLServer' }
74 issue.custom_field_values = { field.id => 'SQLServer' }
75 assert !issue.save
75 assert !issue.save
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
77 # Valid value
77 # Valid value
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
79 assert issue.save
79 assert issue.save
80 issue.reload
80 issue.reload
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
82 end
82 end
83
83
84 def test_create_with_group_assignment
84 def test_create_with_group_assignment
85 with_settings :issue_group_assignment => '1' do
85 with_settings :issue_group_assignment => '1' do
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
87 :subject => 'Group assignment',
87 :subject => 'Group assignment',
88 :assigned_to_id => 11).save
88 :assigned_to_id => 11).save
89 issue = Issue.first(:order => 'id DESC')
89 issue = Issue.first(:order => 'id DESC')
90 assert_kind_of Group, issue.assigned_to
90 assert_kind_of Group, issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
92 end
92 end
93 end
93 end
94
94
95 def test_create_with_parent_issue_id
95 def test_create_with_parent_issue_id
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
97 :author_id => 1, :subject => 'Group assignment',
97 :author_id => 1, :subject => 'Group assignment',
98 :parent_issue_id => 1)
98 :parent_issue_id => 1)
99 assert_save issue
99 assert_save issue
100 assert_equal 1, issue.parent_issue_id
100 assert_equal 1, issue.parent_issue_id
101 assert_equal Issue.find(1), issue.parent
101 assert_equal Issue.find(1), issue.parent
102 end
102 end
103
103
104 def test_create_with_sharp_parent_issue_id
104 def test_create_with_sharp_parent_issue_id
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
106 :author_id => 1, :subject => 'Group assignment',
106 :author_id => 1, :subject => 'Group assignment',
107 :parent_issue_id => "#1")
107 :parent_issue_id => "#1")
108 assert_save issue
108 assert_save issue
109 assert_equal 1, issue.parent_issue_id
109 assert_equal 1, issue.parent_issue_id
110 assert_equal Issue.find(1), issue.parent
110 assert_equal Issue.find(1), issue.parent
111 end
111 end
112
112
113 def test_create_with_invalid_parent_issue_id
113 def test_create_with_invalid_parent_issue_id
114 set_language_if_valid 'en'
114 set_language_if_valid 'en'
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
116 :author_id => 1, :subject => 'Group assignment',
116 :author_id => 1, :subject => 'Group assignment',
117 :parent_issue_id => '01ABC')
117 :parent_issue_id => '01ABC')
118 assert !issue.save
118 assert !issue.save
119 assert_equal '01ABC', issue.parent_issue_id
119 assert_equal '01ABC', issue.parent_issue_id
120 assert_include 'Parent task is invalid', issue.errors.full_messages
120 assert_include 'Parent task is invalid', issue.errors.full_messages
121 end
121 end
122
122
123 def test_create_with_invalid_sharp_parent_issue_id
123 def test_create_with_invalid_sharp_parent_issue_id
124 set_language_if_valid 'en'
124 set_language_if_valid 'en'
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
126 :author_id => 1, :subject => 'Group assignment',
126 :author_id => 1, :subject => 'Group assignment',
127 :parent_issue_id => '#01ABC')
127 :parent_issue_id => '#01ABC')
128 assert !issue.save
128 assert !issue.save
129 assert_equal '#01ABC', issue.parent_issue_id
129 assert_equal '#01ABC', issue.parent_issue_id
130 assert_include 'Parent task is invalid', issue.errors.full_messages
130 assert_include 'Parent task is invalid', issue.errors.full_messages
131 end
131 end
132
132
133 def assert_visibility_match(user, issues)
133 def assert_visibility_match(user, issues)
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
135 end
135 end
136
136
137 def test_visible_scope_for_anonymous
137 def test_visible_scope_for_anonymous
138 # Anonymous user should see issues of public projects only
138 # Anonymous user should see issues of public projects only
139 issues = Issue.visible(User.anonymous).all
139 issues = Issue.visible(User.anonymous).all
140 assert issues.any?
140 assert issues.any?
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
142 assert_nil issues.detect {|issue| issue.is_private?}
142 assert_nil issues.detect {|issue| issue.is_private?}
143 assert_visibility_match User.anonymous, issues
143 assert_visibility_match User.anonymous, issues
144 end
144 end
145
145
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
147 # Anonymous user should not see issues without permission
147 # Anonymous user should not see issues without permission
148 Role.anonymous.remove_permission!(:view_issues)
148 Role.anonymous.remove_permission!(:view_issues)
149 issues = Issue.visible(User.anonymous).all
149 issues = Issue.visible(User.anonymous).all
150 assert issues.empty?
150 assert issues.empty?
151 assert_visibility_match User.anonymous, issues
151 assert_visibility_match User.anonymous, issues
152 end
152 end
153
153
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
158 assert !issue.visible?(User.anonymous)
158 assert !issue.visible?(User.anonymous)
159 end
159 end
160
160
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
165 assert !issue.visible?(User.anonymous)
165 assert !issue.visible?(User.anonymous)
166 end
166 end
167
167
168 def test_visible_scope_for_non_member
168 def test_visible_scope_for_non_member
169 user = User.find(9)
169 user = User.find(9)
170 assert user.projects.empty?
170 assert user.projects.empty?
171 # Non member user should see issues of public projects only
171 # Non member user should see issues of public projects only
172 issues = Issue.visible(user).all
172 issues = Issue.visible(user).all
173 assert issues.any?
173 assert issues.any?
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
175 assert_nil issues.detect {|issue| issue.is_private?}
175 assert_nil issues.detect {|issue| issue.is_private?}
176 assert_visibility_match user, issues
176 assert_visibility_match user, issues
177 end
177 end
178
178
179 def test_visible_scope_for_non_member_with_own_issues_visibility
179 def test_visible_scope_for_non_member_with_own_issues_visibility
180 Role.non_member.update_attribute :issues_visibility, 'own'
180 Role.non_member.update_attribute :issues_visibility, 'own'
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
182 user = User.find(9)
182 user = User.find(9)
183
183
184 issues = Issue.visible(user).all
184 issues = Issue.visible(user).all
185 assert issues.any?
185 assert issues.any?
186 assert_nil issues.detect {|issue| issue.author != user}
186 assert_nil issues.detect {|issue| issue.author != user}
187 assert_visibility_match user, issues
187 assert_visibility_match user, issues
188 end
188 end
189
189
190 def test_visible_scope_for_non_member_without_view_issues_permissions
190 def test_visible_scope_for_non_member_without_view_issues_permissions
191 # Non member user should not see issues without permission
191 # Non member user should not see issues without permission
192 Role.non_member.remove_permission!(:view_issues)
192 Role.non_member.remove_permission!(:view_issues)
193 user = User.find(9)
193 user = User.find(9)
194 assert user.projects.empty?
194 assert user.projects.empty?
195 issues = Issue.visible(user).all
195 issues = Issue.visible(user).all
196 assert issues.empty?
196 assert issues.empty?
197 assert_visibility_match user, issues
197 assert_visibility_match user, issues
198 end
198 end
199
199
200 def test_visible_scope_for_member
200 def test_visible_scope_for_member
201 user = User.find(9)
201 user = User.find(9)
202 # User should see issues of projects for which he has view_issues permissions only
202 # User should see issues of projects for which he has view_issues permissions only
203 Role.non_member.remove_permission!(:view_issues)
203 Role.non_member.remove_permission!(:view_issues)
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
205 issues = Issue.visible(user).all
205 issues = Issue.visible(user).all
206 assert issues.any?
206 assert issues.any?
207 assert_nil issues.detect {|issue| issue.project_id != 3}
207 assert_nil issues.detect {|issue| issue.project_id != 3}
208 assert_nil issues.detect {|issue| issue.is_private?}
208 assert_nil issues.detect {|issue| issue.is_private?}
209 assert_visibility_match user, issues
209 assert_visibility_match user, issues
210 end
210 end
211
211
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
213 user = User.find(8)
213 user = User.find(8)
214 assert user.groups.any?
214 assert user.groups.any?
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
216 Role.non_member.remove_permission!(:view_issues)
216 Role.non_member.remove_permission!(:view_issues)
217
217
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
219 :status_id => 1, :priority => IssuePriority.all.first,
219 :status_id => 1, :priority => IssuePriority.all.first,
220 :subject => 'Assignment test',
220 :subject => 'Assignment test',
221 :assigned_to => user.groups.first,
221 :assigned_to => user.groups.first,
222 :is_private => true)
222 :is_private => true)
223
223
224 Role.find(2).update_attribute :issues_visibility, 'default'
224 Role.find(2).update_attribute :issues_visibility, 'default'
225 issues = Issue.visible(User.find(8)).all
225 issues = Issue.visible(User.find(8)).all
226 assert issues.any?
226 assert issues.any?
227 assert issues.include?(issue)
227 assert issues.include?(issue)
228
228
229 Role.find(2).update_attribute :issues_visibility, 'own'
229 Role.find(2).update_attribute :issues_visibility, 'own'
230 issues = Issue.visible(User.find(8)).all
230 issues = Issue.visible(User.find(8)).all
231 assert issues.any?
231 assert issues.any?
232 assert issues.include?(issue)
232 assert issues.include?(issue)
233 end
233 end
234
234
235 def test_visible_scope_for_admin
235 def test_visible_scope_for_admin
236 user = User.find(1)
236 user = User.find(1)
237 user.members.each(&:destroy)
237 user.members.each(&:destroy)
238 assert user.projects.empty?
238 assert user.projects.empty?
239 issues = Issue.visible(user).all
239 issues = Issue.visible(user).all
240 assert issues.any?
240 assert issues.any?
241 # Admin should see issues on private projects that he does not belong to
241 # Admin should see issues on private projects that he does not belong to
242 assert issues.detect {|issue| !issue.project.is_public?}
242 assert issues.detect {|issue| !issue.project.is_public?}
243 # Admin should see private issues of other users
243 # Admin should see private issues of other users
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
245 assert_visibility_match user, issues
245 assert_visibility_match user, issues
246 end
246 end
247
247
248 def test_visible_scope_with_project
248 def test_visible_scope_with_project
249 project = Project.find(1)
249 project = Project.find(1)
250 issues = Issue.visible(User.find(2), :project => project).all
250 issues = Issue.visible(User.find(2), :project => project).all
251 projects = issues.collect(&:project).uniq
251 projects = issues.collect(&:project).uniq
252 assert_equal 1, projects.size
252 assert_equal 1, projects.size
253 assert_equal project, projects.first
253 assert_equal project, projects.first
254 end
254 end
255
255
256 def test_visible_scope_with_project_and_subprojects
256 def test_visible_scope_with_project_and_subprojects
257 project = Project.find(1)
257 project = Project.find(1)
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
259 projects = issues.collect(&:project).uniq
259 projects = issues.collect(&:project).uniq
260 assert projects.size > 1
260 assert projects.size > 1
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
262 end
262 end
263
263
264 def test_visible_and_nested_set_scopes
264 def test_visible_and_nested_set_scopes
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
266 end
266 end
267
267
268 def test_open_scope
268 def test_open_scope
269 issues = Issue.open.all
269 issues = Issue.open.all
270 assert_nil issues.detect(&:closed?)
270 assert_nil issues.detect(&:closed?)
271 end
271 end
272
272
273 def test_open_scope_with_arg
273 def test_open_scope_with_arg
274 issues = Issue.open(false).all
274 issues = Issue.open(false).all
275 assert_equal issues, issues.select(&:closed?)
275 assert_equal issues, issues.select(&:closed?)
276 end
276 end
277
277
278 def test_errors_full_messages_should_include_custom_fields_errors
278 def test_errors_full_messages_should_include_custom_fields_errors
279 field = IssueCustomField.find_by_name('Database')
279 field = IssueCustomField.find_by_name('Database')
280
280
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
282 :status_id => 1, :subject => 'test_create',
282 :status_id => 1, :subject => 'test_create',
283 :description => 'IssueTest#test_create_with_required_custom_field')
283 :description => 'IssueTest#test_create_with_required_custom_field')
284 assert issue.available_custom_fields.include?(field)
284 assert issue.available_custom_fields.include?(field)
285 # Invalid value
285 # Invalid value
286 issue.custom_field_values = { field.id => 'SQLServer' }
286 issue.custom_field_values = { field.id => 'SQLServer' }
287
287
288 assert !issue.valid?
288 assert !issue.valid?
289 assert_equal 1, issue.errors.full_messages.size
289 assert_equal 1, issue.errors.full_messages.size
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
291 issue.errors.full_messages.first
291 issue.errors.full_messages.first
292 end
292 end
293
293
294 def test_update_issue_with_required_custom_field
294 def test_update_issue_with_required_custom_field
295 field = IssueCustomField.find_by_name('Database')
295 field = IssueCustomField.find_by_name('Database')
296 field.update_attribute(:is_required, true)
296 field.update_attribute(:is_required, true)
297
297
298 issue = Issue.find(1)
298 issue = Issue.find(1)
299 assert_nil issue.custom_value_for(field)
299 assert_nil issue.custom_value_for(field)
300 assert issue.available_custom_fields.include?(field)
300 assert issue.available_custom_fields.include?(field)
301 # No change to custom values, issue can be saved
301 # No change to custom values, issue can be saved
302 assert issue.save
302 assert issue.save
303 # Blank value
303 # Blank value
304 issue.custom_field_values = { field.id => '' }
304 issue.custom_field_values = { field.id => '' }
305 assert !issue.save
305 assert !issue.save
306 # Valid value
306 # Valid value
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
308 assert issue.save
308 assert issue.save
309 issue.reload
309 issue.reload
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
311 end
311 end
312
312
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
314 issue = Issue.find(1)
314 issue = Issue.find(1)
315 field = IssueCustomField.find_by_name('Database')
315 field = IssueCustomField.find_by_name('Database')
316 assert issue.available_custom_fields.include?(field)
316 assert issue.available_custom_fields.include?(field)
317
317
318 issue.custom_field_values = { field.id => 'Invalid' }
318 issue.custom_field_values = { field.id => 'Invalid' }
319 issue.subject = 'Should be not be saved'
319 issue.subject = 'Should be not be saved'
320 assert !issue.save
320 assert !issue.save
321
321
322 issue.reload
322 issue.reload
323 assert_equal "Can't print recipes", issue.subject
323 assert_equal "Can't print recipes", issue.subject
324 end
324 end
325
325
326 def test_should_not_recreate_custom_values_objects_on_update
326 def test_should_not_recreate_custom_values_objects_on_update
327 field = IssueCustomField.find_by_name('Database')
327 field = IssueCustomField.find_by_name('Database')
328
328
329 issue = Issue.find(1)
329 issue = Issue.find(1)
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
331 assert issue.save
331 assert issue.save
332 custom_value = issue.custom_value_for(field)
332 custom_value = issue.custom_value_for(field)
333 issue.reload
333 issue.reload
334 issue.custom_field_values = { field.id => 'MySQL' }
334 issue.custom_field_values = { field.id => 'MySQL' }
335 assert issue.save
335 assert issue.save
336 issue.reload
336 issue.reload
337 assert_equal custom_value.id, issue.custom_value_for(field).id
337 assert_equal custom_value.id, issue.custom_value_for(field).id
338 end
338 end
339
339
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
342 :status_id => 1, :subject => 'Test',
342 :status_id => 1, :subject => 'Test',
343 :custom_field_values => {'2' => 'Test'})
343 :custom_field_values => {'2' => 'Test'})
344 assert !Tracker.find(2).custom_field_ids.include?(2)
344 assert !Tracker.find(2).custom_field_ids.include?(2)
345
345
346 issue = Issue.find(issue.id)
346 issue = Issue.find(issue.id)
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
348
348
349 issue = Issue.find(issue.id)
349 issue = Issue.find(issue.id)
350 custom_value = issue.custom_value_for(2)
350 custom_value = issue.custom_value_for(2)
351 assert_not_nil custom_value
351 assert_not_nil custom_value
352 assert_equal 'Test', custom_value.value
352 assert_equal 'Test', custom_value.value
353 end
353 end
354
354
355 def test_assigning_tracker_id_should_reload_custom_fields_values
355 def test_assigning_tracker_id_should_reload_custom_fields_values
356 issue = Issue.new(:project => Project.find(1))
356 issue = Issue.new(:project => Project.find(1))
357 assert issue.custom_field_values.empty?
357 assert issue.custom_field_values.empty?
358 issue.tracker_id = 1
358 issue.tracker_id = 1
359 assert issue.custom_field_values.any?
359 assert issue.custom_field_values.any?
360 end
360 end
361
361
362 def test_assigning_attributes_should_assign_project_and_tracker_first
362 def test_assigning_attributes_should_assign_project_and_tracker_first
363 seq = sequence('seq')
363 seq = sequence('seq')
364 issue = Issue.new
364 issue = Issue.new
365 issue.expects(:project_id=).in_sequence(seq)
365 issue.expects(:project_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
369 end
369 end
370
370
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
372 attributes = ActiveSupport::OrderedHash.new
372 attributes = ActiveSupport::OrderedHash.new
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
374 attributes['tracker_id'] = '1'
374 attributes['tracker_id'] = '1'
375 issue = Issue.new(:project => Project.find(1))
375 issue = Issue.new(:project => Project.find(1))
376 issue.attributes = attributes
376 issue.attributes = attributes
377 assert_equal 'MySQL', issue.custom_field_value(1)
377 assert_equal 'MySQL', issue.custom_field_value(1)
378 end
378 end
379
379
380 def test_should_update_issue_with_disabled_tracker
380 def test_should_update_issue_with_disabled_tracker
381 p = Project.find(1)
381 p = Project.find(1)
382 issue = Issue.find(1)
382 issue = Issue.find(1)
383
383
384 p.trackers.delete(issue.tracker)
384 p.trackers.delete(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
386
386
387 issue.reload
387 issue.reload
388 issue.subject = 'New subject'
388 issue.subject = 'New subject'
389 assert issue.save
389 assert issue.save
390 end
390 end
391
391
392 def test_should_not_set_a_disabled_tracker
392 def test_should_not_set_a_disabled_tracker
393 p = Project.find(1)
393 p = Project.find(1)
394 p.trackers.delete(Tracker.find(2))
394 p.trackers.delete(Tracker.find(2))
395
395
396 issue = Issue.find(1)
396 issue = Issue.find(1)
397 issue.tracker_id = 2
397 issue.tracker_id = 2
398 issue.subject = 'New subject'
398 issue.subject = 'New subject'
399 assert !issue.save
399 assert !issue.save
400 assert_not_nil issue.errors[:tracker_id]
400 assert_not_nil issue.errors[:tracker_id]
401 end
401 end
402
402
403 def test_category_based_assignment
403 def test_category_based_assignment
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
405 :status_id => 1, :priority => IssuePriority.all.first,
405 :status_id => 1, :priority => IssuePriority.all.first,
406 :subject => 'Assignment test',
406 :subject => 'Assignment test',
407 :description => 'Assignment test', :category_id => 1)
407 :description => 'Assignment test', :category_id => 1)
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
409 end
409 end
410
410
411 def test_new_statuses_allowed_to
411 def test_new_statuses_allowed_to
412 WorkflowTransition.delete_all
412 WorkflowTransition.delete_all
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
414 :old_status_id => 1, :new_status_id => 2,
414 :old_status_id => 1, :new_status_id => 2,
415 :author => false, :assignee => false)
415 :author => false, :assignee => false)
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
417 :old_status_id => 1, :new_status_id => 3,
417 :old_status_id => 1, :new_status_id => 3,
418 :author => true, :assignee => false)
418 :author => true, :assignee => false)
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
420 :new_status_id => 4, :author => false,
420 :new_status_id => 4, :author => false,
421 :assignee => true)
421 :assignee => true)
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
423 :old_status_id => 1, :new_status_id => 5,
423 :old_status_id => 1, :new_status_id => 5,
424 :author => true, :assignee => true)
424 :author => true, :assignee => true)
425 status = IssueStatus.find(1)
425 status = IssueStatus.find(1)
426 role = Role.find(1)
426 role = Role.find(1)
427 tracker = Tracker.find(1)
427 tracker = Tracker.find(1)
428 user = User.find(2)
428 user = User.find(2)
429
429
430 issue = Issue.generate!(:tracker => tracker, :status => status,
430 issue = Issue.generate!(:tracker => tracker, :status => status,
431 :project_id => 1, :author_id => 1)
431 :project_id => 1, :author_id => 1)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
433
433
434 issue = Issue.generate!(:tracker => tracker, :status => status,
434 issue = Issue.generate!(:tracker => tracker, :status => status,
435 :project_id => 1, :author => user)
435 :project_id => 1, :author => user)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
437
437
438 issue = Issue.generate!(:tracker => tracker, :status => status,
438 issue = Issue.generate!(:tracker => tracker, :status => status,
439 :project_id => 1, :author_id => 1,
439 :project_id => 1, :author_id => 1,
440 :assigned_to => user)
440 :assigned_to => user)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
442
442
443 issue = Issue.generate!(:tracker => tracker, :status => status,
443 issue = Issue.generate!(:tracker => tracker, :status => status,
444 :project_id => 1, :author => user,
444 :project_id => 1, :author => user,
445 :assigned_to => user)
445 :assigned_to => user)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
447 end
447 end
448
448
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
450 admin = User.find(1)
450 admin = User.find(1)
451 issue = Issue.find(1)
451 issue = Issue.find(1)
452 assert !admin.member_of?(issue.project)
452 assert !admin.member_of?(issue.project)
453 expected_statuses = [issue.status] +
453 expected_statuses = [issue.status] +
454 WorkflowTransition.find_all_by_old_status_id(
454 WorkflowTransition.find_all_by_old_status_id(
455 issue.status_id).map(&:new_status).uniq.sort
455 issue.status_id).map(&:new_status).uniq.sort
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
457 end
457 end
458
458
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
460 issue = Issue.find(1).copy
460 issue = Issue.find(1).copy
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
462
462
463 issue = Issue.find(2).copy
463 issue = Issue.find(2).copy
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
465 end
465 end
466
466
467 def test_safe_attributes_names_should_not_include_disabled_field
467 def test_safe_attributes_names_should_not_include_disabled_field
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
469
469
470 issue = Issue.new(:tracker => tracker)
470 issue = Issue.new(:tracker => tracker)
471 assert_include 'tracker_id', issue.safe_attribute_names
471 assert_include 'tracker_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
478
478
479 tracker.core_fields.each do |field|
479 tracker.core_fields.each do |field|
480 assert_include field, issue.safe_attribute_names
480 assert_include field, issue.safe_attribute_names
481 end
481 end
482
482
483 tracker.disabled_core_fields.each do |field|
483 tracker.disabled_core_fields.each do |field|
484 assert_not_include field, issue.safe_attribute_names
484 assert_not_include field, issue.safe_attribute_names
485 end
485 end
486 end
486 end
487
487
488 def test_safe_attributes_should_ignore_disabled_fields
488 def test_safe_attributes_should_ignore_disabled_fields
489 tracker = Tracker.find(1)
489 tracker = Tracker.find(1)
490 tracker.core_fields = %w(assigned_to_id due_date)
490 tracker.core_fields = %w(assigned_to_id due_date)
491 tracker.save!
491 tracker.save!
492
492
493 issue = Issue.new(:tracker => tracker)
493 issue = Issue.new(:tracker => tracker)
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
495 assert_nil issue.start_date
495 assert_nil issue.start_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
497 end
497 end
498
498
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
500 source = Tracker.find(1)
500 source = Tracker.find(1)
501 source.core_fields = []
501 source.core_fields = []
502 source.save!
502 source.save!
503 target = Tracker.find(2)
503 target = Tracker.find(2)
504 target.core_fields = %w(assigned_to_id due_date)
504 target.core_fields = %w(assigned_to_id due_date)
505 target.save!
505 target.save!
506
506
507 issue = Issue.new(:tracker => source)
507 issue = Issue.new(:tracker => source)
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
509 assert_equal target, issue.tracker
509 assert_equal target, issue.tracker
510 assert_equal Date.parse('2012-07-14'), issue.due_date
510 assert_equal Date.parse('2012-07-14'), issue.due_date
511 end
511 end
512
512
513 def test_safe_attributes_should_not_include_readonly_fields
513 def test_safe_attributes_should_not_include_readonly_fields
514 WorkflowPermission.delete_all
514 WorkflowPermission.delete_all
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
516 :role_id => 1, :field_name => 'due_date',
516 :role_id => 1, :field_name => 'due_date',
517 :rule => 'readonly')
517 :rule => 'readonly')
518 user = User.find(2)
518 user = User.find(2)
519
519
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
523
523
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
525 assert_equal Date.parse('2012-07-14'), issue.start_date
525 assert_equal Date.parse('2012-07-14'), issue.start_date
526 assert_nil issue.due_date
526 assert_nil issue.due_date
527 end
527 end
528
528
529 def test_safe_attributes_should_not_include_readonly_custom_fields
529 def test_safe_attributes_should_not_include_readonly_custom_fields
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
531 :field_format => 'string',
531 :field_format => 'string',
532 :is_for_all => true, :tracker_ids => [1])
532 :is_for_all => true, :tracker_ids => [1])
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
534 :field_format => 'string',
534 :field_format => 'string',
535 :is_for_all => true, :tracker_ids => [1])
535 :is_for_all => true, :tracker_ids => [1])
536 WorkflowPermission.delete_all
536 WorkflowPermission.delete_all
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
538 :role_id => 1, :field_name => cf2.id.to_s,
538 :role_id => 1, :field_name => cf2.id.to_s,
539 :rule => 'readonly')
539 :rule => 'readonly')
540 user = User.find(2)
540 user = User.find(2)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
544
544
545 issue.send :safe_attributes=, {'custom_field_values' => {
545 issue.send :safe_attributes=, {'custom_field_values' => {
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
547 }}, user
547 }}, user
548 assert_equal 'value1', issue.custom_field_value(cf1)
548 assert_equal 'value1', issue.custom_field_value(cf1)
549 assert_nil issue.custom_field_value(cf2)
549 assert_nil issue.custom_field_value(cf2)
550
550
551 issue.send :safe_attributes=, {'custom_fields' => [
551 issue.send :safe_attributes=, {'custom_fields' => [
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
554 ]}, user
554 ]}, user
555 assert_equal 'valuea', issue.custom_field_value(cf1)
555 assert_equal 'valuea', issue.custom_field_value(cf1)
556 assert_nil issue.custom_field_value(cf2)
556 assert_nil issue.custom_field_value(cf2)
557 end
557 end
558
558
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
561 :is_for_all => true, :tracker_ids => [1, 2])
561 :is_for_all => true, :tracker_ids => [1, 2])
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
563 :is_for_all => true, :tracker_ids => [1, 2])
563 :is_for_all => true, :tracker_ids => [1, 2])
564 WorkflowPermission.delete_all
564 WorkflowPermission.delete_all
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
566 :field_name => cf2.id.to_s, :rule => 'readonly')
566 :field_name => cf2.id.to_s, :rule => 'readonly')
567 user = User.find(2)
567 user = User.find(2)
568
568
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
570 values = issue.editable_custom_field_values(user)
570 values = issue.editable_custom_field_values(user)
571 assert values.detect {|value| value.custom_field == cf1}
571 assert values.detect {|value| value.custom_field == cf1}
572 assert_nil values.detect {|value| value.custom_field == cf2}
572 assert_nil values.detect {|value| value.custom_field == cf2}
573
573
574 issue.tracker_id = 2
574 issue.tracker_id = 2
575 values = issue.editable_custom_field_values(user)
575 values = issue.editable_custom_field_values(user)
576 assert values.detect {|value| value.custom_field == cf1}
576 assert values.detect {|value| value.custom_field == cf1}
577 assert values.detect {|value| value.custom_field == cf2}
577 assert values.detect {|value| value.custom_field == cf2}
578 end
578 end
579
579
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
581 WorkflowPermission.delete_all
581 WorkflowPermission.delete_all
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
583 :role_id => 1, :field_name => 'due_date',
583 :role_id => 1, :field_name => 'due_date',
584 :rule => 'readonly')
584 :rule => 'readonly')
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
586 :role_id => 1, :field_name => 'start_date',
586 :role_id => 1, :field_name => 'start_date',
587 :rule => 'readonly')
587 :rule => 'readonly')
588 user = User.find(2)
588 user = User.find(2)
589
589
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
591
591
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
593 'due_date' => '2012-07-14'}, user
593 'due_date' => '2012-07-14'}, user
594 assert_equal Date.parse('2012-07-12'), issue.start_date
594 assert_equal Date.parse('2012-07-12'), issue.start_date
595 assert_nil issue.due_date
595 assert_nil issue.due_date
596
596
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
598 'due_date' => '2012-07-16',
598 'due_date' => '2012-07-16',
599 'tracker_id' => 2}, user
599 'tracker_id' => 2}, user
600 assert_equal Date.parse('2012-07-12'), issue.start_date
600 assert_equal Date.parse('2012-07-12'), issue.start_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
602 end
602 end
603
603
604 def test_safe_attributes_should_accept_target_status_writable_fields
604 def test_safe_attributes_should_accept_target_status_writable_fields
605 WorkflowPermission.delete_all
605 WorkflowPermission.delete_all
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
607 :role_id => 1, :field_name => 'due_date',
607 :role_id => 1, :field_name => 'due_date',
608 :rule => 'readonly')
608 :rule => 'readonly')
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
610 :role_id => 1, :field_name => 'start_date',
610 :role_id => 1, :field_name => 'start_date',
611 :rule => 'readonly')
611 :rule => 'readonly')
612 user = User.find(2)
612 user = User.find(2)
613
613
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
615
615
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
617 'due_date' => '2012-07-14'},
617 'due_date' => '2012-07-14'},
618 user
618 user
619 assert_equal Date.parse('2012-07-12'), issue.start_date
619 assert_equal Date.parse('2012-07-12'), issue.start_date
620 assert_nil issue.due_date
620 assert_nil issue.due_date
621
621
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
623 'due_date' => '2012-07-16',
623 'due_date' => '2012-07-16',
624 'status_id' => 2},
624 'status_id' => 2},
625 user
625 user
626 assert_equal Date.parse('2012-07-12'), issue.start_date
626 assert_equal Date.parse('2012-07-12'), issue.start_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
628 end
628 end
629
629
630 def test_required_attributes_should_be_validated
630 def test_required_attributes_should_be_validated
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
632 :is_for_all => true, :tracker_ids => [1, 2])
632 :is_for_all => true, :tracker_ids => [1, 2])
633
633
634 WorkflowPermission.delete_all
634 WorkflowPermission.delete_all
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
636 :role_id => 1, :field_name => 'due_date',
636 :role_id => 1, :field_name => 'due_date',
637 :rule => 'required')
637 :rule => 'required')
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
639 :role_id => 1, :field_name => 'category_id',
639 :role_id => 1, :field_name => 'category_id',
640 :rule => 'required')
640 :rule => 'required')
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
642 :role_id => 1, :field_name => cf.id.to_s,
642 :role_id => 1, :field_name => cf.id.to_s,
643 :rule => 'required')
643 :rule => 'required')
644
644
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
646 :role_id => 1, :field_name => 'start_date',
646 :role_id => 1, :field_name => 'start_date',
647 :rule => 'required')
647 :rule => 'required')
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
649 :role_id => 1, :field_name => cf.id.to_s,
649 :role_id => 1, :field_name => cf.id.to_s,
650 :rule => 'required')
650 :rule => 'required')
651 user = User.find(2)
651 user = User.find(2)
652
652
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
654 :status_id => 1, :subject => 'Required fields',
654 :status_id => 1, :subject => 'Required fields',
655 :author => user)
655 :author => user)
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
657 issue.required_attribute_names(user).sort
657 issue.required_attribute_names(user).sort
658 assert !issue.save, "Issue was saved"
658 assert !issue.save, "Issue was saved"
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
660 issue.errors.full_messages.sort
660 issue.errors.full_messages.sort
661
661
662 issue.tracker_id = 2
662 issue.tracker_id = 2
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
664 assert !issue.save, "Issue was saved"
664 assert !issue.save, "Issue was saved"
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
666 issue.errors.full_messages.sort
666 issue.errors.full_messages.sort
667
667
668 issue.start_date = Date.today
668 issue.start_date = Date.today
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
670 assert issue.save
670 assert issue.save
671 end
671 end
672
672
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
674 WorkflowPermission.delete_all
674 WorkflowPermission.delete_all
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
676 :role_id => 1, :field_name => 'due_date',
676 :role_id => 1, :field_name => 'due_date',
677 :rule => 'required')
677 :rule => 'required')
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
679 :role_id => 1, :field_name => 'start_date',
679 :role_id => 1, :field_name => 'start_date',
680 :rule => 'required')
680 :rule => 'required')
681 user = User.find(2)
681 user = User.find(2)
682 member = Member.find(1)
682 member = Member.find(1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
684
684
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
686
686
687 member.role_ids = [1, 2]
687 member.role_ids = [1, 2]
688 member.save!
688 member.save!
689 assert_equal [], issue.required_attribute_names(user.reload)
689 assert_equal [], issue.required_attribute_names(user.reload)
690
690
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
692 :role_id => 2, :field_name => 'due_date',
692 :role_id => 2, :field_name => 'due_date',
693 :rule => 'required')
693 :rule => 'required')
694 assert_equal %w(due_date), issue.required_attribute_names(user)
694 assert_equal %w(due_date), issue.required_attribute_names(user)
695
695
696 member.role_ids = [1, 2, 3]
696 member.role_ids = [1, 2, 3]
697 member.save!
697 member.save!
698 assert_equal [], issue.required_attribute_names(user.reload)
698 assert_equal [], issue.required_attribute_names(user.reload)
699
699
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
701 :role_id => 2, :field_name => 'due_date',
701 :role_id => 2, :field_name => 'due_date',
702 :rule => 'readonly')
702 :rule => 'readonly')
703 # required + readonly => required
703 # required + readonly => required
704 assert_equal %w(due_date), issue.required_attribute_names(user)
704 assert_equal %w(due_date), issue.required_attribute_names(user)
705 end
705 end
706
706
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
708 WorkflowPermission.delete_all
708 WorkflowPermission.delete_all
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
710 :role_id => 1, :field_name => 'due_date',
710 :role_id => 1, :field_name => 'due_date',
711 :rule => 'readonly')
711 :rule => 'readonly')
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
713 :role_id => 1, :field_name => 'start_date',
713 :role_id => 1, :field_name => 'start_date',
714 :rule => 'readonly')
714 :rule => 'readonly')
715 user = User.find(2)
715 user = User.find(2)
716 member = Member.find(1)
716 member = Member.find(1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
718
718
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
720
720
721 member.role_ids = [1, 2]
721 member.role_ids = [1, 2]
722 member.save!
722 member.save!
723 assert_equal [], issue.read_only_attribute_names(user.reload)
723 assert_equal [], issue.read_only_attribute_names(user.reload)
724
724
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
726 :role_id => 2, :field_name => 'due_date',
726 :role_id => 2, :field_name => 'due_date',
727 :rule => 'readonly')
727 :rule => 'readonly')
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
729 end
729 end
730
730
731 def test_copy
731 def test_copy
732 issue = Issue.new.copy_from(1)
732 issue = Issue.new.copy_from(1)
733 assert issue.copy?
733 assert issue.copy?
734 assert issue.save
734 assert issue.save
735 issue.reload
735 issue.reload
736 orig = Issue.find(1)
736 orig = Issue.find(1)
737 assert_equal orig.subject, issue.subject
737 assert_equal orig.subject, issue.subject
738 assert_equal orig.tracker, issue.tracker
738 assert_equal orig.tracker, issue.tracker
739 assert_equal "125", issue.custom_value_for(2).value
739 assert_equal "125", issue.custom_value_for(2).value
740 end
740 end
741
741
742 def test_copy_should_copy_status
742 def test_copy_should_copy_status
743 orig = Issue.find(8)
743 orig = Issue.find(8)
744 assert orig.status != IssueStatus.default
744 assert orig.status != IssueStatus.default
745
745
746 issue = Issue.new.copy_from(orig)
746 issue = Issue.new.copy_from(orig)
747 assert issue.save
747 assert issue.save
748 issue.reload
748 issue.reload
749 assert_equal orig.status, issue.status
749 assert_equal orig.status, issue.status
750 end
750 end
751
751
752 def test_copy_should_add_relation_with_copied_issue
752 def test_copy_should_add_relation_with_copied_issue
753 copied = Issue.find(1)
753 copied = Issue.find(1)
754 issue = Issue.new.copy_from(copied)
754 issue = Issue.new.copy_from(copied)
755 assert issue.save
755 assert issue.save
756 issue.reload
756 issue.reload
757
757
758 assert_equal 1, issue.relations.size
758 assert_equal 1, issue.relations.size
759 relation = issue.relations.first
759 relation = issue.relations.first
760 assert_equal 'copied_to', relation.relation_type
760 assert_equal 'copied_to', relation.relation_type
761 assert_equal copied, relation.issue_from
761 assert_equal copied, relation.issue_from
762 assert_equal issue, relation.issue_to
762 assert_equal issue, relation.issue_to
763 end
763 end
764
764
765 def test_copy_should_copy_subtasks
765 def test_copy_should_copy_subtasks
766 issue = Issue.generate_with_descendants!
766 issue = Issue.generate_with_descendants!
767
767
768 copy = issue.reload.copy
768 copy = issue.reload.copy
769 copy.author = User.find(7)
769 copy.author = User.find(7)
770 assert_difference 'Issue.count', 1+issue.descendants.count do
770 assert_difference 'Issue.count', 1+issue.descendants.count do
771 assert copy.save
771 assert copy.save
772 end
772 end
773 copy.reload
773 copy.reload
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
777 assert_equal copy.author, child_copy.author
777 assert_equal copy.author, child_copy.author
778 end
778 end
779
779
780 def test_copy_should_copy_subtasks_to_target_project
780 def test_copy_should_copy_subtasks_to_target_project
781 issue = Issue.generate_with_descendants!
781 issue = Issue.generate_with_descendants!
782
782
783 copy = issue.copy(:project_id => 3)
783 copy = issue.copy(:project_id => 3)
784 assert_difference 'Issue.count', 1+issue.descendants.count do
784 assert_difference 'Issue.count', 1+issue.descendants.count do
785 assert copy.save
785 assert copy.save
786 end
786 end
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
788 end
788 end
789
789
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
791 issue = Issue.generate_with_descendants!
791 issue = Issue.generate_with_descendants!
792
792
793 copy = issue.reload.copy
793 copy = issue.reload.copy
794 assert_difference 'Issue.count', 1+issue.descendants.count do
794 assert_difference 'Issue.count', 1+issue.descendants.count do
795 assert copy.save
795 assert copy.save
796 assert copy.save
796 assert copy.save
797 end
797 end
798 end
798 end
799
799
800 def test_should_not_call_after_project_change_on_creation
800 def test_should_not_call_after_project_change_on_creation
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Test', :author_id => 1)
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
802 :subject => 'Test', :author_id => 1)
802 issue.expects(:after_project_change).never
803 issue.expects(:after_project_change).never
803 issue.save!
804 issue.save!
804 end
805 end
805
806
806 def test_should_not_call_after_project_change_on_update
807 def test_should_not_call_after_project_change_on_update
807 issue = Issue.find(1)
808 issue = Issue.find(1)
808 issue.project = Project.find(1)
809 issue.project = Project.find(1)
809 issue.subject = 'No project change'
810 issue.subject = 'No project change'
810 issue.expects(:after_project_change).never
811 issue.expects(:after_project_change).never
811 issue.save!
812 issue.save!
812 end
813 end
813
814
814 def test_should_call_after_project_change_on_project_change
815 def test_should_call_after_project_change_on_project_change
815 issue = Issue.find(1)
816 issue = Issue.find(1)
816 issue.project = Project.find(2)
817 issue.project = Project.find(2)
817 issue.expects(:after_project_change).once
818 issue.expects(:after_project_change).once
818 issue.save!
819 issue.save!
819 end
820 end
820
821
821 def test_adding_journal_should_update_timestamp
822 def test_adding_journal_should_update_timestamp
822 issue = Issue.find(1)
823 issue = Issue.find(1)
823 updated_on_was = issue.updated_on
824 updated_on_was = issue.updated_on
824
825
825 issue.init_journal(User.first, "Adding notes")
826 issue.init_journal(User.first, "Adding notes")
826 assert_difference 'Journal.count' do
827 assert_difference 'Journal.count' do
827 assert issue.save
828 assert issue.save
828 end
829 end
829 issue.reload
830 issue.reload
830
831
831 assert_not_equal updated_on_was, issue.updated_on
832 assert_not_equal updated_on_was, issue.updated_on
832 end
833 end
833
834
834 def test_should_close_duplicates
835 def test_should_close_duplicates
835 # Create 3 issues
836 # Create 3 issues
836 issue1 = Issue.generate!
837 issue1 = Issue.generate!
837 issue2 = Issue.generate!
838 issue2 = Issue.generate!
838 issue3 = Issue.generate!
839 issue3 = Issue.generate!
839
840
840 # 2 is a dupe of 1
841 # 2 is a dupe of 1
841 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
842 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
842 # And 3 is a dupe of 2
843 # And 3 is a dupe of 2
843 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
844 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
844 # And 3 is a dupe of 1 (circular duplicates)
845 # And 3 is a dupe of 1 (circular duplicates)
845 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
846 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
846
847
847 assert issue1.reload.duplicates.include?(issue2)
848 assert issue1.reload.duplicates.include?(issue2)
848
849
849 # Closing issue 1
850 # Closing issue 1
850 issue1.init_journal(User.find(:first), "Closing issue1")
851 issue1.init_journal(User.find(:first), "Closing issue1")
851 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
852 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
852 assert issue1.save
853 assert issue1.save
853 # 2 and 3 should be also closed
854 # 2 and 3 should be also closed
854 assert issue2.reload.closed?
855 assert issue2.reload.closed?
855 assert issue3.reload.closed?
856 assert issue3.reload.closed?
856 end
857 end
857
858
858 def test_should_not_close_duplicated_issue
859 def test_should_not_close_duplicated_issue
859 issue1 = Issue.generate!
860 issue1 = Issue.generate!
860 issue2 = Issue.generate!
861 issue2 = Issue.generate!
861
862
862 # 2 is a dupe of 1
863 # 2 is a dupe of 1
863 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
864 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
864 # 2 is a dup of 1 but 1 is not a duplicate of 2
865 # 2 is a dup of 1 but 1 is not a duplicate of 2
865 assert !issue2.reload.duplicates.include?(issue1)
866 assert !issue2.reload.duplicates.include?(issue1)
866
867
867 # Closing issue 2
868 # Closing issue 2
868 issue2.init_journal(User.find(:first), "Closing issue2")
869 issue2.init_journal(User.find(:first), "Closing issue2")
869 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
870 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
870 assert issue2.save
871 assert issue2.save
871 # 1 should not be also closed
872 # 1 should not be also closed
872 assert !issue1.reload.closed?
873 assert !issue1.reload.closed?
873 end
874 end
874
875
875 def test_assignable_versions
876 def test_assignable_versions
876 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
877 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
877 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
878 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
878 end
879 end
879
880
880 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
881 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
881 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
882 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
882 assert !issue.save
883 assert !issue.save
883 assert_not_nil issue.errors[:fixed_version_id]
884 assert_not_nil issue.errors[:fixed_version_id]
884 end
885 end
885
886
886 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
887 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
887 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
888 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
888 assert !issue.save
889 assert !issue.save
889 assert_not_nil issue.errors[:fixed_version_id]
890 assert_not_nil issue.errors[:fixed_version_id]
890 end
891 end
891
892
892 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
893 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
893 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
894 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
894 :status_id => 1, :fixed_version_id => 3,
895 :status_id => 1, :fixed_version_id => 3,
895 :subject => 'New issue')
896 :subject => 'New issue')
896 assert issue.save
897 assert issue.save
897 end
898 end
898
899
899 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
900 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
900 issue = Issue.find(11)
901 issue = Issue.find(11)
901 assert_equal 'closed', issue.fixed_version.status
902 assert_equal 'closed', issue.fixed_version.status
902 issue.subject = 'Subject changed'
903 issue.subject = 'Subject changed'
903 assert issue.save
904 assert issue.save
904 end
905 end
905
906
906 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
907 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
907 issue = Issue.find(11)
908 issue = Issue.find(11)
908 issue.status_id = 1
909 issue.status_id = 1
909 assert !issue.save
910 assert !issue.save
910 assert_not_nil issue.errors[:base]
911 assert_not_nil issue.errors[:base]
911 end
912 end
912
913
913 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
914 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
914 issue = Issue.find(11)
915 issue = Issue.find(11)
915 issue.status_id = 1
916 issue.status_id = 1
916 issue.fixed_version_id = 3
917 issue.fixed_version_id = 3
917 assert issue.save
918 assert issue.save
918 end
919 end
919
920
920 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
921 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
921 issue = Issue.find(12)
922 issue = Issue.find(12)
922 assert_equal 'locked', issue.fixed_version.status
923 assert_equal 'locked', issue.fixed_version.status
923 issue.status_id = 1
924 issue.status_id = 1
924 assert issue.save
925 assert issue.save
925 end
926 end
926
927
927 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
928 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
928 issue = Issue.find(2)
929 issue = Issue.find(2)
929 assert_equal 2, issue.fixed_version_id
930 assert_equal 2, issue.fixed_version_id
930 issue.project_id = 3
931 issue.project_id = 3
931 assert_nil issue.fixed_version_id
932 assert_nil issue.fixed_version_id
932 issue.fixed_version_id = 2
933 issue.fixed_version_id = 2
933 assert !issue.save
934 assert !issue.save
934 assert_include 'Target version is not included in the list', issue.errors.full_messages
935 assert_include 'Target version is not included in the list', issue.errors.full_messages
935 end
936 end
936
937
937 def test_should_keep_shared_version_when_changing_project
938 def test_should_keep_shared_version_when_changing_project
938 Version.find(2).update_attribute :sharing, 'tree'
939 Version.find(2).update_attribute :sharing, 'tree'
939
940
940 issue = Issue.find(2)
941 issue = Issue.find(2)
941 assert_equal 2, issue.fixed_version_id
942 assert_equal 2, issue.fixed_version_id
942 issue.project_id = 3
943 issue.project_id = 3
943 assert_equal 2, issue.fixed_version_id
944 assert_equal 2, issue.fixed_version_id
944 assert issue.save
945 assert issue.save
945 end
946 end
946
947
947 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
948 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
948 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
949 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
949 end
950 end
950
951
951 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
952 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
952 Project.find(2).disable_module! :issue_tracking
953 Project.find(2).disable_module! :issue_tracking
953 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
954 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
954 end
955 end
955
956
956 def test_move_to_another_project_with_same_category
957 def test_move_to_another_project_with_same_category
957 issue = Issue.find(1)
958 issue = Issue.find(1)
958 issue.project = Project.find(2)
959 issue.project = Project.find(2)
959 assert issue.save
960 assert issue.save
960 issue.reload
961 issue.reload
961 assert_equal 2, issue.project_id
962 assert_equal 2, issue.project_id
962 # Category changes
963 # Category changes
963 assert_equal 4, issue.category_id
964 assert_equal 4, issue.category_id
964 # Make sure time entries were move to the target project
965 # Make sure time entries were move to the target project
965 assert_equal 2, issue.time_entries.first.project_id
966 assert_equal 2, issue.time_entries.first.project_id
966 end
967 end
967
968
968 def test_move_to_another_project_without_same_category
969 def test_move_to_another_project_without_same_category
969 issue = Issue.find(2)
970 issue = Issue.find(2)
970 issue.project = Project.find(2)
971 issue.project = Project.find(2)
971 assert issue.save
972 assert issue.save
972 issue.reload
973 issue.reload
973 assert_equal 2, issue.project_id
974 assert_equal 2, issue.project_id
974 # Category cleared
975 # Category cleared
975 assert_nil issue.category_id
976 assert_nil issue.category_id
976 end
977 end
977
978
978 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
979 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
979 issue = Issue.find(1)
980 issue = Issue.find(1)
980 issue.update_attribute(:fixed_version_id, 1)
981 issue.update_attribute(:fixed_version_id, 1)
981 issue.project = Project.find(2)
982 issue.project = Project.find(2)
982 assert issue.save
983 assert issue.save
983 issue.reload
984 issue.reload
984 assert_equal 2, issue.project_id
985 assert_equal 2, issue.project_id
985 # Cleared fixed_version
986 # Cleared fixed_version
986 assert_equal nil, issue.fixed_version
987 assert_equal nil, issue.fixed_version
987 end
988 end
988
989
989 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
990 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
990 issue = Issue.find(1)
991 issue = Issue.find(1)
991 issue.update_attribute(:fixed_version_id, 4)
992 issue.update_attribute(:fixed_version_id, 4)
992 issue.project = Project.find(5)
993 issue.project = Project.find(5)
993 assert issue.save
994 assert issue.save
994 issue.reload
995 issue.reload
995 assert_equal 5, issue.project_id
996 assert_equal 5, issue.project_id
996 # Keep fixed_version
997 # Keep fixed_version
997 assert_equal 4, issue.fixed_version_id
998 assert_equal 4, issue.fixed_version_id
998 end
999 end
999
1000
1000 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1001 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1001 issue = Issue.find(1)
1002 issue = Issue.find(1)
1002 issue.update_attribute(:fixed_version_id, 1)
1003 issue.update_attribute(:fixed_version_id, 1)
1003 issue.project = Project.find(5)
1004 issue.project = Project.find(5)
1004 assert issue.save
1005 assert issue.save
1005 issue.reload
1006 issue.reload
1006 assert_equal 5, issue.project_id
1007 assert_equal 5, issue.project_id
1007 # Cleared fixed_version
1008 # Cleared fixed_version
1008 assert_equal nil, issue.fixed_version
1009 assert_equal nil, issue.fixed_version
1009 end
1010 end
1010
1011
1011 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1012 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1012 issue = Issue.find(1)
1013 issue = Issue.find(1)
1013 issue.update_attribute(:fixed_version_id, 7)
1014 issue.update_attribute(:fixed_version_id, 7)
1014 issue.project = Project.find(2)
1015 issue.project = Project.find(2)
1015 assert issue.save
1016 assert issue.save
1016 issue.reload
1017 issue.reload
1017 assert_equal 2, issue.project_id
1018 assert_equal 2, issue.project_id
1018 # Keep fixed_version
1019 # Keep fixed_version
1019 assert_equal 7, issue.fixed_version_id
1020 assert_equal 7, issue.fixed_version_id
1020 end
1021 end
1021
1022
1022 def test_move_to_another_project_should_keep_parent_if_valid
1023 def test_move_to_another_project_should_keep_parent_if_valid
1023 issue = Issue.find(1)
1024 issue = Issue.find(1)
1024 issue.update_attribute(:parent_issue_id, 2)
1025 issue.update_attribute(:parent_issue_id, 2)
1025 issue.project = Project.find(3)
1026 issue.project = Project.find(3)
1026 assert issue.save
1027 assert issue.save
1027 issue.reload
1028 issue.reload
1028 assert_equal 2, issue.parent_id
1029 assert_equal 2, issue.parent_id
1029 end
1030 end
1030
1031
1031 def test_move_to_another_project_should_clear_parent_if_not_valid
1032 def test_move_to_another_project_should_clear_parent_if_not_valid
1032 issue = Issue.find(1)
1033 issue = Issue.find(1)
1033 issue.update_attribute(:parent_issue_id, 2)
1034 issue.update_attribute(:parent_issue_id, 2)
1034 issue.project = Project.find(2)
1035 issue.project = Project.find(2)
1035 assert issue.save
1036 assert issue.save
1036 issue.reload
1037 issue.reload
1037 assert_nil issue.parent_id
1038 assert_nil issue.parent_id
1038 end
1039 end
1039
1040
1040 def test_move_to_another_project_with_disabled_tracker
1041 def test_move_to_another_project_with_disabled_tracker
1041 issue = Issue.find(1)
1042 issue = Issue.find(1)
1042 target = Project.find(2)
1043 target = Project.find(2)
1043 target.tracker_ids = [3]
1044 target.tracker_ids = [3]
1044 target.save
1045 target.save
1045 issue.project = target
1046 issue.project = target
1046 assert issue.save
1047 assert issue.save
1047 issue.reload
1048 issue.reload
1048 assert_equal 2, issue.project_id
1049 assert_equal 2, issue.project_id
1049 assert_equal 3, issue.tracker_id
1050 assert_equal 3, issue.tracker_id
1050 end
1051 end
1051
1052
1052 def test_copy_to_the_same_project
1053 def test_copy_to_the_same_project
1053 issue = Issue.find(1)
1054 issue = Issue.find(1)
1054 copy = issue.copy
1055 copy = issue.copy
1055 assert_difference 'Issue.count' do
1056 assert_difference 'Issue.count' do
1056 copy.save!
1057 copy.save!
1057 end
1058 end
1058 assert_kind_of Issue, copy
1059 assert_kind_of Issue, copy
1059 assert_equal issue.project, copy.project
1060 assert_equal issue.project, copy.project
1060 assert_equal "125", copy.custom_value_for(2).value
1061 assert_equal "125", copy.custom_value_for(2).value
1061 end
1062 end
1062
1063
1063 def test_copy_to_another_project_and_tracker
1064 def test_copy_to_another_project_and_tracker
1064 issue = Issue.find(1)
1065 issue = Issue.find(1)
1065 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1066 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1066 assert_difference 'Issue.count' do
1067 assert_difference 'Issue.count' do
1067 copy.save!
1068 copy.save!
1068 end
1069 end
1069 copy.reload
1070 copy.reload
1070 assert_kind_of Issue, copy
1071 assert_kind_of Issue, copy
1071 assert_equal Project.find(3), copy.project
1072 assert_equal Project.find(3), copy.project
1072 assert_equal Tracker.find(2), copy.tracker
1073 assert_equal Tracker.find(2), copy.tracker
1073 # Custom field #2 is not associated with target tracker
1074 # Custom field #2 is not associated with target tracker
1074 assert_nil copy.custom_value_for(2)
1075 assert_nil copy.custom_value_for(2)
1075 end
1076 end
1076
1077
1077 context "#copy" do
1078 context "#copy" do
1078 setup do
1079 setup do
1079 @issue = Issue.find(1)
1080 @issue = Issue.find(1)
1080 end
1081 end
1081
1082
1082 should "not create a journal" do
1083 should "not create a journal" do
1083 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1084 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1084 copy.save!
1085 copy.save!
1085 assert_equal 0, copy.reload.journals.size
1086 assert_equal 0, copy.reload.journals.size
1086 end
1087 end
1087
1088
1088 should "allow assigned_to changes" do
1089 should "allow assigned_to changes" do
1089 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1090 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1090 assert_equal 3, copy.assigned_to_id
1091 assert_equal 3, copy.assigned_to_id
1091 end
1092 end
1092
1093
1093 should "allow status changes" do
1094 should "allow status changes" do
1094 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1095 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1095 assert_equal 2, copy.status_id
1096 assert_equal 2, copy.status_id
1096 end
1097 end
1097
1098
1098 should "allow start date changes" do
1099 should "allow start date changes" do
1099 date = Date.today
1100 date = Date.today
1100 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1101 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1101 assert_equal date, copy.start_date
1102 assert_equal date, copy.start_date
1102 end
1103 end
1103
1104
1104 should "allow due date changes" do
1105 should "allow due date changes" do
1105 date = Date.today
1106 date = Date.today
1106 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1107 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1107 assert_equal date, copy.due_date
1108 assert_equal date, copy.due_date
1108 end
1109 end
1109
1110
1110 should "set current user as author" do
1111 should "set current user as author" do
1111 User.current = User.find(9)
1112 User.current = User.find(9)
1112 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1113 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1113 assert_equal User.current, copy.author
1114 assert_equal User.current, copy.author
1114 end
1115 end
1115
1116
1116 should "create a journal with notes" do
1117 should "create a journal with notes" do
1117 date = Date.today
1118 date = Date.today
1118 notes = "Notes added when copying"
1119 notes = "Notes added when copying"
1119 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1120 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1120 copy.init_journal(User.current, notes)
1121 copy.init_journal(User.current, notes)
1121 copy.save!
1122 copy.save!
1122
1123
1123 assert_equal 1, copy.journals.size
1124 assert_equal 1, copy.journals.size
1124 journal = copy.journals.first
1125 journal = copy.journals.first
1125 assert_equal 0, journal.details.size
1126 assert_equal 0, journal.details.size
1126 assert_equal notes, journal.notes
1127 assert_equal notes, journal.notes
1127 end
1128 end
1128 end
1129 end
1129
1130
1130 def test_valid_parent_project
1131 def test_valid_parent_project
1131 issue = Issue.find(1)
1132 issue = Issue.find(1)
1132 issue_in_same_project = Issue.find(2)
1133 issue_in_same_project = Issue.find(2)
1133 issue_in_child_project = Issue.find(5)
1134 issue_in_child_project = Issue.find(5)
1134 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1135 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1135 issue_in_other_child_project = Issue.find(6)
1136 issue_in_other_child_project = Issue.find(6)
1136 issue_in_different_tree = Issue.find(4)
1137 issue_in_different_tree = Issue.find(4)
1137
1138
1138 with_settings :cross_project_subtasks => '' do
1139 with_settings :cross_project_subtasks => '' do
1139 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1140 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1140 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1141 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1141 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1142 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1142 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1143 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1143 end
1144 end
1144
1145
1145 with_settings :cross_project_subtasks => 'system' do
1146 with_settings :cross_project_subtasks => 'system' do
1146 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1147 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1147 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1148 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1148 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1149 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1149 end
1150 end
1150
1151
1151 with_settings :cross_project_subtasks => 'tree' do
1152 with_settings :cross_project_subtasks => 'tree' do
1152 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1153 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1153 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1154 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1154 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1155 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1155 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1156 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1156
1157
1157 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1158 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1158 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1159 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1159 end
1160 end
1160
1161
1161 with_settings :cross_project_subtasks => 'descendants' do
1162 with_settings :cross_project_subtasks => 'descendants' do
1162 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1163 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1163 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1164 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1164 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1165 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1165 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1166 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1166
1167
1167 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1168 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1168 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1169 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1169 end
1170 end
1170 end
1171 end
1171
1172
1172 def test_recipients_should_include_previous_assignee
1173 def test_recipients_should_include_previous_assignee
1173 user = User.find(3)
1174 user = User.find(3)
1174 user.members.update_all ["mail_notification = ?", false]
1175 user.members.update_all ["mail_notification = ?", false]
1175 user.update_attribute :mail_notification, 'only_assigned'
1176 user.update_attribute :mail_notification, 'only_assigned'
1176
1177
1177 issue = Issue.find(2)
1178 issue = Issue.find(2)
1178 issue.assigned_to = nil
1179 issue.assigned_to = nil
1179 assert_include user.mail, issue.recipients
1180 assert_include user.mail, issue.recipients
1180 issue.save!
1181 issue.save!
1181 assert !issue.recipients.include?(user.mail)
1182 assert !issue.recipients.include?(user.mail)
1182 end
1183 end
1183
1184
1184 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1185 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1185 issue = Issue.find(12)
1186 issue = Issue.find(12)
1186 assert issue.recipients.include?(issue.author.mail)
1187 assert issue.recipients.include?(issue.author.mail)
1187 # copy the issue to a private project
1188 # copy the issue to a private project
1188 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1189 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1189 # author is not a member of project anymore
1190 # author is not a member of project anymore
1190 assert !copy.recipients.include?(copy.author.mail)
1191 assert !copy.recipients.include?(copy.author.mail)
1191 end
1192 end
1192
1193
1193 def test_recipients_should_include_the_assigned_group_members
1194 def test_recipients_should_include_the_assigned_group_members
1194 group_member = User.generate!
1195 group_member = User.generate!
1195 group = Group.generate!
1196 group = Group.generate!
1196 group.users << group_member
1197 group.users << group_member
1197
1198
1198 issue = Issue.find(12)
1199 issue = Issue.find(12)
1199 issue.assigned_to = group
1200 issue.assigned_to = group
1200 assert issue.recipients.include?(group_member.mail)
1201 assert issue.recipients.include?(group_member.mail)
1201 end
1202 end
1202
1203
1203 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1204 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1204 user = User.find(3)
1205 user = User.find(3)
1205 issue = Issue.find(9)
1206 issue = Issue.find(9)
1206 Watcher.create!(:user => user, :watchable => issue)
1207 Watcher.create!(:user => user, :watchable => issue)
1207 assert issue.watched_by?(user)
1208 assert issue.watched_by?(user)
1208 assert !issue.watcher_recipients.include?(user.mail)
1209 assert !issue.watcher_recipients.include?(user.mail)
1209 end
1210 end
1210
1211
1211 def test_issue_destroy
1212 def test_issue_destroy
1212 Issue.find(1).destroy
1213 Issue.find(1).destroy
1213 assert_nil Issue.find_by_id(1)
1214 assert_nil Issue.find_by_id(1)
1214 assert_nil TimeEntry.find_by_issue_id(1)
1215 assert_nil TimeEntry.find_by_issue_id(1)
1215 end
1216 end
1216
1217
1217 def test_destroying_a_deleted_issue_should_not_raise_an_error
1218 def test_destroying_a_deleted_issue_should_not_raise_an_error
1218 issue = Issue.find(1)
1219 issue = Issue.find(1)
1219 Issue.find(1).destroy
1220 Issue.find(1).destroy
1220
1221
1221 assert_nothing_raised do
1222 assert_nothing_raised do
1222 assert_no_difference 'Issue.count' do
1223 assert_no_difference 'Issue.count' do
1223 issue.destroy
1224 issue.destroy
1224 end
1225 end
1225 assert issue.destroyed?
1226 assert issue.destroyed?
1226 end
1227 end
1227 end
1228 end
1228
1229
1229 def test_destroying_a_stale_issue_should_not_raise_an_error
1230 def test_destroying_a_stale_issue_should_not_raise_an_error
1230 issue = Issue.find(1)
1231 issue = Issue.find(1)
1231 Issue.find(1).update_attribute :subject, "Updated"
1232 Issue.find(1).update_attribute :subject, "Updated"
1232
1233
1233 assert_nothing_raised do
1234 assert_nothing_raised do
1234 assert_difference 'Issue.count', -1 do
1235 assert_difference 'Issue.count', -1 do
1235 issue.destroy
1236 issue.destroy
1236 end
1237 end
1237 assert issue.destroyed?
1238 assert issue.destroyed?
1238 end
1239 end
1239 end
1240 end
1240
1241
1241 def test_blocked
1242 def test_blocked
1242 blocked_issue = Issue.find(9)
1243 blocked_issue = Issue.find(9)
1243 blocking_issue = Issue.find(10)
1244 blocking_issue = Issue.find(10)
1244
1245
1245 assert blocked_issue.blocked?
1246 assert blocked_issue.blocked?
1246 assert !blocking_issue.blocked?
1247 assert !blocking_issue.blocked?
1247 end
1248 end
1248
1249
1249 def test_blocked_issues_dont_allow_closed_statuses
1250 def test_blocked_issues_dont_allow_closed_statuses
1250 blocked_issue = Issue.find(9)
1251 blocked_issue = Issue.find(9)
1251
1252
1252 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1253 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1253 assert !allowed_statuses.empty?
1254 assert !allowed_statuses.empty?
1254 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1255 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1255 assert closed_statuses.empty?
1256 assert closed_statuses.empty?
1256 end
1257 end
1257
1258
1258 def test_unblocked_issues_allow_closed_statuses
1259 def test_unblocked_issues_allow_closed_statuses
1259 blocking_issue = Issue.find(10)
1260 blocking_issue = Issue.find(10)
1260
1261
1261 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1262 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1262 assert !allowed_statuses.empty?
1263 assert !allowed_statuses.empty?
1263 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1264 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1264 assert !closed_statuses.empty?
1265 assert !closed_statuses.empty?
1265 end
1266 end
1266
1267
1267 def test_rescheduling_an_issue_should_reschedule_following_issue
1268 def test_rescheduling_an_issue_should_reschedule_following_issue
1268 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1269 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1269 :author_id => 1, :status_id => 1,
1270 :author_id => 1, :status_id => 1,
1270 :subject => '-',
1271 :subject => '-',
1271 :start_date => Date.today, :due_date => Date.today + 2)
1272 :start_date => Date.today, :due_date => Date.today + 2)
1272 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1273 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1273 :author_id => 1, :status_id => 1,
1274 :author_id => 1, :status_id => 1,
1274 :subject => '-',
1275 :subject => '-',
1275 :start_date => Date.today, :due_date => Date.today + 2)
1276 :start_date => Date.today, :due_date => Date.today + 2)
1276 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1277 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1277 :relation_type => IssueRelation::TYPE_PRECEDES)
1278 :relation_type => IssueRelation::TYPE_PRECEDES)
1278 assert_equal issue1.due_date + 1, issue2.reload.start_date
1279 assert_equal issue1.due_date + 1, issue2.reload.start_date
1279
1280
1280 issue1.due_date = Date.today + 5
1281 issue1.due_date = Date.today + 5
1281 issue1.save!
1282 issue1.save!
1282 assert_equal issue1.due_date + 1, issue2.reload.start_date
1283 assert_equal issue1.due_date + 1, issue2.reload.start_date
1283 end
1284 end
1284
1285
1285 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1286 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1286 stale = Issue.find(1)
1287 stale = Issue.find(1)
1287 issue = Issue.find(1)
1288 issue = Issue.find(1)
1288 issue.subject = "Updated"
1289 issue.subject = "Updated"
1289 issue.save!
1290 issue.save!
1290
1291
1291 date = 10.days.from_now.to_date
1292 date = 10.days.from_now.to_date
1292 assert_nothing_raised do
1293 assert_nothing_raised do
1293 stale.reschedule_after(date)
1294 stale.reschedule_after(date)
1294 end
1295 end
1295 assert_equal date, stale.reload.start_date
1296 assert_equal date, stale.reload.start_date
1296 end
1297 end
1297
1298
1298 def test_overdue
1299 def test_overdue
1299 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1300 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1300 assert !Issue.new(:due_date => Date.today).overdue?
1301 assert !Issue.new(:due_date => Date.today).overdue?
1301 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1302 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1302 assert !Issue.new(:due_date => nil).overdue?
1303 assert !Issue.new(:due_date => nil).overdue?
1303 assert !Issue.new(:due_date => 1.day.ago.to_date,
1304 assert !Issue.new(:due_date => 1.day.ago.to_date,
1304 :status => IssueStatus.find(:first,
1305 :status => IssueStatus.find(:first,
1305 :conditions => {:is_closed => true})
1306 :conditions => {:is_closed => true})
1306 ).overdue?
1307 ).overdue?
1307 end
1308 end
1308
1309
1309 context "#behind_schedule?" do
1310 context "#behind_schedule?" do
1310 should "be false if the issue has no start_date" do
1311 should "be false if the issue has no start_date" do
1311 assert !Issue.new(:start_date => nil,
1312 assert !Issue.new(:start_date => nil,
1312 :due_date => 1.day.from_now.to_date,
1313 :due_date => 1.day.from_now.to_date,
1313 :done_ratio => 0).behind_schedule?
1314 :done_ratio => 0).behind_schedule?
1314 end
1315 end
1315
1316
1316 should "be false if the issue has no end_date" do
1317 should "be false if the issue has no end_date" do
1317 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1318 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1318 :due_date => nil,
1319 :due_date => nil,
1319 :done_ratio => 0).behind_schedule?
1320 :done_ratio => 0).behind_schedule?
1320 end
1321 end
1321
1322
1322 should "be false if the issue has more done than it's calendar time" do
1323 should "be false if the issue has more done than it's calendar time" do
1323 assert !Issue.new(:start_date => 50.days.ago.to_date,
1324 assert !Issue.new(:start_date => 50.days.ago.to_date,
1324 :due_date => 50.days.from_now.to_date,
1325 :due_date => 50.days.from_now.to_date,
1325 :done_ratio => 90).behind_schedule?
1326 :done_ratio => 90).behind_schedule?
1326 end
1327 end
1327
1328
1328 should "be true if the issue hasn't been started at all" do
1329 should "be true if the issue hasn't been started at all" do
1329 assert Issue.new(:start_date => 1.day.ago.to_date,
1330 assert Issue.new(:start_date => 1.day.ago.to_date,
1330 :due_date => 1.day.from_now.to_date,
1331 :due_date => 1.day.from_now.to_date,
1331 :done_ratio => 0).behind_schedule?
1332 :done_ratio => 0).behind_schedule?
1332 end
1333 end
1333
1334
1334 should "be true if the issue has used more calendar time than it's done ratio" do
1335 should "be true if the issue has used more calendar time than it's done ratio" do
1335 assert Issue.new(:start_date => 100.days.ago.to_date,
1336 assert Issue.new(:start_date => 100.days.ago.to_date,
1336 :due_date => Date.today,
1337 :due_date => Date.today,
1337 :done_ratio => 90).behind_schedule?
1338 :done_ratio => 90).behind_schedule?
1338 end
1339 end
1339 end
1340 end
1340
1341
1341 context "#assignable_users" do
1342 context "#assignable_users" do
1342 should "be Users" do
1343 should "be Users" do
1343 assert_kind_of User, Issue.find(1).assignable_users.first
1344 assert_kind_of User, Issue.find(1).assignable_users.first
1344 end
1345 end
1345
1346
1346 should "include the issue author" do
1347 should "include the issue author" do
1347 non_project_member = User.generate!
1348 non_project_member = User.generate!
1348 issue = Issue.generate!(:author => non_project_member)
1349 issue = Issue.generate!(:author => non_project_member)
1349
1350
1350 assert issue.assignable_users.include?(non_project_member)
1351 assert issue.assignable_users.include?(non_project_member)
1351 end
1352 end
1352
1353
1353 should "include the current assignee" do
1354 should "include the current assignee" do
1354 user = User.generate!
1355 user = User.generate!
1355 issue = Issue.generate!(:assigned_to => user)
1356 issue = Issue.generate!(:assigned_to => user)
1356 user.lock!
1357 user.lock!
1357
1358
1358 assert Issue.find(issue.id).assignable_users.include?(user)
1359 assert Issue.find(issue.id).assignable_users.include?(user)
1359 end
1360 end
1360
1361
1361 should "not show the issue author twice" do
1362 should "not show the issue author twice" do
1362 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1363 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1363 assert_equal 2, assignable_user_ids.length
1364 assert_equal 2, assignable_user_ids.length
1364
1365
1365 assignable_user_ids.each do |user_id|
1366 assignable_user_ids.each do |user_id|
1366 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1367 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1367 "User #{user_id} appears more or less than once"
1368 "User #{user_id} appears more or less than once"
1368 end
1369 end
1369 end
1370 end
1370
1371
1371 context "with issue_group_assignment" do
1372 context "with issue_group_assignment" do
1372 should "include groups" do
1373 should "include groups" do
1373 issue = Issue.new(:project => Project.find(2))
1374 issue = Issue.new(:project => Project.find(2))
1374
1375
1375 with_settings :issue_group_assignment => '1' do
1376 with_settings :issue_group_assignment => '1' do
1376 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1377 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1377 assert issue.assignable_users.include?(Group.find(11))
1378 assert issue.assignable_users.include?(Group.find(11))
1378 end
1379 end
1379 end
1380 end
1380 end
1381 end
1381
1382
1382 context "without issue_group_assignment" do
1383 context "without issue_group_assignment" do
1383 should "not include groups" do
1384 should "not include groups" do
1384 issue = Issue.new(:project => Project.find(2))
1385 issue = Issue.new(:project => Project.find(2))
1385
1386
1386 with_settings :issue_group_assignment => '0' do
1387 with_settings :issue_group_assignment => '0' do
1387 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1388 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1388 assert !issue.assignable_users.include?(Group.find(11))
1389 assert !issue.assignable_users.include?(Group.find(11))
1389 end
1390 end
1390 end
1391 end
1391 end
1392 end
1392 end
1393 end
1393
1394
1394 def test_create_should_send_email_notification
1395 def test_create_should_send_email_notification
1395 ActionMailer::Base.deliveries.clear
1396 ActionMailer::Base.deliveries.clear
1396 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1397 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1397 :author_id => 3, :status_id => 1,
1398 :author_id => 3, :status_id => 1,
1398 :priority => IssuePriority.all.first,
1399 :priority => IssuePriority.all.first,
1399 :subject => 'test_create', :estimated_hours => '1:30')
1400 :subject => 'test_create', :estimated_hours => '1:30')
1400
1401
1401 assert issue.save
1402 assert issue.save
1402 assert_equal 1, ActionMailer::Base.deliveries.size
1403 assert_equal 1, ActionMailer::Base.deliveries.size
1403 end
1404 end
1404
1405
1405 def test_stale_issue_should_not_send_email_notification
1406 def test_stale_issue_should_not_send_email_notification
1406 ActionMailer::Base.deliveries.clear
1407 ActionMailer::Base.deliveries.clear
1407 issue = Issue.find(1)
1408 issue = Issue.find(1)
1408 stale = Issue.find(1)
1409 stale = Issue.find(1)
1409
1410
1410 issue.init_journal(User.find(1))
1411 issue.init_journal(User.find(1))
1411 issue.subject = 'Subjet update'
1412 issue.subject = 'Subjet update'
1412 assert issue.save
1413 assert issue.save
1413 assert_equal 1, ActionMailer::Base.deliveries.size
1414 assert_equal 1, ActionMailer::Base.deliveries.size
1414 ActionMailer::Base.deliveries.clear
1415 ActionMailer::Base.deliveries.clear
1415
1416
1416 stale.init_journal(User.find(1))
1417 stale.init_journal(User.find(1))
1417 stale.subject = 'Another subjet update'
1418 stale.subject = 'Another subjet update'
1418 assert_raise ActiveRecord::StaleObjectError do
1419 assert_raise ActiveRecord::StaleObjectError do
1419 stale.save
1420 stale.save
1420 end
1421 end
1421 assert ActionMailer::Base.deliveries.empty?
1422 assert ActionMailer::Base.deliveries.empty?
1422 end
1423 end
1423
1424
1424 def test_journalized_description
1425 def test_journalized_description
1425 IssueCustomField.delete_all
1426 IssueCustomField.delete_all
1426
1427
1427 i = Issue.first
1428 i = Issue.first
1428 old_description = i.description
1429 old_description = i.description
1429 new_description = "This is the new description"
1430 new_description = "This is the new description"
1430
1431
1431 i.init_journal(User.find(2))
1432 i.init_journal(User.find(2))
1432 i.description = new_description
1433 i.description = new_description
1433 assert_difference 'Journal.count', 1 do
1434 assert_difference 'Journal.count', 1 do
1434 assert_difference 'JournalDetail.count', 1 do
1435 assert_difference 'JournalDetail.count', 1 do
1435 i.save!
1436 i.save!
1436 end
1437 end
1437 end
1438 end
1438
1439
1439 detail = JournalDetail.first(:order => 'id DESC')
1440 detail = JournalDetail.first(:order => 'id DESC')
1440 assert_equal i, detail.journal.journalized
1441 assert_equal i, detail.journal.journalized
1441 assert_equal 'attr', detail.property
1442 assert_equal 'attr', detail.property
1442 assert_equal 'description', detail.prop_key
1443 assert_equal 'description', detail.prop_key
1443 assert_equal old_description, detail.old_value
1444 assert_equal old_description, detail.old_value
1444 assert_equal new_description, detail.value
1445 assert_equal new_description, detail.value
1445 end
1446 end
1446
1447
1447 def test_blank_descriptions_should_not_be_journalized
1448 def test_blank_descriptions_should_not_be_journalized
1448 IssueCustomField.delete_all
1449 IssueCustomField.delete_all
1449 Issue.update_all("description = NULL", "id=1")
1450 Issue.update_all("description = NULL", "id=1")
1450
1451
1451 i = Issue.find(1)
1452 i = Issue.find(1)
1452 i.init_journal(User.find(2))
1453 i.init_journal(User.find(2))
1453 i.subject = "blank description"
1454 i.subject = "blank description"
1454 i.description = "\r\n"
1455 i.description = "\r\n"
1455
1456
1456 assert_difference 'Journal.count', 1 do
1457 assert_difference 'Journal.count', 1 do
1457 assert_difference 'JournalDetail.count', 1 do
1458 assert_difference 'JournalDetail.count', 1 do
1458 i.save!
1459 i.save!
1459 end
1460 end
1460 end
1461 end
1461 end
1462 end
1462
1463
1463 def test_journalized_multi_custom_field
1464 def test_journalized_multi_custom_field
1464 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1465 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1465 :is_filter => true, :is_for_all => true,
1466 :is_filter => true, :is_for_all => true,
1466 :tracker_ids => [1],
1467 :tracker_ids => [1],
1467 :possible_values => ['value1', 'value2', 'value3'],
1468 :possible_values => ['value1', 'value2', 'value3'],
1468 :multiple => true)
1469 :multiple => true)
1469
1470
1470 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1471 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1471 :subject => 'Test', :author_id => 1)
1472 :subject => 'Test', :author_id => 1)
1472
1473
1473 assert_difference 'Journal.count' do
1474 assert_difference 'Journal.count' do
1474 assert_difference 'JournalDetail.count' do
1475 assert_difference 'JournalDetail.count' do
1475 issue.init_journal(User.first)
1476 issue.init_journal(User.first)
1476 issue.custom_field_values = {field.id => ['value1']}
1477 issue.custom_field_values = {field.id => ['value1']}
1477 issue.save!
1478 issue.save!
1478 end
1479 end
1479 assert_difference 'JournalDetail.count' do
1480 assert_difference 'JournalDetail.count' do
1480 issue.init_journal(User.first)
1481 issue.init_journal(User.first)
1481 issue.custom_field_values = {field.id => ['value1', 'value2']}
1482 issue.custom_field_values = {field.id => ['value1', 'value2']}
1482 issue.save!
1483 issue.save!
1483 end
1484 end
1484 assert_difference 'JournalDetail.count', 2 do
1485 assert_difference 'JournalDetail.count', 2 do
1485 issue.init_journal(User.first)
1486 issue.init_journal(User.first)
1486 issue.custom_field_values = {field.id => ['value3', 'value2']}
1487 issue.custom_field_values = {field.id => ['value3', 'value2']}
1487 issue.save!
1488 issue.save!
1488 end
1489 end
1489 assert_difference 'JournalDetail.count', 2 do
1490 assert_difference 'JournalDetail.count', 2 do
1490 issue.init_journal(User.first)
1491 issue.init_journal(User.first)
1491 issue.custom_field_values = {field.id => nil}
1492 issue.custom_field_values = {field.id => nil}
1492 issue.save!
1493 issue.save!
1493 end
1494 end
1494 end
1495 end
1495 end
1496 end
1496
1497
1497 def test_description_eol_should_be_normalized
1498 def test_description_eol_should_be_normalized
1498 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1499 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1499 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1500 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1500 end
1501 end
1501
1502
1502 def test_saving_twice_should_not_duplicate_journal_details
1503 def test_saving_twice_should_not_duplicate_journal_details
1503 i = Issue.find(:first)
1504 i = Issue.find(:first)
1504 i.init_journal(User.find(2), 'Some notes')
1505 i.init_journal(User.find(2), 'Some notes')
1505 # initial changes
1506 # initial changes
1506 i.subject = 'New subject'
1507 i.subject = 'New subject'
1507 i.done_ratio = i.done_ratio + 10
1508 i.done_ratio = i.done_ratio + 10
1508 assert_difference 'Journal.count' do
1509 assert_difference 'Journal.count' do
1509 assert i.save
1510 assert i.save
1510 end
1511 end
1511 # 1 more change
1512 # 1 more change
1512 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1513 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1513 assert_no_difference 'Journal.count' do
1514 assert_no_difference 'Journal.count' do
1514 assert_difference 'JournalDetail.count', 1 do
1515 assert_difference 'JournalDetail.count', 1 do
1515 i.save
1516 i.save
1516 end
1517 end
1517 end
1518 end
1518 # no more change
1519 # no more change
1519 assert_no_difference 'Journal.count' do
1520 assert_no_difference 'Journal.count' do
1520 assert_no_difference 'JournalDetail.count' do
1521 assert_no_difference 'JournalDetail.count' do
1521 i.save
1522 i.save
1522 end
1523 end
1523 end
1524 end
1524 end
1525 end
1525
1526
1526 def test_all_dependent_issues
1527 def test_all_dependent_issues
1527 IssueRelation.delete_all
1528 IssueRelation.delete_all
1528 assert IssueRelation.create!(:issue_from => Issue.find(1),
1529 assert IssueRelation.create!(:issue_from => Issue.find(1),
1529 :issue_to => Issue.find(2),
1530 :issue_to => Issue.find(2),
1530 :relation_type => IssueRelation::TYPE_PRECEDES)
1531 :relation_type => IssueRelation::TYPE_PRECEDES)
1531 assert IssueRelation.create!(:issue_from => Issue.find(2),
1532 assert IssueRelation.create!(:issue_from => Issue.find(2),
1532 :issue_to => Issue.find(3),
1533 :issue_to => Issue.find(3),
1533 :relation_type => IssueRelation::TYPE_PRECEDES)
1534 :relation_type => IssueRelation::TYPE_PRECEDES)
1534 assert IssueRelation.create!(:issue_from => Issue.find(3),
1535 assert IssueRelation.create!(:issue_from => Issue.find(3),
1535 :issue_to => Issue.find(8),
1536 :issue_to => Issue.find(8),
1536 :relation_type => IssueRelation::TYPE_PRECEDES)
1537 :relation_type => IssueRelation::TYPE_PRECEDES)
1537
1538
1538 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1539 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1539 end
1540 end
1540
1541
1541 def test_all_dependent_issues_with_persistent_circular_dependency
1542 def test_all_dependent_issues_with_persistent_circular_dependency
1542 IssueRelation.delete_all
1543 IssueRelation.delete_all
1543 assert IssueRelation.create!(:issue_from => Issue.find(1),
1544 assert IssueRelation.create!(:issue_from => Issue.find(1),
1544 :issue_to => Issue.find(2),
1545 :issue_to => Issue.find(2),
1545 :relation_type => IssueRelation::TYPE_PRECEDES)
1546 :relation_type => IssueRelation::TYPE_PRECEDES)
1546 assert IssueRelation.create!(:issue_from => Issue.find(2),
1547 assert IssueRelation.create!(:issue_from => Issue.find(2),
1547 :issue_to => Issue.find(3),
1548 :issue_to => Issue.find(3),
1548 :relation_type => IssueRelation::TYPE_PRECEDES)
1549 :relation_type => IssueRelation::TYPE_PRECEDES)
1549
1550
1550 r = IssueRelation.create!(:issue_from => Issue.find(3),
1551 r = IssueRelation.create!(:issue_from => Issue.find(3),
1551 :issue_to => Issue.find(7),
1552 :issue_to => Issue.find(7),
1552 :relation_type => IssueRelation::TYPE_PRECEDES)
1553 :relation_type => IssueRelation::TYPE_PRECEDES)
1553 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1554 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1554
1555
1555 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1556 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1556 end
1557 end
1557
1558
1558 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1559 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1559 IssueRelation.delete_all
1560 IssueRelation.delete_all
1560 assert IssueRelation.create!(:issue_from => Issue.find(1),
1561 assert IssueRelation.create!(:issue_from => Issue.find(1),
1561 :issue_to => Issue.find(2),
1562 :issue_to => Issue.find(2),
1562 :relation_type => IssueRelation::TYPE_RELATES)
1563 :relation_type => IssueRelation::TYPE_RELATES)
1563 assert IssueRelation.create!(:issue_from => Issue.find(2),
1564 assert IssueRelation.create!(:issue_from => Issue.find(2),
1564 :issue_to => Issue.find(3),
1565 :issue_to => Issue.find(3),
1565 :relation_type => IssueRelation::TYPE_RELATES)
1566 :relation_type => IssueRelation::TYPE_RELATES)
1566 assert IssueRelation.create!(:issue_from => Issue.find(3),
1567 assert IssueRelation.create!(:issue_from => Issue.find(3),
1567 :issue_to => Issue.find(8),
1568 :issue_to => Issue.find(8),
1568 :relation_type => IssueRelation::TYPE_RELATES)
1569 :relation_type => IssueRelation::TYPE_RELATES)
1569
1570
1570 r = IssueRelation.create!(:issue_from => Issue.find(8),
1571 r = IssueRelation.create!(:issue_from => Issue.find(8),
1571 :issue_to => Issue.find(7),
1572 :issue_to => Issue.find(7),
1572 :relation_type => IssueRelation::TYPE_RELATES)
1573 :relation_type => IssueRelation::TYPE_RELATES)
1573 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1574 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1574
1575
1575 r = IssueRelation.create!(:issue_from => Issue.find(3),
1576 r = IssueRelation.create!(:issue_from => Issue.find(3),
1576 :issue_to => Issue.find(7),
1577 :issue_to => Issue.find(7),
1577 :relation_type => IssueRelation::TYPE_RELATES)
1578 :relation_type => IssueRelation::TYPE_RELATES)
1578 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1579 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1579
1580
1580 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1581 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1581 end
1582 end
1582
1583
1583 context "#done_ratio" do
1584 context "#done_ratio" do
1584 setup do
1585 setup do
1585 @issue = Issue.find(1)
1586 @issue = Issue.find(1)
1586 @issue_status = IssueStatus.find(1)
1587 @issue_status = IssueStatus.find(1)
1587 @issue_status.update_attribute(:default_done_ratio, 50)
1588 @issue_status.update_attribute(:default_done_ratio, 50)
1588 @issue2 = Issue.find(2)
1589 @issue2 = Issue.find(2)
1589 @issue_status2 = IssueStatus.find(2)
1590 @issue_status2 = IssueStatus.find(2)
1590 @issue_status2.update_attribute(:default_done_ratio, 0)
1591 @issue_status2.update_attribute(:default_done_ratio, 0)
1591 end
1592 end
1592
1593
1593 teardown do
1594 teardown do
1594 Setting.issue_done_ratio = 'issue_field'
1595 Setting.issue_done_ratio = 'issue_field'
1595 end
1596 end
1596
1597
1597 context "with Setting.issue_done_ratio using the issue_field" do
1598 context "with Setting.issue_done_ratio using the issue_field" do
1598 setup do
1599 setup do
1599 Setting.issue_done_ratio = 'issue_field'
1600 Setting.issue_done_ratio = 'issue_field'
1600 end
1601 end
1601
1602
1602 should "read the issue's field" do
1603 should "read the issue's field" do
1603 assert_equal 0, @issue.done_ratio
1604 assert_equal 0, @issue.done_ratio
1604 assert_equal 30, @issue2.done_ratio
1605 assert_equal 30, @issue2.done_ratio
1605 end
1606 end
1606 end
1607 end
1607
1608
1608 context "with Setting.issue_done_ratio using the issue_status" do
1609 context "with Setting.issue_done_ratio using the issue_status" do
1609 setup do
1610 setup do
1610 Setting.issue_done_ratio = 'issue_status'
1611 Setting.issue_done_ratio = 'issue_status'
1611 end
1612 end
1612
1613
1613 should "read the Issue Status's default done ratio" do
1614 should "read the Issue Status's default done ratio" do
1614 assert_equal 50, @issue.done_ratio
1615 assert_equal 50, @issue.done_ratio
1615 assert_equal 0, @issue2.done_ratio
1616 assert_equal 0, @issue2.done_ratio
1616 end
1617 end
1617 end
1618 end
1618 end
1619 end
1619
1620
1620 context "#update_done_ratio_from_issue_status" do
1621 context "#update_done_ratio_from_issue_status" do
1621 setup do
1622 setup do
1622 @issue = Issue.find(1)
1623 @issue = Issue.find(1)
1623 @issue_status = IssueStatus.find(1)
1624 @issue_status = IssueStatus.find(1)
1624 @issue_status.update_attribute(:default_done_ratio, 50)
1625 @issue_status.update_attribute(:default_done_ratio, 50)
1625 @issue2 = Issue.find(2)
1626 @issue2 = Issue.find(2)
1626 @issue_status2 = IssueStatus.find(2)
1627 @issue_status2 = IssueStatus.find(2)
1627 @issue_status2.update_attribute(:default_done_ratio, 0)
1628 @issue_status2.update_attribute(:default_done_ratio, 0)
1628 end
1629 end
1629
1630
1630 context "with Setting.issue_done_ratio using the issue_field" do
1631 context "with Setting.issue_done_ratio using the issue_field" do
1631 setup do
1632 setup do
1632 Setting.issue_done_ratio = 'issue_field'
1633 Setting.issue_done_ratio = 'issue_field'
1633 end
1634 end
1634
1635
1635 should "not change the issue" do
1636 should "not change the issue" do
1636 @issue.update_done_ratio_from_issue_status
1637 @issue.update_done_ratio_from_issue_status
1637 @issue2.update_done_ratio_from_issue_status
1638 @issue2.update_done_ratio_from_issue_status
1638
1639
1639 assert_equal 0, @issue.read_attribute(:done_ratio)
1640 assert_equal 0, @issue.read_attribute(:done_ratio)
1640 assert_equal 30, @issue2.read_attribute(:done_ratio)
1641 assert_equal 30, @issue2.read_attribute(:done_ratio)
1641 end
1642 end
1642 end
1643 end
1643
1644
1644 context "with Setting.issue_done_ratio using the issue_status" do
1645 context "with Setting.issue_done_ratio using the issue_status" do
1645 setup do
1646 setup do
1646 Setting.issue_done_ratio = 'issue_status'
1647 Setting.issue_done_ratio = 'issue_status'
1647 end
1648 end
1648
1649
1649 should "change the issue's done ratio" do
1650 should "change the issue's done ratio" do
1650 @issue.update_done_ratio_from_issue_status
1651 @issue.update_done_ratio_from_issue_status
1651 @issue2.update_done_ratio_from_issue_status
1652 @issue2.update_done_ratio_from_issue_status
1652
1653
1653 assert_equal 50, @issue.read_attribute(:done_ratio)
1654 assert_equal 50, @issue.read_attribute(:done_ratio)
1654 assert_equal 0, @issue2.read_attribute(:done_ratio)
1655 assert_equal 0, @issue2.read_attribute(:done_ratio)
1655 end
1656 end
1656 end
1657 end
1657 end
1658 end
1658
1659
1659 test "#by_tracker" do
1660 test "#by_tracker" do
1660 User.current = User.anonymous
1661 User.current = User.anonymous
1661 groups = Issue.by_tracker(Project.find(1))
1662 groups = Issue.by_tracker(Project.find(1))
1662 assert_equal 3, groups.size
1663 assert_equal 3, groups.size
1663 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1664 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1664 end
1665 end
1665
1666
1666 test "#by_version" do
1667 test "#by_version" do
1667 User.current = User.anonymous
1668 User.current = User.anonymous
1668 groups = Issue.by_version(Project.find(1))
1669 groups = Issue.by_version(Project.find(1))
1669 assert_equal 3, groups.size
1670 assert_equal 3, groups.size
1670 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1671 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1671 end
1672 end
1672
1673
1673 test "#by_priority" do
1674 test "#by_priority" do
1674 User.current = User.anonymous
1675 User.current = User.anonymous
1675 groups = Issue.by_priority(Project.find(1))
1676 groups = Issue.by_priority(Project.find(1))
1676 assert_equal 4, groups.size
1677 assert_equal 4, groups.size
1677 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1678 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1678 end
1679 end
1679
1680
1680 test "#by_category" do
1681 test "#by_category" do
1681 User.current = User.anonymous
1682 User.current = User.anonymous
1682 groups = Issue.by_category(Project.find(1))
1683 groups = Issue.by_category(Project.find(1))
1683 assert_equal 2, groups.size
1684 assert_equal 2, groups.size
1684 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1685 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1685 end
1686 end
1686
1687
1687 test "#by_assigned_to" do
1688 test "#by_assigned_to" do
1688 User.current = User.anonymous
1689 User.current = User.anonymous
1689 groups = Issue.by_assigned_to(Project.find(1))
1690 groups = Issue.by_assigned_to(Project.find(1))
1690 assert_equal 2, groups.size
1691 assert_equal 2, groups.size
1691 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1692 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1692 end
1693 end
1693
1694
1694 test "#by_author" do
1695 test "#by_author" do
1695 User.current = User.anonymous
1696 User.current = User.anonymous
1696 groups = Issue.by_author(Project.find(1))
1697 groups = Issue.by_author(Project.find(1))
1697 assert_equal 4, groups.size
1698 assert_equal 4, groups.size
1698 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1699 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1699 end
1700 end
1700
1701
1701 test "#by_subproject" do
1702 test "#by_subproject" do
1702 User.current = User.anonymous
1703 User.current = User.anonymous
1703 groups = Issue.by_subproject(Project.find(1))
1704 groups = Issue.by_subproject(Project.find(1))
1704 # Private descendant not visible
1705 # Private descendant not visible
1705 assert_equal 1, groups.size
1706 assert_equal 1, groups.size
1706 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1707 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1707 end
1708 end
1708
1709
1709 def test_recently_updated_scope
1710 def test_recently_updated_scope
1710 #should return the last updated issue
1711 #should return the last updated issue
1711 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1712 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1712 end
1713 end
1713
1714
1714 def test_on_active_projects_scope
1715 def test_on_active_projects_scope
1715 assert Project.find(2).archive
1716 assert Project.find(2).archive
1716
1717
1717 before = Issue.on_active_project.length
1718 before = Issue.on_active_project.length
1718 # test inclusion to results
1719 # test inclusion to results
1719 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1720 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1720 assert_equal before + 1, Issue.on_active_project.length
1721 assert_equal before + 1, Issue.on_active_project.length
1721
1722
1722 # Move to an archived project
1723 # Move to an archived project
1723 issue.project = Project.find(2)
1724 issue.project = Project.find(2)
1724 assert issue.save
1725 assert issue.save
1725 assert_equal before, Issue.on_active_project.length
1726 assert_equal before, Issue.on_active_project.length
1726 end
1727 end
1727
1728
1728 context "Issue#recipients" do
1729 context "Issue#recipients" do
1729 setup do
1730 setup do
1730 @project = Project.find(1)
1731 @project = Project.find(1)
1731 @author = User.generate!
1732 @author = User.generate!
1732 @assignee = User.generate!
1733 @assignee = User.generate!
1733 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1734 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1734 end
1735 end
1735
1736
1736 should "include project recipients" do
1737 should "include project recipients" do
1737 assert @project.recipients.present?
1738 assert @project.recipients.present?
1738 @project.recipients.each do |project_recipient|
1739 @project.recipients.each do |project_recipient|
1739 assert @issue.recipients.include?(project_recipient)
1740 assert @issue.recipients.include?(project_recipient)
1740 end
1741 end
1741 end
1742 end
1742
1743
1743 should "include the author if the author is active" do
1744 should "include the author if the author is active" do
1744 assert @issue.author, "No author set for Issue"
1745 assert @issue.author, "No author set for Issue"
1745 assert @issue.recipients.include?(@issue.author.mail)
1746 assert @issue.recipients.include?(@issue.author.mail)
1746 end
1747 end
1747
1748
1748 should "include the assigned to user if the assigned to user is active" do
1749 should "include the assigned to user if the assigned to user is active" do
1749 assert @issue.assigned_to, "No assigned_to set for Issue"
1750 assert @issue.assigned_to, "No assigned_to set for Issue"
1750 assert @issue.recipients.include?(@issue.assigned_to.mail)
1751 assert @issue.recipients.include?(@issue.assigned_to.mail)
1751 end
1752 end
1752
1753
1753 should "not include users who opt out of all email" do
1754 should "not include users who opt out of all email" do
1754 @author.update_attribute(:mail_notification, :none)
1755 @author.update_attribute(:mail_notification, :none)
1755
1756
1756 assert !@issue.recipients.include?(@issue.author.mail)
1757 assert !@issue.recipients.include?(@issue.author.mail)
1757 end
1758 end
1758
1759
1759 should "not include the issue author if they are only notified of assigned issues" do
1760 should "not include the issue author if they are only notified of assigned issues" do
1760 @author.update_attribute(:mail_notification, :only_assigned)
1761 @author.update_attribute(:mail_notification, :only_assigned)
1761
1762
1762 assert !@issue.recipients.include?(@issue.author.mail)
1763 assert !@issue.recipients.include?(@issue.author.mail)
1763 end
1764 end
1764
1765
1765 should "not include the assigned user if they are only notified of owned issues" do
1766 should "not include the assigned user if they are only notified of owned issues" do
1766 @assignee.update_attribute(:mail_notification, :only_owner)
1767 @assignee.update_attribute(:mail_notification, :only_owner)
1767
1768
1768 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1769 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1769 end
1770 end
1770 end
1771 end
1771
1772
1772 def test_last_journal_id_with_journals_should_return_the_journal_id
1773 def test_last_journal_id_with_journals_should_return_the_journal_id
1773 assert_equal 2, Issue.find(1).last_journal_id
1774 assert_equal 2, Issue.find(1).last_journal_id
1774 end
1775 end
1775
1776
1776 def test_last_journal_id_without_journals_should_return_nil
1777 def test_last_journal_id_without_journals_should_return_nil
1777 assert_nil Issue.find(3).last_journal_id
1778 assert_nil Issue.find(3).last_journal_id
1778 end
1779 end
1779
1780
1780 def test_journals_after_should_return_journals_with_greater_id
1781 def test_journals_after_should_return_journals_with_greater_id
1781 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1782 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1782 assert_equal [], Issue.find(1).journals_after('2')
1783 assert_equal [], Issue.find(1).journals_after('2')
1783 end
1784 end
1784
1785
1785 def test_journals_after_with_blank_arg_should_return_all_journals
1786 def test_journals_after_with_blank_arg_should_return_all_journals
1786 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1787 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1787 end
1788 end
1788 end
1789 end
General Comments 0
You need to be logged in to leave comments. Login now