jro_apps/redmine Commit - r9860:035805fbd042

Start removing the RJS stuff....

Jean-Philippe Lang -

r9860:035805fbd042

parent child

Context file:

r9860:035805fbd042

Collapse all files

app/views/issue_categories/create.js.erb created 644 +3 0

@@ -0,0 +1,3
	1	hideModal();
	2	<% select = content_tag('select', content_tag('option') + options_from_collection_for_select(@project.issue_categories, 'id', 'name', @category.id), :id => 'issue_category_id', :name => 'issue[category_id]') %>
	3	Element.replace('issue_category_id', '<%= escape_javascript(select) %>');

app/views/issue_categories/new.js.erb created 644 +3 0

@@ -0,0 +1,3
	1	Element.update('ajax-modal', '<%= escape_javascript(render :partial => 'issue_categories/new_modal') %>');
	2	showModal('ajax-modal', '600px');
	3	Form.Element.focus('issue_category_name');

app/views/versions/create.js.erb created 644 +3 0

@@ -0,0 +1,3
	1	hideModal();
	2	<% select = content_tag('select', content_tag('option') + version_options_for_select(@project.shared_versions.open, @version), :id => 'issue_fixed_version_id', :name => 'issue[fixed_version_id]') %>
	3	Element.replace('issue_fixed_version_id', '<%= escape_javascript(select) %>');

app/views/versions/new.js.erb created 644 +3 0

@@ -0,0 +1,3
	1	Element.update('ajax-modal', '<%= escape_javascript(render :partial => 'versions/new_modal') %>');
	2	showModal('ajax-modal', '600px');
	3	Form.Element.focus('version_name');

app/controllers/issue_categories_controller.rb +3 -21

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssueCategoriesController < ApplicationController
               menu_item :settings
               model_object IssueCategory
               before_filter :find_model_object, :except => [:index, :new, :create]
               before_filter :find_project_from_association, :except => [:index, :new, :create]
               before_filter :find_project_by_project_id, :only => [:index, :new, :create]
               before_filter :authorize
               accept_api_auth :index, :show, :create, :update, :destroy
               def index
                 respond_to do |format|
                   format.html { redirect_to :controller => 'projects', :action => 'settings', :tab => 'categories', :id => @project }
                   format.api { @categories = @project.issue_categories.all }
                 end
               end
               def show
                 respond_to do |format|
                   format.html { redirect_to :controller => 'projects', :action => 'settings', :tab => 'categories', :id => @project }
                   format.api
                 end
               end
               def new
                 @category = @project.issue_categories.build
                 @category.safe_attributes = params[:issue_category]
                 respond_to do |format|
                   format.html
-                  format.js do
+                  format.js
-                    render :update do |page|
-                      page.replace_html 'ajax-modal', :partial => 'issue_categories/new_modal'
-                      page << "showModal('ajax-modal', '600px');"
-                      page << "Form.Element.focus('issue_category_name');"
-                    end
-                  end
                 end
               end
               def create
                 @category = @project.issue_categories.build
                 @category.safe_attributes = params[:issue_category]
                 if @category.save
                   respond_to do |format|
                     format.html do
                       flash[:notice] = l(:notice_successful_create)
                       redirect_to :controller => 'projects', :action => 'settings', :tab => 'categories', :id => @project
                     end
-                    format.js do
+                    format.js
-                      render(:update) {|page|
-                        page << 'hideModal();'
-                        # IE doesn't support the replace_html rjs method for select box options
-                        page.replace "issue_category_id",
-                          content_tag('select', content_tag('option') + options_from_collection_for_select(@project.issue_categories, 'id', 'name', @category.id), :id => 'issue_category_id', :name => 'issue[category_id]')
-                    end
                     format.api { render :action => 'show', :status => :created, :location => issue_category_path(@category) }
                   end
                 else
                   respond_to do |format|
                     format.html { render :action => 'new'}
-                    format.js do
+                    format.js   { render :action => 'new'}
-                      render :update do |page|
-                        page.replace_html 'ajax-modal', :partial => 'issue_categories/new_modal'
-                        page << "Form.Element.focus('version_name');"
-                      end
-                    end
                     format.api { render_validation_errors(@category) }
                   end
                 end
               end
               def edit
               end
               def update
                 @category.safe_attributes = params[:issue_category]
                 if @category.save
                   respond_to do |format|
                     format.html {
                       flash[:notice] = l(:notice_successful_update)
                       redirect_to :controller => 'projects', :action => 'settings', :tab => 'categories', :id => @project
                     }
                     format.api { render_api_ok }
                   end
                 else
                   respond_to do |format|
                     format.html { render :action => 'edit' }
                     format.api { render_validation_errors(@category) }
                   end
                 end
               end
               def destroy
                 @issue_count = @category.issues.size
                 if @issue_count == 0 || params[:todo] || api_request?
                   reassign_to = nil
                   if params[:reassign_to_id] && (params[:todo] == 'reassign' || params[:todo].blank?)
                     reassign_to = @project.issue_categories.find_by_id(params[:reassign_to_id])
                   end
                   @category.destroy(reassign_to)
                   respond_to do |format|
                     format.html { redirect_to :controller => 'projects', :action => 'settings', :id => @project, :tab => 'categories' }
                     format.api { render_api_ok }
                   end
                   return
                 end
                 @categories = @project.issue_categories - [@category]
               end
             private
               # Wrap ApplicationController's find_model_object method to set
               # @category instead of just @issue_category
               def find_model_object
                 super
                 @category = @object
               end
             end

app/controllers/versions_controller.rb +3 -21

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class VersionsController < ApplicationController
               menu_item :roadmap
               model_object Version
               before_filter :find_model_object, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project_from_association, :except => [:index, :new, :create, :close_completed]
               before_filter :find_project, :only => [:index, :new, :create, :close_completed]
               before_filter :authorize
               accept_api_auth :index, :show, :create, :update, :destroy
               helper :custom_fields
               helper :projects
               def index
                 respond_to do |format|
                   format.html {
                     @trackers = @project.trackers.find(:all, :order => 'position')
                     retrieve_selected_tracker_ids(@trackers, @trackers.select {|t| t.is_in_roadmap?})
                     @with_subprojects = params[:with_subprojects].nil? ? Setting.display_subprojects_issues? : (params[:with_subprojects] == '1')
                     project_ids = @with_subprojects ? @project.self_and_descendants.collect(&:id) : [@project.id]
                     @versions = @project.shared_versions || []
                     @versions += @project.rolled_up_versions.visible if @with_subprojects
                     @versions = @versions.uniq.sort
                     unless params[:completed]
                       @completed_versions = @versions.select {|version| version.closed? || version.completed? }
                       @versions -= @completed_versions
                     end
                     @issues_by_version = {}
                     if @selected_tracker_ids.any? && @versions.any?
                       issues = Issue.visible.all(
                         :include => [:project, :status, :tracker, :priority, :fixed_version],
                         :conditions => {:tracker_id => @selected_tracker_ids, :project_id => project_ids, :fixed_version_id => @versions.map(&:id)},
                         :order => "#{Project.table_name}.lft, #{Tracker.table_name}.position, #{Issue.table_name}.id"
                       )
                       @issues_by_version = issues.group_by(&:fixed_version)
                     end
                     @versions.reject! {|version| !project_ids.include?(version.project_id) && @issues_by_version[version].blank?}
                   }
                   format.api {
                     @versions = @project.shared_versions.all
                   }
                 end
               end
               def show
                 respond_to do |format|
                   format.html {
                     @issues = @version.fixed_issues.visible.find(:all,
                       :include => [:status, :tracker, :priority],
                       :order => "#{Tracker.table_name}.position, #{Issue.table_name}.id")
                   }
                   format.api
                 end
               end
               def new
                 @version = @project.versions.build
                 @version.safe_attributes = params[:version]
                 respond_to do |format|
                   format.html
-                  format.js do
+                  format.js
-                    render :update do |page|
-                      page.replace_html 'ajax-modal', :partial => 'versions/new_modal'
-                      page << "showModal('ajax-modal', '600px');"
-                      page << "Form.Element.focus('version_name');"
-                    end
-                  end
                 end
               end
               def create
                 @version = @project.versions.build
                 if params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless attributes.nil? || @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                 end
                 if request.post?
                   if @version.save
                     respond_to do |format|
                       format.html do
                         flash[:notice] = l(:notice_successful_create)
                         redirect_back_or_default :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
                       end
-                      format.js do
+                      format.js
-                        render(:update) {|page|
-                          page << 'hideModal();'
-                          # IE doesn't support the replace_html rjs method for select box options
-                          page.replace "issue_fixed_version_id",
-                            content_tag('select', content_tag('option') + version_options_for_select(@project.shared_versions.open, @version), :id => 'issue_fixed_version_id', :name => 'issue[fixed_version_id]')
-                      end
                       format.api do
                         render :action => 'show', :status => :created, :location => version_url(@version)
                       end
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'new' }
-                      format.js do
+                      format.js   { render :action => 'new' }
-                        render :update do |page|
-                          page.replace_html 'ajax-modal', :partial => 'versions/new_modal'
-                          page << "Form.Element.focus('version_name');"
-                        end
-                      end
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def edit
               end
               def update
                 if request.put? && params[:version]
                   attributes = params[:version].dup
                   attributes.delete('sharing') unless @version.allowed_sharings.include?(attributes['sharing'])
                   @version.safe_attributes = attributes
                   if @version.save
                     respond_to do |format|
                       format.html {
                         flash[:notice] = l(:notice_successful_update)
                         redirect_back_or_default :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
                       }
                       format.api  { render_api_ok }
                     end
                   else
                     respond_to do |format|
                       format.html { render :action => 'edit' }
                       format.api  { render_validation_errors(@version) }
                     end
                   end
                 end
               end
               def close_completed
                 if request.put?
                   @project.close_completed_versions
                 end
                 redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
               end
               def destroy
                 if @version.fixed_issues.empty?
                   @version.destroy
                   respond_to do |format|
                     format.html { redirect_back_or_default :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project }
                     format.api  { render_api_ok }
                   end
                 else
                   respond_to do |format|
                     format.html {
                       flash[:error] = l(:notice_unable_delete_version)
                       redirect_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => @project
                     }
                     format.api  { head :unprocessable_entity }
                   end
                 end
               end
               def status_by
                 respond_to do |format|
                   format.html { render :action => 'show' }
                   format.js { render(:update) {|page| page.replace_html 'status_by', render_issue_status_by(@version, params[:status_by])} }
                 end
               end
             private
               def find_project
                 @project = Project.find(params[:project_id])
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def retrieve_selected_tracker_ids(selectable_trackers, default_trackers=nil)
                 if ids = params[:tracker_ids]
                   @selected_tracker_ids = (ids.is_a? Array) ? ids.collect { |id| id.to_i.to_s } : ids.split('/').collect { |id| id.to_i.to_s }
                 else
                   @selected_tracker_ids = (default_trackers || selectable_trackers).collect {|t| t.id.to_s }
                 end
               end
             end

test/functional/issue_categories_controller_test.rb +13 -6

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'issue_categories_controller'
             # Re-raise errors caught by the controller.
             class IssueCategoriesController; def rescue_action(e) raise e end; end
             class IssueCategoriesControllerTest < ActionController::TestCase
               fixtures :projects, :users, :members, :member_roles, :roles, :enabled_modules, :issue_categories
               def setup
                 @controller = IssueCategoriesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
                 @request.session[:user_id] = 2
               end
               def test_new
                 @request.session[:user_id] = 2 # manager
                 get :new, :project_id => '1'
                 assert_response :success
                 assert_template 'new'
                 assert_select 'input[name=?]', 'issue_category[name]'
               end
+              def test_new_from_issue_form
+                @request.session[:user_id] = 2 # manager
+                xhr :get, :new, :project_id => '1'
+                assert_response :success
+                assert_template 'new'
+                assert_equal 'text/javascript', response.content_type
+              end
               def test_create
                 @request.session[:user_id] = 2 # manager
                 assert_difference 'IssueCategory.count' do
                   post :create, :project_id => '1', :issue_category => {:name => 'New category'}
                 end
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 category = IssueCategory.find_by_name('New category')
                 assert_not_nil category
                 assert_equal 1, category.project_id
               end
               def test_create_failure
                 @request.session[:user_id] = 2
                 post :create, :project_id => '1', :issue_category => {:name => ''}
                 assert_response :success
                 assert_template 'new'
               end
               def test_create_from_issue_form
                 @request.session[:user_id] = 2 # manager
                 assert_difference 'IssueCategory.count' do
                   xhr :post, :create, :project_id => '1', :issue_category => {:name => 'New category'}
                 end
                 category = IssueCategory.first(:order => 'id DESC')
                 assert_equal 'New category', category.name
                 assert_response :success
-                assert_select_rjs :replace, 'issue_category_id' do
+                assert_template 'create'
-                  assert_select "option[value=#{category.id}][selected=selected]"
+                assert_equal 'text/javascript', response.content_type
-                end
               end
               def test_create_from_issue_form_with_failure
                 @request.session[:user_id] = 2 # manager
                 assert_no_difference 'IssueCategory.count' do
                   xhr :post, :create, :project_id => '1', :issue_category => {:name => ''}
                 end
                 assert_response :success
-                assert_select_rjs :replace_html, "ajax-modal" do
+                assert_template 'new'
-                  assert_select "div#errorExplanation"
+                assert_equal 'text/javascript', response.content_type
-                end
               end
               def test_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 2
                 assert_response :success
                 assert_template 'edit'
                 assert_select 'input[name=?][value=?]', 'issue_category[name]', 'Recipes'
               end
               def test_update
                 assert_no_difference 'IssueCategory.count' do
                   put :update, :id => 2, :issue_category => { :name => 'Testing' }
                 end
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_equal 'Testing', IssueCategory.find(2).name
               end
               def test_update_failure
                 put :update, :id => 2, :issue_category => { :name => '' }
                 assert_response :success
                 assert_template 'edit'
               end
               def test_update_not_found
                 put :update, :id => 97, :issue_category => { :name => 'Testing' }
                 assert_response 404
               end
               def test_destroy_category_not_in_use
                 delete :destroy, :id => 2
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(2)
               end
               def test_destroy_category_in_use
                 delete :destroy, :id => 1
                 assert_response :success
                 assert_template 'destroy'
                 assert_not_nil IssueCategory.find_by_id(1)
               end
               def test_destroy_category_in_use_with_reassignment
                 issue = Issue.find(:first, :conditions => {:category_id => 1})
                 delete :destroy, :id => 1, :todo => 'reassign', :reassign_to_id => 2
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(1)
                 # check that the issue was reassign
                 assert_equal 2, issue.reload.category_id
               end
               def test_destroy_category_in_use_without_reassignment
                 issue = Issue.find(:first, :conditions => {:category_id => 1})
                 delete :destroy, :id => 1, :todo => 'nullify'
                 assert_redirected_to '/projects/ecookbook/settings/categories'
                 assert_nil IssueCategory.find_by_id(1)
                 # check that the issue category was nullified
                 assert_nil issue.reload.category_id
               end
             end

test/functional/versions_controller_test.rb +6 -10

             # Redmine - project management software
             # Copyright (C) 2006-2012  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             require 'versions_controller'
             # Re-raise errors caught by the controller.
             class VersionsController; def rescue_action(e) raise e end; end
             class VersionsControllerTest < ActionController::TestCase
               fixtures :projects, :versions, :issues, :users, :roles, :members, :member_roles, :enabled_modules, :issue_statuses
               def setup
                 @controller = VersionsController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
               end
               def test_index
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:versions)
                 # Version with no date set appears
                 assert assigns(:versions).include?(Version.find(3))
                 # Completed version doesn't appear
                 assert !assigns(:versions).include?(Version.find(1))
                 # Context menu on issues
                 assert_select "script", :text => Regexp.new(Regexp.escape("new ContextMenu('/issues/context_menu')"))
                 # Links to versions anchors
                 assert_tag 'a', :attributes => {:href => '#2.0'},
                                 :ancestor => {:tag => 'div', :attributes => {:id => 'sidebar'}}
                 # Links to completed versions in the sidebar
                 assert_tag 'a', :attributes => {:href => '/versions/1'},
                                 :ancestor => {:tag => 'div', :attributes => {:id => 'sidebar'}}
               end
               def test_index_with_completed_versions
                 get :index, :project_id => 1, :completed => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:versions)
                 # Version with no date set appears
                 assert assigns(:versions).include?(Version.find(3))
                 # Completed version appears
                 assert assigns(:versions).include?(Version.find(1))
               end
               def test_index_with_tracker_ids
                 get :index, :project_id => 1, :tracker_ids => [1, 3]
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:issues_by_version)
                 assert_nil assigns(:issues_by_version).values.flatten.detect {|issue| issue.tracker_id == 2}
               end
               def test_index_showing_subprojects_versions
                 @subproject_version = Version.create!(:project => Project.find(3), :name => "Subproject version")
                 get :index, :project_id => 1, :with_subprojects => 1
                 assert_response :success
                 assert_template 'index'
                 assert_not_nil assigns(:versions)
                 assert assigns(:versions).include?(Version.find(4)), "Shared version not found"
                 assert assigns(:versions).include?(@subproject_version), "Subproject version not found"
               end
               def test_show
                 get :show, :id => 2
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:version)
                 assert_tag :tag => 'h2', :content => /1.0/
               end
               def test_new
                 @request.session[:user_id] = 2
                 get :new, :project_id => '1'
                 assert_response :success
                 assert_template 'new'
               end
               def test_new_from_issue_form
                 @request.session[:user_id] = 2
                 xhr :get, :new, :project_id => '1'
                 assert_response :success
-                assert_select_rjs :replace_html, "ajax-modal" do
+                assert_template 'new'
-                  assert_select "form[action=/projects/ecookbook/versions]"
+                assert_equal 'text/javascript', response.content_type
-                  assert_select "input#version_name"
-                end
               end
               def test_create
                 @request.session[:user_id] = 2 # manager
                 assert_difference 'Version.count' do
                   post :create, :project_id => '1', :version => {:name => 'test_add_version'}
                 end
                 assert_redirected_to '/projects/ecookbook/settings/versions'
                 version = Version.find_by_name('test_add_version')
                 assert_not_nil version
                 assert_equal 1, version.project_id
               end
               def test_create_from_issue_form
                 @request.session[:user_id] = 2
                 assert_difference 'Version.count' do
                   xhr :post, :create, :project_id => '1', :version => {:name => 'test_add_version_from_issue_form'}
                 end
                 version = Version.find_by_name('test_add_version_from_issue_form')
                 assert_not_nil version
                 assert_equal 1, version.project_id
                 assert_response :success
-                assert_select_rjs :replace, 'issue_fixed_version_id' do
+                assert_template 'create'
-                  assert_select "option[value=#{version.id}][selected=selected]"
+                assert_equal 'text/javascript', response.content_type
-                end
               end
               def test_create_from_issue_form_with_failure
                 @request.session[:user_id] = 2
                 assert_no_difference 'Version.count' do
                   xhr :post, :create, :project_id => '1', :version => {:name => ''}
                 end
                 assert_response :success
-                assert_select_rjs :replace_html, "ajax-modal" do
+                assert_template 'new'
-                  assert_select "div#errorExplanation"
+                assert_equal 'text/javascript', response.content_type
-                end
               end
               def test_get_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 2
                 assert_response :success
                 assert_template 'edit'
               end
               def test_close_completed
                 Version.update_all("status = 'open'")
                 @request.session[:user_id] = 2
                 put :close_completed, :project_id => 'ecookbook'
                 assert_redirected_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => 'ecookbook'
                 assert_not_nil Version.find_by_status('closed')
               end
               def test_post_update
                 @request.session[:user_id] = 2
                 put :update, :id => 2,
                             :version => { :name => 'New version name',
                                           :effective_date => Date.today.strftime("%Y-%m-%d")}
                 assert_redirected_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => 'ecookbook'
                 version = Version.find(2)
                 assert_equal 'New version name', version.name
                 assert_equal Date.today, version.effective_date
               end
               def test_post_update_with_validation_failure
                 @request.session[:user_id] = 2
                 put :update, :id => 2,
                              :version => { :name => '',
                                            :effective_date => Date.today.strftime("%Y-%m-%d")}
                 assert_response :success
                 assert_template 'edit'
               end
               def test_destroy
                 @request.session[:user_id] = 2
                 assert_difference 'Version.count', -1 do
                   delete :destroy, :id => 3
                 end
                 assert_redirected_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => 'ecookbook'
                 assert_nil Version.find_by_id(3)
               end
               def test_destroy_version_in_use_should_fail
                 @request.session[:user_id] = 2
                 assert_no_difference 'Version.count' do
                   delete :destroy, :id => 2
                 end
                 assert_redirected_to :controller => 'projects', :action => 'settings', :tab => 'versions', :id => 'ecookbook'
                 assert flash[:error].match(/Unable to delete version/)
                 assert Version.find_by_id(2)
               end
               def test_issue_status_by
                 xhr :get, :status_by, :id => 2
                 assert_response :success
                 assert_template '_issue_counts'
               end
               def test_issue_status_by_status
                 xhr :get, :status_by, :id => 2, :status_by => 'status'
                 assert_response :success
                 assert_template '_issue_counts'
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages