From 93ef8b7f77ec84bef19d7a872a15b8d406cdb46e 2008-02-11 20:45:46
From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: 2008-02-11 20:45:46
Subject: [PATCH] Replaced window.hash= by Element.scrollTo()

git-svn-id: http://redmine.rubyforge.org/svn/trunk@1136 e93f8b46-1217-0410-a6f0-8f06a7374b81

---

diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index c8b55a6..791c6d8 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -59,7 +59,7 @@ module ApplicationHelper
   def show_and_goto_link(name, id, options={})
     onclick = "Element.show('#{id}'); "
     onclick << (options[:focus] ? "Form.Element.focus('#{options[:focus]}'); " : "this.blur(); ")
-    onclick << "location.href='##{id}-anchor'; "
+    onclick << "Element.scrollTo('#{id}'); "
     onclick << "return false;"
     link_to(name, "#", options.merge(:onclick => onclick))
   end
diff --git a/app/views/issues/_edit.rhtml b/app/views/issues/_edit.rhtml
index 0f843e8..5bd685e 100644
--- a/app/views/issues/_edit.rhtml
+++ b/app/views/issues/_edit.rhtml
@@ -32,7 +32,7 @@
                          :method => 'post',
                          :update => 'preview',
                          :with => 'Form.serialize("issue-form")',
-                         :complete => "location.hash='preview'"
+                         :complete => "Element.scrollTo('preview')"
                        }, :accesskey => accesskey(:preview) %>
 <% end %>
 
diff --git a/app/views/issues/new.rhtml b/app/views/issues/new.rhtml
index 1e9e323..52c32db 100644
--- a/app/views/issues/new.rhtml
+++ b/app/views/issues/new.rhtml
@@ -12,9 +12,8 @@
                          :method => 'post',
                          :update => 'preview',
                          :with => "Form.serialize('issue-form')",
-                         :complete => "location.href='#preview-top'"
+                         :complete => "Element.scrollTo('preview')"
                        }, :accesskey => accesskey(:preview) %>
 <% end %>
 
-<a name="preview-top"></a>
 <div id="preview" class="wiki"></div>
diff --git a/app/views/issues/show.rhtml b/app/views/issues/show.rhtml
index 3392aef..e3999bd 100644
--- a/app/views/issues/show.rhtml
+++ b/app/views/issues/show.rhtml
@@ -89,7 +89,6 @@ end %>
 <% end %>
 
 <% if authorize_for('issues', 'edit') %>
-  <a name="update-anchor"></a>
   <div id="update" style="display:none;">
   <h3><%= l(:button_update) %></h3>
   <%= render :partial => 'edit' %>
diff --git a/app/views/wiki/edit.rhtml b/app/views/wiki/edit.rhtml
index 1027626..e5b0687 100644
--- a/app/views/wiki/edit.rhtml
+++ b/app/views/wiki/edit.rhtml
@@ -16,12 +16,11 @@
                          :method => 'post',
                          :update => 'preview',
                          :with => "Form.serialize('wiki_form')",
-                         :complete => "location.href='#preview-top'"
+                         :complete => "Element.scrollTo('preview')"
                        }, :accesskey => accesskey(:preview) %></p>
 <%= wikitoolbar_for 'content_text' %>
 <% end %>
 
-<a name="preview-top"></a>
 <div id="preview" class="wiki"></div>
 
 <% content_for :header_tags do %>