From 888823a449d9694060a22c09d8d73b2f652e62bb 2014-01-31 17:42:46
From: Jean-Philippe Lang <jp_lang@yahoo.fr>
Date: 2014-01-31 17:42:46
Subject: [PATCH] Fixed calculation of done_ratio of parent task with child having estimated_time at 0 (#15870).

git-svn-id: http://svn.redmine.org/redmine/trunk@12745 e93f8b46-1217-0410-a6f0-8f06a7374b81

---

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 106b7e7..debb931 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -1355,7 +1355,7 @@ class Issue < ActiveRecord::Base
       unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
         leaves_count = p.leaves.count
         if leaves_count > 0
-          average = p.leaves.average(:estimated_hours).to_f
+          average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
           if average == 0
             average = 1
           end
diff --git a/test/unit/issue_nested_set_test.rb b/test/unit/issue_nested_set_test.rb
index 8c40f89..4a41c49 100644
--- a/test/unit/issue_nested_set_test.rb
+++ b/test/unit/issue_nested_set_test.rb
@@ -368,6 +368,18 @@ class IssueNestedSetTest < ActiveSupport::TestCase
     assert_equal 100, parent.reload.done_ratio
   end
 
+  def test_done_ratio_of_parent_with_a_child_with_estimated_time_at_0_should_not_exceed_100
+    parent = Issue.generate!
+    Issue.generate!(:estimated_hours => 40, :parent_issue_id => parent.id)
+    Issue.generate!(:estimated_hours => 40, :parent_issue_id => parent.id)
+    Issue.generate!(:estimated_hours => 20, :parent_issue_id => parent.id)
+    Issue.generate!(:estimated_hours => 0, :parent_issue_id => parent.id)
+    parent.reload.children.each do |child|
+      child.update_attribute :status_id, 5
+    end
+    assert_equal 100, parent.reload.done_ratio
+  end
+
   def test_move_parent_updates_old_parent_attributes
     first_parent = Issue.generate!
     second_parent = Issue.generate!