diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index c54858b..e1505f8 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1165,7 +1165,7 @@ module ApplicationHelper end end - def context_menu(url) + def context_menu unless @context_menu_included content_for :header_tags do javascript_include_tag('context_menu') + @@ -1178,7 +1178,7 @@ module ApplicationHelper end @context_menu_included = true end - javascript_tag "contextMenuInit('#{ url_for(url) }')" + nil end def calendar_for(field_id) diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index 08611c9..72f33da 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -90,7 +90,7 @@ module IssuesHelper end def render_descendants_tree(issue) - s = '
' + s = '
' issue_list(issue.descendants.visible.preload(:status, :priority, :tracker, :assigned_to).sort_by(&:lft)) do |child, level| css = "issue issue-#{child.id} hascontextmenu #{child.css_classes}" css << " idnt idnt-#{level}" if level > 0 @@ -102,7 +102,7 @@ module IssuesHelper content_tag('td', child.disabled_core_fields.include?('done_ratio') ? '' : progress_bar(child.done_ratio), :class=> 'done_ratio'), :class => css) end - s << '
' + s << '' s.html_safe end diff --git a/app/views/issues/_list.html.erb b/app/views/issues/_list.html.erb index 2376a84..851fca1 100644 --- a/app/views/issues/_list.html.erb +++ b/app/views/issues/_list.html.erb @@ -1,4 +1,4 @@ -<%= form_tag({}) do -%> +<%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do -%> <%= hidden_field_tag 'back_url', url_for(:params => request.query_parameters), :id => nil %>
diff --git a/app/views/issues/_list_simple.html.erb b/app/views/issues/_list_simple.html.erb index 8ce273d..0d2850c 100644 --- a/app/views/issues/_list_simple.html.erb +++ b/app/views/issues/_list_simple.html.erb @@ -1,5 +1,5 @@ <% if issues && issues.any? %> -<%= form_tag({}) do %> +<%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do %>
diff --git a/app/views/issues/_relations.html.erb b/app/views/issues/_relations.html.erb index dcf0795..cab1d0c 100644 --- a/app/views/issues/_relations.html.erb +++ b/app/views/issues/_relations.html.erb @@ -7,7 +7,7 @@

<%=l(:label_related_issues)%>

<% if @relations.present? %> - +<%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do %>
#
<% @relations.each do |relation| %> <% other_issue = relation.other_issue(@issue) -%> @@ -30,7 +30,7 @@ <% end %>
- +<% end %> <% end %> <%= form_for @relation, { diff --git a/app/views/issues/index.html.erb b/app/views/issues/index.html.erb index d0fd943..a9f321c 100644 --- a/app/views/issues/index.html.erb +++ b/app/views/issues/index.html.erb @@ -69,4 +69,4 @@ :title => l(:label_changes_details)) %> <% end %> -<%= context_menu issues_context_menu_path %> +<%= context_menu %> diff --git a/app/views/issues/show.html.erb b/app/views/issues/show.html.erb index f884905..b9e5111 100644 --- a/app/views/issues/show.html.erb +++ b/app/views/issues/show.html.erb @@ -96,7 +96,9 @@ end %> <%= link_to_new_subtask(@issue) if User.current.allowed_to?(:manage_subtasks, @project) %>

<%=l(:label_subtask_plural)%>

+<%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do %> <%= render_descendants_tree(@issue) unless @issue.leaf? %> +<% end %> <% end %> @@ -157,4 +159,4 @@ end %> <%= auto_discovery_link_tag(:atom, {:format => 'atom', :key => User.current.rss_key}, :title => "#{@issue.project} - #{@issue.tracker} ##{@issue.id}: #{@issue.subject}") %> <% end %> -<%= context_menu issues_context_menu_path %> +<%= context_menu %> diff --git a/app/views/my/page.html.erb b/app/views/my/page.html.erb index a9a02be..d5b8e3e 100644 --- a/app/views/my/page.html.erb +++ b/app/views/my/page.html.erb @@ -16,6 +16,6 @@ <%= render_blocks(@blocks['right'], @user) %> -<%= context_menu issues_context_menu_path %> +<%= context_menu %> <% html_title(l(:label_my_page)) -%> diff --git a/app/views/timelog/_list.html.erb b/app/views/timelog/_list.html.erb index be02adb..3721df2 100644 --- a/app/views/timelog/_list.html.erb +++ b/app/views/timelog/_list.html.erb @@ -1,4 +1,4 @@ -<%= form_tag({}) do -%> +<%= form_tag({}, :data => {:cm_url => time_entries_context_menu_path}) do -%> <%= hidden_field_tag 'back_url', url_for(:params => request.query_parameters), :id => nil %>
@@ -60,4 +60,4 @@ <% end -%> -<%= context_menu time_entries_context_menu_path %> +<%= context_menu %> diff --git a/app/views/versions/index.html.erb b/app/views/versions/index.html.erb index 0f1d0b8..ab61820 100644 --- a/app/views/versions/index.html.erb +++ b/app/views/versions/index.html.erb @@ -23,7 +23,7 @@ <%= render(:partial => "wiki/content", :locals => {:content => version.wiki_page.content}) if version.wiki_page %> <% if (issues = @issues_by_version[version]) && issues.size > 0 %> - <%= form_tag({}) do -%> + <%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do -%>
<% issues.each do |issue| -%> @@ -99,4 +99,4 @@ <% html_title(l(:label_roadmap)) %> -<%= context_menu issues_context_menu_path %> +<%= context_menu %> diff --git a/app/views/versions/show.html.erb b/app/views/versions/show.html.erb index f018c2d..638a17a 100644 --- a/app/views/versions/show.html.erb +++ b/app/views/versions/show.html.erb @@ -36,7 +36,7 @@ <% if @issues.present? %> -<%= form_tag({}) do -%> +<%= form_tag({}, :data => {:cm_url => issues_context_menu_path}) do -%> <%- @issues.each do |issue| -%> @@ -47,7 +47,7 @@ <% end %> <% end %> -<%= context_menu issues_context_menu_path %> +<%= context_menu %> <% end %>
diff --git a/public/javascripts/context_menu.js b/public/javascripts/context_menu.js index ca2a9be..6fd509e 100644 --- a/public/javascripts/context_menu.js +++ b/public/javascripts/context_menu.js @@ -2,7 +2,6 @@ Copyright (C) 2006-2016 Jean-Philippe Lang */ var contextMenuObserving; -var contextMenuUrl; function contextMenuRightClick(event) { var target = $(event.target); @@ -98,13 +97,16 @@ function contextMenuShow(event) { var window_height; var max_width; var max_height; + var url; $('#context-menu').css('left', (render_x + 'px')); $('#context-menu').css('top', (render_y + 'px')); $('#context-menu').html(''); + url = $(event.target).parents('form').first().data('cm-url'); + $.ajax({ - url: contextMenuUrl, + url: url, data: $(event.target).parents('form').first().serialize(), success: function(data, textStatus, jqXHR) { $('#context-menu').html(data); @@ -208,8 +210,7 @@ function contextMenuClearDocumentSelection() { } } -function contextMenuInit(url) { - contextMenuUrl = url; +function contextMenuInit() { contextMenuCreate(); contextMenuUnselectAll(); @@ -243,5 +244,6 @@ function window_size() { } $(document).ready(function(){ + contextMenuInit(); $('input[type=checkbox].toggle-selection').on('change', toggleIssuesSelection); }); diff --git a/test/functional/versions_controller_test.rb b/test/functional/versions_controller_test.rb index d794cf3..c2f054e 100644 --- a/test/functional/versions_controller_test.rb +++ b/test/functional/versions_controller_test.rb @@ -36,7 +36,7 @@ class VersionsControllerTest < Redmine::ControllerTest assert_select 'h3', :text => Version.find(1).name, :count => 0 # Context menu on issues - assert_select "script", :text => Regexp.new(Regexp.escape("contextMenuInit('/issues/context_menu')")) + assert_select "form[data-cm-url=?]", '/issues/context_menu' assert_select "div#sidebar" do # Links to versions anchors assert_select 'a[href=?]', '#2.0'