diff --git a/app/controllers/issues_controller.rb b/app/controllers/issues_controller.rb index 4238215..e8e1e3c 100644 --- a/app/controllers/issues_controller.rb +++ b/app/controllers/issues_controller.rb @@ -79,7 +79,7 @@ class IssuesController < ApplicationController Issue.load_visible_relations(@issues) if include_in_api_response?('relations') } format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") } - format.csv { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') } + format.csv { send_data(query_to_csv(@issues, @query, params[:csv]), :type => 'text/csv; header=present', :filename => 'issues.csv') } format.pdf { send_file_headers! :type => 'application/pdf', :filename => 'issues.pdf' } end else diff --git a/app/helpers/queries_helper.rb b/app/helpers/queries_helper.rb index f817265..865b950 100644 --- a/app/helpers/queries_helper.rb +++ b/app/helpers/queries_helper.rb @@ -184,6 +184,7 @@ module QueriesHelper end def query_to_csv(items, query, options={}) + options ||= {} columns = (options[:columns] == 'all' ? query.available_inline_columns : query.inline_columns) query.available_block_columns.each do |column| if options[column.name].present? diff --git a/app/views/issues/index.html.erb b/app/views/issues/index.html.erb index f08f76d..de87c5e 100644 --- a/app/views/issues/index.html.erb +++ b/app/views/issues/index.html.erb @@ -79,11 +79,11 @@
-
-
+
+
- +
<% if @issue_count > Setting.issues_export_limit.to_i %>diff --git a/test/functional/issues_controller_test.rb b/test/functional/issues_controller_test.rb index 390da19..b2e4965 100644 --- a/test/functional/issues_controller_test.rb +++ b/test/functional/issues_controller_test.rb @@ -449,7 +449,7 @@ class IssuesControllerTest < ActionController::TestCase Issue.generate!(:description => 'test_index_csv_with_description') with_settings :default_language => 'en' do - get :index, :format => 'csv', :description => '1' + get :index, :format => 'csv', :csv => {:description => '1'} assert_response :success assert_not_nil assigns(:issues) end @@ -472,7 +472,7 @@ class IssuesControllerTest < ActionController::TestCase end def test_index_csv_with_all_columns - get :index, :format => 'csv', :columns => 'all' + get :index, :format => 'csv', :csv => {:columns => 'all'} assert_response :success assert_not_nil assigns(:issues) assert_equal 'text/csv; header=present', @response.content_type @@ -487,7 +487,7 @@ class IssuesControllerTest < ActionController::TestCase issue.custom_field_values = {1 => ['MySQL', 'Oracle']} issue.save! - get :index, :format => 'csv', :columns => 'all' + get :index, :format => 'csv', :csv => {:columns => 'all'} assert_response :success lines = @response.body.chomp.split("\n") assert lines.detect {|line| line.include?('"MySQL, Oracle"')} @@ -498,14 +498,14 @@ class IssuesControllerTest < ActionController::TestCase issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'}) with_settings :default_language => 'fr' do - get :index, :format => 'csv', :columns => 'all' + get :index, :format => 'csv', :csv => {:columns => 'all'} assert_response :success issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s} assert_include '185,60', issue_line end with_settings :default_language => 'en' do - get :index, :format => 'csv', :columns => 'all' + get :index, :format => 'csv', :csv => {:columns => 'all'} assert_response :success issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s} assert_include '185.60', issue_line