##// END OF EJS Templates
jro_apps » redmine
RSS
Speeds up rendering of the project list for users who belong to hundreds of projects....
Speeds up rendering of the project list for users who belong to hundreds of projects. git-svn-id: http://svn.redmine.org/redmine/trunk@16123 e93f8b46-1217-0410-a6f0-8f06a7374b81
Jean-Philippe Lang - - Load All Authors

File last commit:

r15704:831a2d58aba5
r15741:f8df935dcada
Show More
attachment_test.rb
433 lines | 15.6 KiB | text/x-ruby | RubyLexer
/ test / unit / attachment_test.rb
History | Source | Raw |Copy content |Copy permalink
Jean-Philippe Lang
Sets file encoding to utf-8 for ruby 1.9....
 r2796 # encoding: utf-8
#
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724 # Redmine - project management software
Jean-Philippe Lang
Updates copyright for 2016....
 r14856 # Copyright (C) 2006-2016 Jean-Philippe Lang
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 #
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724 #
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 # This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724 #
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 # You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
Jean-Baptiste Barth
Use absolute paths in test/**/* requires for Ruby 1.9.2 compatibility. #4050...
 r4395 require File.expand_path('../../test_helper', __FILE__)
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418
Eric Davis
Upgraded to Rails 2.3.4 (#3597)...
 r2773 class AttachmentTest < ActiveSupport::TestCase
Jean-Philippe Lang
Removes attachment from disk after rollback on create (#21125)....
 r14703 fixtures :users, :email_addresses, :projects, :roles, :members, :member_roles,
Toshi MARUYAMA
add missing fixtures at unit attachment test...
 r7789 :enabled_modules, :issues, :trackers, :attachments
Toshi MARUYAMA
remove trailing white-spaces from test/unit/attachment_test.rb...
 r12101
Jean-Philippe Lang
Remove attachment after transaction commit (#20388)....
 r14248 # TODO: remove this with Rails 5 that supports after_commit callbacks
# in transactional fixtures (https://github.com/rails/rails/pull/18458)
self.use_transactional_fixtures = false
Jean-Philippe Lang
Limit the characters stripped by Attachment#sanitize_filename (#4324)....
 r7797 class MockFile
attr_reader :original_filename, :content_type, :content, :size
Toshi MARUYAMA
remove trailing white-spaces from test/unit/attachment_test.rb...
 r12101
Jean-Philippe Lang
Limit the characters stripped by Attachment#sanitize_filename (#4324)....
 r7797 def initialize(attributes)
@original_filename = attributes[:original_filename]
@content_type = attributes[:content_type]
@content = attributes[:content] || "Content"
@size = content.size
end
end
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 def setup
Toshi MARUYAMA
use temporary attachments directory in unit attachment test...
 r7772 set_tmp_attachments_directory
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 end
Jean-Philippe Lang
Fixes memory consumption on file upload (#3116)....
 r2578
Jean-Philippe Lang
Better handling of attachments when issue validation fails (#10253)....
 r8771 def test_container_for_new_attachment_should_be_nil
assert_nil Attachment.new.container
end
Jean-Philippe Lang
Strip eols from file names (#14819)....
 r11898 def test_filename_should_remove_eols
assert_equal "line_feed", Attachment.new(:filename => "line\nfeed").filename
assert_equal "line_feed", Attachment.new(:filename => "some\npath/line\nfeed").filename
assert_equal "carriage_return", Attachment.new(:filename => "carriage\rreturn").filename
assert_equal "carriage_return", Attachment.new(:filename => "some\rpath/carriage\rreturn").filename
end
Jean-Philippe Lang
Fixes memory consumption on file upload (#3116)....
 r2578 def test_create
a = Attachment.new(:container => Issue.find(1),
Jean-Philippe Lang
Renames uploaded_test_file helper....
 r2795 :file => uploaded_test_file("testfile.txt", "text/plain"),
Jean-Philippe Lang
Fixes memory consumption on file upload (#3116)....
 r2578 :author => User.find(1))
assert a.save
assert_equal 'testfile.txt', a.filename
assert_equal 59, a.filesize
assert_equal 'text/plain', a.content_type
assert_equal 0, a.downloads
Jean-Philippe Lang
Safer assertion....
 r4478 assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
Jean-Philippe Lang
Store attachments in subdirectories (#5298)....
 r10761
assert a.disk_directory
assert_match %r{\A\d{4}/\d{2}\z}, a.disk_directory
Jean-Philippe Lang
Fixes memory consumption on file upload (#3116)....
 r2578 assert File.exist?(a.diskfile)
Jean-Philippe Lang
Fixed: file uploads broken by r6312 (#8912)....
 r6200 assert_equal 59, File.size(a.diskfile)
Jean-Philippe Lang
Fixes memory consumption on file upload (#3116)....
 r2578 end
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724
Jean-Philippe Lang
Adds some Attachment tests....
 r13327 def test_create_should_clear_content_type_if_too_long
a = Attachment.new(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1),
:content_type => 'a'*300)
assert a.save
a.reload
assert_nil a.content_type
end
Jean-Philippe Lang
Restrict the length attachment filenames on disk (#24186)....
 r15701 def test_shorted_filename_if_too_long
Jean-Philippe Lang
Test cleanup....
 r15703 file = mock_file_with_options(:original_filename => "#{'a'*251}.txt")
Jean-Philippe Lang
Restrict the length attachment filenames on disk (#24186)....
 r15701
a = Attachment.new(:container => Issue.find(1),
:file => file,
:author => User.find(1))
assert a.save
a.reload
assert_equal 12 + 1 + 32 + 4, a.disk_filename.length
Jean-Philippe Lang
Test cleanup....
 r15703 assert_equal 255, a.filename.length
Jean-Philippe Lang
Restrict the length attachment filenames on disk (#24186)....
 r15701 end
Jean-Philippe Lang
Store attachments in subdirectories (#5298)....
 r10761 def test_copy_should_preserve_attributes
a = Attachment.find(1)
copy = a.copy
assert_save copy
copy = Attachment.order('id DESC').first
%w(filename filesize content_type author_id created_on description digest disk_filename disk_directory diskfile).each do |attribute|
assert_equal a.send(attribute), copy.send(attribute), "#{attribute} was different"
end
end
Jean-Philippe Lang
Copy attachments on issue and project copy (#3055)....
 r8556 def test_size_should_be_validated_for_new_file
with_settings :attachment_max_size => 0 do
a = Attachment.new(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1))
assert !a.save
end
end
def test_size_should_not_be_validated_when_copying
a = Attachment.create!(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1))
with_settings :attachment_max_size => 0 do
copy = a.copy
assert copy.save
end
end
Jean-Philippe Lang
Extend Filesize in the attachments table for files with size > 2GB (#10672)....
 r14327 def test_filesize_greater_than_2gb_should_be_supported
with_settings :attachment_max_size => (50.gigabyte / 1024) do
a = Attachment.create!(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1))
a.filesize = 20.gigabyte
a.save!
assert_equal 20.gigabyte, a.reload.filesize
end
end
Jean-Philippe Lang
Files upload restriction by files extensions (#20008)....
 r14410 def test_extension_should_be_validated_against_allowed_extensions
with_settings :attachment_extensions_allowed => "txt, png" do
a = Attachment.new(:container => Issue.find(1),
:file => mock_file_with_options(:original_filename => "test.png"),
:author => User.find(1))
assert_save a
a = Attachment.new(:container => Issue.find(1),
:file => mock_file_with_options(:original_filename => "test.jpeg"),
:author => User.find(1))
assert !a.save
end
end
def test_extension_should_be_validated_against_denied_extensions
with_settings :attachment_extensions_denied => "txt, png" do
a = Attachment.new(:container => Issue.find(1),
:file => mock_file_with_options(:original_filename => "test.jpeg"),
:author => User.find(1))
assert_save a
a = Attachment.new(:container => Issue.find(1),
:file => mock_file_with_options(:original_filename => "test.png"),
:author => User.find(1))
assert !a.save
end
end
def test_valid_extension_should_be_case_insensitive
with_settings :attachment_extensions_allowed => "txt, Png" do
assert Attachment.valid_extension?(".pnG")
assert !Attachment.valid_extension?(".jpeg")
end
with_settings :attachment_extensions_denied => "txt, Png" do
assert !Attachment.valid_extension?(".pnG")
assert Attachment.valid_extension?(".jpeg")
end
end
Jean-Philippe Lang
Validate attachment description length (#11365)....
 r9801 def test_description_length_should_be_validated
a = Attachment.new(:description => 'a' * 300)
assert !a.save
Toshi MARUYAMA
not use assert_not_nil in Errors#[]...
 r11840 assert_not_equal [], a.errors[:description]
Jean-Philippe Lang
Validate attachment description length (#11365)....
 r9801 end
Toshi MARUYAMA
add test to destroy at unit attachment test....
 r6642 def test_destroy
a = Attachment.new(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1))
assert a.save
assert_equal 'testfile.txt', a.filename
assert_equal 59, a.filesize
assert_equal 'text/plain', a.content_type
assert_equal 0, a.downloads
assert_equal '1478adae0d4eb06d35897518540e25d6', a.digest
diskfile = a.diskfile
assert File.exist?(diskfile)
assert_equal 59, File.size(a.diskfile)
assert a.destroy
assert !File.exist?(diskfile)
end
Jean-Philippe Lang
Copy attachments on issue and project copy (#3055)....
 r8556 def test_destroy_should_not_delete_file_referenced_by_other_attachment
a = Attachment.create!(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", "text/plain"),
:author => User.find(1))
diskfile = a.diskfile
copy = a.copy
copy.save!
assert File.exists?(diskfile)
a.destroy
assert File.exists?(diskfile)
copy.destroy
assert !File.exists?(diskfile)
end
Jean-Philippe Lang
Auto-detect attachment content type when blank (#3782)....
 r3144 def test_create_should_auto_assign_content_type
a = Attachment.new(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", ""),
:author => User.find(1))
assert a.save
assert_equal 'text/plain', a.content_type
end
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724
Jean-Philippe Lang
Fixed: attachments with the same name at the same time overwrite (#3691)....
 r3397 def test_identical_attachments_at_the_same_time_should_not_overwrite
a1 = Attachment.create!(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", ""),
:author => User.find(1))
a2 = Attachment.create!(:container => Issue.find(1),
:file => uploaded_test_file("testfile.txt", ""),
:author => User.find(1))
assert a1.disk_filename != a2.disk_filename
end
Toshi MARUYAMA
remove trailing white-spaces from test/unit/attachment_test.rb...
 r12101
Jean-Philippe Lang
Limit the characters stripped by Attachment#sanitize_filename (#4324)....
 r7797 def test_filename_should_be_basenamed
a = Attachment.new(:file => MockFile.new(:original_filename => "path/to/the/file"))
assert_equal 'file', a.filename
end
Toshi MARUYAMA
remove trailing white-spaces from test/unit/attachment_test.rb...
 r12101
Jean-Philippe Lang
Limit the characters stripped by Attachment#sanitize_filename (#4324)....
 r7797 def test_filename_should_be_sanitized
a = Attachment.new(:file => MockFile.new(:original_filename => "valid:[] invalid:?%*|\"'<>chars"))
assert_equal 'valid_[] invalid_chars', a.filename
end
Toshi MARUYAMA
remove trailing white-spaces from unit attachment test....
 r5724
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 def test_diskfilename
assert Attachment.disk_filename("test_file.txt") =~ /^\d{12}_test_file.txt$/
assert_equal 'test_file.txt', Attachment.disk_filename("test_file.txt")[13..-1]
assert_equal '770c509475505f37c2b8fb6030434d6b.txt', Attachment.disk_filename("test_accentué.txt")[13..-1]
assert_equal 'f8139524ebb8f32e51976982cd20a85d', Attachment.disk_filename("test_accentué")[13..-1]
assert_equal 'cbb5b0f30978ba03731d61f9f6d10011', Attachment.disk_filename("test_accentué.ça")[13..-1]
end
Eric Davis
Fix a nil error when a Project cannot save attachments....
 r3658
Jean-Philippe Lang
Adds Attachment#title....
 r9829 def test_title
a = Attachment.new(:filename => "test.png")
assert_equal "test.png", a.title
a = Attachment.new(:filename => "test.png", :description => "Cool image")
assert_equal "test.png (Cool image)", a.title
end
Jean-Philippe Lang
Typo....
 r14247 def test_new_attachment_should_be_editable_by_author
Jean-Philippe Lang
Adds some Attachment tests....
 r13327 user = User.find(1)
a = Attachment.new(:author => user)
assert_equal true, a.editable?(user)
end
Jean-Philippe Lang
Adds a rake test that removes old unattached uploads (#10253)....
 r8773 def test_prune_should_destroy_old_unattached_attachments
Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1, :created_on => 2.days.ago)
Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1, :created_on => 2.days.ago)
Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1)
assert_difference 'Attachment.count', -2 do
Attachment.prune
end
end
Jean-Philippe Lang
Store attachments in subdirectories (#5298)....
 r10761 def test_move_from_root_to_target_directory_should_move_root_files
a = Attachment.find(20)
assert a.disk_directory.blank?
# Create a real file for this fixture
File.open(a.diskfile, "w") do |f|
f.write "test file at the root of files directory"
end
assert a.readable?
Attachment.move_from_root_to_target_directory
a.reload
assert_equal '2012/05', a.disk_directory
assert a.readable?
end
Jean-Philippe Lang
Removing shoulda context....
 r11085 test "Attachmnet.attach_files should attach the file" do
issue = Issue.first
assert_difference 'Attachment.count' do
Attachment.attach_files(issue,
'1' => {
'file' => uploaded_test_file('testfile.txt', 'text/plain'),
'description' => 'test'
})
Jean-Philippe Lang
Fixed: file uploads broken by r6312 (#8912)....
 r6200 end
Toshi MARUYAMA
Rails4: replace deprecated Relation#first with finder options at AttachmentTest...
 r12225 attachment = Attachment.order('id DESC').first
Jean-Philippe Lang
Removing shoulda context....
 r11085 assert_equal issue, attachment.container
assert_equal 'testfile.txt', attachment.filename
assert_equal 59, attachment.filesize
assert_equal 'test', attachment.description
assert_equal 'text/plain', attachment.content_type
assert File.exists?(attachment.diskfile)
assert_equal 59, File.size(attachment.diskfile)
end
test "Attachmnet.attach_files should add unsaved files to the object as unsaved attachments" do
# Max size of 0 to force Attachment creation failures
with_settings(:attachment_max_size => 0) do
@project = Project.find(1)
response = Attachment.attach_files(@project, {
'1' => {'file' => mock_file, 'description' => 'test'},
'2' => {'file' => mock_file, 'description' => 'test'}
})
assert response[:unsaved].present?
assert_equal 2, response[:unsaved].length
assert response[:unsaved].first.new_record?
assert response[:unsaved].second.new_record?
assert_equal response[:unsaved], @project.unsaved_attachments
Eric Davis
Fix a nil error when a Project cannot save attachments....
 r3658 end
end
Toshi MARUYAMA
move logic to use latest image file attachment to class method for common use (#3261)...
 r7788
Jean-Philippe Lang
Blank content type for attachments attached via Ajax file upload (Patch by Jens Krämer)....
 r12850 test "Attachment.attach_files should preserve the content_type of attachments added by token" do
@project = Project.find(1)
attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", ""), :author_id => 1, :created_on => 2.days.ago)
assert_equal 'text/plain', attachment.content_type
Attachment.attach_files(@project, { '1' => {'token' => attachment.token } })
attachment.reload
assert_equal 'text/plain', attachment.content_type
end
Jean-Philippe Lang
Edit attachments after upload (#1326)....
 r13283 def test_update_attachments
attachments = Attachment.where(:id => [2, 3]).to_a
assert Attachment.update_attachments(attachments, {
'2' => {:filename => 'newname.txt', :description => 'New description'},
3 => {:filename => 'othername.txt'}
})
attachment = Attachment.find(2)
assert_equal 'newname.txt', attachment.filename
assert_equal 'New description', attachment.description
attachment = Attachment.find(3)
assert_equal 'othername.txt', attachment.filename
end
def test_update_attachments_with_failure
attachments = Attachment.where(:id => [2, 3]).to_a
assert !Attachment.update_attachments(attachments, {
'2' => {:filename => '', :description => 'New description'},
3 => {:filename => 'othername.txt'}
})
attachment = Attachment.find(3)
assert_equal 'logo.gif', attachment.filename
end
def test_update_attachments_should_sanitize_filename
attachments = Attachment.where(:id => 2).to_a
assert Attachment.update_attachments(attachments, {
2 => {:filename => 'newname?.txt'},
})
attachment = Attachment.find(2)
assert_equal 'newname_.txt', attachment.filename
end
Toshi MARUYAMA
move logic to use latest image file attachment to class method for common use (#3261)...
 r7788 def test_latest_attach
Jean-Philippe Lang
Make sure that tests restore the attachments path to the tmp dir so that fixture files don't get deleted....
 r8128 set_fixtures_attachments_directory
Toshi MARUYAMA
move logic to use latest image file attachment to class method for common use (#3261)...
 r7788 a1 = Attachment.find(16)
assert_equal "testfile.png", a1.filename
assert a1.readable?
assert (! a1.visible?(User.anonymous))
assert a1.visible?(User.find(2))
a2 = Attachment.find(17)
assert_equal "testfile.PNG", a2.filename
assert a2.readable?
assert (! a2.visible?(User.anonymous))
assert a2.visible?(User.find(2))
assert a1.created_on < a2.created_on
la1 = Attachment.latest_attach([a1, a2], "testfile.png")
assert_equal 17, la1.id
la2 = Attachment.latest_attach([a1, a2], "Testfile.PNG")
assert_equal 17, la2.id
Toshi MARUYAMA
reset Attachment.storage_path at the end of attachment tests...
 r7791
set_tmp_attachments_directory
Toshi MARUYAMA
move logic to use latest image file attachment to class method for common use (#3261)...
 r7788 end
Jean-Philippe Lang
Displays thumbnails of attached images of the issue view (#1006)....
 r9750
Jean-Philippe Lang
Wrong syntax for resizing inline images may throw a 500 error (#20278)....
 r14091 def test_latest_attach_should_not_error_with_string_with_invalid_encoding
string = "width:50\xFE-Image.jpg".force_encoding('UTF-8')
assert_equal false, string.valid_encoding?
Attachment.latest_attach(Attachment.limit(2).to_a, string)
end
Jean-Philippe Lang
Displays thumbnails of attached images of the issue view (#1006)....
 r9750 def test_thumbnailable_should_be_true_for_images
assert_equal true, Attachment.new(:filename => 'test.jpg').thumbnailable?
end
def test_thumbnailable_should_be_true_for_non_images
assert_equal false, Attachment.new(:filename => 'test.txt').thumbnailable?
end
if convert_installed?
def test_thumbnail_should_generate_the_thumbnail
set_fixtures_attachments_directory
attachment = Attachment.find(16)
Attachment.clear_thumbnails
assert_difference "Dir.glob(File.join(Attachment.thumbnails_storage_path, '*.thumb')).size" do
thumbnail = attachment.thumbnail
assert_equal "16_8e0294de2441577c529f170b6fb8f638_100.thumb", File.basename(thumbnail)
assert File.exists?(thumbnail)
end
end
Jean-Philippe Lang
Adds some Attachment tests....
 r13327
def test_thumbnail_should_return_nil_if_generation_fails
Jean-Philippe Lang
Make sure that Redmine::Thumbnail.generate is called....
 r13332 Redmine::Thumbnail.expects(:generate).raises(SystemCallError, 'Something went wrong')
set_fixtures_attachments_directory
Jean-Philippe Lang
Adds some Attachment tests....
 r13327 attachment = Attachment.find(16)
assert_nil attachment.thumbnail
end
Jean-Philippe Lang
Displays thumbnails of attached images of the issue view (#1006)....
 r9750 else
puts '(ImageMagick convert not available)'
end
Jean-Philippe Lang
Fixed: possible error when attachment's filename is non-ASCII (#747, #1243, #1089)....
 r1418 end