issues_controller_test.rb
1332 lines
| 47.9 KiB
| text/x-ruby
|
RubyLexer
Jean-Philippe Lang
|
r1796 | # Redmine - project management software | ||
| # Copyright (C) 2006-2008 Jean-Philippe Lang | ||||
|
Jean-Philippe Lang
|
r874 | # | ||
| # This program is free software; you can redistribute it and/or | ||||
| # modify it under the terms of the GNU General Public License | ||||
| # as published by the Free Software Foundation; either version 2 | ||||
| # of the License, or (at your option) any later version. | ||||
| # | ||||
| # This program is distributed in the hope that it will be useful, | ||||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||||
| # GNU General Public License for more details. | ||||
| # | ||||
| # You should have received a copy of the GNU General Public License | ||||
| # along with this program; if not, write to the Free Software | ||||
| # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | ||||
Jean-Baptiste Barth
|
r4395 | require File.expand_path('../../test_helper', __FILE__) | ||
|
Jean-Philippe Lang
|
r874 | require 'issues_controller' | ||
| # Re-raise errors caught by the controller. | ||||
| class IssuesController; def rescue_action(e) raise e end; end | ||||
Eric Davis
|
r2773 | class IssuesControllerTest < ActionController::TestCase | ||
|
Jean-Philippe Lang
|
r974 | fixtures :projects, | ||
| :users, | ||||
| :roles, | ||||
| :members, | ||||
|
Jean-Philippe Lang
|
r2627 | :member_roles, | ||
|
Jean-Philippe Lang
|
r974 | :issues, | ||
| :issue_statuses, | ||||
|
Jean-Philippe Lang
|
r1826 | :versions, | ||
|
Jean-Philippe Lang
|
r974 | :trackers, | ||
|
Jean-Philippe Lang
|
r1066 | :projects_trackers, | ||
|
Jean-Philippe Lang
|
r974 | :issue_categories, | ||
| :enabled_modules, | ||||
| :enumerations, | ||||
|
Jean-Philippe Lang
|
r1030 | :attachments, | ||
|
Jean-Philippe Lang
|
r1076 | :workflows, | ||
| :custom_fields, | ||||
| :custom_values, | ||||
|
Jean-Philippe Lang
|
r2987 | :custom_fields_projects, | ||
|
Jean-Philippe Lang
|
r1168 | :custom_fields_trackers, | ||
|
Jean-Philippe Lang
|
r1490 | :time_entries, | ||
| :journals, | ||||
|
Eric Davis
|
r2773 | :journal_details, | ||
| :queries | ||||
|
Jean-Philippe Lang
|
r874 | |||
| def setup | ||||
| @controller = IssuesController.new | ||||
| @request = ActionController::TestRequest.new | ||||
| @response = ActionController::TestResponse.new | ||||
| User.current = nil | ||||
| end | ||||
|
Eric Davis
|
r2315 | |||
|
Jean-Philippe Lang
|
r874 | def test_index | ||
|
Jean-Philippe Lang
|
r2498 | Setting.default_language = 'en' | ||
|
Jean-Philippe Lang
|
r874 | get :index | ||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_nil assigns(:project) | ||||
|
Jean-Philippe Lang
|
r1417 | assert_tag :tag => 'a', :content => /Can't print recipes/ | ||
| assert_tag :tag => 'a', :content => /Subproject issue/ | ||||
| # private projects hidden | ||||
| assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ | ||||
| assert_no_tag :tag => 'a', :content => /Issue on project 2/ | ||||
|
Jean-Philippe Lang
|
r2498 | # project column | ||
| assert_tag :tag => 'th', :content => /Project/ | ||||
|
Jean-Philippe Lang
|
r874 | end | ||
|
Jean-Philippe Lang
|
r1905 | |||
| def test_index_should_not_list_issues_when_module_disabled | ||||
| EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") | ||||
| get :index | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_nil assigns(:project) | ||||
| assert_no_tag :tag => 'a', :content => /Can't print recipes/ | ||||
| assert_tag :tag => 'a', :content => /Subproject issue/ | ||||
| end | ||||
|
Jean-Philippe Lang
|
r874 | |||
|
Eric Davis
|
r2315 | def test_index_should_not_list_issues_when_module_disabled | ||
| EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1") | ||||
| get :index | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_nil assigns(:project) | ||||
| assert_no_tag :tag => 'a', :content => /Can't print recipes/ | ||||
| assert_tag :tag => 'a', :content => /Subproject issue/ | ||||
| end | ||||
|
Jean-Philippe Lang
|
r874 | def test_index_with_project | ||
|
Jean-Philippe Lang
|
r1417 | Setting.display_subprojects_issues = 0 | ||
|
Jean-Philippe Lang
|
r874 | get :index, :project_id => 1 | ||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
|
Jean-Philippe Lang
|
r1417 | assert_tag :tag => 'a', :content => /Can't print recipes/ | ||
| assert_no_tag :tag => 'a', :content => /Subproject issue/ | ||||
| end | ||||
| def test_index_with_project_and_subprojects | ||||
| Setting.display_subprojects_issues = 1 | ||||
| get :index, :project_id => 1 | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_tag :tag => 'a', :content => /Can't print recipes/ | ||||
| assert_tag :tag => 'a', :content => /Subproject issue/ | ||||
| assert_no_tag :tag => 'a', :content => /Issue of a private subproject/ | ||||
| end | ||||
| def test_index_with_project_and_subprojects_should_show_private_subprojects | ||||
| @request.session[:user_id] = 2 | ||||
| Setting.display_subprojects_issues = 1 | ||||
| get :index, :project_id => 1 | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_tag :tag => 'a', :content => /Can't print recipes/ | ||||
| assert_tag :tag => 'a', :content => /Subproject issue/ | ||||
| assert_tag :tag => 'a', :content => /Issue of a private subproject/ | ||||
|
Jean-Philippe Lang
|
r874 | end | ||
|
Jean-Philippe Lang
|
r4273 | def test_index_with_project_and_default_filter | ||
|
Jean-Philippe Lang
|
r874 | get :index, :project_id => 1, :set_filter => 1 | ||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
|
Jean-Philippe Lang
|
r4273 | |||
| query = assigns(:query) | ||||
| assert_not_nil query | ||||
| # default filter | ||||
| assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters) | ||||
| end | ||||
| def test_index_with_project_and_filter | ||||
| get :index, :project_id => 1, :set_filter => 1, | ||||
| :fields => ['tracker_id'], | ||||
| :operators => {'tracker_id' => '='}, | ||||
| :values => {'tracker_id' => ['1']} | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| query = assigns(:query) | ||||
| assert_not_nil query | ||||
| assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters) | ||||
| end | ||||
| def test_index_with_project_and_empty_filters | ||||
| get :index, :project_id => 1, :set_filter => 1, :fields => [''] | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| query = assigns(:query) | ||||
| assert_not_nil query | ||||
| # no filter | ||||
| assert_equal({}, query.filters) | ||||
|
Jean-Philippe Lang
|
r874 | end | ||
|
Jean-Philippe Lang
|
r2604 | def test_index_with_query | ||
| get :index, :project_id => 1, :query_id => 5 | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_nil assigns(:issue_count_by_group) | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2957 | def test_index_with_query_grouped_by_tracker | ||
|
Jean-Philippe Lang
|
r2604 | get :index, :project_id => 1, :query_id => 6 | ||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
|
Jean-Philippe Lang
|
r2998 | assert_not_nil assigns(:issue_count_by_group) | ||
|
Jean-Philippe Lang
|
r2957 | end | ||
| def test_index_with_query_grouped_by_list_custom_field | ||||
| get :index, :project_id => 1, :query_id => 9 | ||||
| assert_response :success | ||||
| assert_template 'index.rhtml' | ||||
| assert_not_nil assigns(:issues) | ||||
|
Jean-Philippe Lang
|
r2998 | assert_not_nil assigns(:issue_count_by_group) | ||
|
Jean-Philippe Lang
|
r2604 | end | ||
|
Jean-Philippe Lang
|
r2982 | def test_index_sort_by_field_not_included_in_columns | ||
| Setting.issue_list_default_columns = %w(subject author) | ||||
| get :index, :sort => 'tracker' | ||||
| end | ||||
|
Jean-Philippe Lang
|
r874 | def test_index_csv_with_project | ||
|
Jean-Philippe Lang
|
r2893 | Setting.default_language = 'en' | ||
|
Jean-Philippe Lang
|
r874 | get :index, :format => 'csv' | ||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_equal 'text/csv', @response.content_type | ||||
|
Jean-Philippe Lang
|
r2893 | assert @response.body.starts_with?("#,") | ||
|
Jean-Philippe Lang
|
r874 | |||
| get :index, :project_id => 1, :format => 'csv' | ||||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_equal 'text/csv', @response.content_type | ||||
| end | ||||
| def test_index_pdf | ||||
| get :index, :format => 'pdf' | ||||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_equal 'application/pdf', @response.content_type | ||||
| get :index, :project_id => 1, :format => 'pdf' | ||||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_equal 'application/pdf', @response.content_type | ||||
|
Jean-Philippe Lang
|
r2604 | |||
| get :index, :project_id => 1, :query_id => 6, :format => 'pdf' | ||||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_equal 'application/pdf', @response.content_type | ||||
|
Jean-Philippe Lang
|
r874 | end | ||
|
Jean-Philippe Lang
|
r2169 | |||
|
Jean-Philippe Lang
|
r3219 | def test_index_pdf_with_query_grouped_by_list_custom_field | ||
| get :index, :project_id => 1, :query_id => 9, :format => 'pdf' | ||||
| assert_response :success | ||||
| assert_not_nil assigns(:issues) | ||||
| assert_not_nil assigns(:issue_count_by_group) | ||||
| assert_equal 'application/pdf', @response.content_type | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2169 | def test_index_sort | ||
|
Jean-Philippe Lang
|
r2509 | get :index, :sort => 'tracker,id:desc' | ||
|
Jean-Philippe Lang
|
r2169 | assert_response :success | ||
|
Jean-Philippe Lang
|
r2509 | sort_params = @request.session['issues_index_sort'] | ||
| assert sort_params.is_a?(String) | ||||
| assert_equal 'tracker,id:desc', sort_params | ||||
| issues = assigns(:issues) | ||||
| assert_not_nil issues | ||||
| assert !issues.empty? | ||||
| assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id) | ||||
|
Jean-Philippe Lang
|
r2169 | end | ||
|
Jean-Philippe Lang
|
r2991 | |||
| def test_index_with_columns | ||||
| columns = ['tracker', 'subject', 'assigned_to'] | ||||
| get :index, :set_filter => 1, :query => { 'column_names' => columns} | ||||
| assert_response :success | ||||
| # query should use specified columns | ||||
| query = assigns(:query) | ||||
| assert_kind_of Query, query | ||||
| assert_equal columns, query.column_names.map(&:to_s) | ||||
| # columns should be stored in session | ||||
| assert_kind_of Hash, session[:query] | ||||
| assert_kind_of Array, session[:query][:column_names] | ||||
| assert_equal columns, session[:query][:column_names].map(&:to_s) | ||||
| end | ||||
|
Jean-Philippe Lang
|
r1795 | |||
|
Jean-Philippe Lang
|
r1030 | def test_show_by_anonymous | ||
|
Jean-Philippe Lang
|
r971 | get :show, :id => 1 | ||
| assert_response :success | ||||
| assert_template 'show.rhtml' | ||||
| assert_not_nil assigns(:issue) | ||||
|
Jean-Philippe Lang
|
r1030 | assert_equal Issue.find(1), assigns(:issue) | ||
| # anonymous role is allowed to add a note | ||||
| assert_tag :tag => 'form', | ||||
| :descendant => { :tag => 'fieldset', | ||||
| :child => { :tag => 'legend', | ||||
| :content => /Notes/ } } | ||||
|
Jean-Philippe Lang
|
r971 | end | ||
|
Jean-Philippe Lang
|
r1030 | def test_show_by_manager | ||
| @request.session[:user_id] = 2 | ||||
| get :show, :id => 1 | ||||
| assert_response :success | ||||
|
Jean-Philippe Lang
|
r4416 | assert_tag :tag => 'a', | ||
| :content => /Quote/ | ||||
|
Jean-Philippe Lang
|
r1030 | assert_tag :tag => 'form', | ||
| :descendant => { :tag => 'fieldset', | ||||
| :child => { :tag => 'legend', | ||||
| :content => /Change properties/ } }, | ||||
| :descendant => { :tag => 'fieldset', | ||||
| :child => { :tag => 'legend', | ||||
| :content => /Log time/ } }, | ||||
| :descendant => { :tag => 'fieldset', | ||||
| :child => { :tag => 'legend', | ||||
| :content => /Notes/ } } | ||||
| end | ||||
|
Eric Davis
|
r2315 | |||
|
Jean-Philippe Lang
|
r2925 | def test_show_should_deny_anonymous_access_without_permission | ||
| Role.anonymous.remove_permission!(:view_issues) | ||||
| get :show, :id => 1 | ||||
| assert_response :redirect | ||||
| end | ||||
| def test_show_should_deny_non_member_access_without_permission | ||||
| Role.non_member.remove_permission!(:view_issues) | ||||
| @request.session[:user_id] = 9 | ||||
| get :show, :id => 1 | ||||
| assert_response 403 | ||||
| end | ||||
| def test_show_should_deny_member_access_without_permission | ||||
| Role.find(1).remove_permission!(:view_issues) | ||||
| @request.session[:user_id] = 2 | ||||
| get :show, :id => 1 | ||||
| assert_response 403 | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2341 | def test_show_should_not_disclose_relations_to_invisible_issues | ||
| Setting.cross_project_issue_relations = '1' | ||||
| IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates') | ||||
| # Relation to a private project issue | ||||
| IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates') | ||||
| get :show, :id => 1 | ||||
| assert_response :success | ||||
| assert_tag :div, :attributes => { :id => 'relations' }, | ||||
| :descendant => { :tag => 'a', :content => /#2$/ } | ||||
| assert_no_tag :div, :attributes => { :id => 'relations' }, | ||||
| :descendant => { :tag => 'a', :content => /#4$/ } | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2669 | def test_show_atom | ||
| get :show, :id => 2, :format => 'atom' | ||||
| assert_response :success | ||||
|
Eric Davis
|
r3920 | assert_template 'journals/index.rxml' | ||
|
Jean-Philippe Lang
|
r2669 | # Inline image | ||
|
Eric Davis
|
r3444 | assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10')) | ||
|
Jean-Philippe Lang
|
r2669 | end | ||
|
Jean-Philippe Lang
|
r2224 | def test_show_export_to_pdf | ||
|
Jean-Philippe Lang
|
r2260 | get :show, :id => 3, :format => 'pdf' | ||
|
Jean-Philippe Lang
|
r2224 | assert_response :success | ||
| assert_equal 'application/pdf', @response.content_type | ||||
| assert @response.body.starts_with?('%PDF') | ||||
| assert_not_nil assigns(:issue) | ||||
| end | ||||
|
Jean-Philippe Lang
|
r1066 | def test_get_new | ||
| @request.session[:user_id] = 2 | ||||
| get :new, :project_id => 1, :tracker_id => 1 | ||||
| assert_response :success | ||||
| assert_template 'new' | ||||
|
Jean-Philippe Lang
|
r1076 | |||
|
Jean-Philippe Lang
|
r1578 | assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]', | ||
|
Jean-Philippe Lang
|
r1076 | :value => 'Default string' } | ||
|
Jean-Philippe Lang
|
r1066 | end | ||
| def test_get_new_without_tracker_id | ||||
| @request.session[:user_id] = 2 | ||||
| get :new, :project_id => 1 | ||||
| assert_response :success | ||||
| assert_template 'new' | ||||
| issue = assigns(:issue) | ||||
| assert_not_nil issue | ||||
| assert_equal Project.find(1).trackers.first, issue.tracker | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2474 | def test_get_new_with_no_default_status_should_display_an_error | ||
| @request.session[:user_id] = 2 | ||||
| IssueStatus.delete_all | ||||
| get :new, :project_id => 1 | ||||
| assert_response 500 | ||||
|
Jean-Philippe Lang
|
r4172 | assert_error_tag :content => /No default issue/ | ||
|
Jean-Philippe Lang
|
r2474 | end | ||
| def test_get_new_with_no_tracker_should_display_an_error | ||||
| @request.session[:user_id] = 2 | ||||
| Tracker.delete_all | ||||
| get :new, :project_id => 1 | ||||
| assert_response 500 | ||||
|
Jean-Philippe Lang
|
r4172 | assert_error_tag :content => /No tracker/ | ||
|
Jean-Philippe Lang
|
r2474 | end | ||
|
Jean-Philippe Lang
|
r1066 | def test_update_new_form | ||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3897 | xhr :post, :new, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r1066 | :issue => {:tracker_id => 2, | ||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5} | ||||
| assert_response :success | ||||
|
Jean-Philippe Lang
|
r2994 | assert_template 'attributes' | ||
| issue = assigns(:issue) | ||||
| assert_kind_of Issue, issue | ||||
| assert_equal 1, issue.project_id | ||||
| assert_equal 2, issue.tracker_id | ||||
| assert_equal 'This is the test_new issue', issue.subject | ||||
| end | ||||
|
Jean-Philippe Lang
|
r1066 | |||
|
Eric Davis
|
r3574 | def test_post_create | ||
|
Jean-Philippe Lang
|
r1066 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r2773 | assert_difference 'Issue.count' do | ||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Eric Davis
|
r2773 | :issue => {:tracker_id => 3, | ||
|
Jean-Philippe Lang
|
r3492 | :status_id => 2, | ||
|
Eric Davis
|
r2773 | :subject => 'This is the test_new issue', | ||
| :description => 'This is the description', | ||||
| :priority_id => 5, | ||||
|
Jean-Philippe Lang
|
r4264 | :start_date => '2010-11-07', | ||
|
Eric Davis
|
r2773 | :estimated_hours => '', | ||
| :custom_field_values => {'2' => 'Value for field 2'}} | ||||
| end | ||||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id | ||||
|
Jean-Philippe Lang
|
r1076 | |||
| issue = Issue.find_by_subject('This is the test_new issue') | ||||
| assert_not_nil issue | ||||
| assert_equal 2, issue.author_id | ||||
|
Jean-Philippe Lang
|
r1596 | assert_equal 3, issue.tracker_id | ||
|
Jean-Philippe Lang
|
r3492 | assert_equal 2, issue.status_id | ||
|
Jean-Philippe Lang
|
r4264 | assert_equal Date.parse('2010-11-07'), issue.start_date | ||
|
Jean-Philippe Lang
|
r1370 | assert_nil issue.estimated_hours | ||
|
Jean-Philippe Lang
|
r1730 | v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2}) | ||
|
Jean-Philippe Lang
|
r1076 | assert_not_nil v | ||
| assert_equal 'Value for field 2', v.value | ||||
|
Jean-Philippe Lang
|
r1066 | end | ||
|
Jean-Philippe Lang
|
r4264 | def test_post_create_without_start_date | ||
| @request.session[:user_id] = 2 | ||||
| assert_difference 'Issue.count' do | ||||
| post :create, :project_id => 1, | ||||
| :issue => {:tracker_id => 3, | ||||
| :status_id => 2, | ||||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5, | ||||
| :start_date => '', | ||||
| :estimated_hours => '', | ||||
| :custom_field_values => {'2' => 'Value for field 2'}} | ||||
| end | ||||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id | ||||
| issue = Issue.find_by_subject('This is the test_new issue') | ||||
| assert_not_nil issue | ||||
| assert_nil issue.start_date | ||||
| end | ||||
|
Eric Davis
|
r3574 | def test_post_create_and_continue | ||
|
Jean-Philippe Lang
|
r2263 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r2263 | :issue => {:tracker_id => 3, | ||
| :subject => 'This is first issue', | ||||
| :priority_id => 5}, | ||||
| :continue => '' | ||||
|
Jean-Baptiste Barth
|
r3969 | assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', | ||
| :issue => {:tracker_id => 3} | ||||
|
Jean-Philippe Lang
|
r2263 | end | ||
|
Eric Davis
|
r3574 | def test_post_create_without_custom_fields_param | ||
|
Jean-Philippe Lang
|
r1302 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r2773 | assert_difference 'Issue.count' do | ||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Eric Davis
|
r2773 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5} | ||||
| end | ||||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id | ||||
|
Jean-Philippe Lang
|
r1302 | end | ||
|
Eric Davis
|
r2315 | |||
|
Eric Davis
|
r3574 | def test_post_create_with_required_custom_field_and_without_custom_fields_param | ||
|
Jean-Philippe Lang
|
r1578 | field = IssueCustomField.find_by_name('Database') | ||
| field.update_attribute(:is_required, true) | ||||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r1578 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5} | ||||
| assert_response :success | ||||
| assert_template 'new' | ||||
| issue = assigns(:issue) | ||||
| assert_not_nil issue | ||||
|
Jean-Philippe Lang
|
r2430 | assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values) | ||
|
Jean-Philippe Lang
|
r1578 | end | ||
|
Eric Davis
|
r3574 | def test_post_create_with_watchers | ||
|
Jean-Philippe Lang
|
r2162 | @request.session[:user_id] = 2 | ||
| ActionMailer::Base.deliveries.clear | ||||
| assert_difference 'Watcher.count', 2 do | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r2162 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is a new issue with watchers', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5, | ||||
| :watcher_user_ids => ['2', '3']} | ||||
| end | ||||
| issue = Issue.find_by_subject('This is a new issue with watchers') | ||||
|
Jean-Philippe Lang
|
r2233 | assert_not_nil issue | ||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => issue | ||||
|
Jean-Philippe Lang
|
r2162 | # Watchers added | ||
| assert_equal [2, 3], issue.watcher_user_ids.sort | ||||
| assert issue.watched_by?(User.find(3)) | ||||
| # Watchers notified | ||||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert_kind_of TMail::Mail, mail | ||||
| assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail) | ||||
| end | ||||
|
Eric Davis
|
r3574 | def test_post_create_subissue | ||
|
Jean-Philippe Lang
|
r3459 | @request.session[:user_id] = 2 | ||
| assert_difference 'Issue.count' do | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r3459 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is a child issue', | ||||
| :parent_issue_id => 2} | ||||
| end | ||||
| issue = Issue.find_by_subject('This is a child issue') | ||||
| assert_not_nil issue | ||||
| assert_equal Issue.find(2), issue.parent | ||||
| end | ||||
|
Jean-Philippe Lang
|
r4300 | |||
| def test_post_create_subissue_with_non_numeric_parent_id | ||||
| @request.session[:user_id] = 2 | ||||
| assert_difference 'Issue.count' do | ||||
| post :create, :project_id => 1, | ||||
| :issue => {:tracker_id => 1, | ||||
| :subject => 'This is a child issue', | ||||
| :parent_issue_id => 'ABC'} | ||||
| end | ||||
| issue = Issue.find_by_subject('This is a child issue') | ||||
| assert_not_nil issue | ||||
| assert_nil issue.parent | ||||
| end | ||||
|
Jean-Philippe Lang
|
r3459 | |||
|
Eric Davis
|
r3574 | def test_post_create_should_send_a_notification | ||
|
Eric Davis
|
r2548 | ActionMailer::Base.deliveries.clear | ||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r2773 | assert_difference 'Issue.count' do | ||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Eric Davis
|
r2773 | :issue => {:tracker_id => 3, | ||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5, | ||||
| :estimated_hours => '', | ||||
| :custom_field_values => {'2' => 'Value for field 2'}} | ||||
| end | ||||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id | ||||
|
Eric Davis
|
r2548 | |||
| assert_equal 1, ActionMailer::Base.deliveries.size | ||||
| end | ||||
|
Eric Davis
|
r3574 | def test_post_create_should_preserve_fields_values_on_validation_failure | ||
|
Jean-Philippe Lang
|
r1578 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r1578 | :issue => {:tracker_id => 1, | ||
|
Jean-Philippe Lang
|
r2246 | # empty subject | ||
| :subject => '', | ||||
| :description => 'This is a description', | ||||
|
Jean-Philippe Lang
|
r1578 | :priority_id => 6, | ||
| :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}} | ||||
| assert_response :success | ||||
| assert_template 'new' | ||||
|
Jean-Philippe Lang
|
r2246 | assert_tag :textarea, :attributes => { :name => 'issue[description]' }, | ||
| :content => 'This is a description' | ||||
|
Jean-Philippe Lang
|
r1578 | assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, | ||
| :child => { :tag => 'option', :attributes => { :selected => 'selected', | ||||
| :value => '6' }, | ||||
| :content => 'High' } | ||||
| # Custom fields | ||||
| assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' }, | ||||
| :child => { :tag => 'option', :attributes => { :selected => 'selected', | ||||
| :value => 'Oracle' }, | ||||
| :content => 'Oracle' } | ||||
| assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]', | ||||
| :value => 'Value for field 2'} | ||||
| end | ||||
|
Eric Davis
|
r3574 | def test_post_create_should_ignore_non_safe_attributes | ||
|
Jean-Philippe Lang
|
r3194 | @request.session[:user_id] = 2 | ||
| assert_nothing_raised do | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" } | ||
|
Jean-Philippe Lang
|
r3194 | end | ||
| end | ||||
|
Jean-Philippe Lang
|
r3492 | context "without workflow privilege" do | ||
| setup do | ||||
| Workflow.delete_all(["role_id = ?", Role.anonymous.id]) | ||||
|
Jean-Philippe Lang
|
r4279 | Role.anonymous.add_permission! :add_issues, :add_issue_notes | ||
|
Jean-Philippe Lang
|
r3492 | end | ||
| context "#new" do | ||||
| should "propose default status only" do | ||||
| get :new, :project_id => 1 | ||||
| assert_response :success | ||||
| assert_template 'new' | ||||
| assert_tag :tag => 'select', | ||||
| :attributes => {:name => 'issue[status_id]'}, | ||||
| :children => {:count => 1}, | ||||
| :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}} | ||||
| end | ||||
| should "accept default status" do | ||||
| assert_difference 'Issue.count' do | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r3492 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is an issue', | ||||
| :status_id => 1} | ||||
| end | ||||
| issue = Issue.last(:order => 'id') | ||||
| assert_equal IssueStatus.default, issue.status | ||||
| end | ||||
|
Jean-Philippe Lang
|
r4279 | should "accept default status" do | ||
| assert_difference 'Issue.count' do | ||||
| post :create, :project_id => 1, | ||||
| :issue => {:tracker_id => 1, | ||||
| :subject => 'This is an issue', | ||||
| :status_id => 1} | ||||
| end | ||||
| issue = Issue.last(:order => 'id') | ||||
| assert_equal IssueStatus.default, issue.status | ||||
| end | ||||
|
Jean-Philippe Lang
|
r3492 | should "ignore unauthorized status" do | ||
| assert_difference 'Issue.count' do | ||||
|
Eric Davis
|
r3574 | post :create, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r3492 | :issue => {:tracker_id => 1, | ||
| :subject => 'This is an issue', | ||||
| :status_id => 3} | ||||
| end | ||||
| issue = Issue.last(:order => 'id') | ||||
| assert_equal IssueStatus.default, issue.status | ||||
| end | ||||
| end | ||||
|
Jean-Philippe Lang
|
r4279 | |||
| context "#update" do | ||||
| should "ignore status change" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3} | ||||
| end | ||||
| assert_equal 1, Issue.find(1).status_id | ||||
| end | ||||
| should "ignore attributes changes" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2} | ||||
| end | ||||
| issue = Issue.find(1) | ||||
| assert_equal "Can't print recipes", issue.subject | ||||
| assert_nil issue.assigned_to | ||||
| end | ||||
| end | ||||
| end | ||||
| context "with workflow privilege" do | ||||
| setup do | ||||
| Workflow.delete_all(["role_id = ?", Role.anonymous.id]) | ||||
| Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3) | ||||
| Workflow.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4) | ||||
| Role.anonymous.add_permission! :add_issues, :add_issue_notes | ||||
| end | ||||
| context "#update" do | ||||
| should "accept authorized status" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3} | ||||
| end | ||||
| assert_equal 3, Issue.find(1).status_id | ||||
| end | ||||
| should "ignore unauthorized status" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2} | ||||
| end | ||||
| assert_equal 1, Issue.find(1).status_id | ||||
| end | ||||
| should "accept authorized attributes changes" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2} | ||||
| end | ||||
| issue = Issue.find(1) | ||||
| assert_equal 2, issue.assigned_to_id | ||||
| end | ||||
| should "ignore unauthorized attributes changes" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'} | ||||
| end | ||||
| issue = Issue.find(1) | ||||
| assert_equal "Can't print recipes", issue.subject | ||||
| end | ||||
| end | ||||
| context "and :edit_issues permission" do | ||||
| setup do | ||||
| Role.anonymous.add_permission! :add_issues, :edit_issues | ||||
| end | ||||
| should "accept authorized status" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3} | ||||
| end | ||||
| assert_equal 3, Issue.find(1).status_id | ||||
| end | ||||
| should "ignore unauthorized status" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2} | ||||
| end | ||||
| assert_equal 1, Issue.find(1).status_id | ||||
| end | ||||
| should "accept authorized attributes changes" do | ||||
| assert_difference 'Journal.count' do | ||||
| put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2} | ||||
| end | ||||
| issue = Issue.find(1) | ||||
| assert_equal "changed", issue.subject | ||||
| assert_equal 2, issue.assigned_to_id | ||||
| end | ||||
| end | ||||
|
Jean-Philippe Lang
|
r3492 | end | ||
|
Jean-Philippe Lang
|
r1066 | def test_copy_issue | ||
| @request.session[:user_id] = 2 | ||||
| get :new, :project_id => 1, :copy_from => 1 | ||||
| assert_template 'new' | ||||
| assert_not_nil assigns(:issue) | ||||
| orig = Issue.find(1) | ||||
| assert_equal orig.subject, assigns(:issue).subject | ||||
| end | ||||
|
Jean-Philippe Lang
|
r971 | def test_get_edit | ||
| @request.session[:user_id] = 2 | ||||
| get :edit, :id => 1 | ||||
| assert_response :success | ||||
| assert_template 'edit' | ||||
| assert_not_nil assigns(:issue) | ||||
| assert_equal Issue.find(1), assigns(:issue) | ||||
| end | ||||
|
Jean-Philippe Lang
|
r1116 | |||
| def test_get_edit_with_params | ||||
| @request.session[:user_id] = 2 | ||||
|
Jean-Philippe Lang
|
r4297 | get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }, | ||
| :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id } | ||||
|
Jean-Philippe Lang
|
r1116 | assert_response :success | ||
| assert_template 'edit' | ||||
| issue = assigns(:issue) | ||||
| assert_not_nil issue | ||||
| assert_equal 5, issue.status_id | ||||
| assert_tag :select, :attributes => { :name => 'issue[status_id]' }, | ||||
| :child => { :tag => 'option', | ||||
| :content => 'Closed', | ||||
| :attributes => { :selected => 'selected' } } | ||||
| assert_equal 7, issue.priority_id | ||||
| assert_tag :select, :attributes => { :name => 'issue[priority_id]' }, | ||||
| :child => { :tag => 'option', | ||||
| :content => 'Urgent', | ||||
| :attributes => { :selected => 'selected' } } | ||||
|
Jean-Philippe Lang
|
r4297 | |||
| assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' } | ||||
| assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' }, | ||||
| :child => { :tag => 'option', | ||||
| :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } } | ||||
| assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' } | ||||
|
Jean-Philippe Lang
|
r1116 | end | ||
|
Jean-Philippe Lang
|
r2994 | |||
| def test_update_edit_form | ||||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3897 | xhr :post, :new, :project_id => 1, | ||
|
Jean-Philippe Lang
|
r2994 | :id => 1, | ||
| :issue => {:tracker_id => 2, | ||||
| :subject => 'This is the test_new issue', | ||||
| :description => 'This is the description', | ||||
| :priority_id => 5} | ||||
| assert_response :success | ||||
| assert_template 'attributes' | ||||
| issue = assigns(:issue) | ||||
| assert_kind_of Issue, issue | ||||
| assert_equal 1, issue.id | ||||
| assert_equal 1, issue.project_id | ||||
| assert_equal 2, issue.tracker_id | ||||
| assert_equal 'This is the test_new issue', issue.subject | ||||
| end | ||||
|
Jean-Philippe Lang
|
r1466 | |||
|
Eric Davis
|
r3406 | def test_update_using_invalid_http_verbs | ||
| @request.session[:user_id] = 2 | ||||
| subject = 'Updated by an invalid http verb' | ||||
| get :update, :id => 1, :issue => {:subject => subject} | ||||
| assert_not_equal subject, Issue.find(1).subject | ||||
| post :update, :id => 1, :issue => {:subject => subject} | ||||
| assert_not_equal subject, Issue.find(1).subject | ||||
| delete :update, :id => 1, :issue => {:subject => subject} | ||||
| assert_not_equal subject, Issue.find(1).subject | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_without_custom_fields_param | ||
|
Jean-Philippe Lang
|
r971 | @request.session[:user_id] = 2 | ||
|
Jean-Philippe Lang
|
r1005 | ActionMailer::Base.deliveries.clear | ||
| issue = Issue.find(1) | ||||
|
Jean-Philippe Lang
|
r1578 | assert_equal '125', issue.custom_value_for(2).value | ||
|
Jean-Philippe Lang
|
r1005 | old_subject = issue.subject | ||
| new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' | ||||
|
Jean-Philippe Lang
|
r1578 | assert_difference('Journal.count') do | ||
| assert_difference('JournalDetail.count', 2) do | ||||
|
Eric Davis
|
r3366 | put :update, :id => 1, :issue => {:subject => new_subject, | ||
|
Jean-Philippe Lang
|
r1578 | :priority_id => '6', | ||
| :category_id => '1' # no change | ||||
| } | ||||
| end | ||||
| end | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r1005 | issue.reload | ||
| assert_equal new_subject, issue.subject | ||||
|
Jean-Philippe Lang
|
r1578 | # Make sure custom fields were not cleared | ||
| assert_equal '125', issue.custom_value_for(2).value | ||||
|
Jean-Philippe Lang
|
r1005 | |||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert_kind_of TMail::Mail, mail | ||||
| assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]") | ||||
| assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}") | ||||
|
Jean-Philippe Lang
|
r971 | end | ||
|
Eric Davis
|
r3366 | def test_put_update_with_custom_field_change | ||
|
Jean-Philippe Lang
|
r1578 | @request.session[:user_id] = 2 | ||
| issue = Issue.find(1) | ||||
| assert_equal '125', issue.custom_value_for(2).value | ||||
| assert_difference('Journal.count') do | ||||
| assert_difference('JournalDetail.count', 3) do | ||||
|
Eric Davis
|
r3366 | put :update, :id => 1, :issue => {:subject => 'Custom field change', | ||
|
Jean-Philippe Lang
|
r1578 | :priority_id => '6', | ||
| :category_id => '1', # no change | ||||
| :custom_field_values => { '2' => 'New custom value' } | ||||
| } | ||||
| end | ||||
| end | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r1578 | issue.reload | ||
| assert_equal 'New custom value', issue.custom_value_for(2).value | ||||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert_kind_of TMail::Mail, mail | ||||
| assert mail.body.include?("Searchable field changed from 125 to New custom value") | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_with_status_and_assignee_change | ||
|
Jean-Philippe Lang
|
r971 | issue = Issue.find(1) | ||
| assert_equal 1, issue.status_id | ||||
| @request.session[:user_id] = 2 | ||||
|
Jean-Philippe Lang
|
r1370 | assert_difference('TimeEntry.count', 0) do | ||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r1370 | :id => 1, | ||
| :issue => { :status_id => 2, :assigned_to_id => 3 }, | ||||
| :notes => 'Assigned to dlopper', | ||||
|
Eric Davis
|
r2677 | :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first } | ||
|
Jean-Philippe Lang
|
r1370 | end | ||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r971 | issue.reload | ||
| assert_equal 2, issue.status_id | ||||
|
Jean-Philippe Lang
|
r3098 | j = Journal.find(:first, :order => 'id DESC') | ||
|
Jean-Philippe Lang
|
r971 | assert_equal 'Assigned to dlopper', j.notes | ||
| assert_equal 2, j.details.size | ||||
|
Jean-Philippe Lang
|
r1030 | |||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert mail.body.include?("Status changed from New to Assigned") | ||||
|
Jean-Philippe Lang
|
r2581 | # subject should contain the new status | ||
| assert mail.subject.include?("(#{ IssueStatus.find(2).name })") | ||||
|
Jean-Philippe Lang
|
r1030 | end | ||
|
Eric Davis
|
r3366 | def test_put_update_with_note_only | ||
|
Jean-Philippe Lang
|
r1030 | notes = 'Note added by IssuesControllerTest#test_update_with_note_only' | ||
| # anonymous user | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r1030 | :id => 1, | ||
| :notes => notes | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r3098 | j = Journal.find(:first, :order => 'id DESC') | ||
|
Jean-Philippe Lang
|
r1030 | assert_equal notes, j.notes | ||
| assert_equal 0, j.details.size | ||||
| assert_equal User.anonymous, j.user | ||||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert mail.body.include?(notes) | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_with_note_and_spent_time | ||
|
Jean-Philippe Lang
|
r1030 | @request.session[:user_id] = 2 | ||
| spent_hours_before = Issue.find(1).spent_hours | ||||
|
Jean-Philippe Lang
|
r1370 | assert_difference('TimeEntry.count') do | ||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r1370 | :id => 1, | ||
| :notes => '2.5 hours added', | ||||
|
Jean-Philippe Lang
|
r3587 | :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id } | ||
|
Jean-Philippe Lang
|
r1370 | end | ||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r1030 | |||
| issue = Issue.find(1) | ||||
|
Jean-Philippe Lang
|
r3098 | j = Journal.find(:first, :order => 'id DESC') | ||
|
Jean-Philippe Lang
|
r1030 | assert_equal '2.5 hours added', j.notes | ||
| assert_equal 0, j.details.size | ||||
|
Jean-Philippe Lang
|
r3550 | t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time') | ||
|
Jean-Philippe Lang
|
r1030 | assert_not_nil t | ||
| assert_equal 2.5, t.hours | ||||
| assert_equal spent_hours_before + 2.5, issue.spent_hours | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_with_attachment_only | ||
|
Jean-Philippe Lang
|
r1506 | set_tmp_attachments_directory | ||
|
Eric Davis
|
r1920 | # Delete all fixtured journals, a race condition can occur causing the wrong | ||
| # journal to get fetched in the next find. | ||||
| Journal.delete_all | ||||
|
Jean-Philippe Lang
|
r1030 | # anonymous user | ||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r1030 | :id => 1, | ||
| :notes => '', | ||||
|
Jean-Philippe Lang
|
r2795 | :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} | ||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r1030 | j = Issue.find(1).journals.find(:first, :order => 'id DESC') | ||
| assert j.notes.blank? | ||||
| assert_equal 1, j.details.size | ||||
| assert_equal 'testfile.txt', j.details.first.value | ||||
| assert_equal User.anonymous, j.user | ||||
| mail = ActionMailer::Base.deliveries.last | ||||
| assert mail.body.include?('testfile.txt') | ||||
| end | ||||
|
Eric Davis
|
r3413 | |||
| def test_put_update_with_attachment_that_fails_to_save | ||||
| set_tmp_attachments_directory | ||||
| # Delete all fixtured journals, a race condition can occur causing the wrong | ||||
| # journal to get fetched in the next find. | ||||
| Journal.delete_all | ||||
| # Mock out the unsaved attachment | ||||
| Attachment.any_instance.stubs(:create).returns(Attachment.new) | ||||
| # anonymous user | ||||
| put :update, | ||||
| :id => 1, | ||||
| :notes => '', | ||||
| :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}} | ||||
| assert_redirected_to :action => 'show', :id => '1' | ||||
| assert_equal '1 file(s) could not be saved.', flash[:warning] | ||||
| end if Object.const_defined?(:Mocha) | ||||
|
Eric Davis
|
r3366 | def test_put_update_with_no_change | ||
|
Jean-Philippe Lang
|
r1030 | issue = Issue.find(1) | ||
| issue.journals.clear | ||||
| ActionMailer::Base.deliveries.clear | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r1030 | :id => 1, | ||
| :notes => '' | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'show', :id => '1' | ||
|
Jean-Philippe Lang
|
r1030 | |||
| issue.reload | ||||
| assert issue.journals.empty? | ||||
| # No email should be sent | ||||
| assert ActionMailer::Base.deliveries.empty? | ||||
|
Jean-Philippe Lang
|
r971 | end | ||
|
Eric Davis
|
r2548 | |||
|
Eric Davis
|
r3366 | def test_put_update_should_send_a_notification | ||
|
Eric Davis
|
r2548 | @request.session[:user_id] = 2 | ||
| ActionMailer::Base.deliveries.clear | ||||
| issue = Issue.find(1) | ||||
| old_subject = issue.subject | ||||
| new_subject = 'Subject modified by IssuesControllerTest#test_post_edit' | ||||
|
Eric Davis
|
r3366 | put :update, :id => 1, :issue => {:subject => new_subject, | ||
|
Eric Davis
|
r2548 | :priority_id => '6', | ||
| :category_id => '1' # no change | ||||
| } | ||||
| assert_equal 1, ActionMailer::Base.deliveries.size | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2249 | |||
|
Jean-Philippe Lang
|
r4990 | def test_put_update_with_invalid_spent_time_hours_only | ||
|
Jean-Philippe Lang
|
r2249 | @request.session[:user_id] = 2 | ||
| notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time' | ||||
| assert_no_difference('Journal.count') do | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r2249 | :id => 1, | ||
| :notes => notes, | ||||
| :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"} | ||||
| end | ||||
| assert_response :success | ||||
| assert_template 'edit' | ||||
|
Jean-Philippe Lang
|
r4990 | assert_error_tag :descendant => {:content => /Activity can't be blank/} | ||
| assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes | ||||
|
Jean-Philippe Lang
|
r2249 | assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" } | ||
| end | ||||
|
Jean-Philippe Lang
|
r2640 | |||
|
Jean-Philippe Lang
|
r4990 | def test_put_update_with_invalid_spent_time_comments_only | ||
| @request.session[:user_id] = 2 | ||||
| notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time' | ||||
| assert_no_difference('Journal.count') do | ||||
| put :update, | ||||
| :id => 1, | ||||
| :notes => notes, | ||||
| :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""} | ||||
| end | ||||
| assert_response :success | ||||
| assert_template 'edit' | ||||
| assert_error_tag :descendant => {:content => /Activity can't be blank/} | ||||
| assert_error_tag :descendant => {:content => /Hours can't be blank/} | ||||
| assert_tag :textarea, :attributes => { :name => 'notes' }, :content => notes | ||||
| assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" } | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject | ||
|
Jean-Philippe Lang
|
r3009 | issue = Issue.find(2) | ||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Jean-Philippe Lang
|
r3009 | :id => issue.id, | ||
| :issue => { | ||||
| :fixed_version_id => 4 | ||||
| } | ||||
| assert_response :redirect | ||||
| issue.reload | ||||
| assert_equal 4, issue.fixed_version_id | ||||
| assert_not_equal issue.project_id, issue.fixed_version.project_id | ||||
| end | ||||
|
Eric Davis
|
r3201 | |||
|
Eric Davis
|
r3366 | def test_put_update_should_redirect_back_using_the_back_url_parameter | ||
|
Eric Davis
|
r3201 | issue = Issue.find(2) | ||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Eric Davis
|
r3201 | :id => issue.id, | ||
| :issue => { | ||||
| :fixed_version_id => 4 | ||||
| }, | ||||
| :back_url => '/issues' | ||||
| assert_response :redirect | ||||
| assert_redirected_to '/issues' | ||||
| end | ||||
|
Eric Davis
|
r3366 | def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host | ||
|
Eric Davis
|
r3201 | issue = Issue.find(2) | ||
| @request.session[:user_id] = 2 | ||||
|
Eric Davis
|
r3366 | put :update, | ||
|
Eric Davis
|
r3201 | :id => issue.id, | ||
| :issue => { | ||||
| :fixed_version_id => 4 | ||||
| }, | ||||
| :back_url => 'http://google.com' | ||||
| assert_response :redirect | ||||
| assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id | ||||
| end | ||||
|
Jean-Philippe Lang
|
r3009 | |||
|
Jean-Philippe Lang
|
r2640 | def test_get_bulk_edit | ||
| @request.session[:user_id] = 2 | ||||
| get :bulk_edit, :ids => [1, 2] | ||||
| assert_response :success | ||||
| assert_template 'bulk_edit' | ||||
|
Jean-Philippe Lang
|
r3164 | |||
|
Jean-Philippe Lang
|
r5104 | assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'} | ||
|
Jean-Philippe Lang
|
r3164 | # Project specific custom field, date type | ||
| field = CustomField.find(9) | ||||
| assert !field.is_for_all? | ||||
| assert_equal 'date', field.field_format | ||||
|
Jean-Philippe Lang
|
r3364 | assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'} | ||
|
Jean-Philippe Lang
|
r3164 | |||
|
Jean-Philippe Lang
|
r3163 | # System wide custom field | ||
|
Jean-Philippe Lang
|
r3164 | assert CustomField.find(1).is_for_all? | ||
|
Jean-Philippe Lang
|
r3364 | assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'} | ||
|
Jean-Philippe Lang
|
r2640 | end | ||
|
Jean-Philippe Lang
|
r1116 | |||
|
Jean-Baptiste Barth
|
r4128 | def test_get_bulk_edit_on_different_projects | ||
| @request.session[:user_id] = 2 | ||||
| get :bulk_edit, :ids => [1, 2, 6] | ||||
| assert_response :success | ||||
| assert_template 'bulk_edit' | ||||
|
Jean-Philippe Lang
|
r5104 | # Can not set issues from different projects as children of an issue | ||
| assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'} | ||||
|
Jean-Baptiste Barth
|
r4128 | # Project specific custom field, date type | ||
| field = CustomField.find(9) | ||||
| assert !field.is_for_all? | ||||
| assert !field.project_ids.include?(Issue.find(6).project_id) | ||||
| assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'} | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_bulk_update | ||
|
Jean-Philippe Lang
|
r1116 | @request.session[:user_id] = 2 | ||
| # update issues priority | ||||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing', | ||
|
Jean-Philippe Lang
|
r3364 | :issue => {:priority_id => 7, | ||
| :assigned_to_id => '', | ||||
| :custom_field_values => {'2' => ''}} | ||||
|
Jean-Philippe Lang
|
r1116 | assert_response 302 | ||
| # check that the issues were updated | ||||
| assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id} | ||||
|
Jean-Philippe Lang
|
r2314 | |||
| issue = Issue.find(1) | ||||
| journal = issue.journals.find(:first, :order => 'created_on DESC') | ||||
| assert_equal '125', issue.custom_value_for(2).value | ||||
| assert_equal 'Bulk editing', journal.notes | ||||
| assert_equal 1, journal.details.size | ||||
| end | ||||
|
Jean-Baptiste Barth
|
r4128 | def test_bulk_update_on_different_projects | ||
| @request.session[:user_id] = 2 | ||||
| # update issues priority | ||||
| post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing', | ||||
| :issue => {:priority_id => 7, | ||||
| :assigned_to_id => '', | ||||
| :custom_field_values => {'2' => ''}} | ||||
| assert_response 302 | ||||
| # check that the issues were updated | ||||
| assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id) | ||||
| issue = Issue.find(1) | ||||
| journal = issue.journals.find(:first, :order => 'created_on DESC') | ||||
| assert_equal '125', issue.custom_value_for(2).value | ||||
| assert_equal 'Bulk editing', journal.notes | ||||
| assert_equal 1, journal.details.size | ||||
| end | ||||
| def test_bulk_update_on_different_projects_without_rights | ||||
| @request.session[:user_id] = 3 | ||||
| user = User.find(3) | ||||
| action = { :controller => "issues", :action => "bulk_update" } | ||||
| assert user.allowed_to?(action, Issue.find(1).project) | ||||
| assert ! user.allowed_to?(action, Issue.find(6).project) | ||||
| post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail', | ||||
| :issue => {:priority_id => 7, | ||||
| :assigned_to_id => '', | ||||
| :custom_field_values => {'2' => ''}} | ||||
| assert_response 403 | ||||
| assert_not_equal "Bulk should fail", Journal.last.notes | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_bullk_update_should_send_a_notification | ||
|
Eric Davis
|
r2548 | @request.session[:user_id] = 2 | ||
| ActionMailer::Base.deliveries.clear | ||||
|
Eric Davis
|
r3923 | post(:bulk_update, | ||
|
Eric Davis
|
r2548 | { | ||
| :ids => [1, 2], | ||||
|
Jean-Philippe Lang
|
r3364 | :notes => 'Bulk editing', | ||
| :issue => { | ||||
| :priority_id => 7, | ||||
| :assigned_to_id => '', | ||||
| :custom_field_values => {'2' => ''} | ||||
| } | ||||
|
Eric Davis
|
r2548 | }) | ||
| assert_response 302 | ||||
| assert_equal 2, ActionMailer::Base.deliveries.size | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_bulk_update_status | ||
|
Jean-Philippe Lang
|
r2645 | @request.session[:user_id] = 2 | ||
| # update issues priority | ||||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status', | ||
|
Jean-Philippe Lang
|
r3364 | :issue => {:priority_id => '', | ||
| :assigned_to_id => '', | ||||
| :status_id => '5'} | ||||
|
Jean-Philippe Lang
|
r2645 | assert_response 302 | ||
| issue = Issue.find(1) | ||||
| assert issue.closed? | ||||
| end | ||||
|
Jean-Philippe Lang
|
r5104 | |||
| def test_bulk_update_parent_id | ||||
| @request.session[:user_id] = 2 | ||||
| post :bulk_update, :ids => [1, 3], | ||||
| :notes => 'Bulk editing parent', | ||||
| :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'} | ||||
| assert_response 302 | ||||
| parent = Issue.find(2) | ||||
| assert_equal parent.id, Issue.find(1).parent_id | ||||
| assert_equal parent.id, Issue.find(3).parent_id | ||||
| assert_equal [1, 3], parent.children.collect(&:id).sort | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2645 | |||
|
Eric Davis
|
r3923 | def test_bulk_update_custom_field | ||
|
Jean-Philippe Lang
|
r2314 | @request.session[:user_id] = 2 | ||
| # update issues priority | ||||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field', | ||
|
Jean-Philippe Lang
|
r3364 | :issue => {:priority_id => '', | ||
| :assigned_to_id => '', | ||||
| :custom_field_values => {'2' => '777'}} | ||||
|
Jean-Philippe Lang
|
r2314 | assert_response 302 | ||
| issue = Issue.find(1) | ||||
| journal = issue.journals.find(:first, :order => 'created_on DESC') | ||||
| assert_equal '777', issue.custom_value_for(2).value | ||||
| assert_equal 1, journal.details.size | ||||
| assert_equal '125', journal.details.first.old_value | ||||
| assert_equal '777', journal.details.first.value | ||||
|
Jean-Philippe Lang
|
r1116 | end | ||
|
Eric Davis
|
r3923 | def test_bulk_update_unassign | ||
|
Jean-Philippe Lang
|
r1279 | assert_not_nil Issue.find(2).assigned_to | ||
| @request.session[:user_id] = 2 | ||||
| # unassign issues | ||||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'} | ||
|
Jean-Philippe Lang
|
r1279 | assert_response 302 | ||
| # check that the issues were updated | ||||
| assert_nil Issue.find(2).assigned_to | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject | ||
|
Jean-Philippe Lang
|
r3009 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4} | ||
|
Jean-Philippe Lang
|
r3009 | |||
| assert_response :redirect | ||||
| issues = Issue.find([1,2]) | ||||
| issues.each do |issue| | ||||
| assert_equal 4, issue.fixed_version_id | ||||
| assert_not_equal issue.project_id, issue.fixed_version.project_id | ||||
| end | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter | ||
|
Eric Davis
|
r3201 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1,2], :back_url => '/issues' | ||
|
Eric Davis
|
r3201 | |||
| assert_response :redirect | ||||
| assert_redirected_to '/issues' | ||||
| end | ||||
|
Eric Davis
|
r3923 | def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host | ||
|
Eric Davis
|
r3201 | @request.session[:user_id] = 2 | ||
|
Eric Davis
|
r3923 | post :bulk_update, :ids => [1,2], :back_url => 'http://google.com' | ||
|
Eric Davis
|
r3201 | |||
| assert_response :redirect | ||||
| assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier | ||||
| end | ||||
|
Jean-Philippe Lang
|
r971 | |||
|
Jean-Philippe Lang
|
r1168 | def test_destroy_issue_with_no_time_entries | ||
|
Jean-Philippe Lang
|
r1325 | assert_nil TimeEntry.find_by_issue_id(2) | ||
|
Jean-Philippe Lang
|
r971 | @request.session[:user_id] = 2 | ||
|
Jean-Philippe Lang
|
r1325 | post :destroy, :id => 2 | ||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' | ||
|
Jean-Philippe Lang
|
r1325 | assert_nil Issue.find_by_id(2) | ||
|
Jean-Philippe Lang
|
r971 | end | ||
|
Jean-Philippe Lang
|
r1168 | def test_destroy_issues_with_time_entries | ||
| @request.session[:user_id] = 2 | ||||
| post :destroy, :ids => [1, 3] | ||||
| assert_response :success | ||||
| assert_template 'destroy' | ||||
| assert_not_nil assigns(:hours) | ||||
| assert Issue.find_by_id(1) && Issue.find_by_id(3) | ||||
| end | ||||
| def test_destroy_issues_and_destroy_time_entries | ||||
| @request.session[:user_id] = 2 | ||||
| post :destroy, :ids => [1, 3], :todo => 'destroy' | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' | ||
|
Jean-Philippe Lang
|
r1168 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) | ||
| assert_nil TimeEntry.find_by_id([1, 2]) | ||||
| end | ||||
| def test_destroy_issues_and_assign_time_entries_to_project | ||||
| @request.session[:user_id] = 2 | ||||
| post :destroy, :ids => [1, 3], :todo => 'nullify' | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' | ||
|
Jean-Philippe Lang
|
r1168 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) | ||
| assert_nil TimeEntry.find(1).issue_id | ||||
| assert_nil TimeEntry.find(2).issue_id | ||||
| end | ||||
| def test_destroy_issues_and_reassign_time_entries_to_another_issue | ||||
| @request.session[:user_id] = 2 | ||||
| post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2 | ||||
|
Eric Davis
|
r2315 | assert_redirected_to :action => 'index', :project_id => 'ecookbook' | ||
|
Jean-Philippe Lang
|
r1168 | assert !(Issue.find_by_id(1) || Issue.find_by_id(3)) | ||
| assert_equal 2, TimeEntry.find(1).issue_id | ||||
| assert_equal 2, TimeEntry.find(2).issue_id | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2829 | |||
|
Jean-Baptiste Barth
|
r4122 | def test_destroy_issues_from_different_projects | ||
| @request.session[:user_id] = 2 | ||||
| post :destroy, :ids => [1, 2, 6], :todo => 'destroy' | ||||
| assert_redirected_to :controller => 'issues', :action => 'index' | ||||
| assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6)) | ||||
| end | ||||
|
Jean-Philippe Lang
|
r2829 | def test_default_search_scope | ||
| get :index | ||||
| assert_tag :div, :attributes => {:id => 'quick-search'}, | ||||
| :child => {:tag => 'form', | ||||
| :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}} | ||||
| end | ||||
|
Jean-Philippe Lang
|
r874 | end | ||