##// END OF EJS Templates
Removes some empty lines (#14015)....
Removes some empty lines (#14015). git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11830 e93f8b46-1217-0410-a6f0-8f06a7374b81

File last commit:

r11600:a2b6088772dc
r11600:a2b6088772dc
Show More
issue.rb
1514 lines | 54.3 KiB | text/x-ruby | RubyLexer
Jean-Philippe Lang
Keep track of issue description changes (#746)....
r4834 # Redmine - project management software
Jean-Philippe Lang
Copyright for 2013 (#12788)....
r10939 # Copyright (C) 2006-2013 Jean-Philippe Lang
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 #
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690 #
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 # This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690 #
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 # You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class Issue < ActiveRecord::Base
Jean-Philippe Lang
Makes issue safe_attributes extensible (#6000)....
r4377 include Redmine::SafeAttributes
Jean-Philippe Lang
Ignore non-working days when rescheduling an issue (#2161)....
r10531 include Redmine::Utils::DateCalculation
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 belongs_to :project
belongs_to :tracker
belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
Jean-Philippe Lang
Ability to assign issues to groups (#2964)....
r6186 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
Eric Davis
Changed Enumerations to use a Single Table Inheritance...
r2677 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
has_many :journals, :as => :journalized, :dependent => :destroy
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 has_many :visible_journals,
:class_name => 'Journal',
:as => :journalized,
:conditions => Proc.new {
["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
},
:readonly => true
Jean-Philippe Lang
Let the user choose when deleting issues with reported hours (closes #734, #71):...
r1168 has_many :time_entries, :dependent => :delete_all
Jean-Philippe Lang
Fixed: associated revisions are displayed in wrong order on issue view (#1546)....
r1582 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Fixed: subtasks are deleted (not destroyed) when destroying parent issue (#7385)....
r4615 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
Jean-Philippe Lang
Fixed: MailHandler does not include JournalDetail for attached files (#7966)....
r6192 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
Jean-Philippe Lang
Custom fields refactoring: most of code moved from controllers to models (using new module ActsAsCustomizable)....
r1578 acts_as_customizable
Jean-Philippe Lang
Added "Watch" functionality on issues. It allows users to receive mail notifications about issue changes....
r450 acts_as_watchable
Jean-Philippe Lang
Search engine: display total results count (#906) and count by result type....
r1664 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 :include => [:project, :visible_journals],
Jean-Philippe Lang
Search engine: display total results count (#906) and count by result type....
r1664 # sort by id so that limited eager loading doesn't break with postgresql
:order_column => "#{table_name}.id"
Eric Davis
Include the issue status in search results and the Activity page. (#3700)...
r2729 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
Jean-Philippe Lang
Different icon for closed issues in search result (#992)....
r2254 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
:type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Display latest user's activity on account/show view....
r2064 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
:author_key => :author_id
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037
DONE_RATIO_OPTIONS = %w(issue_field issue_status)
Eric Davis
Refactor: Replace @journal with @issue.current_journal...
r3426
attr_reader :current_journal
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
Eric Davis
Adds named scopes to replace custom finders....
r3443
Jean-Philippe Lang
Makes issue description a non-required field (#2456)....
r2244 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
Eric Davis
Adds named scopes to replace custom finders....
r3443
Jean-Philippe Lang
Added several validates_length_of...
r590 validates_length_of :subject, :maximum => 255
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 validates_inclusion_of :done_ratio, :in => 0..100
Jean-Philippe Lang
Negative estimated hours should not be valid (#12735)....
r10895 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
Jean-Philippe Lang
Adds a custom validator for dates (#12736)....
r10894 validates :start_date, :date => true
validates :due_date, :date => true
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 validate :validate_issue, :validate_required_fields
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330
Jean-Philippe Lang
Rewrites named scopes with ARel queries....
r10723 scope :visible, lambda {|*args|
includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
}
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Toshi MARUYAMA
model: replace Rails2 "named_scope" to Rails3 "scope"...
r9355 scope :open, lambda {|*args|
Jean-Philippe Lang
Use open scope in version issues count methods....
r8165 is_closed = args.size > 0 ? !args.first : false
Jean-Philippe Lang
Rewrites named scopes with ARel queries....
r10723 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
Jean-Philippe Lang
Use open scope in version issues count methods....
r8165 }
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037
Jean-Philippe Lang
Rewrites named scopes with ARel queries....
r10723 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
scope :on_active_project, lambda {
includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
}
Jean-Philippe Lang
Gantt perf: fixed that Project#start_date and #due_date run way too much queries....
r10905 scope :fixed_version, lambda {|versions|
ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
ids.any? ? where(:fixed_version_id => ids) : where('1=0')
}
Eric Davis
Rewrite the Gantt chart. #6276...
r3958
Jean-Philippe Lang
Fixed: journal details duplicated when an issue is saved twice (#3690)....
r3385 before_create :default_assign
Jean-Philippe Lang
Adds closed_on column that stores the time of the last closing (#824)....
r11172 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
Jean-Philippe Lang
Fixed: precedes/follows relations no longer update start/due dates (#5803)....
r4149 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 # Should be after_create but would be called before previous after_save callbacks
after_save :after_create_from_copy
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 after_destroy :update_parent_attributes
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds Issue#visible_condition to build issue visibility statement....
r5021 # Returns a SQL conditions string used to find all issues visible by the specified user
def self.visible_condition(user, options={})
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
Jean-Philippe Lang
Anonymous users should always see public issues only (#11872)....
r10254 if user.logged?
case role.issues_visibility
when 'all'
nil
when 'default'
Jean-Philippe Lang
Anonymous users should not see private issues with anonymous author (#11872)....
r10250 user_ids = [user.id] + user.groups.map(&:id)
"(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
Jean-Philippe Lang
Anonymous users should always see public issues only (#11872)....
r10254 when 'own'
Jean-Philippe Lang
Anonymous users should not see private issues with anonymous author (#11872)....
r10250 user_ids = [user.id] + user.groups.map(&:id)
"(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
else
'1=0'
end
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 else
Jean-Philippe Lang
Anonymous users should always see public issues only (#11872)....
r10254 "(#{table_name}.is_private = #{connection.quoted_false})"
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 end
end
Jean-Philippe Lang
Adds Issue#visible_condition to build issue visibility statement....
r5021 end
Jean-Philippe Lang
Fixed: issue details view discloses relations to issues that the user is not allowed to view (#2589)....
r2341 # Returns true if usr or current user is allowed to view the issue
def visible?(usr=nil)
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
Jean-Philippe Lang
Anonymous users should always see public issues only (#11872)....
r10254 if user.logged?
case role.issues_visibility
when 'all'
true
when 'default'
!self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
when 'own'
self.author == user || user.is_or_belongs_to?(assigned_to)
else
false
end
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 else
Jean-Philippe Lang
Anonymous users should always see public issues only (#11872)....
r10254 !self.is_private?
Jean-Philippe Lang
Adds an issues visibility level on roles (#7412)....
r5296 end
end
Jean-Philippe Lang
Fixed: issue details view discloses relations to issues that the user is not allowed to view (#2589)....
r2341 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Code cleanup, use named routes....
r10838 # Returns true if user or current user is allowed to edit or add a note to the issue
def editable?(user=User.current)
user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
end
Jean-Philippe Lang
Removed after_initialize methods....
r8168 def initialize(attributes=nil, *args)
super
Jean-Philippe Lang
Added default value for enumerations....
r792 if new_record?
# set default values for new records only
self.status ||= IssueStatus.default
Eric Davis
Changed Enumerations to use a Single Table Inheritance...
r2677 self.priority ||= IssuePriority.default
Jean-Philippe Lang
Initialize watcher_user_ids for new records to prevent useless queries on each #watched_by?....
r8434 self.watcher_user_ids = []
Jean-Philippe Lang
Added default value for enumerations....
r792 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds Issue#status_was that returns the initial issue status....
r11182 def create_or_update
super
ensure
@status_was = nil
end
private :create_or_update
Jean-Philippe Lang
Fixed that deleting a project with subtasks may fail (#11185)....
r9675 # AR#Persistence#destroy would raise and RecordNotFound exception
# if the issue was already deleted or updated (non matching lock_version).
# This is a problem when bulk deleting issues or deleting a project
# (because an issue may already be deleted if its parent was deleted
# first).
# The issue is reloaded by the nested_set before being deleted so
# the lock_version condition should not be an issue but we handle it.
def destroy
super
rescue ActiveRecord::RecordNotFound
# Stale or already deleted
begin
reload
rescue ActiveRecord::RecordNotFound
# The issue was actually already deleted
@destroyed = true
return freeze
end
# The issue was stale, retry to destroy
super
end
Jean-Philippe Lang
Fixed that #reload raises a Stack too deep error with ruby 2.0....
r11267 alias :base_reload :reload
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 def reload(*args)
@workflow_rule_by_attribute = nil
Jean-Philippe Lang
Versions that are not shared should not be assignable when selecting another project (#11506)....
r9903 @assignable_versions = nil
Jean-Philippe Lang
Fixed that relations may not be refreshed when adding a follows relation (#13251)....
r11231 @relations = nil
Jean-Philippe Lang
Fixed that #reload raises a Stack too deep error with ruby 2.0....
r11267 base_reload(*args)
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 end
Jean-Philippe Lang
Custom fields refactoring: most of code moved from controllers to models (using new module ActsAsCustomizable)....
r1578 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
def available_custom_fields
Jean-Philippe Lang
Save queries....
r5125 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
Jean-Philippe Lang
Custom fields refactoring: most of code moved from controllers to models (using new module ActsAsCustomizable)....
r1578 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Use the regular issue form to copy a single issue....
r8432 # Copies attributes from another issue, arg can be an id or an Issue
Jean-Philippe Lang
Adds an option of the copy form to enable/disable attachments copy (#3055)....
r8557 def copy_from(arg, options={})
Eric Davis
Only copy visible issues....
r3584 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
Jean-Philippe Lang
Copy issue status on project copy (#3877)....
r2961 self.status = issue.status
Jean-Philippe Lang
Code cleanup....
r8405 self.author = User.current
Jean-Philippe Lang
Adds an option of the copy form to enable/disable attachments copy (#3055)....
r8557 unless options[:attachments] == false
self.attachments = issue.attachments.map do |attachement|
attachement.copy(:container => self)
end
Jean-Philippe Lang
Copy attachments on issue and project copy (#3055)....
r8556 end
Jean-Philippe Lang
Use the regular issue form to copy a single issue....
r8432 @copied_from = issue
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 @copy_options = options
Jean-Philippe Lang
Added the hability to copy an issue....
r860 self
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Deprecated Issue#move_to_project....
r8419 # Returns an unsaved copy of the issue
Jean-Philippe Lang
Fixed MissingFeatureException: let user choose to copy attachments or not when bulk copying issues....
r9271 def copy(attributes=nil, copy_options={})
copy = self.class.new.copy_from(self, copy_options)
Jean-Philippe Lang
Deprecated Issue#move_to_project....
r8419 copy.attributes = attributes if attributes
copy
end
Jean-Philippe Lang
Use the regular issue form to copy a single issue....
r8432 # Returns true if the issue is a copy
def copy?
@copied_from.present?
end
Jean-Philippe Lang
Adds ability to bulk copy issues (#1847)....
r2311 # Moves/copies an issue to a new project and tracker
# Returns the moved/copied issue on success, false on failure
Jean-Philippe Lang
Code cleanup....
r8407 def move_to_project(new_project, new_tracker=nil, options={})
Jean-Philippe Lang
Deprecated Issue#move_to_project....
r8419 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
Etienne Massip
Save an @Issue#save@....
r8092 if options[:copy]
Jean-Philippe Lang
Deprecated Issue#move_to_project....
r8419 issue = self.copy
Etienne Massip
Save an @Issue#save@....
r8092 else
issue = self
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Code cleanup....
r8406 issue.init_journal(User.current, options[:notes])
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 # Preserve previous behaviour
# #move_to_project doesn't change tracker automatically
issue.send :project=, new_project, true
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 if new_tracker
issue.tracker = new_tracker
end
# Allow bulk setting of attributes on the issue
if options[:attributes]
issue.attributes = options[:attributes]
end
Jean-Philippe Lang
Code cleanup....
r8406
Jean-Philippe Lang
Code cleanup....
r8407 issue.save ? issue : false
Jean-Philippe Lang
Fixed: Update of time entry fails when the issue has been moved to an other project....
r896 end
Jean-Philippe Lang
Cleans up status assignment in IssuesController#new handled by Issue#safe_attributes= now....
r3492
def status_id=(sid)
self.status = nil
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 result = write_attribute(:status_id, sid)
@workflow_rule_by_attribute = nil
result
Jean-Philippe Lang
Cleans up status assignment in IssuesController#new handled by Issue#safe_attributes= now....
r3492 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Added default value for enumerations....
r792 def priority_id=(pid)
self.priority = nil
write_attribute(:priority_id, pid)
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 end
Jean-Philippe Lang
Enable tracker update on issue edit form (#2405)....
r2994
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 def category_id=(cid)
self.category = nil
write_attribute(:category_id, cid)
end
def fixed_version_id=(vid)
self.fixed_version = nil
write_attribute(:fixed_version_id, vid)
end
Jean-Philippe Lang
Enable tracker update on issue edit form (#2405)....
r2994 def tracker_id=(tid)
self.tracker = nil
Jean-Philippe Lang
Fixes tracker_id and custom_field_values assignment order for issues (#4353)....
r3025 result = write_attribute(:tracker_id, tid)
@custom_field_values = nil
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 @workflow_rule_by_attribute = nil
Jean-Philippe Lang
Fixes tracker_id and custom_field_values assignment order for issues (#4353)....
r3025 result
Jean-Philippe Lang
Enable tracker update on issue edit form (#2405)....
r2994 end
Toshi MARUYAMA
remove trailing white-spaces except SQL from app/models/issue.rb....
r6396
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 def project_id=(project_id)
if project_id.to_s != self.project_id.to_s
self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
end
end
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 def project=(project, keep_tracker=false)
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 project_was = self.project
write_attribute(:project_id, project ? project.id : nil)
association_instance_set('project', project)
if project_was && project && project_was != project
Jean-Philippe Lang
Versions that are not shared should not be assignable when selecting another project (#11506)....
r9903 @assignable_versions = nil
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 unless keep_tracker || project.trackers.include?(tracker)
self.tracker = project.trackers.first
end
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 # Reassign to the category with same name if any
if category
self.category = project.issue_categories.find_by_name(category.name)
end
# Keep the fixed_version if it's still valid in the new_project
if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
self.fixed_version = nil
end
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 # Clear the parent task if it's no longer valid
unless valid_parent_project?
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 self.parent_issue_id = nil
end
@custom_field_values = nil
end
end
Jean-Philippe Lang
Normalize issue description EOLs do prevent false journal details (#8712)....
r6029 def description=(arg)
if arg.is_a?(String)
arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
end
write_attribute(:description, arg)
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Merged rails-3.2 branch....
r9346 # Overrides assign_attributes so that project and tracker get assigned first
def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
Jean-Philippe Lang
Fixes tracker_id and custom_field_values assignment order for issues (#4353)....
r3025 return if new_attributes.nil?
Jean-Philippe Lang
Makes project and tracker assigned first in #attributes=...
r8011 attrs = new_attributes.dup
attrs.stringify_keys!
%w(project project_id tracker tracker_id).each do |attr|
if attrs.has_key?(attr)
send "#{attr}=", attrs.delete(attr)
end
Jean-Philippe Lang
Fixes tracker_id and custom_field_values assignment order for issues (#4353)....
r3025 end
Jean-Philippe Lang
Merged rails-3.2 branch....
r9346 send :assign_attributes_without_project_and_tracker_first, attrs, *args
Jean-Philippe Lang
Fixes tracker_id and custom_field_values assignment order for issues (#4353)....
r3025 end
Jean-Philippe Lang
Fixed: SystemStackError (stack level too deep) on Issue#attributes= after model reload (#4838)....
r3313 # Do not redefine alias chain on reload (see #4838)
Jean-Philippe Lang
Merged rails-3.2 branch....
r9346 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Estimated time recognizes improved time formats (#1092)....
r1346 def estimated_hours=(h)
write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 safe_attributes 'project_id',
:if => lambda {|issue, user|
Jean-Philippe Lang
Use the regular issue form to copy a single issue....
r8432 if issue.new_record?
issue.copy?
elsif user.allowed_to?(:move_issues, issue.project)
Jean-Philippe Lang
Check permission before retrieving projects....
r8412 projects = Issue.allowed_target_projects_on_move(user)
projects.include?(issue.project) && projects.size > 1
end
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 }
Jean-Philippe Lang
Makes issue safe_attributes extensible (#6000)....
r4377 safe_attributes 'tracker_id',
'status_id',
'category_id',
'assigned_to_id',
'priority_id',
'fixed_version_id',
'subject',
'description',
'start_date',
'due_date',
'done_ratio',
'estimated_hours',
'custom_field_values',
'custom_fields',
'lock_version',
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 'notes',
Jean-Philippe Lang
Makes issue safe_attributes extensible (#6000)....
r4377 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Makes issue safe_attributes extensible (#6000)....
r4377 safe_attributes 'status_id',
'assigned_to_id',
'fixed_version_id',
'done_ratio',
Jean-Philippe Lang
Display issue form fields according to permissions....
r8107 'lock_version',
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 'notes',
Jean-Philippe Lang
Makes issue safe_attributes extensible (#6000)....
r4377 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
Jean-Philippe Lang
Moved some permission checks for issue update from controller to model....
r4279
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 safe_attributes 'notes',
:if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
safe_attributes 'private_notes',
:if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
Jean-Philippe Lang
Use safe_attributes for issue watchers assignment....
r8077 safe_attributes 'watcher_user_ids',
:if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
Jean-Philippe Lang
Private issues (#7414)....
r5346 safe_attributes 'is_private',
:if => lambda {|issue, user|
user.allowed_to?(:set_issues_private, issue.project) ||
(issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
}
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Code cleanup....
r8078 safe_attributes 'parent_issue_id',
:if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
user.allowed_to?(:manage_subtasks, issue.project)}
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 def safe_attribute_names(user=nil)
names = super
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 names -= disabled_core_fields
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 names -= read_only_attribute_names(user)
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 names
end
Jean-Philippe Lang
Set a white list of issue attributes that can be mass-assigned from controllers....
r3194 # Safely sets attributes
# Should be called from controllers instead of #attributes=
# attr_accessible is too rough because we still want things like
# Issue.new(:project => foo) to work
def safe_attributes=(attrs, user=User.current)
Jean-Philippe Lang
Moved some permission checks for issue update from controller to model....
r4279 return unless attrs.is_a?(Hash)
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 attrs = attrs.dup
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
Jean-Philippe Lang
Check project assignment on issue copy/move....
r8433 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
self.project_id = p
end
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 end
Jean-Philippe Lang
Check project assignment on issue copy/move....
r8433
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
Jean-Philippe Lang
Makes MailHandler accept all issue attributes and custom fields that can be set/updated (#4071, #4807, #5622, #6110)....
r4280 self.tracker_id = t
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
self.status_id = s
Jean-Philippe Lang
Bulk edit refactoring....
r3364 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 attrs = delete_unsafe_attributes(attrs, user)
return if attrs.empty?
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 unless leaf?
attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Code cleanup....
r8078 if attrs['parent_issue_id'].present?
Jean-Philippe Lang
Fixed that entering #nnn as parent task should validate (#11979)....
r10447 s = attrs['parent_issue_id'].to_s
Jean-Philippe Lang
"Parent task is invalid" while editing child issues with restricted Issues Visibility (#12851)....
r10998 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
Jean-Philippe Lang
Fixed: No validation errors when entering an invalid "Parent task" (#11979)....
r10404 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
end
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 if attrs['custom_field_values'].present?
attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
end
if attrs['custom_fields'].present?
attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
end
Jean-Philippe Lang
Use safe_attributes for issue watchers assignment....
r8077 # mass-assignment security bypass
Jean-Philippe Lang
Merged rails-3.2 branch....
r9346 assign_attributes attrs, :without_protection => true
Jean-Philippe Lang
Set a white list of issue attributes that can be mass-assigned from controllers....
r3194 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Ability to disable standard fields on a per tracker basis (#1091)....
r9729 def disabled_core_fields
tracker ? tracker.disabled_core_fields : []
end
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 # Returns the custom_field_values that can be edited by the given user
def editable_custom_field_values(user=nil)
custom_field_values.reject do |value|
read_only_attribute_names(user).include?(value.custom_field_id.to_s)
end
end
# Returns the names of attributes that are read-only for user or the current user
# For users with multiple roles, the read-only fields are the intersection of
# read-only fields of each role
# The result is an array of strings where sustom fields are represented with their ids
#
# Examples:
# issue.read_only_attribute_names # => ['due_date', '2']
# issue.read_only_attribute_names(user) # => []
def read_only_attribute_names(user=nil)
Jean-Philippe Lang
ruby1.8 compatibility (#703, #3521)....
r9802 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 end
# Returns the names of required attributes for user or the current user
# For users with multiple roles, the required fields are the intersection of
# required fields of each role
# The result is an array of strings where sustom fields are represented with their ids
#
# Examples:
# issue.required_attribute_names # => ['due_date', '2']
# issue.required_attribute_names(user) # => []
def required_attribute_names(user=nil)
Jean-Philippe Lang
ruby1.8 compatibility (#703, #3521)....
r9802 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 end
# Returns true if the attribute is required for user
def required_attribute?(name, user=nil)
required_attribute_names(user).include?(name.to_s)
end
# Returns a hash of the workflow rule by attribute for the given user
#
# Examples:
# issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
def workflow_rule_by_attribute(user=nil)
return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
user_real = user || User.current
roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
return {} if roles.empty?
result = {}
workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
if workflow_permissions.any?
workflow_rules = workflow_permissions.inject({}) do |h, wp|
h[wp.field_name] ||= []
h[wp.field_name] << wp.rule
h
end
workflow_rules.each do |attr, rules|
next if rules.size < roles.size
uniq_rules = rules.uniq
if uniq_rules.size == 1
result[attr] = uniq_rules.first
else
result[attr] = 'required'
end
end
end
@workflow_rule_by_attribute = result if user.nil?
result
end
private :workflow_rule_by_attribute
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037 def done_ratio
Eric Davis
Fixes reverting an issue to a status with a done_ratio of 0%. #5170...
r4072 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
Jean-Philippe Lang
Issue#done_ratio should not break if status is nil....
r3045 status.default_done_ratio
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037 else
read_attribute(:done_ratio)
end
end
def self.use_status_for_done_ratio?
Setting.issue_done_ratio == 'issue_status'
end
def self.use_field_for_done_ratio?
Setting.issue_done_ratio == 'issue_field'
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Toshi MARUYAMA
Rails3: model: replace deprecated 'validate' method at Issue model...
r7309 def validate_issue
Jean-Philippe Lang
Code cleanup....
r10460 if due_date && start_date && due_date < start_date
Jean-Philippe Lang
Merged Rails 2.2 branch. Redmine now requires Rails 2.2.2....
r2430 errors.add :due_date, :greater_than_start_date
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 if start_date && soonest_start && start_date < soonest_start
Jean-Philippe Lang
Merged Rails 2.2 branch. Redmine now requires Rails 2.2.2....
r2430 errors.add :start_date, :invalid
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds version status to limit issue assignments (#1245)....
r2906 if fixed_version
if !assignable_versions.include?(fixed_version)
errors.add :fixed_version_id, :inclusion
elsif reopened? && fixed_version.closed?
Toshi MARUYAMA
Rails3: model: replace deprecated errors.add_to_base at validate_issue of Issue...
r7470 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
Jean-Philippe Lang
Adds version status to limit issue assignments (#1245)....
r2906 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Enable tracker update on issue edit form (#2405)....
r2994 # Checks that the issue can not be added/moved to a disabled tracker
if project && (tracker_id_changed? || project_id_changed?)
unless project.trackers.include?(tracker)
errors.add :tracker_id, :inclusion
end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # Checks parent issue assignment
Jean-Philippe Lang
Fixed: No validation errors when entering an invalid "Parent task" (#11979)....
r10404 if @invalid_parent_issue_id.present?
errors.add :parent_issue_id, :invalid
elsif @parent_issue
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 if !valid_parent_project?(@parent_issue)
errors.add :parent_issue_id, :invalid
Jean-Philippe Lang
Fixed: Circular loop when using relations and subtasks (#8794)....
r11411 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
errors.add :parent_issue_id, :invalid
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 elsif !new_record?
# moving an existing issue
if @parent_issue.root_id != root_id
# we can always move to another tree
elsif move_possible?(@parent_issue)
# move accepted inside tree
else
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 errors.add :parent_issue_id, :invalid
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 end
end
end
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Workflow enhancement: editable and required fields configurable by role, tracker and status (#703, #3521)....
r9794 # Validates the issue against additional workflow requirements
def validate_required_fields
user = new_record? ? author : current_journal.try(:user)
required_attribute_names(user).each do |attribute|
if attribute =~ /^\d+$/
attribute = attribute.to_i
v = custom_field_values.detect {|v| v.custom_field_id == attribute }
if v && v.value.blank?
errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
end
else
if respond_to?(attribute) && send(attribute).blank?
errors.add attribute, :blank
end
end
end
end
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
# even if the user turns off the setting later
def update_done_ratio_from_issue_status
Eric Davis
Fixes reverting an issue to a status with a done_ratio of 0%. #5170...
r4072 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
Jean-Philippe Lang
Allow blank value for IssueStatus#default_done_ratio....
r3043 self.done_ratio = status.default_done_ratio
Eric Davis
Adds a Setting to control how an Issue's done_ratio is calculated:...
r3037 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 def init_journal(user, notes = "")
@current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
Jean-Philippe Lang
Code cleanup....
r8406 if new_record?
@current_journal.notify = false
else
@attributes_before_change = attributes.dup
@custom_values_before_change = {}
Jean-Philippe Lang
Adds support for multiselect custom fields (#1189)....
r8601 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
Jean-Philippe Lang
Code cleanup....
r8406 end
Jean-Philippe Lang
added svn:eol-style native property on /app files...
r330 @current_journal
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Better handling of issue update conflicts (#8691)....
r8654 # Returns the id of the last journal or nil
def last_journal_id
if new_record?
nil
else
Jean-Philippe Lang
Code cleanup....
r9994 journals.maximum(:id)
Jean-Philippe Lang
Better handling of issue update conflicts (#8691)....
r8654 end
end
Jean-Philippe Lang
Code cleanup....
r9996 # Returns a scope for journals that have an id greater than journal_id
def journals_after(journal_id)
scope = journals.reorder("#{Journal.table_name}.id ASC")
if journal_id.present?
scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
end
scope
end
Jean-Philippe Lang
Adds Issue#status_was that returns the initial issue status....
r11182 # Returns the initial status of the issue
# Returns nil for a new issue
def status_was
if status_id_was && status_id_was.to_i > 0
@status_was ||= IssueStatus.find_by_id(status_id_was)
end
end
Jean-Philippe Lang
Automatic closing of duplicate issues....
r657 # Return true if the issue is closed, otherwise false
def closed?
self.status.is_closed?
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds version status to limit issue assignments (#1245)....
r2906 # Return true if the issue is being reopened
def reopened?
if !new_record? && status_id_changed?
status_was = IssueStatus.find_by_id(status_id_was)
status_new = IssueStatus.find_by_id(status_id)
if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
return true
end
end
false
end
Jean-Philippe Lang
Fixed: journal details duplicated when an issue is saved twice (#3690)....
r3385
# Return true if the issue is being closed
def closing?
if !new_record? && status_id_changed?
Jean-Philippe Lang
Adds Issue#status_was that returns the initial issue status....
r11182 if status_was && status && !status_was.is_closed? && status.is_closed?
Jean-Philippe Lang
Fixed: journal details duplicated when an issue is saved twice (#3690)....
r3385 return true
end
end
false
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds a css class (overdue) to overdue issues on issue lists and detail views (#2337)....
r2138 # Returns true if the issue is overdue
def overdue?
Jean-Philippe Lang
Closed issue are not overdue, fixes r2140 (#2337)....
r2357 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
Jean-Philippe Lang
Adds a css class (overdue) to overdue issues on issue lists and detail views (#2337)....
r2138 end
Eric Davis
Rewrite the Gantt chart. #6276...
r3958
# Is the amount of work done less than it should for the due date
def behind_schedule?
return false if start_date.nil? || due_date.nil?
done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
return done_date <= Date.today
end
Eric Davis
Updated issue delete confirmation when it has child issues. #6191...
r3991
# Does this issue have children?
def children?
!leaf?
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Added a 'Assignable' boolean on Role model....
r643 # Users the issue can be assigned to
def assignable_users
Eric Davis
Allow assigning issues back to the author. #4199...
r4126 users = project.assignable_users
users << author if author
Jean-Philippe Lang
Assignee is removed on issue update if assignee account is locked (#8884)....
r6188 users << assigned_to if assigned_to
Eric Davis
Don't duplicate users in Issue#assignable_users. From r4240...
r4127 users.uniq.sort
Jean-Philippe Lang
Added a 'Assignable' boolean on Role model....
r643 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds version status to limit issue assignments (#1245)....
r2906 # Versions that the issue can be assigned to
def assignable_versions
Jean-Philippe Lang
Versions that are not shared should not be assignable when selecting another project (#11506)....
r9903 return @assignable_versions if @assignable_versions
versions = project.shared_versions.open.all
if fixed_version
if fixed_version_id_changed?
# nothing to do
elsif project_id_changed?
if project.shared_versions.include?(fixed_version)
versions << fixed_version
end
else
versions << fixed_version
end
end
@assignable_versions = versions.uniq.sort
Jean-Philippe Lang
Adds version status to limit issue assignments (#1245)....
r2906 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Actually block issues from closing when a blocking issue isn't closed (#1740)....
r2700 # Returns true if this issue is blocked by another issue that is still open
def blocked?
!relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Fixed that improper statuses are proposed when changing status before tracker on the issue form (#10619)....
r9244 # Returns an array of statuses that user is able to apply
Jean-Philippe Lang
Code cleanup....
r8706 def new_statuses_allowed_to(user=User.current, include_default=false)
Jean-Philippe Lang
When copying issues, let the status be changed to default or left unchanged....
r9270 if new_record? && @copied_from
[IssueStatus.default, @copied_from.status].compact.uniq.sort
else
initial_status = nil
if new_record?
initial_status = IssueStatus.default
elsif status_id_was
initial_status = IssueStatus.find_by_id(status_id_was)
end
initial_status ||= status
statuses = initial_status.find_new_statuses_allowed_to(
user.admin ? Role.all : user.roles_for_project(project),
tracker,
author == user,
assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
)
statuses << initial_status unless statuses.empty?
statuses << IssueStatus.default if include_default
statuses = statuses.compact.uniq.sort
blocked? ? statuses.reject {|s| s.is_closed?} : statuses
end
Jean-Philippe Lang
Merged IssuesController change_status and add_note actions....
r1030 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Notify previous assignee when assignee changes (#2694)....
r8575 def assigned_to_was
if assigned_to_id_changed? && assigned_to_id_was.present?
@assigned_to_was ||= User.find_by_id(assigned_to_id_was)
end
end
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 # Returns the users that should be notified
def notified_users
Jean-Philippe Lang
Notify previous assignee when assignee changes (#2694)....
r8575 notified = []
Eric Davis
Added User#notify_about? to check when a user should be notified about an event...
r4104 # Author and assignee are always notified unless they have been
# locked or don't want to be notified
Jean-Philippe Lang
Notify previous assignee when assignee changes (#2694)....
r8575 notified << author if author
Jean-Philippe Lang
Ability to assign issues to groups (#2964)....
r6186 if assigned_to
Jean-Philippe Lang
Notify previous assignee when assignee changes (#2694)....
r8575 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
end
if assigned_to_was
notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
Jean-Philippe Lang
Ability to assign issues to groups (#2964)....
r6186 end
Jean-Philippe Lang
Notify previous assignee when assignee changes (#2694)....
r8575 notified = notified.select {|u| u.active? && u.notify_about?(self)}
notified += project.notified_users
Jean-Philippe Lang
Do not notify users that are no longer allowed to view an issue (#3589, #4263)....
r3007 notified.uniq!
# Remove users that can not view the issue
notified.reject! {|user| !visible?(user)}
Jean-Philippe Lang
Private issue notes (#1554)....
r10336 notified
end
# Returns the email addresses that should be notified
def recipients
notified_users.collect(&:mail)
Jean-Philippe Lang
Do not notify users that are no longer allowed to view an issue (#3589, #4263)....
r3007 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Makes spent time column available on the issue list (#971)....
r7953 # Returns the number of hours spent on this issue
def spent_hours
@spent_hours ||= time_entries.sum(:hours) || 0
end
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # Returns the total number of hours spent on this issue and its descendants
Eric Davis
Added some RDoc documentation for some models....
r2536 #
# Example:
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # spent_hours => 0.0
# spent_hours => 50.2
Jean-Philippe Lang
Makes spent time column available on the issue list (#971)....
r7953 def total_spent_hours
Jean-Philippe Lang
Rails3.1 compatibility...
r8155 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
:joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
Jean-Philippe Lang
Simple time tracking functionality added. Time can be logged at issue or project level....
r365 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 def relations
Jean-Philippe Lang
Moved IssueRelations to IssueRelation::Relations....
r10750 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
Jean-Philippe Lang
Ability to load relations on /issues API (#7366)....
r6193 end
Toshi MARUYAMA
remove trailing white-spaces except SQL from app/models/issue.rb....
r6396
Jean-Philippe Lang
Ability to load relations on /issues API (#7366)....
r6193 # Preloads relations for a collection of issues
def self.load_relations(issues)
if issues.any?
relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
issues.each do |issue|
issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
end
end
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 end
Toshi MARUYAMA
remove trailing white-spaces except SQL from app/models/issue.rb....
r6396
Jean-Philippe Lang
Makes spent time column available on the issue list (#971)....
r7953 # Preloads visible spent time for a collection of issues
def self.load_visible_spent_hours(issues, user=User.current)
if issues.any?
hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
issues.each do |issue|
issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
end
end
end
Jean-Philippe Lang
Makes related issues available for display and filtering on the issue list (#3239, #3265)....
r10303 # Preloads visible relations for a collection of issues
def self.load_visible_relations(issues, user=User.current)
if issues.any?
issue_ids = issues.map(&:id)
# Relations with issue_from in given issues and visible issue_to
relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
# Relations with issue_to in given issues and visible issue_from
relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
issues.each do |issue|
relations =
relations_from.select {|relation| relation.issue_from_id == issue.id} +
relations_to.select {|relation| relation.issue_to_id == issue.id}
Jean-Philippe Lang
Moved IssueRelations to IssueRelation::Relations....
r10750 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
Jean-Philippe Lang
Makes related issues available for display and filtering on the issue list (#3239, #3265)....
r10303 end
end
end
Jean-Philippe Lang
Adds REST API for issue relations (#7366)....
r6056 # Finds an issue relation given its id.
def find_relation(relation_id)
IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Code cleanup....
r11412 # Returns all the other issues that depend on the issue
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 # The algorithm is a modified breadth first search (bfs)
Jean-Philippe Lang
Prevent SystemStackError on Issue#all_dependent_issues with mutiple circular dependencies (#7320)....
r4984 def all_dependent_issues(except=[])
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 # The found dependencies
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 dependencies = []
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597
# The visited flag for every node (issue) used by the breadth first search
eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
# the issue when it is processed.
ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
# but its children will not be added to the queue when it is processed.
eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
# the queue, but its children have not been added.
ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
# the children still need to be processed.
eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
# added as dependent issues. It needs no further processing.
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status = Hash.new(eNOT_DISCOVERED)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597
# The queue
queue = []
# Initialize the bfs, add start node (self) to the queue
queue << self
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[self] = ePROCESS_ALL
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597
while (!queue.empty?) do
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 current_issue = queue.shift
current_issue_status = issue_status[current_issue]
dependencies << current_issue
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597
# Add parent to queue, if not already in it.
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 parent = current_issue.parent
parentStatus = issue_status[parent]
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597
Jean-Philippe Lang
Removes then's (#14015)....
r11599 if parent && (parentStatus == eNOT_DISCOVERED) && !except.include?(parent)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << parent
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[parent] = ePROCESS_RELATIONS_ONLY
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 end
# Add children to queue, but only if they are not already in it and
# the children of the current node need to be processed.
Jean-Philippe Lang
Removes then's (#14015)....
r11599 if current_issue.children && (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 current_issue.children.each do |child|
if (issue_status[child] == eNOT_DISCOVERED) && !except.include?(child)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << child
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[child] = ePROCESS_ALL
elsif (issue_status[child] == eRELATIONS_PROCESSED) && !except.include?(child)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << child
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[child] = ePROCESS_CHILDREN_ONLY
elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY) && !except.include?(child)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << child
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[child] = ePROCESS_ALL
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 end
end
end
# Add related issues to the queue, if they are not already in it.
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 current_issue.relations_from.map(&:issue_to).each do |relatedIssue|
Jean-Philippe Lang
Removes then's (#14015)....
r11599 if (issue_status[relatedIssue] == eNOT_DISCOVERED) && !except.include?(relatedIssue)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << relatedIssue
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[relatedIssue] = ePROCESS_ALL
Jean-Philippe Lang
Removes then's (#14015)....
r11599 elsif (issue_status[relatedIssue] == eRELATIONS_PROCESSED) && !except.include?(relatedIssue)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << relatedIssue
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[relatedIssue] = ePROCESS_CHILDREN_ONLY
Jean-Philippe Lang
Removes then's (#14015)....
r11599 elsif (issue_status[relatedIssue] == ePROCESS_RELATIONS_ONLY) && !except.include?(relatedIssue)
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 queue << relatedIssue
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[relatedIssue] = ePROCESS_ALL
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 end
end
# Set new status for current issue
Jean-Philippe Lang
Removes then's (#14015)....
r11599 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[current_issue] = eALL_PROCESSED
Jean-Philippe Lang
Removes then's (#14015)....
r11599 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
Jean-Philippe Lang
Replaces camelcase variable names (#14015)....
r11598 issue_status[current_issue] = eRELATIONS_PROCESSED
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 end
end # while
# Remove the issues from the "except" parameter from the result array
Jean-Philippe Lang
Code cleanup....
r11412 dependencies -= except
Jean-Philippe Lang
Improved Issue#all_dependent_issues (#14015)....
r11597 dependencies.delete(self)
Jean-Philippe Lang
Fixed that r11641 prevents precedes/follows relations between subtasks (#13586)....
r11462 dependencies
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Make the 'duplicates of' relation asymmetric:...
r1474 # Returns an array of issues that duplicate this one
Jean-Philippe Lang
Automatic closing of duplicate issues....
r657 def duplicates
Jean-Philippe Lang
Make the 'duplicates of' relation asymmetric:...
r1474 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
Jean-Philippe Lang
Automatic closing of duplicate issues....
r657 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Gantt chart: display issues that don't have a due date if they are assigned to a version with a date (#184)....
r1441 # Returns the due date or the target due date if any
# Used on gantt chart
def due_before
due_date || (fixed_version ? fixed_version.effective_date : nil)
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Eric Davis
Added some RDoc documentation for some models....
r2536 # Returns the time scheduled for this issue.
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690 #
Eric Davis
Added some RDoc documentation for some models....
r2536 # Example:
# Start Date: 2/26/09, End Date: 3/04/09
# duration => 6
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 def duration
(start_date && due_date) ? due_date - start_date : 0
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Ignore non-working days when rescheduling an issue (#2161)....
r10531 # Returns the duration in working days
def working_duration
(start_date && due_date) ? working_days(start_date, due_date) : 0
end
Jean-Philippe Lang
Precede-Follow relation should move following issues earlier when rescheduling issue earlier (#4590)....
r10651 def soonest_start(reload=false)
@soonest_start = nil if reload
Jean-Philippe Lang
Makes subtasks rescheduled when a 'precedes' relation is set on a parent task....
r3460 @soonest_start ||= (
Jean-Philippe Lang
Precede-Follow relation should move following issues earlier when rescheduling issue earlier (#4590)....
r10651 relations_to(reload).collect{|relation| relation.successor_soonest_start} +
Jean-Philippe Lang
Fixed: subtasks don't resepect following/precedes relations on creation (#12968)....
r11410 [(@parent_issue || parent).try(:soonest_start)]
Jean-Philippe Lang
Makes subtasks rescheduled when a 'precedes' relation is set on a parent task....
r3460 ).compact.max
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Ignore non-working days when rescheduling an issue (#2161)....
r10531 # Sets start_date on the given date or the next working day
# and changes due_date to keep the same working duration.
def reschedule_on(date)
wd = working_duration
date = next_working_date(date)
self.start_date = date
self.due_date = add_working_days(date, wd)
end
# Reschedules the issue on the given date or the next working day and saves the record.
# If the issue is a parent task, this is done by rescheduling its subtasks.
def reschedule_on!(date)
Jean-Philippe Lang
Makes subtasks rescheduled when a 'precedes' relation is set on a parent task....
r3460 return if date.nil?
if leaf?
Jean-Philippe Lang
Precede-Follow relation should move following issues earlier when rescheduling issue earlier (#4590)....
r10651 if start_date.nil? || start_date != date
if start_date && start_date > date
# Issue can not be moved earlier than its soonest start date
date = [soonest_start(true), date].compact.max
end
Jean-Philippe Lang
Ignore non-working days when rescheduling an issue (#2161)....
r10531 reschedule_on(date)
Jean-Philippe Lang
Prevent ActiveRecord::StaleObjectError in Issue#reschedule_after (#7920)....
r8744 begin
save
rescue ActiveRecord::StaleObjectError
reload
Jean-Philippe Lang
Ignore non-working days when rescheduling an issue (#2161)....
r10531 reschedule_on(date)
Jean-Philippe Lang
Prevent ActiveRecord::StaleObjectError in Issue#reschedule_after (#7920)....
r8744 save
end
Jean-Philippe Lang
Makes subtasks rescheduled when a 'precedes' relation is set on a parent task....
r3460 end
else
leaves.each do |leaf|
Jean-Philippe Lang
Fixed the behaviour for when rescheduling a parent task (#4590)....
r10653 if leaf.start_date
# Only move subtask if it starts at the same date as the parent
# or if it starts before the given date
if start_date == leaf.start_date || date > leaf.start_date
leaf.reschedule_on!(date)
end
else
leaf.reschedule_on!(date)
end
Jean-Philippe Lang
Makes subtasks rescheduled when a 'precedes' relation is set on a parent task....
r3460 end
end
Jean-Philippe Lang
Issue relations first commit (not thoroughly tested). 4 kinds of relation are available:...
r503 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 def <=>(issue)
if issue.nil?
-1
elsif root_id != issue.root_id
(root_id || 0) <=> (issue.root_id || 0)
else
(lft || 0) <=> (issue.lft || 0)
end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Time report can be done at issue level (closes #970) + timelog views xhtml validation....
r1304 def to_s
"#{tracker} ##{id}: #{subject}"
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds more css classes to the roadmap issues (#3214)....
r2602 # Returns a string of css classes that apply to the issue
def css_classes
Jean-Philippe Lang
Adds "tracker-[id]" CSS class to issues (#13309)....
r11279 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
Jean-Philippe Lang
Adds more css classes to the roadmap issues (#3214)....
r2602 s << ' closed' if closed?
s << ' overdue' if overdue?
Jean-Philippe Lang
Adds css classes to parent/child issues (#7986)....
r5101 s << ' child' if child?
s << ' parent' unless leaf?
Jean-Philippe Lang
Private issues (#7414)....
r5346 s << ' private' if is_private?
Jean-Philippe Lang
Adds more css classes to the roadmap issues (#3214)....
r2602 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
s
end
Jean-Philippe Lang
Version sharing (#465) + optional inclusion of subprojects in the roadmap view (#2666)....
r3009
Jean-Philippe Lang
Better handling of attachments when issue validation fails (#10253)....
r8771 # Saves an issue and a time_entry from the parameters
Eric Davis
Refactor: Moved the contents of #issue_update into Issue....
r3431 def save_issue_with_child_records(params, existing_time_entry=nil)
Jean-Philippe Lang
Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails....
r3550 Issue.transaction do
Jean-Philippe Lang
Check for a valid time entry if comments have been entered when updating an issue (#7581)....
r4990 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
Jean-Philippe Lang
Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails....
r3550 @time_entry = existing_time_entry || TimeEntry.new
@time_entry.project = project
@time_entry.issue = self
@time_entry.user = User.current
Jean-Philippe Lang
Use user's time zone when logging time while editing ticket (#9619)....
r7798 @time_entry.spent_on = User.current.today
Jean-Philippe Lang
Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails....
r3550 @time_entry.attributes = params[:time_entry]
self.time_entries << @time_entry
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Better handling of attachments when issue validation fails (#10253)....
r8771 # TODO: Rename hook
Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
if save
Jean-Philippe Lang
Fixes Issue#save_issue_with_child_records so that time entry do not get saved if issue save fails....
r3550 # TODO: Rename hook
Jean-Philippe Lang
Better handling of attachments when issue validation fails (#10253)....
r8771 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
else
raise ActiveRecord::Rollback
Eric Davis
Refactor: Moved the contents of #issue_update into Issue....
r3431 end
end
end
Jean-Philippe Lang
Optimize updates of issue's shared versions....
r3023 # Unassigns issues from +version+ if it's no longer shared with issue's project
def self.update_versions_from_sharing_change(version)
# Update issues assigned to the version
update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Optimize updates of issue's shared versions....
r3023 # Unassigns issues from versions that are no longer shared
# after +project+ was moved
def self.update_versions_from_hierarchy_change(project)
moved_project_ids = project.self_and_descendants.reload.collect(&:id)
# Update issues of the moved projects and issues assigned to a version of a moved project
Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
end
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 def parent_issue_id=(arg)
Jean-Philippe Lang
Fixed: No validation errors when entering an invalid "Parent task" (#11979)....
r10404 s = arg.to_s.strip.presence
if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 @parent_issue.id
else
@parent_issue = nil
Jean-Philippe Lang
Fixed: No validation errors when entering an invalid "Parent task" (#11979)....
r10404 @invalid_parent_issue_id = arg
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 def parent_issue_id
Jean-Philippe Lang
Fixed: No validation errors when entering an invalid "Parent task" (#11979)....
r10404 if @invalid_parent_issue_id
@invalid_parent_issue_id
elsif instance_variable_defined? :@parent_issue
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 @parent_issue.nil? ? nil : @parent_issue.id
else
parent_id
end
end
Toshi MARUYAMA
replace tabs to spaces at app/models/issue.rb...
r11192 # Returns true if issue's project is a valid
# parent issue project
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 def valid_parent_project?(issue=parent)
return true if issue.nil? || issue.project_id == project_id
case Setting.cross_project_subtasks
when 'system'
true
when 'tree'
issue.project.root == project.root
when 'hierarchy'
issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
when 'descendants'
issue.project.is_or_is_ancestor_of?(project)
else
false
end
end
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 # Extracted from the ReportsController.
def self.by_tracker(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'tracker_id',
:joins => Tracker.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_version(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'fixed_version_id',
:joins => Version.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_priority(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'priority_id',
:joins => IssuePriority.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_category(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'category_id',
:joins => IssueCategory.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_assigned_to(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'assigned_to_id',
:joins => User.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_author(project)
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 count_and_group_by(:project => project,
:field => 'author_id',
:joins => User.table_name)
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
def self.by_subproject(project)
ActiveRecord::Base.connection.select_all("select s.id as status_id,
s.is_closed as closed,
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 #{Issue.table_name}.project_id as project_id,
count(#{Issue.table_name}.id) as total
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 from
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 where
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 #{Issue.table_name}.status_id=s.id
and #{Issue.table_name}.project_id = #{Project.table_name}.id
and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
and #{Issue.table_name}.project_id <> #{project.id}
group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
Eric Davis
Refactor: Moved the raw SQL finders from ReportsController to Issue....
r3248 end
# End ReportsController extraction
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Check project assignment on issue copy/move....
r8433 # Returns an array of projects that user can assign the issue to
def allowed_target_projects(user=User.current)
if new_record?
Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
else
self.class.allowed_target_projects_on_move(user)
end
end
# Returns an array of projects that user can move issues to
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 def self.allowed_target_projects_on_move(user=User.current)
Jean-Philippe Lang
Fixed that issues can be moved to projects with issue tracking disabled (#10467)....
r9139 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
Jean-Philippe Lang
Fixes behaviour of move_issues permission for non member role (#5309)....
r3569 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Optimize updates of issue's shared versions....
r3023 private
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 def after_project_change
# Update project_id on related time entries
TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
# Delete issue relations
unless Setting.cross_project_issue_relations?
relations_from.clear
relations_to.clear
end
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 # Move subtasks that were in the same project
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 children.each do |child|
Jean-Philippe Lang
Adds a setting to allow subtasks to belong to other projects (#5487)....
r10376 next unless child.project_id == project_id_was
Jean-Philippe Lang
Allows project to be changed from the regular issue update action (#4769, #9803)....
r8411 # Change project and keep project
child.send :project=, project, true
Jean-Philippe Lang
Extracted some code from #move_to_project to a callback....
r8404 unless child.save
raise ActiveRecord::Rollback
end
end
end
Jean-Philippe Lang
Adds a "Copied from/to" relation when copying issue(s) (#6899)....
r10282 # Callback for after the creation of an issue by copy
# * adds a "copied to" relation with the copied issue
# * copies subtasks from the copied issue
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 def after_create_from_copy
Jean-Philippe Lang
Adds a "Copied from/to" relation when copying issue(s) (#6899)....
r10282 return unless copy? && !@after_create_from_copy_handled
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144
Jean-Philippe Lang
Do not link copied issues when copying a project (#6899)....
r10286 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
Jean-Philippe Lang
Adds a "Copied from/to" relation when copying issue(s) (#6899)....
r10282 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
unless relation.save
logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
end
end
unless @copied_from.leaf? || @copy_options[:subtasks] == false
Jean-Philippe Lang
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
r11283 copy_options = (@copy_options || {}).merge(:subtasks => false)
copied_issue_ids = {@copied_from.id => self.id}
@copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
# Do not copy self when copying an issue as a descendant of the copied issue
next if child == self
# Do not copy subtasks of issues that were not copied
next unless copied_issue_ids[child.parent_id]
# Do not copy subtasks that are not visible to avoid potential disclosure of private data
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 unless child.visible?
logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
next
end
Jean-Philippe Lang
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
r11283 copy = Issue.new.copy_from(child, copy_options)
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 copy.author = author
copy.project = project
Jean-Philippe Lang
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
r11283 copy.parent_issue_id = copied_issue_ids[child.parent_id]
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 unless copy.save
logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
Jean-Philippe Lang
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
r11283 next
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 end
Jean-Philippe Lang
Fixed that copying an issue as a child of itself creates an extra issue (#13328)....
r11283 copied_issue_ids[child.id] = copy.id
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 end
end
Jean-Philippe Lang
Adds a "Copied from/to" relation when copying issue(s) (#6899)....
r10282 @after_create_from_copy_handled = true
Jean-Philippe Lang
Option to copy subtasks when copying issue(s) (#6965)....
r10144 end
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 def update_nested_set_attributes
if root_id.nil?
# issue was just created
self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
set_default_left_and_right
Jean-Philippe Lang
Code cleanup....
r11266 Issue.update_all(["root_id = ?, lft = ?, rgt = ?", root_id, lft, rgt], ["id = ?", id])
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 if @parent_issue
move_to_child_of(@parent_issue)
end
elsif parent_issue_id != parent_id
Eric Davis
Recalculate inherited attributes on parents when a child is moved under a new parent. #5524...
r3707 former_parent_id = parent_id
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # moving an existing issue
if @parent_issue && @parent_issue.root_id == root_id
# inside the same tree
move_to_child_of(@parent_issue)
else
# to another tree
unless root?
move_to_right_of(root)
end
old_root_id = root_id
self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
target_maxright = nested_set_scope.maximum(right_column_name) || 0
offset = target_maxright + 1 - lft
Jean-Philippe Lang
Code cleanup....
r11266 Issue.update_all(["root_id = ?, lft = lft + ?, rgt = rgt + ?", root_id, offset, offset],
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
self[left_column_name] = lft + offset
self[right_column_name] = rgt + offset
if @parent_issue
move_to_child_of(@parent_issue)
end
end
# delete invalid relations of all descendants
self_and_descendants.each do |issue|
issue.relations.each do |relation|
relation.destroy unless relation.valid?
end
end
Eric Davis
Recalculate inherited attributes on parents when a child is moved under a new parent. #5524...
r3707 # update former parent
recalculate_attributes_for(former_parent_id) if former_parent_id
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 end
remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 def update_parent_attributes
Eric Davis
Recalculate inherited attributes on parents when a child is moved under a new parent. #5524...
r3707 recalculate_attributes_for(parent_id) if parent_id
end
def recalculate_attributes_for(issue_id)
if issue_id && p = Issue.find_by_id(issue_id)
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # priority = highest priority of children
Jean-Philippe Lang
Use :joins instead of :include in calculations....
r8262 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 p.priority = IssuePriority.find_by_position(priority_position)
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # start/due dates = lowest/highest dates of children
p.start_date = p.children.minimum(:start_date)
p.due_date = p.children.maximum(:due_date)
if p.start_date && p.due_date && p.due_date < p.start_date
p.start_date, p.due_date = p.due_date, p.start_date
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # done ratio = weighted average ratio of leaves
Eric Davis
Fixes reverting an issue to a status with a done_ratio of 0%. #5170...
r4072 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 leaves_count = p.leaves.count
if leaves_count > 0
average = p.leaves.average(:estimated_hours).to_f
if average == 0
average = 1
end
Jean-Philippe Lang
Use :joins instead of :include in calculations....
r8262 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 progress = done / (average * leaves_count)
p.done_ratio = progress.round
end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # estimate = sum of leaves estimates
p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
p.estimated_hours = nil if p.estimated_hours == 0.0
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 # ancestors will be recursively updated
Jean-Philippe Lang
Merged rails-3.2 branch....
r9346 p.save(:validate => false)
Jean-Philippe Lang
Adds subtasking (#443) including:...
r3459 end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Optimize updates of issue's shared versions....
r3023 # Update issues so their versions are not pointing to a
# fixed_version that is not shared with the issue's project
def self.update_versions(conditions=nil)
# Only need to update issues with a fixed_version from
# a different project and that is not systemwide shared
Jean-Philippe Lang
Use scoped method instead of merge_conditions....
r8170 Issue.scoped(:conditions => conditions).all(
:conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
" AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
" AND #{Version.table_name}.sharing <> 'system'",
:include => [:project, :fixed_version]
).each do |issue|
Jean-Philippe Lang
Version sharing (#465) + optional inclusion of subprojects in the roadmap view (#2666)....
r3009 next if issue.project.nil? || issue.fixed_version.nil?
unless issue.project.shared_versions.include?(issue.fixed_version)
issue.init_journal(User.current)
issue.fixed_version = nil
issue.save
end
end
end
Toshi MARUYAMA
remove trailing white-spaces except SQL from app/models/issue.rb....
r6396
Etienne Massip
Fixed comment....
r10194 # Callback on file attachment
Jean-Philippe Lang
Fixed: MailHandler does not include JournalDetail for attached files (#7966)....
r6192 def attachment_added(obj)
if @current_journal && !obj.new_record?
@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
AttachmentsController now handles attachments deletion....
r2114 # Callback on attachment deletion
def attachment_removed(obj)
Jean-Philippe Lang
Rails 3.1 compatibility....
r8953 if @current_journal && !obj.new_record?
@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
@current_journal.save
end
Jean-Philippe Lang
AttachmentsController now handles attachments deletion....
r2114 end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Fixed: journal details duplicated when an issue is saved twice (#3690)....
r3385 # Default assignment based on category
def default_assign
if assigned_to.nil? && category && category.assigned_to
self.assigned_to = category.assigned_to
end
end
# Updates start/due dates of following issues
def reschedule_following_issues
if start_date_changed? || due_date_changed?
relations_from.each do |relation|
relation.set_issue_to_dates
end
end
end
# Closes duplicates if the issue is being closed
def close_duplicates
if closing?
duplicates.each do |duplicate|
# Reload is need in case the duplicate was updated by a previous duplicate
duplicate.reload
# Don't re-close it if it's already closed
next if duplicate.closed?
# Same user and notes
if @current_journal
duplicate.init_journal(@current_journal.user, @current_journal.notes)
end
duplicate.update_attribute :status, self.status
end
end
end
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Jean-Philippe Lang
Adds closed_on column that stores the time of the last closing (#824)....
r11172 # Make sure updated_on is updated when adding a note and set updated_on now
# so we can set closed_on with the same value on closing
Jean-Philippe Lang
Fixed that updated_on is not updated when updating an issue (#10964)....
r9520 def force_updated_on_change
Jean-Philippe Lang
Adds closed_on column that stores the time of the last closing (#824)....
r11172 if @current_journal || changed?
Jean-Philippe Lang
Fixed that updated_on is not updated when updating an issue (#10964)....
r9520 self.updated_on = current_time_from_proper_timezone
Jean-Philippe Lang
Adds closed_on column that stores the time of the last closing (#824)....
r11172 if new_record?
self.created_on = updated_on
end
end
end
# Callback for setting closed_on when the issue is closed.
# The closed_on attribute stores the time of the last closing
# and is preserved when the issue is reopened.
def update_closed_on
if closing? || (new_record? && closed?)
self.closed_on = updated_on
Jean-Philippe Lang
Fixed that updated_on is not updated when updating an issue (#10964)....
r9520 end
end
Jean-Philippe Lang
Create the journal after issue save (#3140)....
r2577 # Saves the changes in a Journal
# Called after_save
def create_journal
if @current_journal
# attributes changes
Jean-Philippe Lang
Code cleanup....
r8406 if @attributes_before_change
Jean-Philippe Lang
Adds closed_on column that stores the time of the last closing (#824)....
r11172 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
Jean-Philippe Lang
Code cleanup....
r8406 before = @attributes_before_change[c]
after = send(c)
next if before == after || (before.blank? && after.blank?)
@current_journal.details << JournalDetail.new(:property => 'attr',
:prop_key => c,
:old_value => before,
:value => after)
}
end
if @custom_values_before_change
# custom fields changes
Jean-Philippe Lang
Adds support for multiselect custom fields (#1189)....
r8601 custom_field_values.each {|c|
Jean-Philippe Lang
Code cleanup....
r8406 before = @custom_values_before_change[c.custom_field_id]
after = c.value
next if before == after || (before.blank? && after.blank?)
Jean-Philippe Lang
Adds support for multiselect custom fields (#1189)....
r8601
if before.is_a?(Array) || after.is_a?(Array)
before = [before] unless before.is_a?(Array)
after = [after] unless after.is_a?(Array)
# values removed
(before - after).reject(&:blank?).each do |value|
@current_journal.details << JournalDetail.new(:property => 'cf',
:prop_key => c.custom_field_id,
:old_value => value,
:value => nil)
end
# values added
(after - before).reject(&:blank?).each do |value|
@current_journal.details << JournalDetail.new(:property => 'cf',
:prop_key => c.custom_field_id,
:old_value => nil,
:value => value)
end
else
@current_journal.details << JournalDetail.new(:property => 'cf',
:prop_key => c.custom_field_id,
:old_value => before,
:value => after)
end
Jean-Philippe Lang
Code cleanup....
r8406 }
end
Jean-Philippe Lang
Create the journal after issue save (#3140)....
r2577 @current_journal.save
Jean-Philippe Lang
Fixed: journal details duplicated when an issue is saved twice (#3690)....
r3385 # reset current journal
init_journal @current_journal.user, @current_journal.notes
Jean-Philippe Lang
Create the journal after issue save (#3140)....
r2577 end
end
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251
# Query generator for selecting groups of issue counts for a project
# based on specific criteria
#
# Options
# * project - Project to search in.
# * field - String. Issue field to key off of in the grouping.
# * joins - String. The table name to join against.
def self.count_and_group_by(options)
project = options.delete(:project)
select_field = options.delete(:field)
joins = options.delete(:joins)
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 where = "#{Issue.table_name}.#{select_field}=j.id"
Toshi MARUYAMA
remove trailing white-spaces excluding SQL from issue model source....
r5690
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 ActiveRecord::Base.connection.select_all("select s.id as status_id,
s.is_closed as closed,
j.id as #{select_field},
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 count(#{Issue.table_name}.id) as total
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 from
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 where
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 #{Issue.table_name}.status_id=s.id
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 and #{where}
Jean-Philippe Lang
Adds visibility condition to Issue.by_* count methods....
r5245 and #{Issue.table_name}.project_id=#{Project.table_name}.id
and #{visible_condition(User.current, :project => project)}
Eric Davis
Refactor: Extracted the select_all calls to a new private method....
r3251 group by s.id, s.is_closed, j.id")
end
Jean-Philippe Lang
Initial commit...
r2 end