##// END OF EJS Templates
jro_apps » redmine
RSS
scm: git: performance improvements in fetching revisions (#8857, #9472)...
scm: git: performance improvements in fetching revisions (#8857, #9472) Parse a revision for a given branch, just if we haven't parsed it for any branches before. Moved the db check to for existing revisions into a grouped search. Search for many revisions at once: this reduces db load. Revisions are grouped into sets of 100. This is to improve memory consumption. There will be just one query instead of each 100. The above two methods significantly increase parsing speed. Test case was a git repo with 6000+ commits on a master branch, and several other branches originating for master. Speed improved from 1.4h to 18min. Contributed by Gergely Fábián. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81
Jean-Philippe Lang - - Load All Authors

File last commit:

r9014:d0356fe93533
r9024:999a4ba30d7b
Show More
news_controller.rb
116 lines | 3.6 KiB | text/x-ruby | RubyLexer
/ app / controllers / news_controller.rb
History | Source | Raw |Copy content |Copy permalink
Jean-Philippe Lang
Adds email notifications support for news comments (#2074)....
 r4883 # Redmine - project management software
# Copyright (C) 2006-2011 Jean-Philippe Lang
Jean-Philippe Lang
added svn:eol-style native property on /app files...
 r330 #
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689 #
Jean-Philippe Lang
added svn:eol-style native property on /app files...
 r330 # This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689 #
Jean-Philippe Lang
added svn:eol-style native property on /app files...
 r330 # You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
class NewsController < ApplicationController
Jean-Philippe Lang
Contextual quick search (#3263)....
 r2829 default_search_scope :news
Eric Davis
Refactor: Change the different find_object filters to share a common method....
 r3483 model_object News
Eric Davis
Refactor: move NewsController#preview to PreviewsController#news...
 r4060 before_filter :find_model_object, :except => [:new, :create, :index]
before_filter :find_project_from_association, :except => [:new, :create, :index]
before_filter :find_project, :only => [:new, :create]
before_filter :authorize, :except => [:index]
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 before_filter :find_optional_project, :only => :index
Jean-Philippe Lang
Separation of RSS/API auth actions....
 r6077 accept_rss_auth :index
accept_api_auth :index
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Adds email notifications support for news comments (#2074)....
 r4883 helper :watchers
Jean-Philippe Lang
Allows attachments on news (#1972)....
 r8608 helper :attachments
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 def index
Jean-Philippe Lang
Refactor and add tests for News #index API (#7072)....
 r4391 case params[:format]
when 'xml', 'json'
@offset, @limit = api_offset_and_limit
else
@limit = 10
end
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Refactor and add tests for News #index API (#7072)....
 r4391 scope = @project ? @project.news.visible : News.visible
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Refactor and add tests for News #index API (#7072)....
 r4391 @news_count = scope.count
@news_pages = Paginator.new self, @news_count, @limit, params['page']
@offset ||= @news_pages.current.offset
@newss = scope.all(:include => [:author, :project],
:order => "#{News.table_name}.created_on DESC",
:offset => @offset,
:limit => @limit)
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 respond_to do |format|
Jean-Philippe Lang
Removed object name from form_for arguments....
 r7784 format.html {
@news = News.new # for adding news inline
render :layout => false if request.xhr?
}
Jean-Philippe Lang
Refactor and add tests for News #index API (#7072)....
 r4391 format.api
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 format.atom { render_feed(@newss, :title => (@project ? @project.name : Setting.app_title) + ": #{l(:label_news_plural)}") }
end
end
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Initial commit...
 r2 def show
Jean-Philippe Lang
Add a user preference to choose how comments/replies are displayed: in chronological or reverse chronological order (#589, #776)....
 r1183 @comments = @news.comments
@comments.reverse! if User.current.wants_comments_in_reverse_order?
Jean-Philippe Lang
Initial commit...
 r2 end
Jean-Philippe Lang
ProjectsController#add_news moved to NewsController#new....
 r1097 def new
@news = News.new(:project => @project, :author => User.current)
Eric Davis
Refactor: split NewsController#new into #new and #create methods....
 r4049 end
def create
@news = News.new(:project => @project, :author => User.current)
Jean-Philippe Lang
Prevent mass-assignment when adding/updating a news (#10390)....
 r9014 @news.safe_attributes = params[:news]
Jean-Philippe Lang
Preserve uploaded files when on news....
 r8822 @news.save_attachments(params[:attachments])
Jean-Philippe Lang
Do not check the request http method....
 r8821 if @news.save
render_attachment_warning_if_needed(@news)
flash[:notice] = l(:notice_successful_create)
redirect_to :controller => 'news', :action => 'index', :project_id => @project
else
render :action => 'new'
Jean-Philippe Lang
ProjectsController#add_news moved to NewsController#new....
 r1097 end
end
Eric Davis
Refactor: split NewsController#edit into #edit and #update...
 r4054
Jean-Philippe Lang
Initial commit...
 r2 def edit
Eric Davis
Refactor: split NewsController#edit into #edit and #update...
 r4054 end
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Eric Davis
Refactor: split NewsController#edit into #edit and #update...
 r4054 def update
Jean-Philippe Lang
Prevent mass-assignment when adding/updating a news (#10390)....
 r9014 @news.safe_attributes = params[:news]
Jean-Philippe Lang
Preserve uploaded files when on news....
 r8822 @news.save_attachments(params[:attachments])
Jean-Philippe Lang
Prevent mass-assignment when adding/updating a news (#10390)....
 r9014 if @news.save
Jean-Philippe Lang
Allows attachments on news (#1972)....
 r8608 render_attachment_warning_if_needed(@news)
Jean-Philippe Lang
notice messages translation...
 r15 flash[:notice] = l(:notice_successful_update)
Jean-Philippe Lang
Initial commit...
 r2 redirect_to :action => 'show', :id => @news
Eric Davis
Refactor: split NewsController#edit into #edit and #update...
 r4054 else
render :action => 'edit'
Jean-Philippe Lang
Initial commit...
 r2 end
end
Eric Davis
Refactor: split NewsController#edit into #edit and #update...
 r4054
Jean-Philippe Lang
indentation corrections...
 r198 def destroy
@news.destroy
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 redirect_to :action => 'index', :project_id => @project
Jean-Philippe Lang
added svn:eol-style native property on /app files...
 r330 end
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
added svn:eol-style native property on /app files...
 r330 private
Jean-Philippe Lang
ProjectsController#add_news moved to NewsController#new....
 r1097 def find_project
@project = Project.find(params[:project_id])
rescue ActiveRecord::RecordNotFound
render_404
end
Toshi MARUYAMA
remove trailing white-spaces from app/controllers/news_controller.rb....
 r6689
Jean-Philippe Lang
Moved ProjectsController#list_news to NewsController#index....
 r875 def find_optional_project
return true unless params[:project_id]
@project = Project.find(params[:project_id])
authorize
rescue ActiveRecord::RecordNotFound
render_404
end
Jean-Philippe Lang
Initial commit...
 r2 end