jro_apps/redmine Files · app/controllers/files_controller.rb

scm: git: performance improvements in fetching revisions (#8857, #9472)...

scm: git: performance improvements in fetching revisions (#8857, #9472) Parse a revision for a given branch, just if we haven't parsed it for any branches before. Moved the db check to for existing revisions into a grouped search. Search for many revisions at once: this reduces db load. Revisions are grouped into sets of 100. This is to improve memory consumption. There will be just one query instead of each 100. The above two methods significantly increase parsing speed. Test case was a git repo with 6000+ commits on a master branch, and several other branches originating for master. Speed improved from 1.4h to 18min. Contributed by Gergely Fábián. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9144 e93f8b46-1217-0410-a6f0-8f06a7374b81

Toshi MARUYAMA - - Load All Authors

File last commit:

r5717:7e308ae3751d


                r9024:999a4ba30d7b

Download file

             files_controller.rb
        
                    36 lines
            
             | 1.2 KiB
            
                | text/x-ruby
            
             |
                RubyLexer
            
             / app / controllers / files_controller.rb
          
                    History
                
                 |
                  Source
                 | Raw
                 |Copy content
                 |Copy permalink

        Eric Davis
    
Refactor: move method, ProjectsController#list_files to FilesController#index....

              r3937
            
      class FilesController < ApplicationController

        menu_item :files

        Eric Davis
    
Refactor: convert FilesController to a restful resource....

              r3971
            
        before_filter :find_project_by_project_id

        Eric Davis
    
Refactor: move method, ProjectsController#list_files to FilesController#index....

              r3937
            
        before_filter :authorize

        helper :sort

        include SortHelper

        def index

          sort_init 'filename', 'asc'

          sort_update 'filename' => "#{Attachment.table_name}.filename",

                      'created_on' => "#{Attachment.table_name}.created_on",

                      'size' => "#{Attachment.table_name}.filesize",

                      'downloads' => "#{Attachment.table_name}.downloads"

        Toshi MARUYAMA
    
remove trailing white-spaces from files controller source....

              r5717
            
        Eric Davis
    
Refactor: move method, ProjectsController#list_files to FilesController#index....

              r3937
            
          @containers = [ Project.find(@project.id, :include => :attachments, :order => sort_clause)]

          @containers += @project.versions.find(:all, :include => :attachments, :order => sort_clause).sort.reverse

          render :layout => !request.xhr?

        end

        Eric Davis
    
Refactor: move method, ProjectsController#add_file to FilesController#new....

              r3938
            
        def new

        Eric Davis
    
Refactor: split FilesController#new into #new and #create....

              r3970
            
          @versions = @project.versions.sort

        end

        Eric Davis
    
Refactor: move method, ProjectsController#add_file to FilesController#new....

              r3938
            
        Eric Davis
    
Refactor: split FilesController#new into #new and #create....

              r3970
            
        def create

          container = (params[:version_id].blank? ? @project : @project.versions.find_by_id(params[:version_id]))

          attachments = Attachment.attach_files(container, params[:attachments])

          render_attachment_warning_if_needed(container)

        Jean-Philippe Lang
    
Fixed: error on mail notification when adding an invalid file (#6452)....

              r4063
            
          if !attachments.empty? && !attachments[:files].blank? && Setting.notified_events.include?('file_added')

        Eric Davis
    
Refactor: split FilesController#new into #new and #create....

              r3970
            
            Mailer.deliver_attachments_added(attachments[:files])

        Eric Davis
    
Refactor: move method, ProjectsController#add_file to FilesController#new....

              r3938
            
          end

        Eric Davis
    
Refactor: convert FilesController to a restful resource....

              r3971
            
          redirect_to project_files_path(@project)

        Eric Davis
    
Refactor: move method, ProjectsController#add_file to FilesController#new....

              r3938
            
        end

        Eric Davis
    
Refactor: move method, ProjectsController#list_files to FilesController#index....

              r3937
            
      end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

Eric Davis Refactor: move method, ProjectsController#list_files to FilesController#index....	r3937	class FilesController < ApplicationController
		menu_item :files

Eric Davis Refactor: convert FilesController to a restful resource....	r3971	before_filter :find_project_by_project_id
Eric Davis Refactor: move method, ProjectsController#list_files to FilesController#index....	r3937	before_filter :authorize

		helper :sort
		include SortHelper

		def index
		sort_init 'filename', 'asc'
		sort_update 'filename' => "#{Attachment.table_name}.filename",
		'created_on' => "#{Attachment.table_name}.created_on",
		'size' => "#{Attachment.table_name}.filesize",
		'downloads' => "#{Attachment.table_name}.downloads"
Toshi MARUYAMA remove trailing white-spaces from files controller source....	r5717
Eric Davis Refactor: move method, ProjectsController#list_files to FilesController#index....	r3937	@containers = [ Project.find(@project.id, :include => :attachments, :order => sort_clause)]
		@containers += @project.versions.find(:all, :include => :attachments, :order => sort_clause).sort.reverse
		render :layout => !request.xhr?
		end

Eric Davis Refactor: move method, ProjectsController#add_file to FilesController#new....	r3938	def new
Eric Davis Refactor: split FilesController#new into #new and #create....	r3970	@versions = @project.versions.sort
		end
Eric Davis Refactor: move method, ProjectsController#add_file to FilesController#new....	r3938
Eric Davis Refactor: split FilesController#new into #new and #create....	r3970	def create
		container = (params[:version_id].blank? ? @project : @project.versions.find_by_id(params[:version_id]))
		attachments = Attachment.attach_files(container, params[:attachments])
		render_attachment_warning_if_needed(container)

Jean-Philippe Lang Fixed: error on mail notification when adding an invalid file (#6452)....	r4063	if !attachments.empty? && !attachments[:files].blank? && Setting.notified_events.include?('file_added')
Eric Davis Refactor: split FilesController#new into #new and #create....	r3970	Mailer.deliver_attachments_added(attachments[:files])
Eric Davis Refactor: move method, ProjectsController#add_file to FilesController#new....	r3938	end
Eric Davis Refactor: convert FilesController to a restful resource....	r3971	redirect_to project_files_path(@project)
Eric Davis Refactor: move method, ProjectsController#add_file to FilesController#new....	r3938	end
Eric Davis Refactor: move method, ProjectsController#list_files to FilesController#index....	r3937	end